On 9/28/20 4:27 AM, Joakim Zhang wrote:
>> If it's OK on all SoCs to initialize the complete RAM area, just do it. Then
>> we can
>> get rid of the proposed struct at all.
>
> Should be OK according to IP guys feedbacks.
Good!
> static const struct flexcan_devtype_data fsl_vf610_devtype_data =
Hello,
syzbot found the following issue on:
HEAD commit:05943249 net: atlantic: fix build when object tree is sepa..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=1343b90990
kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7
dashboar
From: Bartosz Golaszewski
It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV - we
still want to finalize the registration of the ixgbe device. Check the
error code and don't bail out if err == -ENODEV.
This fixes an issue on C3000 family of SoCs where four ixgbe devices
share a sin
Hello,
syzbot found the following issue on:
HEAD commit:5e46e43c MAINTAINERS: Add Vladimir as a maintainer for DSA
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=168d5a8790
kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7
dashboard
Hello,
syzbot found the following issue on:
HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=105fbac590
kernel config: https://syzkaller.appspot.com/x/.config?x=af502ec9a451c9fc
das
Hello,
syzbot found the following issue on:
HEAD commit:ad2b9b0f tcp: skip DSACKs with dubious sequence ranges
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=13baee3d90
kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97
dashboard link
+ Uffe
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
@@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st
brcmf_dbg(INTR, "IB intr triggered\n");
- brcmf_sdio_isr(sdiodev->bus);
+ brcmf_sdio_isr(sdiodev->bus, false);
}
Hi Uffe,
I assume the above code is okay, but want
Hello,
syzbot found the following issue on:
HEAD commit:307eea32 dt-bindings: net: renesas,ravb: Add support for r..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=13b7e29d90
kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7
dashboar
Hello,
syzbot found the following issue on:
HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15d1a80990
kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7
das
Hello,
syzbot found the following issue on:
HEAD commit:05943249 net: atlantic: fix build when object tree is sepa..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=1505450990
kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7
dashboar
On Fri, Sep 25, 2020 at 11:49:13AM -0500, Gustavo A. R. Silva wrote:
> Calls to kzalloc() and kvzalloc() should be null-checked
> in order to avoid any potential failures. In this case,
> a potential null pointer dereference.
>
> Fix this by adding null checks for _parse_attr_ and _flow_
> right af
On Sun, Sep 27, 2020 at 12:32:52PM +0100, Alex Dewar wrote:
> The variable flow is used after being allocated but before being
> null-checked, which will cause a null pointer dereference if the
> allocation failed. Fix this and tidy up the error-checking logic in this
> function.
>
> Addresses-Cove
On Sun, Sep 27, 2020 at 12:32:53PM +0100, Alex Dewar wrote:
> If the call to mlx5_fc_create() fails, then shared_counter will be freed
> before its member, shared_counter->counter, is accessed to retrieve the
> error code. Fix by using an intermediate variable.
>
> Addresses-Coverity: CID 1497153:
Hello,
syzbot found the following issue on:
HEAD commit:c9c9e6a4 Merge tag 'trace-v5.9-rc5-2' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13a34b1d90
kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97
das
From: Florian Fainelli
Date: Sun, 27 Sep 2020 19:31:50 -0700
> After commit d0186842ec5f ("net: vlan: Avoid using BUG() in
> vlan_proto_idx()"), vlan_proto_idx() was changed to return a signed
> integer, however one of its called: vlan_group_prealloc_vid() was still
> using an unsigned integer fo
On Sun, Sep 27, 2020 at 10:57:24AM +0200, Dmitry Vyukov wrote:
> On Thu, Oct 31, 2019 at 9:39 PM syzbot
> wrote:
> >
> > syzbot has found a reproducer for the following crash on:
> >
> > HEAD commit:49afce6d Add linux-next specific files for 20191031
> > git tree: linux-next
> > console
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月28日 15:01
> To: Joakim Zhang ; linux-...@vger.kernel.org;
> Pankaj Bansal
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC f
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.
brcmfmac uses in_interupt() to selec
On 9/28/20 9:58 AM, Joakim Zhang wrote:
>> Can someone check the vf610, too?
>
> I check the VF610 RM just now, indeed it has ECC feature, there is also a
> NOTE in "12.1.4.13 Detection and Correction of Memory Errors" section:
>
> All FlexCAN memory must be initialized before starting its
> ope
We're excited to announce that the call for proposals is now open for the
inaugural
eBPF Summit, a virtual event, targeted at DevOps, platform architects and
developers.
The goal is to have a gathering of users or potential users of eBPF(/XDP) as
well as
developers in order to exchange ideas,
From: YueHaibing
If CONFIG_INET_XFRM_TUNNEL is set but CONFIG_IPV6 is n,
net/ipv4/ip_vti.c:493:27: warning: 'vti_ipip6_handler' defined but not used
[-Wunused-variable]
Signed-off-by: YueHaibing
Signed-off-by: Steffen Klassert
---
net/ipv4/ip_vti.c | 2 ++
1 file changed, 2 insertions(+)
d
From: Antony Antony
XFRMA_SEC_CTX was not cloned from the old to the new.
Migrate this attribute during XFRMA_MSG_MIGRATE
v1->v2:
- return -ENOMEM on error
v2->v3:
- fix return type to int
Fixes: 80c9abaabf42 ("[XFRM]: Extension for dynamic update of endpoint
address(es)")
Signed-off-by: Ant
1) Fix a build warning in ip_vti if CONFIG_IPV6 is not set.
From YueHaibing.
2) Restore IPCB on espintcp before handing the packet to xfrm
as the information there is still needed.
From Sabrina Dubroca.
3) Fix pmtu updating for xfrm interfaces.
From Sabrina Dubroca.
4) Some xfrm stat
From: Antony Antony
When we clone state only add_time was cloned. It missed values like
bytes, packets. Now clone the all members of the structure.
v1->v3:
- use memcpy to copy the entire structure
Fixes: 80c9abaabf42 ("[XFRM]: Extension for dynamic update of endpoint
address(es)")
Signed-of
From: Sabrina Dubroca
xfrm interfaces currently test for !skb->ignore_df when deciding
whether to update the pmtu on the skb's dst. Because of this, no pmtu
exception is created when we do something like:
ping -s 1438
By dropping this check, the pmtu exception will be created and the
next
From: Herbert Xu
The struct flowi must never be interpreted by itself as its size
depends on the address family. Therefore it must always be grouped
with its original family value.
In this particular instance, the original family value is lost in
the function xfrm_state_find. Therefore we get
From: Sabrina Dubroca
Xiumei reported a bug with espintcp over IPv6 in transport mode,
because xfrm6_transport_finish expects to find IP6CB data (struct
inet6_skb_cb). Currently, espintcp zeroes the CB, but the relevant
part is actually preserved by previous layers (first set up by tcp,
then strp
From: Antony Antony
XFRMA_REPLAY_ESN_VAL was not cloned completely from the old to the new.
Migrate this attribute during XFRMA_MSG_MIGRATE
v1->v2:
- move curleft cloning to a separate patch
Fixes: af2f464e326e ("xfrm: Assign esn pointers when cloning a state")
Signed-off-by: Antony Antony
Si
From: Antony Antony
XFRMA_SET_MARK and XFRMA_SET_MARK_MASK was not cloned from the old
to the new. Migrate these two attributes during XFRMA_MSG_MIGRATE
Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction
and masking.")
Signed-off-by: Antony Antony
Signed-off-by: Stef
On Mon, Sep 28, 2020 at 5:41 AM wrote:
>
> From: Tonghao Zhang
>
> Open vSwitch and Linux bridge will disable LRO of the interface
> when this interface added to them. Now when disable the LRO, the
> virtio-net csum is disable too. That drops the forwarding performance.
>
> Fixes: e59ff2c49ae1 ("
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月28日 16:21
> To: Joakim Zhang ; linux-...@vger.kernel.org;
> Pankaj Bansal
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC f
We are seeing the following error after S3 resume:
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete
[ 704.902817] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.903075] e1000e :00:1f.6 eno1: reading PHY page
On 9/28/20 10:36 AM, Joakim Zhang wrote:
> Could I send out a V3 to review firstly, then wait Pankaj have time to do the
> test?
sure, go ahead.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung We
On Mon, Sep 28, 2020 at 5:42 AM wrote:
>
> From: Tonghao Zhang
>
> Allow user configuring RXCSUM separately with ethtool -K,
> reusing the existing virtnet_set_guest_offloads helper
> that configures RXCSUM for XDP. This is conditional on
> VIRTIO_NET_F_CTRL_GUEST_OFFLOADS.
>
> Cc: Michael S. Tsi
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config'
has no member named 'auto_start'
27 | .auto_start = false,
|^~
drivers/net/wireless/ath/ath11
Hello,
On Sat, 2020-09-26 at 16:22 +0200, Hannes Frederic Sowa wrote:
> On Sat, Sep 26, 2020, at 01:50, Wei Wang wrote:
> > I took a look at the current "threadirqs" implementation. From my
> > understanding, the kthread used there is to handle irq from the
> > driver, and needs driver-specific th
On Wed, Sep 16, 2020 at 11:48:06AM +0800, Boqun Feng wrote:
> This patchset add the necessary changes to support guests whose page
> size is larger than 4K. And the main architecture which we develop this
> for is ARM64 (also it's the architecture that I use to test this
> feature).
>
> Previous v
Adds the missing .stop entry in the Belkin driver_info structure.
Signed-off-by: Wilken Gottwalt
---
Changes in v2:
- reposted to proper mailing list
---
drivers/net/usb/ax88179_178a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax8817
From: He Zhe
The user defined label following "fallthrough" is not considered by GCC
and causes build failure.
kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute
'fallthrough' not preceding a case label or default label [-Werror]
208 define fallthrough _attribute((fall
On Fri, 25 Sep 2020 at 22:54, Martin KaFai Lau wrote:
>
> > + if (unlikely(!sk))
> sk_fullsock(sk) test is also needed.
>
> > + return -EINVAL;
>
> > +
> > if (!sock_map_sk_is_suitable(sk))
> sk->sk_type is used in sock_map_sk_is_suitable().
> sk_type is not in sock_common.
Changes in v2:
- Check sk_fullsock in map_update_elem (Martin)
Enable calling map_update_elem on sockmaps from bpf_iter context. This
in turn allows us to copy a sockmap by iterating its elements.
The change itself is tiny, all thanks to the ground work from Martin,
whose series [1] this patch is
The shared header to define SOCKMAP_MAX_ENTRIES is a bit overkill.
Dynamically allocate the sock_fd array based on bpf_map__max_entries
instead.
Suggested-by: Yonghong Song
Signed-off-by: Lorenz Bauer
Acked-by: Yonghong Song
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 36 +-
Allow passing a pointer to a BTF struct sock_common* when updating
a sockmap or sockhash. Since BTF pointers can fault and therefore be
NULL at runtime we need to add an additional !sk check to
sock_map_update_elem. Since we may be passed a request or timewait
socket we also need to check sk_fullso
This code frees "shared_counter" and then dereferences on the next line
to get the error code.
Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 4 +++-
1 file changed, 3 insertion
Since we can now call map_update_elem(sockmap) from bpf_iter context
it's possible to copy a sockmap or sockhash in the kernel. Add a
selftest which exercises this.
Signed-off-by: Lorenz Bauer
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 14 +-
.../selftests/bpf/progs/bpf_iter_soc
We compare socket cookies to ensure that insertion into a sockmap worked.
Pull this out into a helper function for use in other tests.
Signed-off-by: Lorenz Bauer
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 50 +--
1 file changed, 36 insertions(+), 14 deletions(-)
diff -
Hi,
On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
> mhi_channel_config' has no member named 'auto_start
Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB
3.0 ethernet adapter.
Signed-off-by: Wilken Gottwalt
---
drivers/net/usb/ax88179_178a.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
in
On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel
wrote:
>
> + Uffe
>
> On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
> > @@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st
> >
> > brcmf_dbg(INTR, "IB intr triggered\n");
> >
> > - brcmf_sdio_isr(sdiodev->bus);
> > + brcmf_sdio_is
On Mon, Sep 28, 2020 at 4:35 PM Willem de Bruijn
wrote:
>
> On Mon, Sep 28, 2020 at 5:41 AM wrote:
> >
> > From: Tonghao Zhang
> >
> > Open vSwitch and Linux bridge will disable LRO of the interface
> > when this interface added to them. Now when disable the LRO, the
> > virtio-net csum is disab
On Mon, Sep 28, 2020 at 4:39 PM Willem de Bruijn
wrote:
>
> On Mon, Sep 28, 2020 at 5:42 AM wrote:
> >
> > From: Tonghao Zhang
> >
> > Allow user configuring RXCSUM separately with ethtool -K,
> > reusing the existing virtnet_set_guest_offloads helper
> > that configures RXCSUM for XDP. This is
Hi Manivannan,
On Mon, 28 Sep 2020 14:40:35 +0530 Manivannan Sadhasivam
wrote:
>
> But your change looks good and I can just modify the subject/description and
> resubmit. Or if Dave prefers to fix the original commit itself in net-next,
> I'm fine!
Dave never rebase the net-next tree, so a new
On 9/27/2020 10:47 AM, Dmitry Vyukov wrote:
On Sun, Sep 27, 2020 at 10:38 AM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:748d1c8a Merge branch 'devlink-Use-nla_policy-to-validate-..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt
This fixes a regression for blocking connects introduced by commit
4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect").
The x25->neighbour is already set to "NULL" by x25_disconnect() now,
while a blocking connect is waiting in
x25_wait_for_connection_establishment(). Therefore
On Mon, Sep 21, 2020 at 03:36:50PM +0100, Dmitry Safonov wrote:
> Changes since v2:
> - added struct xfrm_translator as API to register xfrm_compat.ko with
> xfrm_state.ko. This allows compilation of translator as a loadable
> module
> - fixed indention and collected reviewed-by (Johannes Berg)
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be seperated or the context be conveyed in an argument passed by the
Manivannan Sadhasivam writes:
> On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> mhi_channel_conf
On 9/28/2020 11:19 AM, Ulf Hansson wrote:
On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel
wrote:
+ Uffe
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
@@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st
brcmf_dbg(INTR, "IB intr triggered\n");
- brcmf_sdio_isr(sdiodev->bus);
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
brcmf_sdio_isr() is using in_interrupt() to distinguish if it is called
from a interrupt service routine or from a worker thread.
Passing such information from the calling context is preferred and
requested by Linus,
On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
> Manivannan Sadhasivam writes:
>
> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >>
Add flexcan driver for i.MX8MP, which supports CAN FD and ECC.
Signed-off-by: Joakim Zhang
---
ChangeLogs:
V1->V2:
* sort the order of the quirks by their value.
V2->V3:
* add FLEXCAN_QUIRK_SUPPORT_ECC for i.MX8MP.
---
drivers/net/can/flexcan.c | 9 +
1 file changed, 9 in
One issue was reported at a baremetal environment, which is used for
FPGA verification. "The first transfer will fail for extended ID
format(for both 2.0B and FD format), following frames can be transmitted
and received successfully for extended format, and standard format don't
have this issue. Th
Disable runtime PM if register flexcandev failed, and balance reference
of usage_count.
Signed-off-by: Joakim Zhang
---
ChangeLogs:
V1->V3:
* no changes.
---
drivers/net/can/flexcan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexca
Hi Marc,
ECC is enabled by default if SoCs support this feature, so I think the
common solution is to initialize all flexcan memory for these SoCs. For
that, I create FLEXCAN_QUIRK_SUPPORT_ECC quirk to add this feature, then
users can decide to whether select FLEXCAN_QUIRK_DISABLE_MECR qurik or no
From: Rusaimi Amira Ruslan
Adding reference clock (1us tic) for all LPI timer on Intel platforms.
The reference clock is derived from ptp clk. This also enables all LPI
counter.
Signed-off-by: Rusaimi Amira Ruslan
Signed-off-by: Voon Weifeng
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel
Recent change in MHI bus removed the option to auto start the channels
during MHI driver probe. The channel will only be started when the MHI
client driver like QRTR gets probed. So, remove the option from ath11k
channel config struct.
Fixes: 1399fb87ea3e ("ath11k: register MHI controller device f
Use devm_alloc_etherdev() to simplify the code instead of alloc_etherdev().
Signed-off-by: Kunihiko Hayashi
---
drivers/net/ethernet/socionext/sni_ave.c | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/net/ethernet/socionext/sni_ave.c
hello,
On Fri, 2020-09-25 at 22:45 +0300, Vlad Buslov wrote:
> On Fri 25 Sep 2020 at 22:22, Cong Wang wrote:
> > On Fri, Sep 25, 2020 at 8:24 AM Vlad Buslov wrote:
> > > > + if (TC_ACT_EXT_CMP(a->tcfa_action, TC_ACT_GOTO_CHAIN) &&
> > > > + !rcu_access_pointer(a->goto_chain)) {
> > >
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
and LiFi-XL USB devices, which provide lightweight, highspeed secure and
fully networked wireless communications via light.
This driver implementation has been based on the zd1211rw driver
Driver is based on 802.11 softMAC Architecture
On Sun, Sep 27 2020 at 13:57, David Miller wrote:
> From: Thomas Gleixner
> Date: Sun, 27 Sep 2020 21:48:46 +0200
>
>> in the discussion about preempt count consistency accross kernel
>> configurations:
>
> Please respin this against net-next, some of the patches in here are already
> in net-nex
On 9/28/2020 12:04 PM, Dmitry Vyukov wrote:
On Mon, Sep 28, 2020 at 11:31 AM Arend Van Spriel
wrote:
On 9/27/2020 10:47 AM, Dmitry Vyukov wrote:
On Sun, Sep 27, 2020 at 10:38 AM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:748d1c8a Merge branch 'devlink-Use-n
Get rid of bpf_cpu_map_entry pointer in cpu_map_build_skb routine
signature since it is no longer needed
Signed-off-by: Lorenzo Bianconi
---
kernel/bpf/cpumap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c
index 7e1a8ad0c32a..
It will be used later for BPF structure display support
Signed-off-by: Alan Maguire
---
include/linux/bpf.h | 2 ++
kernel/bpf/verifier.c | 18 --
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index 7990232..2eae3f3 1
A helper is added to support tracing kernel type information in BPF
using the BPF Type Format (BTF). Its signature is
long bpf_snprintf_btf(char *str, u32 str_size, struct btf_ptr *ptr,
u32 btf_ptr_size, u64 flags);
struct btf_ptr * specifies
- a pointer to the data to be
This series attempts to provide a simple way for BPF programs (and in
future other consumers) to utilize BPF Type Format (BTF) information
to display kernel data structures in-kernel. The use case this
functionality is applied to here is to support a snprintf()-like
helper to copy a BTF representa
generalize the "seq_show" seq file support in btf.c to support
a generic show callback of which we support two instances; the
current seq file show, and a show with snprintf() behaviour which
instead writes the type data to a supplied string.
Both classes of show function call btf_type_show() with
bpf iter size increase to PAGE_SIZE << 3 means overflow tests assuming
page size need to be bumped also.
Signed-off-by: Alan Maguire
---
tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/bp
A helper is added to allow seq file writing of kernel data
structures using vmlinux BTF. Its signature is
long bpf_seq_printf_btf(struct seq_file *m, struct btf_ptr *ptr,
u32 btf_ptr_size, u64 flags);
Flags and struct btf_ptr definitions/use are identical to the
bpf_snpri
Tests verifying snprintf()ing of various data structures,
flags combinations using a tp_btf program. Tests are skipped
if __builtin_btf_type_id is not available to retrieve BTF
type ids.
Signed-off-by: Alan Maguire
---
.../selftests/bpf/prog_tests/snprintf_btf.c| 60 +
.../selftests
BPF iter size is limited to PAGE_SIZE; if we wish to display BTF-based
representations of larger kernel data structures such as task_struct,
this will be insufficient.
Suggested-by: Alexei Starovoitov
Signed-off-by: Alan Maguire
---
kernel/bpf/bpf_iter.c | 4 ++--
1 file changed, 2 insertions(+
Add a test verifying iterating over tasks and displaying BTF
representation of task_struct succeeds.
Suggested-by: Alexei Starovoitov
Signed-off-by: Alan Maguire
---
tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 74 ++
.../selftests/bpf/progs/bpf_iter_task_btf.c
From: "Vineetha G. Jaya Kumaran"
Ethtool manual stated that the tx-timer is the "the amount of time the
device should stay in idle mode prior to asserting its Tx LPI". The
previous implementation for "ethtool --set-eee tx-timer" sets the LPI TW
timer duration which is not correct.
Hence, this pa
On Mon, Sep 28, 2020 at 12:05:56PM +0300, Dan Carpenter wrote:
> This code frees "shared_counter" and then dereferences on the next line
> to get the error code.
>
> Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both
> directions")
> Signed-off-by: Dan Carpenter
> ---
> drivers/n
On Mon, 2020-09-28 at 15:49 +0530, Srinivasan Raju wrote:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices, which provide lightweight, highspeed secure and
> fully networked wireless communications via light.
trivial notes:
> diff --git a/drivers/net/wirele
On Sat, Sep 19, 2020 at 05:54:05PM +0200, Pablo Neira Ayuso wrote:
> Would you redo these numbers using this ruleset to address Daniel's
> comments regarding performance?
>
> Moreover, Daniel also suggested dev_direct_xmit() path from AF_PACKET
> allows packets to escape from policy, it seems this
> From: Stephen Rothwell
> Date: Mon, 28 Sep 2020 12:42:10 +1000
> Subject: [PATCH] merge fix for "mdio: fix mdio-thunder.c dependency & build
> error"
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/net/mdio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mdi
When the IOTLB device is enabled, the vring addresses we get from
userspace are GIOVAs. It is thus wrong to pass them to vq_access_ok()
which only takes HVAs. The IOTLB map is likely empty at this stage,
so there isn't much that can be done with these GIOVAs. Access validation
will be performed at
When an L2TPv3 session receives a data frame with an incorrect cookie
l2tp_core logs a warning message and bumps a stats counter to reflect
the fact that the packet has been dropped.
However, the stats counter in question is missing from the l2tp_netlink
get message for tunnel and session instance
> Didn't look at the rest
Thanks for your comments Joe, I will refactor the code for clarity, remove
redundancy and address your comments.
Regards
Srini
The fr_hard_header function is used to prepend the header to skbs before
transmission. It is used in 3 situations:
1) When a control packet is generated internally in this driver;
2) When a user sends an skb on an Ethernet-emulating PVC device;
3) When a user sends an skb on a normal PVC device.
T
On Sat, Sep 26, 2020 at 08:52:17PM +0200, Marek Vasut wrote:
> On 9/9/20 10:38 AM, Richard Leitner wrote:
> > On Fri, Sep 04, 2020 at 09:23:26PM +0200, Marek Vasut wrote:
> >> On 9/4/20 9:02 PM, Richard Leitner wrote:
> >>> On Fri, Sep 04, 2020 at 05:26:14PM +0200, Marek Vasut wrote:
> On 9/4/
Hei Marek,
Am Sonntag, 27. September 2020, 02:52:58 CEST schrieb Marek Behun:
> On Sun, 27 Sep 2020 00:40:25 +0200
>
> Marek Behun wrote:
> > What I am wondering is how should we select a name for the device part
> > of the LED for network devices, when network namespaces are enabled.
> >
> > a
On Fri, Sep 25, 2020 at 9:06 PM Jakub Kicinski wrote:
>
> On Fri, 25 Sep 2020 15:48:35 +0200 Magnus Karlsson wrote:
> > I really like this RFC and would encourage you to submit it as a
> > patch. Would love to see it make it into the kernel.
> >
> > I see the same positive effects as you when tryi
On Thu, 24 Sep 2020, Alexei Starovoitov wrote:
> to whatever number, but printing single task_struct needs ~800 lines and
> ~18kbytes. Humans can scroll through that much spam, but can we make it less
> verbose by default somehow?
> May be not in this patch set, but in the follow up?
>
One app
On Sun, Sep 27 2020 at 16:04, Hillf Danton wrote:
> Sat, 26 Sep 2020 17:38:16 -0700
>
> Dunno if it's down to memory barrier.
>
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -929,7 +929,7 @@ u64 hrtimer_forward(struct hrtimer *time
> if (delta < 0)
> return 0;
On Mon, Sep 28, 2020 at 5:13 AM David Ahern wrote:
>
> On 2/27/20 2:41 AM, Magnus Karlsson wrote:
> > I will unfortunately be after Netdevconf due to other commitments. The
> > plan is to send out the RFC to the co-authors of the Plumbers
> > presentation first, just to check the sanity of it. And
For those locations where we use an immediate tail call map index use the
newly added bpf_tail_call_static() helper.
Signed-off-by: Daniel Borkmann
---
samples/bpf/sockex3_kern.c| 20 +++--
tools/testing/selftests/bpf/progs/bpf_flow.c | 12
tools/testing/sel
Add a small test that excercises the new redirect_neigh() helper for the
IPv4 and IPv6 case.
Signed-off-by: Daniel Borkmann
---
.../selftests/bpf/progs/test_tc_neigh.c | 144 +++
tools/testing/selftests/bpf/test_tc_neigh.sh | 168 ++
2 files changed, 312 insert
This series adds two BPF helpers, that is, one for retrieving the classid
of an skb and another one to redirect via the neigh subsystem, and improves
also the cookie helpers by removing the atomic counter. I've also added
the bpf_tail_call_static() helper to the libbpf API that we've been using
in
Port of tail_call_static() helper function from Cilium's BPF code base [0]
to libbpf, so others can easily consume it as well. We've been using this
in production code for some time now. The main idea is that we guarantee
that the kernel's BPF infrastructure and JIT (here: x86_64) can patch the
JIT
1 - 100 of 381 matches
Mail list logo