I agree with you. I will write a separate new test. In the meanwhile I think it
should be okay to prepare and send just one patch.
Thanks
Bimmy
-Original Message-
From: Andrii Nakryiko
Sent: Thursday, September 24, 2020 1:22 PM
To: Pujari, Bimmy
Cc: bpf ; Networking ;
mche...@kernel.
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch added a new helper named mptcp_destroy_common containing the
shared code between mptcp_destroy() and mptcp_sock_destruct().
Suggested-by: Paolo Abeni
Signed-off-by: Geliang Tang
---
net/mptcp/protocol.c | 11 ---
net/mptcp/protocol.h
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch added a new cfg, named cfg_remove in mptcp_connect. This new
cfg_remove is copied from cfg_join. The only difference between them is in
the do_rnd_write function. Here we slow down the transfer process of all
data to let the RM_ADDR suboption c
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch added the remove addr and subflow test cases and two new
functions.
The first function run_remove_tests calls do_transfer with two new
arguments, rm_nr_ns1 and rm_nr_ns2, for the numbers of addresses should be
removed during the transfer proce
On Thu, 24 Sep 2020, Geliang Tang wrote:
Add a new struct mptcp_pm_add_entry to describe add_addr's entry.
Acked-by: Paolo Abeni
Signed-off-by: Geliang Tang
---
net/mptcp/pm_netlink.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Reviewed-by: Mat Martineau
--
M
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch added a new helper sk_stop_timer_sync, it deactivates a timer
like sk_stop_timer, but waits for the handler to finish.
Acked-by: Paolo Abeni
Signed-off-by: Geliang Tang
---
include/net/sock.h | 2 ++
net/core/sock.c| 7 +++
2 files cha
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch implemented the retransmition of ADD_ADDR when no ADD_ADDR echo
is received. It added a timer with the announced address. When timeout
occurs, ADD_ADDR will be retransmitted.
Suggested-by: Mat Martineau
Suggested-by: Paolo Abeni
Acked-by: Pa
While we should always make sure that we specify a valid VLAN protocol
to vlan_proto_idx(), killing the machine when an invalid value is
specified is too harsh and not helpful for debugging. All callers are
capable of dealing with an error returned by vlan_proto_idx() so check
the index value and p
From: Yufeng Mo
In hns3_process_hw_error(), the hardware error detection of the
ROCEE AXI RESP error type is added. When this error occurs,
the client needs to be notified of this error and take
corresponding operation.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
drivers/net/ethe
From: Yufeng Mo
If a variable is assigned a value before it is used, it's no
need to assign an initial value to the variable. So remove
these redundant operations.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c| 2 +-
driver
From: Guangbin Huang
VF devices do not have speed division, its speed is depended on its PF.
So macro name of PCI device id of VF is incorrent to have 100G info, it
should be renamed by removing 100G info.
Signed-off-by: Guangbin Huang
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisi
From: Yufeng Mo
Remove some unnecessary parameters of hclge_title_idx_print(),
and rename this function for readability.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c| 15 +--
1 file changed, 5 insertions(+), 10
From: Guangbin Huang
The 200G device has a new device id 0xA228, so adds this device id to
pci table, then the driver can probe it.
As speed_ability queried from firmware has only 8 bits and already be
used up, so firmware adds extra speed_ability_ext to indicate more
speed abilities to support
From: Yufeng Mo
The pf's interrupt resources will be changed with the number of
enabled pf. Dumping this resource information will be helpful
for debugging.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 +
drivers/net/
There are some updates for the HNS3 ethernet driver.
#1 & #2 are two cleanups.
#3 adds new hardware error for the client.
#4 adds debugfs support the pf's interrupt resource.
#5 adds new pci device id for 200G device.
#6 renames the unsuitable macro of vf's pci device id.
Guangbin Huang (2):
net
On Thu, 24 Sep 2020, Geliang Tang wrote:
This patch implemented the local subflow removing function,
mptcp_pm_remove_subflow, it simply called mptcp_pm_nl_rm_subflow_received
under the PM spin lock.
We use mptcp_pm_remove_subflow to remove a local subflow, so change it's
argument from remote_id
On Wed, Sep 23, 2020 at 06:46:24PM +0100, Alan Maguire wrote:
>
> +/* Chunk size we use in safe copy of data to be shown. */
> +#define BTF_SHOW_OBJ_SAFE_SIZE 256
sizeof(struct btf_show) == 472
It's allocated on stack and called from bpf prog.
It's a leaf function, but it still wor
On Wed, Sep 23, 2020 at 06:46:25PM +0100, Alan Maguire wrote:
> +
> +static int bpf_btf_printf_prepare(struct btf_ptr *ptr, u32 btf_ptr_size,
> + u64 flags, const struct btf **btf,
> + s32 *btf_id)
> +{
> + u8 btf_kind = BTF_KIND_TYPED
On Wed, Sep 23, 2020 at 06:46:26PM +0100, Alan Maguire wrote:
> +static int __strncmp(const void *m1, const void *m2, size_t len)
> +{
> + const unsigned char *s1 = m1;
> + const unsigned char *s2 = m2;
> + int i, delta = 0;
> +
> +#pragma clang loop unroll(full)
Shouldn't be needed?
T
Song Liu wrote:
> This test runs test_run for raw_tracepoint program. The test covers ctx
> input, retval output, and running on correct cpu.
>
> Signed-off-by: Song Liu
> ---
[...]
> +void test_raw_tp_test_run(void)
> +{
> + struct bpf_prog_test_run_attr test_attr = {};
> + int comm_fd
On Thu, Sep 24, 2020 at 09:38:09AM +0100, Lorenz Bauer wrote:
> On Wed, 23 Sep 2020 at 18:06, Martin KaFai Lau wrote:
> >
> > On Wed, Sep 23, 2020 at 10:27:27AM +0100, Lorenz Bauer wrote:
> > > On Tue, 22 Sep 2020 at 19:26, Martin KaFai Lau wrote:
> > > >
> > > > On Tue, Sep 22, 2020 at 10:46:41A
On Wed, Sep 23, 2020 at 06:46:28PM +0100, Alan Maguire wrote:
> Add a test verifying iterating over tasks and displaying BTF
> representation of data succeeds. Note here that we do not display
> the task_struct itself, as it will overflow the PAGE_SIZE limit on seq
> data; instead we write task->f
From: Cong Wang
Date: Tue, 22 Sep 2020 20:56:22 -0700
> This patchset fixes a use-after-free triggered by syzbot. Please
> find more details in each patch description.
Series applied and queued up for -stable, thanks Cong.
From: Vladimir Oltean
Date: Wed, 23 Sep 2020 14:24:20 +0300
> Currently, ocelot switchdev passes the skb directly to the function that
> enqueues it to the list of skb's awaiting a TX timestamp. Whereas the
> felix DSA driver first clones the skb, then passes the clone to this
> queue.
>
> This
From: Ioana Ciornei
Date: Wed, 23 Sep 2020 18:41:20 +0300
> This patch set aims to add PCS support in the dpaa2-eth driver by
> leveraging the Lynx PCS module.
>
> The first two patches are some missing pieces: the first one adding
> support for 10GBASER in Lynx PCS while the second one adds a n
From: Xie He
Date: Wed, 23 Sep 2020 11:18:18 -0700
> 1.
> Move the lapb_register/lapb_unregister calls into the ndo_open/ndo_stop
> functions.
> This makes the LAPB protocol start/stop when the network interface
> starts/stops. When the network interface is down, the LAPB protocol
> shouldn't be
From: Maciej Żenczykowski
Date: Wed, 23 Sep 2020 13:18:15 -0700
> From: Maciej Żenczykowski
>
> Documentation/networking/ip-sysctl.txt:46 says:
> ip_forward_use_pmtu - BOOLEAN
> By default we don't trust protocol path MTUs while forwarding
> because they could be easily forged and can
From: sa...@kernel.org
Date: Wed, 23 Sep 2020 15:48:09 -0700
> This series adds the support for connection tracking in NIC mode,
> and attached to this series some trivial cleanup patches.
> v1->v2:
> - Remove "fixup!" comment from commit message (Jakub)
> - More information and use case descrip
From: Geliang Tang
Date: Thu, 24 Sep 2020 08:29:46 +0800
> This series include two enhancements for the MPTCP path management,
> namely RM_ADDR support and ADD_ADDR echo support, as specified by RFC
> sections 3.4.1 and 3.4.2.
>
> 1 RM_ADDR support include 9 patches (1-3 and 8-13):
>
> Patch 1
This reverts commit 09ef193fef7efb0175a04634853862d717adbb95.
For C3000 family of SoCs, they have four ixgbe devices sharing a single MDIO
bus.
ixgbe_mii_bus_init() returns -ENODEV for other three devices. The propagation
of the error code makes other three ixgbe devices unregistered.
Signed-off
From: Xiaoliang Yang
Date: Thu, 24 Sep 2020 09:57:46 +0800
> state->speed holds a value of 10, 100, 1000 or 2500, but
> QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the
> speed to a proper value.
>
> Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler vi
> On Sep 24, 2020, at 6:01 PM, John Fastabend wrote:
>
> Song Liu wrote:
>> This test runs test_run for raw_tracepoint program. The test covers ctx
>> input, retval output, and running on correct cpu.
>>
>> Signed-off-by: Song Liu
>> ---
>
> [...]
>
>> +void test_raw_tp_test_run(void)
>> +
From: Luo bin
Date: Thu, 24 Sep 2020 09:31:51 +0800
> It should also be regarded as an error when hw return status=4 for PF's
> setting mac cmd. Only if PF return status=4 to VF should this cmd be
> taken special treatment.
>
> Fixes: 7dd29ee12865 ("hinic: add sriov feature support")
> Signed-of
From: Xiaoliang Yang
Date: Thu, 24 Sep 2020 10:11:13 +0800
> INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3.
> This register is used by stream gate control of PSFP, and it has not
> been used before, because PSFP is not implemented in ocelot driver.
>
> Signed-off-by: Xia
From: Wang Qing
Date: Thu, 24 Sep 2020 14:50:24 +0800
> Modify the comment typo: "compliment" -> "complement".
>
> Signed-off-by: Wang Qing
Applied, thank you.
From: Rohit Maheshwari
Date: Thu, 24 Sep 2020 12:28:45 +0530
> BUG: kernel NULL pointer dereference, address: 00b8
...
> RIP: 0010:tx_work_handler+0x1b/0x70 [tls]
...
> Call Trace:
> process_one_work+0x1a7/0x370
> worker_thread+0x30/0x370
> ? process_one_work+0x370/0x370
>
On Mon, Sep 21, 2020 at 07:56:20AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:eb5f95f1 Merge tag 's390-5.9-6' of git://git.kernel.org/pu..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=13996ad590
> kernel
From: Helmut Grohne
Date: Thu, 24 Sep 2020 10:37:47 +0200
> The previous implementation failed to account for the "ports" node. The
> actual port nodes are not child nodes of the switch node, but a "ports"
> node sits in between.
>
> Fixes: edecfa98f602 ("net: dsa: microchip: look for phy-mode i
From: Jamie Iles
Date: Thu, 24 Sep 2020 15:56:45 +0100
> MDIO reads can happen during PHY probing, and printing an error with
> dev_err can result in a large number of error messages during device
> probe. On a platform with a serial console this can result in
> excessively long boot times in a
From: Priyaranjan Jha
Date: Thu, 24 Sep 2020 15:23:14 -0700
> From: Priyaranjan Jha
>
> Currently, we use length of DSACKed range to compute number of
> delivered packets. And if sequence range in DSACK is corrupted,
> we can get bogus dsacked/acked count, and bogus cwnd.
>
> This patch put bo
From: Florian Westphal
Date: Fri, 25 Sep 2020 01:23:02 +0200
> Since commit cfde141ea3faa30e ("mptcp: move option parsing into
> mptcp_incoming_options()"), the 3rd function argument is no longer used.
>
> Signed-off-by: Florian Westphal
Applied, thanks Florian.
From: Huazhong Tan
Date: Fri, 25 Sep 2020 08:26:12 +0800
> There are some updates for the HNS3 ethernet driver.
> #1 & #2 are two cleanups.
> #3 adds new hardware error for the client.
> #4 adds debugfs support the pf's interrupt resource.
> #5 adds new pci device id for 200G device.
> #6 renames
On Wed, Sep 23, 2020 at 08:54:34AM -0700, Andrii Nakryiko wrote:
> Add APIs for appending new BTF types at the end of BTF object.
>
> Each BTF kind has either one API of the form btf__append_(). For types
> that have variable amount of additional items (struct/union, enum, func_proto,
> datasec),
> On Sep 25, 2020, at 03:57, Andrew Lunn wrote:
>
> On Fri, Sep 25, 2020 at 12:45:42AM +0800, Kai-Heng Feng wrote:
>> We are seeing the following error after S3 resume:
>> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
>> [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not
This is in dma-mapping for-next now.
Resend with proper subject.
---8<---
The struct flowi must never be interpreted by itself as its size
depends on the address family. Therefore it must always be grouped
with its original family value.
In this particular instance, the original family value is lost in
the function xfrm_state_find
Now that import_iovec handles compat iovecs, the native syscalls
can be used for the compat case as well.
Signed-off-by: Christoph Hellwig
---
arch/arm64/include/asm/unistd32.h | 4 +-
arch/mips/kernel/syscalls/syscall_n32.tbl | 4 +-
arch/mips/kernel/syscalls/syscall_o32.tbl
Now that import_iovec handles compat iovecs as well, all the duplicated
code in the compat readv/writev helpers is not needed. Remove them
and switch the compat syscall handlers to use the native helpers.
Signed-off-by: Christoph Hellwig
---
fs/read_write.c| 179 +++-
Now that import_iovec handles compat iovecs, the native readv and writev
syscalls can be used for the compat case as well.
Signed-off-by: Christoph Hellwig
---
arch/arm64/include/asm/unistd32.h | 4 ++--
arch/mips/kernel/syscalls/syscall_n32.tbl | 4 ++--
arch/mips/ke
Hi Al,
this series changes import_iovec to transparently deal with compat iovec
structures, and then cleanups up a lot of code dupliation.
Changes since v3:
- fix up changed prototypes in compat.h as well
Changes since v2:
- revert the switch of the access process vm sysclls to iov_iter
- ref
There is no compat_sys_readv64v2 syscall, only a compat_sys_preadv64v2
one.
Signed-off-by: Christoph Hellwig
---
include/linux/compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compat.h b/include/linux/compat.h
index b354ce58966e2d..654c1ec36671a4 100644
Split rw_copy_check_uvector into two new helpers with more sensible
calling conventions:
- iovec_from_user copies a iovec from userspace either into the provided
stack buffer if it fits, or allocates a new buffer for it. Returns
the actually used iovec. It also verifies that iov_len does
Use in compat_syscall to import either native or the compat iovecs, and
remove the now superflous compat_import_iovec.
This removes the need for special compat logic in most callers, and
the remaining ones can still be simplified by using __import_iovec
with a bool compat parameter.
Signed-off-by
From: David Laight
This lets the compiler inline it into import_iovec() generating
much better code.
Signed-off-by: David Laight
Signed-off-by: Christoph Hellwig
---
fs/read_write.c | 179
lib/iov_iter.c | 176 +
Now that import_iovec handles compat iovecs, the native vmsplice syscall
can be used for the compat case as well.
Signed-off-by: Christoph Hellwig
---
arch/arm64/include/asm/unistd32.h | 2 +-
arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +-
arch/mips/kernel/syscalls/syscall_o
Now that import_iovec handles compat iovecs, the native version of
keyctl_instantiate_key_iov can be used for the compat case as well.
Signed-off-by: Christoph Hellwig
---
security/keys/compat.c | 36 ++--
security/keys/internal.h | 5 -
security/keys/keyct
Dear Kai-Heng,
Thank you for patch version 3.
Am 24.09.20 um 18:45 schrieb Kai-Heng Feng:
We are seeing the following error after S3 resume:
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete
[ 704.902817] e1000e 00
On 9/24/20 11:21 AM, Daniel Borkmann wrote:
Port of tail_call_static() helper function from Cilium's BPF code base [0]
to libbpf, so others can easily consume it as well. We've been using this
in production code for some time now. The main idea is that we guarantee
that the kernel's BPF infras
On Thu, Sep 24, 2020 at 8:55 PM Alexei Starovoitov
wrote:
>
> On Wed, Sep 23, 2020 at 08:54:34AM -0700, Andrii Nakryiko wrote:
> > Add APIs for appending new BTF types at the end of BTF object.
> >
> > Each BTF kind has either one API of the form btf__append_(). For types
> > that have variable am
Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
support") added support for encapsulation offload. However, the inner
offload capability is to be restrictued to UDP tunnels.
This patch fixes the issue for non-udp tunnels by adding features
check capability and filtering appropri
201 - 260 of 260 matches
Mail list logo