Re: [net] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-09-24 Thread Alexandre Belloni
Hi, On 24/09/2020 10:11:13+0800, Xiaoliang Yang wrote: > INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3. You are changing GATE_STATE, not GATE_ENABLE > This register is used by stream gate control of PSFP, and it has not > been used before, because PSFP is not implemented

Re: [EXT] Re: [PATCH] net: fec: Keep device numbering consistent with datasheet

2020-09-24 Thread Stefan Riedmüller
Hi Andy, David and Andrew, first of all, thanks for your review. I really appreciate it! On 24.09.20 08:36, Andy Duan wrote: From: David Miller Sent: Thursday, September 24, 2020 4:32 AM From: Stefan Riedmueller Date: Wed, 23 Sep 2020 16:25:28 +0200 From: Christian Hemp Make use of devi

Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"

2020-09-24 Thread Geert Uytterhoeven
Hi David, On Thu, Sep 24, 2020 at 2:40 AM David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 22 Sep 2020 09:29:31 +0200 > > > This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc. > > > > This commit moved the ravb_mdio_init() call (and thus the > > of_mdiobus_register() call) f

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: > Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") > introduces two malfunction backend features ioctls: > > 1) the ioctls was blindly added to vring ioctl instead of vdpa device >ioctl > 2) vhost_set_backend_featu

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Jason Wang
On 2020/9/24 下午3:16, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") introduces two malfunction backend features ioctls: 1) the ioctls was blindly added to vring ioctl instead of vdpa device

[PATCH iproute2-next] ss: add support for xdp statistics

2020-09-24 Thread Ciara Loftus
The patch exposes statistics for XDP sockets which can be useful for debugging purposes. The stats exposed are: rx dropped rx invalid rx queue full rx fill ring empty tx invalid tx ring empty Signed-off-by: Ciara Loftus --- misc/ss.c | 22 +- 1 file c

Re: possible deadlock in xfrm_policy_delete

2020-09-24 Thread peterz
On Thu, Sep 24, 2020 at 06:44:12AM +0200, Dmitry Vyukov wrote: > On Thu, Sep 24, 2020 at 6:36 AM Herbert Xu > wrote: > > > (k-slock-AF_INET6){+.-.}-{2:2} That's a seqlock. > > What's going on with all these bogus lockdep reports? > > > > These are two completely different locks, one is for TCP

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 03:26:08PM +0800, Jason Wang wrote: > > On 2020/9/24 下午3:16, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: > > > Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") > > > introduces two malfunction backend features ioctls:

Re: KASAN: stack-out-of-bounds Read in xfrm_selector_match (2)

2020-09-24 Thread Steffen Klassert
On Mon, Sep 21, 2020 at 07:56:20AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:eb5f95f1 Merge tag 's390-5.9-6' of git://git.kernel.org/pu.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13996ad590 > kernel

Re: possible deadlock in xfrm_policy_delete

2020-09-24 Thread Herbert Xu
On Thu, Sep 24, 2020 at 09:30:03AM +0200, pet...@infradead.org wrote: > On Thu, Sep 24, 2020 at 06:44:12AM +0200, Dmitry Vyukov wrote: > > On Thu, Sep 24, 2020 at 6:36 AM Herbert Xu > > wrote: > > > > (k-slock-AF_INET6){+.-.}-{2:2} > > That's a seqlock. Are you sure? Line 2503 in net/ipv4/tcp.

Re: KASAN: stack-out-of-bounds Read in xfrm_selector_match (2)

2020-09-24 Thread Herbert Xu
On Thu, Sep 24, 2020 at 09:40:26AM +0200, Steffen Klassert wrote: > > This is yet another ipv4 mapped ipv6 address with IPsec socket policy > combination bug, and I'm sure it is not the last one. We could fix this > one by adding another check to match the address family of the policy > and the SA

Re: [RFC PATCH 02/24] vhost-vdpa: fix vqs leak in vhost_vdpa_open()

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote: > We need to free vqs during the err path after it has been allocated > since vhost won't do that for us. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vdpa.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) >

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: > Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") > introduces two malfunction backend features ioctls: > > 1) the ioctls was blindly added to vring ioctl instead of vdpa device >ioctl > 2) vhost_set_backend_featu

[PATCH net] net/tls: sendfile fails with ktls offload

2020-09-24 Thread Rohit Maheshwari
At first when sendpage gets called, if there is more data, 'more' in tls_push_data() gets set which later sets pending_open_record_frags, but when there is no more data in file left, and last time tls_push_data() gets called, pending_open_record_frags doesn't get reset. And later when 2 bytes of en

Re: KASAN: stack-out-of-bounds Read in xfrm_selector_match (2)

2020-09-24 Thread Steffen Klassert
On Thu, Sep 24, 2020 at 05:43:51PM +1000, Herbert Xu wrote: > On Thu, Sep 24, 2020 at 09:40:26AM +0200, Steffen Klassert wrote: > > > > This is yet another ipv4 mapped ipv6 address with IPsec socket policy > > combination bug, and I'm sure it is not the last one. We could fix this > > one by adding

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Jason Wang
On 2020/9/24 下午3:50, Michael S. Tsirkin wrote: On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") introduces two malfunction backend features ioctls: 1) the ioctls was blindly added to vring ioctl instead of vdpa de

Re: [PATCH v3 bpf-next 02/11] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-24 Thread Lorenz Bauer
On Wed, 23 Sep 2020 at 18:06, Martin KaFai Lau wrote: > > On Wed, Sep 23, 2020 at 10:27:27AM +0100, Lorenz Bauer wrote: > > On Tue, 22 Sep 2020 at 19:26, Martin KaFai Lau wrote: > > > > > > On Tue, Sep 22, 2020 at 10:46:41AM +0100, Lorenz Bauer wrote: > > > > On Tue, 22 Sep 2020 at 08:04, Martin

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread peterz
On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: > Introduce a new API hk_num_online_cpus(), that can be used to > retrieve the number of online housekeeping CPUs that are meant to handle > managed IRQ jobs. > > This API is introduced for the drivers that were previously relying

[PATCH] net: dsa: microchip: really look for phy-mode in port nodes

2020-09-24 Thread Helmut Grohne
The previous implementation failed to account for the "ports" node. The actual port nodes are not child nodes of the switch node, but a "ports" node sits in between. Fixes: edecfa98f602 ("net: dsa: microchip: look for phy-mode in port nodes") Signed-off-by: Helmut Grohne --- drivers/net/dsa/micr

RE: [EXT] Re: [net] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-09-24 Thread Xiaoliang Yang
Hi Alexandre, On 24/09/2020 15:08:21+0800, Alexandre Belloni wrote: > > Hi, > > On 24/09/2020 10:11:13+0800, Xiaoliang Yang wrote: > > INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3. > > You are changing GATE_STATE, not GATE_ENABLE Oh, sorry, it should be GATE_STATE fiel

KMSAN: uninit-value in ieee80211_skb_resize

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c5a13b33 kmsan: clang-format core git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1366df5390 kernel config: https://syzkaller.appspot.com/x/.config?x=20f149ad694ba

WARNING in __cfg80211_ibss_joined (2)

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:eff48dde Merge tag 'trace-v5.9-rc5' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1665b19b90 kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97 das

WARNING in ieee80211_rx_list

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:12450081 libbpf: Fix native endian assumption when parsing.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=1236e99b90 kernel config: https://syzkaller.appspot.com/x/.config?x=5ac0d21536db480b dashboar

memory leak in ieee80211_check_fast_xmit

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c9c9e6a4 Merge tag 'trace-v5.9-rc5-2' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1373520990 kernel config: https://syzkaller.appspot.com/x/.config?x=23de0cdbdd5f681b das

KASAN: vmalloc-out-of-bounds Read in bpf_trace_run5

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b10b8ad8 Add linux-next specific files for 20200921 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1371eb1d90 kernel config: https://syzkaller.appspot.com/x/.config?x=3cf0782933432b43 dashboard

KMSAN: uninit-value in hwsim_cloned_frame_received_nl

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c5a13b33 kmsan: clang-format core git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=12a19c0390 kernel config: https://syzkaller.appspot.com/x/.config?x=20f149ad694ba

UBSAN: array-index-out-of-bounds in ieee80211_del_key

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:98477740 Merge branch 'rcu/urgent' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1713087590 kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97 das

WARNING in sta_info_insert_rcu

2020-09-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:eff48dde Merge tag 'trace-v5.9-rc5' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17b4e8e390 kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97 das

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Michael S. Tsirkin
On Fri, Sep 18, 2020 at 11:22:45AM +0300, Leon Romanovsky wrote: > On Thu, Sep 17, 2020 at 07:35:03PM -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > > > drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency > > on VHOST to eliminate build errors. > > > > ld: drivers/vdpa/ml

Re: [RFC PATCH 02/24] vhost-vdpa: fix vqs leak in vhost_vdpa_open()

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote: > We need to free vqs during the err path after it has been allocated > since vhost won't do that for us. > > Signed-off-by: Jason Wang This is a bugfix too right? I don't see it posted separately ... > --- > drivers/vhost/vdpa.c | 11

[PATCH] net: qrtr: Fix port ID for control messages

2020-09-24 Thread Loic Poulain
The port ID for control messages was uncorrectly set with broadcast node ID value, causing message to be dropped on remote side since not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL). Fixes: d27e77a3de28 ("net: qrtr: Reset the node and port ID of broadcast messages") Signed-off-by: L

Re: [RFC PATCH 00/24] Control VQ support in vDPA

2020-09-24 Thread Stefan Hajnoczi
On Thu, Sep 24, 2020 at 11:21:01AM +0800, Jason Wang wrote: > This series tries to add the support for control virtqueue in vDPA. Please include documentation for both driver authors and vhost-vdpa ioctl users. vhost-vdpa ioctls are only documented with a single sentence. Please add full informati

[PATCH 1/1 nf] selftests: netfilter: add time counter check

2020-09-24 Thread Fabian Frederick
Check packets are correctly placed in current year. Also do a NULL check for another one. Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_meta.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/netfilter/nft_meta.sh

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: > > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig > > > +++ linux-next-20200917/drivers/vdpa/Kconfig > > > @@ -31,7 +31,7 @@ config IFCVF > > > > > > config MLX5_VDPA > > > bool "MLX5 VDPA support library for ConnectX devi

[PATCH v2 net] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-09-24 Thread Xiaoliang Yang
INIT_IPS and GATE_STATE fields have a wrong offset in SG_CONFIG_REG_3. This register is used by stream gate control of PSFP, and it has not been used before, because PSFP is not implemented in ocelot driver. Signed-off-by: Xiaoliang Yang --- include/soc/mscc/ocelot_ana.h | 8 1 file cha

Re: RTNETLINK answers: Permission denied

2020-09-24 Thread Brian J. Murrell
On Tue, 2020-09-22 at 15:04 -0400, Brian J. Murrell wrote: > What are the possible causes of: > > # ip route get 2001:4860:4860::8844 > RTNETLINK answers: Permission denied > > when > > # ip route get fd31:aeb1:48df::99 > fd31:aeb1:48df::99 from :: dev br-lan proto static src > fd31:aeb1:48df::1

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Oliver Neukum
Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > This internally uses kmemdup() with GFP_KERNEL. > > You cannot make this change. The API does not support it. > > I am afraid we will have to change the API first, before more > > such changes are done. > > One possible fix is to

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Oliver Neukum
Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya: > I meant that it was stupid to change it without properly understanding > the significance of GFP_NOIO in this context. > > So now, do we re-write the wrapper functions with flag passed as a parameter? Hi, I hope I set you in CC

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Frederic Weisbecker
On Thu, Sep 24, 2020 at 10:40:29AM +0200, pet...@infradead.org wrote: > On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: > > Introduce a new API hk_num_online_cpus(), that can be used to > > retrieve the number of online housekeeping CPUs that are meant to handle > > managed IRQ

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Frederic Weisbecker
On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: > Introduce a new API hk_num_online_cpus(), that can be used to > retrieve the number of online housekeeping CPUs that are meant to handle > managed IRQ jobs. > > This API is introduced for the drivers that were previously relying

Re: [PATCH v2] net: dsa: mt7530: Add some return-value checks

2020-09-24 Thread Landen Chao
Hi Alex, Thanks for your patch. By linux/scripts/checkpatch.pl On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote: [..] > @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch *ds) > mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK, > PCR_MATRIX_CLR); >

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Nitesh Narayan Lal
On 9/24/20 8:09 AM, Frederic Weisbecker wrote: > On Thu, Sep 24, 2020 at 10:40:29AM +0200, pet...@infradead.org wrote: >> On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: >>> Introduce a new API hk_num_online_cpus(), that can be used to >>> retrieve the number of online housekee

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Peter Zijlstra
On Thu, Sep 24, 2020 at 02:09:57PM +0200, Frederic Weisbecker wrote: > > > +static inline unsigned int hk_num_online_cpus(void) > > > > This breaks with the established naming of that header. > > I guess we can make it housekeeping_num_online_cpus() ? That would be consistent :-)

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Nitesh Narayan Lal
On 9/24/20 8:11 AM, Frederic Weisbecker wrote: > On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: >> Introduce a new API hk_num_online_cpus(), that can be used to >> retrieve the number of online housekeeping CPUs that are meant to handle >> managed IRQ jobs. >> >> This API is i

Re: [net-next] net: dsa: felix: convert TAS link speed based on phylink speed

2020-09-24 Thread Andrew Lunn
> I modify the commit and resend this patch to "net tree", please reject this > one. Hi Xiaoliang Yang You dropped "PATCH" from the subject. Please also include a version number, so it is possible to identify which is the last version: [PATCH net v2] net: dsa: felix: convert TAS link speed base

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Peter Zijlstra
FWIW, cross-posting to moderated lists is annoying. I don't know why we allow them in MAINTAINERS :-(

Re: [PATCH] e1000e: Power cycle phy on PM resume

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 23, 2020, at 23:37, Andrew Lunn wrote: > > On Wed, Sep 23, 2020 at 10:44:10PM +0800, Kai-Heng Feng wrote: >> Hi Andrew, >> >>> On Sep 23, 2020, at 20:17, Andrew Lunn wrote: >>> >>> On Wed, Sep 23, 2020 at 03:47:51PM +0800, Kai-Heng Feng wrote: We are seeing the follow

Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume

2020-09-24 Thread Paul Menzel
Dear Andrew, Am 23.09.20 um 21:28 schrieb Andrew Lunn: How much does this increase the resume time? Define resume time? Until you get the display manager unlock screen? Or do you need working networking? Until network is functional again. Currently, the speed negotiation alone takes three(

Re: [PATCH v2] net: dsa: mt7530: Add some return-value checks

2020-09-24 Thread Alex Dewar
On 2020-09-24 13:13, Landen Chao wrote: Hi Alex, Thanks for your patch. By linux/scripts/checkpatch.pl On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote: [..] @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch *ds) mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK,

Re: [PATCH v2] net: dsa: mt7530: Add some return-value checks

2020-09-24 Thread Landen Chao
On Thu, 2020-09-24 at 14:11 +0100, Alex Dewar wrote: > On 2020-09-24 13:13, Landen Chao wrote: > > Hi Alex, > > > > Thanks for your patch. By linux/scripts/checkpatch.pl > > > > On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote: > > [..] > >> @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Nitesh Narayan Lal
On 9/24/20 8:46 AM, Peter Zijlstra wrote: > > FWIW, cross-posting to moderated lists is annoying. I don't know why we > allow them in MAINTAINERS :-( Yeah, it sends out an acknowledgment for every email. I had to include it because sending the patches to it apparently allows them to get tested by

Re: ip rule iif oif and vrf

2020-09-24 Thread Stephen Suryaputra
On Wed, Sep 23, 2020 at 07:47:16PM -0600, David Ahern wrote: > If I remove the fib rules and add VRF route leaking from core to tenant > it works. Why is that not an option? Overlapping tenant addresses? Exactly. > One thought to get around it is adding support for a new FIB rule type > -- say l3

[PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Sedat Dilek
[ Please CC me I am not subscribed to all MLs ] [ CC Sami ] Hi Bill, I have tested your patch on top of Sami's latest clang-cfi Git branch. Feel free to add... Tested-by: Sedat Dilek # LLVM toolchain version 11.0.0-rc3 on x86-64 Thanks for the patch. Regards, - Sedat -

commit 37bd22420f85 ("af_key: pfkey_dump needs parameter validation") to stable

2020-09-24 Thread Mark Salyzyn
Please consider commit 37bd22420f856fcd976989f1d4f1f7ad28e1fcac ("af_key: pfkey_dump needs parameter validation") for merge into all the maintained stable trees. Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: sta...@vger.kernel.org Cc: Greg KH Fix

[PATCH v3] net: dsa: mt7530: Add some return-value checks

2020-09-24 Thread Alex Dewar
In mt7531_cpu_port_config(), if the variable port is neither 5 nor 6, then variable interface will be used uninitialised. Change the function to return -EINVAL in this case. As the return value of mt7531_cpu_port_config() is never checked (even though it returns an int) add a check in the correct

Re: commit 37bd22420f85 ("af_key: pfkey_dump needs parameter validation") to stable

2020-09-24 Thread Greg KH
On Thu, Sep 24, 2020 at 06:58:24AM -0700, Mark Salyzyn wrote: > Please consider > > commit 37bd22420f856fcd976989f1d4f1f7ad28e1fcac ("af_key: pfkey_dump needs > parameter validation") > > for merge into all the maintained stable trees. > > Cc: netdev@vger.kernel.org > Cc: linux-ker...@vger.kerne

Re: [PATCH] net: qrtr: Fix port ID for control messages

2020-09-24 Thread Bjorn Andersson
On Thu 24 Sep 04:53 CDT 2020, Loic Poulain wrote: > The port ID for control messages was uncorrectly set with broadcast > node ID value, causing message to be dropped on remote side since > not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL). > This does indeed make more sense. Unfortu

[PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-24 Thread Eli Cohen
Change core vdpa functionality into a loadbale module such that upcoming block implementation will be able to use it. Signed-off-by: Eli Cohen --- V0 --> V1: Removed "default n" for configu options as 'n' is the default drivers/vdpa/Kconfig | 8 +++- drivers/vdpa/Makefile

Re: [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-24 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Tue, Sep 22, 2020 at 08:38:38PM +0200, Toke Høiland-Jørgensen wrote: >> @@ -746,7 +748,9 @@ struct bpf_prog_aux { >> u32 max_rdonly_access; >> u32 max_rdwr_access; >> const struct bpf_ctx_arg_aux *ctx_arg_info; >> -struct bpf_prog *linked_p

i386: allmodconfig build failed on linux next

2020-09-24 Thread Naresh Kamboju
i386 allmodconfig build failed on linux next due to below errors. Since we recently started building allmodconfig. we do not have when this problem started. We are building with gcc-8, gcc-9 and gcc-10. Build log: make -sk KBUILD_BUILD_USER=TuxBuild -C/linux ARCH=i386 HOSTCC=gcc CC="

Re: ip rule iif oif and vrf

2020-09-24 Thread David Ahern
On 9/24/20 7:48 AM, Stephen Suryaputra wrote: > On Wed, Sep 23, 2020 at 07:47:16PM -0600, David Ahern wrote: >> If I remove the fib rules and add VRF route leaking from core to tenant >> it works. Why is that not an option? Overlapping tenant addresses? > > Exactly. > >> One thought to get around

[PATCH] net/fsl: quieten expected MDIO access failures

2020-09-24 Thread Jamie Iles
MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long boot times in a way that looks like an infinite loop when multiple busses are pre

Re: [PATCH] net/fsl: quieten expected MDIO access failures

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote: > MDIO reads can happen during PHY probing, and printing an error with > dev_err can result in a large number of error messages during device > probe. On a platform with a serial console this can result in > excessively long boot times in

[PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
We are seeing the following error after S3 resume: [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete [ 704.902817] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.903075] e1000e :00:1f.6 eno1: reading PHY page

Re: [PATCH] net/fsl: quieten expected MDIO access failures

2020-09-24 Thread Jamie Iles
Hi Andrew, On Thu, Sep 24, 2020 at 05:04:53PM +0200, Andrew Lunn wrote: > On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote: > > MDIO reads can happen during PHY probing, and printing an error with > > dev_err can result in a large number of error messages during device > > probe. On a p

RE: [PATCH bpf-next 0/9] libbpf: BTF writer APIs

2020-09-24 Thread John Fastabend
Andrii Nakryiko wrote: > This patch set introduces a new set of BTF APIs to libbpf that allow to > conveniently produce BTF types and strings. Internals of struct btf were > changed such that it can transparently and automatically switch to writable > mode, which allows appending BTF types and stri

RE: [PATCH bpf-next 2/9] libbpf: remove assumption of single contiguous memory for BTF data

2020-09-24 Thread John Fastabend
Andrii Nakryiko wrote: > Refactor internals of struct btf to remove assumptions that BTF header, type > data, and string data are layed out contiguously in a memory in a single > memory allocation. Now we have three separate pointers pointing to the start > of each respective are: header, types, st

Re: [PATCH bpf-next v3 1/2] bpf: Add bpf_ktime_get_real_ns

2020-09-24 Thread Daniel Borkmann
On 9/24/20 4:25 AM, bimmy.puj...@intel.com wrote: From: Bimmy Pujari The existing bpf helper functions to get timestamp return the time elapsed since system boot. This timestamp is not particularly useful where epoch timestamp is required or more than one server is involved and time sync is req

Re: [Intel-wired-lan] [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Paul Menzel
Dear Kai-Heng, Thank you for sending version 2. Am 24.09.20 um 17:09 schrieb Kai-Heng Feng: We are seeing the following error after S3 resume: I’d be great if you added the system and used hardware, you are seeing this with. [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 [

Re: [PATCH] net/fsl: quieten expected MDIO access failures

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote: > MDIO reads can happen during PHY probing, and printing an error with > dev_err can result in a large number of error messages during device > probe. On a platform with a serial console this can result in > excessively long boot times in

Re: [PATCH bpf-next v3 2/2] selftests/bpf: Verifying real time helper function

2020-09-24 Thread Daniel Borkmann
On 9/24/20 4:25 AM, bimmy.puj...@intel.com wrote: From: Bimmy Pujari Test xdping measures RTT from xdp using monotonic time helper. Extending xdping test to use real time helper function in order to verify this helper function. Signed-off-by: Bimmy Pujari [...] diff --git a/tools/testing/se

Re: [PATCH ethtool-next 2/5] pause: add --json support

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 17:10:30 -0700 Jacob Keller wrote: > > - printf("RX negotiated: %s\nTX negotiated: %s\n", > > - rx_status ? "on" : "off", tx_status ? "on" : "off"); > > + > > + if (is_json_context()) { > > + open_json_object("negotiated"); > > + print_bool(PRINT

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Petko Manolov
On 20-09-24 13:09:05, Oliver Neukum wrote: > Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > > One possible fix is to add yet another argument to usb_control_msg_recv(), > > which would be the GFP_XYZ flag to pass on to kmemdup(). Up to Greg, of > > course. > > submitted. T

Re: [PATCH] net/fsl: quieten expected MDIO access failures

2020-09-24 Thread Jeremy Linton
Hi, On 9/24/20 10:12 AM, Jamie Iles wrote: Hi Andrew, On Thu, Sep 24, 2020 at 05:04:53PM +0200, Andrew Lunn wrote: On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote: MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error mes

Re: [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-24 Thread Alexei Starovoitov
On Thu, Sep 24, 2020 at 7:34 AM Toke Høiland-Jørgensen wrote: > > ...which I just put down to random breakage, turned off the umh and > continued on my way (ignoring the failed test). Until you wrote this I > did not suspect this would be something I needed to pay attention to. > Now that you did

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Randy Dunlap
On 9/24/20 3:24 AM, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200917/drivers/vdpa/Kconfig @@ -31,7 +31,7 @@ config IFCVF config MLX5_VDPA bool "MLX5 VDPA

Re: [PATCH v2] brcmfmac: check return value of driver_for_each_device()

2020-09-24 Thread Kalle Valo
Zhang Changzhong wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: > variable 'ret' set but not used [-Wunused-but-set-variable] > 1576 | int ret; >| ^~~ > > driver_for_each_device() has been de

Re: [PATCH -next] zd1201: simplify the return expression of zd1201_set_maxassoc()

2020-09-24 Thread Kalle Valo
Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao Patch applied to wireless-drivers-next.git, thanks. 5acbf34e2a2c zd1201: simplify the return expression of zd1201_set_maxassoc() -- https://patchwork.kernel.org/patch/11789771/ https://wireless.wiki.ker

Re: [PATCH 1/2] rtw88: Fix probe error handling race with firmware loading

2020-09-24 Thread Kalle Valo
Andreas Färber wrote: > In case of rtw8822be, a probe failure after successful rtw_core_init() > has been observed to occasionally lead to an oops from rtw_load_firmware_cb(): > > [3.924268] pci 0001:01:00.0: [10ec:b822] type 00 class 0xff > [3.930531] pci 0001:01:00.0: reg 0x10: [io

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: > We are seeing the following error after S3 resume: > [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 > [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete > [ 704.902817] e1000e :00:1f.6 eno1: Setting

RE: [PATCH bpf-next 5/9] libbpf: allow modification of BTF and add btf__add_str API

2020-09-24 Thread John Fastabend
Andrii Nakryiko wrote: > Allow internal BTF representation to switch from default read-only mode, in > which raw BTF data is a single non-modifiable block of memory with BTF header, > types, and strings layed out sequentially and contiguously in memory, into > a writable representation with types a

Re: [PATCH] ipvs: adjust the debug order of src and dst

2020-09-24 Thread Simon Horman
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote: > From: ylg > > adjust the debug order of src and dst when tcp state changes > > Signed-off-by: ylg Hi, This sounds reasonable to me but please provide your real name in the Signed-off-by name, which should be consistent with the

RE: [PATCH bpf-next 7/9] libbpf: add BTF writing APIs

2020-09-24 Thread John Fastabend
Andrii Nakryiko wrote: > Add APIs for appending new BTF types at the end of BTF object. > > Each BTF kind has either one API of the form btf__append_(). For types > that have variable amount of additional items (struct/union, enum, func_proto, > datasec), additional API is provided to emit each su

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Greg KH
On Thu, Sep 24, 2020 at 06:40:26PM +0300, Petko Manolov wrote: > On 20-09-24 13:09:05, Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > > > > One possible fix is to add yet another argument to > > > usb_control_msg_recv(), > > > which would be the GFP_

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 22:49:37 -0700 Saeed Mahameed wrote: > 2) Another problematic scenario which i see is repeated in many > drivers: > > shutdown/suspend() > rtnl_lock() > netif_device_detach()//Mark !present; > stop()->carrier_off()->linkwatch_event() > // at this point device is

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote: > On 9/24/20 3:24 AM, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: > --- linux-next-20200917.orig/drivers/vdpa/Kconfig > +++ linux-next-20200917/drivers/vdpa/Kconfig > @@ -31,7 +

Re: [Intel-wired-lan] [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 05:32:12PM +0200, Paul Menzel wrote: > Dear Kai-Heng, > > > Thank you for sending version 2. > > Am 24.09.20 um 17:09 schrieb Kai-Heng Feng: > > We are seeing the following error after S3 resume: > > I’d be great if you added the system and used hardware, you are seeing

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 24, 2020, at 23:53, Andrew Lunn wrote: > > On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e :00:1f.6 eno1: MDI Writ

Re: [PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Masahiro Yamada
On Wed, Sep 23, 2020 at 8:21 AM Bill Wendling wrote: > > ld's --build-id defaults to "sha1" style, while lld defaults to "fast". > The build IDs are very different between the two, which may confuse > programs that reference them. > > Signed-off-by: Bill Wendling > --- > Makefile

Re: [PATCH iproute2] build: avoid make jobserver warnings

2020-09-24 Thread Stephen Hemminger
On Tue, 22 Sep 2020 08:15:59 +0200 (CEST) Jan Engelhardt wrote: > On Tuesday 2020-09-22 02:19, Stephen Hemminger wrote: > >> I observe: > >> > >>» make -j8 CCOPTS=-ggdb3 > >>lib > >>make[1]: warning: -j8 forced in submake: resetting jobserver mode. > >>make[1]: Nothing to be done

Re: RTNETLINK answers: Permission denied

2020-09-24 Thread David Ahern
On 9/24/20 5:09 AM, Brian J. Murrell wrote: > On Tue, 2020-09-22 at 15:04 -0400, Brian J. Murrell wrote: >> What are the possible causes of: >> >> # ip route get 2001:4860:4860::8844 >> RTNETLINK answers: Permission denied >> >> when >> >> # ip route get fd31:aeb1:48df::99 >> fd31:aeb1:48df::99 fro

Re: RTNETLINK answers: Permission denied

2020-09-24 Thread Brian J. Murrell
On Thu, 2020-09-24 at 10:15 -0600, David Ahern wrote: > > check your routes for a prohibit entry: I don't have any prohibit entries # ip -6 route ls table 5 | grep prohib # ip -6 rule ls 0: from all lookup local 1003: from all iif 6in4-henet lookup 3 1005: from all iif pppoe-wan1 look

[PATCH net-next v4 1/2] net: phy: dp83869: support Wake on LAN

2020-09-24 Thread Dan Murphy
This adds WoL support on TI DP83869 for magic, magic secure, unicast and broadcast. Signed-off-by: Dan Murphy --- v4 - Added checking error on phy_read drivers/net/phy/dp83869.c | 176 ++ 1 file changed, 176 insertions(+) diff --git a/drivers/net/phy/dp8386

[PATCH net-next v4 0/2] DP83869 WoL and Speed optimization

2020-09-24 Thread Dan Murphy
Hello Add the WoL and Speed Optimization (aka downshift) support for the DP83869 Ethernet PHY. Dan Dan Murphy (2): net: phy: dp83869: support Wake on LAN net: phy: dp83869: Add speed optimization feature drivers/net/phy/dp83869.c | 292 ++ 1 file changed

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-24 Thread Kalle Valo
Julian Calaby writes: > On Thu, Sep 17, 2020 at 3:09 AM Alex Dewar wrote: >> >> The for loop checks whether cur_section is NULL on every iteration, but >> we know it can never be NULL as there is another check towards the >> bottom of the loop body. Refactor to avoid this unnecessary check. >> >

[PATCH net-next v4 2/2] net: phy: dp83869: Add speed optimization feature

2020-09-24 Thread Dan Murphy
Set the speed optimization bit on the DP83869 PHY. Speed optimization, also known as link downshift, enables fallback to 100M operation after multiple consecutive failed attempts at Gigabit link establishment. Such a case could occur if cabling with only four wires (two twisted pairs) were connect

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-24 Thread Kalle Valo
Amit Pundir writes: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. > > We suspect either the host

[PATCH v3] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
We are seeing the following error after S3 resume: [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete [ 704.902817] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.903075] e1000e :00:1f.6 eno1: reading PHY page

Re: [PATCH iproute2] build: avoid make jobserver warnings

2020-09-24 Thread Jan Engelhardt
On Thursday 2020-09-24 18:11, Stephen Hemminger wrote: >> > >> >MFLAGS is a way to pass flags from original make into the sub-make. >> >> MAKEFLAGS and MFLAGS are already exported by make (${MAKE} is magic >> methinks), so they need no explicit passing. You can check this by >> adding somethin

[PATCH bpf] libbpf: fix XDP program load regression for old kernels

2020-09-24 Thread Andrii Nakryiko
Fix regression in libbpf, introduced by XDP link change, which causes XDP programs to fail to be loaded into kernel due to specified BPF_XDP expected_attach_type. While kernel doesn't enforce expected_attach_type for BPF_PROG_TYPE_XDP, some old kernels already support XDP program, but they don't ye

  1   2   3   >