Re: [PATCH] SUNRPC: Fix svc_flush_dcache()

2020-09-22 Thread He Zhe
On 9/21/20 3:51 AM, Chuck Lever wrote: > On platforms that implement flush_dcache_page(), a large NFS WRITE > triggers the WARN_ONCE in bvec_iter_advance(): > > Sep 20 14:01:05 klimt.1015granger.net kernel: Attempted to advance past end > of bvec iter > Sep 20 14:01:05 klimt.1015granger.net ker

Re: [PATCH 2/5] wlcore: Remove unused function no_write_handler()

2020-09-22 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. d0c8ff7c1e47 wlcore: Remove unused function no_write_handler() -- https://patchwork.kernel.org/patch/11785047/ https://wireless.wiki.kernel.or

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-22 Thread Vasundhara Volam
On Tue, Sep 22, 2020 at 12:22 PM Michal Kubecek wrote: > > On Tue, Sep 22, 2020 at 11:24:24AM +0530, Vasundhara Volam wrote: > > On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > > > + return -1; > > > > + } > > > > + > > > > + pcie_stats = (u16 *)(regs->data + BNXT_PX

Re: [PATCH -next v2] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-22 Thread Kalle Valo
Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao > Acked-by: Jakub Kicinski Patch applied to wireless-drivers-next.git, thanks. 7f1e215b39cb mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE -- https://patchwork.kernel.org/patch/11786577

Re: [PATCH] rtlwifi: Use ffs in _phy_calculate_bit_shift

2020-09-22 Thread Kalle Valo
Joe Perches wrote: > Remove the loop and use the generic ffs instead. > > Signed-off-by: Joe Perches Patch applied to wireless-drivers-next.git, thanks. 6c1d61913570 rtlwifi: Use ffs in _phy_calculate_bit_shift -- https://patchwork.kernel.org/patch/11786667/ https://wireless.wiki.kernel.or

Re: [PATCH] rtlwifi: rtl8192ee: use true,false for bool variable large_cfo_hit

2020-09-22 Thread Kalle Valo
Jason Yan wrote: > This addresses the following coccinelle warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/dm.c:721:27-47: > WARNING: Comparison of 0/1 to bool variable > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/dm.c:722:3-23: WARNING: > Assignment of 0/1 to bool variable > dri

Re: [PATCH] rtlwifi: rtl8821ae: use true,false for bool variable large_cfo_hit

2020-09-22 Thread Kalle Valo
Jason Yan wrote: > This addresses the following coccinelle warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2680:27-47: WARNING: > Comparison of 0/1 to bool variable > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2683:3-23: WARNING: > Assignment of 0/1 to bool variable > d

Re: [PATCH] rtlwifi: rtl8723be: use true,false for bool variable large_cfo_hit

2020-09-22 Thread Kalle Valo
Jason Yan wrote: > This addresses the following coccinelle warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c:1155:27-47: WARNING: > Comparison of 0/1 to bool variable > drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c:1156:3-23: WARNING: > Assignment of 0/1 to bool variable > d

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Arnd Bergmann
On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov wrote: > On 22/09/2020 03:58, Andy Lutomirski wrote: > > On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov > > wrote: > > I may be looking at a different kernel than you, but aren't you > > preventing creating an io_uring regardless of whether SQPOLL i

[PATCH v3 bpf-next 09/11] bpf: selftest: Adapt sock_fields test to use skel and global variables

2020-09-22 Thread Martin KaFai Lau
skel is used. Global variables are used to store the result from bpf prog. addr_map, sock_result_map, and tcp_sock_result_map are gone. Instead, global variables listen_tp, srv_sa6, cli_tp,, srv_tp, listen_sk, srv_sk, and cli_sk are added. Because of that, bpf_addr_array_idx and bpf_result_array_i

[PATCH v3 bpf-next 04/11] bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Martin KaFai Lau
This patch changes the bpf_sk_storage_*() to take ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer returned by the bpf_skc_to_*() helpers also. A micro benchmark has been done on a "cgroup_skb/egress" bpf program which does a bpf_sk_storage_get(). It was driven by netperf d

Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Michal Hocko
On Tue 22-09-20 12:20:52, Yafang Shao wrote: > On Mon, Sep 21, 2020 at 7:36 PM Michal Hocko wrote: > > > > On Mon 21-09-20 19:23:01, Yafang Shao wrote: > > > On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote: > > > > > > > > On Mon 21-09-20 18:55:40, Yafang Shao wrote: > > > > > On Mon, Sep 21,

[PATCH v3 bpf-next 11/11] bpf: selftest: Use bpf_skc_to_tcp_sock() in the sock_fields test

2020-09-22 Thread Martin KaFai Lau
This test uses bpf_skc_to_tcp_sock() to get a kernel tcp_sock ptr "ktp". Access the ktp->lsndtime and also pass it to bpf_sk_storage_get(). Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/prog_tests/sock_fields.c | 2 ++ tools/testing/selftests/bpf/progs/test_sock_fields.c | 11

[PATCH v3 bpf-next 00/11] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-22 Thread Martin KaFai Lau
This set allows networking prog type to directly read fields from the in-kernel socket type, e.g. "struct tcp_sock". Patch 2 has the details on the use case. v3: - ARG_PTR_TO_SOCK_COMMON_OR_NULL was attempted in v2. The _OR_NULL was needed because the PTR_TO_BTF_ID could be NULL but note that

[PATCH v3 bpf-next 03/11] bpf: Change bpf_sk_release and bpf_sk_*cgroup_id to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Martin KaFai Lau
The previous patch allows the networking bpf prog to use the bpf_skc_to_*() helpers to get a PTR_TO_BTF_ID socket pointer, e.g. "struct tcp_sock *". It allows the bpf prog to read all the fields of the tcp_sock. This patch changes the bpf_sk_release() and bpf_sk_*cgroup_id() to take ARG_PTR_TO_BT

[PATCH net] Revert "ravb: Fixed to be able to unload modules"

2020-09-22 Thread Geert Uytterhoeven
This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc. This commit moved the ravb_mdio_init() call (and thus the of_mdiobus_register() call) from the ravb_probe() to the ravb_open() call. This causes a regression during system resume (s2idle/s2ram), as new PHY devices cannot be bound while

[PATCH net-next v2 00/16] net: bridge: mcast: IGMPv3/MLDv2 fast-path (part 2)

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This is the second part of the IGMPv3/MLDv2 support which adds support for the fast-path. In order to be able to handle source entries we add mdb support for S,G entries (i.e. we add source address support to br_ip), that requires to extend the current mdb netlink AP

[PATCH net-next v2 04/16] net: bridge: add src field to br_ip

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add a new src field to struct br_ip which will be used to lookup S, G entries. When SSM option is added we will enable full br_ip lookups. Signed-off-by: Nikolay Aleksandrov --- include/linux/if_bridge.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/includ

[PATCH net-next v2 01/16] net: bridge: mdb: use extack in br_mdb_parse()

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We can drop the pr_info() calls and just use extack to return a meaningful error to user-space when br_mdb_parse() fails. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 60 + 1 file changed, 39 insertions(+), 2

[PATCH net-next v2 03/16] net: bridge: mdb: use extack in br_mdb_add() and br_mdb_add_group()

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Pass and use extack all the way down to br_mdb_add_group(). Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 54 +++-- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/

[PATCH net-next v2 02/16] net: bridge: mdb: move all port and bridge checks to br_mdb_add

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov To avoid doing duplicate device checks and searches (the same were done in br_mdb_add and __br_mdb_add) pass the already found port to __br_mdb_add and pull the bridge's netif_running and enabled multicast checks to br_mdb_add. This would also simplify the future extack

[PATCH net-next v2 08/16] net: bridge: mdb: add support for add/del/dump of entries with source

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add new mdb attributes (MDBE_ATTR_SOURCE for setting, MDBA_MDB_EATTR_SOURCE for dumping) to allow add/del and dump of mdb entries with a source address (S,G). New S,G entries are created with filter mode of MCAST_INCLUDE. The same attributes are used for IPv4 and IPv6, t

[PATCH net-next v2 07/16] net: bridge: mdb: add support to extend add/del commands

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Since the MDB add/del code expects an exact struct br_mdb_entry we can't really add any extensions, thus add a new nested attribute at the level of MDBA_SET_ENTRY called MDBA_SET_ENTRY_ATTRS which will be used to pass all new options via netlink attributes. This patch do

[PATCH net-next v2 11/16] net: bridge: mcast: add sg_port rhashtable

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov To speedup S,G forward handling we need to be able to quickly find out if a port is a member of an S,G group. To do that add a global S,G port rhashtable with key: source addr, group addr, protocol, vid (all br_ip fields) and port pointer. Signed-off-by: Nikolay Aleksan

[PATCH net-next v2 12/16] net: bridge: mcast: install S,G entries automatically based on reports

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch adds support for automatic install of S,G mdb entries based on the port group's source list and the source entry's timer. Once installed the S,G will be used when forwarding packets if the approprate multicast/mld versions are set. A new source flag called BR_

[PATCH net-next v2 14/16] net: bridge: mcast: add support for blocked port groups

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov When excluding S,G entries we need a way to block a particular S,G,port. The new port group flag is managed based on the source's timer as per RFCs 3376 and 3810. When a source expires and its port group is in EXCLUDE mode, it will be blocked. Signed-off-by: Nikolay Ale

[PATCH net-next v2 05/16] net: bridge: mcast: use br_ip's src for src groups and querier address

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Now that we have src and dst in br_ip it is logical to use the src field for the cases where we need to work with a source address such as querier source address and group source address. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 4 +-- net/b

[PATCH net-next v2 10/16] net: bridge: mcast: add rt_protocol field to the port group struct

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We need to be able to differentiate between pg entries created by user-space and the kernel when we start generating S,G entries for IGMPv3/MLDv2's fast path. User-space entries are created by default as RTPROT_STATIC and the kernel entries are RTPROT_KERNEL. Later we ca

[PATCH net-next v2 15/16] net: bridge: mcast: handle host state

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Since host joins are considered as EXCLUDE {} joins we need to reflect that in all of *,G ports' S,G entries. Since the S,Gs can have host_joined == true only set automatically we can safely set it to false when removing all automatically added entries upon S,G delete.

[PATCH net-next v2 13/16] net: bridge: mcast: handle port group filter modes

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We need to handle group filter mode transitions and initial state. To change a port group's INCLUDE -> EXCLUDE mode (or when we have added a new port group in EXCLUDE mode) we need to add that port to all of *,G ports' S,G entries for proper replication. When the EXCLUDE

[PATCH net-next v2 16/16] net: bridge: mcast: when forwarding handle filter mode and blocked flag

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We need to avoid forwarding to ports in MCAST_INCLUDE filter mode when the mdst entry is a *,G or when the port has the blocked flag. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_forward.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)

[PATCH net-next v2 09/16] net: bridge: mcast: when igmpv3/mldv2 are enabled lookup (S,G) first, then (*,G)

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov If (S,G) entries are enabled (igmpv3/mldv2) then look them up first. If there isn't a present (S,G) entry then try to find (*,G). Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/n

[PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Since now we have src in br_ip, u no longer makes sense so rename it to dst. No functional changes. v2: fix build with CONFIG_BATMAN_ADV_MCAST CC: Marek Lindner CC: Simon Wunderlich CC: Antonio Quartulli CC: Sven Eckelmann CC: b.a.t.m@lists.open-mesh.org Signed

[PATCH v3 bpf-next 05/11] bpf: Change bpf_tcp_*_syncookie to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Martin KaFai Lau
This patch changes the bpf_tcp_*_syncookie() to take ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer returned by the bpf_skc_to_*() helpers also. Signed-off-by: Martin KaFai Lau --- net/core/filter.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -

[PATCH v3 bpf-next 07/11] bpf: selftest: Add ref_tracking verifier test for bpf_skc casting

2020-09-22 Thread Martin KaFai Lau
The patch tests for: 1. bpf_sk_release() can be called on a tcp_sock btf_id ptr. 2. Ensure the tcp_sock btf_id pointer cannot be used after bpf_sk_release(). Signed-off-by: Martin KaFai Lau --- .../selftests/bpf/verifier/ref_tracking.c | 47 +++ 1 file changed, 47 inserti

[PATCH v3 bpf-next 02/11] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-22 Thread Martin KaFai Lau
There is a constant need to add more fields into the bpf_tcp_sock for the bpf programs running at tc, sock_ops...etc. A current workaround could be to use bpf_probe_read_kernel(). However, other than making another helper call for reading each field and missing CO-RE, it is also not as intuitive

[PATCH v3 bpf-next 06/11] bpf: Change bpf_sk_assign to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Martin KaFai Lau
This patch changes the bpf_sk_assign() to take ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer returned by the bpf_skc_to_*() helpers also. The bpf_sk_lookup_assign() is taking ARG_PTR_TO_SOCKET_"OR_NULL". Meaning it specifically takes a scalar NULL. ARG_PTR_TO_BTF_ID_SOC

[PATCH v3 bpf-next 08/11] bpf: selftest: Move sock_fields test into test_progs

2020-09-22 Thread Martin KaFai Lau
This is a mechanical change to 1. move test_sock_fields.c to prog_tests/sock_fields.c 2. rename progs/test_sock_fields_kern.c to progs/test_sock_fields.c Minimal change is made to the code itself. Next patch will make changes to use new ways of writing test, e.g. use skel and global variables. S

[PATCH v3 bpf-next 10/11] bpf: selftest: Use network_helpers in the sock_fields test

2020-09-22 Thread Martin KaFai Lau
This patch uses start_server() and connect_to_fd() from network_helpers.h to remove the network testing boiler plate codes. epoll is no longer needed also since the timeout has already been taken care of also. Signed-off-by: Martin KaFai Lau --- .../selftests/bpf/prog_tests/sock_fields.c| 8

Re: [PATCH -next] ath5k: convert to use DEFINE_SEQ_ATTRIBUTE macro

2020-09-22 Thread Kalle Valo
Liu Shixin wrote: > Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Liu Shixin > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. aac352d6810e ath5k: convert to use DEFINE_SEQ_ATTRIBUTE macro -- https://patchwork.kernel.org/patch/117787

[PATCH v3 bpf-next 01/11] bpf: Move the PTR_TO_BTF_ID check to check_reg_type()

2020-09-22 Thread Martin KaFai Lau
check_reg_type() checks whether a reg can be used as an arg of a func_proto. For PTR_TO_BTF_ID, the check is actually not completely done until the reg->btf_id is pointing to a kernel struct that is acceptable by the func_proto. Thus, this patch moves the btf_id check into check_reg_type(). The c

Re: [PATCH] ath11k: Remove unused function ath11k_htc_restore_tx_skb()

2020-09-22 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 191e7f9f05c6 ath11k: Remove unused function ath11k_htc_restore_tx_skb() -- https://patchwork.kernel.org/patch/117

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Pavel Begunkov
On 22/09/2020 10:23, Arnd Bergmann wrote: > On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov wrote: >> On 22/09/2020 03:58, Andy Lutomirski wrote: >>> On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov >>> wrote: >>> I may be looking at a different kernel than you, but aren't you >>> preventing creati

Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Yafang Shao
On Tue, Sep 22, 2020 at 3:27 PM Michal Hocko wrote: > > On Tue 22-09-20 12:20:52, Yafang Shao wrote: > > On Mon, Sep 21, 2020 at 7:36 PM Michal Hocko wrote: > > > > > > On Mon 21-09-20 19:23:01, Yafang Shao wrote: > > > > On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote: > > > > > > > > > > On

Re: [PATCH bpf-next v4 11/11] bpf: use a table to drive helper arg type checks

2020-09-22 Thread Lorenz Bauer
On Mon, 21 Sep 2020 at 23:23, Alexei Starovoitov wrote: > > On Mon, Sep 21, 2020 at 01:12:27PM +0100, Lorenz Bauer wrote: > > +struct bpf_reg_types { > > + const enum bpf_reg_type types[10]; > > +}; > > any idea on how to make it more robust? I kind of copied this from the bpf_iter context. I

Performance regressions in networking & storage benchmarks in Linux kernel 5.8

2020-09-22 Thread Abdul Anshad Azeez
Part of VMware's performance regression testing for Linux Kernel upstream rele ases we compared Linux kernel 5.8 against 5.7. Our evaluation revealed perform ance regressions mostly in networking latency/response-time benchmarks up to 6 0%. Storage throughput & latency benchmarks were also up by 8%

Re: [PATCH] net: allwinner: remove redundant irqsave and irqrestore in hardIRQ

2020-09-22 Thread Maxime Ripard
On Tue, Sep 22, 2020 at 01:56:15PM +1200, Barry Song wrote: > The comment "holders of db->lock must always block IRQs" and related > code to do irqsave and irqrestore don't make sense since we are in a > IRQ-disabled hardIRQ context. > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Signed-off-by: Barr

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-22 Thread Arnd Bergmann
On Tue, Sep 22, 2020 at 9:59 AM Pavel Begunkov wrote: > On 22/09/2020 10:23, Arnd Bergmann wrote: > > On Tue, Sep 22, 2020 at 8:32 AM Pavel Begunkov > > wrote: > >> On 22/09/2020 03:58, Andy Lutomirski wrote: > >>> On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov > >>> wrote: > >>> I may be look

Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-22 Thread Jesper Dangaard Brouer
On Mon, 21 Sep 2020 23:17:16 +0200 Willem de Bruijn wrote: > On Mon, Sep 21, 2020 at 6:22 PM Marek Zavodsky > wrote: > > > > Hi guys, > > > > My kernel knowledge is small, but I experienced this (similar) issue > > with packet encapsulation (not a redirect), therefore modifying the > > redirect

Re: [PATCH v3 bpf-next 04/11] bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Lorenz Bauer
On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > This patch changes the bpf_sk_storage_*() to take > ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer > returned by the bpf_skc_to_*() helpers also. > > A micro benchmark has been done on a "cgroup_skb/egress" bpf prog

Re: [PATCH v3 bpf-next 05/11] bpf: Change bpf_tcp_*_syncookie to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Lorenz Bauer
On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > This patch changes the bpf_tcp_*_syncookie() to take > ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer > returned by the bpf_skc_to_*() helpers also. > > Signed-off-by: Martin KaFai Lau Acked-by: Lorenz Bauer --

kindly responce to my mail

2020-09-22 Thread Sgt Vivian Robert
Good Day, I am glad to contact you through this medium I’m Sgt Vivian Robert am from united state, 28 years old single I am the only surviving child of my late parents, I am America female soldier presently in Afghanistan for the training, advising the Afghan forces and also helping in stabil

Re: [PATCH v3 bpf-next 06/11] bpf: Change bpf_sk_assign to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-22 Thread Lorenz Bauer
On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > This patch changes the bpf_sk_assign() to take > ARG_PTR_TO_BTF_ID_SOCK_COMMON such that they will work with the pointer > returned by the bpf_skc_to_*() helpers also. > > The bpf_sk_lookup_assign() is taking ARG_PTR_TO_SOCKET_"OR_NULL". M

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chunxin Zang
On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote: > > On Mon 21-09-20 18:55:40, Yafang Shao wrote: > > On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote: > > > > > > On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote: > > > > From: Chunxin Zang > > > > > > > > In the cgroup v1, we have

Re: [PATCH v3 bpf-next 02/11] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-22 Thread Lorenz Bauer
On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > There is a constant need to add more fields into the bpf_tcp_sock > for the bpf programs running at tc, sock_ops...etc. > > A current workaround could be to use bpf_probe_read_kernel(). However, > other than making another helper call for

Re: [PATCH bpf-next v7 00/10] bpf: Support multi-attach for freplace programs

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> This series adds support attaching freplace BPF programs to multiple targets. >> This is needed to support incremental attachment of multiple XDP programs >> using >> the libxdp dispatcher model. >>

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chris Down
Chunxin Zang writes: My usecase is that there are two types of services in one server. They have difference priorities. Type_A has the highest priority, we need to ensure it's schedule latency、I/O latency、memory enough. Type_B has the lowest priority, we expect it will not affect Type_A when exec

Re: [PATCH bpf-next v7 01/10] bpf: disallow attaching modify_return tracing functions to other BPF programs

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> From the checks and commit messages for modify_return, it seems it was >> never the intention that it should be possible to attach a tracing program >> with expect

Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"

2020-09-22 Thread Sergei Shtylyov
On 22.09.2020 10:29, Geert Uytterhoeven wrote: This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc. This commit moved the ravb_mdio_init() call (and thus the of_mdiobus_register() call) from the ravb_probe() to the ravb_open() call. This causes a regression during system resume (s2idl

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Mon, Sep 21, 2020 at 11:08:20PM -0400, Nitesh Narayan Lal wrote: > > On 9/21/20 6:58 PM, Frederic Weisbecker wrote: > > On Thu, Sep 17, 2020 at 11:23:59AM -0700, Jesse Brandeburg wrote: > >> Nitesh Narayan Lal wrote: > >> > >>> In a realtime environment, it is essential to isolate unwanted IRQs

Re: [PATCH v3 bpf-next 01/11] bpf: Move the PTR_TO_BTF_ID check to check_reg_type()

2020-09-22 Thread Lorenz Bauer
On Tue, 22 Sep 2020 at 08:04, Martin KaFai Lau wrote: > > check_reg_type() checks whether a reg can be used as an arg of a > func_proto. For PTR_TO_BTF_ID, the check is actually not > completely done until the reg->btf_id is pointing to a > kernel struct that is acceptable by the func_proto. > >

Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Michal Hocko
On Tue 22-09-20 16:06:31, Yafang Shao wrote: > On Tue, Sep 22, 2020 at 3:27 PM Michal Hocko wrote: [...] > > What is the latency triggered by the memory reclaim? It should be mostly > > a clean page cache right as drop_caches only drops clean pages. Or is > > this more about [id]cache? Do you have

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Mon, Sep 21, 2020 at 11:16:51PM -0400, Nitesh Narayan Lal wrote: > > On 9/21/20 7:40 PM, Frederic Weisbecker wrote: > > On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: > >> +/* > >> + * num_housekeeping_cpus() - Read the number of housekeeping CPUs. > >> + * > >> + * This fu

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

[PATCH v3 ethtool] bnxt: Add Broadcom driver support.

2020-09-22 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- v3: - Fix the memcpy to copy to the correct size variable. - Also, fix

Re: [PATCH v4 0/2] net: mdio-ipq4019: add Clause 45 support

2020-09-22 Thread Robert Marko
On Mon, Sep 21, 2020 at 11:48 PM David Miller wrote: > > From: Robert Marko > Date: Sun, 20 Sep 2020 16:16:51 +0200 > > > This patch series adds support for Clause 45 to the driver. > > > > While at it also change some defines to upper case to match rest of the > > driver. > > > > Changes since

[PATCH v5 1/2] net: mdio-ipq4019: change defines to upper case

2020-09-22 Thread Robert Marko
In the commit adding the IPQ4019 MDIO driver, defines for timeout and sleep partially used lower case. Lets change it to upper case in line with the rest of driver defines. Signed-off-by: Robert Marko Cc: Luka Perkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes since v4:

[PATCH v5 0/2] net: mdio-ipq4019: add Clause 45 support

2020-09-22 Thread Robert Marko
This patch series adds support for Clause 45 to the driver. While at it also change some defines to upper case to match rest of the driver. Changes since v4: * Rebase onto net-next.git Changes since v1: * Drop clock patches, these need further investigation and no user for non default configurat

[PATCH v5 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-22 Thread Robert Marko
While up-streaming the IPQ4019 driver it was thought that the controller had no Clause 45 support, but it actually does and its activated by writing a bit to the mode register. So lets add it as newer SoC-s use the same controller and Clause 45 compliant PHY-s. Signed-off-by: Robert Marko Cc:

Re: [PATCH bpf-next v7 04/10] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> In preparation for allowing multiple attachments of freplace programs, move >> the references to the target program and trampoline into the >> bpf_tracing_link str

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chunxin Zang
On Tue, Sep 22, 2020 at 5:51 PM Chris Down wrote: > > Chunxin Zang writes: > >My usecase is that there are two types of services in one server. They > >have difference > >priorities. Type_A has the highest priority, we need to ensure it's > >schedule latency、I/O > >latency、memory enough. Type_B ha

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chris Down
Chunxin Zang writes: On Tue, Sep 22, 2020 at 5:51 PM Chris Down wrote: Chunxin Zang writes: >My usecase is that there are two types of services in one server. They >have difference >priorities. Type_A has the highest priority, we need to ensure it's >schedule latency、I/O >latency、memory enough

[net-next] net: dsa: felix: convert TAS link speed based on phylink speed

2020-09-22 Thread Xiaoliang Yang
state->speed holds a value of 10, 100, 1000 or 2500, but QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the speed to a proper value. Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler via taprio offload") Signed-off-by: Xiaoliang Yang --- drivers/net/dsa

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

[PATCH 0/3] Fix Kernel-doc warnings introduced on next-20200921

2020-09-22 Thread Mauro Carvalho Chehab
A few new warnings were added at linux-next. Address them, in order for us to keep zero warnings at the docs. The entire patchset fixing all kernel-doc warnings is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=doc-fixes Mauro Carvalho Chehab (3): net: fix a new kernel-doc

[PATCH 1/3] net: fix a new kernel-doc warning at dev.c

2020-09-22 Thread Mauro Carvalho Chehab
kernel-doc expects the function prototype to be just after the kernel-doc markup, as otherwise it will get it all wrong: ./net/core/dev.c:10036: warning: Excess function parameter 'dev' description in 'WAIT_REFS_MIN_MSECS' Fixes: 0e4be9e57e8c ("net: use exponential backoff in netdev_wait

[PATCH net] hinic: fix wrong return value of mac-set cmd

2020-09-22 Thread Luo bin
It should also be regarded as an error when hw return status=4 for PF's setting mac cmd. Only if PF return status=4 to VF should this cmd be taken special treatment. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_port.c | 6 +++--- drivers/net/ethernet/huawei/hinic/hinic_sr

Re: Performance regressions in networking & storage benchmarks in Linux kernel 5.8

2020-09-22 Thread Thomas Gleixner
Abdul, On Tue, Sep 22 2020 at 08:51, Abdul Anshad Azeez wrote: > Part of VMware's performance regression testing for Linux Kernel upstream rele > ases we compared Linux kernel 5.8 against 5.7. Our evaluation revealed perform > ance regressions mostly in networking latency/response-time benchmarks

[PATCH -next] ath9k: Remove set but not used variable

2020-09-22 Thread Li Heng
This addresses the following gcc warning with "make W=1": drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1338:18: warning: ‘ar9580_1p0_pcie_phy_clkreq_disable_L1’ defined but not used [-Wunused-const-variable=] Reported-by: Hulk Robot Signed-off-by: Li Heng --- drivers/net/wireless/ath/

[PATCH net-next RFC v2 repost 3/3] net/mlx5e: Add devlink

2020-09-22 Thread Aya Levin
From: Aya Levin Register MTU error trap to allow visibility of oversize packets. Display a naive use of devlink trap in devlink port context. Signed-off-by: Aya Levin --- Changelog: v1->v2: -Minor changes in trap's definition -Adjustments to trap API and ops drivers/net/ethernet/mellanox/mlx5

[PATCH net-next RFC v2 repost 0/3] Add devlink traps in

2020-09-22 Thread Aya Levin
Implement support for devlink traps on per-port basis. Dropped packets in the RX flow are related to the Ethernet port and thus should be in port context. Traps per device should trap global configuration which may cause drops. Devlink traps is regard as a debug mode. Using traps per port enable de

[PATCH net-next RFC v2 repost 2/3] devlink: Add devlink traps

2020-09-22 Thread Aya Levin
There are some cases where we would like to trap dropped packets only for a single port on a device without affecting the others. For that purpose: - Add trap lists and trap ops to devlink_port - Add corresponding trap API to manage traps - Add matching netlink commands Signed-off-by: Aya Levin -

Re: [net-next] net: dsa: felix: convert TAS link speed based on phylink speed

2020-09-22 Thread Vladimir Oltean
Hi Xiaoliang, On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote: > state->speed holds a value of 10, 100, 1000 or 2500, but > QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the > speed to a proper value. > > Fixes: de143c0e274b ("net: dsa: felix: Configure Time-

[PATCH RFC] net: add in_softirq() debug checking in napi_consume_skb()

2020-09-22 Thread Yunsheng Lin
The current semantic for napi_consume_skb() is that caller need to provide non-zero budget when calling from NAPI context, and breaking this semantic will cause hard to debug problem, because _kfree_skb_defer() need to run in atomic context in order to push the skb to the particular cpu' napi_alloc

[PATCH net-next RFC v2 repost 1/3] devlink: Wrap trap related

2020-09-22 Thread Aya Levin
Bundle the trap related lists: trap_list, trap_group_list and trap_policer_list in a dedicated struct. This will be handy in the coming patches in the set introducing traps in devlink port context. With trap_lists, code reuse is much simpler. Signed-off-by: Aya Levin --- Changelog: v1->v2: Patch

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > What is considered a RoCE port in this case if it's not compliant with RoCE? > Sounds like it's an implementation of RDMA over ethernet, not RoCE. > Does GAUDI support UD/RC/.. QPs? Is it using a proprietary wire protocol? > (BTW, Ode

Re: [PATCH net-next v2 3/3] octeontx2-af: add support for custom KPU entries

2020-09-22 Thread Stanislaw Kardach
On Mon, Sep 21, 2020 at 04:26:43PM -0700, Jakub Kicinski wrote: > Date: Mon, 21 Sep 2020 16:26:43 -0700 > From: Jakub Kicinski > To: Stanislaw Kardach > Cc: da...@davemloft.net, sgout...@marvell.com, netdev@vger.kernel.org, > k...@semihalf.com > Subject: Re: [PATCH net-next v2 3/3] octeontx2-af:

Re: [PATCH 10/18] hal2: convert to dma_alloc_noncoherent

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:14PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This also means we can allocate the buffer memory with the proper > direction instead of bidirectional. > > Signed-off-by: Christoph Hellwig > --- > sound

Re: [PATCH 15/18] dma-mapping: add a new dma_alloc_pages API

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:19PM +0200, Christoph Hellwig wrote: > This API is the equivalent of alloc_pages, except that the returned memory > is guaranteed to be DMA addressable by the passed in device. The > implementation will also be used to provide a more sensible replacement > for DMA_ATT

Re: [PATCH 14/18] dma-mapping: remove dma_cache_sync

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:18PM +0200, Christoph Hellwig wrote: > All users are gone now, remove the API. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/Kconfig | 1 - > arch/mips/jazz/jazzdma.c| 1 - > arch/mips/mm/dma-noncoherent.c | 6 -- > arch/parisc

Re: [PATCH 06/18] lib82596: move DMA allocation into the callers of i82596_probe

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:10PM +0200, Christoph Hellwig wrote: > This allows us to get rid of the LIB82596_DMA_ATTR defined and prepare > for untangling the coherent vs non-coherent DMA allocation API. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/i825xx/lasi_82596.c | 24

Re: [PATCH 07/18] 53c700: improve non-coherent DMA handling

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:11PM +0200, Christoph Hellwig wrote: > Switch the 53c700 driver to only use non-coherent descriptor memory if it > really has to because dma_alloc_coherent fails. This doesn't matter for > any of the platforms it runs on currently, but that will change soon. > > To h

Re: [PATCH 12/18] sgiseeq: convert to dma_alloc_noncoherent

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:16PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This includes adding additional calls to dma_sync_desc_dev as the > old syncing was rather ad-hoc. > > Thanks to Thomas Bogendoerfer for debugging the owner

Re: [PATCH 09/18] sgiwd93: convert to dma_alloc_noncoherent

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:13PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This also means we can allocate the memory as DMA_TO_DEVICE instead > of bidirectional. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/sgiwd93.

Re: [PATCH 11/18] lib82596: convert to dma_alloc_noncoherent

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:15PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This includes moving the DMA helpers to lib82596 based of an ifdef to > avoid include order problems. > > Signed-off-by: Christoph Hellwig > --- > drivers

Re: [PATCH 13/18] 53c700: convert to dma_alloc_noncoherent

2020-09-22 Thread Thomas Bogendoerfer
On Tue, Sep 15, 2020 at 05:51:17PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/53c700.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) Tested-by:

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Mon, Sep 21, 2020 at 02:20:53PM -0700, Jakub Kicinski wrote: > I'd wager the only reason you expose the netdevs at all is for link > settings, stats, packet capture and debug. You'd never run TCP traffic > over those links. And you're fighting against using Linux APIs for the > only real traffic

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chunxin Zang
On Tue, Sep 22, 2020 at 6:42 PM Chris Down wrote: > > Chunxin Zang writes: > >On Tue, Sep 22, 2020 at 5:51 PM Chris Down wrote: > >> > >> Chunxin Zang writes: > >> >My usecase is that there are two types of services in one server. They > >> >have difference > >> >priorities. Type_A has the highes

Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-22 Thread Chris Down
Chunxin Zang writes: Please forgive me for not being able to understand why setting memory.low for Type_A can solve the problem. In my scene, Type_A is the most important, so I will set 100G to memory.low. But 'memory.low' only takes effect passively when the kernel is reclaiming memory. It means

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Gal Pressman
On 22/09/2020 14:41, Jason Gunthorpe wrote: > On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > >> What is considered a RoCE port in this case if it's not compliant with RoCE? >> Sounds like it's an implementation of RDMA over ethernet, not RoCE. >> Does GAUDI support UD/RC/.. QPs? I

  1   2   3   >