Hi Andrew,
I removed below register layout descriptions because these descriptions did not
match register definitions for rtl8211e extension page 164 reg 0x1c at all.
8:6 = PHY Address
5:4 = Auto-Negotiation
3 = Mode
2 = RXD
1 = TXD
0 = SELRGV1
I think it is a misunderstanding. These definitions a
Hi Daniel,
On Fri, Sep 18, 2020 at 10:31 PM Daniel Borkmann wrote:
>
> On 9/17/20 12:28 PM, Laura García Liébana wrote:
> > On Tue, Sep 15, 2020 at 12:02 AM Daniel Borkmann
> > wrote:
> >> On 9/14/20 1:29 PM, Laura García Liébana wrote:
> >>> On Fri, Sep 11, 2020 at 6:28 PM Daniel Borkmann
>
Fix the warnings about function header comments when building hinic
driver with "W=1" option.
Signed-off-by: Luo bin
---
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 6 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 3 +
On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
>
> Signed-off-by: YueHaibing
Thanks, this look good to me.
Acked-by: Simon Horman
Pablo, please consider this for nf-next.
> --
There is really no point having an auto-start for channels.
This is confusing for the device drivers, some have to enable the
channels, others don't have... and waste resources (e.g. pre allocated
buffers) that may never be used.
This is really up to the MHI device(channel) driver to manage the st
Start MHI device channels so that transfers can be performed.
The MHI stack does not auto-start channels anymore.
Signed-off-by: Loic Poulain
---
v2: split MHI and qrtr changes in dedicated commits
net/qrtr/mhi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/qrtr/mhi.c b/net/qrt
Hi,
On Fri, Sep 18, 2020 at 10:39 PM Nick Desaulniers
wrote:
>
> On Thu, Sep 17, 2020 at 12:20 AM Gilad Ben-Yossef wrote:
> >
...
> >
> > I am unable to understand this warning. It looks like it is
> > complaining about a FIELD_GET sanity check that is always false, which
> > makes sense since w
From: Chunxin Zang
In the cgroup v1, we have 'force_mepty' interface. This is very
useful for userspace to actively release memory. But the cgroup
v2 does not.
This patch reuse cgroup v1's function, but have a new name for
the interface. Because I think 'drop_cache' may be is easier to
understan
Hello,
syzbot found the following issue on:
HEAD commit:ba4f184e Linux 5.9-rc6
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1620076590
kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97
dashboard link: https://syzkaller.appspot
On 2020/9/21 15:19, Eric Dumazet wrote:
> On Mon, Sep 21, 2020 at 4:08 AM Yunsheng Lin wrote:
>>
>> When napi_consume_skb() is called in the tx desc cleaning process,
>> it is usually in the softirq context(BH disabled, or are processing
>> softirqs), but it may also be in the task context, such a
On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
> From: Chunxin Zang
>
> In the cgroup v1, we have 'force_mepty' interface. This is very
> useful for userspace to actively release memory. But the cgroup
> v2 does not.
>
> This patch reuse cgroup v1's function, but have a new name for
Make log prints in ena_netdev use the same log functions as the rest of
the driver.
For the sake of consistency, all prints in ena_netdev file were
converted into netif_* format except where netdev struct isn't yet
defined. For these places, dev_* log functions are used (similar to
the patch for e
Hi all,
This series adds the following:
- Change driver's license into SPDX format
- Capitalize all log prints in ENA driver
- Fix issues raised by static checkers
- Improve code readability by adding functions, fix spelling
mistakes etc.
- Update driver's documentation
Changed from previous ver
All ena files should now use SPDX format in their license string. This
doesn't change the license of the files, but rather states the same
license in fewer words.
Also update the license years in some of the files.
Signed-off-by: Shay Agroskin
---
.../net/ethernet/amazon/ena/ena_admin_defs.h |
Capitalize all log strings printed by the ena driver to make their
format uniform across it.
Also fix indentation, spelling mistakes and comments to improve code
readability. This also includes adding comments to macros/enums whose
purpose might be difficult to understand.
Separate some code into
The PCI vendor IDs in the documentation inaccurately describe the ENA
devices. For example, the 1d0f:ec20 can have LLQ support. The driver
loads in LLQ mode by default, and a message is printed to the kernel
ring if the mode isn't supported by the device, so the device table
isn't needed.
Also, LL
After running Sparse checker on the driver using
make C=1 M=drivers/net/ethernet/amazon/ena
the only error that is thrown is:
sparse: sparse: Using plain integer as NULL pointer
about the line
struct ena_calc_queue_size_ctx calc_queue_ctx = { 0 };
This patch fixes this warning, thus m
The placement policy is printed in the process of queue creation in
ena_up(). No need to print it in ena_probe().
Signed-off-by: Arthur Kiyanovski
Signed-off-by: Shay Agroskin
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff
The formal name changes to "ENA_ADMIN_RSS_INDIRECTION_TABLE_CONFIG".
Indirection is the ability to reference "something" using "something else"
instead of the value itself.
Indirection table, as the name implies, is the ability to reference
CPU/Queue value using hash-to-CPU table instead of CPU/Que
On 2020/9/21 16:17, Eric Dumazet wrote:
> On Mon, Sep 21, 2020 at 10:10 AM Yunsheng Lin wrote:
>>
>> On 2020/9/21 15:19, Eric Dumazet wrote:
>>> On Mon, Sep 21, 2020 at 4:08 AM Yunsheng Lin wrote:
When napi_consume_skb() is called in the tx desc cleaning process,
it is usually in t
On 9/21/20 10:40 AM, Yunsheng Lin wrote:
> On 2020/9/21 16:17, Eric Dumazet wrote:
>> On Mon, Sep 21, 2020 at 10:10 AM Yunsheng Lin wrote:
>>>
>>> On 2020/9/21 15:19, Eric Dumazet wrote:
On Mon, Sep 21, 2020 at 4:08 AM Yunsheng Lin
wrote:
>
> When napi_consume_skb() is calle
On Mon, Sep 21, 2020 at 12:09:51PM +0530, Vasundhara Volam wrote:
> This patch adds the initial support for parsing registers dumped
> by the Broadcom driver. Currently, PXP and PCIe registers are
> parsed.
>
> Reviewed-by: Andy Gospodarek
> Reviewed-by: Edwin Peer
> Signed-off-by: Vasundhara Vo
On Mon, Sep 14, 2020 at 03:57:56AM +, Krzysztof Wilczyński wrote:
> All the flags defined in the enum pci_dev_flags are used to determine
> whether a particular feature of an underlying PCI device should be used
> or not - features are also often disabled via a device-specific quirk.
>
> These
Hello,
syzbot found the following issue on:
HEAD commit:f13d783a MAINTAINERS: Update ibmveth maintainer
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=12dda4e390
kernel config: https://syzkaller.appspot.com/x/.config?x=5ac0d21536db480b
dashboard link: https
Hello,
syzbot found the following issue on:
HEAD commit:70b97111 bpf: Use hlist_add_head_rcu when linking to local..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15c624ad90
kernel config: https://syzkaller.appspot.com/x/.config?x=7e0ca96a9b6ee858
das
Hi all,
I would like to know if you have already seen this behavior :
Without this patch
https://patchwork.ozlabs.org/project/netdev/patch/20200201020124.5989-1-nicoleots...@gmail.com/,
during suspend/resume sequence on STM32MP15 (stmmac driver):
[ 69.184175] dwc2 4900.usb-otg: suspe
On Mon, Sep 21, 2020 at 05:02:13AM +0200, Andrew Lunn wrote:
> On Mon, Sep 21, 2020 at 12:23:18AM +, Vladimir Oltean wrote:
> > On Mon, Sep 21, 2020 at 02:45:39AM +0300, Vladimir Oltean wrote:
> > > This looks like a simple enough solution, but am I right that old
> > > kernels, which ignore th
On 15/09/2020 01:32, David Miller wrote:
From: Landen Chao
Date: Fri, 11 Sep 2020 21:48:50 +0800
This patch series adds support for MT7531.
MT7531 is the next generation of MT7530 which could be found on Mediatek
router platforms such as MT7622 or MT7629.
It is also a 7-ports switch with
Hello,
syzbot found the following issue on:
HEAD commit:325d0eab Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=128d4dd990
kernel config: https://syzkaller.appspot.com/x/.config?x=b12e84189082991c
dashboard lin
Hello,
syzbot found the following issue on:
HEAD commit:70b97111 bpf: Use hlist_add_head_rcu when linking to local..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1375823d90
kernel config: https://syzkaller.appspot.com/x/.config?x=7e0ca96a9b6ee858
das
Fri, Sep 18, 2020 at 06:13:59PM CEST, mo...@nvidia.com wrote:
>
>On 9/15/2020 11:33 PM, Moshe Shemesh wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 9/15/2020 4:34 PM, Jiri Pirko wrote:
>> > Tue, Sep 15, 2020 at 02:31:38PM CEST, mo...@nvidia.com wrote:
>> > > On 9/
On Sat, 19 Sep 2020 at 00:06, Maciej Żenczykowski wrote:
>
> > This is a good point. As bpf_skb_adjust_room() can just be run after
> > bpf_redirect() call, then a MTU check in bpf_redirect() actually
> > doesn't make much sense. As clever/bad BPF program can then avoid the
> > MTU check anyhow.
On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson
wrote:
>
> On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote:
>
> > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845)
> > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error
> > message in ath10k_qmi_host_cap_send_sync(), but we can still
>
On Sun, Sep 20, 2020 at 10:05:39PM +0300, Oded Gabbay wrote:
> On Sun, Sep 20, 2020 at 11:47 AM Greg Kroah-Hartman
> wrote:
> >
> > On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote:
> > > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote:
> > > > > It's probably her
On Thu, 17 Sep 2020 at 13:55, Maciej Żenczykowski wrote:
>
>
> (b) another complexity with bpf_redirect() is you can call it, it can succeed,
> but then you can not return TC_ACT_REDIRECT from the bpf program,
> which effectively makes the earlier *successful* bpf_redirect() call
> an utter no-op.
Michal Hocko writes:
On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
From: Chunxin Zang
In the cgroup v1, we have 'force_mepty' interface. This is very
useful for userspace to actively release memory. But the cgroup
v2 does not.
This patch reuse cgroup v1's function, but have a new
From: Nikolay Aleksandrov
Hi,
This is the second part of the IGMPv3/MLDv2 support which adds support
for the fast-path. In order to be able to handle source entries we add
mdb support for S,G entries (i.e. we add source address support to
br_ip), that requires to extend the current mdb netlink AP
From: Nikolay Aleksandrov
Since now we have src in br_ip, u no longer makes sense so rename
it to dst. No functional changes.
CC: Marek Lindner
CC: Simon Wunderlich
CC: Antonio Quartulli
CC: b.a.t.m@lists.open-mesh.org
Signed-off-by: Nikolay Aleksandrov
---
include/linux/if_bridge.h |
From: Nikolay Aleksandrov
We can drop the pr_info() calls and just use extack to return a
meaningful error to user-space when br_mdb_parse() fails.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 60 +
1 file changed, 39 insertions(+), 2
From: Nikolay Aleksandrov
Add a new src field to struct br_ip which will be used to lookup S, G
entries. When SSM option is added we will enable full br_ip lookups.
Signed-off-by: Nikolay Aleksandrov
---
include/linux/if_bridge.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/includ
From: Nikolay Aleksandrov
Pass and use extack all the way down to br_mdb_add_group().
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 54 +++--
1 file changed, 42 insertions(+), 12 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/
From: Nikolay Aleksandrov
Add new mdb attributes (MDBE_ATTR_SOURCE for setting,
MDBA_MDB_EATTR_SOURCE for dumping) to allow add/del and dump of mdb
entries with a source address (S,G). New S,G entries are created with
filter mode of MCAST_INCLUDE. The same attributes are used for IPv4 and
IPv6, t
From: Nikolay Aleksandrov
If (S,G) entries are enabled (igmpv3/mldv2) then look them up first. If
there isn't a present (S,G) entry then try to find (*,G).
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/n
From: Nikolay Aleksandrov
To avoid doing duplicate device checks and searches (the same were done
in br_mdb_add and __br_mdb_add) pass the already found port to __br_mdb_add
and pull the bridge's netif_running and enabled multicast checks to
br_mdb_add. This would also simplify the future extack
From: Nikolay Aleksandrov
Since the MDB add/del code expects an exact struct br_mdb_entry we can't
really add any extensions, thus add a new nested attribute at the level of
MDBA_SET_ENTRY called MDBA_SET_ENTRY_ATTRS which will be used to pass
all new options via netlink attributes. This patch do
From: Nikolay Aleksandrov
Now that we have src and dst in br_ip it is logical to use the src field
for the cases where we need to work with a source address such as
querier source address and group source address.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 4 +--
net/b
From: Nikolay Aleksandrov
This patch adds support for automatic install of S,G mdb entries based
on the port group's source list and the source entry's timer.
Once installed the S,G will be used when forwarding packets if the
approprate multicast/mld versions are set. A new source flag called
BR_
From: Nikolay Aleksandrov
We need to handle group filter mode transitions and initial state.
To change a port group's INCLUDE -> EXCLUDE mode (or when we have added
a new port group in EXCLUDE mode) we need to add that port to all of
*,G ports' S,G entries for proper replication. When the EXCLUDE
From: Nikolay Aleksandrov
To speedup S,G forward handling we need to be able to quickly find out
if a port is a member of an S,G group. To do that add a global S,G port
rhashtable with key: source addr, group addr, protocol, vid (all br_ip
fields) and port pointer.
Signed-off-by: Nikolay Aleksan
From: Nikolay Aleksandrov
We need to avoid forwarding to ports in MCAST_INCLUDE filter mode when the
mdst entry is a *,G or when the port has the blocked flag.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_forward.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
From: Nikolay Aleksandrov
When excluding S,G entries we need a way to block a particular S,G,port.
The new port group flag is managed based on the source's timer as per
RFCs 3376 and 3810. When a source expires and its port group is in
EXCLUDE mode, it will be blocked.
Signed-off-by: Nikolay Ale
From: Nikolay Aleksandrov
Since host joins are considered as EXCLUDE {} joins we need to reflect
that in all of *,G ports' S,G entries. Since the S,Gs can have
host_joined == true only set automatically we can safely set it to false
when removing all automatically added entries upon S,G delete.
From: Nikolay Aleksandrov
We need to be able to differentiate between pg entries created by
user-space and the kernel when we start generating S,G entries for
IGMPv3/MLDv2's fast path. User-space entries are created by default as
RTPROT_STATIC and the kernel entries are RTPROT_KERNEL. Later we ca
On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote:
>
> On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
> > From: Chunxin Zang
> >
> > In the cgroup v1, we have 'force_mepty' interface. This is very
> > useful for userspace to actively release memory. But the cgroup
> > v2 does not.
>
On Mon 21-09-20 18:55:40, Yafang Shao wrote:
> On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote:
> >
> > On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
> > > From: Chunxin Zang
> > >
> > > In the cgroup v1, we have 'force_mepty' interface. This is very
> > > useful for userspace to
> On Sat, Sep 19, 2020 at 02:24:10PM +, David Laight wrote:
> > I thought about that change while writing my import_iovec() =>
> > iovec_import()
> > patch - and thought that the io_uring code would (as usual) cause grief.
> >
> > Christoph - did you see those patches?
Link to cover email.
h
On Fri, Sep 18, 2020 at 1:21 AM Song Liu wrote:
>
> On Thu, Sep 17, 2020 at 7:16 AM Luka Oreskovic
> wrote:
> >
> [...]
>
> > +++ b/kernel/bpf/syscall.c
> > @@ -1475,6 +1475,9 @@ static int map_lookup_and_delete_elem(union bpf_attr
> > *attr)
> > if (CHECK_ATTR(BPF_MAP_LOOKUP_AND_DELETE_
On 18/09/2020 15:33, Dan Carpenter wrote:
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter
Acked-by: Edward Cree
Thanks for catching this.
On 18/09/2020 18:28, Jason Gunthorpe wrote:
> On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote:
>
>> I'm sorry, but you won't be able to convince me here that I need to
>> "enslave" my entire code to RDMA, just because my ASIC "also" has some
>> RDMA ports.
>
> You can't recreate commo
On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote:
>
> On Mon 21-09-20 18:55:40, Yafang Shao wrote:
> > On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote:
> > >
> > > On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
> > > > From: Chunxin Zang
> > > >
> > > > In the cgroup v1, we have
On Mon 21-09-20 19:23:01, Yafang Shao wrote:
> On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote:
> >
> > On Mon 21-09-20 18:55:40, Yafang Shao wrote:
> > > On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote:
> > > >
> > > > On Mon 21-09-20 16:02:55, zangchun...@bytedance.com wrote:
> > > > > Fr
The last return statement is unreachable code. I'm not sure if it will
provoke any warnings, but it looks ugly.
Signed-off-by: Pavel Machek (CIP)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
index 2d55b7c22c03..a804f9
On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote:
> On 18/09/2020 18:28, Jason Gunthorpe wrote:
> > On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote:
> >
> >> I'm sorry, but you won't be able to convince me here that I need to
> >> "enslave" my entire code to RDMA, just becau
On Sun, Sep 20, 2020 at 10:47:02AM +0200, Greg Kroah-Hartman wrote:
> > If not, what open source userspace are you going to ask them to
> > present to merge the kernel side into misc?
>
> I don't think that they have a userspace api to their rdma feature from
> what I understand, but I could be to
drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
`ret` is set but not used. In fact, `ret` should be the right value of
`lan743x_pm_suspend`
function, therefore, fix it.
Signed-off-by: Zheng Yongjun
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file
Move the check for a NULL or zero register to check_helper_mem_access. This
makes check_stack_boundary easier to understand.
Signed-off-by: Lorenz Bauer
Acked-by: Andrii Nakryiko
---
kernel/bpf/verifier.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --g
I'm not sure why, but I missed sending the patchset to netdev@ last
week. I guess that is why it's slipped through the cracks.
Changes in v4:
- Output the desired type on BTF ID mismatch (Martin)
Changes in v3:
- Fix BTF_ID_LIST_SINGLE if BTF is disabled (Martin)
- Drop incorrect arg_btf_id in bp
Instead of dealing with reg->ref_obj_id individually for every arg type that
needs it, rely on the fact that ref_obj_id is zero if the register is not
reference tracked.
Signed-off-by: Lorenz Bauer
Acked-by: Andrii Nakryiko
Acked-by: Martin KaFai Lau
---
kernel/bpf/verifier.c | 26 ++--
check_func_arg has a plethora of weird if statements with empty branches.
They work around the fact that *_OR_NULL argument types should accept a
SCALAR_VALUE register, as long as it's value is 0. These statements make
it difficult to reason about the type checking logic.
Instead, skip more detail
bsearch doesn't modify the contents of the array, so we can take a const
pointer.
Signed-off-by: Lorenz Bauer
Acked-by: Andrii Nakryiko
---
include/linux/bpf.h | 2 +-
kernel/bpf/btf.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/bpf.h b/include/linux
Always check context access if the register we're operating on is
PTR_TO_CTX, rather than relying on ARG_PTR_TO_CTX. This allows
simplifying the arg_type checking section of the function.
Signed-off-by: Lorenz Bauer
Acked-by: Martin KaFai Lau
---
kernel/bpf/verifier.c | 7 ---
1 file change
Add a convenience macro that allows defining a BTF ID list with
a single item. This lets us cut down on repetitive macros.
Signed-off-by: Lorenz Bauer
Suggested-by: Andrii Nakryiko
Acked-by: Martin KaFai Lau
---
include/linux/btf_ids.h | 8
tools/include/linux/btf_ids.h | 8
Function prototypes using ARG_PTR_TO_BTF_ID currently use two ways to signal
which BTF IDs are acceptable. First, bpf_func_proto.btf_id is an array of
IDs, one for each argument. This array is only accessed up to the highest
numbered argument that uses ARG_PTR_TO_BTF_ID and may therefore be less th
If we encounter a pointer to memory, we set meta->raw_mode depending
on the type of memory we point at. What isn't obvious is that this
information is only used when the next memory size argument is
encountered.
Move the assignment closer to where it's used, and add a comment that
explains what is
Move the check for PTR_TO_MAP_VALUE to check_func_arg, where all other
checking is done as well. Move the invocation of process_spin_lock away
from the register type checking, to allow a future refactoring.
Signed-off-by: Lorenz Bauer
Acked-by: Martin KaFai Lau
---
kernel/bpf/verifier.c | 28 ++
Perform BTF type checks if the register we're working on contains a BTF
pointer, rather than if the argument is for a BTF pointer. This is easier
to understand, and allows removing the code from the arg_type checking
section of the function.
Signed-off-by: Lorenz Bauer
Acked-by: Martin KaFai Lau
The mapping between bpf_arg_type and bpf_reg_type is encoded in a big
hairy if statement that is hard to follow. The debug output also leaves
to be desired: if a reg_type doesn't match we only print one of the
options, instead printing all the valid ones.
Convert the if statement into a table whic
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/natsemi/ns83820.c: In function ns83820_get_link_ksettings:
drivers/net/ethernet/natsemi/ns83820.c:1210:11: warning: variable ‘tanar’ set
but not used [-Wunused-but-set-variable]
`tanar` is never used, so remove it.
Signed-off-b
On Tue, Sep 08, 2020 at 09:00:19PM +0800, Zhu, Lingshan wrote:
>
> On 9/8/2020 8:05 PM, Michael S. Tsirkin wrote:
>
> On Mon, Sep 07, 2020 at 06:52:19PM +0800, Zhu Lingshan wrote:
>
> In vhost_vdpa ioctl SET_BACKEND_FEATURES path, currect code
> would try to acquire vhost dev
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/ixgb/ixgb_hw.c: In function ixgb_adapter_stop:
drivers/net/ethernet/intel/ixgb/ixgb_hw.c:101:6: warning: variable ‘icr_reg’
set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/intel/ixgb/ixgb_hw.c: In functio
> +struct bnxt_pcie_stat {
> + const char *name;
> + u16 offset;
> + u8 size;
> + const char *format;
> +};
> +
> +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = {
> + { .name = "PL Signal integrity errors ", .offset = 0, .size = 4,
> .format = "%lld" },
> + { .
On Mon, 21 Sep 2020 11:37:18 +0100
Lorenz Bauer wrote:
> On Sat, 19 Sep 2020 at 00:06, Maciej Żenczykowski wrote:
> >
> > > This is a good point. As bpf_skb_adjust_room() can just be run after
> > > bpf_redirect() call, then a MTU check in bpf_redirect() actually
> > > doesn't make much sense
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/chelsio/cxgb3/ael1002.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/ael1002.c
b/drivers/net/ethernet/chelsio/cxgb3/ael1002.c
index dadf11e3d..9d
Huang Guobin wrote:
> The wilc_wfi_init_mon_int() forgets to clean up resource when
> register_netdevice() failed. Add the missed call to fix it.
> And the return value of netdev_priv can't be NULL, so remove
> the unnecessary error handling.
>
> Fixes: 588713006ea4 ("staging: wilc1000: avoid th
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/wireless/zydas/zd1201.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/zydas/zd1201.c
b/drivers/net/wireless/zydas/zd1201.c
index 41641fc2b..718c4ee86 100644
--- a/drivers
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/intel/ice/ice_fw_update.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c
b/drivers/net/ethernet/intel/ice/ice_fw_update.c
index deaefe0
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index 20dd50
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/freescale/enetc/enetc_vf.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
index f145
Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c:797:6-33: WARNING:
> Comparison to bool
>
> Signed-off-by: Zheng Bin
9 patches applied to wireless-drivers-next.git, thanks.
027a4c9c305f rtlwifi: rtl8192ee: fix comparison to bool warning i
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ecpf.c
b/drivers/net/ethernet/mellanox/mlx5/core/ecpf.c
index a894ea98
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
b/drivers/net/ethernet/mellanox/mlxsw/spect
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ro
Simplify the return expression.
Signed-off-by: Qinglang Miao
---
drivers/connector/connector.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index 2d22d6bf5..7d59d18c6 100644
--- a/drivers/connector/connect
On Wed, Sep 16, 2020 at 11:31 AM Geert Uytterhoeven
wrote:
> On Thu, Aug 20, 2020 at 2:55 PM Yuusuke Ashizuka wrote:
> > When this driver is built as a module, I cannot rmmod it after insmoding
> > it.
> > This is because that this driver calls ravb_mdio_init() at the time of
> > probe, and modul
>-Original Message-
>From: Qinglang Miao
>Sent: Monday, September 21, 2020 4:10 PM
>To: Claudiu Manoil
>Cc: David S. Miller ; Jakub Kicinski
>; netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
>Qinglang Miao
>Subject: [PATCH -next] enetc: simplify the return expression of
>enetc_vf_
Hi Dave,
We have a few more fixes for 5.9, see below.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit 5f6857e808a8bd078296575b417c4b9d160b9779:
nfp: use correct define to return NONE fec (2020-09-17 17:59:12 -0700)
are available in t
Hi Dave,
And for net-next, we have a bit more content. There's more
in the pipeline for S1G (see below), but I figure I'd "flush"
this out, in particular so Felix can take advantage of it in
the driver updates.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/realtek/8139cp.c: In function cp_tx_timeout:
drivers/net/ethernet/realtek/8139cp.c:1242:6: warning: variable ‘rc’ set but
not used [-Wunused-but-set-variable]
`rc` is never used, so remove it.
Signed-off-by: Zheng Yongjun
---
Hi Nikolay,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-IGMPv3-MLDv2-fast-path-part-2/20200921-185933
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem
1 - 100 of 403 matches
Mail list logo
