[PATCH] net: openswitch: reuse the helper variable to improve the code readablity

2020-09-18 Thread Zeng Tao
In the function ovs_ct_limit_exit, there is already a helper vaibale which could be reused to improve the readability, so i fix it in this patch. Signed-off-by: Zeng Tao --- net/openvswitch/conntrack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/conntr

[PATCH -next] rapidio: Remove set but not used variable 'rc'

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/rapidio/rio_cm.c: In function rio_txcq_handler: drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] rc is never used, so remove it. Signed-off-by: Zheng Yongjun --- drivers/rapidio/rio_cm.c

Re: Exposing device ACL setting through devlink

2020-09-18 Thread Jiri Pirko
Thu, Sep 17, 2020 at 10:31:10PM CEST, tlfal...@linux.ibm.com wrote: > >On 9/10/20 2:00 AM, Jiri Pirko wrote: >> Tue, Sep 08, 2020 at 08:27:13PM CEST, tlfal...@linux.ibm.com wrote: >> > On 9/4/20 5:37 PM, Jakub Kicinski wrote: >> > > On Fri, 4 Sep 2020 10:31:41 +0200 Jiri Pirko wrote: >> > > > Thu,

Re: [PATCH -next] rapidio: Remove set but not used variable 'rc'

2020-09-18 Thread Greg KH
On Fri, Sep 18, 2020 at 03:18:44PM +0800, Zheng Yongjun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/rapidio/rio_cm.c: In function rio_txcq_handler: > drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used > [-Wunused-but-set-variable] > > rc is never used

[PATCH net-next 2/3] devlink: Show external port attribute

2020-09-18 Thread Parav Pandit
If a port is for an external controller, port's external attribute is set. Show such external attribute. An example of an external controller port for PCI VF: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev ens2f0c1pf0vf1 flavour pcivf pfnum 0 vfnum 1 external true spl

[PATCH net-next 3/3] devlink: Show controller number of a devlink port

2020-09-18 Thread Parav Pandit
Show the controller number of the devlink port whenever kernel reports it. Example of a PCI VF port for an external controller number 1: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev ens2f0c1pf0vf1 flavour pcivf controller 1 pfnum 0 vfnum 1 external true splittable f

[PATCH net-next 1/3] devlink: Update kernel headers

2020-09-18 Thread Parav Pandit
Update kernel headers to commit: e2ce94dc1d89 ("devlink: introduce the health reporter test command") Signed-off-by: Parav Pandit --- include/uapi/linux/devlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index b7f23faa

[PATCH net-next 0/3] devlink show controller and external info

2020-09-18 Thread Parav Pandit
For certain devlink port flavours controller number and optionally external attributes are reported by the kernel. (a) controller number indicates that a given port belong to which local or external controller. (b) external port attribute indicates that if a given port is for external or local

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-18 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 07:35:03PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency > on VHOST to eliminate build errors. > > ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain': > mr.c:(.text+0x106): undefined r

Re: [PATCH] net: bypass ->sendpage for slab pages

2020-09-18 Thread Coly Li
On 2020/8/22 05:14, David Miller wrote: > From: Christoph Hellwig > Date: Thu, 20 Aug 2020 06:37:44 +0200 > >> If you look at who uses sendpage outside the networking layer itself >> you see that it is basically block driver and file systems. These >> have no way to control what memory they get

[PATCH net-next] net: ethernet: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq: drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ‘val32’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/cavium/liquidio

[PATCH] net/sched: cbs: fix calculation error of idleslope credits

2020-09-18 Thread Xiaoyong Yan
in the function cbs_dequeue_soft, when q->credits< 0, (now- q->last) should be accounted for sendslope, not idleslope. so the solution is as follows: when q->credits is less than 0, directly calculate delay time, activate hrtimer and when hrtimer fires, calculate idleslope credits and update it to

[PATCH net-next] net: cortina: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cortina/gemini.c: In function gmac_get_ringparam: drivers/net/ethernet/cortina/gemini.c:2125:21: warning: variable ‘config0’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/cortina/gemini.c: In function gmac_in

RE: [v3, 6/6] dpaa2-eth: fix a build warning in dpmac.c

2020-09-18 Thread Y.b. Lu
Hi Ioana, > -Original Message- > From: Ioana Ciornei > Sent: Wednesday, September 16, 2020 10:33 PM > To: Y.b. Lu ; netdev@vger.kernel.org > Cc: Y.b. Lu ; David S . Miller ; > Jakub Kicinski ; Ioana Ciocoi Radulescu > ; Richard Cochran > > Subject: RE: [v3, 6/6] dpaa2-eth: fix a build wa

RE: [PATCH] net: phy: realtek: Replace 2.5Gbps name from RTL8125 to RTL8226

2020-09-18 Thread 劉偉權
Hi Andrew, Thanks for your information. Should I do any modifications to make this patch be applied? B.R. Willy -Original Message- From: Andrew Lunn Sent: Thursday, September 17, 2020 9:40 PM To: 劉偉權 Cc: hkallwe...@gmail.com; da...@davemloft.net; li...@armlinux.org.uk; k...@kernel.or

Re: [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-18 Thread Geert Uytterhoeven
Hi Dan, On Thu, Sep 17, 2020 at 8:50 PM Dan Murphy wrote: > On 9/17/20 8:57 AM, Geert Uytterhoeven wrote: > > Some EtherAVB variants support internal clock delay configuration, which > > can add larger delays than the delays that are typically supported by > > the PHY (using an "rgmii-*id" PHY mo

RE: [v3, 5/6] dpaa2-eth: support PTP Sync packet one-step timestamping

2020-09-18 Thread Y.b. Lu
Hi Saeed, > -Original Message- > From: Saeed Mahameed > Sent: Thursday, September 17, 2020 3:23 AM > To: Y.b. Lu ; netdev@vger.kernel.org > Cc: David S . Miller ; Jakub Kicinski > ; Ioana Ciornei ; Ioana Ciocoi > Radulescu ; Richard Cochran > > Subject: Re: [v3, 5/6] dpaa2-eth: support P

[PATCH net-next] hinic: modify irq name

2020-09-18 Thread Luo bin
Make a distinction between different irqs by netdev name or pci name. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 15 +-- drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_rx.c | 2 +- drivers/net/e

[v4, 4/5] dpaa2-eth: utilize skb->cb[0] for hardware timestamping

2020-09-18 Thread Yangbo Lu
This patch is a preparation for next hardware one-step timestamping support. For DPAA2, the one step timestamping configuration on hardware registers has to be done when there is no one-step timestamping packet in flight. So we will have to use workqueue and skb queue for such packets transmitting,

[v4, 1/5] dpaa2-eth: add APIs of 1588 single step timestamping

2020-09-18 Thread Yangbo Lu
This patch is to add APIs of 1588 single step timestamping. - dpni_set_single_step_cfg - dpni_get_single_step_cfg Signed-off-by: Yangbo Lu --- Changes for v2: - None. Changes for v3: - Fixed sparse warnings. Changes for v4: - None. --- drivers/net/ethernet/freescale/dpaa

[v4, 2/5] dpaa2-eth: define a global ptp_qoriq structure pointer

2020-09-18 Thread Yangbo Lu
Define a global ptp_qoriq structure pointer, and export to use. The ptp clock operations will be used in dpaa2-eth driver. For example, supporting one step timestamping needs to write current time to hardware frame annotation before sending and then hardware inserts the delay time on frame during s

[v4, 3/5] dpaa2-eth: invoke dpaa2_eth_enable_tx_tstamp() once in code

2020-09-18 Thread Yangbo Lu
Invoke dpaa2_eth_enable_tx_tstamp() once in code after building FD, rather than calling it in dpaa2_eth_build_single_fd(), dpaa2_eth_build_sg_fd_single_buf(), and dpaa2_eth_build_sg_fd(). Signed-off-by: Yangbo Lu --- Changes for v2: - None. Changes for v3: - None. Changes for v4:

[v4, 0/5] dpaa2_eth: support 1588 one-step timestamping

2020-09-18 Thread Yangbo Lu
This patch-set is to add MC APIs of 1588 one-step timestamping, and support one-step timestamping for PTP Sync packet on DPAA2. Before egress, one-step timestamping enablement needs, - Enabling timestamp and FAS (Frame Annotation Status) in dpni buffer layout. - Write timestamp to frame annota

[v4, 5/5] dpaa2-eth: support PTP Sync packet one-step timestamping

2020-09-18 Thread Yangbo Lu
This patch is to add PTP sync packet one-step timestamping support. Before egress, one-step timestamping enablement needs, - Enabling timestamp and FAS (Frame Annotation Status) in dpni buffer layout. - Write timestamp to frame annotation and set PTP bit in FAS to mark as one-step timestampin

[v2] dpaa2-eth: fix a build warning in dpmac.c

2020-09-18 Thread Yangbo Lu
Fix below sparse warning in dpmac.c. warning: cast to restricted __le64 Signed-off-by: Yangbo Lu --- Changes for v2: - Fixed in right way. --- drivers/net/ethernet/freescale/dpaa2/dpmac-cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/fre

RE: [PATCH 2/2] ptp_qoriq: support FIPER3

2020-09-18 Thread Y.b. Lu
Hi Vladimir, > -Original Message- > From: Vladimir Oltean > Sent: Saturday, September 12, 2020 3:36 PM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; David S . Miller > ; Richard Cochran ; Rob > Herring ; Mark Rutland > Subject: Re: [PATCH 2/2] ptp_qoriq: suppor

RE: [PATCH 2/2] ptp_qoriq: support FIPER3

2020-09-18 Thread Y.b. Lu
Hi Vladimir, > -Original Message- > From: Vladimir Oltean > Sent: Sunday, September 13, 2020 2:32 AM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; David S . Miller > ; Richard Cochran ; Rob > Herring ; Mark Rutland > Subject: Re: [PATCH 2/2] ptp_qoriq: support

[v2, 0/2] ptp_qoriq: support FIPER3

2020-09-18 Thread Yangbo Lu
The FIPER3 (fixed interval period pulse generator) is supported on DPAA2 and ENETC network controller hardware. This patch-set is to support it in ptp_qoriq driver and dt-binding. Changes for v2: - Some improvement in code. - Added ACK from Vladimir. Yangbo Lu (2): dt-binding: ptp_qoriq: suppor

[v2, 2/2] ptp_qoriq: support FIPER3

2020-09-18 Thread Yangbo Lu
The FIPER3 (fixed interval period pulse generator) is supported on DPAA2 and ENETC network controller hardware. This patch is to support it in ptp_qoriq driver. Signed-off-by: Yangbo Lu Acked-by: Vladimir Oltean --- Changes for v2: - Some improvement in code. - Added ACK from Vla

[v2, 1/2] dt-binding: ptp_qoriq: support fsl,tmr-fiper3 property

2020-09-18 Thread Yangbo Lu
Add fsl,tmr-fiper3 property definition which is supported only on DPAA2 and ENETC network controller hardware. Signed-off-by: Yangbo Lu --- Changes for v2: - None. --- Documentation/devicetree/bindings/ptp/ptp-qoriq.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/

Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-18 Thread Jesper Dangaard Brouer
On Thu, 17 Sep 2020 12:11:33 -0700 Saeed Mahameed wrote: > On Thu, 2020-09-17 at 05:54 -0700, Maciej Żenczykowski wrote: > > On Thu, Sep 17, 2020 at 5:39 AM Jesper Dangaard Brouer > > wrote: > > > > > > As you likely know[1] I'm looking into moving the MTU check (for > > > TC-BPF) in __bpf_sk

Re: resolve_btfids breaks kernel cross-compilation

2020-09-18 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 07:54:50AM -0500, Seth Forshee wrote: > On Thu, Sep 17, 2020 at 11:14:06AM +0200, Jiri Olsa wrote: > > On Thu, Sep 17, 2020 at 10:38:12AM +0200, Jiri Olsa wrote: > > > On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > > > > On Wed, Sep 16, 2020 at 02:47:33PM -0500

RE: [PATCH net-next 0/3] devlink show controller and external info

2020-09-18 Thread Parav Pandit
> From: Parav Pandit > Sent: Friday, September 18, 2020 1:33 PM > > For certain devlink port flavours controller number and optionally external > attributes are reported by the kernel. > > (a) controller number indicates that a given port belong to which local or > external controller. > (b) e

[PATCH v3] ptp: mark symbols static where possible

2020-09-18 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

[PATCH iproute2-next RESEND 1/3] devlink: Update kernel headers

2020-09-18 Thread Parav Pandit
Update kernel headers to commit: e2ce94dc1d89 ("devlink: introduce the health reporter test command") Signed-off-by: Parav Pandit --- include/uapi/linux/devlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index b7f23faa

[PATCH iproute2-next RESEND 0/3] devlink show controller and external info

2020-09-18 Thread Parav Pandit
For certain devlink port flavours controller number and optionally external attributes are reported by the kernel. (a) controller number indicates that a given port belong to which local or external controller. (b) external port attribute indicates that if a given port is for external or local

[PATCH iproute2-next RESEND 2/3] devlink: Show external port attribute

2020-09-18 Thread Parav Pandit
If a port is for an external controller, port's external attribute is set. Show such external attribute. An example of an external controller port for PCI VF: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev ens2f0c1pf0vf1 flavour pcivf pfnum 0 vfnum 1 external true spl

[PATCH iproute2-next RESEND 3/3] devlink: Show controller number of a devlink port

2020-09-18 Thread Parav Pandit
Show the controller number of the devlink port whenever kernel reports it. Example of a PCI VF port for an external controller number 1: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev ens2f0c1pf0vf1 flavour pcivf controller 1 pfnum 0 vfnum 1 external true splittable f

[PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:179:14-17: WARNING: Comparison t

[PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c:1897:5-13: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek

[PATCH -next 0/9] rtlwifi: fix comparison to bool warnings

2020-09-18 Thread Zheng Bin
Zheng Bin (9): rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c rtlwifi: rtl8821ae: fix compar

[PATCH -next 1/9] rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c:797:6-33: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/

[PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/w

[PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1839:5-13: WARNING: Comparison t

[PATCH -next 7/9] rtlwifi: rtl8192ce: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:616:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:621:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:626:14-20: WARNING: Comparison to b

[PATCH -next 8/9] rtlwifi: rtl8192de: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:566:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:572:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:581:14-20: WARNING: Comparison to b

[PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/

[PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c

2020-09-18 Thread Zheng Bin
Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:831:14-49: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek

Re: [PATCH bpf-next] selftests/bpf: Fix stat probe in d_path test

2020-09-18 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 02:14:38PM -0700, Alexei Starovoitov wrote: > On Thu, Sep 17, 2020 at 1:25 AM Jiri Olsa wrote: > > > > > Ideally resolve_btfids would parse dwarf info and check > > > whether any of the funcs in allowlist were inlined. > > > That would be more reliable, but not pretty to dr

[PATCH net-next 1/1] l2tp: fix up inconsistent rx/tx statistics

2020-09-18 Thread Tom Parkin
Historically L2TP core statistics count the L2TP header in the per-session and per-tunnel byte counts tracked for transmission and receipt. Now that l2tp_xmit_skb updates tx stats, it is necessary for l2tp_xmit_core to pass out the length of the transmitted packet so that the statistics can be upd

Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-18 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Thu, 17 Sep 2020 12:11:33 -0700 > Saeed Mahameed wrote: > >> On Thu, 2020-09-17 at 05:54 -0700, Maciej Żenczykowski wrote: >> > On Thu, Sep 17, 2020 at 5:39 AM Jesper Dangaard Brouer >> > wrote: >> > > >> > > As you likely know[1] I'm looking into moving t

Re: [PATCHv3] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-09-18 Thread Po-Hsu Lin
Hello folks, any thoughts on this patch? It can make the test pass and reduce the failure numbers in kselftests, it will be great to have this applied. Thanks PHLin On Tue, Sep 8, 2020 at 2:57 PM Po-Hsu Lin wrote: > > On Tue, Sep 8, 2020 at 4:12 AM Jakub Kicinski wrote: > > > > On Mon, 7 Sep

[PATCH net-next 09/11] net: mscc: ocelot: make ocelot_init_timestamp take a const struct ptp_clock_info

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean It is a good measure to ensure correctness if the structures that are meant to remain constant are only processed by functions that thake constant arguments. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_ptp.c | 3 ++- include/soc/mscc/ocelot_ptp.h

[PATCH net-next 08/11] net: dsa: seville: duplicate vsc9959_mdio_bus_free

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean While we don't plan on making any changes to this function, currently this is the only remaining dependency between felix and seville, after the PCS has been refactored out into pcs-lynx.c. Duplicate this function in seville to break the dependency completely. Signed-off-b

[PATCH net-next 05/11] net: dsa: seville: remove unused defines for the mdio controller

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Some definitions were likely copied from drivers/net/mdio/mdio-mscc-miim.c. They are not necessary, remove them. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/dsa/oc

[PATCH net-next 11/11] net: dsa: seville: build as separate module

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Seville does not need to depend on PCI or on the ENETC MDIO controller. There will also be other compile-time differences in the future. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/Kconfig | 22 drivers/net/dsa/ocelot/Makefile

[PATCH net-next 07/11] net: dsa: felix: replace tabs with spaces

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Over the time, some patches have introduced structures aligned with spaces, near structures aligned with tabs. Fix the inconsistencies. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix.c | 2 +- drivers/net/dsa/ocelot/felix.h | 2 +- drive

[PATCH net-next 00/11] Felix DSA driver cleanup: build Seville separately

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean When introducing the Seville switch support to the Felix driver, some technical debt was created. Since both VSC9959 and VSC9953 are embedded switches (one on an arm64 SoC and the other on a powerpc SoC), there is no use case for having the code for both be present in the sa

[PATCH net-next 04/11] net: dsa: ocelot: document why reset procedure is different for felix/seville

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean The overall idea (issue soft reset, enable memories, initialize memories, enable core) is the same, so it would make sense that an attempt is made to unify the procedures. It is not immediately obvious that the fields are not part of the same register targets, though. So ad

[PATCH net-next 10/11] net: dsa: felix: move the PTP clock structure to felix_vsc9959.c

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Not only does Sevile not have a PTP clock, but with separate modules, this structure cannot even live in felix.c, due to the .owner = THIS_MODULE assignment causing this link time error: drivers/net/dsa/ocelot/felix.o:(.data+0x0): undefined reference to `__this_module' Si

[PATCH net-next 06/11] net: dsa: seville: reindent defines for MDIO controller

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Reindent these definitions to be in line with the rest of the driver. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/d

[PATCH net-next 03/11] net: dsa: seville: first enable memories, then initialize them

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean As per documentation, proper startup sequence is: * Enable memories * Initialize memories * Enable core Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/ocelot/s

[PATCH net-next 02/11] net: dsa: seville: don't write to MEM_ENA twice

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean There is another one of these right above the readx_poll_status. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc99

[PATCH net-next 01/11] net: dsa: felix: use ocelot_field_{read,write} helpers consistently

2020-09-18 Thread Vladimir Oltean
From: Vladimir Oltean Since these helpers for regmap fields are available, use them. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix_vsc9959.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/oce

[PATCHv2 bpf-next] selftests/bpf: Fix stat probe in d_path test

2020-09-18 Thread Jiri Olsa
Some kernels builds might inline vfs_getattr call within fstat syscall code path, so fentry/vfs_getattr trampoline is not called. Alexei suggested [1] we should use security_inode_getattr instead, because it's less likely to get inlined. Using this idea also for vfs_truncate (replaced with securit

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Gal Pressman
On 17/09/2020 20:18, Jason Gunthorpe wrote: > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: >> infrastructure for communication between multiple accelerators. Same >> as Nvidia uses NVlink, we use RDMA that we have inside our ASIC. >> The RDMA implementation we did does NOT support s

[PATCH net-next] net: brcmfmac: check return value of driver_for_each_device()

2020-09-18 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 1576 | int ret; | ^~~ driver_for_each_device() has been declared with __must_check, so the return va

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we have

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we have

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > > >> infrastructure for communication between multiple accel

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > > >> infrastructure for communication between multiple accel

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:00 PM Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 08:10:08PM +0300, Oded Gabbay wrote: > > Hello, > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > into the habanalabs driver. > > > > The only modification from v2 is in the et

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabba

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > > On 17/09/2020 20:18, Jason Gunthorpe

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:36 PM Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we have inside

[PATCH 2/2] dev_ioctl: split out SIOC?IFMAP ioctls

2020-09-18 Thread Arnd Bergmann
The ifreq ioctls need a special compat handler at the moment because of the size difference between the struct on native and compat architectures, but this difference exists only for one pair of ioctls, SIOCGIFMAP and SIOCSIFMAP. Splitting these two out of dev_ioctl() into their own higher level i

[PATCH 1/2] ethtool: improve compat ioctl handling

2020-09-18 Thread Arnd Bergmann
The ethtool compat ioctl handling is hidden away in net/socket.c, which introduces a couple of minor oddities: - The implementation may end up diverging, as seen in the RXNFC extension in commit 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches") that doe

[PATCH bpf-next v3 1/5] bpf: expose is_mptcp flag to bpf_tcp_sock

2020-09-18 Thread Nicolas Rybowski
is_mptcp is a field from struct tcp_sock used to indicate that the current tcp_sock is part of the MPTCP protocol. In this protocol, a first socket (mptcp_sock) is created with sk_protocol set to IPPROTO_MPTCP (=262) for control purpose but it isn't directly on the wire. This is the role of the su

[PATCH bpf-next v3 2/5] mptcp: attach subflow socket to parent cgroup

2020-09-18 Thread Nicolas Rybowski
It has been observed that the kernel sockets created for the subflows (except the first one) are not in the same cgroup as their parents. That's because the additional subflows are created by kernel workers. This is a problem with eBPF programs attached to the parent's cgroup won't be executed for

[PATCH bpf-next v3 4/5] bpf: selftests: add MPTCP test base

2020-09-18 Thread Nicolas Rybowski
This patch adds a base for MPTCP specific tests. It is currently limited to the is_mptcp field in case of plain TCP connection because for the moment there is no easy way to get the subflow sk from a msk in userspace. This implies that we cannot lookup the sk_storage attached to the subflow sk in

[PATCH bpf-next v3 3/5] bpf: add 'bpf_mptcp_sock' structure and helper

2020-09-18 Thread Nicolas Rybowski
In order to precisely identify the parent MPTCP connection of a subflow, it is required to access the mptcp_sock's token which uniquely identify a MPTCP connection. This patch adds a new structure 'bpf_mptcp_sock' exposing the 'token' field of the 'mptcp_sock' extracted from a subflow's 'tcp_sock'

[PATCH bpf-next v3 5/5] bpf: selftests: add bpf_mptcp_sock() verifier tests

2020-09-18 Thread Nicolas Rybowski
This patch adds verifier side tests for the new bpf_mptcp_sock() helper. Here are the new tests : - NULL bpf_sock is correctly handled - We cannot access a field from bpf_mptcp_sock if the latter is NULL - We can access a field from bpf_mptcp_sock if the latter is not NULL - We cannot modify a fie

[PATCH bpf-next v3 0/5] bpf: add MPTCP subflow support

2020-09-18 Thread Nicolas Rybowski
Previously it was not possible to make a distinction between plain TCP sockets and MPTCP subflow sockets on the BPF_PROG_TYPE_SOCK_OPS hook. This patch series now enables a fine control of subflow sockets. In its current state, it allows to put different sockopt on each subflow from a same MPTCP c

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Tue, Sep 15, 2020 at 08:10:08PM +0300, Oded Gabbay wrote: > Hello, > > This is the second version of the patch-set to upstream the GAUDI NIC code > into the habanalabs driver. > > The only modification from v2 is in the ethtool patch (patch 12). Details > are in that patch's commit message.

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 02:59:28PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabba

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > > > > > On Fri, Sep 18, 2020 at 02:36:10P

[PATCH bpf-next 2/2] tools resolve_btfids: Always force HOSTARCH

2020-09-18 Thread Jiri Olsa
Seth reported problem with cross builds, that fail on resolve_btfids build, because we are trying to build it on cross build arch. Fixing this by always forcing the host arch. Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object") Reported-by: Seth Forshee Signed-

[PATCH bpf-next 1/2] bpf: Use --no-fail option if CONFIG_BPF is not enabled

2020-09-18 Thread Jiri Olsa
Currently all the resolve_btfids 'users' are under CONFIG_BPF code, so if we have CONFIG_BPF disabled, resolve_btfids will fail, because there's no data to resolve. In case CONFIG_BPF is disabled, using resolve_btfids --no-fail option, that makes resolve_btfids leave quietly if there's no data to

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:19 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > > > On Fri, Sep 18, 2020 at 2:52 PM Leon

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:16 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 02:59:28PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > > On 17/09/2020 20:18, Jason Gunthorpe

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-18 Thread Nikolay Aleksandrov
On Mon, 2020-09-14 at 09:40 +0200, Geert Uytterhoeven wrote: > Hi David, > > CC bridge > > On Sun, Sep 13, 2020 at 3:34 AM David Miller wrote: > > From: Geert Uytterhoeven > > Date: Sat, 12 Sep 2020 14:33:59 +0200 > > > > > "dev" is not the bridge device, but the physical Ethernet interface, w

let import_iovec deal with compat_iovecs as well

2020-09-18 Thread Christoph Hellwig
Hi Al, this series changes import_iovec to transparently deal with comat iovec structures, and then cleanups up a lot of code dupliation. But to get there it first has to fix the pre-existing bug that io_uring compat contexts don't trigger the in_compat_syscall() check. This has so far been rela

[PATCH 3/9] fs: explicitly check for CHECK_IOVEC_ONLY in rw_copy_check_uvector

2020-09-18 Thread Christoph Hellwig
Explicitly check for the magic value insted of implicitly relying on its number representation. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 5db58b8c78d0dd..f153116bc5399b 100

[PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-18 Thread Christoph Hellwig
Add a flag to force processing a syscall as a compat syscall. This is required so that in_compat_syscall() works for I/O submitted by io_uring helper threads on behalf of compat syscalls. Signed-off-by: Christoph Hellwig --- arch/sparc/include/asm/compat.h | 3 ++- arch/x86/include/asm/compat.h

[PATCH 7/9] fs: remove compat_sys_vmsplice

2020-09-18 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native vmsplice syscall can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 2 +- arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +- arch/mips/kernel/syscalls/syscall_o

[PATCH 9/9] security/keys: remove compat_keyctl_instantiate_key_iov

2020-09-18 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native version of keyctl_instantiate_key_iov can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- security/keys/compat.c | 36 ++-- security/keys/internal.h | 5 - security/keys/keyct

[PATCH 4/9] fs: handle the compat case in import_iovec

2020-09-18 Thread Christoph Hellwig
Use in compat_syscall to import either native or the compat iovecs, and remove the now superflous compat_import_iovec. Signed-off-by: Christoph Hellwig --- block/scsi_ioctl.c | 12 +--- drivers/scsi/sg.c | 9 +-- fs/aio.c | 38 +--- fs/io_uring.c | 12

[PATCH 8/9] mm: remove compat_process_vm_{readv,writev}

2020-09-18 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native syscalls can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 4 +- arch/mips/kernel/syscalls/syscall_n32.tbl | 4 +- arch/mips/kernel/syscalls/syscall_o32.tbl

[PATCH 5/9] fs: remove various compat readv/writev helpers

2020-09-18 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs as well, all the duplicated code in the compat readv/writev helpers is not needed. Remove them and switch the compat syscall handlers to use the native helpers. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 179 ---

[PATCH 6/9] fs: remove the compat readv/writev syscalls

2020-09-18 Thread Christoph Hellwig
Now that import_iovec handles compat iovecs, the native readv and writev syscalls can be used for the compat case as well. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/unistd32.h | 4 ++-- arch/mips/kernel/syscalls/syscall_n32.tbl | 4 ++-- arch/mips/ke

  1   2   3   4   >