[PATCH AUTOSEL 5.4 082/330] ipv6_route_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 4fc427e0515811250647d44de38d87d7b0e0790f ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH] batman-adv: Fix orig node refcnt leak when creating neigh node

2020-09-17 Thread Xiyu Yang
batadv_neigh_node_create() is used to create a neigh node object, whose fields will be initialized with the specific object. When a new reference of the specific object is created during the initialization, its refcount should be increased. However, when "neigh_node" object initializes its orig_no

[PATCH AUTOSEL 5.4 080/330] neigh_stat_seq_next() should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 1e3f9f073c47bee7c23e77316b07bc12338c5bba ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 079/330] vcc_seq_next should increase position index

2020-09-17 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 8bf7092021f283944f0c5f4c364853201c45c611 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David

[PATCH AUTOSEL 5.4 059/330] mt76: add missing locking around ampdu action

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 1a817fa73c3b27a593aadf0029de24db1bbc1a3e ] This is needed primarily to avoid races in dealing with rx aggregation related data structures Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7603/main.c | 2 ++

[PATCH AUTOSEL 5.4 058/330] mt76: do not use devm API for led classdev

2020-09-17 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 36f7e2b2bb1de86f0072cd49ca93d82b9e8fd894 ] With the devm API, the unregister happens after the device cleanup is done, after which the struct mt76_dev which contains the led_cdev has already been freed. This leads to a use-after-free bug that can crash the s

[PATCH AUTOSEL 5.4 037/330] ice: Fix to change Rx/Tx ring descriptor size via ethtool with DCBx

2020-09-17 Thread Sasha Levin
From: Usha Ketineni [ Upstream commit c0a3665f71a2f086800abea4d9d14d28269089d6 ] This patch fixes the call trace caused by the kernel when the Rx/Tx descriptor size change request is initiated via ethtool when DCB is configured. ice_set_ringparam() should use vsi->num_txq instead of vsi->alloc_t

[PATCH AUTOSEL 5.4 031/330] net: silence data-races on sk_backlog.tail

2020-09-17 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 9ed498c6280a2f2b51d02df96df53037272ede49 ] sk->sk_backlog.tail might be read without holding the socket spinlock, we need to add proper READ_ONCE()/WRITE_ONCE() to silence the warnings. KCSAN reported : BUG: KCSAN: data-race in tcp_add_backlog / tcp_recvmsg

[PATCH AUTOSEL 5.4 011/330] ath10k: fix array out-of-bounds access

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit c5329b2d5b8b4e41be14d31ee8505b4f5607bf9b ] If firmware reports rate_max > WMI_TPC_RATE_MAX(WMI_TPC_FINAL_RATE_MAX) or num_tx_chain > WMI_TPC_TX_N_CHAIN, it will cause array out-of-bounds access, so print a warning and reset to avoid memory corruption. Tested

[PATCH AUTOSEL 5.4 012/330] ath10k: fix memory leak for tpc_stats_final

2020-09-17 Thread Sasha Levin
From: Miaoqing Pan [ Upstream commit 486a8849843455298d49e694cca9968336ce2327 ] The memory of ar->debug.tpc_stats_final is reallocated every debugfs reading, it should be freed in ath10k_debug_destroy() for the last allocation. Tested HW: QCA9984 Tested FW: 10.4-3.9.0.2-00035 Signed-off-by: Mi

Re: [PATCH v8 bpf-next 0/7] bpf: tailcalls in BPF subprograms

2020-09-17 Thread Alexei Starovoitov
On Wed, Sep 16, 2020 at 2:16 PM Maciej Fijalkowski wrote: > > Changelog: > > v7->v8: > - teach bpf_patch_insn_data to adjust insn_idx of tailcall insn > - address case of clearing tail call counter when bpf2bpf with tailcalls > are mixed > - drop unnecessary checks against cbpf in JIT > - introd

RE: [PATCH net-next v2 4/8] devlink: Support get and set state of port function

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 1:54 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > diff --git a/net/core/devlink.c b/net/core/devlink.c index > > d152489e48da..c82098cb75da 100644 > > --- a/net/core/devlink.c > > +++ b/net/core/devlink.c > > @@ -595,6 +598,40 @@ dev

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 2:01 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > Simulate PCI SF ports. Allow user to create one or more PCI SF ports. > > > > Examples: > > > > Create a PCI PF and PCI SF port. > > $ devlink port add netdevsim/netdevsim10/10 flavour

RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-17 Thread Parav Pandit
Hi Jacob, > From: Jacob Keller > Sent: Friday, September 18, 2020 12:29 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > Prepare code to fill zero or more port function optional attributes. > > Subsequent patch makes use of this to fill more port function > > attributes. > > > > Signed-o

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread David Ahern
On 9/17/20 9:29 PM, Parav Pandit wrote: >>> Examples: >>> >>> Create a PCI PF and PCI SF port. >>> $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ >>> devlink port add netdevsim/netdevsim10/11 flavour pcisf pfnum 0 sfnum >>> 44 $ devlink port show netdevsim/netdevsim10/11 >>> ne

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: Jacob Keller > Sent: Friday, September 18, 2020 12:00 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > A PCI sub-function (SF) represents a portion of the device similar to > > PCI VF. > > > > In an eswitch, PCI SF may have port which is normally represented > > using a represen

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-09-17 Thread Jason Wang
On 2020/9/16 下午7:47, Kishon Vijay Abraham I wrote: Hi Jason, On 16/09/20 8:40 am, Jason Wang wrote: On 2020/9/15 下午11:47, Kishon Vijay Abraham I wrote: Hi Jason, On 15/09/20 1:48 pm, Jason Wang wrote: Hi Kishon: On 2020/9/14 下午3:23, Kishon Vijay Abraham I wrote: Then you need something t

[PATCH net] hinic: fix sending pkts from core while self testing

2020-09-17 Thread Luo bin
Call netif_tx_disable firstly before starting doing self-test to avoid sending packet from networking core and self-test packet simultaneously which may cause self-test failure or hw abnormal. Fixes: 4aa218a4fe77 ("hinic: add self test support") Signed-off-by: Luo bin --- drivers/net/ethernet/hu

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 1:32 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > diff --git a/include/net/devlink.h b/include/net/devlink.h index > > 48b1c1ef1ebd..1edb558125b0 100644 > > --- a/include/net/devlink.h > > +++ b/include/net/devlink.h > > @@ -83,6 +83,

RE: [PATCH net-next v2 2/8] devlink: Support add and delete devlink port

2020-09-17 Thread Parav Pandit
> From: Jacob Keller > Sent: Friday, September 18, 2020 12:13 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > Extended devlink interface for the user to add and delete port. > > Extend devlink to connect user requests to driver to add/delete such > > port in the device. > > > > When driv

[PATCH 6/7 net-next] net: atm: delete duplicated words

2020-09-17 Thread Randy Dunlap
insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/atm/lec.c +++ linux-next-20200917/net/atm/lec.c @@ -1070,7 +1070,7 @@ module_exit(lane_module_cleanup); /* * LANE2: 3.1.3, LE_RESOLVE.request * Non force allocates memory and fills in *tlvs, fills in *sizeoftlvs. - * If sizeoftlvs == NULL

[PATCH 4/7 net-next] net: bluetooth: delete duplicated words

2020-09-17 Thread Randy Dunlap
linux-next-20200917.orig/net/bluetooth/hci_conn.c +++ linux-next-20200917/net/bluetooth/hci_conn.c @@ -1388,7 +1388,7 @@ static int hci_conn_auth(struct hci_conn return 0; } -/* Encrypt the the link */ +/* Encrypt the link */ static void hci_conn_encrypt(struct hci_conn *conn) {

[PATCH 7/7 net-next] net: bridge: delete duplicated words

2020-09-17 Thread Randy Dunlap
ions(+), 2 deletions(-) --- linux-next-20200917.orig/net/bridge/br_ioctl.c +++ linux-next-20200917/net/bridge/br_ioctl.c @@ -103,7 +103,7 @@ static int add_del_if(struct net_bridge /* * Legacy ioctl's through SIOCDEVPRIVATE - * This interface is deprecated because it was too diffic

[PATCH 5/7 net-next] net: tipc: delete duplicated words

2020-09-17 Thread Randy Dunlap
deletions(-) --- linux-next-20200917.orig/net/tipc/msg.c +++ linux-next-20200917/net/tipc/msg.c @@ -582,7 +582,7 @@ bundle: * @pos: position in outer message of msg to be extracted. *Returns position of next msg * Consumes outer buffer when last packet extracted - * Returns true when when t

[PATCH 0/7 net-next] net: various: delete duplicated words

2020-09-17 Thread Randy Dunlap
[PATCH 1/7 net-next] net: core: delete duplicated words [PATCH 2/7 net-next] net: rds: delete duplicated words [PATCH 3/7 net-next] net: ipv6: delete duplicated words [PATCH 4/7 net-next] net: bluetooth: delete duplicated words [PATCH 5/7 net-next] net: tipc: delete duplicated words [PATCH 6/7 ne

[PATCH 3/7 net-next] net: ipv6: delete duplicated words

2020-09-17 Thread Randy Dunlap
Drop repeated words in net/ipv6/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/ipv6/ip6_output.c |2 +- net/ipv6/tcp_ipv6.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/ipv6/ip6_output.c +++

[PATCH 1/7 net-next] net: core: delete duplicated words

2020-09-17 Thread Randy Dunlap
Drop repeated words in net/core/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski --- net/core/dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200917.orig/net/core/dev.c +++ linux-next-20200917/net/core/dev.c @@ -1131

[PATCH 2/7 net-next] net: rds: delete duplicated words

2020-09-17 Thread Randy Dunlap
deletions(-) --- linux-next-20200917.orig/net/rds/cong.c +++ linux-next-20200917/net/rds/cong.c @@ -236,7 +236,7 @@ void rds_cong_queue_updates(struct rds_c *tcp_setsockopt and/or tcp_sendmsg will deadlock *when it tries to get the

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Friday, September 18, 2020 9:08 AM > > On 9/17/20 9:29 PM, Parav Pandit wrote: > >>> Examples: > >>> > >>> Create a PCI PF and PCI SF port. > >>> $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ > >>> devlink port add netdevsim/netdevsim10

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Samudrala, Sridhar
On 9/17/2020 9:41 PM, Parav Pandit wrote: Hi David, From: David Ahern Sent: Friday, September 18, 2020 9:08 AM On 9/17/20 9:29 PM, Parav Pandit wrote: Examples: Create a PCI PF and PCI SF port. $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ devlink port add netdevsim

RE: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, September 18, 2020 10:23 AM > > > On 9/17/2020 9:41 PM, Parav Pandit wrote: > > Hi David, > > > >> From: David Ahern > >> Sent: Friday, September 18, 2020 9:08 AM > >> > >> On 9/17/20 9:29 PM, Parav Pandit wrote: > > Examples: > > > > Cre

Re: [PATCH next] net: fix build without CONFIG_SYSCTL definition

2020-09-17 Thread Randy Dunlap
On 9/17/20 10:08 PM, Mahesh Bandewar wrote: > Earlier commit 316cdaa1158a ("net: add option to not create fall-back > tunnels in root-ns as well") removed the CONFIG_SYSCTL to enable the > kernel-commandline to work. However, this variable gets defined only > when CONFIG_SYSCTL option is selected.

[PATCH] [PATCH v2]ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

[PATCH v2] ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

Re: [PATCH] batman-adv: Fix orig node refcnt leak when creating neigh node

2020-09-17 Thread Sven Eckelmann
On Friday, 18 September 2020 05:03:19 CEST Xiyu Yang wrote: > batadv_neigh_node_create() is used to create a neigh node object, whose > fields will be initialized with the specific object. When a new > reference of the specific object is created during the initialization, > its refcount should be i

[PATCH] net: hns: kerneldoc fixes

2020-09-17 Thread Lu Wei
Fix some parameter description mistakes. Signed-off-by: Lu Wei --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c i

RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-17 Thread 劉偉權
Hi Serge, Thanks for your reply. There is a confidential issue that realtek doesn't offer the detail of a full register layout for configuration register. The default setting for this configuration register should be 0x8148. Basically, no need to change it. If you need to enable RGMII RX Delay

<    1   2   3   4   5