[PATCH net-next 04/13] mptcp: basic sndbuf autotuning

2020-09-11 Thread Paolo Abeni
Let the msk sendbuf track the size of the larger subflow's send window, so that we ensure mptcp_sendmsg() does not exceed MPTCP-level send window. The update is performed just before try to send any data. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 17 + 1 file changed

[PATCH net-next 10/13] mptcp: allow creating non-backup subflows

2020-09-11 Thread Paolo Abeni
Currently the 'backup' attribute of local endpoint is ignored. Let's use it for the MP_JOIN handshake Signed-off-by: Paolo Abeni --- net/mptcp/subflow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 9edcce21715b..58f2349930a

[PATCH net-next 08/13] mptcp: add OoO related mibs

2020-09-11 Thread Paolo Abeni
Add a bunch of MPTCP mibs related to MPTCP OoO data processing. Signed-off-by: Paolo Abeni --- net/mptcp/mib.c | 5 + net/mptcp/mib.h | 5 + net/mptcp/protocol.c | 24 +++- net/mptcp/subflow.c | 1 + 4 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH net-next 00/13] mptcp: introduce support for real multipath xmit

2020-09-11 Thread Paolo Abeni
This series enable MPTCP socket to transmit data on multiple subflows concurrently in a load balancing scenario. First the receive code path is refactored to better deal with out-of-order data (patches 1-7). An RB-tree is introduced to queue MPTCP-level out-of-order data, closely resembling the TC

[PATCH net-next 06/13] mptcp: move ooo skbs into msk out of order queue.

2020-09-11 Thread Paolo Abeni
Add an RB-tree to cope with OoO (at MPTCP level) data. __mptcp_move_skb() insert into the RB tree "future" data, eventually coalescing skb as allowed by the MPTCP DSN. To simplify sequence accounting, move the DSN inside the cb. After successfully enqueuing in sequence data, check if we can use a

Re: [RFC PATCH net-next 03/22] nexthop: Only emit a notification when nexthop is actually deleted

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 04:39:59PM +0200, Jiri Pirko wrote: > Tue, Sep 08, 2020 at 11:10:18AM CEST, ido...@idosch.org wrote: > >From: Ido Schimmel > > > >Currently, the delete notification is emitted from the error path of > >nexthop_add() and replace_nexthop(), which can be confusing to listeners

Re: [PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it

2020-09-11 Thread Willem de Bruijn
On Fri, Sep 11, 2020 at 7:04 AM Xie He wrote: > > This patch tries to clarify the difference between hard_header_len and > needed_headroom by fixing an outdated comment and adding a WARN_ON_ONCE > warning for hard_header_len. > > The difference between hard_header_len and needed_headroom as unders

[PATCH 1/3] Documentation: Update paths of Samsung S3C machine files

2020-09-11 Thread Krzysztof Kozlowski
Documentation references Samsung S3C24xx and S3C64xx machine files in multiple places but the files were traveling around the kernel multiple times. Signed-off-by: Krzysztof Kozlowski --- .../admin-guide/kernel-parameters.txt | 2 +- Documentation/arm/samsung-s3c24xx/gpio.rst| 4 ++

Re: [RFC PATCH net-next 08/22] nexthop: vxlan: Convert to new notification info

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 08:58:07AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Convert the sole listener of the nexthop notification chain (the VXLAN > > driver) to the new notification info. > > > > Signed-off-by: Ido Schimmel > > --- > >

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > This series is a placeholder to show I've about finished this work. > > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings. > > This series removes 1,283 warnings and

Re: VLAN filtering with DSA

2020-09-11 Thread Florian Fainelli
On 9/11/2020 9:30 AM, Vladimir Oltean wrote: On Fri, Sep 11, 2020 at 04:20:58PM +0300, Ido Schimmel wrote: On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: +Ido, On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Florian, can you please reiterate what is the problem with calling

[PATCH net-next v5 1/6] net: dsa: mt7530: Refine message in Kconfig

2020-09-11 Thread Landen Chao
Refine message in Kconfig with fixing typo and an explicit MT7621 support. Signed-off-by: Landen Chao Signed-off-by: Sean Wang Reviewed-by: Florian Fainelli --- drivers/net/dsa/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/Kconfig b/drivers/n

[PATCH bpf-next v2 2/5] mptcp: attach subflow socket to parent cgroup

2020-09-11 Thread Nicolas Rybowski
It has been observed that the kernel sockets created for the subflows (except the first one) are not in the same cgroup as their parents. That's because the additional subflows are created by kernel workers. This is a problem with eBPF programs attached to the parent's cgroup won't be executed for

[net/tls] Re: KMSAN: uninit-value in aes_encrypt (4)

2020-09-11 Thread Eric Biggers
Looks like the tls subsystem is encrypting uninitialized memory again. +tls maintainers and netdev. On Thu, Sep 10, 2020 at 07:09:24AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:3b3ea602 x86: add failure injection to get/put/clear_user > git tree:

[PATCH bpf-next v2 5/5] bpf: selftests: add bpf_mptcp_sock() verifier tests

2020-09-11 Thread Nicolas Rybowski
This patch adds verifier side tests for the new bpf_mptcp_sock() helper. Here are the new tests : - NULL bpf_sock is correctly handled - We cannot access a field from bpf_mptcp_sock if the latter is NULL - We can access a field from bpf_mptcp_sock if the latter is not NULL - We cannot modify a fie

[PATCH net-next v5 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

2020-09-11 Thread Landen Chao
Add devicetree binding to support the compatible mt7531 switch as used in the MediaTek MT7531 switch. Signed-off-by: Sean Wang Signed-off-by: Landen Chao --- .../devicetree/bindings/net/dsa/mt7530.txt | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Doc

[PATCH net-next v5 4/6] net: dsa: mt7530: Add the support of MT7531 switch

2020-09-11 Thread Landen Chao
Add new support for MT7531: MT7531 is the next generation of MT7530. It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu port 6 only supports SGMII interface. Cpu port 5 supports either RGMII or SGMII in different HW sku, but cannot be muxed to

Re: [RFC PATCH net-next 07/22] nexthop: Prepare new notification info

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 08:55:06AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Prepare the new notification information so that it could be passed to > > listeners in the new patch. > > > > Signed-off-by: Ido Schimmel > > --- > > net/ipv4/n

[PATCH net-next v5 6/6] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board

2020-09-11 Thread Landen Chao
Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support. Signed-off-by: Landen Chao --- .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64

Re: [RFC PATCH net-next 05/22] nexthop: Add nexthop notification data structures

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 08:43:10AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Add data structures that will be used for nexthop replace and delete > > notifications in the previously introduced nexthop notification chain. > > > > New data st

[RESEND PATCH 1/3] Bluetooth: Add mgmt suspend and resume events

2020-09-11 Thread Abhishek Pandit-Subedi
Add the controller suspend and resume events, which will signal when Bluetooth has completed preparing for suspend and when it's ready for resume. Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Miao-chen Chou Reviewed-by: Sonny Sasaka --- include/net/bluetooth/hci_core.h | 3 +++ include

[RESEND PATCH 2/3] Bluetooth: Add suspend reason for device disconnect

2020-09-11 Thread Abhishek Pandit-Subedi
Update device disconnect event with reason 0x5 to indicate that device disconnected because the controller is suspending. Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Miao-chen Chou Reviewed-by: Sonny Sasaka --- include/net/bluetooth/mgmt.h | 1 + net/bluetooth/mgmt.c | 4

[RESEND PATCH 3/3] Bluetooth: Emit controller suspend and resume events

2020-09-11 Thread Abhishek Pandit-Subedi
Emit controller suspend and resume events when we are ready for suspend and we've resumed from suspend. The controller suspend event will report whatever suspend state was successfully entered. The controller resume event will check the first HCI event that was received after we finished preparing

Re: [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments

2020-09-11 Thread Edward Cree
On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything

[PATCH net-next v5 2/6] net: dsa: mt7530: Extend device data ready for adding a new hardware

2020-09-11 Thread Landen Chao
Add a structure holding required operations for each device such as device initialization, PHY port read or write, a checker whether PHY interface is supported on a certain port, MAC port setup for either bus pad or a specific PHY interface. The patch is done for ready adding a new hardware MT7531

[RESEND PATCH 0/3] Bluetooth: Emit events for suspend/resume

2020-09-11 Thread Abhishek Pandit-Subedi
Hi Marcel, This series adds the suspend/resume events suggested in https://patchwork.kernel.org/patch/11771001/. I have tested it with some userspace changes that monitors the controller resumed event to trigger audio device reconnection and verified that the events are correctly emitted. Patc

[PATCH net-next v5 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board

2020-09-11 Thread Landen Chao
Add mt7531 dsa to mt7622-rfb1 board for 5 giga Ethernet ports support. mt7622 only supports 1 sgmii interface, so either gmac0 or gmac1 can be configured as sgmii interface. In this patch, change to connect mt7622 gmac0 and mt7531 port6 through sgmii interface. Signed-off-by: Landen Chao --- arc

Re: [PATCH net-next] net/socket.c: Remove an unused header file

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 23:07:20 -0700 Xie He wrote: > This header file is not actually used in this file. Let's remove it. > > Information about this header file: > > This header file comes from the "Frame Relay" module at > drivers/net/wan/dlci.c > > The "Frame Relay" module is used by only one

[PATCH 3/3] ARM: s3c: Bring back notes from removed debug-macro.S

2020-09-11 Thread Krzysztof Kozlowski
Documentation references notes from a removed debug-macro.S file so bring the contents here. Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-s3c/s3c64xx.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c inde

Re: [PATCH] ipv6: remove redundant assignment to variable err

2020-09-11 Thread David Ahern
On 9/11/20 4:35 AM, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read and > it is being updated later with a new value. The initialization is redundant > and can be removed. Also re-order variable declarations in reverse > Christma

[PATCH net-next v4 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board

2020-09-11 Thread Landen Chao
Add mt7531 dsa to mt7622-rfb1 board for 5 giga Ethernet ports support. mt7622 only supports 1 sgmii interface, so either gmac0 or gmac1 can be configured as sgmii interface. In this patch, change to connect mt7622 gmac0 and mt7531 port6 through sgmii interface. Signed-off-by: Landen Chao --- arc

[PATCH net-next v4 6/6] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board

2020-09-11 Thread Landen Chao
Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support. Signed-off-by: Landen Chao --- .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 44 +++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-11 Thread Saeed Mahameed
On Wed, 2020-09-09 at 14:34 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 9 Sep 2020 19:22:02 + > > > Maxim really tried here to avoid this without huge performance > > degradation (~6.4% reduce in packet rate), due to the refactoring > > patches gcc yields non optimal code,

Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments

2020-09-11 Thread Edward Cree
On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 cleanups for ethernet, a million [1] driver comments > had to be cleaned up to get the W=1 compilation to succeed. This > change finally makes the drivers/net/ethernet tree compile with > W=1 set on the command line. > > [1] - ok it

[PATCH net-next v4 1/6] net: dsa: mt7530: Refine message in Kconfig

2020-09-11 Thread Landen Chao
Refine message in Kconfig with fixing typo and an explicit MT7621 support. Signed-off-by: Landen Chao Signed-off-by: Sean Wang Reviewed-by: Florian Fainelli --- drivers/net/dsa/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/Kconfig b/drivers/n

[PATCH net-next v4 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

2020-09-11 Thread Landen Chao
Add devicetree binding to support the compatible mt7531 switch as used in the MediaTek MT7531 switch. Signed-off-by: Sean Wang Signed-off-by: Landen Chao --- .../devicetree/bindings/net/dsa/mt7530.txt | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Doc

[PATCH net-next v4 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-11 Thread Landen Chao
This patch series adds support for MT7531. MT7531 is the next generation of MT7530 which could be found on Mediatek router platforms such as MT7622 or MT7629. It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu port 6 only supports SGMII inter

Re: [PATCH v2 net-next 4/4] Revert "net: dsa: Add more convenient functions for installing port VLANs"

2020-09-11 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 12:52:03PM -0700, Florian Fainelli wrote: > On 9/10/2020 9:48 AM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > This reverts commit 314f76d7a68bab0516aa52877944e6aacfa0fc3f. > > > > Citing that commit message, the call graph was: > > > > dsa_slave_vlan_rx_ad

Re: [PATCH v2 net-next 4/4] Revert "net: dsa: Add more convenient functions for installing port VLANs"

2020-09-11 Thread Florian Fainelli
On 9/11/2020 10:30 AM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 12:52:03PM -0700, Florian Fainelli wrote: On 9/10/2020 9:48 AM, Vladimir Oltean wrote: From: Vladimir Oltean This reverts commit 314f76d7a68bab0516aa52877944e6aacfa0fc3f. Citing that commit message, the call graph was:

Re: [PATCH net-next 11/13] mptcp: allow picking different xmit subflows

2020-09-11 Thread Paolo Abeni
On Fri, 2020-09-11 at 15:52 +0200, Paolo Abeni wrote: [...] > +#define MPTCP_SEND_BURST_SIZE((1 << 16) - \ > + sizeof(struct tcphdr) - \ > + MAX_TCP_OPTION_SPACE - \ > + s

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-11 Thread Marek Behún
On Thu, 10 Sep 2020 22:44:54 +0100 Russell King - ARM Linux admin wrote: > On Thu, Sep 10, 2020 at 10:31:12PM +0200, Marek Behun wrote: > > On Thu, 10 Sep 2020 19:34:35 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > >

Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Edward Cree
On 11/09/2020 16:53, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 21:31:29 +0100 Edward Cree wrote: >> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c >> index 48d91b26f1a2..b0a08d9f4773 100644 >> --- a/drivers/net/ethernet/sfc/tx.c >> +++ b/drivers/net/ethernet/sfc/tx.c >

Re: [PATCH net-next 5/7] sfc: de-indirect TSO handling

2020-09-11 Thread Edward Cree
On 11/09/2020 17:01, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 21:33:11 +0100 Edward Cree wrote: >> index 078c7ec2a70e..272eb5ecb7e7 100644 >> --- a/drivers/net/ethernet/sfc/ef100_tx.c >> +++ b/drivers/net/ethernet/sfc/ef100_tx.c >> @@ -38,7 +38,8 @@ void ef100_tx_init(struct efx_tx_queue *tx_que

Re: [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly

2020-09-11 Thread Vinicius Costa Gomes
Jesse Brandeburg writes: > This takes care of all of the trivial W=1 fixes in the Intel > Ethernet drivers, which allows developers and maintainers to > build more of the networking tree with more complete warning > checks. > > Almost all of the changes were trivial comment updates on > function

Re: [PATCH v2 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY

2020-09-11 Thread Andrew Lunn
On Fri, Sep 11, 2020 at 11:40:20AM +0530, Divya Koppera wrote: > LAN8814 is a low-power, quad-port triple-speed (10BASE-T/100BASETX/1000BASE-T) > Ethernet physical layer transceiver (PHY). It supports transmission and > reception of data on standard CAT-5, as well as CAT-5e and CAT-6, unshielded >

Re: [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Magnus Karlsson
On Fri, Sep 11, 2020 at 2:11 PM Maciej Fijalkowski wrote: > > On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some > > reason, we only allowed main VSIs to be used with zero-copy,

Aw: [PATCH net-next v5 6/6] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board

2020-09-11 Thread Frank Wunderlich
Tested full series on Bananapi-r2 and r64, results as in v3 Tested-By: Frank Wunderlich regards Frank

Re: [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Samudrala, Sridhar
On 9/11/2020 6:10 AM, Maciej Fijalkowski wrote: On Fri, Sep 11, 2020 at 02:29:50PM +0200, Magnus Karlsson wrote: On Fri, Sep 11, 2020 at 2:11 PM Maciej Fijalkowski wrote: On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote: From: Magnus Karlsson Allow VMDQs to be used with A

[PATCH v3 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY

2020-09-11 Thread Divya Koppera
LAN8814 is a low-power, quad-port triple-speed (10BASE-T/100BASETX/1000BASE-T) Ethernet physical layer transceiver (PHY). It supports transmission and reception of data on standard CAT-5, as well as CAT-5e and CAT-6, unshielded twisted pair (UTP) cables. LAN8814 supports industry-standard QSGMII (

[DISCUSS] sfp: sfp controller concept

2020-09-11 Thread Vadym Kochan
Hi, I'd like to discuss a concept of introduction additional entity into SFP subsystem called SFP controller. But lets start with the issue. Issue = There are boards with SFP ports whose GPIO pins are not connected directly to the SoC but to the I2C CPLD device which has ability to read/writ

[PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-11 Thread Florian Fainelli
On 9/11/2020 8:43 AM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 08:09:19PM -0700, Florian Fainelli wrote: On 9/10/2020 5:03 PM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 02:58:04PM -0700, Florian Fainelli wrote: On 9/9/2020 11:34 AM, Florian Fainelli wrote: On 9/9/2020 10:53 AM,

Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

2020-09-11 Thread Florian Fainelli
On 9/10/2020 9:19 PM, Florian Fainelli wrote: Update the B53 driver to support VLANs while not filtering. This requires us to enable VLAN globally within the switch upon driver initial configuration (dev->vlan_enabled). We also need to remove the code that dealt with PVID re-configuration in

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 11:23:28AM -0700, Florian Fainelli wrote: > On 9/11/2020 8:43 AM, Vladimir Oltean wrote: > > > The slightly confusing part is that a vlan_filtering=1 bridge accepts the > > > default_pvid either tagged or untagged whereas a vlan_filtering=0 bridge > > > does not, except for

Re: [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Alexander Duyck
On Fri, Sep 11, 2020 at 11:05 AM Samudrala, Sridhar wrote: > > > > On 9/11/2020 6:10 AM, Maciej Fijalkowski wrote: > > On Fri, Sep 11, 2020 at 02:29:50PM +0200, Magnus Karlsson wrote: > >> On Fri, Sep 11, 2020 at 2:11 PM Maciej Fijalkowski > >> wrote: > >>> > >>> On Fri, Sep 11, 2020 at 02:08:26P

[PATCH net-next 0/3] sfc: misc cleanups

2020-09-11 Thread Edward Cree
Clean up a few nits I noticed while working on TXQ stuff. Edward Cree (3): sfc: remove duplicate call to efx_init_channels from EF100 probe sfc: remove spurious unreachable return statement sfc: cleanups around efx_alloc_channel drivers/net/ethernet/sfc/ef100_nic.c| 4 drivers/net

[PATCH net-next 1/3] sfc: remove duplicate call to efx_init_channels from EF100 probe

2020-09-11 Thread Edward Cree
efx_init_struct already calls this, we don't need to do it again. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef100_nic.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c index fb7752d62ce0..3148fe7703

[PATCH net-next 3/3] sfc: cleanups around efx_alloc_channel

2020-09-11 Thread Edward Cree
The old_channel argument is never used, so remove it. The function is only called from elsewhere in efx_channels.c, so make it static and remove the declaration from the header file. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/efx_channels.c | 5 ++--- drivers/net/ethernet/sfc/efx_c

[PATCH net-next 2/3] sfc: remove spurious unreachable return statement

2020-09-11 Thread Edward Cree
The statement above it already returns, so there is no way to get here. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef100_tx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef100_tx.c b/drivers/net/ethernet/sfc/ef100_tx.c index 078c7ec2a70e..ef9c2e87949

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jesse Brandeburg
Jakub Kicinski wrote: > On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > > Some of these patches are already sent to Intel Wired Lan, but the rest > > of the series titled drivers/net/ethernet affects other drivers, not > > just Intel, but they depend on the first five. > > Great stuf

Re: [PATCH RESEND bpf-next v3 2/9] bpf: verifier: refactor check_attach_btf_id()

2020-09-11 Thread Andrii Nakryiko
On Fri, Sep 11, 2020 at 3:00 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > The check_attach_btf_id() function really does three things: > > 1. It performs a bunch of checks on the program to ensure that the >attachment is valid. > > 2. It stores a bunch of state about

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Fri, Sep 11, 2020 at 09:01:01AM -0700, Nathan Chancellor wrote: > On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > > > Ah great

Re: [PATCH 0/3] xtensa: add seccomp support

2020-09-11 Thread Kees Cook
On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote: > Hello, > > this series adds support for seccomp filter on xtensa and updates > selftests/seccomp. Hi! Firstly, thanks for adding seccomp support! :) I would, however, ask that you CC maintainers on these kinds of changes for feedbac

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-11 Thread Florian Fainelli
On 9/11/2020 11:35 AM, Vladimir Oltean wrote: On Fri, Sep 11, 2020 at 11:23:28AM -0700, Florian Fainelli wrote: On 9/11/2020 8:43 AM, Vladimir Oltean wrote: The slightly confusing part is that a vlan_filtering=1 bridge accepts the default_pvid either tagged or untagged whereas a vlan_filteri

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-11 Thread Florian Fainelli
On 9/11/2020 12:39 PM, Florian Fainelli wrote: On 9/11/2020 11:35 AM, Vladimir Oltean wrote: On Fri, Sep 11, 2020 at 11:23:28AM -0700, Florian Fainelli wrote: On 9/11/2020 8:43 AM, Vladimir Oltean wrote: The slightly confusing part is that a vlan_filtering=1 bridge accepts the default_pvi

Re: [PATCH RESEND bpf-next v3 2/9] bpf: verifier: refactor check_attach_btf_id()

2020-09-11 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Fri, Sep 11, 2020 at 3:00 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

[PATCH net-next 0/7] ethtool: add pause frame stats

2020-09-11 Thread Jakub Kicinski
Hi! This is the first (small) series which exposes some stats via the corresponding ethtool interface. Here (thanks to the excitability of netlink) we expose pause frame stats via the same interfaces as ethtool -a / -A. In particular the following stats from the standard: - 30.3.4.2 aPAUSEMACCtr

[PATCH net-next 8/8] mlx4: add pause frame stats

2020-09-11 Thread Jakub Kicinski
Check if the pause stats are reported by HW by checking the bitmap. Calculation is based on the order of strings in main_strings from ethtool -S. Hopefully the semantics of these stats match the standard.. Signed-off-by: Jakub Kicinski --- .../net/ethernet/mellanox/mlx4/en_ethtool.c | 19 +

[PATCH net-next 5/8] bnxt: add pause frame stats

2020-09-11 Thread Jakub Kicinski
These stats are already reported in ethtool -S. Hopefully they are equivalent to standard stats? Signed-off-by: Jakub Kicinski --- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtoo

[PATCH net-next 7/8] ixgbe: add pause frame stats

2020-09-11 Thread Jakub Kicinski
Report standard pause frame stats. They are already aggregated in struct ixgbe_hw_stats. The combination of the registers is suggested as equivalent to PAUSEMACCtrlFramesTransmitted / PAUSEMACCtrlFramesReceived by the Intel 82576EB datasheet, I could not find any information in the HW actually sup

[PATCH net-next 3/8] netdevsim: add pause frame stats

2020-09-11 Thread Jakub Kicinski
Add minimal ethtool interface for testing ethtool pause stats. Signed-off-by: Jakub Kicinski --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/ethtool.c | 64 +++ drivers/net/netdevsim/netdev.c| 1 + drivers/net/netdevsim/netdevsim.h | 11 +++

[PATCH net-next 2/8] docs: net: include the new ethtool pause stats in the stats doc

2020-09-11 Thread Jakub Kicinski
Tell people that there now is an interface for querying pause frames. A little bit of restructuring is needed given this is a first source of such statistics. Signed-off-by: Jakub Kicinski --- Documentation/networking/statistics.rst | 57 ++--- 1 file changed, 52 insertions(+

[PATCH net-next 6/8] mlx5: add pause frame stats

2020-09-11 Thread Jakub Kicinski
Plumb through all the indirection and copy some code from ethtool -S. The names of the group indicate that these are the stats we are after. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++ .../ethernet/mellanox/mlx5/core/en_ethtool.c | 15 ++ ...

[PATCH net-next 1/8] ethtool: add standard pause stats

2020-09-11 Thread Jakub Kicinski
Currently drivers have to report their pause frames statistics via ethtool -S, and there is a wide variety of names used for these statistics. Add the two statistics defined in IEEE 802.3x to the standard API. Create a new ethtool request header flag for including statistics in the response to GET

[PATCH net-next 4/8] selftests: add a test for ethtool pause stats

2020-09-11 Thread Jakub Kicinski
Make sure the empty nest is reported even without stats. Make sure reporting only selected stats works fine. Signed-off-by: Jakub Kicinski --- .../drivers/net/netdevsim/ethtool-pause.sh| 108 ++ 1 file changed, 108 insertions(+) create mode 100755 tools/testing/selftests/dr

Re: [PATCH RESEND bpf-next v3 3/9] bpf: wrap prog->aux->linked_prog in a bpf_tracing_link

2020-09-11 Thread Andrii Nakryiko
On Fri, Sep 11, 2020 at 3:00 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > The bpf_tracing_link structure is a convenient data structure to contain > the reference to a linked program; in preparation for supporting multiple > attachments for the same freplace program, move

Re: [PATCH 0/3] xtensa: add seccomp support

2020-09-11 Thread Max Filippov
On Fri, Sep 11, 2020 at 12:38 PM Kees Cook wrote: > On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote: > > Hello, > > > > this series adds support for seccomp filter on xtensa and updates > > selftests/seccomp. > > Hi! > > Firstly, thanks for adding seccomp support! :) I would, however,

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 12:00:05 -0700 Jesse Brandeburg wrote: > > I feel slightly bad for saying this but I think your config did not > > include all the drivers, 'cause I'm still getting some warnings after > > patch 11. Regardless this is impressive effort, thanks! > > No worries! I want to get i

Re: [PATCH net-next 5/7] sfc: de-indirect TSO handling

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 18:42:34 +0100 Edward Cree wrote: > > Should tso_version 3 be handled in this switch? > No, because this switch is in the EF10/Siena datapath and is neverrun for >  EF100.  Setting tx_queue->tso_version = 3 for EF100 is really just there >  as documentation — EF100 has a compl

Re: [PATCH 0/8] drivers: net: convert tasklets to use new tasklet_setup()

2020-09-11 Thread David Miller
From: Allen Date: Fri, 11 Sep 2020 11:26:52 +0530 > Will you pick these up or should I send these out again when I > have fixed the two patches on the other thread. Always resend.

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-11 Thread David Miller
From: Allen Date: Fri, 11 Sep 2020 15:30:41 +0530 >> Just add a backpointer to the netdev from the netdev_priv() if you >> absolutely have too. >> > > How does this look? Looks good.

Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 18:36:04 +0100 Edward Cree wrote: > >> + /* We don't have a TXQ of the right type. > >> + * This should never happen, as we don't advertise offload > >> + * features unless we can support them. > >> + */ > >> + return NETDEV_TX_BUS

Re: pull-request: wireless-drivers-next-2020-09-11

2020-09-11 Thread David Miller
From: Kalle Valo Date: Fri, 11 Sep 2020 15:27:13 + > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. Pulled, thanks a lot Kalle.

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-09-11 Thread Anchal Agarwal
On Fri, Aug 28, 2020 at 06:39:45PM +, Anchal Agarwal wrote: > On Fri, Aug 28, 2020 at 08:29:24PM +0200, Rafael J. Wysocki wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the c

Re: [PATCH net-next 3/3] octeontx2-af: add support for custom KPU entries

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 15:21:24 +0200 skard...@marvell.com wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/npc.h > b/drivers/net/ethernet/marvell/octeontx2/af/npc.h > index 6bfb9a9d3003..fe164b85adfb 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/npc.h > +++ b/drivers/net/et

Re: [PATCH net-next v4 0/8] Add GVE Features.

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 10:38:43 -0700 David Awogbemila wrote: > Note: Patch 4 in v3 was dropped. > > Patch 4 (patch 5 in v3): Start/stop timer only when report stats is > enabled/disabled. > Patch 7 (patch 8 in v3): Use netdev_info, not dev_info, to log >

Re: [PATCH RESEND bpf-next v3 3/9] bpf: wrap prog->aux->linked_prog in a bpf_tracing_link

2020-09-11 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Fri, Sep 11, 2020 at 3:00 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The bpf_tracing_link structure is a convenient data structure to contain >> the reference to a linked program; in preparation for supporting multiple >> attachment

Re: [PATCH net-next 0/3] sfc: misc cleanups

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 19:43:26 +0100 Edward Cree wrote: > Clean up a few nits I noticed while working on TXQ stuff. Reviewed-by: Jakub Kicinski

[PATCH v2 3/3] Bluetooth: Emit controller suspend and resume events

2020-09-11 Thread Abhishek Pandit-Subedi
Emit controller suspend and resume events when we are ready for suspend and we've resumed from suspend. The controller suspend event will report whatever suspend state was successfully entered. The controller resume event will check the first HCI event that was received after we finished preparing

[PATCH v2 1/3] Bluetooth: Add mgmt suspend and resume events

2020-09-11 Thread Abhishek Pandit-Subedi
Add the controller suspend and resume events, which will signal when Bluetooth has completed preparing for suspend and when it's ready for resume. Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Miao-chen Chou Reviewed-by: Sonny Sasaka --- Changes in v2: - Added suspend/resume events to lis

[PATCH v2 0/3] Bluetooth: Emit events for suspend/resume

2020-09-11 Thread Abhishek Pandit-Subedi
Hi Marcel, This series adds the suspend/resume events suggested in https://patchwork.kernel.org/patch/11771001/. I have tested it with some userspace changes that monitors the controller resumed event to trigger audio device reconnection and verified that the events are correctly emitted. Patc

[PATCH v2 2/3] Bluetooth: Add suspend reason for device disconnect

2020-09-11 Thread Abhishek Pandit-Subedi
Update device disconnect event with reason 0x5 to indicate that device disconnected because the controller is suspending. Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Miao-chen Chou Reviewed-by: Sonny Sasaka --- Changes in v2: None include/net/bluetooth/mgmt.h | 1 + net/bluetooth/mgmt

Re: [PATCH RESEND bpf-next v3 4/9] bpf: support attaching freplace programs to multiple attach points

2020-09-11 Thread Andrii Nakryiko
On Fri, Sep 11, 2020 at 3:01 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This enables support for attaching freplace programs to multiple attach > points. It does this by amending UAPI for bpf_raw_tracepoint_open with a > target prog fd and btf ID pair that can be used t

Re: [PATCH net-next 7/8] ixgbe: add pause frame stats

2020-09-11 Thread Alexander Duyck
On Fri, Sep 11, 2020 at 12:53 PM Jakub Kicinski wrote: > > Report standard pause frame stats. They are already aggregated > in struct ixgbe_hw_stats. > > The combination of the registers is suggested as equivalent to > PAUSEMACCtrlFramesTransmitted / PAUSEMACCtrlFramesReceived > by the Intel 82576

Re: [PATCH RESEND bpf-next v3 6/9] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-09-11 Thread Andrii Nakryiko
On Fri, Sep 11, 2020 at 3:01 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > Sync addition of new members from main kernel tree. > > Signed-off-by: Toke Høiland-Jørgensen > --- There is no more need to split these updates into separate patches, feel free to fold it into th

Re: [PATCH RESEND bpf-next v3 7/9] libbpf: add support for supplying target to bpf_raw_tracepoint_open()

2020-09-11 Thread Andrii Nakryiko
On Fri, Sep 11, 2020 at 3:00 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This adds support for supplying a target fd and btf ID for the > raw_tracepoint_open() BPF operation, using a new bpf_raw_tracepoint_opts > structure. This can be used for attaching freplace program

Re: [PATCH net-next v4 0/8] Add GVE Features.

2020-09-11 Thread David Miller
From: Jakub Kicinski Date: Fri, 11 Sep 2020 13:55:33 -0700 > On Fri, 11 Sep 2020 10:38:43 -0700 David Awogbemila wrote: >> Note: Patch 4 in v3 was dropped. >> >> Patch 4 (patch 5 in v3): Start/stop timer only when report stats is >> enabled/disabled. >> Patch 7 (patc

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jesse Brandeburg
Jakub Kicinski wrote: > Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered > by the last patch at the end of the email) Ah, good idea, I checked and I have that set, however, I understand what's going on now. > > but I'd like to target the actual job you're running and use

Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

2020-09-11 Thread David Miller
From: Luo Jiaxing Date: Fri, 11 Sep 2020 11:55:58 +0800 > We found the following warning when using W=1 to build kernel: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable > ‘ret’ set but not used [-Wunused-but-set-variable] > int ret, coe = priv->hw->rx_csum; > >

Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

2020-09-11 Thread David Miller
From: Florian Fainelli Date: Fri, 11 Sep 2020 11:28:27 -0700 > > > On 9/10/2020 9:19 PM, Florian Fainelli wrote: >> Update the B53 driver to support VLANs while not filtering. This >> requires us to enable VLAN globally within the switch upon driver >> initial configuration (dev->vlan_enabled).

Re: [PATCH net-next] net/socket.c: Remove an unused header file

2020-09-11 Thread David Miller
From: Xie He Date: Thu, 10 Sep 2020 23:07:20 -0700 > This header file is not actually used in this file. Let's remove it. How did you test this assertion? As Jakub showed, the dlci_ioctl_set() function needs to be declared because socket.c references it. All of your visual scanning of the code

<    1   2   3   >