Re: [net-next v8 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-11 Thread Vadym Kochan
On Thu, Sep 10, 2020 at 06:30:47PM -0700, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 18:00:50 +0300 Vadym Kochan wrote: > > +static int prestera_sdma_tx_wait(struct prestera_sdma *sdma, > > +struct prestera_tx_ring *tx_ring) > > +{ > > + int tx_wait_num = PRESTERA_SDM

Re: [PATCH] Bluetooth: Re-order clearing suspend tasks

2020-09-11 Thread Marcel Holtmann
Hi Abhishek, > Unregister_pm_notifier is a blocking call so suspend tasks should be > cleared beforehand. Otherwise, the notifier will wait for completion > before returning (and we encounter a 2s timeout on resume). > > Fixes: 0e9952804ec9c8 (Bluetooth: Clear suspend tasks on unregister) > Signe

Re: [PATCH v3 2/2] Bluetooth: sco: new getsockopt options BT_SNDMTU/BT_RCVMTU

2020-09-11 Thread Marcel Holtmann
Hi Joseph, > This patch defines new getsockopt options BT_SNDMTU/BT_RCVMTU > for SCO socket to be compatible with other bluetooth sockets. > These new options return the same value as option SCO_OPTIONS > which is already present on existing kernels. > > Reviewed-by: Alain Michaud > Reviewed-by:

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-11 Thread Matthias Schiffer
On Thu, 2020-09-10 at 17:00 +0200, Andrew Lunn wrote: > > I propose that at least these HW modes should be available (and > > documented) for ethernet PHY controlled LEDs: > > mode to determine link on: > > - `link` > > mode for activity (these should blink): > > - `activity` (both rx a

Re: [PATCH 0/2] Bluetooth: Report extended adv capabilities to userspace

2020-09-11 Thread Marcel Holtmann
Hi Daniel, > This series improves the kernel/controller support that is reported > to userspace for the following extended advertising features: > > 1. If extended advertising is available, the number of hardware slots > is used and reported, rather than the fixed default of 5. If no hardware > s

Re: [PATCH 0/3] Bluetooth: Emit events for suspend/resume

2020-09-11 Thread Marcel Holtmann
Hi Abhishek, > This series adds the suspend/resume events suggested in > https://patchwork.kernel.org/patch/11663455/. > > I have tested it with some userspace changes that monitors the > controller resumed event to trigger audio device reconnection and > verified that the events are correctly em

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-11 Thread Laura García Liébana
Hi Daniel, On Tue, Sep 8, 2020 at 2:55 PM Daniel Borkmann wrote: > > Hi Lukas, > > On 9/5/20 7:24 AM, Lukas Wunner wrote: > > On Fri, Sep 04, 2020 at 11:14:37PM +0200, Daniel Borkmann wrote: > >> On 9/4/20 6:21 PM, Lukas Wunner wrote: > [...] > >> The tc queueing layer which is below is not the t

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-11 Thread Jesper Dangaard Brouer
On Thu, 10 Sep 2020 12:35:33 -0600 David Ahern wrote: > On 9/10/20 11:50 AM, Jesper Dangaard Brouer wrote: > > Maybe we should change the devmap-prog approach, and run this on the > > xdp_frame's (in bq_xmit_all() to be precise) . Hangbin's patchset > > clearly shows that we need this "layer" be

Re: KASAN: use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-09-11 Thread Steffen Klassert
On Thu, Sep 10, 2020 at 10:09:50AM +0200, Dmitry Vyukov wrote: > On Thu, Sep 10, 2020 at 10:08 AM B K Karthik wrote: > > > > On Thu, Sep 10, 2020 at 1:32 PM Dmitry Vyukov wrote: > > > > > > On Thu, Sep 10, 2020 at 9:20 AM Anant Thazhemadam > > > wrote: > > > > Looks like this bug is no longer va

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-11 Thread Yunsheng Lin
On 2020/9/11 4:07, Cong Wang wrote: > On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: >> >> Currently there is concurrent reset and enqueue operation for the >> same lockless qdisc when there is no lock to synchronize the >> q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in >>

[PATCH v1 2/2] net: ag71xx: add flow control support

2020-09-11 Thread Oleksij Rempel
Add flow control support. The functionality was tested on AR9331 SoC and confirmed by iperf3 results and HW counters exported over ethtool. Following test configurations was used: iMX6S receiver <--- TL-SG1005D switch < AR9331 sender The switch is supporting symmytric flow control: Settings f

[PATCH v1 0/2] ag71xx: add ethtool and flow control support

2020-09-11 Thread Oleksij Rempel
The main target of this patches is to provide flow control support for ag71xx driver. To be able to validate this functionality, I also added ethtool support with HW counters. So, this patches was validated with iperf3 and counters showing Pause frames send or received by this NIC. Oleksij Rempel

[PATCH v1 1/2] net: ag71xx: add ethtool support

2020-09-11 Thread Oleksij Rempel
Add basic ethtool support. The functionality was tested on AR9331 SoC. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/atheros/ag71xx.c | 147 ++ 1 file changed, 147 insertions(+) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/a

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-11 Thread Yunsheng Lin
On 2020/9/11 16:13, Yunsheng Lin wrote: > On 2020/9/11 4:07, Cong Wang wrote: >> On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: >>> >>> Currently there is concurrent reset and enqueue operation for the >>> same lockless qdisc when there is no lock to synchronize the >>> q->enqueue() in __dev_x

Re: [PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-11 Thread Andrea Parri
> > @@ -740,12 +755,45 @@ static void netvsc_send_completion(struct > > net_device *ndev, > >int budget) > > { > > const struct nvsp_message *nvsp_packet = hv_pkt_data(desc); > > + u32 msglen = hv_pkt_datalen(desc); > > + > > + /* Ensure packet is big enough

Cloudflare L4LB - UNIMOG - using XDP and TC cls

2020-09-11 Thread Marek Majkowski
Hello, I know the community is looking for examples of eBPF usage. David from Cloudflare wrote a blog post about our Layer 4 Load Balancer called UNIMOG. It's a long read but goes into many architectural details: https://blog.cloudflare.com/unimog-cloudflares-edge-load-balancer/ We added the tc

Re: [PATCH] ath11k: Remove unused inline function htt_htt_stats_debug_dump()

2020-09-11 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 9bc260653a1d ath11k: Remove unused inline function htt_htt_stats_debug_dump() -- https://patchwork.kernel.org/pat

[PATCH RESEND bpf-next v3 0/9] bpf: Support multi-attach for freplace programs

2020-09-11 Thread Toke Høiland-Jørgensen
This series adds support attaching freplace BPF programs to multiple targets. This is needed to support incremental attachment of multiple XDP programs using the libxdp dispatcher model. The first three patches are refactoring patches: The first one is a trivial change to the logging in the verifi

[PATCH RESEND bpf-next v3 1/9] bpf: change logging calls from verbose() to bpf_log() and use log pointer

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen In preparation for moving code around, change a bunch of references to env->log (and the verbose() logging helper) to use bpf_log() and a direct pointer to struct bpf_verifier_log. While we're touching the function signature, mark the 'prog' argument to bpf_check_type

Re: [PATCH] ath10k: Remove unused macro ATH10K_ROC_TIMEOUT_HZ

2020-09-11 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 42a08ff79ff5 ath10k: Remove unused macro ATH10K_ROC_TIMEOUT_HZ -- https://patchwork.kernel.org/patch/11765703/ h

[PATCH RESEND bpf-next v3 3/9] bpf: wrap prog->aux->linked_prog in a bpf_tracing_link

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The bpf_tracing_link structure is a convenient data structure to contain the reference to a linked program; in preparation for supporting multiple attachments for the same freplace program, move the linked_prog in prog->aux into a bpf_tracing_link wrapper. With this

[PATCH RESEND bpf-next v3 5/9] bpf: Fix context type resolving for extension programs

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Eelco reported we can't properly access arguments if the tracing program is attached to extension program. Having following program: SEC("classifier/test_pkt_md_access") int test_pkt_md_access(struct __sk_buff *skb) with its extension: SEC("freplace/test_pkt

[PATCH RESEND bpf-next v3 2/9] bpf: verifier: refactor check_attach_btf_id()

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The check_attach_btf_id() function really does three things: 1. It performs a bunch of checks on the program to ensure that the attachment is valid. 2. It stores a bunch of state about the attachment being requested in the verifier environment and struct bpf_p

[PATCH RESEND bpf-next v3 4/9] bpf: support attaching freplace programs to multiple attach points

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This enables support for attaching freplace programs to multiple attach points. It does this by amending UAPI for bpf_raw_tracepoint_open with a target prog fd and btf ID pair that can be used to supply the new attachment point. The target must be compatible with the

Re: [PATCH bpf-next v3 1/9] bpf: change logging calls from verbose() to bpf_log() and use log pointer

2020-09-11 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Sep 10, 2020 at 6:13 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> In preparation for moving code around, change a bunch of references to >> env->log (and the verbose() logging helper) to use bpf_log() and a direct >> pointer to s

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-11 Thread Allen
> >> > > >> > > >> > -static void ace_tasklet(unsigned long arg) > >> > +static void ace_tasklet(struct tasklet_struct *t) > >> > { > >> > - struct net_device *dev = (struct net_device *) arg; > >> > - struct ace_private *ap = netdev_priv(dev); > >> > + struct ace_private *ap = from_ta

[PATCH RESEND bpf-next v3 9/9] selftests/bpf: Adding test for arg dereference in extension trace

2020-09-11 Thread Toke Høiland-Jørgensen
From: Jiri Olsa Adding test that setup following program: SEC("classifier/test_pkt_md_access") int test_pkt_md_access(struct __sk_buff *skb) with its extension: SEC("freplace/test_pkt_md_access") int test_pkt_md_access_new(struct __sk_buff *skb) and tracing that extension with: SEC

[PATCH RESEND bpf-next v3 7/9] libbpf: add support for supplying target to bpf_raw_tracepoint_open()

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds support for supplying a target fd and btf ID for the raw_tracepoint_open() BPF operation, using a new bpf_raw_tracepoint_opts structure. This can be used for attaching freplace programs to multiple destinations. Signed-off-by: Toke Høiland-Jørgensen --- t

[PATCH RESEND bpf-next v3 6/9] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Sync addition of new members from main kernel tree. Signed-off-by: Toke Høiland-Jørgensen --- tools/include/uapi/linux/bpf.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h

[PATCH RESEND bpf-next v3 8/9] selftests: add test for multiple attachments of freplace program

2020-09-11 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds a selftest for attaching an freplace program to multiple targets simultaneously. Signed-off-by: Toke Høiland-Jørgensen --- .../selftests/bpf/prog_tests/fexit_bpf2bpf.c | 171 .../selftests/bpf/progs/freplace_get_constant.c|

[PATCH v2 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY

2020-09-11 Thread Divya Koppera
LAN8814 is a low-power, quad-port triple-speed (10BASE-T/100BASETX/1000BASE-T) Ethernet physical layer transceiver (PHY). It supports transmission and reception of data on standard CAT-5, as well as CAT-5e and CAT-6, unshielded twisted pair (UTP) cables. LAN8814 supports industry-standard QSGMII (

[PATCH net] enetc: Fix mdio bus removal on PF probe bailout

2020-09-11 Thread Claudiu Manoil
This is the correct resolution for the conflict from merging the "net" tree fix: commit 26cb7085c898 ("enetc: Remove the mdio bus on PF probe bailout") with the "net-next" new work: commit 07095c025ac2 ("net: enetc: Use DT protocol information to set up the ports") that moved mdio bus allocation t

Re: linux-next: manual merge of the net-next tree with the net tree

2020-09-11 Thread Paul Barker
On Fri, 11 Sep 2020 at 02:17, Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/dsa/microchip/ksz9477.c > > between commit: > > edecfa98f602 ("net: dsa: microchip: look for phy-mode in port nodes") > > from the net tree and

[PATCH] ipv6: remove redundant assignment to variable err

2020-09-11 Thread Colin King
From: Colin Ian King The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Also re-order variable declarations in reverse Christmas tree ordering. Addresses-Coverity: ("Unused val

Re: [PATCH bpf-next 1/2] bpf: Fix context type resolving for extension programs

2020-09-11 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Wed, Sep 9, 2020 at 8:11 AM Jiri Olsa wrote: >> >> Eelco reported we can't properly access arguments if the tracing >> program is attached to extension program. >> >> Having following program: >> >> SEC("classifier/test_pkt_md_access") >> int test_pkt_md_acces

Re: [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace

2020-09-11 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Sep 9, 2020 at 8:38 AM Jiri Olsa wrote: >> >> Adding test that setup following program: >> >> SEC("classifier/test_pkt_md_access") >> int test_pkt_md_access(struct __sk_buff *skb) >> >> with its extension: >> >> SEC("freplace/test_pkt_md_access") >> int

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > > From: Nathan Chancellor > > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > > > Clang warns (trimmed for brevity): > > > > > > drivers/net/ethernet/marvell/mvpp2/mvp

Re: [PATCH 4.19] net/mlx5e: Don't support phys switch id if not in switchdev mode

2020-09-11 Thread Greg Kroah-Hartman
On Thu, Sep 10, 2020 at 11:46:36AM -0700, Saeed Mahameed wrote: > On Fri, 2020-08-07 at 15:13 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote: > > > From: Roi Dayan > > > > > > Support for phys switch id ndo added for representors and if > > > w

[PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Magnus Karlsson
From: Magnus Karlsson Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some reason, we only allowed main VSIs to be used with zero-copy, but there is now reason to not allow VMDQs also. Signed-off-by: Magnus Karlsson --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +- 1 fil

Re: [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Maciej Fijalkowski
On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote: > From: Magnus Karlsson > > Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some > reason, we only allowed main VSIs to be used with zero-copy, but > there is now reason to not allow VMDQs also. You meant 'to allo

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-11 Thread Andrew Lunn
> - Do all PHYs support manual setting of the LED level, or are the PHYs > that can only work with HW triggers? There are PHYs with do not have simple on/off. > - Is setting PHY registers always efficiently possible, or should SW > triggers be avoided in certain cases? I'm thinking about setups l

[PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-11 Thread Magnus Karlsson
From: Magnus Karlsson In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it signifies that it was not possible to send the packet right now, please try later. Unfortunately, the xsk transmit code discarded the packet and re

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-11 Thread Marek Behún
On Fri, 11 Sep 2020 09:12:01 +0200 Matthias Schiffer wrote: > On Thu, 2020-09-10 at 17:00 +0200, Andrew Lunn wrote: > > > I propose that at least these HW modes should be available (and > > > documented) for ethernet PHY controlled LEDs: > > > mode to determine link on: > > > - `link` > > >

[PATCH net-next v4 2/6] net: dsa: mt7530: Extend device data ready for adding a new hardware

2020-09-11 Thread Landen Chao
Add a structure holding required operations for each device such as device initialization, PHY port read or write, a checker whether PHY interface is supported on a certain port, MAC port setup for either bus pad or a specific PHY interface. The patch is done for ready adding a new hardware MT7531

[PATCH net-next v4 4/6] net: dsa: mt7530: Add the support of MT7531 switch

2020-09-11 Thread Landen Chao
Add new support for MT7531: MT7531 is the next generation of MT7530. It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu port 6 only supports SGMII interface. Cpu port 5 supports either RGMII or SGMII in different HW sku, but cannot be muxed to

Re: VLAN filtering with DSA

2020-09-11 Thread Ido Schimmel
On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: > +Ido, > > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > > Florian, can you please reiterate what is the problem with calling > > vlan_vid_add() with a VLAN that is installed by the bridge? > > > > The effect of vlan_vid_add(), t

Re: [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Maciej Fijalkowski
On Fri, Sep 11, 2020 at 02:29:50PM +0200, Magnus Karlsson wrote: > On Fri, Sep 11, 2020 at 2:11 PM Maciej Fijalkowski > wrote: > > > > On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote: > > > From: Magnus Karlsson > > > > > > Allow VMDQs to be used with AF_XDP sockets in zero-copy m

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-11 Thread Jiri Olsa
On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote: > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > > > Some kernels builds might inline vfs_getattr call within > > fstat syscall code path, so fentry/vfs_getattr trampoline > > is not called. > > > > I'm not sure how to handl

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-11 Thread Jiri Olsa
On Thu, Sep 10, 2020 at 03:22:10PM -0700, Andrii Nakryiko wrote: > On Thu, Sep 10, 2020 at 5:25 AM Jiri Olsa wrote: > > > > Some kernels builds might inline vfs_getattr call within > > fstat syscall code path, so fentry/vfs_getattr trampoline > > is not called. > > > > I'm not sure how to handle t

Re: [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace

2020-09-11 Thread Jiri Olsa
On Thu, Sep 10, 2020 at 03:34:26PM -0700, Andrii Nakryiko wrote: SNIP > > + > > +void test_trace_ext(void) > > +{ > > + struct test_trace_ext_tracing *skel_trace = NULL; > > + struct test_trace_ext_tracing__bss *bss_trace; > > + const char *file = "./test_pkt_md_access.o"; > > +

[PATCH bpf-next v2 4/5] bpf: selftests: add MPTCP test base

2020-09-11 Thread Nicolas Rybowski
This patch adds a base for MPTCP specific tests. It is currently limited to the is_mptcp field in case of plain TCP connection because for the moment there is no easy way to get the subflow sk from a msk in userspace. This implies that we cannot lookup the sk_storage attached to the subflow sk in

[PATCH net-next 12/13] mptcp: call tcp_cleanup_rbuf on subflows

2020-09-11 Thread Paolo Abeni
That is needed to let the subflows announce promptly when new space is available in the receive buffer. tcp_cleanup_rbuf() is currently a static function, drop the scope modifier and add a declaration in the TCP header. Reviewed-by: Mat Martineau Signed-off-by: Paolo Abeni --- include/net/tcp.

[PATCH net-next 02/13] mptcp: set data_ready status bit in subflow_check_data_avail()

2020-09-11 Thread Paolo Abeni
This simplify mptcp_subflow_data_available() and will made follow-up patches simpler. Additionally remove the unneeded checks on subflow copied_seq: we always whole skbs out of subflows. Signed-off-by: Paolo Abeni --- net/mptcp/subflow.c | 19 --- 1 file changed, 8 insertions(+)

[PATCH net-next 09/13] mptcp: move address attribute into mptcp_addr_info

2020-09-11 Thread Paolo Abeni
So that can be accessed easily from the subflow creation helper. No functional change intended. Signed-off-by: Paolo Abeni --- net/mptcp/pm_netlink.c | 39 --- net/mptcp/protocol.h | 5 +++-- net/mptcp/subflow.c| 5 ++--- 3 files changed, 25 insertions

Re: [net-next v5 01/15] virtchnl: Extend AVF ops

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 21:06:05 + Brady, Alan wrote: > > It seems like these are triggering on old messages too, curious why this > > wasn't > > caught sooner. Will fix, thanks. > > > I managed to get a 32-bit build environment setup and found that we > do indeed have alignment issues there on

[PATCH bpf-next v2 0/5] bpf: add MPTCP subflow support

2020-09-11 Thread Nicolas Rybowski
Previously it was not possible to make a distinction between plain TCP sockets and MPTCP subflow sockets on the BPF_PROG_TYPE_SOCK_OPS hook. This patch series now enables a fine control of subflow sockets. In its current state, it allows to put different sockopt on each subflow from a same MPTCP c

[PATCH] vhost: reduce stack usage in log_used

2020-09-11 Thread Li Wang
Fix the warning: [-Werror=-Wframe-larger-than=] drivers/vhost/vhost.c: In function log_used: drivers/vhost/vhost.c:1906:1: warning: the frame size of 1040 bytes is larger than 1024 bytes Signed-off-by: Li Wang --- drivers/vhost/vhost.c | 14 ++ 1 file changed, 10 insertions(+), 4 de

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-09-11 Thread boris . ostrovsky
On 8/21/20 6:22 PM, Anchal Agarwal wrote: > > Known issues: > 1.KASLR causes intermittent hibernation failures. VM fails to resumes and > has to be restarted. I will investigate this issue separately and shouldn't > be a blocker for this patch series. Is there any change in status for this? Thi

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-11 Thread Marcelo Tosatti
On Wed, Sep 09, 2020 at 11:08:17AM -0400, Nitesh Narayan Lal wrote: > In a realtime environment, it is essential to isolate unwanted IRQs from > isolated CPUs to prevent latency overheads. Creating MSIX vectors only > based on the online CPUs could lead to a potential issue on an RT setup > that ha

pull-request: wireless-drivers-next-2020-09-11

2020-09-11 Thread Kalle Valo
Hi, here's a pull request to net-next tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the git repository at: git://git.kernel.

Re: [PATCH net v1] hinic: fix rewaking txq after netif_tx_disable

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 22:04:40 +0800 Luo bin wrote: > When calling hinic_close in hinic_set_channels, all queues are > stopped after netif_tx_disable, but some queue may be rewaken in > free_tx_poll by mistake while drv is handling tx irq. If one queue > is rewaken core may call hinic_xmit_frame to s

Re: [RFC PATCH net-next 10/22] nexthop: Allow setting "offload" and "trap" indications on nexthops

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:14:37AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Add a function that can be called by device drivers to set "offload" or > > "trap" indication on nexthops following nexthop notifications. > > > > Signed-off-by: I

Re: [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 14:08:26 +0200 Magnus Karlsson wrote: > From: Magnus Karlsson > > Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some > reason, we only allowed main VSIs to be used with zero-copy, but > there is now reason to not allow VMDQs also. > > Signed-off-by: Magnus

Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 11:55:58 +0800 Luo Jiaxing wrote: > We found the following warning when using W=1 to build kernel: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable > ‘ret’ set but not used [-Wunused-but-set-variable] > int ret, coe = priv->hw->rx_csum; > > When

Re: [PATCH v1 1/2] net: ag71xx: add ethtool support

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 10:25:27 +0200 Oleksij Rempel wrote: > Add basic ethtool support. The functionality was tested on AR9331 SoC. > > Signed-off-by: Oleksij Rempel Reviewed-by: Jakub Kicinski

[PATCH net-next 1/3] octeontx2-af: fix LD CUSTOM LTYPE aliasing

2020-09-11 Thread skardach
From: Stanislaw Kardach Since LD contains LTYPE definitions tweaked toward efficient NIX_AF_RX_FLOW_KEY_ALG(0..31)_FIELD(0..4) usage, the original location of NPC_LT_LD_CUSTOM0/1 was aliased with MPLS_IN_* definitions. Moving custom frame to value 6 and 7 removes the aliasing at the cost of custo

[PATCH] rndis_host: increase sleep time in the query-response loop

2020-09-11 Thread Olympia Giannou
Some WinCE devices face connectivity issues via the NDIS interface. They fail to register, resulting in -110 timeout errors and failures during the probe procedure. In this kind of WinCE devices, the Windows-side ndis driver needs quite more time to be loaded and configured, so that the linux rndi

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-11 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 08:09:19PM -0700, Florian Fainelli wrote: > On 9/10/2020 5:03 PM, Vladimir Oltean wrote: > > On Thu, Sep 10, 2020 at 02:58:04PM -0700, Florian Fainelli wrote: > > > On 9/9/2020 11:34 AM, Florian Fainelli wrote: > > > > On 9/9/2020 10:53 AM, Vladimir Oltean wrote: > > > > > O

Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

2020-09-11 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 09:19:05PM -0700, Florian Fainelli wrote: > Update the B53 driver to support VLANs while not filtering. This > requires us to enable VLAN globally within the switch upon driver > initial configuration (dev->vlan_enabled). > > We also need to remove the code that dealt with P

[PATCH net-next 3/3] octeontx2-af: add support for custom KPU entries

2020-09-11 Thread skardach
From: Stanislaw Kardach Add ability to load a set of custom KPU entries via firmware APIs. This allows for flexible support for custom protocol parsing and CAM matching. AF driver will attempt to load the profile from the firmware file and verify if it can fit hardware capabilities. If not, it w

Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F_TRAP flag

2020-09-11 Thread David Ahern
On 9/11/20 9:26 AM, Ido Schimmel wrote: > Reworded to: > > " > rtnetlink: Add RTNH_F_TRAP flag > > The flag indicates to user space that the nexthop is not programmed to > forward packets in hardware, but rather to trap them to the CPU. This is > needed, for example, when the MAC of the nexthop n

Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 21:31:29 +0100 Edward Cree wrote: > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index 48d91b26f1a2..b0a08d9f4773 100644 > --- a/drivers/net/ethernet/sfc/tx.c > +++ b/drivers/net/ethernet/sfc/tx.c > @@ -527,6 +527,12 @@ netdev_tx_t efx_hard_start_

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Nathan Chancellor
On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > > Ah great, that is indeed cleaner, thank you for letting me know! > > > > Hmm, I'

Re: [PATCH net-next 5/7] sfc: de-indirect TSO handling

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 21:33:11 +0100 Edward Cree wrote: > index 078c7ec2a70e..272eb5ecb7e7 100644 > --- a/drivers/net/ethernet/sfc/ef100_tx.c > +++ b/drivers/net/ethernet/sfc/ef100_tx.c > @@ -38,7 +38,8 @@ void ef100_tx_init(struct efx_tx_queue *tx_queue) > tx_queue-

Re: [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for transmit timestamping

2020-09-11 Thread Richard Cochran
On Wed, Sep 09, 2020 at 11:00:47AM -0700, Richard Cochran wrote: > On Tue, Sep 08, 2020 at 11:00:41PM +0100, Russell King wrote: > > > +static bool mvpp2_tx_hw_tstamp(struct mvpp2_port *port, > > + struct mvpp2_tx_desc *tx_desc, > > + struct sk_buf

[PATCH net-next 2/3] octeontx2-af: prepare for custom KPU profiles

2020-09-11 Thread skardach
From: Stanislaw Kardach Refactor KPU related NPC code to prepare for upcoming KPU customization functionality. This requires the following: * Gathering all KPU profile related data into a single adapter struct. * Converting the built-in MKEX definition to a structured one to streamline the MKEX

Re: [RFC PATCH net-next 11/22] nexthop: Emit a notification when a nexthop is added

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:21:08AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Emit a notification in the nexthop notification chain when a new nexthop > > is added (not replaced). The nexthop can either be a new group or a > > single nexthop.

Re: [RFC PATCH net-next 13/22] nexthop: Emit a notification when a single nexthop is replaced

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:25:40AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > The notification is emitted after all the validation checks were > > performed, but before the new configuration (i.e., 'struct nh_info') is > > pointed at by the o

Re: [PATCH net-next v5 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

2020-09-11 Thread Florian Fainelli
On 9/11/2020 6:48 AM, Landen Chao wrote: Add devicetree binding to support the compatible mt7531 switch as used in the MediaTek MT7531 switch. Signed-off-by: Sean Wang Signed-off-by: Landen Chao Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F_TRAP flag

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:02:33AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > The flag indicates to user space that the nexthop is not programmed to > > forward packets in hardware, but rather to trap them. > > please elaborate in the commit

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > Ah great, that is indeed cleaner, thank you for letting me know! > > Hmm, I'm not sure why gcc didn't find that. Strangely, the 0-day bot > seems to h

Re: [RFC PATCH net-next 15/22] nexthop: Emit a notification when a nexthop group is reduced

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:33:42AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > When a single nexthop is deleted, the configuration of all the groups > > using the nexthop is effectively modified. In this case, emit a > > notification in the ne

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-11 Thread Daniel Borkmann
On 9/11/20 9:42 AM, Laura García Liébana wrote: On Tue, Sep 8, 2020 at 2:55 PM Daniel Borkmann wrote: On 9/5/20 7:24 AM, Lukas Wunner wrote: On Fri, Sep 04, 2020 at 11:14:37PM +0200, Daniel Borkmann wrote: On 9/4/20 6:21 PM, Lukas Wunner wrote: [...] The tc queueing layer which is below is

Re: VLAN filtering with DSA

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 04:20:58PM +0300, Ido Schimmel wrote: > On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: > > +Ido, > > > > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > > > Florian, can you please reiterate what is the problem with calling > > > vlan_vid_add() with a VLAN

Re: VLAN filtering with DSA

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 07:30:42PM +0300, Vladimir Oltean wrote: > Currently there are other places in the network stack that don't really > work with a network interface that has problems with an interface that > has "rx-vlan-filter: on" in ethtool -k. Wow, I should learn how to write. I meant:

[PATCH net-next 0/3] octeontx2-af: add support for KPU profile customization

2020-09-11 Thread skardach
From: Stanislaw Kardach Marvell octeontx2 NPC device contains a configurable Kanguroo Parser Unit (KPU) and CAM match key data extraction (MKEX). The octeontx2-af driver configures them both to parse a list of standard protocol headers which are used by netdev driver and other potential applicati

[PATCH bpf-next v2 1/5] bpf: expose is_mptcp flag to bpf_tcp_sock

2020-09-11 Thread Nicolas Rybowski
is_mptcp is a field from struct tcp_sock used to indicate that the current tcp_sock is part of the MPTCP protocol. In this protocol, a first socket (mptcp_sock) is created with sk_protocol set to IPPROTO_MPTCP (=262) for control purpose but it isn't directly on the wire. This is the role of the su

[PATCH net-next 05/13] mptcp: introduce and use mptcp_try_coalesce()

2020-09-11 Thread Paolo Abeni
Factor-out existing code, will be re-used by the next patch. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 4f12a8ce0ddd..5a2ff333e426 1006

[PATCH net-next 13/13] mptcp: simult flow self-tests

2020-09-11 Thread Paolo Abeni
Add a bunch of test-cases for multiple subflow xmit: create multiple subflows simulating different links condition via netem and verify that the msk is able to use completely the aggregated bandwidth. Signed-off-by: Paolo Abeni --- tools/testing/selftests/net/mptcp/Makefile| 3 +- .../self

Re: [RFC PATCH net-next 17/22] nexthop: Replay nexthops when registering a notifier

2020-09-11 Thread Ido Schimmel
On Tue, Sep 08, 2020 at 09:37:10AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > When registering a new notifier to the nexthop notification chain, > > replay all the existing nexthops to the new notifier so that it will > > have a complete pict

[PATCH net-next v5 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-11 Thread Landen Chao
This patch series adds support for MT7531. MT7531 is the next generation of MT7530 which could be found on Mediatek router platforms such as MT7622 or MT7629. It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu port 6 only supports SGMII inter

[PATCH net-next] bridge: mcast: Fix incomplete MDB dump

2020-09-11 Thread Ido Schimmel
From: Ido Schimmel Each MDB entry is encoded in a nested netlink attribute called 'MDBA_MDB_ENTRY'. In turn, this attribute contains another nested attributed called 'MDBA_MDB_ENTRY_INFO', which encodes a single port group entry within the MDB entry. The cited commit added the ability to restart

[PATCH 2/3] serial: s3c: Update path of Samsung S3C machine file

2020-09-11 Thread Krzysztof Kozlowski
Correct the path to Samsung S3C24xx machine file, mentioned in documentation. Signed-off-by: Krzysztof Kozlowski --- include/linux/serial_s3c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h index 463ed28d2b27..ca2c5393

[PATCH bpf-next v2 3/5] bpf: add 'bpf_mptcp_sock' structure and helper

2020-09-11 Thread Nicolas Rybowski
In order to precisely identify the parent MPTCP connection of a subflow, it is required to access the mptcp_sock's token which uniquely identify a MPTCP connection. This patch adds a new structure 'bpf_mptcp_sock' exposing the 'token' field of the 'mptcp_sock' extracted from a subflow's 'tcp_sock'

[PATCH net-next 11/13] mptcp: allow picking different xmit subflows

2020-09-11 Thread Paolo Abeni
Update the scheduler to less trivial heuristic: cache the last used subflow, and try to send on it a reasonably long burst of data. When the burst or the subflow send space is exhausted, pick the subflow with the lower ratio between write space and send buffer - that is, the subflow with the great

[PATCH net-next 07/13] mptcp: cleanup mptcp_subflow_discard_data()

2020-09-11 Thread Paolo Abeni
There is no need to use the tcp_read_sock(), we can simply drop the skb. Additionally try to look at the next buffer for in order data. This both simplifies the code and avoid unneeded indirect calls. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.h | 1 - net/mptcp/subflow.c | 58

Re: [RFC PATCH net-next 17/22] nexthop: Replay nexthops when registering a notifier

2020-09-11 Thread David Ahern
On 9/11/20 10:40 AM, Ido Schimmel wrote: >>> @@ -2116,11 +2137,40 @@ static struct notifier_block nh_netdev_notifier = { >>> .notifier_call = nh_netdev_event, >>> }; >>> >>> +static int nexthops_dump(struct net *net, struct notifier_block *nb, >>> +struct netlink_ext_ack

Re: [PATCH net-next v5 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 09:48:50PM +0800, Landen Chao wrote: > This patch series adds support for MT7531. > > MT7531 is the next generation of MT7530 which could be found on Mediatek > router platforms such as MT7622 or MT7629. > > It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports,

[PATCH net-next 03/13] mptcp: trigger msk processing even for OoO data

2020-09-11 Thread Paolo Abeni
This is a prerequisite to allow receiving data from multiple subflows without re-injection. Instead of dropping the OoO - "future" data in subflow_check_data_avail(), call into __mptcp_move_skbs() and let the msk drop that. To avoid code duplication factor out the mptcp_subflow_discard_data() hel

[PATCH net-next 01/13] mptcp: rethink 'is writable' conditional

2020-09-11 Thread Paolo Abeni
Currently, when checking for the 'msk is writable' condition, we look at the individual subflows write space. That works well while we send data via a single subflow, but will not as soon as we will enable concurrent xmit on multiple subflows. With this change msk becomes writable when the followi

  1   2   3   >