[Question] Oops when using connector in linux-4.19

2020-09-05 Thread Yang Yingliang
Hi, I got some crashes when using connector module in linux-4.19: log1: [10385482.776385] Unable to handle kernel paging request at virtual address 0003004c [10385482.777083] Mem abort info: [10385482.777340] ESR = 0x9604 [10385482.777578] Exception class = DABT (current EL), IL

[PATCH net] net: macb: fix for pause frame receive enable bit

2020-09-05 Thread Parshuram Thombare
PAE bit of NCFGR register, when set, pauses transmission if a non-zero 802.3 classic pause frame is received. Fixes: 7897b071ac3b ("net: macb: convert to phylink") Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb_main.c |3 +-- 1 files changed, 1 insertions(+), 2 delet

[PATCH net-next v3 01/15] net: bridge: mdb: arrange internal structs so fast-path fields are close

2020-09-05 Thread Nikolay Aleksandrov
Before this patch we'd need 2 cache lines for fast-path, now all used fields are in the first cache line. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_private.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_private.h b/net/bridge/br_priv

[PATCH net-next v3 03/15] net: bridge: mcast: add support for src list and filter mode dumping

2020-09-05 Thread Nikolay Aleksandrov
Support per port group src list (address and timer) and filter mode dumping. Protected by either multicast_lock or rcu. v3: add IPv6 support v2: require RCU or multicast_lock to traverse src groups Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 21 + net/bridge/

[PATCH net-next v3 04/15] net: bridge: mcast: add support for group-and-source specific queries

2020-09-05 Thread Nikolay Aleksandrov
Allows br_multicast_alloc_query to build queries with the port group's source lists and sends a query for sources over and under lmqt when necessary as per RFCs 3376 and 3810 with the suppress flag set appropriately. v3: add IPv6 support Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mult

[PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-05 Thread Nikolay Aleksandrov
We need to be able to retransmit group-specific and group-and-source specific queries. The new timer takes care of those. v3: add IPv6 support Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 73 +-- net/bridge/br_private.h | 8 + 2 f

[PATCH net-next v3 00/15] net: bridge: mcast: initial IGMPv3/MLDv2 support (part 1)

2020-09-05 Thread Nikolay Aleksandrov
Hi all, This patch-set implements the control plane for initial IGMPv3/MLDv2 support which takes care of include/exclude sets and state transitions based on the different report types. Patch 01 arranges the structure better by moving the frequently used fields together, patches 02 and 03 add suppor

[PATCH net-next v3 09/15] net: bridge: mcast: delete expired port groups without srcs

2020-09-05 Thread Nikolay Aleksandrov
If an expired port group is in EXCLUDE mode, then we have to turn it into INCLUDE mode, remove all srcs with zero timer and finally remove the group itself if there are no more srcs with an active timer. For IGMPv2 use there would be no sources, so this will reduce to just removing the group as bef

[PATCH net-next v3 08/15] net: bridge: mdb: use mdb and port entries in notifications

2020-09-05 Thread Nikolay Aleksandrov
We have to use mdb and port entries when sending mdb notifications in order to fill in all group attributes properly. Before this change we would've used a fake br_mdb_entry struct to fill in only partial information about the mdb. Now we can also reuse the mdb dump fill function and thus have only

[PATCH net-next v3 14/15] net: bridge: mcast: improve IGMPv3/MLDv2 query processing

2020-09-05 Thread Nikolay Aleksandrov
When an IGMPv3/MLDv2 query is received and we're operating in such mode then we need to avoid updating group timers if the suppress flag is set. Also we should update only timers for groups in exclude mode. v3: add IPv6/MLDv2 support Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicas

[PATCH net-next v3 15/15] net: bridge: mcast: destroy all entries via gc

2020-09-05 Thread Nikolay Aleksandrov
Since each entry type has timers that can be running simultaneously we need to make sure that entries are not freed before their timers have finished. In order to do that generalize the src gc work to mcast gc work and use a callback to free the entries (mdb, port group or src). v3: add IPv6 suppo

[PATCH net-next v3 07/15] net: bridge: mdb: push notifications in __br_mdb_add/del

2020-09-05 Thread Nikolay Aleksandrov
This change is in preparation for using the mdb port group entries when sending a notification, so their full state and additional attributes can be filled in. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 20 1 file changed, 8 insertions(+), 12 deletions(-)

[PATCH net-next v3 12/15] net: bridge: mcast: support for IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report

2020-09-05 Thread Nikolay Aleksandrov
In order to process IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report types we need new helpers which allow us to mark entries based on their timer state and to query only marked entries. v3: add IPv6/MLDv2 support, fix other_query checks v2: directly do flag bit operations Signed-off-by: Nikolay Ale

[PATCH net-next v3 10/15] net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report

2020-09-05 Thread Nikolay Aleksandrov
This patch adds handling for the ALLOW_NEW_SOURCES IGMPv3/MLDv2 report types and limits them only when multicast_igmp_version == 3 or multicast_mld_version == 2 respectively. Now that IGMPv3/MLDv2 handling functions will be managing timers we need to delay their activation, thus a new argument is a

[PATCH net-next v3 11/15] net: bridge: mcast: support for IGMPV3/MLDv2 MODE_IS_INCLUDE/EXCLUDE report

2020-09-05 Thread Nikolay Aleksandrov
In order to process IGMPV3/MLDv2_MODE_IS_INCLUDE/EXCLUDE report types we need some new helpers which allow us to set/clear flags for all current entries and later delete marked entries after the report sources have been processed. v3: add IPv6/MLDv2 support v2: drop flag helpers and directly do fl

[PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-05 Thread Nikolay Aleksandrov
In order to avoid future errors and reduce code duplication we should factor out the port group del sequence. This allows us to have one function which takes care of all details when removing a port group. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 15 +- net/brid

[PATCH net-next v3 02/15] net: bridge: mcast: add support for group source list

2020-09-05 Thread Nikolay Aleksandrov
Initial functions for group source lists which are needed for IGMPv3 and MLDv2 include/exclude lists. Both IPv4 and IPv6 sources are supported. User-added mdb entries are created with exclude filter mode, we can extend that later to allow user-supplied mode. When group src entries are deleted, they

[PATCH net-next v3 13/15] net: bridge: mcast: support for IGMPV3/MLDv2 BLOCK_OLD_SOURCES report

2020-09-05 Thread Nikolay Aleksandrov
We already have all necessary helpers, so process IGMPV3/MLDv2 BLOCK_OLD_SOURCES as per the RFCs. v3: add IPv6/MLDv2 support v2: directly do flag bit operations Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 97 +++ 1 file changed, 97 inse

Aw: [PATCH net-next v3 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-05 Thread Frank Wunderlich
tested full series on Bananapi-r64 (mt7531) running iperf3-server [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.00 sec 1.09 GBytes 939 Mbits/sec0 sender [ 5] 0.00-10.01 sec 1.09 GBytes 935 Mbits/sec receiver reverse mode (-R

[PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-05 Thread Wang Hai
BLOCK_PRIV is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Corrected the wrong comment net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index da82

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-05 Thread Michael Chan
On Fri, Sep 4, 2020 at 4:20 PM Baptiste Covolato wrote: > Thank you for proposing this patch. Unfortunately, it appears to make > things worse on my test setup. The problem is a lot easier to > reproduce, and not related to transmit timeout anymore. This patch specifically addresses the issue re

Re: [PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-05 Thread Willem de Bruijn
On Sat, Sep 5, 2020 at 10:53 AM Wang Hai wrote: > > BLOCK_PRIV is never used after it was introduced. > So better to remove it. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Acked-by: Willem de Bruijn

[PATCH] net: Fix some comments

2020-09-05 Thread Miaohe Lin
Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to invalidate dst entries"), we use blackhole_netdev to invalidate dst entries instead of loopback device anymore. Also fix broken NETIF_F_HW_CSUM spell. Signed-off-by: Miaohe Lin --- include/linux/netdev_features.h | 2 +- net/c

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-05 Thread Xie He
On Fri, Sep 4, 2020 at 9:36 PM Jakub Kicinski wrote: > > Applied to net, thank you! Thank you, Jakub!

GET BACK TO US FOR OUR SERVICES

2020-09-05 Thread Shirley A. Campbell
Hi Everyone, My name is Shirley A. Campbell the Manager Investment Dept. of Manulife Investments an accredited Insurance and Finance broker with leading financial institution with extensive policies as one of the largest insurers and financial services. Meanwhile, we refer to our previous email r

INFO: rcu detected stall in __run_timers (5)

2020-09-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:29523c5e bpf: Fix build without BPF_LSM. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=112d38ae90 kernel config: https://syzkaller.appspot.com/x/.config?x=230cd4f722256978 dashboard link: https:/

Re: [net-next PATCH 2/2 v2] net: dsa: rtl8366: Refactor VLAN/PVID init

2020-09-05 Thread Linus Walleij
On Tue, Sep 1, 2020 at 9:14 PM Florian Fainelli wrote: > On 9/1/2020 12:08 PM, Linus Walleij wrote: > [snip] > > > + /* Update the MC entry */ > > + vlanmc.member |= member; > > + vlanmc.untag |= untag; > > + vlanmc.fid = fid; > > Is not there a problem with rtl8366_vlan_del() whi

[net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-05 Thread Linus Walleij
When removing a port from a VLAN we are just erasing the member config for the VLAN, which is wrong: other ports can be using it. Just mask off the port and only zero out the rest of the member config once ports using of the VLAN are removed from it. Reported-by: Florian Fainelli Signed-off-by:

[PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Lukas Bulwahn
Commit 0da4c3d393e4 ("net: phy: add Lynx PCS module") added the files in ./drivers/net/pcs/, but the new LYNX PCS MODULE section refers to ./drivers/net/phy/. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matchesF:drivers/net/phy/pcs-lynx.c Repair

[net-next PATCH] net: gemini: Try to register phy before netdev

2020-09-05 Thread Linus Walleij
It's nice if the phy is online before we register the netdev so try to do that first. Reported-by: David Miller Signed-off-by: Linus Walleij --- drivers/net/ethernet/cortina/gemini.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cortina/gemini

Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64

2020-09-05 Thread Marc Zyngier
On Fri, 04 Sep 2020 10:27:42 +0100, Jianyong Wu wrote: > > Currently, there is no mechanism to keep time sync between guest and host > in arm64 virtualization environment. Time in guest will drift compared > with host after boot up as they may both use third party time sources > to correct their

Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp.

2020-09-05 Thread Marc Zyngier
On Fri, 04 Sep 2020 10:27:41 +0100, Jianyong Wu wrote: > > ptp_kvm will get this service through smccc call. > The service offers wall time and counter cycle of host for guest. > caller must explicitly determines which cycle of virtual counter or > physical counter to return if it needs counter c

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-05 Thread Laura García Liébana
Hi John, On Fri, Sep 4, 2020 at 5:46 PM John Fastabend wrote: > > Laura García Liébana wrote: > > Hi, > > > > On Thu, Sep 3, 2020 at 7:00 AM John Fastabend > > wrote: > > > > > [...] > > > > > > I don't think it actualy improves performance at least I didn't observe > > > that. From the code it

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-05 Thread Laura García Liébana
Hi Daniel, On Fri, Sep 4, 2020 at 11:14 PM Daniel Borkmann wrote: > [...] > > Its trivial to achieve with tc/BPF on the existing egress hook today. Probably > takes less time than to write up this mail ... > > root@x:~/x# cat foo.c > > #include > #include > #include > > #ifndef __section > # d

Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64

2020-09-05 Thread Marc Zyngier
On Fri, 04 Sep 2020 10:27:42 +0100, Jianyong Wu wrote: > > Currently, there is no mechanism to keep time sync between guest and host > in arm64 virtualization environment. Time in guest will drift compared > with host after boot up as they may both use third party time sources > to correct their

[PATCH 1/4] net: dsa: microchip: Make switch detection more informative

2020-09-05 Thread Paul Barker
To make switch detection more informative print the result of the ksz9477/ksz9893 compatibility check. With debug output enabled also print the contents of the Chip ID registers as a 40-bit hex string. As this detection is the first communication with the switch performed by the driver, making it

[PATCH 2/4] net: dsa: microchip: Add debug print for XMII port mode

2020-09-05 Thread Paul Barker
When debug is enabled for this driver, this allows users to confirm that the correct port mode is in use. Signed-off-by: Paul Barker --- drivers/net/dsa/microchip/ksz9477.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ks

[PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893

2020-09-05 Thread Paul Barker
We can't assume that the link partner supports the in-band status reporting which is enabled by default on the KSZ9893 when using RGMII for the upstream port. Signed-off-by: Paul Barker --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa

[PATCH 4/4] net: dsa: microchip: Implement recommended reset timing

2020-09-05 Thread Paul Barker
The datasheet for the ksz9893 and ksz9477 switches recommend waiting at least 100us after the de-assertion of reset before trying to program the device through any interface. Also switch the existing mdelay() call to usleep_range() as recommended in Documentation/timers/timers-howto.rst. The 2ms r

[PATCH 0/4] ksz9477 dsa switch driver improvements

2020-09-05 Thread Paul Barker
These changes were made while debugging the ksz9477 driver for use on a custom board which uses the ksz9893 switch supported by this driver. The patches have been runtime tested on top of Linux 5.8.4, I couldn't runtime test them on top of 5.9-rc3 due to unrelated issues. They have been build teste

Re: [RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-09-05 Thread Boqun Feng
On Sat, Sep 05, 2020 at 02:55:48AM +, Michael Kelley wrote: > From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 > PM > > > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when > > communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE > > as the unit for page re

Re: [PATCH 1/4] net: dsa: microchip: Make switch detection more informative

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 03:03:22PM +0100, Paul Barker wrote: > To make switch detection more informative print the result of the > ksz9477/ksz9893 compatibility check. With debug output enabled also > print the contents of the Chip ID registers as a 40-bit hex string. > > As this detection is the

Re: [PATCH 2/4] net: dsa: microchip: Add debug print for XMII port mode

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 03:03:23PM +0100, Paul Barker wrote: > When debug is enabled for this driver, this allows users to confirm that > the correct port mode is in use. > > Signed-off-by: Paul Barker > --- > drivers/net/dsa/microchip/ksz9477.c | 4 > 1 file changed, 4 insertions(+) > > d

Re: [PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 03:03:24PM +0100, Paul Barker wrote: > We can't assume that the link partner supports the in-band status > reporting which is enabled by default on the KSZ9893 when using RGMII > for the upstream port. What do you mean by RGMII inband status reporting? SGMII/1000BaseX has i

Re: [PATCH 0/4] ksz9477 dsa switch driver improvements

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 03:03:21PM +0100, Paul Barker wrote: > These changes were made while debugging the ksz9477 driver for use on a > custom board which uses the ksz9893 switch supported by this driver. The > patches have been runtime tested on top of Linux 5.8.4, I couldn't > runtime test them

Re: [PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-05 Thread Andrew Lunn
On Fri, Sep 04, 2020 at 02:37:30PM -0700, Florian Fainelli wrote: > Registering our slave MDIO bus outside of the OF infrastructure is > necessary in order to avoid creating double references of the same > Device Tree nodes, however it is not sufficient to guarantee that the > MDIO bus diversion is

RE: [RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-09-05 Thread Michael Kelley
From: Boqun Feng Sent: Saturday, September 5, 2020 7:15 AM > > On Sat, Sep 05, 2020 at 02:55:48AM +, Michael Kelley wrote: > > From: Boqun Feng Sent: Tuesday, September 1, 2020 > > 8:01 PM > > > > > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when > > > communicating with Hype

Re: [PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 12:37:00PM +0200, Lukas Bulwahn wrote: > Commit 0da4c3d393e4 ("net: phy: add Lynx PCS module") added the files in > ./drivers/net/pcs/, but the new LYNX PCS MODULE section refers to > ./drivers/net/phy/. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:

[PATCH bpf-next] samples: bpf: refactor xdp_sample_pkts_kern with BTF-defined map

2020-09-05 Thread Daniel T. Lee
Most of the samples were converted to use the new BTF-defined MAP as they moved to libbbpf, but some of the samples were missing. Instead of using the previous BPF MAP definition, this commit refactors xdp_sample_pkts_kern MAP definition with the new BTF-defined MAP format. Signed-off-by: Daniel

Re: [net-next PATCH] net: gemini: Try to register phy before netdev

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 12:45:30PM +0200, Linus Walleij wrote: > It's nice if the phy is online before we register the netdev > so try to do that first. Hi Linus The PHY handling in this driver is all a bit odd. gmac_open() will also try to connect the PHY if it has not already been found. gmac_

Re: [PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893

2020-09-05 Thread Paul Barker
On Sat, 5 Sep 2020 at 16:32, Andrew Lunn wrote: > > On Sat, Sep 05, 2020 at 03:03:24PM +0100, Paul Barker wrote: > > We can't assume that the link partner supports the in-band status > > reporting which is enabled by default on the KSZ9893 when using RGMII > > for the upstream port. > > What do yo

Re: [PATCH 0/4] ksz9477 dsa switch driver improvements

2020-09-05 Thread Paul Barker
On Sat, 5 Sep 2020 at 16:34, Andrew Lunn wrote: > > On Sat, Sep 05, 2020 at 03:03:21PM +0100, Paul Barker wrote: > > These changes were made while debugging the ksz9477 driver for use on a > > custom board which uses the ksz9893 switch supported by this driver. The > > patches have been runtime te

Re: [PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893

2020-09-05 Thread Florian Fainelli
On 9/5/2020 8:53 AM, Paul Barker wrote: On Sat, 5 Sep 2020 at 16:32, Andrew Lunn wrote: On Sat, Sep 05, 2020 at 03:03:24PM +0100, Paul Barker wrote: We can't assume that the link partner supports the in-band status reporting which is enabled by default on the KSZ9893 when using RGMII for t

Re: [PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893

2020-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 04:53:20PM +0100, Paul Barker wrote: > On Sat, 5 Sep 2020 at 16:32, Andrew Lunn wrote: > > > > On Sat, Sep 05, 2020 at 03:03:24PM +0100, Paul Barker wrote: > > > We can't assume that the link partner supports the in-band status > > > reporting which is enabled by default on

Re: [PATCH net-next v2 4/6] net: mvpp2: ptp: add TAI support

2020-09-05 Thread Richard Cochran
On Fri, Sep 04, 2020 at 08:29:27AM +0100, Russell King wrote: > Add support for the TAI block in the mvpp2.2 hardware. > > Signed-off-by: Russell King Acked-by: Richard Cochran A few minor questions/comments follow... > diff --git a/drivers/net/ethernet/marvell/Kconfig > b/drivers/net/ethern

[PATCH 0/3 v4 net-next] 8390: core cleanups

2020-09-05 Thread Armin Wolf
The purpose of this patchset is to do some cleanups in lib8390.c and 8390.c. While most changes are coding-style related, pr_cont() usage in lib8390.c was replaced by a more SMP-safe construct. Other functional changes include the removal of version-printing in lib8390.c so modules using lib8390.

[PATCH 1/3 v4 net-next] lib8390: Fix coding-style issues and remove verion printing

2020-09-05 Thread Armin Wolf
Fix various checkpatch warnings. Remove version printing so modules including lib8390 do not have to provide a global version string for successful compilation. Replace pr_cont() with SMP-safe construct. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/lib8390.c | 590 ++

[PATCH 2/3 v4 net-next] 8390: Miscellaneous cleanups

2020-09-05 Thread Armin Wolf
Replace version string with MODULE_* macros. Include necessary libraries. Fix two minor coding-style issues. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/8390.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/8390/8390.

[PATCH 3/3 v4 net-next] 8390: Remove version string

2020-09-05 Thread Armin Wolf
Remove unused version string in modules which are including lib8390 and replace him with MODULE_* macros if necessary. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/8390p.c | 18 +++--- drivers/net/ethernet/8390/ax88796.c | 3 --- drivers/net/ethernet/8390/etherh.c

Re: [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:57 -0500 Dan Murphy wrote: > Add the ability to advertise the Fiber connection if the strap or the > op-mode is configured for 100Base-FX. > > Auto negotiation is not supported on this PHY when in fiber mode. > > Signed-off-by: Dan Murphy Some comments, I'm not very phy

[PATCH] net: Add a missing word

2020-09-05 Thread Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index b9c6f31ae96eb..36c22e60910c5 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6293,7 +6293,7 @@ EXPORT_SYMBOL(__napi_schedule); *

Re: [PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:58 -0500 Dan Murphy wrote: > This adds WoL support on TI DP83869 for magic, magic secure, unicast and > broadcast. > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/dp83869.c | 128 ++ > 1 file changed, 128 insertions(+) > > diff

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > +{ > + int val, count; > + > + if (cnt > DP83869_DOWNSHIFT_8_COUNT) > + return -E2BIG; ERANGE > + if (!cnt) > + return phy_clear_bits(ph

Re: [Question] Oops when using connector in linux-4.19

2020-09-05 Thread Cong Wang
On Sat, Sep 5, 2020 at 12:28 AM Yang Yingliang wrote: > > Hi, > > I got some crashes when using connector module in linux-4.19: Can you test a reasonably recent kernel? > The invalid address[0x0003004c] is the value of nlmsghdr from cn > netlink, nlmsg_type is 3 and nlmsg_len is 0x4c.

Re: [PATCH v2 net-next 0/6] sfc: TXQ refactor

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 22:30:58 +0100 Edward Cree wrote: > Refactor and unify partner-TXQ handling in the EF100 and legacy drivers. > > The main thrust of this series is to remove from the legacy (Siena/EF10) > driver the assumption that a netdev TX queue has precisely two hardware > TXQs (checksumm

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: > + devlink_flash_update_status_notify(dl, "Downloading", NULL, 0, > fw->size); > + offset = 0; > + next_interval = fw->size / IONIC_FW_INTERVAL_FRACTION; > + while (offset < fw->size) { > + copy_sz = min_t(unsign

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: > +/* The worst case wait for the install activity is about 25 minutes when > + * installing a new CPLD, which is very seldom. Normal is about 30-35 > + * seconds. Since the driver can't tell if a CPLD update will happen we > + * set the ti

RE: [PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Ioana Ciornei
> Subject: [PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE > > Commit 0da4c3d393e4 ("net: phy: add Lynx PCS module") added the files in > ./drivers/net/pcs/, but the new LYNX PCS MODULE section refers to > ./drivers/net/phy/. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns

Re: [PATCH 2/3 v4 net-next] 8390: Miscellaneous cleanups

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 19:44:11 +0200 Armin Wolf wrote: > Replace version string with MODULE_* macros. > > Include necessary libraries. > > Fix two minor coding-style issues. These 3 may be better as separate commits. > diff --git a/drivers/net/ethernet/8390/8390.c > b/drivers/net/ethernet/8390/83

Re: [PATCH 1/3 v4 net-next] lib8390: Fix coding-style issues and remove verion printing

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 19:43:17 +0200 Armin Wolf wrote: > Fix various checkpatch warnings. > > Remove version printing so modules including lib8390 do not > have to provide a global version string for successful > compilation. > > Replace pr_cont() with SMP-safe construct. > > Signed-off-by: Armin W

Re: [PATCH] MAINTAINERS: repair reference in LYNX PCS MODULE

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 12:37:00 +0200 Lukas Bulwahn wrote: > Commit 0da4c3d393e4 ("net: phy: add Lynx PCS module") added the files in > ./drivers/net/pcs/, but the new LYNX PCS MODULE section refers to > ./drivers/net/phy/. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: > >

Re: [net-next PATCH] net: gemini: Try to register phy before netdev

2020-09-05 Thread Linus Walleij
On Sat, Sep 5, 2020 at 5:50 PM Andrew Lunn wrote: > The PHY handling in this driver is all a bit odd. > > gmac_open() will also try to connect the PHY if it has not already > been found. gmac_stop() does not seem to have a symmetrical > phy_disconnect. However, gmac_uninit does? > > I do wonder i

[net-next PATCH v2] net: gemini: Clean up phy registration

2020-09-05 Thread Linus Walleij
It's nice if the phy is online before we register the netdev so try to do that first. Stop trying to do "second tried" to register the phy, it works perfectly fine the first time. Stop remvoving the phy in uninit. Remove it when the driver is remove():d, symmetric to where it is added, in probe()

Re: [PATCH v5 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-05 Thread Vladimir Oltean
On Fri, Sep 04, 2020 at 08:27:34AM +0200, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time A

Re: [PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure MDIO diversion is used

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 14:37:28 -0700 Florian Fainelli wrote: > Changes in v2: > > - export of_update_property() to permit building bcm_sf2 as a module > - provided a better explanation of the problem being solved after > explaining it to Andrew during the v1 review Applied, thanks everyone!

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Shannon Nelson
On 9/5/20 12:52 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: + devlink_flash_update_status_notify(dl, "Downloading", NULL, 0, fw->size); + offset = 0; + next_interval = fw->size / IONIC_FW_INTERVAL_FRACTION; + while (offset < fw->siz

[PATCH bpf v1] tools/libbpf: avoid counting local symbols in ABI check

2020-09-05 Thread Tony Ambardar
Encountered the following failure building libbpf from kernel 5.8.5 sources with GCC 8.4.0 and binutils 2.34: (long paths shortened) Warning: Num of global symbols in sharedobjs/libbpf-in.o (234) does NOT match with num of versioned symbols in libbpf.so (236). Please make sure all LIBBPF_API

[PATCH] net: dsa: rtl8366rb: Support setting MTU

2020-09-05 Thread Linus Walleij
This implements the missing MTU setting for the RTL8366RB switch. Apart from supporting jumboframes, this rids us of annoying boot messages like this: realtek-smi switch: nonfatal error -95 setting MTU on port 0 Signed-off-by: Linus Walleij --- drivers/net/dsa/rtl8366rb.c | 38 +

[PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket

2020-09-05 Thread Jens Axboe
No functional changes in this patch, needed to provide io_uring support for shutdown(2). Cc: netdev@vger.kernel.org Cc: David S. Miller Signed-off-by: Jens Axboe --- There's a trivial io_uring patch that depends on this one. If this one is acceptable to you, I'd like to queue it up in the io_u

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Shannon Nelson
On 9/5/20 1:04 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: +/* The worst case wait for the install activity is about 25 minutes when + * installing a new CPLD, which is very seldom. Normal is about 30-35 + * seconds. Since the driver can't tell if a CPLD

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 14:47:58 -0700 Shannon Nelson wrote: > On 9/5/20 12:52 PM, Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: > >> + if (offset > next_interval) { > >> + devlink_flash_update_status_notify(dl, "Downloading", > >> +

Re: [PATCH v2 net-next 2/2] ionic: add devlink firmware update

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 15:06:07 -0700 Shannon Nelson wrote: > On 9/5/20 1:04 PM, Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 17:05:34 -0700 Shannon Nelson wrote: > >> +/* The worst case wait for the install activity is about 25 minutes when > >> + * installing a new CPLD, which is very seldom. Nor

Question about dev_validate_header used in af_packet.c

2020-09-05 Thread Xie He
Hi Willem, I have a question about the function dev_validate_header used in af_packet.c. Can you help me? Thanks! I see when the length of the data is smaller than hard_header_len, and when the user is "capable" enough, the function will accept it and pad it with 0s, without validating the header

Re: [PATCH net v1 0/2] hinic: BugFixes

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 16:37:27 +0800 Luo bin wrote: > The bugs fixed in this patchset have been present since the following > commits: > patch #1: Fixes: 00e57a6d4ad3 ("net-next/hinic: Add Tx operation") > patch #2: Fixes: 5e126e7c4e52 ("hinic: add firmware update support") Applied.

Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket

2020-09-05 Thread Jakub Kicinski
On Sat, 5 Sep 2020 16:05:48 -0600 Jens Axboe wrote: > No functional changes in this patch, needed to provide io_uring support > for shutdown(2). > > Cc: netdev@vger.kernel.org > Cc: David S. Miller > Signed-off-by: Jens Axboe > > --- > > There's a trivial io_uring patch that depends on this on

[net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-05 Thread Linus Walleij
This switches the RTL8366RB over to using phylink callbacks instead of .adjust_link(). This is a pretty template switchover. All we adjust is the CPU port so that is why the code only inspects this port. We enhance by adding proper error messages, also disabling the CPU port on the way down and mo

Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket

2020-09-05 Thread Jens Axboe
On 9/5/20 4:39 PM, Jakub Kicinski wrote: > On Sat, 5 Sep 2020 16:05:48 -0600 Jens Axboe wrote: >> No functional changes in this patch, needed to provide io_uring support >> for shutdown(2). >> >> Cc: netdev@vger.kernel.org >> Cc: David S. Miller >> Signed-off-by: Jens Axboe >> >> --- >> >> There'

Re: [PATCH net] cxgb4: Fix offset when clearing filter byte counters

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 15:58:18 +0530 Ganji Aravind wrote: > Pass the correct offset to clear the stale filter hit > bytes counter. Otherwise, the counter starts incrementing > from the stale information, instead of 0. > > Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") > Signed-off

Re: [PATCH net-next] caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 20:58:58 +0800 Wang Hai wrote: > Remove SRVL_CTRL_PKT_SIZE which is defined more than once. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied, thanks.

Re: [PATCH net-next] NFC: digital: Remove two unused macroes

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 21:01:57 +0800 Wang Hai wrote: > DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced. > DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below > commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()") > Remove them. > > Reported-by: Hu

Re: Question about dev_validate_header used in af_packet.c

2020-09-05 Thread Xie He
On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote: > > Hi Willem, > > I have a question about the function dev_validate_header used in > af_packet.c. Can you help me? Thanks! > > I see when the length of the data is smaller than hard_header_len, and > when the user is "capable" enough, the function will

Re: [PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 19:52:18 -0700 Dexuan Cui wrote: > mlx5_suspend()/resume() keep the network interface, so during hibernation > netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence > netvsc_resume() should call netvsc_vf_changed() to switch the data path > back to the VF aft

Re: [PATCH net-next v3 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:58 +0800 Landen Chao wrote: > @@ -32,10 +33,13 @@ Required properties for the child nodes within ports > container: > > - reg: Port address described must be 6 for CPU port and from 0 to 5 for > user ports. > -- phy-mode: String, must be either "trgmii" or "rgmii"

Re: [PATCH net-next v3 2/6] net: dsa: mt7530: Extend device data ready for adding a new hardware

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:57 +0800 Landen Chao wrote: > +static bool > +mt7530_phy_mode_supported(struct dsa_switch *ds, int port, > + const struct phylink_link_state *state) > { > struct mt7530_priv *priv = ds->priv; > - u32 mcr_cur, mcr_new; > > switch (por

Re: [PATCH net-next v3 4/6] net: dsa: mt7530: Add the support of MT7531 switch

2020-09-05 Thread Jakub Kicinski
On Fri, 4 Sep 2020 22:21:59 +0800 Landen Chao wrote: > +static int > +mt7531_cpu_port_config(struct dsa_switch *ds, int port) > +{ > + struct mt7530_priv *priv = ds->priv; > + phy_interface_t interface; > + int speed; > + > + switch (port) { > + case 5: > + if (mt753

Re: WARNING: refcount bug in l2cap_chan_put

2020-09-05 Thread syzbot
syzbot suspects this issue was fixed by commit: commit b83764f9220a4a14525657466f299850bbc98de9 Author: Miao-chen Chou Date: Tue Jun 30 03:15:00 2020 + Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11aaff5

Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-05 Thread Florian Fainelli
+Russell, On 9/5/2020 3:48 PM, Linus Walleij wrote: This switches the RTL8366RB over to using phylink callbacks instead of .adjust_link(). This is a pretty template switchover. All we adjust is the CPU port so that is why the code only inspects this port. We enhance by adding proper error messa

Re: [PATCH] net: dsa: rtl8366rb: Support setting MTU

2020-09-05 Thread Florian Fainelli
On 9/5/2020 2:59 PM, Linus Walleij wrote: This implements the missing MTU setting for the RTL8366RB switch. Apart from supporting jumboframes, this rids us of annoying boot messages like this: realtek-smi switch: nonfatal error -95 setting MTU on port 0 Signed-off-by: Linus Walleij Review

Re: [PATCH v20 14/23] LSM: Ensure the correct LSM context releaser

2020-09-05 Thread Paul Moore
On Wed, Aug 26, 2020 at 11:16 AM Casey Schaufler wrote: > > Add a new lsmcontext data structure to hold all the information > about a "security context", including the string, its size and > which LSM allocated the string. The allocation information is > necessary because LSMs have different polic

[PATCH net 1/2] bnxt_en: Avoid sending firmware messages when AER error is detected.

2020-09-05 Thread Michael Chan
From: Vasundhara Volam When the driver goes through PCIe AER reset in error state, all firmware messages will timeout because the PCIe bus is no longer accessible. This can lead to AER reset taking many minutes to complete as each firmware command takes time to timeout. Define a new macro BNXT_

  1   2   >