[PATCH net-next v3 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board

2020-09-04 Thread Landen Chao
Add mt7531 dsa to mt7622-rfb1 board for 5 giga Ethernet ports support. mt7622 only supports 1 sgmii interface, so either gmac0 or gmac1 can be configured as sgmii interface. In this patch, change to connect mt7622 gmac0 and mt7531 port6 through sgmii interface. Signed-off-by: Landen Chao --- arc

Re: [PATCH net-next 0/3] net: phy: Support enabling clocks prior to bus probe

2020-09-04 Thread Andrew Lunn
On Fri, Sep 04, 2020 at 04:00:55PM +0200, Adam Rudziński wrote: > W dniu 2020-09-04 o 15:45, Andrew Lunn pisze: > > > Just a bunch of questions. > > > > > > Actually, why is it necessary to have a full MDIO bus scan already during > > > probing peripherals? > > That is the Linux bus model. It does

Re: [PATCHv10 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2020-09-04 Thread Daniel Borkmann
On 9/3/20 12:26 PM, Hangbin Liu wrote: Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v10: remove us

Re: [PATCH v2 net-next 6/9] bpf: helpers: add bpf_xdp_adjust_mb_header helper

2020-09-04 Thread Lorenzo Bianconi
> On Fri, 4 Sep 2020 09:50:31 +0200 > Lorenzo Bianconi wrote: > > > > On Thu, Sep 03, 2020 at 10:58:50PM +0200, Lorenzo Bianconi wrote: > > > > +BPF_CALL_2(bpf_xdp_adjust_mb_header, struct xdp_buff *, xdp, > > > > + int, offset) > > > > +{ > > > > + void *data_hard_end, *data_en

Re: [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring is full

2020-09-04 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2020 15:53:25 +0200 Björn Töpel wrote: > On my machine the "one core scenario Rx drop" performance went from > ~65Kpps to 21Mpps. In other words, from "not usable" to > "usable". YMMV. We have observed this kind of dropping off an edge before with softirq (when userspace process r

Re: [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring is full

2020-09-04 Thread Björn Töpel
On 2020-09-04 16:27, Jesper Dangaard Brouer wrote: On Fri, 4 Sep 2020 15:53:25 +0200 Björn Töpel wrote: On my machine the "one core scenario Rx drop" performance went from ~65Kpps to 21Mpps. In other words, from "not usable" to "usable". YMMV. We have observed this kind of dropping off an e

Re: [PATCH] net/packet: fix overflow in tpacket_rcv

2020-09-04 Thread gre...@linuxfoundation.org
On Fri, Sep 04, 2020 at 02:22:46PM +, Nuernberger, Stefan wrote: > On Fri, 2020-09-04 at 16:16 +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 04, 2020 at 03:30:52PM +0200, Stefan Nuernberger wrote: > > > > > > From: Or Cohen > > > > > > Using tp_reserve to calculate netoff can overflow as

Re: KASAN: use-after-free Write in refcount_warn_saturate

2020-09-04 Thread syzbot
syzbot suspects this issue was fixed by commit: commit b83764f9220a4a14525657466f299850bbc98de9 Author: Miao-chen Chou Date: Tue Jun 30 03:15:00 2020 + Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10f92e3

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Jakub Kicinski
On Thu, 3 Sep 2020 17:05:32 -0700 Shannon Nelson wrote: > Add support for using devlink's dev flash facility to update the > firmware on an ionic device. This is a simple model of pushing the > firmware file to the NIC, asking the NIC to unpack and install the file > into the device, and then sel

Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 09:15:24 + Henrik Bjoernlund wrote: > + rcu_read_lock(); > + b_port = rcu_dereference(mep->b_port); > + if (!b_port) > + return NULL; > + skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH); > + if (!skb) > + return NULL; net/bridge/br_c

Re: [net-next 04/10] net/mlx5e: Unify constants for WQE_EMPTY_DS_COUNT

2020-09-04 Thread Willem de Bruijn
On Thu, Sep 3, 2020 at 11:01 PM Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > A constant for the number of DS in an empty WQE (i.e. a WQE without data > segments) is needed in multiple places (normal TX data path, MPWQE in > XDP), but currently we have a constant for XDP and an inline fo

Re: [net-next 09/10] net/mlx5e: Move TX code into functions to be used by MPWQE

2020-09-04 Thread Willem de Bruijn
On Thu, Sep 3, 2020 at 11:01 PM Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > mlx5e_txwqe_complete performs some actions that can be taken to separate > functions: > > 1. Update the flags needed for hardware timestamping. > > 2. Stop the TX queue if it's full. > > Take these actions into

Re: [PATCH bpf-next 3/6] xsk: introduce xsk_do_redirect_rx_full() helper

2020-09-04 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2020 15:53:28 +0200 Björn Töpel wrote: > From: Björn Töpel > > The xsk_do_redirect_rx_full() helper can be used to check if a failure > of xdp_do_redirect() was due to the AF_XDP socket had a full Rx ring. This is very AF_XDP specific. I think that the cpumap could likely benef

Re: [PATCH v2 net-next 1/9] xdp: introduce mb in xdp_buff/xdp_frame

2020-09-04 Thread David Ahern
On 9/4/20 1:19 AM, Jesper Dangaard Brouer wrote: > On Thu, 3 Sep 2020 18:07:05 -0700 > Alexei Starovoitov wrote: > >> On Thu, Sep 03, 2020 at 10:58:45PM +0200, Lorenzo Bianconi wrote: >>> Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer to specify >>> if shared_info area has been properly

Re: [PATCH v2 net-next 6/9] bpf: helpers: add bpf_xdp_adjust_mb_header helper

2020-09-04 Thread John Fastabend
Lorenzo Bianconi wrote: > > Lorenzo Bianconi wrote: > > > Introduce bpf_xdp_adjust_mb_header helper in order to adjust frame > > > headers moving *offset* bytes from/to the second buffer to/from the > > > first one. > > > This helper can be used to move headers when the hw DMA SG is not able > > >

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-09-04 Thread Marek Vasut
On 9/4/20 4:02 PM, Andrew Lunn wrote: > On Fri, Sep 04, 2020 at 12:45:44AM +0200, Marek Vasut wrote: >> On 9/4/20 12:08 AM, Andrew Lunn wrote: > b4 am 20200903043947.3272453-1-f.faine...@gmail.com That might be a fix for the long run, but I doubt there's any chance to backport it

Re: [PATCH bpf-next 6/6] ixgbe, xsk: finish napi loop if AF_XDP Rx queue is full

2020-09-04 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2020 15:53:31 +0200 Björn Töpel wrote: > From: Björn Töpel > > Make the AF_XDP zero-copy path aware that the reason for redirect > failure was due to full Rx queue. If so, exit the napi loop as soon as > possible (exit the softirq processing), so that the userspace AF_XDP > proce

Re: [PATCH net-next 3/3] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-04 Thread Florian Fainelli
On 9/3/2020 11:15 PM, Marco Felsch wrote: Hi Florian, On 20-09-02 21:39, Florian Fainelli wrote: The internal Gigabit PHY on Broadcom STB chips has a digital clock which drives its MDIO interface among other things, the driver now requests and manage that clock during .probe() and .remove()

Re: [PATCH net-next 3/3] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-04 Thread Florian Fainelli
On 9/3/2020 11:18 PM, Marco Felsch wrote: On 20-09-02 21:39, Florian Fainelli wrote: The internal Gigabit PHY on Broadcom STB chips has a digital clock which drives its MDIO interface among other things, the driver now requests and manage that clock during .probe() and .remove() accordingly.

Re: [PATCH bpf-next 3/6] xsk: introduce xsk_do_redirect_rx_full() helper

2020-09-04 Thread Björn Töpel
On 2020-09-04 17:11, Jesper Dangaard Brouer wrote: On Fri, 4 Sep 2020 15:53:28 +0200 Björn Töpel wrote: From: Björn Töpel The xsk_do_redirect_rx_full() helper can be used to check if a failure of xdp_do_redirect() was due to the AF_XDP socket had a full Rx ring. This is very AF_XDP specif

Re: [PATCH net-next 1/1] net: hsr/prp: add vlan support

2020-09-04 Thread Willem de Bruijn
On Tue, Sep 1, 2020 at 9:54 PM Murali Karicheri wrote: > > This patch add support for creating vlan interfaces > over hsr/prp interface. > > Signed-off-by: Murali Karicheri > --- > net/hsr/hsr_device.c | 4 > net/hsr/hsr_forward.c | 16 +--- > 2 files changed, 13 insertions(+)

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread John Fastabend
Laura García Liébana wrote: > Hi, > > On Thu, Sep 3, 2020 at 7:00 AM John Fastabend > wrote: > > > [...] > > > > I don't think it actualy improves performance at least I didn't observe > > that. From the code its not clear why this would be the case either. As > > a nit I would prefer that line

Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-04 Thread Willem de Bruijn
On Thu, Sep 3, 2020 at 12:30 AM Murali Karicheri wrote: > > All, > > On 9/2/20 12:14 PM, Murali Karicheri wrote: > > All, > > > > On 9/1/20 3:54 PM, Murali Karicheri wrote: > >> This series add support for creating VLAN interface over HSR or > >> PRP interface. Typically industrial networks uses V

Re: [PATCH bpf-next 6/6] ixgbe, xsk: finish napi loop if AF_XDP Rx queue is full

2020-09-04 Thread Björn Töpel
On 2020-09-04 17:35, Jesper Dangaard Brouer wrote: On Fri, 4 Sep 2020 15:53:31 +0200 Björn Töpel wrote: From: Björn Töpel Make the AF_XDP zero-copy path aware that the reason for redirect failure was due to full Rx queue. If so, exit the napi loop as soon as possible (exit the softirq proce

Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-04 Thread Vadym Kochan
Hi Andrew, On Fri, Sep 04, 2020 at 03:32:17PM +0200, Andrew Lunn wrote: > > > > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 > > > > *addr) > > > > +{ > > > > + if (!is_valid_ether_addr(addr)) > > > > + return -EADDRNOTAVAIL; > > > > + > > > > +

Re: [PATCH v2 net-next 1/9] xdp: introduce mb in xdp_buff/xdp_frame

2020-09-04 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2020 09:15:04 -0600 David Ahern wrote: > On 9/4/20 1:19 AM, Jesper Dangaard Brouer wrote: > > On Thu, 3 Sep 2020 18:07:05 -0700 > > Alexei Starovoitov wrote: > > > >> On Thu, Sep 03, 2020 at 10:58:45PM +0200, Lorenzo Bianconi wrote: > >>> Introduce multi-buffer bit (mb) in xdp

Re: [PATCH v3] staging: qlge: fix build breakage with dumping enabled

2020-09-04 Thread Coiby Xu
On Thu, Sep 03, 2020 at 12:49:18PM +0900, Benjamin Poirier wrote: On 2020-09-02 22:00 +0800, Coiby Xu wrote: This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning o

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Jiri Olsa
On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote: > On Wed, Jul 29, 2020 at 4:24 PM Ian Rogers wrote: > > > > On Tue, Jul 28, 2020 at 9:10 AM Jiri Olsa wrote: > > > > > > On Tue, Jul 28, 2020 at 05:59:46PM +0200, Jiri Olsa wrote: > > > > On Tue, Jul 28, 2020 at 01:57:31AM -0700, Ian Rog

Re: [PATCH net-next v1 0/7] udp_tunnel: convert Intel drivers with shared tables

2020-09-04 Thread Nguyen, Anthony L
On Thu, 2020-09-03 at 16:22 -0700, Jakub Kicinski wrote: > On Thu, 23 Jul 2020 20:06:15 + Nguyen, Anthony L wrote: > > On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote: > > > On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote: > > > > This set converts Intel drivers which have the ab

[PATCH bpf-next 2/2] tools: bpftool: add "inner_map" to "bpftool map create" outer maps

2020-09-04 Thread Quentin Monnet
There is no support for creating maps of types array-of-map or hash-of-map in bpftool. This is because the kernel needs an inner_map_fd to collect metadata on the inner maps to be supported by the new map, but bpftool does not provide a way to pass this file descriptor. Add a new optional "inner_m

[PATCH bpf-next 1/2] tools: bpftool: dump outer maps content

2020-09-04 Thread Quentin Monnet
Although user space can lookup and dump the content of an outer map (hash-of-maps or array-of-maps), bpftool does not allow to do so. It seems that the only reason for that is historical. Lookups for outer maps was added in commit 14dc6f04f49d ("bpf: Add syscall lookup support for fd array and hta

[PATCH bpf-next 0/2] tools: bpftool: support creating and dumping outer maps

2020-09-04 Thread Quentin Monnet
This series makes bpftool able to create and dump the content for outer maps (maps of types array-of-maps and hash-of-maps). The modifications are rather succinct: dumping works if we remove the related restriction in bpftool's code, and creation is just a matter of passing the relevant inner_map_f

[PATCH bpf-next 1/3] tools: bpftool: fix formatting in bpftool-link documentation

2020-09-04 Thread Quentin Monnet
Fix a formatting error in the documentation for bpftool-link, so that the man page can build correctly. Signed-off-by: Quentin Monnet --- tools/bpf/bpftool/Documentation/bpftool-link.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Documentation/bpftool-l

[PATCH bpf-next 2/3] bpf: fix formatting in documentation for BPF helpers

2020-09-04 Thread Quentin Monnet
Fix a formatting error in the description of bpf_load_hdr_opt() (rst2man complains about a wrong indentation, but what is missing is actually a blank line before the bullet list). Fix and harmonise the formatting for other helpers. Signed-off-by: Quentin Monnet --- include/uapi/linux/bpf.h | 87

[PATCH bpf-next 3/3] tools, bpf: synchronise BPF UAPI header with tools

2020-09-04 Thread Quentin Monnet
Synchronise the bpf.h header under tools, to report the fixes recently brought to the documentation for the BPF helpers. Signed-off-by: Quentin Monnet --- tools/include/uapi/linux/bpf.h | 87 ++ 1 file changed, 45 insertions(+), 42 deletions(-) diff --git a/tools

[PATCH bpf-next 0/3] bpf: format fixes for BPF helpers and bpftool documentation

2020-09-04 Thread Quentin Monnet
This series contains minor fixes (or harmonisation edits) for the bpftool-link documentation (first patch) and BPF helpers documentation (last two patches), so that all related man pages can build without errors. Quentin Monnet (3): tools: bpftool: fix formatting in bpftool-link documentation

Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp.

2020-09-04 Thread Marc Zyngier
On Fri, 04 Sep 2020 10:27:41 +0100, Jianyong Wu wrote: > > ptp_kvm will get this service through smccc call. > The service offers wall time and counter cycle of host for guest. > caller must explicitly determines which cycle of virtual counter or > physical counter to return if it needs counter c

Re: [PATCH v14 09/10] doc: add ptp_kvm introduction for arm64 support

2020-09-04 Thread Marc Zyngier
On Fri, 04 Sep 2020 10:27:43 +0100, Jianyong Wu wrote: > > ptp_kvm implementation depends on hypercall using SMCCC. So we > introduce a new SMCCC service ID. This doc explain how we define > and use this new ID. > > Signed-off-by: Jianyong Wu > --- > Documentation/virt/kvm/arm/ptp_kvm.rst | 72

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread Lukas Wunner
On Wed, Sep 02, 2020 at 10:00:32PM -0700, John Fastabend wrote: > Lukas Wunner wrote: > > * Before: 4730418pps 2270Mb/sec (2270600640bps) > > * After:4759206pps 2284Mb/sec (2284418880bps) > > I used a 10Gbps ixgbe nic to measure the performance after the dummy > device hung on me for

Re: [PATCH v2 net-next 1/9] xdp: introduce mb in xdp_buff/xdp_frame

2020-09-04 Thread David Ahern
On 9/4/20 9:59 AM, Jesper Dangaard Brouer wrote: >> dev_rx for example seems like it could just be the netdev >> index rather than a pointer or perhaps can be removed completely. I >> believe it is only used for 1 use case (redirects to CPUMAP); maybe that >> code can be refactored to handle the de

RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-09-04 Thread Sunil Kovvuri Goutham
> -Original Message- > From: Herbert Xu > Sent: Friday, September 4, 2020 7:48 PM > To: Srujana Challa > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > cry...@vger.kernel.org; Suheil Chandran ; > Narayana Prasad Raju Athreya ; Sunil Kovvuri > Goutham ; Linu Cherian ; > Geeth

[PATCH net-next v7 3/6] net: marvell: prestera: Add basic devlink support

2020-09-04 Thread Vadym Kochan
Add very basic support for devlink interface: - driver name - fw version - devlink ports Signed-off-by: Vadym Kochan --- PATCH v5: 1) Simplified some error path handling by simple return error code in: - prestera_dl_info_get(...) 2) Remove not-needed err assignment i

[PATCH net-next v7 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings

2020-09-04 Thread Vadym Kochan
Add brief description how to configure base mac address binding in device-tree. Describe requirement for the PCI port which is connected to the ASIC, to allow access to the firmware related registers. Signed-off-by: Vadym Kochan --- .../bindings/net/marvell,prestera.txt | 34 +++

[PATCH net-next v7 4/6] net: marvell: prestera: Add ethtool interface support

2020-09-04 Thread Vadym Kochan
The ethtool API provides support for the configuration of the following features: speed and duplex, auto-negotiation, MDI-x, forward error correction, port media type. The API also provides information about the port status, hardware and software statistic. The following limitation exists: - p

[PATCH net-next v7 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-09-04 Thread Vadym Kochan
The following features are supported: - VLAN-aware bridge offloading - VLAN-unaware bridge offloading - FDB offloading (learning, ageing) - Switchport configuration Currently there are some limitations like: - Only 1 VLAN-aware bridge instance supported - FDB ageing timeo

[PATCH net-next v7 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x)

2020-09-04 Thread Vadym Kochan
Marvell Prestera 98DX3255 integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. Prestera Switchdev is a firmware based driver that operates via PCI bus. The current implementation supports only boards designed for the

[PATCH net-next v7 2/6] net: marvell: prestera: Add PCI interface support

2020-09-04 Thread Vadym Kochan
Add PCI interface driver for Prestera Switch ASICs family devices, which provides: - Firmware loading mechanism - Requests & events handling to/from the firmware - Access to the firmware on the bus level The firmware has to be loaded each time the device is reset. The driver is loadin

[PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-04 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. The current implementation supports only boards designed for the Marvell Switchdev solution and requires special firmware. The core Preste

Re: [PATCH bpf-next 1/2] samples: bpf: Replace bpf_program__title() with bpf_program__section_name()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 11:34 PM Daniel T. Lee wrote: > > From commit 521095842027 ("libbpf: Deprecate notion of BPF program > "title" in favor of "section name""), the term title has been replaced > with section name in libbpf. > > Since the bpf_program__title() has been deprecated, this commit >

Re: [PATCH net-next 0/3] net: phy: Support enabling clocks prior to bus probe

2020-09-04 Thread Adam Rudziński
W dniu 2020-09-04 o 16:23, Andrew Lunn pisze: On Fri, Sep 04, 2020 at 04:00:55PM +0200, Adam Rudziński wrote: W dniu 2020-09-04 o 15:45, Andrew Lunn pisze: Just a bunch of questions. Actually, why is it necessary to have a full MDIO bus scan already during probing peripherals? That is the Lin

RE: [Intel-wired-lan] [PATCH] i40e: always propagate error value in i40e_set_vsi_promisc()

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Stefan Assmann > Sent: Thursday, August 20, 2020 4:53 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Loktionov, Aleksandr > ; sassm...@kpanic.de; > da...@davemloft.net > Subject: [Intel-wired-lan] [PATCH] i40e: always propagate error

RE: [Intel-wired-lan] [PATCH v2] i40e: fix return of uninitialized aq_ret in i40e_set_vsi_promisc

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Stefan Assmann > Sent: Thursday, August 13, 2020 4:27 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; sassm...@kpanic.de; k...@kernel.org; > da...@davemloft.net > Subject: [Intel-wired-lan] [PATCH v2] i40e: fix return of uninitialized

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Shannon Nelson
On 9/4/20 8:01 AM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 17:05:32 -0700 Shannon Nelson wrote: Add support for using devlink's dev flash facility to update the firmware on an ionic device. This is a simple model of pushing the firmware file to the NIC, asking the NIC to unpack and install th

Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-09-04 Thread Andrew Lunn
On Fri, Sep 04, 2020 at 04:36:29PM +, Sunil Kovvuri Goutham wrote: > > > > -Original Message- > > From: Herbert Xu > > Sent: Friday, September 4, 2020 7:48 PM > > To: Srujana Challa > > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > > cry...@vger.kernel.org; Suheil Chandr

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote: > > > On Wed, Jul 29, 2020 at 4:24 PM Ian Rogers wrote: > > > > On Tue, Jul 28, 2020 at 9:10 AM Jiri Olsa wrote: > > >

INFO: rcu detected stall in corrupted (4)

2020-09-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0f091e43 netlabel: remove unused param from audit_log_form.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14551a7190 kernel config: https://syzkaller.appspot.com/x/.config?x=61025c6fd3261bb1 das

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 03:50:13PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > > > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > > > On Thu, Sep 0

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > > On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote: > > > > On Wed, Jul 29, 2020 at 4:24 P

Re: [PATCH bpf-next v2 1/6] bpf: Introduce pseudo_btf_id

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:34 PM Hao Luo wrote: > > Pseudo_btf_id is a type of ld_imm insn that associates a btf_id to a > ksym so that further dereferences on the ksym can use the BTF info > to validate accesses. Internally, when seeing a pseudo_btf_id ld insn, > the verifier reads the btf_id store

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-09-04 Thread Richard Leitner
On Fri, Sep 04, 2020 at 05:26:14PM +0200, Marek Vasut wrote: > On 9/4/20 4:02 PM, Andrew Lunn wrote: > > On Fri, Sep 04, 2020 at 12:45:44AM +0200, Marek Vasut wrote: > >> On 9/4/20 12:08 AM, Andrew Lunn wrote: > > b4 am 20200903043947.3272453-1-f.faine...@gmail.com > > That might be a

Re: [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > The current implementation supports only boards designed for the Marvell > S

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-09-04 Thread Marek Vasut
On 9/4/20 9:02 PM, Richard Leitner wrote: > On Fri, Sep 04, 2020 at 05:26:14PM +0200, Marek Vasut wrote: >> On 9/4/20 4:02 PM, Andrew Lunn wrote: >>> On Fri, Sep 04, 2020 at 12:45:44AM +0200, Marek Vasut wrote: On 9/4/20 12:08 AM, Andrew Lunn wrote: >>> b4 am 20200903043947.3272453-1-f.fai

Re: [PATCH net-next v7 2/6] net: marvell: prestera: Add PCI interface support

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The firmware

Re: [PATCHv2] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 17:10:39 +0800 Po-Hsu Lin wrote: > Hello David, > > do you need more information for this V2 patch? Something strange happened here, did you perhaps edit the patch manually and resend the same email? I think the Message-ID header may had been the same on v1 and v2 of your patc

Re: [PATCH bpf-next v2 2/6] bpf/libbpf: BTF support for typed ksyms

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:34 PM Hao Luo wrote: > > If a ksym is defined with a type, libbpf will try to find the ksym's btf > information from kernel btf. If a valid btf entry for the ksym is found, > libbpf can pass in the found btf id to the verifier, which validates the > ksym's type and value.

Re: [PATCH net-next v7 4/6] net: marvell: prestera: Add ethtool interface support

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > The ethtool API provides support for the configuration of the following > features: speed and duplex, auto-negotiation, MDI-x, forward error > correction, port media type. The API also provides information about the > port status, hardware and

Re: [PATCH net-next v7 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > The following features are supported: > > - VLAN-aware bridge offloading > - VLAN-unaware bridge offloading > - FDB offloading (learning, ageing) > - Switchport configuration > > Currently there are some limitations like: > >

Re: [PATCH bpf-next v2 3/6] bpf/selftests: ksyms_btf to test typed ksyms

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Selftests for typed ksyms. Tests two types of ksyms: one is a struct, > the other is a plain int. This tests two paths in the kernel. Struct > ksyms will be converted into PTR_TO_BTF_ID by the verifier while int > typed ksyms will be converted into

[PATCH bpf-next 0/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
With CORE, it is possible that the compiler may produce code like r1 = 0 // relocation instruction map_ptr += r1 ... Currently verifier does not allow map_ptr arithmetic, even for adding with 0. This patch set relaxed the condition so the above code can be accepted. Patch #1 is the kernel im

[PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
Commit 41c48f3a98231 ("bpf: Support access to bpf map fields") added support to access map fields with CORE support. For example, struct bpf_map { __u32 max_entries; } __attribute__((preserve_access_index)); struct bpf_array {

[PATCH bpf-next 2/2] selftests/bpf: add test for map_ptr arithmetic

2020-09-04 Thread Yonghong Song
change selftest map_ptr_kern.c which will fail without previous verifier change. Also added to verifier test for both "map_ptr += scalar" and "scalar += map_ptr" arithmetic. Signed-off-by: Yonghong Song --- .../selftests/bpf/progs/map_ptr_kern.c| 4 +-- .../testing/selftests/bpf/verifie

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: > >On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > >> Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >> >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote:

Re: [PATCH bpf-next v2 4/6] bpf: Introduce bpf_per_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Add bpf_per_cpu_ptr() to help bpf programs access percpu vars. > bpf_per_cpu_ptr() has the same semantic as per_cpu_ptr() in the kernel > except that it may return NULL. This happens when the cpu parameter is > out of range. So the caller must chec

[PATCH net-next] mlx4: make sure to always set the port type

2020-09-04 Thread Jakub Kicinski
Even tho mlx4_core registers the devlink ports, it's mlx4_en and mlx4_ib which set their type. In situations where one of the two is not built yet the machine has ports of given type we see the devlink warning from devlink_port_type_warn() trigger. Having ports of a type not supported by the kerne

Re: [PATCH bpf-next v2 5/6] bpf: Introduce bpf_this_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Add bpf_this_cpu_ptr() to help access percpu var on this cpu. This > helper always returns a valid pointer, therefore no need to check > returned value for NULL. Also note that all programs run with > preemption disabled, which means that the retur

Re: [PATCH bpf-next v2 6/6] bpf/selftests: Test for bpf_per_cpu_ptr() and bpf_this_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Test bpf_per_cpu_ptr() and bpf_this_cpu_ptr(). Test two paths in the > kernel. If the base pointer points to a struct, the returned reg is > of type PTR_TO_BTF_ID. Direct pointer dereference can be applied on > the returned variable. If the base po

RE: [PATCH] igb: read PBA number from flash

2020-09-04 Thread Brown, Aaron F
> From: Gal Hammer > Sent: Saturday, August 29, 2020 10:45 PM > To: linux-ker...@vger.kernel.org > Cc: Kirsher, Jeffrey T ; David S . Miller > ; Jakub Kicinski ; intel-wired- > l...@lists.osuosl.org; netdev@vger.kernel.org; Marcel Apfelbaum > ; Gal Hammer > Subject: [PATCH] igb: read PBA number f

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > > Commit 41c48f3a98231 ("bpf: Support access > to bpf map fields") added support to access map fields > with CORE support. For example, > > struct bpf_map { > __u32 max_entries; > } __attribute__((pr

Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 12:29:04 + Sunil Kovvuri Goutham wrote: > > >No, there are 3 drivers registering to 3 PCI device IDs and there can > > >be many instances of the same devices. So there can be 10's of instances > > >of > > AF, PF and VFs. > > > > So you can still have per-pci device devlin

[PATCH bpf-next 0/3] tools: bpftool: print built-in features, automate some of the documentation

2020-09-04 Thread Quentin Monnet
There are two changes for bpftool in this series. The first one is a modification to the "version" command, to have it print the status (compiled or not) of some of the optional features for bpftool. This is to help determine if a bpftool binary is able to, for example, disassemble JIT-compiled pr

[PATCH bpf-next 2/3] tools: bpftool: include common options from separate file

2020-09-04 Thread Quentin Monnet
Nearly all man pages for bpftool have the same common set of option flags (--help, --version, --json, --pretty, --debug). The description is duplicated across all the pages, which is more difficult to maintain if the description of an option changes. It may also be confusing to sort out what option

[PATCH bpf-next 1/3] tools: bpftool: print optional built-in features along with version

2020-09-04 Thread Quentin Monnet
Bpftool has a number of features that can be included or left aside during compilation. This includes: - Support for libbfd, providing the disassembler for JIT-compiled programs. - Support for BPF skeletons, used for profiling programs or iterating on the PIDs of processes associated with BPF

[PATCH bpf-next 3/3] tools: bpftool: automate generation for "SEE ALSO" sections in man pages

2020-09-04 Thread Quentin Monnet
The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), bpf-helpers(7), then all existing bpftool man pages (save the current one). This leads to nearly-identical lists being duplicated in all manual pages. Ideally, when a new page is created, all lists should be updated accordingly, bu

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread Daniel Borkmann
On 9/4/20 6:21 PM, Lukas Wunner wrote: On Wed, Sep 02, 2020 at 10:00:32PM -0700, John Fastabend wrote: Lukas Wunner wrote: [...] Do you have plans to address the performance degradation? Otherwise if I was building some new components its unclear why we would choose the slower option over the

Re: [PATCH v20 06/23] LSM: Use lsmblob in security_secctx_to_secid

2020-09-04 Thread Paul Moore
On Wed, Aug 26, 2020 at 11:08 AM Casey Schaufler wrote: > Change security_secctx_to_secid() to fill in a lsmblob instead > of a u32 secid. Multiple LSMs may be able to interpret the > string, and this allows for setting whichever secid is > appropriate. Change security_secmark_relabel_packet() to

[PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-04 Thread Florian Fainelli
Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient to guarantee that the MDIO bus diversion is used because of_phy_connect() will still resolve to a valid PHY phandle a

[PATCH net-next v2 1/2] of: Export of_remove_property() to modules

2020-09-04 Thread Florian Fainelli
We will need to remove some OF properties in drivers/net/dsa/bcm_sf2.c with a subsequent commit. Export of_remove_property() to modules so we can keep bcm_sf2 modular and provide an empty stub for when CONFIG_OF is disabled to maintain the ability to compile test. Signed-off-by: Florian Fainelli

[PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure MDIO diversion is used

2020-09-04 Thread Florian Fainelli
Changes in v2: - export of_update_property() to permit building bcm_sf2 as a module - provided a better explanation of the problem being solved after explaining it to Andrew during the v1 review Florian Fainelli (2): of: Export of_remove_property() to modules net: dsa: bcm_sf2: Ensure that

Re: [PATCH bpf-next 0/3] bpf: format fixes for BPF helpers and bpftool documentation

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:15 AM Quentin Monnet wrote: > > This series contains minor fixes (or harmonisation edits) for the > bpftool-link documentation (first patch) and BPF helpers documentation > (last two patches), so that all related man pages can build without errors. > > Quentin Monnet (3):

Re: [PATCH bpf-next 1/3] tools: bpftool: print optional built-in features along with version

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:57 PM Quentin Monnet wrote: > > Bpftool has a number of features that can be included or left aside > during compilation. This includes: > > - Support for libbfd, providing the disassembler for JIT-compiled > programs. > - Support for BPF skeletons, used for profiling pr

Re: [PATCH bpf-next 2/3] tools: bpftool: include common options from separate file

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:57 PM Quentin Monnet wrote: > > Nearly all man pages for bpftool have the same common set of option > flags (--help, --version, --json, --pretty, --debug). The description is > duplicated across all the pages, which is more difficult to maintain if > the description of an

RE: [PATCH][next] i40e: switch kvzalloc to allocate rx/tx_bi buffer

2020-09-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org > On Behalf Of Li RongQing > Sent: Friday, August 21, 2020 2:02 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [PATCH][next] i40e: switch kvzalloc to allocate rx/tx_bi buffer > > when changes the rx/tx ring to 4096, rx/tx_bi needs

Re: [PATCH bpf-next 3/3] tools: bpftool: automate generation for "SEE ALSO" sections in man pages

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:58 PM Quentin Monnet wrote: > > The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), > bpf-helpers(7), then all existing bpftool man pages (save the current > one). > > This leads to nearly-identical lists being duplicated in all manual > pages. Ideally, when

Re: [PATCH bpf-next 2/2] tools: bpftool: add "inner_map" to "bpftool map create" outer maps

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:16 AM Quentin Monnet wrote: > > There is no support for creating maps of types array-of-map or > hash-of-map in bpftool. This is because the kernel needs an inner_map_fd > to collect metadata on the inner maps to be supported by the new map, > but bpftool does not provide

Re: [PATCH bpf-next 1/2] tools: bpftool: dump outer maps content

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:14 AM Quentin Monnet wrote: > > Although user space can lookup and dump the content of an outer map > (hash-of-maps or array-of-maps), bpftool does not allow to do so. > > It seems that the only reason for that is historical. Lookups for outer > maps was added in commit 14

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
On Wed, 2 Sep 2020 17:06:58 -0700 Xie He wrote: > PVC devices are virtual devices in this driver stacked on top of the > actual HDLC device. They are the devices normal users would use. > PVC devices have two types: normal PVC devices and Ethernet-emulating > PVC devices. > > When transmitting da

Re: [PATCH net-next v2 1/2] of: Export of_remove_property() to modules

2020-09-04 Thread Rob Herring
On Fri, Sep 4, 2020 at 3:37 PM Florian Fainelli wrote: > > We will need to remove some OF properties in drivers/net/dsa/bcm_sf2.c > with a subsequent commit. Export of_remove_property() to modules so we > can keep bcm_sf2 modular and provide an empty stub for when CONFIG_OF is > disabled to mainta

Re: [PATCH bpf-next 1/2] samples: bpf: Replace bpf_program__title() with bpf_program__section_name()

2020-09-04 Thread Daniel Borkmann
On 9/4/20 8:34 AM, Daniel T. Lee wrote: From commit 521095842027 ("libbpf: Deprecate notion of BPF program "title" in favor of "section name""), the term title has been replaced with section name in libbpf. Since the bpf_program__title() has been deprecated, this commit switches this function t

Re: Exposing device ACL setting through devlink

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 10:31:41 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 07:59:45PM CEST, tlfal...@linux.ibm.com wrote: > >Hello, I am trying to expose MAC/VLAN ACL and pvid settings for IBM > >VNIC devices to administrators through devlink (originally through > >sysfs files, but that was rejecte

[PATCH v2 16/17] RDMA/qedr: Remove fbo and zbva from the MR

2020-09-04 Thread Jason Gunthorpe
zbva is always false, so fbo is never read. A 'zero-based-virtual-address' is simply IOVA == 0, and the driver already supports this. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/qedr/verbs.c | 4 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 12 ++-- include/li

<    1   2   3   >