[net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-03 Thread sundeep . lkml
From: Subbaraya Sundeep This patchset adds tracepoints support for mailbox. In Octeontx2, PFs and VFs need to communicate with AF for allocating and freeing resources. Once all the configuration is done by AF for a PF/VF then packet I/O can happen on PF/VF queues. When an interface is brought up

[net-next PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

2020-09-03 Thread sundeep . lkml
From: Subbaraya Sundeep Added tracepoints in mailbox code so that the mailbox operations like message allocation, sending message and message interrupts are traced. Also the mailbox errors occurred like timeout or wrong responses are traced. These will help in debugging mailbox issues. Here's an

[net-next PATCH 2/2] octeontx2-pf: Add tracepoints for PF/VF mailbox

2020-09-03 Thread sundeep . lkml
From: Subbaraya Sundeep With tracepoints support present in the mailbox code this patch adds tracepoints in PF and VF drivers at places where mailbox messages are allocated, sent and at message interrupts. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham --- drivers/net/ethernet/

Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-03 Thread Vasundhara Volam
Hello Jiri, After the following set of upstream commits, the user fails to attach a bond to the bridge, if the user creates the bond with two interfaces from different bnxt_en NICs. Previously bnxt_en driver does not advertise the switch_id for legacy mode as part of ndo_get_port_parent_id cb but

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-03 Thread Eric Dumazet
On 9/2/20 6:14 PM, Yunsheng Lin wrote: > > It seems semantics for some_qdisc_is_busy() is changed, which does not only do > the checking, but also do the reseting? Yes, obviously, we would have to rename to a better name. > > Also, qdisc_reset() could be called multi times for the same qdis

[PATCH rdma-next 0/3] Extend mlx5_ib software steering interface

2020-09-03 Thread Leon Romanovsky
From: Leon Romanovsky This series from Alex extends software steering interface to support devices with extra capability "sw_owner_2" which will replace existing "sw_owner". Thanks Alex Vesker (3): RDMA/mlx5: Add sw_owner_v2 bit capability RDMA/mlx5: Allow DM allocation for sw_owner_v2 enab

[PATCH mlx5-next 1/3] RDMA/mlx5: Add sw_owner_v2 bit capability

2020-09-03 Thread Leon Romanovsky
From: Alex Vesker Added sw_owner_v2 which will be enabled for future devices, replacing sw_owner bit. Signed-off-by: Alex Vesker Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/mlx5/mlx5_ifc.h

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-03 Thread Paolo Abeni
On Wed, 2020-09-02 at 22:01 -0700, Cong Wang wrote: > Can you test the attached one-line fix? I think we are overthinking, > probably all > we need here is a busy wait. I think that will solve, but I also think that will kill NOLOCK performances due to really increased contention. At this point I

Re: RTL8402 stops working after hibernate/resume

2020-09-03 Thread Petr Tesarik
Hi Heiner, this issue was on the back-burner for some time, but I've got some interesting news now. On Sat, 18 Jul 2020 14:07:50 +0200 Heiner Kallweit wrote: >[...] > Maybe the following gives us an idea: > Please do "ethtool -d " after boot and after resume from suspend, > and check for differ

Re: [PATCH 22/28] sgiseeq: convert from dma_cache_sync to dma_sync_single_for_device

2020-09-03 Thread Christoph Hellwig
On Wed, Sep 02, 2020 at 11:38:09PM +0200, Thomas Bogendoerfer wrote: > the patch below fixes the problem. But is very wrong unfortunately. > static inline void dma_sync_desc_cpu(struct net_device *dev, void *addr) > { > - dma_cache_sync(dev->dev.parent, addr, sizeof(struct sgiseeq_rx_desc

Re: [PATCH 22/28] sgiseeq: convert from dma_cache_sync to dma_sync_single_for_device

2020-09-03 Thread Christoph Hellwig
On Tue, Sep 01, 2020 at 07:38:10PM +0200, Thomas Bogendoerfer wrote: > this is the problem: > >/* Always check for received packets. */ > sgiseeq_rx(dev, sp, hregs, sregs); > > so the driver will look at the rx descriptor on every interrupt, so > we cache the rx descriptor on the

Re: [PATCH 22/28] sgiseeq: convert from dma_cache_sync to dma_sync_single_for_device

2020-09-03 Thread Christoph Hellwig
On Thu, Sep 03, 2020 at 10:43:02AM +0200, Christoph Hellwig wrote: > On Tue, Sep 01, 2020 at 07:38:10PM +0200, Thomas Bogendoerfer wrote: > > this is the problem: > > > >/* Always check for received packets. */ > > sgiseeq_rx(dev, sp, hregs, sregs); > > > > so the driver will look

INFO: task hung in tcf_ife_init

2020-09-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:1996cf46 net: bcmgenet: fix mask check in bcmgenet_validat.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=17233f4d90 kernel config: https://syzkaller.appspot.com/x/.config?x=a0437fdd630bee11 dashboar

Re: [PATCH net-next 6/7] net: mvpp2: ptp: add interrupt handling

2020-09-03 Thread Russell King - ARM Linux admin
On Thu, Sep 03, 2020 at 03:39:40AM +0200, Andrew Lunn wrote: > > +static void mvpp2_isr_handle_ptp_queue(struct mvpp2_port *port, int nq) > > +{ > > + void __iomem *ptp_q; > > + u32 r0, r1, r2; > > + > > + ptp_q = port->priv->iface_base + MVPP22_PTP_BASE(port->gop_id); > > + if (nq) > > +

[PATCH] doc: net: dsa: Fix typo in config code sample

2020-09-03 Thread Paul Barker
In the "single port" example code for configuring a DSA switch without tagging support from userspace the command to bring up the "lan2" link was typo'd. Signed-off-by: Paul Barker --- Documentation/networking/dsa/configuration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH net-next 1/6] l2tp: remove header length param from l2tp_xmit_skb

2020-09-03 Thread Tom Parkin
All callers pass the session structure's hdr_len field as the header length parameter to l2tp_xmit_skb. Since we're passing a pointer to the session structure to l2tp_xmit_skb anyway, there's not much point breaking the header length out as a separate argument. Signed-off-by: Tom Parkin --- net

[PATCH net-next 0/6] l2tp: miscellaneous cleanups

2020-09-03 Thread Tom Parkin
This series of patches makes the following cleanups and improvements to the l2tp code: * various API tweaks to remove unused parameters from function calls * lightly refactor the l2tp transmission path to capture more error conditions in the data plane statistics * repurpose the "magic feat

[PATCH net-next 4/6] l2tp: capture more tx errors in data plane stats

2020-09-03 Thread Tom Parkin
l2tp_xmit_skb has a number of failure paths which are not reflected in the tunnel and session statistics because the stats are updated by l2tp_xmit_core. Hence any errors occurring before l2tp_xmit_core is called are missed from the statistics. Refactor the transmit path slightly to capture all e

[PATCH net-next 5/6] l2tp: make magic feather checks more useful

2020-09-03 Thread Tom Parkin
The l2tp tunnel and session structures contain a "magic feather" field which was originally intended to help trace lifetime bugs in the code. Since the introduction of the shared kernel refcount code in refcount.h, and l2tp's porting to those APIs, we are covered by the refcount code's checks and

[PATCH net-next 2/6] l2tp: drop data_len argument from l2tp_xmit_core

2020-09-03 Thread Tom Parkin
The data_len argument passed to l2tp_xmit_core is no longer used, so remove it. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index c95b58b2ab3c..4a8fb285fada 100644 --- a/ne

[PATCH net-next 6/6] l2tp: avoid duplicated code in l2tp_tunnel_closeall

2020-09-03 Thread Tom Parkin
l2tp_tunnel_closeall is called as a part of tunnel shutdown in order to close all the sessions held by the tunnel. The code it uses to close a session duplicates what l2tp_session_delete does. Rather than duplicating the code, have l2tp_tunnel_closeall call l2tp_session_delete instead. This invo

[PATCH net-next 3/6] l2tp: drop net argument from l2tp_tunnel_create

2020-09-03 Thread Tom Parkin
The argument is unused, so remove it. Signed-off-by: Tom Parkin --- net/l2tp/l2tp_core.c| 2 +- net/l2tp/l2tp_core.h| 2 +- net/l2tp/l2tp_netlink.c | 2 +- net/l2tp/l2tp_ppp.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_

Re: [PATCHv9 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2020-09-03 Thread Hangbin Liu
Hi Daniel, Sorry for the late reply. I was in PTO last few days. On Fri, Aug 28, 2020 at 11:56:37PM +0200, Daniel Borkmann wrote: > On 8/26/20 3:19 PM, Hangbin Liu wrote: > > Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be > > used when we want to allow NULL pointer for map p

Re: INFO: task hung in tcf_ife_init

2020-09-03 Thread Eric Dumazet
On 9/3/20 1:48 AM, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:1996cf46 net: bcmgenet: fix mask check in bcmgenet_validat.. > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=17233f4d90 > kernel config: https://syzkall

[PATCHv10 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-03 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv10 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2020-09-03 Thread Hangbin Liu
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v10: remove useless CONST_PTR_TO_MAP_OR_NULL and Copy-p

[PATCHv10 bpf-next 0/5] xdp: add a new helper for dev map multicast support

2020-09-03 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv10 bpf-next 4/5] selftests/bpf: add xdp_redirect_multi test

2020-09-03 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMAP_HASH

[PATCHv10 bpf-next 3/5] sample/bpf: add xdp_redirect_map_multicast test

2020-09-03 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. Signed-off-by: Hangbin Liu --- v10: no update v9: use NULL directly for arg2 and redefine the maps with btf format v5: add a null_map as we have strict the arg2 to ARG_CONST_MAP_PTR. Move

[PATCHv10 bpf-next 5/5] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

2020-09-03 Thread Hangbin Liu
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the map arg could be verified correctly when it is NULL or valid map pointer. Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map, map_multi} lim

Re: [PATCH net-next v2 3/3] net: dp83869: Add speed optimization feature

2020-09-03 Thread Dan Murphy
Jakub On 9/2/20 9:06 PM, Jakub Kicinski wrote: On Wed, 2 Sep 2020 15:34:44 -0500 Dan Murphy wrote: Set the speed optimization bit on the DP83869 PHY. Speed optimization, also known as link downshift, enables fallback to 100M operation after multiple consecutive failed attempts at Gigabit link

[PATCH 2/2] net: dsa: b53: Print err message on SW_RST timeout

2020-09-03 Thread Paul Barker
This allows us to differentiate between the possible failure modes of b53_switch_reset() by looking at the dmesg output. Signed-off-by: Paul Barker --- drivers/net/dsa/b53/b53_common.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/driv

[PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-03 Thread Dan Murphy
Set the speed optimization bit on the DP83869 PHY. Speed optimization, also known as link downshift, enables fallback to 100M operation after multiple consecutive failed attempts at Gigabit link establishment. Such a case could occur if cabling with only four wires (two twisted pairs) were connect

[PATCH] net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

2020-09-03 Thread Wei Xu
Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params is invoked in a spinlock context. This code was detected with the help of Coccinelle. Signed-off-by: Wei Xu --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread Tetsuo Handa
On 2020/09/03 20:31, Wouter Verhelst wrote: > So. > > On Wed, Sep 02, 2020 at 08:09:54PM +0900, Tetsuo Handa wrote: >> syzbot is reporting hung task at nbd_ioctl() [1], for there are two >> problems regarding TIPC's connectionless socket's shutdown() operation. >> I found C reproducer for this pro

Re: [PATCH net-next v2 04/15] net: bridge: mcast: add support for group-and-source specific queries

2020-09-03 Thread Dan Carpenter
Hi Nikolay, url: https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-initial-IGMPv3-support-part-1/20200902-193339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc1a9bf2c8169d9f607502162af1858a73a18cb8 config: i386-randconfig-m021-2020090

Re: [PATCH net-next v2 04/15] net: bridge: mcast: add support for group-and-source specific queries

2020-09-03 Thread Nikolay Aleksandrov
On 03/09/2020 15:18, Dan Carpenter wrote: > Hi Nikolay, > > url: > https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-initial-IGMPv3-support-part-1/20200902-193339 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > dc1a9bf2c8169d9f6075021

Re: [PATCH] net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

2020-09-03 Thread Wei Xu
Hi All, Sorry for the noise and please ignore it! I found a nearly same patch has been sent out 2 days before. Best Regards, Wei On 2020/9/3 19:45, Wei Xu wrote: > Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params > is invoked in a spinlock context. > This code was detecte

[PATCH net-next 3/3] mlxsw: core_hwmon: Extend hwmon interface with critical and emergency alarms

2020-09-03 Thread Ido Schimmel
From: Amit Cohen Add new attributes to hwmon object for exposing critical and emergency alarms. In case that current temperature is higher than emergency threshold, EMERGENCY alarm will be reported in sensors utility: $ sensors ... front panel 025: +55.0°C (crit = +35.0°C, emerg = +40.0°C) AL

Re: [PATCH net 3/3] hinic: fix bug of send pkts while setting channels

2020-09-03 Thread luobin (L)
On 2020/9/3 3:52, David Miller wrote: > From: Luo bin > Date: Wed, 2 Sep 2020 17:41:45 +0800 > >> @@ -531,6 +531,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, >> struct net_device *netdev) >> struct hinic_txq *txq; >> struct hinic_qp *qp; >> >> +if (unlikely(!netif_carr

[RFC V2 net-next 0/2] net: two updates related to UDP GSO

2020-09-03 Thread Huazhong Tan
There are two updates relates to UDP GSO. #1 adds a new GSO type for UDPv6 #2 adds check for UDP GSO when csum is disable in netdev_fix_features(). Changes since V1: - updates NETIF_F_GSO_LAST suggested by Willem de Bruijn. and add NETIF_F_GSO_UDPV6_L4 feature for each driver who support UDP GSO

[RFC V2 net-next 1/2] udp: add a GSO type for UDPv6

2020-09-03 Thread Huazhong Tan
In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4. Signed-off-by: Huazhong Tan --- drivers/net/bonding/bond_main.c | 4 +++-

[RFC V2 net-next 2/2] net: disable UDP GSO features when CSUM is disable

2020-09-03 Thread Huazhong Tan
When CSUM is not available, UDP GSO should be disable as well. Signed-off-by: Huazhong Tan --- net/core/dev.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index d42c9ea..0c78306 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9402,6 +9402

Re: [PATCH v2] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread Tetsuo Handa
Hello, Parthasarathy. I have a question regarding commit 6f00089c7372ba97 ("tipc: remove SS_DISCONNECTING state"). That commit added sk->sk_shutdown = SEND_SHUTDOWN; into tipc_shutdown(). What is the reason you chose SEND_SHUTDOWN despite how == SHUT_RDWR ? Since Wouter commented that

Re: [PATCH 1/2] net: dsa: b53: Use dev_{err,info} instead of pr_*

2020-09-03 Thread Florian Fainelli
On 9/3/2020 4:26 AM, Paul Barker wrote: This change allows us to see which device the err or info messages are referring to if we have multiple b53 compatible devices on a board. As this removes the only pr_*() calls in this file we can drop the definition of pr_fmt(). Signed-off-by: Paul Ba

Re: [PATCH] doc: net: dsa: Fix typo in config code sample

2020-09-03 Thread Florian Fainelli
On 9/3/2020 1:49 AM, Paul Barker wrote: In the "single port" example code for configuring a DSA switch without tagging support from userspace the command to bring up the "lan2" link was typo'd. Signed-off-by: Paul Barker Acked-by: Florian Fainelli Ah yes, thanks! -- Florian

Re: [PATCH 2/2] net: dsa: b53: Print err message on SW_RST timeout

2020-09-03 Thread Florian Fainelli
On 9/3/2020 4:26 AM, Paul Barker wrote: This allows us to differentiate between the possible failure modes of b53_switch_reset() by looking at the dmesg output. Signed-off-by: Paul Barker Acked-by: Florian Fainelli -- Florian

Re: [PATCH net 3/3] hinic: fix bug of send pkts while setting channels

2020-09-03 Thread luobin (L)
On 2020/9/2 18:16, Eric Dumazet wrote: > > > On 9/2/20 2:41 AM, Luo bin wrote: >> When calling hinic_close in hinic_set_channels, netif_carrier_off >> and netif_tx_disable are excuted, and TX host resources are freed >> after that. Core may call hinic_xmit_frame to send pkt after >> netif_tx_disa

[PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Dan Murphy
Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 47 ++- 1 file changed, 22 insertions(+), 25 deletions(

Re: [PATCH] libbpf: Remove arch-specific include path in Makefile

2020-09-03 Thread Daniel Borkmann
On 9/3/20 7:46 AM, Naveen N. Rao wrote: Daniel Borkmann wrote: On 9/2/20 10:58 PM, Andrii Nakryiko wrote: On Wed, Sep 2, 2020 at 1:43 AM Naveen N. Rao wrote: Ubuntu mainline builds for ppc64le are failing with the below error (*): CALL    /home/kernel/COD/linux/scripts/atomic/check-atom

[PATCH net-next 2/3] mlxsw: core_hwmon: Calculate MLXSW_HWMON_ATTR_COUNT more accurately

2020-09-03 Thread Ido Schimmel
From: Amit Cohen Currently the value of MLXSW_HWMON_ATTR_COUNT is calculated not really accurate. Add several defines to make the calculation clearer and easier to change. Calculate the precise high bound of number of attributes that may be needed. Signed-off-by: Amit Cohen Reviewed-by: Petr

[PATCH net-next 1/3] mlxsw: core_hwmon: Split temperature querying from show functions

2020-09-03 Thread Ido Schimmel
From: Amit Cohen mlxsw_hwmon_module_temp_show(), mlxsw_hwmon_module_temp_critical_show() and mlxsw_hwmon_module_temp_emergency_show() query the relevant temperature from firmware and fill the value in provided buffers. Split the temperature querying functionality to individual get() functions an

[PATCH net-next 0/3] mlxsw: Expose critical and emergency module alarms

2020-09-03 Thread Ido Schimmel
From: Ido Schimmel Amit says: Extend hwmon interface with critical and emergency module alarms. In case that current module temperature is higher than emergency threshold, EMERGENCY alarm will be reported in sensors utility: $ sensors ... front panel 025: +55.0°C (crit = +35.0°C, emerg = +40

Re: [PATCH net-next 0/6] l2tp: miscellaneous cleanups

2020-09-03 Thread James Chapman
On 03/09/2020 09:54, Tom Parkin wrote: > This series of patches makes the following cleanups and improvements to > the l2tp code: > > * various API tweaks to remove unused parameters from function calls > * lightly refactor the l2tp transmission path to capture more error >conditions in the

[PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-03 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 36 1 file changed, 36 ins

Re: [PATCH] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread Wouter Verhelst
So. On Wed, Sep 02, 2020 at 08:09:54PM +0900, Tetsuo Handa wrote: > syzbot is reporting hung task at nbd_ioctl() [1], for there are two > problems regarding TIPC's connectionless socket's shutdown() operation. > I found C reproducer for this problem (shown below) from "no output from > test machin

Re: [PATCH] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread Wouter Verhelst
On Thu, Sep 03, 2020 at 08:57:01PM +0900, Tetsuo Handa wrote: > On 2020/09/03 20:31, Wouter Verhelst wrote: > > So. > > > > On Wed, Sep 02, 2020 at 08:09:54PM +0900, Tetsuo Handa wrote: > >> syzbot is reporting hung task at nbd_ioctl() [1], for there are two > >> problems regarding TIPC's connecti

[PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-03 Thread Dan Murphy
This adds WoL support on TI DP83869 for magic, magic secure, unicast and broadcast. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 128 ++ 1 file changed, 128 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index 48

[PATCH net-next v3 0/3] DP83869 Feature additions

2020-09-03 Thread Dan Murphy
Hello Adding features to the DP83869 PHY. These features are also supported in other TI PHYs like the DP83867 and DP83822. Fiber Advertisement: The DP83869 supports a 100Base-FX connection. When this mode is selected the driver needs to advertise that this PHY supports fiber. WoL: The PHY also

Re: [PATCH] sctp: Honour SCTP_PARTIAL_DELIVERY_POINT even under memory pressure

2020-09-03 Thread Marcelo Ricardo Leitner
On Tue, Sep 01, 2020 at 11:00:07AM +0200, Petr Malat wrote: > Command SCTP_CMD_PART_DELIVER issued under memory pressure calls > sctp_ulpq_partial_delivery(), which tries to fetch and partially deliver > the first message it finds without checking if the message is longer than > SCTP_PARTIAL_DELIVE

[PATCH] sctp: Honour SCTP_PARTIAL_DELIVERY_POINT even under memory pressure

2020-09-03 Thread Petr Malat
Command SCTP_CMD_PART_DELIVER issued under memory pressure calls sctp_ulpq_partial_delivery(), which tries to fetch and partially deliver the first message it finds without checking if the message is longer than SCTP_PARTIAL_DELIVERY_POINT. According to the RFC 6458 paragraph 8.1.21. such a behavio

[PATCH 1/2] net: dsa: b53: Use dev_{err,info} instead of pr_*

2020-09-03 Thread Paul Barker
This change allows us to see which device the err or info messages are referring to if we have multiple b53 compatible devices on a board. As this removes the only pr_*() calls in this file we can drop the definition of pr_fmt(). Signed-off-by: Paul Barker --- drivers/net/dsa/b53/b53_common.c |

[PATCH 0/2] Minor improvements to b53 dmesg output

2020-09-03 Thread Paul Barker
These changes were made while debugging the b53 driver for use on a custom board. They've been runtime tested on a patched 4.14.y kernel which supports this board as well as build tested with 5.9-rc3. The changes are straightforward enough that I think this testing is sufficient but let me know if

Re: [RFC net-next 2/2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-03 Thread Florian Fainelli
On 9/2/2020 11:00 PM, Adam Rudziński wrote: W dniu 2020-09-03 o 04:13, Florian Fainelli pisze: On 9/2/2020 3:20 PM, Andrew Lunn wrote: +    priv->clk = devm_clk_get_optional(&phydev->mdio.dev, "sw_gphy"); +    if (IS_ERR(priv->clk)) +    return PTR_ERR(priv->clk); + +    /* To get the

Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-03 Thread Willem de Bruijn
On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan wrote: > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > The current implementation supports only boards designed for the Marvell > S

Re: [PATCH] sctp: Honour SCTP_PARTIAL_DELIVERY_POINT even under memory pressure

2020-09-03 Thread Petr Malat
Hi! On Wed, Sep 02, 2020 at 11:58:35AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Sep 01, 2020 at 11:00:07AM +0200, Petr Malat wrote: > > Command SCTP_CMD_PART_DELIVER issued under memory pressure calls > > sctp_ulpq_partial_delivery(), which tries to fetch and partially deliver > > the first

Re: INFO: task hung in tcf_ife_init

2020-09-03 Thread syzbot
syzbot has bisected this issue to: commit 4e8ddd7f1758ca4ddd0c1f7cf3e66fce736241d2 Author: Vlad Buslov Date: Thu Jul 5 14:24:30 2018 + net: sched: don't release reference on action overwrite bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14ae08e990 start commit: 19

Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-03 Thread Andy Shevchenko
On Thu, Sep 3, 2020 at 6:23 PM Willem de Bruijn wrote: > On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan wrote: ... > > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 *addr) > > +{ > > + if (!is_valid_ether_addr(addr)) > > + return -EADDRNOTAVAIL; > > + >

Re: [PATCH net-next 2/2] ionic: add devlink firmware update

2020-09-03 Thread Shannon Nelson
On 9/2/20 11:01 PM, Jiri Pirko wrote: Wed, Sep 02, 2020 at 09:57:17PM CEST, snel...@pensando.io wrote: Add support for firmware update through the devlink interface. This update copies the firmware object into the device, asks the current firmware to install it, then asks the firmware to set the

Re: [PATCH v4 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-09-03 Thread Rob Herring
On Tue, 01 Sep 2020 14:50:14 +0200, Kurt Kanzenbach wrote: > Add basic documentation and example. > > Signed-off-by: Kurt Kanzenbach > --- > .../bindings/net/dsa/hellcreek.yaml | 127 ++ > 1 file changed, 127 insertions(+) > create mode 100644 Documentation/devicetree/

INFO: rcu detected stall in ip_list_rcv

2020-09-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:1eb832ac tools/bpf: build: Make sure resolve_btfids cleans.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=15affa1e90 kernel config: https://syzkaller.appspot.com/x/.config?x=a0437fdd630bee11 dashboar

Re: [PATCH net-next] net: tighten the definition of interface statistics

2020-09-03 Thread Edwin Peer
On Wed, Sep 2, 2020 at 7:03 PM Jakub Kicinski wrote: > +Drivers should report all statistics which have a matching member in > +:c:type:`struct rtnl_link_stats64 ` exclusively > +via `.ndo_get_stats64`. Reporting such standard stats via ethtool > +or debugfs will not be accepted. Should existing

Re: [PATCH v4 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-09-03 Thread Florian Fainelli
On 9/1/2020 5:50 AM, Kurt Kanzenbach wrote: Add basic documentation and example. Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 5/7] net: dsa: hellcreek: Add PTP status LEDs

2020-09-03 Thread Florian Fainelli
On 9/1/2020 5:50 AM, Kurt Kanzenbach wrote: The switch has two controllable I/Os which are usually connected to LEDs. This is useful to immediately visually see the PTP status. These provide two signals: * is_gm This LED can be activated if the current device is the grand master in th

Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema

2020-09-03 Thread Rob Herring
On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > This is conversion only so it includes properties with invalid prefixes > (s3fwrn5,en-gpios) which should be addressed later. > > Signed-off-by: Krzysztof K

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Florian Fainelli
On 9/3/2020 7:15 AM, Dan Murphy wrote: Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 47 ++- 1

KASAN: use-after-free Read in dump_schedule

2020-09-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fc3abb53 Merge branch 'for-linus' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17b672f590 kernel config: https://syzkaller.appspot.com/x/.config?x=e1c560d0f4e121c9 das

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Dan Murphy
Florian On 9/3/20 11:34 AM, Florian Fainelli wrote: On 9/3/2020 7:15 AM, Dan Murphy wrote: Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-by: Dan Murphy ---   drivers/net/phy/dp838

Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in tx.c

2020-09-03 Thread Edward Cree
On 02/09/2020 23:55, David Miller wrote: > From: Edward Cree > Date: Wed, 2 Sep 2020 15:35:53 +0100 > >> +tx_queue->xmit_more_available = true; > > I don't understand why you're setting xmit_more_available > unconditionally to true now instead of setting it to 'xmit_more' as > seen by this t

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Florian Fainelli
On 9/3/2020 9:41 AM, Dan Murphy wrote: Florian On 9/3/20 11:34 AM, Florian Fainelli wrote: On 9/3/2020 7:15 AM, Dan Murphy wrote: Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Joe Perches
On Thu, 2020-09-03 at 11:41 -0500, Dan Murphy wrote: > On 9/3/20 11:34 AM, Florian Fainelli wrote: > > On 9/3/2020 7:15 AM, Dan Murphy wrote: > > > Fix spacing issues reported for misaligned switch..case and extra new > > > lines. [] > > > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp

Re: [RFC net-next 2/2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-03 Thread Adam Rudziński
W dniu 2020-09-03 o 17:21, Florian Fainelli pisze: On 9/2/2020 11:00 PM, Adam Rudziński wrote: W dniu 2020-09-03 o 04:13, Florian Fainelli pisze: On 9/2/2020 3:20 PM, Andrew Lunn wrote: +    priv->clk = devm_clk_get_optional(&phydev->mdio.dev, "sw_gphy"); +    if (IS_ERR(priv->clk)) +  

Re: INFO: task hung in tcf_ife_init

2020-09-03 Thread Vlad Buslov
On Thu 03 Sep 2020 at 18:33, syzbot wrote: > syzbot has bisected this issue to: > > commit 4e8ddd7f1758ca4ddd0c1f7cf3e66fce736241d2 > Author: Vlad Buslov > Date: Thu Jul 5 14:24:30 2018 + > > net: sched: don't release reference on action overwrite > > bisection log: https://syzkaller.

Re: [RFC net-next 2/2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-03 Thread Florian Fainelli
On 9/3/2020 10:13 AM, Adam Rudziński wrote: W dniu 2020-09-03 o 17:21, Florian Fainelli pisze: On 9/2/2020 11:00 PM, Adam Rudziński wrote: W dniu 2020-09-03 o 04:13, Florian Fainelli pisze: On 9/2/2020 3:20 PM, Andrew Lunn wrote: +    priv->clk = devm_clk_get_optional(&phydev->mdio.d

Re: [PATCH] sctp: Honour SCTP_PARTIAL_DELIVERY_POINT even under memory pressure

2020-09-03 Thread Marcelo Ricardo Leitner
Hi! On Thu, Sep 03, 2020 at 01:21:48PM +0200, Petr Malat wrote: > Hi! > On Wed, Sep 02, 2020 at 11:58:35AM -0300, Marcelo Ricardo Leitner wrote: > > On Tue, Sep 01, 2020 at 11:00:07AM +0200, Petr Malat wrote: > > > Command SCTP_CMD_PART_DELIVER issued under memory pressure calls > > > sctp_ulpq_pa

Re: [PATCH net v6 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-09-03 Thread Willem de Bruijn
On Wed, Sep 2, 2020 at 5:07 PM Vadym Kochan wrote: > > The following features are supported: > > - VLAN-aware bridge offloading > - VLAN-unaware bridge offloading > - FDB offloading (learning, ageing) > - Switchport configuration > > Currently there are some limitations like: > >

[wireless-testsing2:master 4/5] drivers/net/ethernet/ibm/ibmvnic.c:473:7: warning: variable 'size_array' set but not used

2020-09-03 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-testing.git master head: 4962b497738dfcccbe7424333a4ac4f381969861 commit: ce55512f4e8fd5bd801badf3b7a5dc99670e5ca7 [4/5] Merge remote-tracking branch 'mac80211/master' config: powerpc-allyesconfig (attached as .config) c

Re: [PATCH net-next 2/2] ionic: add devlink firmware update

2020-09-03 Thread Jiri Pirko
Thu, Sep 03, 2020 at 05:58:42PM CEST, snel...@pensando.io wrote: >On 9/2/20 11:01 PM, Jiri Pirko wrote: >> Wed, Sep 02, 2020 at 09:57:17PM CEST, snel...@pensando.io wrote: >> > Add support for firmware update through the devlink interface. >> > This update copies the firmware object into the device

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-03 Thread Cong Wang
On Thu, Sep 3, 2020 at 1:40 AM Paolo Abeni wrote: > > On Wed, 2020-09-02 at 22:01 -0700, Cong Wang wrote: > > Can you test the attached one-line fix? I think we are overthinking, > > probably all > > we need here is a busy wait. > > I think that will solve, but I also think that will kill NOLOCK >

Vulnerability report - af_packet.c - CVE-2020-14386

2020-09-03 Thread Or Cohen
Hi, I already reported the issue to secur...@kernel.org and linux-dist...@vs.openwall.org and CVE-2020-14386 was assigned. The report is as follows: ( a proposed patch and a reproducer are attached) I discovered a bug which leads to a memory corruption in (net/packet/af_packet.c). It can be explo

Exposing device ACL setting through devlink

2020-09-03 Thread Thomas Falcon
Hello, I am trying to expose MAC/VLAN ACL and pvid settings for IBM VNIC devices to administrators through devlink (originally through sysfs files, but that was rejected in favor of devlink). Could you give any tips on how you might go about doing this? Thanks, Tom

Re: INFO: task hung in tcf_ife_init

2020-09-03 Thread Cong Wang
On Thu, Sep 3, 2020 at 2:47 AM Eric Dumazet wrote: > This commit might be related : > > commit 4e407ff5cd67ec76a1deec227b7982dc7f66 > Author: Cong Wang > Date: Sun Aug 19 12:22:12 2018 -0700 > > act_ife: move tcfa_lock down to where necessary It does not look like my commit's fault. Fr

[PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-03 Thread Michael Chan
If tg3_reset_task() fails, the device state is left in an inconsistent state with IFF_RUNNING still set but NAPI state not enabled. A subsequent operation, such as ifdown or AER error can cause it to soft lock up when it tries to disable NAPI state. Fix it by bringing down the device to !IFF_RUNN

Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-03 Thread Jakub Kicinski
On Thu, 3 Sep 2020 09:31:16 -0700 David Awogbemila wrote: > Thanks, I'll adjust this. Please don't top post. > On Wed, Sep 2, 2020 at 4:08 PM David Miller wrote: > > > > From: David Awogbemila > > Date: Wed, 2 Sep 2020 11:42:37 -0700 > > > > > I don't think there is a specific 24-bit device i

Re: [PATCH] selftests/bpf: Fix check in global_data_init.

2020-09-03 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 11:02 AM Hao Luo wrote: > > The returned value of bpf_object__open_file() should be checked with > IS_ERR() rather than NULL. This fix makes test_progs not crash when > test_global_data.o is not present. > > Signed-off-by: Hao Luo > --- > tools/testing/selftests/bpf/prog_t

Re: [PATCH] doc: net: dsa: Fix typo in config code sample

2020-09-03 Thread David Miller
From: Paul Barker Date: Thu, 3 Sep 2020 09:49:25 +0100 > In the "single port" example code for configuring a DSA switch without > tagging support from userspace the command to bring up the "lan2" link > was typo'd. > > Signed-off-by: Paul Barker Applied, thank you.

Re: [PATCH 0/2] Minor improvements to b53 dmesg output

2020-09-03 Thread David Miller
From: Paul Barker Date: Thu, 3 Sep 2020 12:26:19 +0100 > These changes were made while debugging the b53 driver for use on a > custom board. They've been runtime tested on a patched 4.14.y kernel > which supports this board as well as build tested with 5.9-rc3. The > changes are straightforward

Re: [PATCH] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread David Miller
From: Wouter Verhelst Date: Thu, 3 Sep 2020 14:05:15 +0200 > That's fine, because NBD doesn't deal with SOCK_DGRAM sockets anyway > (i.e., passing a SOCK_DGRAM socket to the NBD device is undefined > behavior). Then why doesn't NBD simply reject such sockets?

Re: [PATCH net-next 0/3] mlxsw: Expose critical and emergency module alarms

2020-09-03 Thread David Miller
From: Ido Schimmel Date: Thu, 3 Sep 2020 16:41:43 +0300 > Amit says: > > Extend hwmon interface with critical and emergency module alarms. ... Looks good, series applied, thanks.

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-03 Thread Jakub Kicinski
On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > Hello Jiri, > > After the following set of upstream commits, the user fails to attach > a bond to the bridge, if the user creates the bond with two interfaces > from different bnxt_en NICs. Previously bnxt_en driver does not > advertise t

  1   2   3   >