[PATCHi v2] net: mdiobus: fix device unregistering in mdiobus_register

2020-08-27 Thread Sascha Hauer
After device_register has been called the device structure may not be freed anymore, put_device() has to be called instead. This gets violated when device_register() or any of the following steps before the mdio bus is fully registered fails. In this case the caller will call mdiobus_free() which t

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

2020-08-27 Thread Steffen Klassert
On Tue, Aug 04, 2020 at 11:37:29AM +0200, Sabrina Dubroca wrote: > xfrm interfaces currently test for !skb->ignore_df when deciding > whether to update the pmtu on the skb's dst. Because of this, no pmtu > exception is created when we do something like: > > ping -s 1438 > > By dropping this

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-27 Thread Sedat Dilek
On Thu, Aug 27, 2020 at 3:09 AM Willy Tarreau wrote: > > Hi Amit, > > On Thu, Aug 27, 2020 at 02:06:39AM +0300, Amit Klein wrote: > > Hi > > > > Is there an ETA for this patch then? > > No particular ETA on my side, I was waiting for potential criticisms > before going further. I suspect that if n

Re: [PATCH net 1/2] net: disable netpoll on fresh napis

2020-08-27 Thread Eric Dumazet
On 8/26/20 12:40 PM, Jakub Kicinski wrote: > napi_disable() makes sure to set the NAPI_STATE_NPSVC bit to prevent > netpoll from accessing rings before init is complete. However, the > same is not done for fresh napi instances in netif_napi_add(), > even though we expect NAPI instances to be add

[PATCH v2 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

2020-08-27 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of kernel-doc format: * Addressing - theory of operations drivers/net/wireless/ath/wil6210/wmi.c:70: warning: Incorrect use of kernel-doc format: * @sparrow_fw_mapping provides

[PATCH v2 26/32] wireless: ath: wil6210: interrupt: Demote comment header which is clearly not kernel-doc

2020-08-27 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/interrupt.c:652: warning: Function parameter or member 'irq' not described in 'wil6210_thread_irq' drivers/net/wireless/ath/wil6210/interrupt.c:652: warning: Function parameter or member 'cookie' not described in

[PATCH v2 27/32] wireless: ath: wil6210: txrx: Demote obvious abuse of kernel-doc

2020-08-27 Thread Lee Jones
None of these headers provide any parameter documentation. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'wil' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Func

[PATCH v2 28/32] wireless: ath: wil6210: txrx_edma: Demote comments which are clearly not kernel-doc

2020-08-27 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'wil' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'ring' not described

[PATCH v2 30/32] wireless: ath: wil6210: pmc: Demote a few nonconformant kernel-doc function headers

2020-08-27 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/pmc.c:43: warning: Function parameter or member 'wil' not described in 'wil_pmc_alloc' drivers/net/wireless/ath/wil6210/pmc.c:43: warning: Function parameter or member 'num_descriptors' not described in 'wil_pmc_

[PATCH v2 31/32] wireless: ath: wil6210: wil_platform: Demote kernel-doc header to standard comment block

2020-08-27 Thread Lee Jones
There has been no attempt to document any of the function parameters here. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wil_platform.c:27: warning: Function parameter or member 'dev' not described in 'wil_platform_init' drivers/net/wireless/ath/wil6210/wil_

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-27 Thread Lee Jones
> > Are you applying them in order? > > It may be affected by: > > wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming > function headers > > I'll also rebase onto the latest -next and resubmit. I just rebased all 3 sets onto the latest -next (next-20200827) without issue. Not sure what problem you're seeing. Did you apply the first set before attempting the second? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > On Fri, 14 Aug 2020, Kalle Valo wrote: >> > >> >> Lee Jones writes: >> >> >> >> > Fixes the following W=1 kernel build warning(s): >> >> > >> >> > drivers/net/wireless/broadcom/b43/main.c: In function

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-27 Thread Kalle Valo
Ondrej Zary writes: > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> On Mon, 17 Aug 2020 16:27:01 +0300 >> Kalle Valo wrote: >> >> > I was surprised to see that someone was using this driver in 2015, so >> > I'm not sure anymore what to do. Of course we could still just remove >>

[PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

2020-08-27 Thread Li RongQing
when changes the rx/tx ring to 4096, kzalloc may fail due to a temporary shortage on slab entries. kvmalloc is used to allocate this memory as there is no need to have this memory area physical continuously. Signed-off-by: Li RongQing --- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 12 ++-

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Mon, 17 Aug 2020, Kalle Valo wrote: > >> Rasmus Villemoes writes: >> >> > On 14/08/2020 17.14, Christian Lamparter wrote: >> >> On 2020-08-14 13:39, Lee Jones wrote: >> >>> 'ar9170_qmap' is used in some source files which include carl9170.h, >> >>> but not all of them.  M

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

2020-08-27 Thread Sergei Shtylyov
Hello! On 27.08.2020 9:53, Himadri Pandya wrote: The buffer size is 2 Bytes and we expect to receive the same amount of data. But sometimes we receive less data and run into uninit-was-stored issue upon read. Hence modify the error check on the return value to match with the buffer size as a pr

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-27 Thread Kalle Valo
Brian Norris writes: > Hi, > > On Tue, Aug 25, 2020 at 8:38 AM Maximilian Luz > wrote: >> >> Following commit e18696786548 ("mwifiex: Prevent memory corruption >> handling keys") the mwifiex driver fails to authenticate with certain >> networks, specifically networks with 256 bit keys, and repe

[PATCH] gss_krb5: Fix memleak in krb5_make_rc4_seq_num

2020-08-27 Thread Dinghao Liu
When kmalloc() fails, cipher should be freed just like when krb5_rc4_setup_seq_key() fails. Fixes: e7afe6c1d486b ("sunrpc: fix 4 more call sites that were using stack memory with a scatterlist") Signed-off-by: Dinghao Liu --- net/sunrpc/auth_gss/gss_krb5_seqnum.c | 6 -- 1 file changed, 4 i

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Kalle Valo
Mauro Carvalho Chehab writes: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

[PATCH net-next 3/8] s390/qeth: make queue lock a proper spinlock

2020-08-27 Thread Julian Wiedmann
queue->state is a ternary spinlock in disguise, used by OSA's TX completion path to lock the Output Queue and flush any pending packets on it to the device. If the Queue is already locked by our TX code, setting the lock word to QETH_OUT_Q_LOCKED_FLUSH lets the TX completion code move on - the TX p

[PATCH net-next 4/8] s390/qeth: don't disable address events during initialization

2020-08-27 Thread Julian Wiedmann
A newly initialized device is disabled for address events, there's no need to explicitly disable them. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_l2_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/

[PATCH net-next 1/8] s390/qeth: clean up qeth_l3_send_setdelmc()'s declaration

2020-08-27 Thread Julian Wiedmann
Clarify that the 'ipacmd' parameter is an enum, and thus compatible to what qeth_ipa_alloc_cmd() expects as input. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s3

[PATCH net-next 8/8] s390/qeth: strictly order bridge address events

2020-08-27 Thread Julian Wiedmann
The current code for bridge address events has two shortcomings in its control sequence: 1. after disabling address events via PNSO, we don't flush the remaining events from the event_wq. So if the feature is re-enabled fast enough, stale events could leak over. 2. PNSO and the events' arriv

[PATCH net-next 7/8] s390/qeth: unify structs for bridge port state

2020-08-27 Thread Julian Wiedmann
The data returned from IPA_SBP_QUERY_BRIDGE_PORTS and IPA_SBP_BRIDGE_PORT_STATE_CHANGE has the same format. Use a single struct definition for it. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_core_mpc.h | 14 +++--- drivers/s390/net/qeth_l2_main

[PATCH net-next 5/8] s390/qeth: don't let HW override the configured port role

2020-08-27 Thread Julian Wiedmann
The only time that our Bridgeport role should change is when we change the configuration ourselves. In which case we also adjust our internal state tracking, no need to do it again when we receive the corresponding event. Removing the locked section helps a subsequent patch that needs to flush the

[PATCH net-next 2/8] s390/qeth: use to_delayed_work()

2020-08-27 Thread Julian Wiedmann
Avoid poking around in the delayed_work struct's internals. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index bba1b54b8aa3..574

[PATCH net-next 6/8] s390/qeth: copy less data from bridge state events

2020-08-27 Thread Julian Wiedmann
Current code copies _all_ entries from the event into a worker, when we later only need specific data from the first entry. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_l2_main.c | 29 ++--- 1 file changed, 14 insertions(+), 15 d

[PATCH net-next 0/8] s390/qeth: updates 2020-08-27

2020-08-27 Thread Julian Wiedmann
Hi Dave & Jakub, please apply the following patch series for qeth to netdev's net-next tree. Patch 8 makes some improvements to how we handle HW address events, avoiding some uncertainty around processing stale events after we switched off the feature. Except for that it's all straight-forward cl

Re: [PATCH] ioctl: only memset non-NULL link settings

2020-08-27 Thread Michal Kubecek
On Mon, Aug 24, 2020 at 08:46:30AM +0200, Hans-Christian Noren Egtvedt wrote: > In commit bef780467fa ('ioctl: do not pass transceiver value back to > kernel') a regression slipped. If we have a kernel that does not support > the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() > functi

Re: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

2020-08-27 Thread Eric Dumazet
On 8/27/20 12:53 AM, Li RongQing wrote: > when changes the rx/tx ring to 4096, kzalloc may fail due to > a temporary shortage on slab entries. > > kvmalloc is used to allocate this memory as there is no need > to have this memory area physical continuously. > > Signed-off-by: Li RongQing > --

Re: [PATCHi v2] net: mdiobus: fix device unregistering in mdiobus_register

2020-08-27 Thread Heiner Kallweit
On 27.08.2020 09:06, Sascha Hauer wrote: > After device_register has been called the device structure may not be > freed anymore, put_device() has to be called instead. This gets violated > when device_register() or any of the following steps before the mdio > bus is fully registered fails. In this

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-27 Thread Lee Jones
On Thu, 27 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > On Fri, 14 Aug 2020, Kalle Valo wrote: > > > >> Lee Jones writes: > >> > >> > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> > > >> >> Lee Jones writes: > >> >> > >> >> > Fixes the following W=1 kernel build warning(s): > >> >> >

RE: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

2020-08-27 Thread Li,Rongqing
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Thursday, August 27, 2020 4:26 PM > To: Li,Rongqing ; netdev@vger.kernel.org; > intel-wired-...@lists.osuosl.org > Subject: Re: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer > > > > On

Re: [PATCH net-next v2] gtp: add notification mechanism

2020-08-27 Thread Harald Welte
Hi Nicolas, On Thu, Aug 27, 2020 at 12:36:24AM +0200, Nicolas Dichtel wrote: > Le 26/08/2020 à 20:52, Harald Welte a écrit : > > Wouldn't it make sense to only allocate + fill those messages if we > > actually knew a subscriber existed? > > In fact, this is actually how the netlink framework work

Re: [PATCH ethtool v2] netlink: Print and return an error when features weren't changed

2020-08-27 Thread Michal Kubecek
On Tue, Aug 25, 2020 at 11:11:38AM +0300, Maxim Mikityanskiy wrote: > The legacy ethtool prints an error message and returns 1 if no features > were changed as requested. Port this behavior to ethtool-netlink. > req_mask is compared to wanted_mask to detect if any feature was > changed. If these ma

[PATCH nf-next v3 0/3] Netfilter egress hook

2020-08-27 Thread Lukas Wunner
Introduce a netfilter egress hook to allow filtering outbound AF_PACKETs such as DHCP and to prepare for in-kernel NAT64/NAT46. An earlier version of this series was applied by Pablo Neira Ayuso back in March and subsequently reverted by Daniel Borkmann over performance concerns. I've now reworke

[PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-08-27 Thread Lukas Wunner
Commit e687ad60af09 ("netfilter: add netfilter ingress hook after handle_ing() under unique static key") introduced the ability to classify packets on ingress. Support the same on egress. This allows filtering locally generated traffic such as DHCP, or outbound AF_PACKETs in general. It will als

[PATCH nf-next v3 1/3] netfilter: Rename ingress hook include file

2020-08-27 Thread Lukas Wunner
Prepare for addition of a netfilter egress hook by renaming to . The egress hook also necessitates a refactoring of the include file, but that is done in a separate commit to ease reviewing. No functional change intended. Signed-off-by: Lukas Wunner Cc: Daniel Borkmann --- include/linux/{net

[PATCH nf-next v3 2/3] netfilter: Generalize ingress hook

2020-08-27 Thread Lukas Wunner
Prepare for addition of a netfilter egress hook by generalizing the ingress hook introduced by commit e687ad60af09 ("netfilter: add netfilter ingress hook after handle_ing() under unique static key"). In particular, rename and refactor the ingress hook's static inlines such that they can be reused

[PATCH] net: dsa: mt7530: fix advertising unsupported

2020-08-27 Thread Landen Chao
1000baseT_Half Remove 1000baseT_Half to advertise correct hardware capability in phylink_validate() callback function. Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") Signed-off-by: Landen Chao --- drivers/net/dsa/mt7530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Kalle Valo
Larry Finger writes: > On 7/27/20 9:52 AM, Joe Perches wrote: >> On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: >>> So, I think you would like to have parenthesis intentionally. >>> If so, >>> test1 ? : (test2 ? :) >>> would be better. >>> >>> >>> If not, >>> test1 ? : test2 ? : >>> may be what

[PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function

2020-08-27 Thread Lee Jones
'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. A 'defined but not used' warning is thrown when compiling the ones which do not use it. Fixes the following W=1 kernel build warning(s) from drivers/net/wireless/ath/carl9170/carl9170.h:57, In file includ

[v2] ioctl: only memset non-NULL link settings

2020-08-27 Thread Hans-Christian Noren Egtvedt
In commit bef780467fa ('ioctl: do not pass transceiver value back to kernel') a regression slipped in. If we have a kernel that does not support the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() function will return a NULL pointer. Hence before memset'ing the pointer to zero we must

Re: [PATCH] ioctl: only memset non-NULL link settings

2020-08-27 Thread Hans-Christian Egtvedt (hegtvedt)
On 27/08/2020 10:23, Michal Kubecek wrote: > On Mon, Aug 24, 2020 at 08:46:30AM +0200, Hans-Christian Noren Egtvedt wrote: >> In commit bef780467fa ('ioctl: do not pass transceiver value back to >> kernel') a regression slipped. If we have a kernel that does not support >> the ETHTOOL_xLINKSETTINGS

Re: [PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-27 Thread Michal Kubecek
On Thu, Aug 27, 2020 at 08:50:19AM +0200, Fabian Frederick wrote: > Replace common flag assignment with a macro. > This could yet be simplified with changelink/supported but it would > remove clarity > > Signed-off-by: Fabian Frederick > --- [...] > diff --git a/include/net/vxlan.h b/include/net/

Re: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

2020-08-27 Thread Eric Dumazet
On 8/27/20 1:53 AM, Li,Rongqing wrote: > > >> -Original Message- >> From: Eric Dumazet [mailto:eric.duma...@gmail.com] >> Sent: Thursday, August 27, 2020 4:26 PM >> To: Li,Rongqing ; netdev@vger.kernel.org; >> intel-wired-...@lists.osuosl.org >> Subject: Re: [PATCH] iavf: use kvzalloc

Re: [PATCH] mwifiex: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'mwifiex_p

Re: [PATCH] mwifiex: Clean up some err and dbg messages

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The error message if 'pci_set_consistent_dma_mask()' fails is misleading. > The function call uses 32 bits, but the error message reports 64. > > Moreover, according to the comment above 'dma_set_mask_and_coherent()' > definition, such an error can never happen. > >

Re: [PATCH][next] mwifiex: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH v2] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-08-27 Thread Kalle Valo
Tetsuo Handa wrote: > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > > Ganapathi Bhat proposed a possibly cleaner fix, but it seems that > that fi

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging: wilc1000: look for rtc_clk clock") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wireless-drivers

Re: [PATCH] rtw88: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rtw_pci_i

Re: [PATCH][next] rtw88: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wirel

powering off phys on 'ip link set down'

2020-08-27 Thread Rasmus Villemoes
Hi, We have a requirement that when an interface is taken down administratively, the phy should be powered off. That also works when the interface has link when the 'ip link set down ...' is run. But if there's no cable plugged in, the phy stays powered on (as can be seen both using phytool, and f

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-08-27 Thread Kurt Kanzenbach
Hi Vinicius, On Tue Aug 25 2020, Vinicius Costa Gomes wrote: > Hi Kurt, > > Kurt Kanzenbach writes: > >> I think so. As Vladimir pointed out, the driver should setup an identity >> mapping which I already did by default. >> >> Can you point me your patch? > > Just sent it for consideration: > > h

Re: [PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath6kl/wmi.c: In function > ‘ath6kl_wmi_bitrate_reply_rx’: > drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set > but not used [-Wunused-but-set-variable] > > Cc: Kalle V

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Sig

Re: [PATCH] ath9k_htc: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ath9k_htc driver hides all LEDs related code behind > CONFIG_MAC80211_LEDS ifdefs so it does not really require the > MAC80211_LEDS. The code builds and works just fine. Convert the > "select" into "imply" to allow disabling LED trigger when not needed. > > Sig

Re: [PATCH 02/16] wireless: ath9k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Sig

Re: [PATCH 17/30] wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: > ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "David S. Mi

Re: [PATCH] ath9k: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS > ifdefs so it does not really require the MAC80211_LEDS. The code builds > fine. Convert the "select" into "imply" to allow disabling LED trigger > when not needed. > > Signed-off-by: Krzyszt

Re: [PATCH] ath11k: return error if firmware request fails

2020-08-27 Thread Kalle Valo
Alex Dewar wrote: > In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is > called, but the returned pointer is not checked for errors. Rather the > variable ret (which will always be zero) is checked by mistake. Fix > this and replace the various gotos with simple returns for c

Re: [PATCH][next] carl9170: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH 21/28] wireless: ath: wil6210: debugfs: Fix a couple of formatting issues in 'wil6210_debugfs_init'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > gets confused if the variable does not follow the type/attribute > definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function pa

Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Ack

Re: [PATCH net-next v2] gtp: add notification mechanism

2020-08-27 Thread Nicolas Dichtel
Hi Harald, Le 27/08/2020 à 11:00, Harald Welte a écrit : > Hi Nicolas, > > On Thu, Aug 27, 2020 at 12:36:24AM +0200, Nicolas Dichtel wrote: >> Le 26/08/2020 à 20:52, Harald Welte a écrit : > >>> Wouldn't it make sense to only allocate + fill those messages if we >>> actually knew a subscriber ex

Re: [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-08-27 Thread Lad, Prabhakar
Hi David, On Mon, Jul 13, 2020 at 10:36 PM Lad Prabhakar wrote: > > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + > 1

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-27 Thread Kurt Kanzenbach
Hi Andrew, On Tue Aug 25 2020, Kurt Kanzenbach wrote: > On Tue Aug 25 2020, Andrew Lunn wrote: >> I agree with the check here. The question is about the compatible >> string. Should there be a more specific compatible string as well as >> the generic one? >> >> There have been a few discussions ab

Re: powering off phys on 'ip link set down'

2020-08-27 Thread Heiner Kallweit
On 27.08.2020 12:08, Rasmus Villemoes wrote: > Hi, > > We have a requirement that when an interface is taken down > administratively, the phy should be powered off. That also works when > the interface has link when the 'ip link set down ...' is run. But if > there's no cable plugged in, the phy s

Re: [v2] ioctl: only memset non-NULL link settings

2020-08-27 Thread Michal Kubecek
On Thu, Aug 27, 2020 at 11:50:33AM +0200, Hans-Christian Noren Egtvedt wrote: > In commit bef780467fa ('ioctl: do not pass transceiver value back to > kernel') a regression slipped in. If we have a kernel that does not > support the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() > fun

Re: [PATCH nf-next v3 0/3] Netfilter egress hook

2020-08-27 Thread Laura García Liébana
Hi Lukas, thank you for your patches. On Thu, Aug 27, 2020 at 10:55 AM Lukas Wunner wrote: > > Introduce a netfilter egress hook to allow filtering outbound AF_PACKETs > such as DHCP and to prepare for in-kernel NAT64/NAT46. > Actually, we've found 2 additional use cases in container-based nodes

[PATCH net-next 1/2] ipv6: add ipv6_fragment hook in ipv6_stub

2020-08-27 Thread wenxu
From: wenxu Add ipv6_fragment to ipv6_stub to avoid calling netfilter when access ip6_fragment. Signed-off-by: wenxu --- include/net/ipv6_stubs.h | 3 +++ net/ipv6/af_inet6.c | 1 + 2 files changed, 4 insertions(+) diff --git a/include/net/ipv6_stubs.h b/include/net/ipv6_stubs.h index d7

[PATCH net-next 0/2] Put ip6_fragment in ipv6_stub

2020-08-27 Thread wenxu
From: wenxu Add ip6_fragment in ipv6_stub and use it in openvswitch wenxu (2): ipv6: add ipv6_fragment hook in ipv6_stub openvswitch: using ip6_fragment in ipv6_stub include/net/ipv6_stubs.h | 2 ++ net/ipv6/af_inet6.c | 1 + net/openvswitch/actions.c | 6 ++ 3 files changed, 5

[PATCH net-next 2/2] openvswitch: using ip6_fragment in ipv6_stub

2020-08-27 Thread wenxu
From: wenxu Using ipv6_stub->ipv6_fragment to avoid the netfilter dependency Signed-off-by: wenxu --- net/openvswitch/actions.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index 2611657..1f3d406 100644 --- a/ne

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Allen Pais
Hi, > > Allen Pais wrote: > > > In preparation for unconditionally passing the > > struct tasklet_struct pointer to all tasklet > > callbacks, switch to using the new tasklet_setup() > > and from_tasklet() to pass the tasklet pointer explicitly. > > > > Signed-off-by: Romain Perier > > Signed-off

Re: [net-next v5 1/2] seg6: inherit DSCP of inner IPv4 packets

2020-08-27 Thread Ahmed Abdelsalam
On 26/08/2020 21:41, David Ahern wrote: On 8/26/20 6:12 AM, Ahmed Abdelsalam wrote: On 26/08/2020 02:45, David Ahern wrote: On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote: Hi David The seg6 encap is implemented through the seg6_lwt rather than seg6_local_lwt. ok. I don't know the seg6 code

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 12:27 +0300, Kalle Valo wrote: > Larry Finger writes: > > On 7/27/20 9:52 AM, Joe Perches wrote: > > > On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > > > > So, I think you would like to have parenthesis intentionally. > > > > If so, > > > > test1 ? : (test2 ? :) > > > > w

Re: powering off phys on 'ip link set down'

2020-08-27 Thread Rasmus Villemoes
On 27/08/2020 12.29, Heiner Kallweit wrote: > On 27.08.2020 12:08, Rasmus Villemoes wrote: >> Hi, >> >> We have a requirement that when an interface is taken down >> administratively, the phy should be powered off. That also works when >> the interface has link when the 'ip link set down ...' is ru

Re: [PATCH mlx5-next 0/2] Add DC RoCE LAG support

2020-08-27 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 02:52:43PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > Two extremely short patches to enable DC RoCE LAG support. > > Thanks > > Mark Zhang (2): > IB/mlx5: Add tx_affinity support for DCI QP > IB/mlx5: Add DCT RoCE LAG support Applied to for-n

[PATCH] net: exit immediately when encounter ipv6 fragment in skb_checksum_setup_ipv6()

2020-08-27 Thread Miaohe Lin
skb_checksum_setup_ipv6() always return -EPROTO if ipv6 packet is fragment. So we should not continue to parse other header type in this case. Also remove unnecessary local variable 'fragment'. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH] net: exit immediately when off = 0 in skb_headers_offset_update()

2020-08-27 Thread Miaohe Lin
In the case of off = 0, skb_headers_offset_update() do nothing indeed. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 18ed56316e56..f67f0da20a5b 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff

Re: powering off phys on 'ip link set down'

2020-08-27 Thread Rasmus Villemoes
On 27/08/2020 13.14, Heiner Kallweit wrote: > On 27.08.2020 13:00, Rasmus Villemoes wrote: >> On 27/08/2020 12.29, Heiner Kallweit wrote: >>> On 27.08.2020 12:08, Rasmus Villemoes wrote: Hi, We have a requirement that when an interface is taken down administratively, the phy sho

Re: [PATCH bpf-next 0/3] bpf: add MPTCP subflow support

2020-08-27 Thread Nicolas Rybowski
Hi Alexei, On Wed, Aug 26, 2020 at 9:13 PM Alexei Starovoitov wrote: > > On Tue, Aug 25, 2020 at 11:55 AM Nicolas Rybowski > wrote: > > > > Hi Alexei, > > > > Thanks for the feedback! > > > > On Tue, Aug 25, 2020 at 12:01 AM Alexei Starovoitov > > wrote: > > > > > > On Fri, Aug 21, 2020 at 05:1

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-27 Thread Lee Jones
o apply: > >> > > >> > error: patch failed: drivers/net/wireless/ath/wil6210/wmi.c:266 > >> > error: drivers/net/wireless/ath/wil6210/wmi.c: patch does not apply > >> > stg import: Diff does not apply cleanly > >> > > >> > Pat

Re: [PATCH 05/30] atmel: Demote non-kerneldoc header to standard comment block

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/atmel/atmel.c:4232: warning: Cannot understand This > file is part of net.russotto.AtmelMACFW, hereto referred to > > Cc: Simon Kelley > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicin

[PATCH net-next v3] gtp: add notification mechanism

2020-08-27 Thread Nicolas Dichtel
Like all other network functions, let's notify gtp context on creation and deletion. Signed-off-by: Nicolas Dichtel Tested-by: Gabriel Ganne Acked-by: Harald Welte --- v2 -> v3: - add ack from Harald - rebase on HEAD of net-next v1 -> v2: - fix typo in the commit title - fix indentation o

Re: [PATCH mlx5-next 1/3] net/mlx5: Refactor query port speed functions

2020-08-27 Thread Jason Gunthorpe
On Mon, Aug 24, 2020 at 01:58:24PM +0300, Leon Romanovsky wrote: > @@ -490,7 +490,7 @@ static int mlx5_query_port_roce(struct ib_device *device, > u8 port_num, > props->active_width = IB_WIDTH_4X; > props->active_speed = IB_SPEED_QDR; > > - translate_eth_proto_oper(eth_p

Re: [PATCH][next] rt2x00: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH][next] brcmfmac: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [net] mwifiex: Increase AES key storage size to 256 bits

2020-08-27 Thread Kalle Valo
Maximilian Luz wrote: > Following commit e18696786548 ("mwifiex: Prevent memory corruption > handling keys") the mwifiex driver fails to authenticate with certain > networks, specifically networks with 256 bit keys, and repeatedly asks > for the password. The kernel log repeats the following line

Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly > and remove .data field. > > Signed-off-by: R

[PATCH net-next v3 0/2] Enable Fiber on DP83822 PHY

2020-08-27 Thread Dan Murphy
Hello The DP83822 Ethernet PHY has the ability to connect via a Fiber port. The derivative PHYs DP83825 and DP83826 do not have this ability. In fiber mode the DP83822 disables auto negotiation and has a fixed 100Mbps speed with support for full or half duplex modes. A devicetree binding was add

[PATCH net-next v3 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-08-27 Thread Dan Murphy
Add a dt binding for the TI dp83822 ethernet phy device. Reviewed-by: Rob Herring Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83822.yaml | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml dif

[PATCH net-next v3 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-08-27 Thread Dan Murphy
The DP83822 can be configured to use a Fiber connection. The strap register is read to determine if the device has been configured to use a fiber connection. With the fiber connection the PHY can be configured to detect whether the fiber connection is active by either a high signal or a low signa

Re: [PATCH net-next v4 0/5] Move MDIO drivers into their own directory

2020-08-27 Thread David Miller
From: Andrew Lunn Date: Thu, 27 Aug 2020 04:00:27 +0200 > The phy subdirectory is getting cluttered. It has both PHY drivers and > MDIO drivers, plus a stray switch driver. Soon more PCS drivers are > likely to appear. > > Move MDIO and PCS drivers into new directories. This requires fixing > up

[PATCH net-next] netfilter: xt_HMARK: Use ip_is_fragment() helper

2020-08-27 Thread YueHaibing
Use ip_is_fragment() to simpify code. Signed-off-by: YueHaibing --- net/netfilter/xt_HMARK.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_HMARK.c b/net/netfilter/xt_HMARK.c index 713fb38541df..8928ec56c388 100644 --- a/net/netfilter/xt_HMARK.c +++ b/net/ne

Re: [PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-27 Thread David Miller
From: Michal Kubecek Date: Thu, 27 Aug 2020 11:50:25 +0200 > On Thu, Aug 27, 2020 at 08:50:19AM +0200, Fabian Frederick wrote: >> Replace common flag assignment with a macro. >> This could yet be simplified with changelink/supported but it would >> remove clarity >> >> Signed-off-by: Fabian Fred

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

2020-08-27 Thread David Miller
From: Himadri Pandya Date: Thu, 27 Aug 2020 12:23:55 +0530 > The buffer size is 2 Bytes and we expect to receive the same amount of > data. But sometimes we receive less data and run into uninit-was-stored > issue upon read. Hence modify the error check on the return value to match > with the buf

[PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
This patch fixes a bunch of issues in cpsw_ndo_vlan_rx_kill_vid() - pm_runtime_get_sync() returns non zero value. This results in non zero value return to caller which will be interpreted as error. So overwrite ret with zero. - If VID matches with port VLAN VID, then set error code. - Cur

  1   2   3   >