[PATCH net-next v2 0/3] net: openvswitch: improve codes

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang This series patches are not bug fix, just improve codes. Tonghao Zhang (3): net: openvswitch: improve coding style net: openvswitch: refactor flow free function net: openvswitch: remove unused keep_flows net/openvswitch/actions.c| 5 +-- net/openvswitch/datapath.

[PATCH net-next v2 1/3] net: openvswitch: improve coding style

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang Not change the logic, just improve coding style. Cc: Pravin B Shelar Signed-off-by: Tonghao Zhang --- net/openvswitch/actions.c| 5 ++-- net/openvswitch/datapath.c | 35 net/openvswitch/flow_table.c | 44 -

[PATCH net-next v2 3/3] net: openvswitch: remove unused keep_flows

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang keep_flows was introduced by [1], which used as flag to delete flows or not. When rehashing or expanding the table instance, we will not flush the flows. Now don't use it anymore, remove it. [1] - https://github.com/openvswitch/ovs/commit/acd051f1761569205827dc9b037e15568a8d

[PATCH net-next v2 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread xiangxia . m . yue
From: Tonghao Zhang Decrease table->count and ufid_count unconditionally, because we only don't use count or ufid_count to count when flushing the flows. To simplify the codes, we remove the "count" argument of table_instance_flow_free. To avoid a bug when deleting flows in the future, add BUG_O

Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread Tonghao Zhang
On Thu, Aug 20, 2020 at 9:52 AM David Miller wrote: > > From: Tonghao Zhang > Date: Thu, 20 Aug 2020 07:21:33 +0800 > > > On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > > > >> From: xiangxia.m@gmail.com > >> > >> Date: Tue, 18 Aug 2020 18:09:22 +0800 > >> > >> > >> > >> > Decrease tab

Re: [PATCH 2/2] genl: ctrl: support dumping netlink policy

2020-08-24 Thread Johannes Berg
On Sun, 2020-08-23 at 19:45 -0600, David Ahern wrote: > On 8/19/20 4:29 AM, Johannes Berg wrote: > > @@ -100,6 +102,30 @@ static int print_ctrl_grp(FILE *fp, struct rtattr > > *arg, __u32 ctrl_ver) > > > > } > > > > +static const char *get_nla_type_str(unsigned int attr) > > +{ > > + switch

[PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread sundeep . lkml
From: Subbaraya Sundeep Hi, This patchset adds PTP support for Octeontx2 platform. PTP is an independent coprocessor block from which CGX block fetches timestamp and prepends it to the packet before sending to NIX block. Patches are as follows: Patch 1: Patch to enable/disable packet timstampin

[PATCH v7 net-next 1/3] octeontx2-af: Support to enable/disable HW timestamping

2020-08-24 Thread sundeep . lkml
From: Zyta Szpak Four new mbox messages ids and handler are added in order to enable or disable timestamping procedure on tx and rx side. Additionally when PTP is enabled, the packet parser must skip over 8 bytes and start analyzing packet data there. To make NPC profiles work seemlesly PTR_ADVAN

[PATCH v7 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor

2020-08-24 Thread sundeep . lkml
From: Aleksey Makarov Precision Timestamping block found on Octeontx2 platform is an independent coprocessor and has internal PTP hardware clock. Once configured PTP runs independently and when a packet arrives CGX hardware block gets the current timestamp from PTP block and forwards the packet t

[PATCH v7 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-08-24 Thread sundeep . lkml
From: Aleksey Makarov This patch adds PTP clock and uses it in Octeontx2 network device. PTP clock uses mailbox calls to access the hardware counter on the RVU side. Co-developed-by: Subbaraya Sundeep Signed-off-by: Subbaraya Sundeep Signed-off-by: Aleksey Makarov Signed-off-by: Sunil Goutham

Re: linux-next: build failure after merge of the net-next tree

2020-08-24 Thread Sven Joachim
On 2020-08-22 08:16 +0200, Sven Joachim wrote: > On 2020-08-21 09:23 -0700, Brian Vazquez wrote: > >> Hi Sven, >> >> Sorry for the late reply, did you still see this after: >> https://patchwork.ozlabs.org/project/netdev/patch/20200803131948.41736-1-yuehaib...@huawei.com/ >> ?? > > That patch is ap

Re: (EXT) Re: [PATCH net-next 2/2] net: phy: dp83867: apply ti, led-function and ti, led-ctrl to registers

2020-08-24 Thread Matthias Schiffer
On Sat, 2020-08-22 at 18:08 +0200, Andrew Lunn wrote: > On Fri, Aug 21, 2020 at 09:21:46AM +0200, Matthias Schiffer wrote: > > These DT bindings are already in use by the imx7-mba7 DTS, but they > > were > > not supported by the PHY driver so far. > > > > Signed-off-by: Matthias Schiffer > > > >

Re: [PATCH 00/32] Set 2: Rid W=1 warnings in Wireless

2020-08-24 Thread Lee Jones
On Sat, 22 Aug 2020, Christian Lamparter wrote: > On 2020-08-21 09:16, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > I see that after our discussion about the

Re: BPF sk_lookup v5 - TCP SYN and UDP 0-len flood benchmarks

2020-08-24 Thread Paolo Abeni
On Tue, 2020-08-18 at 11:19 -0700, Alexei Starovoitov wrote: > On Tue, Aug 18, 2020 at 8:49 AM Jakub Sitnicki wrote: > > : rcu_read_lock(); > > : run_array = > > rcu_dereference(net->bpf.run_array[NETNS_BPF_SK_LOOKUP]); > > 0.01 :

Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329

2020-08-24 Thread Arend Van Spriel
On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: This patch fixes SDHCI CRC errors during of RX throughput testing on BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark value is borrowed from downstream BCMDHD

Re: [PATCH 1/3] xfrm: clone XFRMA_SET_MARK during xfrm_do_migrate

2020-08-24 Thread Steffen Klassert
On Thu, Aug 20, 2020 at 08:11:58PM +0200, Antony Antony wrote: > XFRMA_SET_MARK and XFRMA_SET_MARK_MASK was not cloned from the old > to the new. Migrate these two attributes during XFRMA_MSG_MIGRATE > > Signed-off-by: Antony Antony Please add a 'Fixes' tag so that this can be backported properl

[PATCH 5.7 077/124] bonding: show saner speed for broadcast mode

2020-08-24 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 4ca0d9ac3fd8f9f90b72a15d8da2aca3ffb58418 ] Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the slowest active interface

[PATCH 5.4 076/107] bonding: show saner speed for broadcast mode

2020-08-24 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 4ca0d9ac3fd8f9f90b72a15d8da2aca3ffb58418 ] Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the slowest active interface

expects argument of type 'size_t', but argument 5 has type 'Elf64_Xword

2020-08-24 Thread Naresh Kamboju
while building perf with gcc 7.3.0 on linux next this warning/error is found. In file included from libbpf.c:55:0: libbpf.c: In function 'bpf_object__elf_collect': libbpf_internal.h:74:22: error: format '%zu' expects argument of type 'size_t', but argument 5 has type 'Elf64_Xword {aka long long un

Re: [PATCH v7 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor

2020-08-24 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sundeep-lkml-gmail-com/Add-PTP-support-for-Octeontx2/20200824-155705 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

[PATCH 4.19 45/71] bonding: show saner speed for broadcast mode

2020-08-24 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 4ca0d9ac3fd8f9f90b72a15d8da2aca3ffb58418 ] Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the slowest active interface

RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-24 Thread Van Leeuwen, Pascal
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of Andrew Lunn > Sent: Wednesday, August 12, 2020 2:42 PM > To: Van Leeuwen, Pascal > Cc: Sabrina Dubroca ; Scott Dial ; > linux-cry...@vger.kernel.org; Ryan Cox > ; netdev@vger.kernel.org; da...@davemloft.net;

[PATCH 4.14 37/50] bonding: show saner speed for broadcast mode

2020-08-24 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 4ca0d9ac3fd8f9f90b72a15d8da2aca3ffb58418 ] Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the slowest active interface

Re: [PATCH 6/6] xfrm: add espintcp (RFC 8229)

2020-08-24 Thread Steffen Klassert
Ccing Sabrina. On Fri, Aug 21, 2020 at 02:46:44PM -0700, Eric Dumazet wrote: > > > On 1/20/20 11:38 PM, Steffen Klassert wrote: > > From: Sabrina Dubroca > > > > TCP encapsulation of IKE and IPsec messages (RFC 8229) is implemented > > as a TCP ULP, overriding in particular the sendmsg and rec

[net-next v4] seg6: using DSCP of inner IPv4 packets

2020-08-24 Thread Ahmed Abdelsalam
This patch allows copying the DSCP from inner IPv4 header to the outer IPv6 header, when doing SRv6 Encapsulation. This allows forwarding packet across the SRv6 fabric based on their original traffic class. Signed-off-by: Ahmed Abdelsalam --- net/ipv6/seg6_iptunnel.c | 36 +++---

[PATCH] rtw88: pci: Power cycle device during shutdown

2020-08-24 Thread Kai-Heng Feng
Sometimes system freeze on cold/warm boot when rtw88 is probing. According to [1], platform firmware may not properly power manage the device during shutdown. I did some expirements and putting the device to D3 can workaround the issue. So let's power cycle the device by putting the device to D3

Re: [PATCH 3/3] xfrm: clone XFRMA_SEC_CTX during xfrm_do_migrate

2020-08-24 Thread Steffen Klassert
On Thu, Aug 20, 2020 at 08:16:08PM +0200, Antony Antony wrote: > XFRMA_SEC_CTX was not cloned from the old to the new. > Migrate this attribute during XFRMA_MSG_MIGRATE > > Signed-off-by: Antony Antony > --- > net/xfrm/xfrm_state.c | 28 > 1 file changed, 28 insertio

Re: [PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame

2020-08-24 Thread Jesper Dangaard Brouer
On Sun, 23 Aug 2020 17:08:30 +0300 Shay Agroskin wrote: > > diff --git a/include/net/xdp.h b/include/net/xdp.h > > index 3814fb631d52..42f439f9fcda 100644 > > --- a/include/net/xdp.h > > +++ b/include/net/xdp.h > > @@ -72,7 +72,8 @@ struct xdp_buff { > > void *data_hard_start; > > struct

Re: [PATCH 2/3] xfrm: clone XFRMA_REPLAY_ESN_VAL in xfrm_do_migrate

2020-08-24 Thread Steffen Klassert
On Thu, Aug 20, 2020 at 08:14:52PM +0200, Antony Antony wrote: > XFRMA_REPLAY_ESN_VAL was not cloned from the old to the new. > Migrate this attribute during XFRMA_MSG_MIGRATE > > Signed-off-by: Antony Antony > --- > include/net/xfrm.h| 16 ++-- > net/xfrm/xfrm_state.c | 2 +- >

Re: [PATCH 01/12] staging: wfx: fix BA when device is AP and MFP is enabled

2020-08-24 Thread Dan Carpenter
On Thu, Aug 20, 2020 at 05:58:47PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > The protection of the management frames is mainly done by mac80211. > However, frames for the management of the BlockAck sessions are directly > sent by the device. These frames have to be protected if MF

[PATCH 5.8 091/148] bonding: show saner speed for broadcast mode

2020-08-24 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 4ca0d9ac3fd8f9f90b72a15d8da2aca3ffb58418 ] Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the slowest active interface

[PATCH rdma-next 0/3] Fix in-kernel active_speed type

2020-08-24 Thread Leon Romanovsky
From: Leon Romanovsky IBTA declares speed as 16 bits, but kernel stores it in u8. This series fixes in-kernel declaration while keeping external interface intact. Thanks Aharon Landau (3): net/mlx5: Refactor query port speed functions RDMA/mlx5: Delete duplicated mlx5_ptys_width enum RDMA

[PATCH mlx5-next 1/3] net/mlx5: Refactor query port speed functions

2020-08-24 Thread Leon Romanovsky
From: Aharon Landau The functions mlx5_query_port_link_width_oper and mlx5_query_port_ib_proto_oper are always called together, so combine them to a new function called mlx5_query_port_oper to avoid duplication. And while the mlx5i_get_port_settings is the same as mlx5_query_port_oper therefore

[PATCH mlx5-next 2/3] RDMA/mlx5: Delete duplicated mlx5_ptys_width enum

2020-08-24 Thread Leon Romanovsky
From: Aharon Landau Combine two same enums to avoid duplication. Signed-off-by: Aharon Landau Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 20 ++- .../mellanox/mlx5/core/ipoib/ethtool.c| 8

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-24 Thread Vladimir Oltean
Hi Sasha, On Wed, Aug 12, 2020 at 05:34:30PM +0300, Vladimir Oltean wrote: > On Wed, Aug 12, 2020 at 03:51:44PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-08-03 18:21:45 [-0700], David Miller wrote: > > > From: Vladimir Oltean > > > > The driver calls napi_schedule_irqoff() from a contex

Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
On 8/21/20 4:00 PM, Jesse Brandeburg wrote: Murali Karicheri wrote: To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port. With

[PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED

2020-08-24 Thread Miaohe Lin
There is no need to fetch errno and fatal info from icmp_err_convert when icmp code is ICMP_FRAG_NEEDED. Signed-off-by: Miaohe Lin --- net/ipv4/raw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c index 6fd4330287c2..ea4c36e93824 100644 -

[PATCH] net: gain ipv4 mtu when mtu is not locked

2020-08-24 Thread Miaohe Lin
When mtu is locked, we should not obtain ipv4 mtu as we return immediately in this case and leave acquired ipv4 mtu unused. Signed-off-by: Miaohe Lin --- net/ipv4/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 8ca6bcab7b03.

[PATCH 0/6] Netfilter fixes for net

2020-08-24 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Don't flag SCTP heartbeat as invalid for re-used connections, from Florian Westphal. 2) Bogus overlap report due to rbtree tree rotations, from Stefano Brivio. 3) Detect partial overlap with start end point match, also from Stef

[PATCH 3/6] netfilter: nft_set_rbtree: Detect partial overlap with start endpoint match

2020-08-24 Thread Pablo Neira Ayuso
From: Stefano Brivio Getting creative with nft and omitting the interval_overlap() check from the set_overlap() function, without omitting set_overlap() altogether, led to the observation of a partial overlap that wasn't detected, and would actually result in replacement of the end element of an

[PATCH 2/6] netfilter: nft_set_rbtree: Handle outcomes of tree rotations in overlap detection

2020-08-24 Thread Pablo Neira Ayuso
From: Stefano Brivio Checks for partial overlaps on insertion assume that end elements are always descendant nodes of their corresponding start, because they are inserted later. However, this is not the case if a previous delete operation caused a tree rotation as part of rebalancing. Taking the

[PATCH 4/6] netfilter: nf_tables: add NFTA_SET_USERDATA if not null

2020-08-24 Thread Pablo Neira Ayuso
Kernel sends an empty NFTA_SET_USERDATA attribute with no value if userspace adds a set with no NFTA_SET_USERDATA attribute. Fixes: e6d8ecac9e68 ("netfilter: nf_tables: Add new attributes into nft_set to store user data.") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 3 +

[PATCH 6/6] netfilter: nf_tables: fix destination register zeroing

2020-08-24 Thread Pablo Neira Ayuso
From: Florian Westphal Following bug was reported via irc: nft list ruleset set knock_candidates_ipv4 { type ipv4_addr . inet_service size 65535 elements = { 127.0.0.1 . 123, 127.0.0.1 . 123 } } .. udp dport 123 add @knock_candidates_ipv4 { ip sad

[PATCH 1/6] netfilter: conntrack: allow sctp hearbeat after connection re-use

2020-08-24 Thread Pablo Neira Ayuso
From: Florian Westphal If an sctp connection gets re-used, heartbeats are flagged as invalid because their vtag doesn't match. Handle this in a similar way as TCP conntrack when it suspects that the endpoints and conntrack are out-of-sync. When a HEARTBEAT request fails its vtag validation, fla

[PATCH 5/6] netfilter: nf_tables: incorrect enum nft_list_attributes definition

2020-08-24 Thread Pablo Neira Ayuso
This should be NFTA_LIST_UNSPEC instead of NFTA_LIST_UNPEC, all other similar attribute definitions are postfixed with _UNSPEC. Fixes: 96518518cc41 ("netfilter: add nftables") Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] net: Use helper macro RT_TOS() in __icmp_send()

2020-08-24 Thread Miaohe Lin
Use helper macro RT_TOS() to get tos in __icmp_send(). Signed-off-by: Miaohe Lin --- net/ipv4/icmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index cf36f955bfe6..3b387dc3864f 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -6

[PATCH net] ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype

2020-08-24 Thread Tobias Klauser
Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") changed ndisc_ifinfo_sysctl_change to take a kernel pointer. Adjust its prototype in net/ndisc.h as well to fix the following sparse warning: net/ipv6/ndisc.c:1838:5: error: symbol 'ndisc_ifinfo_sysctl_change' redeclared with

Re: [PATCH 01/12] staging: wfx: fix BA when device is AP and MFP is enabled

2020-08-24 Thread Jérôme Pouiller
On Monday 24 August 2020 11:50:42 CEST Dan Carpenter wrote: > On Thu, Aug 20, 2020 at 05:58:47PM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > The protection of the management frames is mainly done by mac80211. > > However, frames for the management of the BlockAck sessions are d

Re: [PATCH] net: Get rid of consume_skb when tracing is off

2020-08-24 Thread Neil Horman
On Sat, Aug 22, 2020 at 12:49:02PM -0700, David Miller wrote: > > From: Neil Horman > > Neil, you might want to fix this so people can reply to you :-) Crap, thanks, new computer. Neil >

Re: [PATCH] net: hns: Fix memleak in hns_nic_dev_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Mon, 24 Aug 2020 13:44:42 +0800 > hns_nic_dev_probe allocates ndev, but not free it on > two error handling paths, which may lead to memleak. > > Fixes: 63434888aaf1b ("net: hns: net: hns: enet adds support of acpi") > Signed-off-by: Dinghao Liu Applied and queued up fo

Re: [PATCH] net: systemport: Fix memleak in bcm_sysport_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Mon, 24 Aug 2020 13:58:31 +0800 > When devm_kcalloc() fails, dev should be freed just > like what we've done in the subsequent error paths. > > Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX > rings") > Signed-off-by: Dinghao Liu Applied and

Re: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-24 Thread Andrew Lunn
On Mon, Aug 24, 2020 at 09:07:26AM +, Van Leeuwen, Pascal wrote: > No need to point this out to me as we're the number one supplier of inline > MACsec IP :-) > In fact, the Microsemi PHY solution you mention is ours, major parts of that > design were > even created by these 2 hands here. Oh,

Re: [PATCH net-next v2 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread David Miller
From: xiangxia.m@gmail.com Date: Mon, 24 Aug 2020 15:36:01 +0800 > To avoid a bug when deleting flows in the future, add > BUG_ON in flush flows function. BUG_ON() is too severe, I think WARN_ON() or similar are sufficient because the kernel can try to continue operating if this condition is

Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: sundeep.l...@gmail.com Date: Mon, 24 Aug 2020 13:25:14 +0530 > This patchset adds PTP support for Octeontx2 platform. > PTP is an independent coprocessor block from which > CGX block fetches timestamp and prepends it to the > packet before sending to NIX block. Patches are as > follows: > >

Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread David Miller
From: David Miller Date: Mon, 24 Aug 2020 06:16:57 -0700 (PDT) > Series applied, thank you. Actually, this doesn't even compile: drivers/net/ethernet/marvell/octeontx2/af/ptp.c: In function ‘get_clock_rate’: drivers/net/ethernet/marvell/octeontx2/af/ptp.c:60:26: error: implicit declaration of

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2020 08:49:30 +0200 Mauro Carvalho Chehab escreveu: > Hi John, > > Em Wed, 19 Aug 2020 20:28:44 -0700 > John Stultz escreveu: > > > > That said even with the patches I've got on top of your series, I > > still see a few issues: > > 1) I'm seeing red-blue swap with your driver.

Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Mon, 24 Aug 2020 01:00:54 +0530 > --- > > Signed-off-by: Sumera Priyadarsini > > Signed-off-by: Sumera Priyadarsini You only need one Signed-off-by: You must not put the signoff after the "---" otherwise GIT will remove it from the commit log message when I t

[PATCH v2 0/7] crypto: mark ecb(arc4) skcipher as obsolete

2020-08-24 Thread Ard Biesheuvel
RC4 hasn't aged very well, and is a poor fit for the skcipher API so it would be good if we could get rid of the ecb(arc4) drivers in the kernel at some point in the future. This prevents new users from creeping in, and allows us to improve the skcipher API without having to care too much about obs

[PATCH v2 2/7] staging/rtl8192u: switch to RC4 library interface

2020-08-24 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel Acked-by: Greg Kroah-Hartman --- drivers/staging/rtl8192u/Kconfig | 1 +

[PATCH v2 3/7] SUNRPC: remove RC4-HMAC-MD5 support from KerberosV

2020-08-24 Thread Ard Biesheuvel
The RC4-HMAC-MD5 KerberosV algorithm is based on RFC 4757 [0], which was specifically issued for interoperability with Windows 2000, but was never intended to receive the same level of support. The RFC says The IETF Kerberos community supports publishing this specification as an informational

[PATCH v2 4/7] crypto: n2 - remove ecb(arc4) support

2020-08-24 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/n2_core.c | 46 1 file changed, 46 deletions(-) diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c index d8aec5153b21..8c8e17d5fb20 100644 --- a/drivers/crypto/n2_core.c +++ b/drivers/crypto/n2_core.c @@ -662,7 +

[PATCH v2 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

2020-08-24 Thread Ard Biesheuvel
Cryptographic algorithms may have a lifespan that is significantly shorter than Linux's, and so we need to start phasing out algorithms that are known to be broken, and are no longer fit for general use. RC4 (or arc4) is a good example here: there are a few areas where its use is still somewhat ac

Re: [PATCH] net: gain ipv4 mtu when mtu is not locked

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:35:28 -0400 > When mtu is locked, we should not obtain ipv4 mtu as we return immediately > in this case and leave acquired ipv4 mtu unused. > > Signed-off-by: Miaohe Lin > --- > net/ipv4/route.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-

Re: [PATCH v2 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

2020-08-24 Thread Ard Biesheuvel
On Mon, 24 Aug 2020 at 15:35, Herbert Xu wrote: > > On Mon, Aug 24, 2020 at 03:30:01PM +0200, Ard Biesheuvel wrote: > > > > +config CRYPTO_USER_ENABLE_OBSOLETE > > + bool "Enable obsolete cryptographic algorithms for userspace" > > + depends on CRYPTO_USER > > That should be CRYPTO_USER_AP

Re: [PATCH 0/6] Netfilter fixes for net

2020-08-24 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 24 Aug 2020 13:39:35 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Don't flag SCTP heartbeat as invalid for re-used connections, >from Florian Westphal. > > 2) Bogus overlap report due to rbtree tree rotations, from Stefano Brivio

Re: [PATCH v2 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

2020-08-24 Thread Herbert Xu
On Mon, Aug 24, 2020 at 03:30:01PM +0200, Ard Biesheuvel wrote: > > +config CRYPTO_USER_ENABLE_OBSOLETE > + bool "Enable obsolete cryptographic algorithms for userspace" > + depends on CRYPTO_USER That should be CRYPTO_USER_API which is the option for af_alg. CRYPTO_USER is the configurati

[PATCH v2 6/7] net: wireless: drop bogus CRYPTO_xxx Kconfig selects

2020-08-24 Thread Ard Biesheuvel
Drop some bogus Kconfig selects that are not entirely accurate, and unnecessary to begin with, since the same Kconfig options also select LIB80211 features that already imply the selected functionality (AES for CCMP, ARC4 and ECB for TKIP) Signed-off-by: Ard Biesheuvel --- drivers/net/wireless/i

[PATCH v2 5/7] crypto: bcm-iproc - remove ecb(arc4) support

2020-08-24 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/bcm/cipher.c | 96 +--- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c| 23 + drivers/crypto/bcm/spu.h| 1 - drivers/crypto/bcm/spu2.c | 12 +-- drivers/crypto/bcm/spu2.h | 1 - 6 files changed, 6 ins

Re: [PATCH net] ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype

2020-08-24 Thread David Miller
From: Tobias Klauser Date: Mon, 24 Aug 2020 13:46:22 +0200 > Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") > changed ndisc_ifinfo_sysctl_change to take a kernel pointer. Adjust its > prototype in net/ndisc.h as well to fix the following sparse warning: > > net/ipv6/ndisc

Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 01:00:54AM +0530, Sumera Priyadarsini wrote: > Every iteration of for_each_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no dec

[PATCH v2 1/7] staging/rtl8192e: switch to RC4 library interface

2020-08-24 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel Acked-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/Kconfig | 4 +- drivers/sta

KMSAN: uninit-value in skb_trim

2020-08-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=16e3c4b690 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH net-next v2 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread Tonghao Zhang
On Mon, Aug 24, 2020 at 9:09 PM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Mon, 24 Aug 2020 15:36:01 +0800 > > > To avoid a bug when deleting flows in the future, add > > BUG_ON in flush flows function. > > BUG_ON() is too severe, I think WARN_ON() or similar are sufficient > b

Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-24 Thread Madhuparna Bhowmik
On Sun, Aug 23, 2020 at 12:12:01PM -0700, Xie He wrote: > On Sun, Aug 23, 2020 at 8:28 AM Madhuparna Bhowmik > wrote: > > > > sl->xhead is modified in both x25_asy_change_mtu() and > > x25_asy_write_wakeup(). However, sl->lock is not held in > > x25_asy_write_wakeup(). So, I am not sure if it is i

[PATCH bpf] bpf, sysctl: let bpf_stats_handler take a kernel pointer buffer

2020-08-24 Thread Tobias Klauser
Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") changed ctl_table.proc_handler to take a kernel pointer. Adjust the signature of bpf_stats_handler to match ctl_table.proc_handler which fixes the following sparse warning: kernel/sysctl.c:226:49: warning: incorrect type in arg

Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread sundeep subbaraya
Hi David, On Mon, Aug 24, 2020 at 6:47 PM David Miller wrote: > > From: David Miller > Date: Mon, 24 Aug 2020 06:16:57 -0700 (PDT) > > > Series applied, thank you. > > Actually, this doesn't even compile: > Our Marvell GCC10 ARM64 compiler did not complain anything about this even with W=1 and m

Request for backport of 78dc70ebaa38aa303274e333be6c98eef87619e2 to 4.19.y

2020-08-24 Thread Robert Bengtsson-Ölund
Hi everyone We stumbled upon a TCP BBR throughput issue that the following change fixes. git: 78dc70ebaa38aa303274e333be6c98eef87619e2 Our issue: We have a transmission that is application limited to 20Mbps on an ethernet connection that has ~1Gbps capacity. Without this change our transmission s

[PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-24 Thread Mira Ressel
Set the perm_addr of veth devices to whatever MAC has been assigned to the device. Otherwise, it remains all zero, with the consequence that ipv6_generate_stable_address() (which is used if the sysctl net.ipv6.conf.DEV.addr_gen_mode is set to 2 or 3) assigns every veth interface on a host the same

[PATCH 2/2] vlan: Initialize dev->perm_addr

2020-08-24 Thread Mira Ressel
Set the perm_addr of vlan devices to that of their parent device. Otherwise, it remains all zero, with the consequence that ipv6_generate_stable_address() (which is used if the sysctl net.ipv6.conf.DEV.addr_gen_mode is set to 2 or 3) assigns every vlan interface on a host the same link-local addres

[net v3 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port. Without this, these entries remain in the ALE table even after removing the VLA

[net v3 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port. Without this, these entries remain in the ALE table even after removing the VLA

[PATCH net] sfc: fix boolreturn.cocci warning and rename function

2020-08-24 Thread Edward Cree
check_fcs() was returning bool as 0/1, which was a sign that the sense of the function was unclear: false was good, which doesn't really match a name like 'check_$thing'. So rename it to ef100_has_fcs_error(), and use proper booleans in the return statements. Reported-by: kernel test robot Si

Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329

2020-08-24 Thread Dmitry Osipenko
24.08.2020 11:28, Arend Van Spriel пишет: > > > On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: >> This patch fixes SDHCI CRC errors during of RX throughput testing on >> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the >> checksum problem is observed on NVIDIA Tegra20 SoCs. The go

Re: [PATCH] net: systemport: Fix memleak in bcm_sysport_probe

2020-08-24 Thread Florian Fainelli
On 8/23/2020 10:58 PM, Dinghao Liu wrote: When devm_kcalloc() fails, dev should be freed just like what we've done in the subsequent error paths. Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX rings") Signed-off-by: Dinghao Liu Acked-by: Florian Fainelli This

[PATCH v8 net-next 1/3] octeontx2-af: Support to enable/disable HW timestamping

2020-08-24 Thread sundeep . lkml
From: Zyta Szpak Four new mbox messages ids and handler are added in order to enable or disable timestamping procedure on tx and rx side. Additionally when PTP is enabled, the packet parser must skip over 8 bytes and start analyzing packet data there. To make NPC profiles work seemlesly PTR_ADVAN

[PATCH v8 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-08-24 Thread sundeep . lkml
From: Aleksey Makarov This patch adds PTP clock and uses it in Octeontx2 network device. PTP clock uses mailbox calls to access the hardware counter on the RVU side. Co-developed-by: Subbaraya Sundeep Signed-off-by: Subbaraya Sundeep Signed-off-by: Aleksey Makarov Signed-off-by: Sunil Goutham

[PATCH v8 net-next 0/3] Add PTP support for Octeontx2

2020-08-24 Thread sundeep . lkml
From: Subbaraya Sundeep Hi, This patchset adds PTP support for Octeontx2 platform. PTP is an independent coprocessor block from which CGX block fetches timestamp and prepends it to the packet before sending to NIX block. Patches are as follows: Patch 1: Patch to enable/disable packet timstampin

[PATCH v8 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor

2020-08-24 Thread sundeep . lkml
From: Aleksey Makarov Precision Timestamping block found on Octeontx2 platform is an independent coprocessor and has internal PTP hardware clock. Once configured PTP runs independently and when a packet arrives CGX hardware block gets the current timestamp from PTP block and forwards the packet t

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2020 17:56:50 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote: > > Another quick question: > > > > Em Wed, 19 Aug 2020 19:35:58 +0200 > > Sam Ravnborg escreveu: > > > > > > +#define DSS_REDUCE(x) ((x) > 0 ? (

Re: Request for backport of 78dc70ebaa38aa303274e333be6c98eef87619e2 to 4.19.y

2020-08-24 Thread Eric Dumazet
On 8/24/20 7:35 AM, Robert Bengtsson-Ölund wrote: > Hi everyone > > We stumbled upon a TCP BBR throughput issue that the following change fixes. > git: 78dc70ebaa38aa303274e333be6c98eef87619e2 > > Our issue: > We have a transmission that is application limited to 20Mbps on an > ethernet connec

[PATCH 3/5] batman-adv: types.h: delete duplicated words

2020-08-24 Thread Simon Wunderlich
From: Randy Dunlap Delete the doubled word "time" in a comment. Delete the doubled word "address" in a comment. Signed-off-by: Randy Dunlap Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/5] batman-adv: Drop unused function batadv_hardif_remove_interfaces()

2020-08-24 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_hardif_remove_interfaces was meant to remove all interfaces which are currently in the list of known (compatible) hardifs during module unload. But the function unregister_netdevice_notifier is called in batadv_exit before batadv_hardif_remove_interfaces.

[PATCH 2/3] batman-adv: Fix own OGM check in aggregated OGMs

2020-08-24 Thread Simon Wunderlich
From: Linus Lüssing The own OGM check is currently misplaced and can lead to the following issues: For one thing we might receive an aggregated OGM from a neighbor node which has our own OGM in the first place. We would then not only skip our own OGM but erroneously also any other, following OGM

[PATCH 0/3] pull request for net: batman-adv 2020-08-24

2020-08-24 Thread Simon Wunderlich
Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20200824 for you to fetch changes up to 279e89b2281af3b1a9f04906e157992c19c9f163: batman-adv: bla: use netif_rx_ni when not in interrupt context (2020-08-18 19:40:03 +0200

[PATCH 3/3] batman-adv: bla: use netif_rx_ni when not in interrupt context

2020-08-24 Thread Simon Wunderlich
From: Jussi Kivilinna batadv_bla_send_claim() gets called from worker thread context through batadv_bla_periodic_work(), thus netif_rx_ni needs to be used in that case. This fixes "NOHZ: local_softirq_pending 08" log messages seen when batman-adv is enabled. Fixes: 23721387c409 ("batman-adv: add

[PATCH 1/3] batman-adv: Avoid uninitialized chaddr when handling DHCP

2020-08-24 Thread Simon Wunderlich
From: Sven Eckelmann The gateway client code can try to optimize the delivery of DHCP packets to avoid broadcasting them through the whole mesh. But also transmissions to the client can be optimized by looking up the destination via the chaddr of the DHCP packet. But the chaddr is currently only

[PATCH 4/5] batman-adv: Drop repeated words in comments

2020-08-24 Thread Simon Wunderlich
From: Sven Eckelmann checkpatch found various instances of "Possible repeated word" in various comments. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/fragmentation.c | 2 +- net/batman-adv/hard-interfac

[PATCH 0/5] pull request for net-next: batman-adv 2020-08-24

2020-08-24 Thread Simon Wunderlich
Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20200824 for you to fetch changes up to 0093870aa891594d170e1dc9aa192a30d530d755: batman-adv: Migrate to linux/prandom.h (2020-08-18 19:39:54 +0200

[PATCH 5/5] batman-adv: Migrate to linux/prandom.h

2020-08-24 Thread Simon Wunderlich
From: Sven Eckelmann The commit c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") introduced a new header for the pseudo random functions from (previously) linux/random.h. One future goal of the prandom.h change is to make code to switch just the new header file an

[PATCH 1/5] batman-adv: Start new development cycle

2020-08-24 Thread Simon Wunderlich
Signed-off-by: Simon Wunderlich --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 0393bb9ed3d0..a47dc332d796 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -13,7 +13,7 @@ #define BA

  1   2   3   >