Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Robin Murphy
Hi Tomasz, On 2020-08-19 12:16, Tomasz Figa wrote: Hi Christoph, On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, Could you explain what makes you think it's unused? It's a feature of the UAPI generally supported by the v

[PATCH] staging: wilc1000: Fix memleak in wilc_bus_probe

2020-08-19 Thread Dinghao Liu
When devm_clk_get() returns -EPROBE_DEFER, spi_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") Signed-off-by: Dinghao Liu --- drivers/net/wireless/microchip/wilc1000/spi.c | 5 +++-- 1 file changed, 3

[PATCH 47/49] dts: add support for Hikey 970 DRM

2020-08-19 Thread Mauro Carvalho Chehab
Add the needed bits for the DRM driver to work with the Hikey 970 board. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 52 +++ arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 6 + .../boot/dts/hisilicon/hikey970-drm.dtsi | 130 ++

[PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Mauro Carvalho Chehab
Add a description of the bindings used by Kirin 960/970 Display Serial Interface (DSI) controller and by its Display Engine (DPE). Signed-off-by: Mauro Carvalho Chehab --- .../display/hisilicon,hi3660-dpe.yaml | 99 + .../display/hisilicon,hi3660-dsi.yaml | 102 +

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Moshe Shemesh
On 8/19/2020 3:10 AM, Jakub Kicinski wrote: On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: On 8/17/2020 7:36 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The ac

RE: [PATCH V1 net-next 1/3] net: ena: ethtool: Add new device statistics

2020-08-19 Thread Jubran, Samih
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, August 4, 2020 1:18 AM > To: Jubran, Samih > Cc: da...@davemloft.net; netdev@vger.kernel.org; Woodhouse, David > ; Machulsky, Zorik ; > Matushevsky, Alexander ; Bshara, Saeed > ; Wilson, Matt ; Liguori, > Anthony ; Bshara, Na

[PATCH v2] dt-bindings: net: renesas,ether: Improve schema validation

2020-08-19 Thread Geert Uytterhoeven
- Remove pinctrl consumer properties, as they are handled by core dt-schema, - Document missing properties, - Document missing PHY child node, - Add "additionalProperties: false". Signed-off-by: Geert Uytterhoeven Reviewed-by: Rob Herring --- v2: - Add Reviewed-by. --- .../binding

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jiri Pirko
Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: > >On 8/19/2020 3:10 AM, Jakub Kicinski wrote: >> >> On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: >> > On 8/17/2020 7:36 PM, Jiri Pirko wrote: >> > > Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: >> > > > Ad

RE: [PATCH v2] net: sctp: Fix negotiation of the number of data streams.

2020-08-19 Thread David Laight
The number of output and input streams was never being reduced, eg when processing received INIT or INIT_ACK chunks. The effect is that DATA chunks can be sent with invalid stream ids and then discarded by the remote system. Fixes: 2075e50caf5ea ("sctp: convert to genradix") Signed-off-by: David L

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Tomasz Figa
On Wed, Aug 19, 2020 at 1:51 PM Robin Murphy wrote: > > Hi Tomasz, > > On 2020-08-19 12:16, Tomasz Figa wrote: > > Hi Christoph, > > > > On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: > >> > >> The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, > > > > Could you explain what m

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Jens Axboe
On 8/18/20 1:00 PM, James Bottomley wrote: > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: >> On 8/17/20 12:48 PM, Kees Cook wrote: >>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: On 8/17/20 12:29 PM, Kees Cook wrote: > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-08-19 Thread Era Mayflower
On Wed, Jun 24, 2020 at 10:23 AM Era Mayflower wrote: > > On Wed, Jun 17, 2020 at 1:32 AM Era Mayflower wrote: > > > > On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower > > wrote: > > > > > > On Tue, Jun 16, 2020 at 1:23 AM David Miller wrote: > > > > > > > > From: Era Mayflower > > > > Date: Tu

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread Andrew Lunn
> In general, according to phy.rst, RGMII delay should be done by phy, but > some MoCA product need RGMII delay in MAC. These two requirements > conflict. Is there any suggestion to solve the conflict? Implementing the delay in the PHY is just a recommendation, not a requirement. However, as i sai

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > >> On 8/17/20 12:48 PM, Kees Cook wrote: > >>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > On 8/17/20 12:29 PM,

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Jens Axboe
On 8/19/20 6:11 AM, Greg KH wrote: > On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: >> On 8/18/20 1:00 PM, James Bottomley wrote: >>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: On 8/17/20 12:48 PM, Kees Cook wrote: > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axb

[PATCH net-next 5/6] net: mvneta: add multi buffer support to XDP_TX

2020-08-19 Thread Lorenzo Bianconi
Introduce the capability to map non-linear xdp buffer running mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 79 +-- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/drivers/

[PATCH net-next 6/6] net: mvneta: enable jumbo frames for XDP

2020-08-19 Thread Lorenzo Bianconi
Enable the capability to receive jumbo frames even if the interface is running in XDP mode Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvel

Re: [PATCH net-next v2 2/2] net: dsa: loop: Return VLAN table size through devlink

2020-08-19 Thread Andrew Lunn
On Tue, Aug 18, 2020 at 09:32:18PM -0700, Florian Fainelli wrote: > We return the VLAN table size through devlink as a simple parameter, we > do not support altering it at runtime: > > devlink resource show mdio_bus/fixed-0:1f > mdio_bus/fixed-0:1f: > name VTU size 4096 occ 0 unit entry dpipe_ta

Re: [PATCH net-next v2 1/2] net: dsa: loop: Configure VLANs while not filtering

2020-08-19 Thread Andrew Lunn
On Tue, Aug 18, 2020 at 09:32:17PM -0700, Florian Fainelli wrote: > Since this is a mock-up driver with no real data path for now, but we > will have one at some point, enable VLANs while not filtering. > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

[PATCH net-next 4/6] xdp: add multi-buff support to xdp_return_{buff/frame}

2020-08-19 Thread Lorenzo Bianconi
Take into account if the received xdp_buff/xdp_frame is non-linear recycling/returning the frame memory to the allocator Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 17 +++-- net/core/xdp.c| 36 2 files changed, 51 insertions(+), 2

[PATCH net-next 2/6] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-08-19 Thread Lorenzo Bianconi
Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. This is a preliminary patch to enable xdp multi-buffer support. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 1 + drivers/net/

[PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame

2020-08-19 Thread Lorenzo Bianconi
Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer to specify if shared_info area has been properly initialized for non-linear xdp buffers Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 8 ++-- net/core/xdp.c| 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --gi

[PATCH net-next 0/6] mvneta: introduce XDP multi-buffer support

2020-08-19 Thread Lorenzo Bianconi
Finalize XDP multi-buffer support for mvneta driver introducing the capability to map non-linear buffers on tx side. Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer to specify if shared_info area has been properly initialized. Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers

[PATCH net-next 3/6] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer

2020-08-19 Thread Lorenzo Bianconi
Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and XDP remote drivers if this is a "non-linear" XDP buffer Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:17:19AM -0600, Jens Axboe wrote: > On 8/19/20 6:11 AM, Greg KH wrote: > > On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > >> On 8/18/20 1:00 PM, James Bottomley wrote: > >>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kee

[PATCH v3 6/7] arm64: dts: renesas: rcar-gen3: Convert EtherAVB to explicit delay handling

2020-08-19 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these delays based on the "rgmii-

[PATCH V2 net-next 3/4] net: ena: ethtool: add stats printing to XDP queues

2020-08-19 Thread sameehj
From: Sameeh Jubran Added statistics for TX queues that are used for XDP TX. The statistics are the same as the ones printed for regular non-XDP TX queues. The XDP queue statistics can be queried using `ethtool -S ` Signed-off-by: Shay Agroskin Signed-off-by: Sameeh Jubran --- drivers/net/et

[PATCH V2 net-next 1/4] net: ena: ethtool: use unsigned long for pointer arithmetics

2020-08-19 Thread sameehj
From: Sameeh Jubran unsigned long is the type for doing maths on pointers. Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/driver

[PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics

2020-08-19 Thread sameehj
From: Sameeh Jubran The new metrics provide granular visibility along multiple network dimensions and enable troubleshooting and remediation of issues caused by instances exceeding network performance allowances. The new statistics can be queried using ethtool command. Signed-off-by: Guy Tzalik

[PATCH V2 net-next 4/4] net: ena: xdp: add queue counters for xdp actions

2020-08-19 Thread sameehj
From: Sameeh Jubran When using XDP every ingress packet is passed to an eBPF (xdp) program which returns an action for this packet. This patch adds counters for the number of times each such action was received. It also counts all the invalid actions received from the eBPF program. Signed-off-b

[PATCH v3 4/7] ravb: Split delay handling in parsing and applying

2020-08-19 Thread Geert Uytterhoeven
Currently, full delay handling is done in both the probe and resume paths. Split it in two parts, so the resume path doesn't have to redo the parsing part over and over again. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov --- v3: - No changes, v2: - Add Reviewed-by, - Us

[PATCH V2 net-next 0/4] Enhance current features in ena driver

2020-08-19 Thread sameehj
From: Sameeh Jubran This series adds the following: * Exposes new device stats using ethtool. * Adds and exposes the stats of xdp TX queues through ethtool. V1: Use unsigned long for pointer math instead of uintptr_t Sameeh Jubran (4): net: ena: ethtool: use unsigned long for pointer arithmet

[PATCH v3 3/7] dt-bindings: net: renesas,etheravb: Convert to json-schema

2020-08-19 Thread Geert Uytterhoeven
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding documentation to json-schema. Add missing properties. Update the example to match reality. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring --- v3: - Add Reviewed-by, v2: - Add Rev

[PATCH v3 1/7] dt-bindings: net: ethernet-controller: Add internal delay properties

2020-08-19 Thread Geert Uytterhoeven
Internal Receive and Transmit Clock Delays are a common setting for RGMII capable devices. While these delays are typically applied by the PHY, some MACs support configuring internal clock delay settings, too. Hence add standardized properties to configure this. This is the MAC counterpart of co

[PATCH v3 5/7] ravb: Add support for explicit internal clock delay configuration

2020-08-19 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these delays based on the "rgmii-

[PATCH v3 2/7] dt-bindings: net: renesas,ravb: Document internal clock delay properties

2020-08-19 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Add properties for configuring the internal MAC delays. These properties are m

[PATCH v3 7/7] arm64: dts: renesas: rzg2: Convert EtherAVB to explicit delay handling

2020-08-19 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these delays based on the "rgmii-

[PATCH v3 0/7] net/ravb: Add support for explicit internal clock delay configuration

2020-08-19 Thread Geert Uytterhoeven
Hi all, Some Renesas EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these de

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 01:16:51PM +0200, Tomasz Figa wrote: > Hi Christoph, > > On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: > > > > The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, > > Could you explain what makes you think it's unused? It's a feature of > the UAPI gene

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 02:49:01PM +0200, Tomasz Figa wrote: > With the default config it doesn't, but with > CONFIG_DMA_NONCOHERENT_CACHE_SYNC enabled it makes dma_pgprot() keep > the pgprot value as is, without enforcing coherence attributes. Which isn't selected on arm64, and that is for a good

[PATCH net-next 0/2] crypto/chelsio: Restructure chelsio's inline crypto drivers

2020-08-19 Thread Vinay Kumar Yadav
This series of patches will move chelsio's inline crypto drivers (ipsec and chtls) from "drivers/crypto/chelsio/" to "drivers/net/ethernet/chelsio/inline_crypto/" for better maintenance. Patch1: moves out chtls. Patch2: moves out inline ipsec, applies on top of Patch1. Vinay Kumar Yadav (2): ch

[PATCH net-next 2/2] crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net

2020-08-19 Thread Vinay Kumar Yadav
This patch seperates inline ipsec functionality from coprocessor driver chcr. Now inline ipsec is separate ULD, moved from "drivers/crypto/chelsio/" to "drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/" Signed-off-by: Ayush Sawal Signed-off-by: Vinay Kumar Yadav --- drivers/crypto/chelsio/

[PATCH net-next 1/2] chelsio/chtls: separate chelsio tls driver from crypto driver

2020-08-19 Thread Vinay Kumar Yadav
chelsio inline tls driver(chtls) is mostly overlaps with NIC drivers but currenty it is part of crypto driver, so move it out to appropriate directory for better maintenance. Signed-off-by: Vinay Kumar Yadav --- MAINTAINERS | 9 ++ drivers/crypto/chelsio/Kconfi

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Robin Murphy
On 2020-08-19 13:49, Tomasz Figa wrote: On Wed, Aug 19, 2020 at 1:51 PM Robin Murphy wrote: Hi Tomasz, On 2020-08-19 12:16, Tomasz Figa wrote: Hi Christoph, On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, Could you e

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Tomasz Figa
On Wed, Aug 19, 2020 at 3:55 PM Christoph Hellwig wrote: > > On Wed, Aug 19, 2020 at 01:16:51PM +0200, Tomasz Figa wrote: > > Hi Christoph, > > > > On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: > > > > > > The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, > > > > Could you e

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Tomasz Figa
On Wed, Aug 19, 2020 at 3:57 PM Christoph Hellwig wrote: > > On Wed, Aug 19, 2020 at 02:49:01PM +0200, Tomasz Figa wrote: > > With the default config it doesn't, but with > > CONFIG_DMA_NONCOHERENT_CACHE_SYNC enabled it makes dma_pgprot() keep > > the pgprot value as is, without enforcing coherenc

Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics

2020-08-19 Thread Andrew Lunn
> + if (eni_stats_needed) { > + ena_update_hw_stats(adapter); > + for (i = 0; i < ENA_STATS_ARRAY_ENI(adapter); i++) { > + ena_stats = &ena_stats_eni_strings[i]; > + > + ptr = (u64 *)((unsigned long)&adapter->eni_stats + > +

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Moshe Shemesh
On 8/19/2020 3:46 PM, Jiri Pirko wrote: Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: On 8/19/2020 3:10 AM, Jakub Kicinski wrote: On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: On 8/17/2020 7:36 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mella

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Tomasz Figa
On Wed, Aug 19, 2020 at 4:07 PM Robin Murphy wrote: > > On 2020-08-19 13:49, Tomasz Figa wrote: > > On Wed, Aug 19, 2020 at 1:51 PM Robin Murphy wrote: > >> > >> Hi Tomasz, > >> > >> On 2020-08-19 12:16, Tomasz Figa wrote: > >>> Hi Christoph, > >>> > >>> On Wed, Aug 19, 2020 at 8:56 AM Christoph

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 12:56:05 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to expose the wideband speech packet length via > > a socket option to the user space so that the user space can set > > the value correctly

Re: [PATCH v1 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 13:07:25 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to define the HCI packet payload sizes of > > USB alternate settings so that they can be exposed to user > > space. > > > > Reviewed-by: Ala

Re: xdp generic default option

2020-08-19 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: > Hi Andrii, > > working on xdp multi-buff I figured out now xdp generic is the default choice > if not specified by userspace. In particular after commit 7f0a838254bd > ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device"), > running > the command below

[PATCH v2] net: sctp: Fix negotiation of the number of data streams.

2020-08-19 Thread David Laight
The number of output and input streams was never being reduced, eg when processing received INIT or INIT_ACK chunks. The effect is that DATA chunks can be sent with invalid stream ids and then discarded by the remote system. Fixes: 2075e50caf5ea ("sctp: convert to genradix") Signed-off-by: David

Re: ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 11:37:00AM +0100, Edward Cree wrote: > As far as I can tell, truncation to 32 bits is harmless ??? the > ??called function (efx_init_io) already tries every mask from the > ??passed one down to 32 bits in case of PCIe hardware limitations. Which btw isn't needed. These day

Re: [PATCH] staging: wilc1000: Fix memory leak in wilc_bus_probe

2020-08-19 Thread Greg Kroah-Hartman
On Wed, Aug 19, 2020 at 04:47:59PM +0200, Markus Elfring wrote: > > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > > should be freed just like when wilc_cfg80211_init() fails. > > How do you think about to choose an imperative wording for > a corresponding change description? > https://git.

Re: ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-19 Thread Randy Dunlap
On 8/19/20 3:37 AM, Edward Cree wrote: > On 19/08/2020 01:28, Randy Dunlap wrote: >> Hi, >> >> Does the drivers/net/ethernet/sfc/sfc driver require (expect) >> dma_addr_t to be 64 bits (as opposed to 32 bits)? >> >> I see that several #defines in ef100_regs.h are 64... >> >> When used with DMA_BIT_

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread James Bottomley
On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: [...] > > Since both threads seem to have petered out, let me suggest in > > kernel.h: > > > > #define cast_out(ptr, container, member) \ > > container_of(ptr, typeof(*container), member) > > > >

Re: WARNING in __cfg80211_connect_result

2020-08-19 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:e3ec1e8c net: eliminate meaningless memcpy to data in pskb.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1664ac8990 kernel config: https://syzkaller.appspot.com/x/.config?x=3d400a4

WARNING in rtnl_dellink

2020-08-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4ca0d9ac bonding: show saner speed for broadcast mode git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=13c2151690 kernel config: https://syzkaller.appspot.com/x/.config?x=9c89856ae5fc8b6 dashboard link:

Re: [PATCH 19/28] dma-mapping: replace DMA_ATTR_NON_CONSISTENT with dma_{alloc, free}_pages

2020-08-19 Thread Tomasz Figa
Hi Christoph, On Wed, Aug 19, 2020 at 8:57 AM Christoph Hellwig wrote: > > Add a new API to allocate and free pages that are guaranteed to be > addressable by a device, but otherwise behave like pages allocated by > alloc_pages. The intended APIs to sync them for use with the device > and cpu ar

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jiri Pirko
Wed, Aug 19, 2020 at 04:23:25PM CEST, mo...@nvidia.com wrote: > >On 8/19/2020 3:46 PM, Jiri Pirko wrote: >> Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: >> > On 8/19/2020 3:10 AM, Jakub Kicinski wrote: >> > > On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: >> > > > On 8/17/

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Sam Ravnborg
Hi Mauro. On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > This patch series port the out-of-tree driver for Hikey 970 (which > should also support Hikey 960) from the official 96boards tree: > >https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > Based on h

Re: [PATCH] cfg80211: switch from WARN() to pr_warn() in is_user_regdom_saved()

2020-08-19 Thread Rustam Kovhaev
On Wed, Aug 19, 2020 at 10:46:34AM +0200, Johannes Berg wrote: > On Tue, 2020-08-04 at 14:05 -0700, Rustam Kovhaev wrote: > > this warning can be triggered by userspace, so it should not cause a > > panic if panic_on_warn is set > > This is incorrect, it just addresses a particular symptom. I'll m

[PATCH net] net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() error flow

2020-08-19 Thread Alaa Hleihel
tcf_ct_handle_fragments() shouldn't free the skb when ip_defrag() call fails. Otherwise, we will cause a double-free bug. In such cases, just return the error to the caller. Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Signed-off-by: Alaa Hleihel Reviewed-by: Roi Dayan --- net/sched/a

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Laurent Pinchart
On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: > Hi Mauro. > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > > This patch series port the out-of-tree driver for Hikey 970 (which > > should also support Hikey 960) from the official 96boards tree: > > > >

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-19 Thread Yonghong Song
On 8/19/20 2:23 AM, Jiri Olsa wrote: The data of compressed section should be aligned to 4 (for 32bit) or 8 (for 64 bit) bytes. The binutils ld sets sh_addralign to 1, which makes libelf fail with misaligned section error during the update as reported by Jesper: FAILED elf_update(WRITE):

Re: Kernel build error on BTFIDS vmlinux

2020-08-19 Thread Nick Clifton
Hi Mark, > Adding Nick, the binutils maintainer, so we can make sure > binutils/elfutils agree on some ELF section compression corner case. Thanks for doing this. > But it would obviously be better if that wasn't necessary. So I'll try > to fix libelf so that if it fixes up the alignment when re

[PATCH net-next 1/3] net: phy: add interface mode PHY_INTERFACE_MODE_5GBASER.

2020-08-19 Thread Marek Behún
Add support for interface mode PHY_INTERFACE_MODE_5GBASER. Signed-off-by: Marek Behún --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea4..0214d70e12a69 100644 --- a/include/linux/phy.h +++ b/include/linux/p

[PATCH net-next 0/3] net: dsa: mv88e6xxx: Add Amethyst 88E6393X

2020-08-19 Thread Marek Behún
Hello, this adds support for one Marvell switch from the Amethyst family, 88E6393X. USXGMII mode is not supported, nor SERDES stats nor SERDES register dumps. Tested on Marvell CN9130 Customer Reference Board. Marek Marek Behún (3): net: phy: add interface mode PHY_INTERFACE_MODE_5GBASER.

[PATCH net-next 2/3] net: dsa: mv88e6xxx: return error instead of lane in .serdes_get_lane

2020-08-19 Thread Marek Behún
Currently the .serdes_get_lane method gets the lane as the result of the method, returning 0 if no SERDES is on given port. This was okay till now, because on no mv88e6xxx switch were it possible to have SERDES on port/lane 0. But it becomes incompatible with 88E6393X, on which the SERDES ports ar

Re: [PATCH v6 net-next 1/3] octeontx2-af: Support to enable/disable HW timestamping

2020-08-19 Thread Jesse Brandeburg
sundeep.l...@gmail.com wrote: > From: Zyta Szpak > > Four new mbox messages ids and handler are added in order to > enable or disable timestamping procedure on tx and rx side. > Additionally when PTP is enabled, the packet parser must skip > over 8 bytes and start analyzing packet data there. To

[PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family

2020-08-19 Thread Marek Behún
This adds support for 88E6393X, which differs from Peridot (6390 family) in that instead of XAUI and RXAUI it supports 5GBASE-R, 10GBASE-R and USXGMII modes and these modes are supported on ports 0, 9 and 10. The USXGMII is not supported yet, since I couldn't find information about the correspondi

Re: [PATCH bpf] libbpf: fix map index used in error message

2020-08-19 Thread Yonghong Song
On 8/19/20 4:05 AM, Toke Høiland-Jørgensen wrote: The error message emitted by bpf_object__init_user_btf_maps() was using the wrong section ID. Signed-off-by: Toke Høiland-Jørgensen Acked-by: Yonghong Song

Re: [PATCH V2 net 1/3] net: ena: Prevent reset after device destruction

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 12:04:41 +0300 Shay Agroskin wrote: > Fixes: 84a629e ("[New feature] ena_netdev: Add hibernation support") Fixes tag: Fixes: 84a629e ("[New feature] ena_netdev: Add hibernation support") Has these problem(s): - Target SHA1 does not exist Also hash needs to be 12 chara

Re: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 10:24:32 +0100 Lorenz Bauer wrote: > --- a/net/core/sock_map.c > +++ b/net/core/sock_map.c > @@ -559,10 +559,12 @@ static bool sock_map_sk_state_allowed(const struct sock > *sk) > return false; > } > > -static int sock_map_update_elem(struct bpf_map *map, void *key, >

Re: [PATCH RFC russell-king 0/4] Support for RollBall 10G copper SFP modules

2020-08-19 Thread Marek Behún
On Tue, 18 Aug 2020 17:34:15 +0100 Russell King - ARM Linux admin wrote: > On Tue, Aug 18, 2020 at 05:47:24PM +0200, Marek Behún wrote: > > On Tue, 18 Aug 2020 16:36:49 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Tue, Aug 18, 2020 at 05:30:55PM +0200, Marek Behún wrote: > >

RE: [net-next v3 1/4] devlink: check flash_update parameter support in net core

2020-08-19 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, August 18, 2020 8:46 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Jiri Pirko ; Jonathan Corbet > ; Michael Chan ; Bin Luo > ; Saeed Mahameed ; Leon > Romanovsky ; Ido Schimmel ; > Danielle Ratson > Subject: Re: [ne

Re: [PATCH RFC russell-king 0/4] Support for RollBall 10G copper SFP modules

2020-08-19 Thread Marek Behún
Btw if you want to check out the current status of my work, you can find it at https://gitlab.nic.cz/turris/mox-kernel/-/tree/sfp-2020-08-work the last patch is the one for marvell10g On Wed, 19 Aug 2020 17:49:50 +0200 Marek Behún wrote: > Russell, > > if you have time please rebase your work

Re: [PATCH v6 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor

2020-08-19 Thread Jesse Brandeburg
sundeep.l...@gmail.com wrote: > From: Aleksey Makarov > > This patch adds driver for Precision Time > Protocol Clock and Timestamping block found on > Octeontx2 platform. The driver does initial > configuration and exposes a function to adjust > PTP hardware clock. Please explain in the commit

RE: [net-next v3 3/4] devlink: introduce flash update overwrite mask

2020-08-19 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, August 18, 2020 8:55 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org > Subject: Re: [net-next v3 3/4] devlink: introduce flash update overwrite mask > > On Tue, 18 Aug 2020 17:28:17 -0700 Jacob Keller wrote: > > +The `

VLAN over HSR/PRP - Issue with rx_handler not called for VLAN hw acceleration

2020-08-19 Thread Murali Karicheri
All, I am working to add VLAN interface creation over HSR/PRP interface. It works fine after I fixed the HSR driver to allow creation of VLAN over it and with VLAN without hw acceleration. But with hw acceleration, the HSR hook is bypassed in net/core/dev.c as if (skb_vlan_tag_present(sk

Re: [RFC PATCH net-next 0/6] devlink: Add device metric support

2020-08-19 Thread Jakub Kicinski
On Tue, 18 Aug 2020 21:30:16 -0700 Florian Fainelli wrote: > >>> I spend way too much time patrolling ethtool -S outputs already. > >> > >> But that's the nature of detailed stats which are often essential to > >> ensuring the system is operating as expected or debugging some problem. > >> Common

Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-19 Thread Guenter Roeck
On Tue, Aug 18, 2020 at 06:14:39PM +0200, Sebastian Andrzej Siewior wrote: > Commit >8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") > > implemented a read callback with an udelay(1U). This fails to > compile on ARM because the delay is >1ms. I doubt that it is needed

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Allen
> [...] > > > Since both threads seem to have petered out, let me suggest in > > > kernel.h: > > > > > > #define cast_out(ptr, container, member) \ > > > container_of(ptr, typeof(*container), member) > > > > > > It does what you want, the argument order is the same as > > > container_of with th

Re: [PATCH v2 bpf-next 0/5] Add support for type-based and enum value-based CO-RE relocations

2020-08-19 Thread Yonghong Song
On 8/18/20 10:28 PM, Andrii Nakryiko wrote: This patch set adds libbpf support for two new classes of CO-RE relocations: type-based (TYPE_EXISTS/TYPE_SIZE/TYPE_ID_LOCAL/TYPE_ID_TARGET) and enum value-vased (ENUMVAL_EXISTS/ENUMVAL_VALUE): - TYPE_EXISTS allows to detect presence in kernel BTF

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote: I will add counters on which reload were done. reload_down()/up() can return which actions were actually done and devlink will show counters. >>> Why a counter? Just return what was done over netlink reply. >> >> Such counters

Re: [net-next v3 3/4] devlink: introduce flash update overwrite mask

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 16:01:02 + Keller, Jacob E wrote: > > > -#define DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT BIT(0) > > > +#define DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT BIT(0) > > > +#define DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK BIT(1) > > > > Since core will check sup

Re: [PATCH v2 bpf-next 2/5] selftests/bpf: test TYPE_EXISTS and TYPE_SIZE CO-RE relocations

2020-08-19 Thread Yonghong Song
On 8/18/20 10:28 PM, Andrii Nakryiko wrote: Add selftests for TYPE_EXISTS and TYPE_SIZE relocations, testing correctness of relocations and handling of type compatiblity/incompatibility. If __builtin_preserve_type_info() is not supported by compiler, skip tests. Signed-off-by: Andrii Nakryik

Re: [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac'

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 08:23:49 +0100 Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Function > parameter or member 'dac' not described in 'mt7601u_set_tx_dac' > drivers/net/wireless/mediatek/mt7601u/phy.c:1216: wa

Re: [PATCH v2 bpf-next 3/5] selftests/bpf: add CO-RE relo test for TYPE_ID_LOCAL/TYPE_ID_TARGET

2020-08-19 Thread Yonghong Song
On 8/18/20 10:28 PM, Andrii Nakryiko wrote: Add tests for BTF type ID relocations. To allow testing this, enhance core_relo.c test runner to allow dynamic initialization of test inputs. If __builtin_btf_type_id() is not supported by Clang, skip tests. Signed-off-by: Andrii Nakryiko --- ...

Re: [PATCH v2 bpf-next 5/5] selftests/bpf: add tests for ENUMVAL_EXISTS/ENUMVAL_VALUE relocations

2020-08-19 Thread Yonghong Song
On 8/18/20 10:28 PM, Andrii Nakryiko wrote: Add tests validating existence and value relocations for enum value-based relocations. If __builtin_preserve_enum_value() built-in is not supported, skip tests. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 56

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Jens Axboe
On 8/19/20 9:24 AM, Allen wrote: >> [...] Since both threads seem to have petered out, let me suggest in kernel.h: #define cast_out(ptr, container, member) \ container_of(ptr, typeof(*container), member) It does what you want, the argument order is the same as

Re: NETDEV WATCHDOG: WARNING: at net/sched/sch_generic.c:442 dev_watchdog

2020-08-19 Thread Steven Rostedt
On Wed, 19 Aug 2020 17:01:06 +0530 Naresh Kamboju wrote: > kernel warning noticed on x86_64 while running LTP tracing ftrace-stress-test > case. started noticing on the stable-rc linux-5.8.y branch. > > This device booted with KASAN config and DYNAMIC tracing configs and more. > This reported is

Re: [PATCH v6 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-08-19 Thread Jesse Brandeburg
sundeep.l...@gmail.com wrote: > From: Aleksey Makarov > > This patch adds PTP clock and uses it in Octeontx2 > network device. PTP clock uses mailbox calls to > access the hardware counter on the RVU side. > > Co-developed-by: Subbaraya Sundeep > Signed-off-by: Subbaraya Sundeep > Signed-off-

Re: [PATCH] bpf: Add bpf_skb_get_sock_comm() helper

2020-08-19 Thread Martin KaFai Lau
On Wed, Aug 19, 2020 at 02:10:56PM +0800, 江禹 wrote: > Dear Martin, > > > > One possibility is to use the "sk_bpf_storage" member immediately above > > instead of adding "sk_task_com[]". > > > > It is an extensible sk storage for bpf. There are examples in selftests, > > e.g tools/testing/selfte

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-19 Thread Jesper Dangaard Brouer
On Wed, 19 Aug 2020 11:23:42 +0200 Jiri Olsa wrote: > The data of compressed section should be aligned to 4 > (for 32bit) or 8 (for 64 bit) bytes. > > The binutils ld sets sh_addralign to 1, which makes libelf > fail with misaligned section error during the update as > reported by Jesper: > >

RE: [net-next v3 3/4] devlink: introduce flash update overwrite mask

2020-08-19 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Wednesday, August 19, 2020 9:31 AM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org > Subject: Re: [net-next v3 3/4] devlink: introduce flash update overwrite mask > > On Wed, 19 Aug 2020

Re: Kernel build error on BTFIDS vmlinux

2020-08-19 Thread Jiri Olsa
On Wed, Aug 19, 2020 at 04:34:30PM +0100, Nick Clifton wrote: > Hi Mark, > > > Adding Nick, the binutils maintainer, so we can make sure > > binutils/elfutils agree on some ELF section compression corner case. > > Thanks for doing this. > > > But it would obviously be better if that wasn't neces

Re: [RFC PATCH net-next 0/6] devlink: Add device metric support

2020-08-19 Thread Florian Fainelli
On 8/19/20 9:18 AM, Jakub Kicinski wrote: > On Tue, 18 Aug 2020 21:30:16 -0700 Florian Fainelli wrote: > I spend way too much time patrolling ethtool -S outputs already. But that's the nature of detailed stats which are often essential to ensuring the system is operating as exp

Re: [PATCH V2 net 1/3] net: ena: Prevent reset after device destruction

2020-08-19 Thread Shay Agroskin
Jakub Kicinski writes: On Wed, 19 Aug 2020 12:04:41 +0300 Shay Agroskin wrote: Fixes: 84a629e ("[New feature] ena_netdev: Add hibernation support") Fixes tag: Fixes: 84a629e ("[New feature] ena_netdev: Add hibernation support") Has these problem(s): - Target SHA1 does not exist

<    1   2   3   4   >