Re: Flaw in "random32: update the net random state on interrupt and activity"

On Thu, Aug 06, 2020 at 10:18:55AM -0700, Marc Plumb wrote: > Willy, > > > On 2020-08-05 11:30 p.m., Willy Tarreau wrote: > > On Wed, Aug 05, 2020 at 03:21:11PM -0700, Marc Plumb wrote: > > > There is nothing wrong with perturbing net_rand_state, the sin is doing it > > > with the raw entropy tha

WARNING: locking bug in l2cap_chan_del

Hello, syzbot found the following issue on: HEAD commit:47ec5303 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=111d93fa90 kernel config: https://syzkaller.appspot.com/x/.config?x=7bb894f55faf8242 das

INFO: trying to register non-static key in l2cap_chan_close

Hello, syzbot found the following issue on: HEAD commit:01830e6c Add linux-next specific files for 20200731 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=171e3dc690 kernel config: https://syzkaller.appspot.com/x/.config?x=2e226b2d1364112c dashboard

memory leak in hci_conn_add

Hello, syzbot found the following issue on: HEAD commit:47ec5303 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a0122c90 kernel config: https://syzkaller.appspot.com/x/.config?x=eab224ce244e423c das

Re: [PATCH net 1/2] ipv6: add ipv6_dev_find()

On Thu, Aug 6, 2020 at 10:03 PM David Ahern wrote: > > On 8/6/20 2:55 AM, Xin Long wrote: > > On Thu, Aug 6, 2020 at 10:50 AM Hideaki Yoshifuji > > wrote: > >> > >> Hi, > >> > >> 2020年8月4日(火) 0:35 Xin Long : > >>> > >>> This is to add an ip_dev_find like function for ipv6, used to find > >>> the

Re: [GIT] Networking

On Thu, Aug 06, 2020 at 11:23:34PM -0700, John Stultz wrote: > So I've finally rebase-bisected it down to: > a31edb2059ed ("net: improve the user pointer check in init_user_sockptr") > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a31edb2059ed4e498f9aa8230c734b59d0

Re: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

On Thu, Aug 06, 2020 at 03:21:25PM -0700, Eric Dumazet wrote: > converting get_user(...) to copy_from_sockptr(...) really assumed the > optlen > has been validated to be >= sizeof(int) earlier. > > Which is not always the case, for example here. Yes. And besides the bpfilter mess the main re

WARNING: refcount bug in l2tp_session_free

Hello, syzbot found the following issue on: HEAD commit:04300d66 Merge tag 'riscv-for-linus-5.8-rc7' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17beee2890 kernel config: https://syzkaller.appspot.com/x/.config?x=f3bc31881f1ae8a7 das

[PATCH net] r8152: Use MAC address from correct device tree node

From: Thierry Reding Query the USB device's device tree node when looking for a MAC address. The struct device embedded into the struct net_device does not have a device tree node attached at all. The reason why this went unnoticed is because the system where this was tested was one of the few d

RE: [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping

> -Original Message- > From: Richard Cochran > Sent: Monday, July 27, 2020 10:29 PM > To: Ooi, Joyce > Cc: Thor Thayer ; David S . Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Dalon Westergreen > ; Tan, Ley Foon > ; See, Chin Liang ; > Nguyen, Dinh ;

Re: rtnl_trylock() versus SCHED_FIFO lockup

On 07/08/2020 05.39, Stephen Hemminger wrote: > On Thu, 6 Aug 2020 12:46:43 +0300 > Nikolay Aleksandrov wrote: > >> On 06/08/2020 12:17, Rasmus Villemoes wrote: >>> On 06/08/2020 01.34, Stephen Hemminger wrote: On Wed, 5 Aug 2020 16:25:23 +0200 >> >> Hi Rasmus, >> I haven't tested anythin

RE: [PATCH net] r8152: Use MAC address from correct device tree node

EJ Hsu wrote: > From: Thierry Reding > > Query the USB device's device tree node when looking for a MAC address. > The struct device embedded into the struct net_device does not have a device > tree node attached at all. > > The reason why this went unnoticed is because the system where this wa

Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table

> 2020/08/06 1:38、David Ahern のメール: > > On 8/4/20 5:27 AM, Yoshiki Komachi wrote: >> >> I guess that no build errors will occur because the API is allowed when >> CONFIG_BRIDGE is enabled. >> >> I successfully build my kernel applying this patch, and I don’t receive any >> messages from build

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > kernel > > results in a EOPNOTSUPP message during sendmsg: > > > > setsockopt(3, SOL_TLS, TLS_TX, …, 40)

Re: [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup

> 2020/08/06 1:36、David Ahern のメール: > > On 8/5/20 4:26 AM, Yoshiki Komachi wrote: >>> >>> Just to clarify for myself. I expect that with just the helpers here >>> we should only expect static configurations to work, e.g. any learning >>> and/or aging is not likely to work if we do redirects in

Re: [PATCH v9 bpf-next 10/14] bpf: Add d_path helper

On Fri, Aug 07, 2020 at 02:31:52AM +0200, KP Singh wrote: > On Sat, Aug 1, 2020 at 7:04 PM Jiri Olsa wrote: > > > > Adding d_path helper function that returns full path for > > [...] > > > +} > > + > > +BTF_SET_START(btf_allowlist_d_path) > > +BTF_ID(func, vfs_truncate) > > +BTF_ID(func, vfs_fal

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

Hi! > this is v4 of my RFC adding support for LEDs connected to Marvell PHYs. > > Please note that if you want to test this, you still need to first apply > the patch adding the LED private triggers support from Pavel's tree. > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

On Sat 2020-07-25 20:48:46, Andrew Lunn wrote: > > > > +#if 0 > > > > + /* LED_COLOR_ID_MULTI is not yet merged in Linus' tree */ > > > > + /* TODO: Support DUAL MODE */ > > > > + if (color == LED_COLOR_ID_MULTI) { > > > > + phydev_warn(phydev, "node %pOF: This drive

RE: [PATCH 25/26] net: pass a sockptr_t into ->setsockopt

From: Eric Dumazet > Sent: 06 August 2020 23:21 > > On 7/22/20 11:09 PM, Christoph Hellwig wrote: > > Rework the remaining setsockopt code to pass a sockptr_t instead of a > > plain user pointer. This removes the last remaining set_fs(KERNEL_DS) > > outside of architecture specific code. > > > >

Re: [PATCH net 1/2] ipv6: add ipv6_dev_find()

Hi, 2020年8月6日(木) 23:03 David Ahern : > > On 8/6/20 2:55 AM, Xin Long wrote: > > On Thu, Aug 6, 2020 at 10:50 AM Hideaki Yoshifuji > > wrote: > >> > >> Hi, > >> > >> 2020年8月4日(火) 0:35 Xin Long : > >>> > >>> This is to add an ip_dev_find like function for ipv6, used to find > >>> the dev by saddr.

RE: [PATCH net-next v1] hinic: fix strncpy output truncated compile warnings

From: Luo bin > Sent: 07 August 2020 03:09 > > fix the compile warnings of 'strncpy' output truncated before > terminating nul copying N bytes from a string of the same length > > Signed-off-by: Luo bin > Reported-by: kernel test robot > --- > V0~V1: > - use the strlen()+1 pattern consistently

[PATCH net] selftests: mptcp: fix dependecies

Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests") the MPTCP selftests relies on the MPTCP diag interface which is enabled by a specific kconfig knob: be sure to include it. Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests") Signed-off-by: Paolo Abeni --- tool

Re: [PATCH net 0/4] support multipacket broadcast message

Hi Oleksij, We have tested this j1939 stack according to SAE J1939-21. It works fine for most cases, but when we test multipacket broadcast message function we found the receiver can't receive those packets. You can reproduce on CAN bus or vcan, for vcan case use cangw to connect vcan0 and vcan1:

Re: [PATCH v9 bpf-next 10/14] bpf: Add d_path helper

On Fri, Aug 7, 2020 at 10:35 AM Jiri Olsa wrote: > > On Fri, Aug 07, 2020 at 02:31:52AM +0200, KP Singh wrote: > > On Sat, Aug 1, 2020 at 7:04 PM Jiri Olsa wrote: > > > > > > Adding d_path helper function that returns full path for > > > > [...] > > > > > +} > > > + > > > +BTF_SET_START(btf_allow

[PATCH v10 bpf-next 01/14] tools resolve_btfids: Add size check to get_id function

To make sure we don't crash on malformed symbols. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- tools/bpf/resolve_btfids/main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c index 52d883325a

[PATCH v10 bpf-next 03/14] bpf: Move btf_resolve_size into __btf_resolve_size

Moving btf_resolve_size into __btf_resolve_size and keeping btf_resolve_size public with just first 3 arguments, because the rest of the arguments are not used by outside callers. Following changes are adding more arguments, which are not useful to outside callers. They will be added to the __btf_

[PATCH v10 bpf-next 06/14] bpf: Remove recursion call in btf_struct_access

Andrii suggested we can simply jump to again label instead of making recursion call. Suggested-by: Andrii Nakryiko Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/bpf/btf.c b/kernel/b

[PATCH v10 bpf-next 00/14] bpf: Add d_path helper

hi, adding d_path helper function that returns full path for given 'struct path' object, which needs to be the kernel BTF 'path' object. The path is returned in buffer provided 'buf' of size 'sz' and is zero terminated. long bpf_d_path(struct path *path, char *buf, u32 sz); The helper calls dir

[PATCH v10 bpf-next 12/14] selftests/bpf: Add verifier test for d_path helper

Adding verifier test for attaching tracing program and calling d_path helper from within and testing that it's allowed for dentry_open function and denied for 'd_path' function with appropriate error. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/test_verifi

[PATCH v10 bpf-next 05/14] bpf: Add type_id pointer as argument to __btf_resolve_size

Adding type_id pointer as argument to __btf_resolve_size to return also BTF ID of the resolved type. It will be used in following changes. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/ke

[PATCH v10 bpf-next 02/14] tools resolve_btfids: Add support for set symbols

The set symbol does not have the unique number suffix, so we need to give it a special parsing function. This was omitted in the first batch, because there was no set support yet, so it slipped in the testing. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- tools/bpf/resolve_btfids/main

[PATCH v10 bpf-next 08/14] bpf: Add btf_struct_ids_match function

Adding btf_struct_ids_match function to check if given address provided by BTF object + offset is also address of another nested BTF object. This allows to pass an argument to helper, which is defined via parent BTF object + offset, like for bpf_d_path (added in following changes): SEC("fentry/

[PATCH v10 bpf-next 11/14] bpf: Update .BTF_ids section in btf.rst with sets info

Updating btf.rst doc with info about BTF_SET_START/END macros. Signed-off-by: Jiri Olsa --- Documentation/bpf/btf.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst index b5361b8621c9..44dc789de2b4 100644 --- a

[PATCH v10 bpf-next 07/14] bpf: Factor btf_struct_access function

Adding btf_struct_walk function that walks through the struct type + given offset and returns following values: enum bpf_struct_walk_result { /* < 0 error */ WALK_SCALAR = 0, WALK_PTR, WALK_STRUCT, }; WALK_SCALAR - when SCALAR_VALUE is found WALK_PTR- when poin

[PATCH v10 bpf-next 14/14] selftests/bpf: Add set test to resolve_btfids

Adding test to for sets resolve_btfids. We're checking that testing set gets properly resolved and sorted. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/resolve_btfids.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a

[PATCH v10 bpf-next 09/14] bpf: Add BTF_SET_START/END macros

Adding support to define sorted set of BTF ID values. Following defines sorted set of BTF ID values: BTF_SET_START(btf_allowlist_d_path) BTF_ID(func, vfs_truncate) BTF_ID(func, vfs_fallocate) BTF_ID(func, dentry_open) BTF_ID(func, vfs_getattr) BTF_ID(func, filp_close) BTF_SET_END(bt

[PATCH v10 bpf-next 10/14] bpf: Add d_path helper

Adding d_path helper function that returns full path for given 'struct path' object, which needs to be the kernel BTF 'path' object. The path is returned in buffer provided 'buf' of size 'sz' and is zero terminated. bpf_d_path(&file->f_path, buf, size); The helper calls directly d_path function

[PATCH v10 bpf-next 13/14] selftests/bpf: Add test for d_path helper

Adding test for d_path helper which is pretty much copied from Wenbo Zhang's test for bpf_get_fd_path, which never made it in. The test is doing fstat/close on several fd types, and verifies we got the d_path helper working on kernel probes for vfs_getattr/filp_close functions. Original-patch-by:

Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

Al Viro wrote: >On Thu, Aug 06, 2020 at 12:59:16PM +0100, Al Viro wrote: >> On Thu, Aug 06, 2020 at 07:53:16PM +0800, linmiaohe wrote: >> > From: Miaohe Lin >> > >> > We should fput() file iff FDPUT_FPUT is set. So we should set >> > fput_needed accordingly. >> > >> > Fixes: 00e188ef6a7e ("soc

[PATCH v10 bpf-next 04/14] bpf: Add elem_id pointer as argument to __btf_resolve_size

If the resolved type is array, make btf_resolve_size return also ID of the elem type. It will be needed in following changes. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/btf.c b

Re: [MPTCP] [PATCH net] selftests: mptcp: fix dependecies

Hi Paolo, On 07/08/2020 11:32, Paolo Abeni wrote: Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests") the MPTCP selftests relies on the MPTCP diag interface which is enabled by a specific kconfig knob: be sure to include it. Good catch! Thank you for the patch! Reviewed-by

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

On 2020-07-10 8:04 a.m., Jamal Hadi Salim wrote: On 2020-07-09 8:19 a.m., Jiri Pirko wrote: Thu, Jul 09, 2020 at 01:00:26PM CEST, j...@mojatatu.com wrote: Main point is: classifying based on hash(and for that matter any other metadata like mark) is needed as a general utility for the system

[PATCH v1 4/5] can: j1939: transport: add j1939_session_skb_find_by_offset() function

Sometimes it makes no sense to search the skb by pkt.dpo, since we need next the skb within the transaction block. This may happen if we have an ETP session with CTS set to less than 255 packets. After this patch, we will be able to work with ETP sessions where the block size (ETP.CM_CTS byte 2) i

[PATCH v1 0/5] j1939 fixes

This patch set include different fixes reported by google syzkaller or other users. Oleksij Rempel (5): can: j1939: transport: j1939_simple_recv(): ignore local J1939 messages send not by J1939 stack can: j1939: transport: j1939_session_tx_dat(): fix use-after-free read in j1939_tp_txt

[PATCH v1 5/5] can: j1939: transport: j1939_xtp_rx_dat_one(): compare own packets to detect corruptions

Since the stack relays on receiving own packets, it was overwriting own transmit buffer from received packets. At least theoretically, the received echo buffer can be corrupt or changed and the session partner can request to resend previous data. In this case we will re-send bad data. With this p

Re: [PATCH v3 1/3] driver core: Revert default driver_deferred_probe_timeout value to 0

On Thu, Aug 06, 2020 at 07:09:16PM -0700, John Stultz wrote: > On Thu, Aug 6, 2020 at 6:52 AM Thierry Reding > wrote: > > > > On Wed, Apr 22, 2020 at 08:32:43PM +, John Stultz wrote: > > > This patch addresses a regression in 5.7-rc1+ > > > > > > In commit c8c43cee29f6 ("driver core: Fix > >

[PATCH v1 3/5] can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated

This patch adds check to ensure that the struct net_device::ml_priv is allocated, as it is used later by the j1939 stack. The allocation is done by all mainline CAN network drivers, but when using bond or team devices this is not the case. Bail out if no ml_priv is allocated. Reported-by: syzbot

[PATCH v1 1/5] can: j1939: transport: j1939_simple_recv(): ignore local J1939 messages send not by J1939 stack

In current J1939 stack implementation, we process all locally send messages as own messages. Even if it was send by CAN_RAW socket. To reproduce it use following commands: testj1939 -P -r can0:0x80 & cansend can0 18238040#0123 This step will trigger false positive not critical warning: j1939_simp

[PATCH v5 2/2] net: dsa: ocelot: Add support for QinQ Operation

From: "hongbo.wang" This feature can be test in the following case: Customer <-> swp0 <-> swp1 <-> ISP Customer will send and receive packets with single VLAN tag(CTAG), ISP will send and receive packets with double VLAN tag(STAG and CTAG). This refers to "4.3.3 Provider Bridges and

[PATCH v1 2/5] can: j1939: transport: j1939_session_tx_dat(): fix use-after-free read in j1939_tp_txtimer()

The current stack implementation do not support ECTS requests of not aligned TP sized blocks. If ECTS will request a block with size and offset spanning two TP blocks, this will cause memcpy() to read beyond the queued skb (which does only contain one TP sized block). Sometimes KASAN will detect

[PATCH v5 0/2] Add 802.1AD protocol support for dsa switch and ocelot driver

From: "hongbo.wang" 1. the patch 0001* is for setting single port into 802.1AD(QinQ) mode, before this patch, the function dsa_slave_vlan_rx_add_vid didn't pass the parameter "proto" to next port level, so switch's port can't get parameter "proto" after applying this patch, the following comma

[PATCH v5 1/2] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch port

From: "hongbo.wang" the following command will be supported: Set bridge's vlan protocol: ip link set br0 type bridge vlan_protocol 802.1ad Add VLAN: ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 Delete VLAN: ip link del link swp1 name swp1.100 Signed-off-by:

Re: [PATCH v5 1/2] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch port

On 07/08/2020 14:13, hongbo.w...@nxp.com wrote: > From: "hongbo.wang" > > the following command will be supported: > > Set bridge's vlan protocol: > ip link set br0 type bridge vlan_protocol 802.1ad > Add VLAN: > ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 > Del

[PATCH bpf] bpf: doc: remove references to warning message when using bpf_trace_printk()

The BPF helper bpf_trace_printk() no longer uses trace_printk(); it is now triggers a dedicated trace event. Hence the described warning is no longer present, so remove the discussion of it as it may confuse people. Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace

Re: [PATCH v3 1/3] driver core: Revert default driver_deferred_probe_timeout value to 0

On Fri, Aug 07, 2020 at 01:02:44PM +0200, Thierry Reding wrote: > On Thu, Aug 06, 2020 at 07:09:16PM -0700, John Stultz wrote: > > On Thu, Aug 6, 2020 at 6:52 AM Thierry Reding > > wrote: > > > > > > On Wed, Apr 22, 2020 at 08:32:43PM +, John Stultz wrote: > > > > This patch addresses a regre

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

On Fri, 2020-08-07 at 10:26 +0200, Rouven Czerwinski wrote: > On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > > kernel > > > results in a EOPNOTSUPP mes

Re: [PATCH 4.19] net/mlx5e: Don't support phys switch id if not in switchdev mode

On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote: > From: Roi Dayan > > Support for phys switch id ndo added for representors and if > we do not have representors there is no need to support it. > Since each port return different switch id supporting this > block support for creatin

Re: [PATCH net 0/4] support multipacket broadcast message

On Fri, Aug 07, 2020 at 05:36:38PM +0800, Zhang Changzhong wrote: > Hi Oleksij, > > We have tested this j1939 stack according to SAE J1939-21. It works fine for > most cases, but when we test multipacket broadcast message function we found > the receiver can't receive those packets. > > You can r

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

> > And no, I don't want phydev name there. > > Ummm. Can we get little more explanation on that? I fear that LED > device renaming will be tricky and phydev would work around that > nicely. Hi Pavel The phydev name is not particularly nice: !mdio-mux!mdio@1!switch@0!mdio:00 !mdio-mux!mdio@1!sw

Re: [PATCH net] net: qcom/emac: Fix missing clk_disable_unprepare() in error path of emac_probe

On 8/6/20 8:54 PM, wanghai (M) wrote: Thanks for your suggestion. May I fix it like this? Yes, this is what I had in mind. Thanks. Acked-by: Timur Tabi

[PATCH] Bluetooth: Delete both L2CAP connction and HCI channel when completing destroying logical link in AMP

When destroying a logical link (HCI_EV_DISCONN_LOGICAL_LINK_COMPLETE) in AMP, L2CAP connection (struct l2cap_conn) should be deleted together with HCI channel (struct hci_chan). Otherwise HCI channel will be deleted twice when unregistering a HCI device. `static void l2cap_conn_del(struct hci_conn

[PATCH v2 0/3] Add Support for Marvell OcteonTX2 Cryptographic

The following series adds support for Marvell Cryptographic Acceleration Unit(CPT) on OcteonTX2 CN96XX SoC. This series is tested with CRYPTO_EXTRA_TESTS enabled and CRYPTO_DISABLE_TESTS disabled. Changes since v1: * Moved Makefile changes from patch4 to patch2 and patch3. Srujana Challa (3):

[PATCH v2 1/3] octeontx2-af: add support to manage the CPT unit

The Admin function (AF) manages hardware resources on the cryptographic acceleration unit(CPT). This patch adds a mailbox interface for PFs and VFs to configure hardware resources for cryptography and inline-ipsec. Signed-off-by: Srujana Challa --- drivers/net/ethernet/marvell/octeontx2/af/Makef

[PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

Add support for the cryptographic acceleration unit (CPT) on OcteonTX2 CN96XX SoC. Signed-off-by: Srujana Challa --- drivers/crypto/marvell/Kconfig | 13 + drivers/crypto/marvell/Makefile|1 + drivers/crypto/marvell/octeontx2/Makefile |7

[PATCH v2 3/3] drivers: crypto: add the Virtual Function driver for OcteonTX2 CPT

Add support for the cryptographic accelerator unit virtual functions on OcteonTX2 96XX SoC. Signed-off-by: Srujana Challa --- drivers/crypto/marvell/Kconfig |4 + drivers/crypto/marvell/octeontx2/Makefile |5 +- .../crypto/marvell/octeontx2/otx2_cpt_hw_types.

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

2020-08-04, 14:32:56 +0200, Bram Yvakh wrote: > On 4/08/2020 11:37, Sabrina Dubroca wrote: > > xfrm interfaces currently test for !skb->ignore_df when deciding > > whether to update the pmtu on the skb's dst. Because of this, no pmtu > > exception is created when we do something like: > > > > p

Bei Interesse antworten.

Schöne Grüße, Mein Name ist MATTIAS SJOBORG, ich bin Schweizer Staatsbürger und (Vorsitzender des Vergütungs- und Nominierungsausschusses) von Tethys Petroleum, einem multinationalen Ölkonzern mit Sitz in London-England, Großbritannien. Ich bitte Sie um Ihre Hilfe, um die Summe von vierzig Mill

Re: rtnl_trylock() versus SCHED_FIFO lockup

On Fri, 7 Aug 2020 10:03:59 +0200 Rasmus Villemoes wrote: > On 07/08/2020 05.39, Stephen Hemminger wrote: > > On Thu, 6 Aug 2020 12:46:43 +0300 > > Nikolay Aleksandrov wrote: > > > >> On 06/08/2020 12:17, Rasmus Villemoes wrote: > >>> On 06/08/2020 01.34, Stephen Hemminger wrote: >

rcu build on bug

Made this small change: -- diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c index ec945294626a..75d43ed10cd8 100644 --- a/net/sched/cls_fw.c +++ b/net/sched/cls_fw.c @@ -22,7 +22,7 @@ #include #include -#define HTSIZE 256 +#define HTSIZE 4096 struct fw_head { u32

Re: [PATCH net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

On Thu, 6 Aug 2020 23:43:45 -0700 Ronak Doshi wrote: > 'Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support")' added support for encapsulation offload. However, while nit: no need for the quotes around commit xzy ("") > calculating tcp hdr length, it does not take into ac

Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

On Fri, 7 Aug 2020 19:39:19 +0530 Srujana Challa wrote: > Add support for the cryptographic acceleration unit (CPT) on > OcteonTX2 CN96XX SoC. Please address the W=1 C=1 build warnings ../drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c:475:51: warning: cast removes address space '__iomem' of

[ANNOUNCE] iproute2 5.8

Time for a new version of iproute2 to go with the 5.8 kernel. There are couple of administrative changes that long term downloaders will notice. First it that iproute2 is now maintained on the "main" branch. There are parallel copies (both updated) on kernel.org and github. If you use github, you

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

On 7/08/2020 16:47, Sabrina Dubroca wrote: > 2020-08-04, 14:32:56 +0200, Bram Yvakh wrote: > >> On 4/08/2020 11:37, Sabrina Dubroca wrote: >> >>> diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c >>> index b615729812e5..ade2eba863b3 100644 >>> --- a/net/xfrm/xfrm_interfac

Re: rcu build on bug

More clarification - this: --- diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c index ec945294626a..06510c8c8281 100644 --- a/net/sched/cls_fw.c +++ b/net/sched/cls_fw.c @@ -22,12 +22,12 @@ #include #include -#define HTSIZE 256 +#define HTSIZE 4096 struct fw_head { + struct rcu_h

[PATCH net 3/4] ptp: ptp_idt82p33: use do_aux_work for delay work

From: Min Li Instead of declaring its own delay_work, use ptp_clock provided do_aux_work to configure sync_tod. Signed-off-by: Min Li --- drivers/ptp/ptp_idt82p33.c | 24 drivers/ptp/ptp_idt82p33.h | 2 -- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git

[PATCH net 2/4] ptp: ptp_idt82p33: add more debug logs

From: Min Li Signed-off-by: Min Li --- drivers/ptp/ptp_idt82p33.c | 88 +- 1 file changed, 79 insertions(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index bd1fbcd..189bb81 100644 --- a/drivers/ptp/ptp_idt82

[PATCH net 4/4] ptp: ptp_idt82p33: support individually configure output by index

From: Min Li Enable/disable individual output by index instead of by output_mask Signed-off-by: Min Li --- drivers/ptp/ptp_idt82p33.c | 62 ++ drivers/ptp/ptp_idt82p33.h | 2 ++ 2 files changed, 48 insertions(+), 16 deletions(-) diff --git a/driver

[PATCH net 1/4] ptp: ptp_idt82p33: update to support adjphase

From: Min Li Add adjphase support for idt82p33xxx synchronization management unit. Also fix n_per_out to the actual number of outputs. Changes since v1: - Break into small changes Signed-off-by: Min Li --- drivers/ptp/ptp_idt82p33.c | 48 +- 1 file

[PATCH net] mptcp: more stable diag self-tests

During diag self-tests we introduce long wait in the mptcp test program to give the script enough time to access the sockets dump. Such wait is introduced after shutting down one sockets end. Since commit 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state machine") if both sides shutdown

Re: [PATCH v10 bpf-next 00/14] bpf: Add d_path helper

On Fri, Aug 07, 2020 at 11:45:45AM +0200, Jiri Olsa wrote: > hi, > adding d_path helper function that returns full path for > given 'struct path' object, which needs to be the kernel > BTF 'path' object. The path is returned in buffer provided > 'buf' of size 'sz' and is zero terminated. > > lon

BUG: corrupted list in kobject_add_internal

Hello, syzbot found the following issue on: HEAD commit:5a30a789 Merge tag 'x86-urgent-2020-08-02' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1660c85890 kernel config: https://syzkaller.appspot.com/x/.config?x=c0cfcf935bcc94d2 das

Bei Interesse antworten.

Schöne Grüße, Mein Name ist MATTIAS SJOBORG, ich bin Schweizer Staatsbürger und (Vorsitzender des Vergütungs- und Nominierungsausschusses) von Tethys Petroleum, einem multinationalen Ölkonzern mit Sitz in London-England, Großbritannien. Ich bitte Sie um Ihre Hilfe, um die Summe von vierzig Mill

Re: Flaw in "random32: update the net random state on interrupt and activity"

On 2020-08-07 12:03 a.m., Willy Tarreau wrote: Just to give a heads up on this, here's what I'm having pending regarding MSWS: struct rnd_state { uint64_t x, w; uint64_t seed; uint64_t noise; }; uint32_t msws32(struct rnd_state *state) { uint64_t

Re: [PATCH bpf] bpf: doc: remove references to warning message when using bpf_trace_printk()

On 8/7/20 1:50 PM, Alan Maguire wrote: The BPF helper bpf_trace_printk() no longer uses trace_printk(); it is now triggers a dedicated trace event. Hence the described warning is no longer present, so remove the discussion of it as it may confuse people. Fixes: ac5a72ea5c89 ("bpf: Use dedicated

Re: [PATCH bpf] selftests/bpf: fix silent Makefile output

On 8/7/20 5:30 AM, Andrii Nakryiko wrote: 99aacebecb75 ("selftests: do not use .ONESHELL") removed .ONESHELL, which changes how Makefile "silences" multi-command target recipes. selftests/bpf's Makefile relied (a somewhat unknowingly) on .ONESHELL behavior of silencing all commands within the rec

Re: [PATCH] kernel: bpf: delete repeated words in comments

On 8/7/20 5:31 AM, Randy Dunlap wrote: Drop repeated words in kernel/bpf/. {has, the} Signed-off-by: Randy Dunlap Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: netdev@vger.kernel.org Cc: b...@vger.kernel.org Applied, thanks!

[PATCH net] mptcp: fix warn at shutdown time for unaccepted msk sockets

With commit b93df08ccda3 ("mptcp: explicitly track the fully established status"), the status of unaccepted mptcp closed in mptcp_sock_destruct() changes from TCP_SYN_RECV to TCP_ESTABLISHED. As a result mptcp_sock_destruct() does not perform the proper cleanup and inet_sock_destruct() will later

Re: [PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting

On 2020-07-05 11:11, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:23 AM Richard Guy Briggs wrote: > > Require the target task to be a descendant of the container > > orchestrator/engine. > > > > You would only change the audit container ID from one set or inherited > > value to another if you wer

[PATCH bpf-next] bpf: fix segmentation fault of test_progs

test_progs reports the segmentation fault as below $ sudo ./test_progs -t mmap --verbose test_mmap:PASS:skel_open_and_load 0 nsec .. test_mmap:PASS:adv_mmap1 0 nsec test_mmap:PASS:adv_mmap2 0 nsec test_mmap:PASS:adv_mmap3 0 nsec test_mmap:PASS:adv_mmap4 0 nsec Segmentation fault This issue wa

Re: [PATCH v10 bpf-next 00/14] bpf: Add d_path helper

On Fri, Aug 07, 2020 at 09:35:03AM -0700, Alexei Starovoitov wrote: > On Fri, Aug 07, 2020 at 11:45:45AM +0200, Jiri Olsa wrote: > > hi, > > adding d_path helper function that returns full path for > > given 'struct path' object, which needs to be the kernel > > BTF 'path' object. The path is retur

[RFC] bpf: verifier check for dead branch

hi, we have a customer facing some odd verifier fails on following sk_skb program: 0. r2 = *(u32 *)(r1 + data_end) 1. r4 = *(u32 *)(r1 + data) 2. r3 = r4 3. r3 += 42 4. r1 = 0 5. if r3 > r2 goto 8 6. r4 += 14 7. r1 = r4 8. if r3 > r2 goto 10 9. r2 = *(u8 *)(r1 + 9)

Re: Flaw in "random32: update the net random state on interrupt and activity"

On Fri, Aug 07, 2020 at 09:52:14AM -0700, Marc Plumb wrote: > On 2020-08-07 12:03 a.m., Willy Tarreau wrote: > > > Just to give a heads up on this, here's what I'm having pending regarding > > MSWS: > > > >struct rnd_state { > > uint64_t x, w; > > uint64_t seed; > >

Re: [PATCH net] mptcp: fix warn at shutdown time for unaccepted msk sockets

Hi Paolo, On 07/08/2020 19:03, Paolo Abeni wrote: With commit b93df08ccda3 ("mptcp: explicitly track the fully established status"), the status of unaccepted mptcp closed in mptcp_sock_destruct() changes from TCP_SYN_RECV to TCP_ESTABLISHED. As a result mptcp_sock_destruct() does not perform th

RE: [PATCH][for v4.4 only] udp: drop corrupt packets earlier to avoid data corruption

> From: Dexuan Cui > Sent: Monday, July 27, 2020 6:55 PM > To: gre...@linuxfoundation.org; eduma...@google.com; > sta...@vger.kernel.org > Cc: w...@1wt.eu; Dexuan Cui ; Joseph Salisbury > ; Michael Kelley ; > v...@zeniv.linux.org.uk; netdev@vger.kernel.org; da...@davemloft.net; > oher...@suse.com

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

On Fri, 07 Aug 2020 14:27:48 +0200 Rouven Czerwinski wrote: > I just tested on my x86_64 workstation and these specific tests fail > there too, do they only work on 5.8? They were added in 5.8, but I am > running 5.7.11 here. It looks like these failures are not > MSG_CMSG_COMPAT related. > > Pooj

Re: Flaw in "random32: update the net random state on interrupt and activity"

Hi Andy, On Fri, Aug 07, 2020 at 10:55:11AM -0700, Andy Lutomirski wrote: > >> This is still another non-cryptographic PRNG. > > > > Absolutely. During some discussions regarding the possibility of using > > CSPRNGs, orders around hundreds of CPU cycles were mentioned for them, > > which can defi

Re: [PATCH 10/22] crypto: atmel-aes - add check for xts input length equal to zero

Hi Andrei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on crypto/master next-20200807] [cannot apply to powerpc/next sparc-next/master v5.8] [If your patch is applied to the wrong git tree, kindly drop us a note

Bei Interesse antworten.

Schöne Grüße, Mein Name ist MATTIAS SJOBORG, ich bin Schweizer Staatsbürger und (Vorsitzender des Vergütungs- und Nominierungsausschusses) von Tethys Petroleum, einem multinationalen Ölkonzern mit Sitz in London-England, Großbritannien. Ich bitte Sie um Ihre Hilfe, um die Summe von vierzig Mill

Re: Flaw in "random32: update the net random state on interrupt and activity"

On Fri, Aug 7, 2020 at 10:55 AM Andy Lutomirski wrote: > > I think the real random.c can run plenty fast. It’s ChaCha20 plus ludicrous > overhead right now. I doubt it. I tried something very much like that in user space to just see how many cycles it ended up being. I made a "just raw ChaCha2

Re: rcu build on bug

On Fri, Aug 7, 2020 at 8:16 AM Jamal Hadi Salim wrote: > > I am guessing the hash table got too large. > Smells like hard coded expectation? Yeah, that is literally how kfree_rcu() works. > > How to fix? I guess you just have to wrap up kfree() and pass it to call_rcu(). Thanks.

  1   2   >