Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Song Liu
> On Aug 4, 2020, at 10:47 PM, Andrii Nakryiko > wrote: > > On Tue, Aug 4, 2020 at 9:47 PM Song Liu wrote: >> >> >> >>> On Aug 4, 2020, at 6:52 PM, Andrii Nakryiko >>> wrote: >>> >>> On Tue, Aug 4, 2020 at 2:01 PM Song Liu wrote: > On Aug 2, 2020, at 10:10 PM, And

[PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread xiangxia . m . yue
From: Tonghao Zhang ovs_flow_tbl_destroy always is called from RCU callback or error path. It is no need to check if rcu_read_lock or lockdep_ovsl_is_held was held. ovs_dp_cmd_fill_info always is called with ovs_mutex, So use the rcu_dereference_ovsl instead of rcu_dereference in ovs_flow_tbl_ma

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-05 Thread Song Liu
> On Aug 4, 2020, at 11:54 PM, Andrii Nakryiko > wrote: > > On Tue, Aug 4, 2020 at 11:26 PM Song Liu wrote: >> >> >> >>> On Aug 4, 2020, at 10:32 PM, Andrii Nakryiko >>> wrote: >>> >>> On Tue, Aug 4, 2020 at 8:59 PM Song Liu wrote: > On Aug 4, 2020, at 6:38 PM, A

Re: general protection fault in hci_phy_link_complete_evt

2020-08-05 Thread syzbot
syzbot has bisected this issue to: commit b59abfbed638037f3b51eeb73266892cd2df177f Author: Johannes Berg Date: Thu Sep 15 13:30:03 2016 + mac80211_hwsim: statically initialize hwsim_radios list bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15dd5f9890 start commit:

Re: [PATCH V5 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

2020-08-05 Thread Jason Wang
On 2020/7/31 下午2:55, Zhu Lingshan wrote: +static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid) +{ + struct vhost_virtqueue *vq = &v->vqs[qid]; + const struct vdpa_config_ops *ops = v->vdpa->config; + struct vdpa_device *vdpa = v->vdpa; + int ret, irq; + +

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-05 Thread Willem de Bruijn
On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote: > > > > On 8/4/20 5:30 AM, Colin King wrote: > > From: Colin Ian King > > > > The current test will exit with a failure if it cannot set affinity on > > specific CPUs which is problematic when running this on single CPU > > systems. Add a check f

Re: The card speed limited to 100 Mb/s

2020-08-05 Thread Janusz S. Bień
On Wed, Aug 05 2020 at 8:16 +02, Heiner Kallweit wrote: > On 04.08.2020 18:17, Janusz S. Bień wrote: >> >> I apologize for a false alarm - the cable had to be replaced. >> > It wouldn't have been a question for the kernel community anyway > because it's about a out-of-tree vendor driver. > And t

Re: [PATCH V5 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

2020-08-05 Thread Zhu, Lingshan
On 8/5/2020 4:06 PM, Jason Wang wrote: On 2020/7/31 下午2:55, Zhu Lingshan wrote: +static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid) +{ +    struct vhost_virtqueue *vq = &v->vqs[qid]; +    const struct vdpa_config_ops *ops = v->vdpa->config; +    struct vdpa_device *vdpa = v->v

Packet not rerouting via different bridge interface after modifying destination IP in TC ingress hook

2020-08-05 Thread Swarm NameRedacted
Hi, I am trying to build a quick script via TC direct action and eBPF to modify the destination IP of a packet so that it is routed through a different bridge interface. Made a quick network diagram below to demonstrate it. Packet (dst: 10.10.3.2) | | in

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-05 Thread Moshe Shemesh
On 8/5/2020 9:55 AM, Vasundhara Volam wrote: On Wed, Aug 5, 2020 at 12:02 PM Moshe Shemesh wrote: On 8/4/2020 1:13 PM, Vasundhara Volam wrote: On Mon, Aug 3, 2020 at 7:23 PM Moshe Shemesh wrote: On 8/3/2020 3:47 PM, Vasundhara Volam wrote: On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wr

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-05 Thread Colin Ian King
On 05/08/2020 09:06, Willem de Bruijn wrote: > On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote: >> >> >> >> On 8/4/20 5:30 AM, Colin King wrote: >>> From: Colin Ian King >>> >>> The current test will exit with a failure if it cannot set affinity on >>> specific CPUs which is problematic when ru

Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-05 Thread Willem de Bruijn
On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote: > > The definition for symmetric keys does not include the flow label so > that when symmetric keys is used a non-zero IPv6 flow label is not > extracted. Symmetric keys are used in functions to compute the flow > hash for packets, and these functi

Re: The card speed limited to 100 Mb/s

2020-08-05 Thread Janusz S. Bień
On Wed, Aug 05 2020 at 10:08 +02, Janusz S. Bień wrote: > On Wed, Aug 05 2020 at 8:16 +02, Heiner Kallweit wrote: >> On 04.08.2020 18:17, Janusz S. Bień wrote: >>> >>> I apologize for a false alarm - the cable had to be replaced. >>> >> It wouldn't have been a question for the kernel community a

[PATCH net] selftests/net: relax cpu affinity requirement in msg_zerocopy test

2020-08-05 Thread Willem de Bruijn
From: Willem de Bruijn The msg_zerocopy test pins the sender and receiver threads to separate cores to reduce variance between runs. But it hardcodes the cores and skips core 0, so it fails on machines with the selected cores offline, or simply fewer cores. The test mainly gives code coverage i

Re: [PATCH net] Revert "vxlan: fix tos value before xmit"

2020-08-05 Thread Guillaume Nault
On Wed, Aug 05, 2020 at 10:41:31AM +0800, Hangbin Liu wrote: > This reverts commit 71130f29979c7c7956b040673e6b9d5643003176. > > In commit 71130f29979c ("vxlan: fix tos value before xmit") we want to > make sure the tos value are filtered by RT_TOS() based on RFC1349. > >0 1 2

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-05 Thread Willem de Bruijn
On Wed, Aug 5, 2020 at 10:22 AM Colin Ian King wrote: > > On 05/08/2020 09:06, Willem de Bruijn wrote: > > On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote: > >> > >> > >> > >> On 8/4/20 5:30 AM, Colin King wrote: > >>> From: Colin Ian King > >>> > >>> The current test will exit with a failure

[PATCH] rtw88: 8821c: Add RFE 2 support

2020-08-05 Thread Kai-Heng Feng
8821CE with RFE 2 isn't supported: [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information It works well if both type0 tables are in use, so add it

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-05 Thread Colin Ian King
On 05/08/2020 09:44, Willem de Bruijn wrote: > On Wed, Aug 5, 2020 at 10:22 AM Colin Ian King > wrote: >> >> On 05/08/2020 09:06, Willem de Bruijn wrote: >>> On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote: On 8/4/20 5:30 AM, Colin King wrote: > From: Colin Ian King >>

ACK: [PATCH net] selftests/net: relax cpu affinity requirement in msg_zerocopy test

2020-08-05 Thread Colin Ian King
On 05/08/2020 09:40, Willem de Bruijn wrote: > From: Willem de Bruijn > > The msg_zerocopy test pins the sender and receiver threads to separate > cores to reduce variance between runs. > > But it hardcodes the cores and skips core 0, so it fails on machines > with the selected cores offline, or

Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-08-05 Thread Xie He
On Tue, Aug 4, 2020 at 10:23 PM Martin Schiller wrote: > > > Adding skb_cow before these skb_push calls would indeed help > > preventing kernel panics, but that might not be the essential issue > > here, and it might also prevent us from discovering the real issue. (I > > guess this is also the re

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread Paolo Abeni
On Wed, 2020-08-05 at 15:19 +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_mut

Re: [PATCH net] mptcp: be careful on subflow creation

2020-08-05 Thread Paolo Abeni
On Tue, 2020-08-04 at 21:25 +0200, Matthieu Baerts wrote: > Hi Paolo, > > On 04/08/2020 18:31, Paolo Abeni wrote: > > Nicolas reported the following oops: > > (...) > > > on some unconventional configuration. > > > > The MPTCP protocol is trying to create a subflow for an > > unaccepted server

Re: [PATCH net] mptcp: be careful on subflow creation

2020-08-05 Thread Matthieu Baerts
Hi Paolo, On 05/08/2020 11:10, Paolo Abeni wrote: On Tue, 2020-08-04 at 21:25 +0200, Matthieu Baerts wrote: Hi Paolo, On 04/08/2020 18:31, Paolo Abeni wrote: Nicolas reported the following oops: (...) on some unconventional configuration. The MPTCP protocol is trying to create a subflow

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-05 Thread Kurt Kanzenbach
On Wed Aug 05 2020, Russell King - ARM Linux admin wrote: > On Wed, Aug 05, 2020 at 01:04:31AM +0300, Grygorii Strashko wrote: >> On 05/08/2020 00:44, Russell King - ARM Linux admin wrote: >> > On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko wrote: >> > > On 05/08/2020 00:07, Russell Ki

Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-08-05 Thread Willem de Bruijn
On Wed, Aug 5, 2020 at 10:57 AM Xie He wrote: > > On Tue, Aug 4, 2020 at 10:23 PM Martin Schiller wrote: > > > > > Adding skb_cow before these skb_push calls would indeed help > > > preventing kernel panics, but that might not be the essential issue > > > here, and it might also prevent us from d

Re: [PATCH net] Revert "vxlan: fix tos value before xmit"

2020-08-05 Thread Hangbin Liu
On Wed, Aug 05, 2020 at 10:44:27AM +0200, Guillaume Nault wrote: > On Wed, Aug 05, 2020 at 10:41:31AM +0800, Hangbin Liu wrote: > > This reverts commit 71130f29979c7c7956b040673e6b9d5643003176. > > > > In commit 71130f29979c ("vxlan: fix tos value before xmit") we want to > > make sure the tos val

Re: [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup

2020-08-05 Thread Yoshiki Komachi
Thanks for giving me a lot of comments! Find my response below, please. > 2020/08/01 6:52、John Fastabend のメール: > > Yoshiki Komachi wrote: >> This series adds a new bpf helper for doing FDB lookup in the kernel >> tables from XDP programs. This helps users to accelerate Linux bridge >> with XDP. >

Re: [PATCH net 2/2] tipc: set ub->ifindex for local ipv6 address

2020-08-05 Thread Ying Xue
On 8/3/20 11:34 PM, Xin Long wrote: > Without ub->ifindex set for ipv6 address in tipc_udp_enable(), > ipv6_sock_mc_join() may make the wrong dev join the multicast > address in enable_mcast(). This causes that tipc links would > never be created. > > So fix it by getting the right netdev and sett

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-05 Thread Neil Horman
On Tue, Aug 04, 2020 at 04:14:14PM -0700, David Miller wrote: > From: izabela.bakoll...@gmail.com > Date: Tue, 4 Aug 2020 18:09:08 +0200 > > > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > > return -EOPNOTSUPP; > > } > > > > +static int net_dm_interface_start(st

Re: [PATCH net 1/2] ipv6: add ipv6_dev_find()

2020-08-05 Thread Ying Xue
On 8/3/20 11:34 PM, Xin Long wrote: > This is to add an ip_dev_find like function for ipv6, used to find > the dev by saddr. > > It will be used by TIPC protocol. So also export it. > > Signed-off-by: Xin Long Acked-by: Ying Xue > --- > include/net/addrconf.h | 2 ++ > net/ipv6/addrconf.c

Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-08-05 Thread Ilia Lin
My comments inline. Thanks, Ilia Lin On Tue, Aug 4, 2020 at 10:24 PM Andrew Lunn wrote: > > On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote: > > Hi Andrew and David, > > Hi Ilia > > Please don't top post. > > > > > Thank you for your comments! > > > > The client driver is still work in

RE: [PATCH] rtw88: 8821c: Add RFE 2 support

2020-08-05 Thread Tony Chuang
> 8821CE with RFE 2 isn't supported: > [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info > [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information > NACK The RFE type 2 should be working with s

RE: [PATCH v3 net-next] ptp: only allow phase values lower than 1 period

2020-08-05 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran > Sent: Tuesday, August 04, 2020 7:06 PM > To: Vladimir Oltean > Cc: k...@kernel.org; da...@davemloft.net; netdev@vger.kernel.org; Keller, > Jacob E > Subject: Re: [PATCH v3 net-next] ptp: only allow phase values lower than 1 > period > >

[PATCH net-next] ip_tunnel_core: Fix build for archs without _HAVE_ARCH_IPV6_CSUM

2020-08-05 Thread Stefano Brivio
On architectures defining _HAVE_ARCH_IPV6_CSUM, we get csum_ipv6_magic() defined by means of arch checksum.h headers. On other architectures, we actually need to include net/ip6_checksum.h to be able to use it. Without this include, building with defconfig breaks at least for s390. Reported-by: S

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-05 Thread tytso
On Wed, Aug 05, 2020 at 04:49:41AM +0200, Willy Tarreau wrote: > > Not only was this obviously not the goal, but I'd be particularly > interested in seeing this reality demonstrated, considering that > the whole 128 bits of fast_pool together count as a single bit of > entropy, and that as such, e

BUG: unable to handle kernel paging request in lock_sock_nested

2020-08-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ac3a0c84 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=141a4c1a90 kernel config: https://syzkaller.appspot.com/x/.config?x=c0cfcf935bcc94d2 dashboar

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-05 Thread Jason A. Donenfeld
On Wed, Aug 5, 2020 at 6:07 PM wrote: > That being said, it certainly is a certificational / theoretical > weakness random.c is filled with super suspicious things that are probably only correct by accident, or only correct in practice, but in theory it's just such a mess. Stupid example if I'm r

Re: [PATCH 2/2] vhost_vdpa: unified set_vq_irq() and update_vq_irq()

2020-08-05 Thread Michael S. Tsirkin
On Wed, Aug 05, 2020 at 07:38:32PM +0800, Zhu Lingshan wrote: > This commit merge vhost_vdpa_update_vq_irq() logics into > vhost_vdpa_setup_vq_irq(), so that code are unified. > > In vhost_vdpa_setup_vq_irq(), added checks for the existence > for get_vq_irq(). > > Signed-off-by: Zhu Lingshan wh

Re: linux-next: build failure after merge of the net-next tree

2020-08-05 Thread Stefano Brivio
On Wed, 5 Aug 2020 22:31:21 +1000 Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (s390 defconfig) > failed like this: > > net/ipv4/ip_tunnel_core.c:335:2: error: implicit declaration of function > 'csum_ipv6_magic' [-Werror=implicit-function-dec

[PATCH 3/3] usb: hso: remove bogus check for EINPROGRESS

2020-08-05 Thread Oliver Neukum
This check an inherent race. It opens a race where an error code has already been set or cleared yet the URB has not been given back. We cannot do such an optimization and must unlink unconditionally. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 3 +-- 1 file changed, 1 insertion(+),

[PATCH 0/3] misc bug fixes for the hso driver

2020-08-05 Thread Oliver Neukum
1. Code reuse led to an unregistration of a net driver that has not been registered 2. The kernel complains generically if kmalloc with GFP_KERNEL fails 3. A race that can lead to an URB that is in use being reused or a use after free

[PATCH 2/3] usb: hso: no complaint about kmalloc failure

2020-08-05 Thread Oliver Neukum
If this fails, kmalloc() will print a report including a stack trace. There is no need for a separate complaint. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 031

Re: ethtool-5.8: test-driver uses bashisms

2020-08-05 Thread Michal Kubecek
On Wed, Aug 05, 2020 at 08:46:06AM +0200, Lars Wendler wrote: > Hi Michal, > > I hope you are the right person to reach out for this matter. > > Running the test-driver script from ethtool-5.8 release with /bin/dash > results in an endless loop that constantly emits the following two > lines: >

linux-next: build failure after merge of the net-next tree

2020-08-05 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (s390 defconfig) failed like this: net/ipv4/ip_tunnel_core.c:335:2: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration] Caused by commit 4cb47a8644cc ("tunnels: PMTU discovery supp

[PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-05 Thread Rouven Czerwinski
If compat_{s,g}etsockopt for TLS are not implemented, the TLS layer will never be called on a system where CONFIG_COMPAT is enabled and userspace is 32bit. Implement both to support CONFIG_COMPAT. Signed-off-by: Rouven Czerwinski --- net/tls/tls_main.c | 28 1 file c

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-05 Thread Willy Tarreau
Hi Ted, On Wed, Aug 05, 2020 at 11:34:32AM -0400, ty...@mit.edu wrote: > That being said, it certainly is a certificational / theoretical > weakness, and if the bright boys and girls at Fort Meade did figure > out a way to exploit this, they are very much unlikely to share it at > an open Crypto c

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-05 Thread Richard Cochran
On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote: > So, skb->data pints on Eth header, but skb_mac_header() return garbage. This triggers an ancient memory in my head. Now I vaguely recall that there was a reason I made different parsing routines. :( Still I think it would be g

[PATCH 2/2] vhost_vdpa: unified set_vq_irq() and update_vq_irq()

2020-08-05 Thread Zhu Lingshan
This commit merge vhost_vdpa_update_vq_irq() logics into vhost_vdpa_setup_vq_irq(), so that code are unified. In vhost_vdpa_setup_vq_irq(), added checks for the existence for get_vq_irq(). Signed-off-by: Zhu Lingshan --- drivers/vhost/vdpa.c | 28 ++-- 1 file changed, 6

Re: [External] Re: [PATCH v2] kprobes: fix NULL pointer dereference at kprobe_ftrace_handler

2020-08-05 Thread Muchun Song
On Thu, Aug 6, 2020 at 12:51 AM Steven Rostedt wrote: > > On Thu, 6 Aug 2020 00:27:13 +0800 > Muchun Song wrote: > > > We found a case of kernel panic on our server. The stack trace is as > > follows(omit some irrelevant information): > > > > BUG: kernel NULL pointer dereference, address:

[PATCH RESEND net-next] ip_tunnel_core: Fix build for archs without _HAVE_ARCH_IPV6_CSUM

2020-08-05 Thread Stefano Brivio
On architectures defining _HAVE_ARCH_IPV6_CSUM, we get csum_ipv6_magic() defined by means of arch checksum.h headers. On other architectures, we actually need to include net/ip6_checksum.h to be able to use it. Without this include, building with defconfig breaks at least for s390. Reported-by: S

[PATCH] virtio_net: use LE accessors for speed/duplex

2020-08-05 Thread Michael S. Tsirkin
Speed and duplex config fields depend on VIRTIO_NET_F_SPEED_DUPLEX which being 63>31 depends on VIRTIO_F_VERSION_1. Accordingly, use LE accessors for these fields. Reported-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c| 9 + include/uapi/linux

[PATCH] kprobes: fix compiler warning for !CONFIG_KPROBES_ON_FTRACE

2020-08-05 Thread Muchun Song
Fix compiler warning(as show below) for !CONFIG_KPROBES_ON_FTRACE. kernel/kprobes.c: In function 'kill_kprobe': kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value] 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV) | ^ kernel/kprobes.c:

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Alexei Starovoitov
On Wed, Aug 05, 2020 at 04:47:30AM +, Song Liu wrote: > > Being able to trigger BPF program on a different CPU could enable many > use cases and optimizations. The use case I am looking at is to access > perf_event and percpu maps on the target CPU. For example: > 0. trigger the program

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Andrii Nakryiko
On Wed, Aug 5, 2020 at 10:16 AM Alexei Starovoitov wrote: > > On Wed, Aug 05, 2020 at 04:47:30AM +, Song Liu wrote: > > > > Being able to trigger BPF program on a different CPU could enable many > > use cases and optimizations. The use case I am looking at is to access > > perf_event and percp

KMSAN: uninit-value in do_xdp_generic

2020-08-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:93f54a72 instrumented.h: fix KMSAN support git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=16fa519890 kernel config: https://syzkaller.appspot.com/x/.config?x=fa4f

Re: [PATCH v9 bpf-next 06/14] bpf: Remove recursion call in btf_struct_access

2020-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2020 at 11:12:49PM -0700, Andrii Nakryiko wrote: > On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > > > Andrii suggested we can simply jump to again label > > instead of making recursion call. > > > > Suggested-by: Andrii Nakryiko > > Signed-off-by: Jiri Olsa > > --- > > ker

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Andrii Nakryiko
On Wed, Aug 5, 2020 at 12:01 AM Song Liu wrote: > > > > > On Aug 4, 2020, at 10:47 PM, Andrii Nakryiko > > wrote: > > > > On Tue, Aug 4, 2020 at 9:47 PM Song Liu wrote: > >> > >> > >> > >>> On Aug 4, 2020, at 6:52 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Tue, Aug 4, 2020 at 2:01 PM Son

Re: INFO: trying to register non-static key in l2cap_chan_del

2020-08-05 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:4c900a6b farsync: switch from 'pci_' to 'dma_' API git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1561801a90 kernel config: https://syzkaller.appspot.com/x/.config?x=91a13b78c7dc258d

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Linus Torvalds
On Wed, Aug 5, 2020 at 7:34 AM Russell King wrote: > > Is this something you're willing to merge directly please? Done. That said: > -K: phylink > +K: > phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|se

Re: [PATCH v3 38/38] virtio_net: use LE accessors for speed/duplex

2020-08-05 Thread Cornelia Huck
On Wed, 5 Aug 2020 09:45:00 -0400 "Michael S. Tsirkin" wrote: > Speed and duplex config fields depend on VIRTIO_NET_F_SPEED_DUPLEX > which being 63>31 depends on VIRTIO_F_VERSION_1. > > Accordingly, use LE accessors for these fields. > > Reported-by: Cornelia Huck > Signed-off-by: Michael S. T

[PATCH net-next] net: thunderx: initialize VF's mailbox mutex before first usage

2020-08-05 Thread Dean Nelson
A VF's mailbox mutex is not getting initialized by nicvf_probe() until after it is first used. And such usage is resulting in... [ 28.270927] [ cut here ] [ 28.270934] DEBUG_LOCKS_WARN_ON(lock->magic != lock) [ 28.270980] WARNING: CPU: 9 PID: 675 at kernel/locking/mut

[Linux-kernel-mentees] [PATCH net] Bluetooth: Fix slab-out-of-bounds read in hci_le_direct_adv_report_evt()

2020-08-05 Thread Peilin Ye
`num_reports` is not being properly checked. A malformed event packet with a large `num_reports` number makes hci_le_direct_adv_report_evt() read out of bounds. Fix it. Reported-and-tested-by: syzbot+24ebd650e20bd263c...@syzkaller.appspotmail.com Fixes: 2f010b55884e ("Bluetooth: Add support for ha

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > On Wed, Aug 5, 2020 at 7:34 AM Russell King > wrote: > > > > Is this something you're willing to merge directly please? > > Done. > > That said: > > > -K: phylink > > +K: > > phylink\.h|struct\s+phylink|\.phylink|>phyli

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Song Liu
> On Aug 5, 2020, at 10:16 AM, Alexei Starovoitov > wrote: > > On Wed, Aug 05, 2020 at 04:47:30AM +, Song Liu wrote: >> >> Being able to trigger BPF program on a different CPU could enable many >> use cases and optimizations. The use case I am looking at is to access >> perf_event and pe

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Joe Perches
On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > On Wed, Aug 5, 2020 at 7:34 AM Russell King > > wrote: > > > Is this something you're willing to merge directly please? > > > > Done. > > > > That said:

Re: [PATCH v3 net-next] ptp: only allow phase values lower than 1 period

2020-08-05 Thread David Miller
From: Vladimir Oltean Date: Wed, 5 Aug 2020 03:10:47 +0300 > The way we define the phase (the difference between the time of the > signal's rising edge, and the closest integer multiple of the period), > it doesn't make sense to have a phase value equal or larger than 1 > period. > > So deny th

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Joe Perches
On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > On Wed, Aug 5, 2020 at 7:34 AM Russell King > > wrote: > > > Is this something you're willing to merge directly please? > > > > Done. > > > > That said:

Re: Question about TC filter

2020-08-05 Thread satish dhote
Hi Jakub, Thanks for your response. Below are the OS and Kernel version I'm using. OS: Ubuntu 20.04.1 LTS Kernel Version: 5.4.0-42-generic Thanks Satish On Wed, Aug 5, 2020 at 10:15 PM Jakub Kicinski wrote: > > On Wed, 5 Aug 2020 11:08:08 +0530 satish dhote wrote: > > Hi Team, > > > > I have a

Re: [PATCH v3 6/9] ethernet: ti: cpts: Use generic helper function

2020-08-05 Thread Grygorii Strashko
On 02/08/2020 23:22, Florian Fainelli wrote: On 7/30/2020 1:00 AM, Kurt Kanzenbach wrote: In order to reduce code duplication between ptp drivers, generic helper functions were introduced. Use them. Signed-off-by: Kurt Kanzenbach --- [snip] - if (unlikely(ptp_class & PTP_CLASS_V1)

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-08-05 Thread Boris Ostrovsky
On 8/4/20 7:42 PM, Anchal Agarwal wrote: > > I think this could be done. PM_HIBERNATION_PREPARE could return -ENOTSUPP > for arm and pvh dom0 when the notifier call chain is invoked for this case > in hibernate(). This will then be an empty notifier just for checking two > usecases. > Also, for pvh

Re: [PATCH net] Revert "vxlan: fix tos value before xmit"

2020-08-05 Thread David Miller
From: Hangbin Liu Date: Wed, 5 Aug 2020 18:18:07 +0800 > Should I re-post the patch with Fixes flag? No, I took care the Fixes tag and queued this up for -stable. But you do need to explain what kind of testing you even did on this change we are reverting. Did you make this change purely on th

Re: [PATCH v9 bpf-next 13/14] selftests/bpf: Add test for d_path helper

2020-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2020 at 11:40:05PM -0700, Andrii Nakryiko wrote: SNIP > > +SEC("fentry/vfs_getattr") > > +int BPF_PROG(prog_stat, struct path *path, struct kstat *stat, > > +__u32 request_mask, unsigned int query_flags) > > +{ > > + pid_t pid = bpf_get_current_pid_tgid() >> 32;

Re: [PATCH] rtw88: 8821c: Add RFE 2 support

2020-08-05 Thread Kai-Heng Feng
Hi Tony, > On Aug 5, 2020, at 19:18, Tony Chuang wrote: > >> 8821CE with RFE 2 isn't supported: >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info >> [ 12.404939] rtw_8821ce :02:00.0: failed to setup c

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-05 Thread Grygorii Strashko
On 05/08/2020 16:57, Kurt Kanzenbach wrote: On Wed Aug 05 2020, Grygorii Strashko wrote: I really do not want touch netcp, sry. There are other internal code based on this even if there is only one hooks in LKML now. + my comment above. OK, I see. The use of lists makes more sense now.

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread David Miller
From: xiangxia.m@gmail.com Date: Wed, 5 Aug 2020 15:19:11 +0800 > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_

Re: [PATCH v9 bpf-next 08/14] bpf: Add btf_struct_ids_match function

2020-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2020 at 11:27:55PM -0700, Andrii Nakryiko wrote: SNIP > > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c > > index 7bacc2f56061..ba05b15ad599 100644 > > --- a/kernel/bpf/btf.c > > +++ b/kernel/bpf/btf.c > > @@ -4160,6 +4160,37 @@ int btf_struct_access(struct bpf_verifier_log *lo

Re: [PATCH v9 bpf-next 10/14] bpf: Add d_path helper

2020-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2020 at 11:35:53PM -0700, Andrii Nakryiko wrote: > On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > > > Adding d_path helper function that returns full path for > > given 'struct path' object, which needs to be the kernel > > BTF 'path' object. The path is returned in buffer pr

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Andrii Nakryiko
On Wed, Aug 5, 2020 at 10:45 AM Alexei Starovoitov wrote: > > On Wed, Aug 05, 2020 at 10:27:28AM -0700, Andrii Nakryiko wrote: > > On Wed, Aug 5, 2020 at 10:16 AM Alexei Starovoitov > > wrote: > > > > > > On Wed, Aug 05, 2020 at 04:47:30AM +, Song Liu wrote: > > > > > > > > Being able to trig

Re: [PATCH net 0/2] net: fix a mcast issue for tipc udp media

2020-08-05 Thread David Miller
From: Xin Long Date: Mon, 3 Aug 2020 23:34:45 +0800 > Patch 1 is to add a function to get the dev by source address, > whcih will be used by Patch 2. Series applied, thank you.

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-05 Thread Alexei Starovoitov
On Wed, Aug 05, 2020 at 10:27:28AM -0700, Andrii Nakryiko wrote: > On Wed, Aug 5, 2020 at 10:16 AM Alexei Starovoitov > wrote: > > > > On Wed, Aug 05, 2020 at 04:47:30AM +, Song Liu wrote: > > > > > > Being able to trigger BPF program on a different CPU could enable many > > > use cases and op

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-05 Thread Andrii Nakryiko
On Wed, Aug 5, 2020 at 12:23 AM Song Liu wrote: > > > > > On Aug 4, 2020, at 11:54 PM, Andrii Nakryiko > > wrote: > > > > On Tue, Aug 4, 2020 at 11:26 PM Song Liu wrote: > >> > >> > >> > >>> On Aug 4, 2020, at 10:32 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Tue, Aug 4, 2020 at 8:59 PM S

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-08-05 Thread Anchal Agarwal
On Wed, Aug 05, 2020 at 09:31:13AM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 8/4/20 7:42 PM, Anchal Agarwal wrote: > > >

Re: [PATCH net-next] ip_vti: Fix unused variable warning

2020-08-05 Thread David Miller
From: Steffen Klassert Date: Tue, 4 Aug 2020 07:53:10 +0200 > On Mon, Aug 03, 2020 at 03:13:49PM -0700, David Miller wrote: >> From: YueHaibing >> Date: Fri, 31 Jul 2020 14:49:52 +0800 >> >> > If CONFIG_INET_XFRM_TUNNEL is set but CONFIG_IPV6 is n, >> > >> > net/ipv4/ip_vti.c:493:27: warning:

Re: [PATCH net-next] net: dsa: sja1105: use detected device id instead of DT one on mismatch

2020-08-05 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 19:48:23 +0300 > Although we can detect the chip revision 100% at runtime, it is useful > to specify it in the device tree compatible string too, because > otherwise there would be no way to assess the correctness of device tree > bindings statically,

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread Eelco Chaudron
On 5 Aug 2020, at 9:19, xiangxia.m@gmail.com wrote: From: Tonghao Zhang ovs_flow_tbl_destroy always is called from RCU callback or error path. It is no need to check if rcu_read_lock or lockdep_ovsl_is_held was held. ovs_dp_cmd_fill_info always is called with ovs_mutex, So use the rcu_

[PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King
syzbot has revealed that the "phylink" keyword exists in non-phylink related contexts in the bluetooth stack. To avoid receiving inappropriate notifications, change the keyword matching regexp to something which avoids this, while still allowing changes to networking drivers that make use of phylin

Re: [PATCH 0/2] selftests: rtnetlink: Fix for false-negative return values

2020-08-05 Thread David Miller
From: Po-Hsu Lin Date: Tue, 4 Aug 2020 18:18:01 +0800 > This patchset will address the false-negative return value issue > caused by the following: > 1. The return value "ret" in this script will be reset to 0 from > the beginning of each sub-test in rtnetlink.sh, therefore this > rt

rtnl_trylock() versus SCHED_FIFO lockup

2020-08-05 Thread Rasmus Villemoes
Hi, We're seeing occasional lockups on an embedded board (running an -rt kernel), which I believe I've tracked down to the if (!rtnl_trylock()) return restart_syscall(); in net/bridge/br_sysfs_br.c. The problem is that some SCHED_FIFO task writes a "1" to the /sys

Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-08-05 Thread Andrew Lunn
> > Well, until the user of this new API is ready, we will not accept the > > patch. > OK, but once we submit the change in the driver, is it good to go? No. You really do need to explain why it is needed, and why it is safe. > > You also need to explain "For HW performance reasons". Why is this

Re: [PATCH net] mptcp: be careful on subflow creation

2020-08-05 Thread David Miller
From: Paolo Abeni Date: Tue, 4 Aug 2020 18:31:06 +0200 > Nicolas reported the following oops: ... > on some unconventional configuration. > > The MPTCP protocol is trying to create a subflow for an > unaccepted server socket. That is allowed by the RFC, even > if subflow creation will likely f

Re: [PATCH net] selftests/net: relax cpu affinity requirement in msg_zerocopy test

2020-08-05 Thread David Miller
From: Willem de Bruijn Date: Wed, 5 Aug 2020 04:40:45 -0400 > From: Willem de Bruijn > > The msg_zerocopy test pins the sender and receiver threads to separate > cores to reduce variance between runs. > > But it hardcodes the cores and skips core 0, so it fails on machines > with the selected

Re: Packet not rerouting via different bridge interface after modifying destination IP in TC ingress hook

2020-08-05 Thread Andrew Lunn
On Wed, Aug 05, 2020 at 08:19:57AM +, Swarm NameRedacted wrote: > Hi, > > I am trying to build a quick script via TC direct action and eBPF to > modify the destination IP of a packet so that it is routed through a > different bridge interface. Made a quick network diagram below to > demonstrat

[PATCH v3 20/38] vhost/vdpa: switch to new helpers

2020-08-05 Thread Michael S. Tsirkin
For new helpers handling legacy features to be effective, vhost needs to invoke them. Tie them in. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vdpa.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 18869a35d408

[PATCH v3 38/38] virtio_net: use LE accessors for speed/duplex

2020-08-05 Thread Michael S. Tsirkin
Speed and duplex config fields depend on VIRTIO_NET_F_SPEED_DUPLEX which being 63>31 depends on VIRTIO_F_VERSION_1. Accordingly, use LE accessors for these fields. Reported-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c| 9 + include/uapi/linux

Re: [PATCH RESEND net-next] ip_tunnel_core: Fix build for archs without _HAVE_ARCH_IPV6_CSUM

2020-08-05 Thread David Miller
From: Stefano Brivio Date: Wed, 5 Aug 2020 15:39:31 +0200 > On architectures defining _HAVE_ARCH_IPV6_CSUM, we get > csum_ipv6_magic() defined by means of arch checksum.h headers. On > other architectures, we actually need to include net/ip6_checksum.h > to be able to use it. > > Without this in

Re: [External] Re: [PATCH v2] kprobes: fix NULL pointer dereference at kprobe_ftrace_handler

2020-08-05 Thread Steven Rostedt
On Thu, 6 Aug 2020 00:59:41 +0800 Muchun Song wrote: > > The original patch has already been pulled into the queue and tested. > > Please make a new patch that adds this update, as if your original > > patch has already been accepted. > > Will do, thanks! Also, if you can, add the following:

Re: [PATCH net-next v2 2/6] tunnels: PMTU discovery support for directly bridged IP packets

2020-08-05 Thread Stefano Brivio
Hi Naresh, On Wed, 5 Aug 2020 22:24:03 +0530 Naresh Kamboju wrote: > On Tue, 4 Aug 2020 at 11:24, Stefano Brivio wrote: > > > > + icmp6h->icmp6_cksum = csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr, > > len, > > + IPPROTO_ICMPV6, csum); > > Lin

Re: [PATCH net-next v2 2/6] tunnels: PMTU discovery support for directly bridged IP packets

2020-08-05 Thread Naresh Kamboju
cmp6hdr) { > + .icmp6_type = ICMPV6_PKT_TOOBIG, > + .icmp6_code = 0, > + .icmp6_cksum = 0, > + .icmp6_mtu = htonl(mtu), > + }; > + skb_reset_transport_header(skb); >

[RFC 1/4] netlink: consistently use NLA_POLICY_EXACT_LEN()

2020-08-05 Thread Johannes Berg
From: Johannes Berg Change places that open-code NLA_POLICY_EXACT_LEN() to use the macro instead, giving us flexibility in how we handle the details of the macro. Signed-off-by: Johannes Berg --- drivers/net/wireguard/netlink.c | 10 +- net/bridge/br_netlink.c | 4 ++-- net/br

Re: linux-next: build failure after merge of the net-next tree

2020-08-05 Thread Stefano Brivio
On Wed, 5 Aug 2020 15:21:44 +0200 Heiko Carstens wrote: > On Wed, Aug 05, 2020 at 03:06:27PM +0200, Stefano Brivio wrote: > > On Wed, 5 Aug 2020 22:31:21 +1000 > > Stephen Rothwell wrote: > > > > > Hi all, > > > > > > After merging the net-next tree, today's linux-next build (s390 defconfig)

  1   2   >