> From: Greg KH
> Sent: Friday, July 24, 2020 10:59 PM
> > [...]
> > Eric Dumazet made an alternative that performs the csum validation earlier:
> >
> > --- a/net/ipv4/udp.c
> > +++ b/net/ipv4/udp.c
> > @@ -1589,8 +1589,7 @@ int udp_queue_rcv_skb(struct sock *sk, struct
> > sk_buff *skb)
> >
From: Gaurav Singh
Date: Sun, 26 Jul 2020 23:38:10 -0400
> ipv6_pinfo is initlialized by inet6_sk() which returns NULL.
> Hence it can cause segmentation fault. Fix this by adding a
> NULL check.
Please take your time with such changes and actually look at the
compiler output, it will warn tha
From: Ido Schimmel
Date: Mon, 27 Jul 2020 10:18:34 +0300
> Cited commit mistakenly copied provided option to 'val' instead of to
> 'mfc':
>
> ```
> - if (copy_from_user(&mfc, optval, sizeof(mfc))) {
> + if (copy_from_sockptr(&val, optval, sizeof(val))) {
> ```
>
> Fi
From: Martin Varghese
Date: Mon, 27 Jul 2020 13:09:19 +0530
> From: Martin Varghese
>
> MPLS has no dependency with the device type of underlying devices.
> Hence the device type check to add mpls support for devices can be
> avoided.
>
> Signed-off-by: Martin Varghese
Applied, thanks for fo
On Mon, Jul 27, 2020 at 11:36 AM David Miller wrote:
>
> From: Michael Chan
> Date: Sun, 26 Jul 2020 23:29:36 -0400
>
> > This patchset removes the PCIe histogram and other debug register
> > data from ethtool -S. The removed data are not counters and they have
> > very large and constantly fluct
We are extending devlink infrastructure, thus move the existing
stuff into a new file qed_devlink.c
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/qed/Makefile | 1 +
drivers/net/ethernet/qlogic/qed/qed_devlin
Use devlink_health_report to push error indications.
We implement this in qede via callback function to make it possible
to reuse the same for other drivers sitting on top of qed in future.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
drivers
In theory that could lead to race condition
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/qed/qed_devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev
Gather and push out full device dump to devlink.
Device dump is the same as with `ethtool -d`, but now its generated
exactly at the moment bad thing happens.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/qed/qed_dev
Here we return existing fw & mfw versions, we also fetch device's
serial number.
The base device specific structure (qed_dev_info) was not directly
available to the base driver before.
Thus, here we create and store a private copy of this structure
in qed_dev root object.
Signed-off-by: Igor Russ
Here we declare health reporter ops (empty for now)
and register these in qed probe and remove callbacks.
This way we get devlink attached to all kind of qed* PCI
device entities: networking or storage offload entity.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by:
Remove forcible recovery trigger and put it as a normal devlink
callback.
This allows user to enable/disable it via
devlink health set pci/:03:00.0 reporter fw_fatal auto_recover false
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
dr
This patch replaces stubs in kconfig help entries with an actual description.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ne
Fix indent on some of adjacent declarations.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
---
include/linux/qed/qed_if.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed
This is a followup implementation after series
https://patchwork.ozlabs.org/project/netdev/cover/20200514095727.1361-1-irussk...@marvell.com/
This is an implementation of devlink health infrastructure.
With this we are now able to report HW errors to devlink, and it'll take
its own actions depen
First, we check cdev for null on dev close. That could be a case
if recovery was not successful.
Next, we nullify cdev if something bad happens on recovery, to
not to access freed memory accidentially.
Signed-off-by: Igor Russkikh
Signed-off-by: Alexander Lobakin
Signed-off-by: Michal Kalderon
Before that, devlink instance lifecycle was linked to qed_dev object,
that causes devlink to be recreated on each recovery.
Changing it by making higher level driver (qede) responsible for its
life. This way devlink will survive recoveries.
qede will store devlink structure pointer as a part of i
Enable the memcg-based memory accounting for the memory used by
the bpf ringbuffer.
Signed-off-by: Roman Gushchin
---
kernel/bpf/ringbuf.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/ringbuf.c b/kernel/bpf/ringbuf.c
index 002f8a5c9e51..e8e2c39cbdc9 100
Do not use rlimit-based memory accounting for cpumap maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/cpumap.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpum
Do not use rlimit-based memory accounting for hashtab maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/hashtab.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bp
Include memory used by bpf programs into the memcg-based accounting.
This includes the memory used by programs itself, auxiliary data
and statistics.
Signed-off-by: Roman Gushchin
---
kernel/bpf/core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/core.c
Since bpf stopped using memlock rlimit to limit the memory usage,
there is no more reason for perf to alter its own limit.
Signed-off-by: Roman Gushchin
---
tools/perf/builtin-trace.c | 10 --
tools/perf/tests/builtin-test.c | 6 --
tools/perf/util/Build | 1 -
tools
Since bpf stopped using memlock rlimit to limit the memory usage,
there is no more reason for bpftool to alter its own limits.
Signed-off-by: Roman Gushchin
---
tools/bpf/bpftool/common.c | 7 ---
tools/bpf/bpftool/feature.c| 2 --
tools/bpf/bpftool/main.h | 2 --
tools/bpf/bpf
Do not use rlimit-based memory accounting for bpf_struct_ops maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/bpf_struct_ops.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/kernel/bpf/bpf_st
This patch enables memcg-based memory accounting for memory allocated
by __bpf_map_area_alloc(), which is used by most map types for
large allocations.
Following patches in the series will refine the accounting for
some map types.
Signed-off-by: Roman Gushchin
---
kernel/bpf/syscall.c | 2 +-
1
Do not use rlimit-based memory accounting for bpf ringbuffer.
It has been replaced with the memcg-based memory accounting.
bpf_ringbuf_alloc() can't return anything except ERR_PTR(-ENOMEM)
and a valid pointer, so to simplify the code make it return NULL
in the first case. This allows to drop a cou
Do not use rlimit-based memory accounting for reuseport_array maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/reuseport_array.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/kernel/bpf/reuseport_a
Do not use rlimit-based memory accounting for sockmap and sockhash maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
net/core/sock_map.c | 33 ++---
1 file changed, 6 insertions(+), 27 deletions(-)
diff --git a/net/c
Since bpf is not using memlock rlimit for memory accounting,
there are no more reasons to bump the limit.
Signed-off-by: Roman Gushchin
---
tools/testing/selftests/bpf/bench.c | 16 ---
.../selftests/bpf/progs/bpf_iter_bpf_map.c| 5 ++---
tools/testing/selftests/bpf/xd
Do not use rlimit-based memory accounting for cgroup storage maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/local_storage.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/kernel/bpf/local_
As rlimit-based memory accounting is not used by bpf anymore,
there are no more reasons to play with memlock rlimit.
Delete bpf_rlimit.h which contained a code to bump the limit.
Signed-off-by: Roman Gushchin
---
samples/bpf/hbm.c | 1 -
tools/testing/selftests/bpf/
Include lpm trie and lpm trie node objects into the memcg-based memory
accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/lpm_trie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c
index 44474bf3ab7a..d85e0fc2cafc 100644
Do not use rlimit-based memory accounting for xskmap maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
net/xdp/xskmap.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c
index e574b
Do not use rlimit-based memory accounting for bpf progs. It has been
replaced with memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
include/linux/bpf.h | 11 --
kernel/bpf/core.c| 12 ++-
kernel/bpf/syscall.c | 86 ++--
3 files
Do not use rlimit-based memory accounting for socket storage maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
net/core/bpf_sk_storage.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_
Extend xskmap memory accounting to include the memory taken by
the xsk_map_node structure.
Signed-off-by: Roman Gushchin
---
net/xdp/xskmap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c
index 8367adbbe9df..e574b22defe5 100644
--- a/ne
Do not use rlimit-based memory accounting for stackmap maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/stackmap.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/kernel/bpf/stackmap.c b/kernel/b
Currently bpf is using the memlock rlimit for the memory accounting.
This approach has its downsides and over time has created a significant
amount of problems:
1) The limit is per-user, but because most bpf operations are performed
as root, the limit has a little value.
2) It's hard to come u
Remove rlimit-based accounting infrastructure code, which is not used
anymore.
Signed-off-by: Roman Gushchin
---
include/linux/bpf.h | 12
kernel/bpf/syscall.c | 64 +--
.../selftests/bpf/progs/map_ptr_kern.c| 5 --
Since bpf is not using memlock rlimit for memory accounting,
there are no more reasons to bump the limit.
Signed-off-by: Roman Gushchin
---
tools/bpf/runqslower/runqslower.c | 16
1 file changed, 16 deletions(-)
diff --git a/tools/bpf/runqslower/runqslower.c
b/tools/bpf/runqsl
As bpf is not using memlock rlimit for memory accounting anymore,
let's remove the related code from libbpf.
Bpf operations can't fail because of exceeding the limit anymore.
Signed-off-by: Roman Gushchin
---
tools/lib/bpf/libbpf.c | 31 +--
tools/lib/bpf/libbpf.h |
Since bpf is not using rlimit memlock for the memory accounting
and control, do not change the limit in sample applications.
Signed-off-by: Roman Gushchin
---
samples/bpf/map_perf_test_user.c| 11 ---
samples/bpf/offwaketime_user.c | 2 --
samples/bpf/sockex2_user.c |
Include percpu arrays and auxiliary data into the memcg-based memory
accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/arraymap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 8ff419b632a6..9597fecff8da 100644
Do not use rlimit-based memory accounting for arraymap maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/arraymap.c | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/kernel/bpf/arraymap.c b/
Include percpu objects and the size of map metadata into the
accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/hashtab.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
index 024276787055..9d0432170812 100644
-
Include metadata and percpu data into the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/cpumap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c
index f1c46529929b..74ae9fcbe82e 100644
--- a/kernel/bp
Account memory used by the socket storage.
Signed-off-by: Roman Gushchin
---
net/core/bpf_sk_storage.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c
index eafcd15e7dfd..fbcd03cd00d3 100644
--- a/net/core/bpf
Include map metadata and the node size (struct bpf_dtab_netdev) on
element update into the accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/devmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index 10abb06065bb..05bf
Account memory used by cgroup storage maps including the percpu memory
for the percpu flavor of cgroup storage and map metadata.
Signed-off-by: Roman Gushchin
---
kernel/bpf/local_storage.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/kernel/bpf/local_sto
> Subject: Re: [PATCH net-next v4 0/5] net: phy: add Lynx PCS MDIO module
>
>
>
> On 7/24/2020 1:01 AM, Ioana Ciornei wrote:
> > Add support for the Lynx PCS as a separate module in drivers/net/phy/.
> > The advantage of this structure is that multiple ethernet or switch
> > drivers used on NXP
Do not use rlimit-based memory accounting for queue_stack maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/queue_stack_maps.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/kernel/bpf/queue_stac
Include internal metadata into the memcg-based memory accounting.
Also include the memory allocated on updating an element.
Signed-off-by: Roman Gushchin
---
net/core/sock_map.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/core/sock_map.c b/net/core/sock_map.c
i
Do not use rlimit-based memory accounting for devmap maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/devmap.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/d
Do not use rlimit-based memory accounting for lpm_trie maps.
It has been replaced with the memcg-based memory accounting.
Signed-off-by: Roman Gushchin
---
kernel/bpf/lpm_trie.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c
index
From: Michael Chan
Date: Mon, 27 Jul 2020 05:40:35 -0400
> This patchset removes the PCIe histogram and other debug register
> data from ethtool -S. The removed data are not counters and they have
> very large and constantly fluctuating values that are not suitable for
> the ethtool -S decimal co
On Mon, Jul 27, 2020 at 5:08 AM Shay Agroskin wrote:
>
>
> Andrii Nakryiko writes:
>
> > Further refactor XDP attachment code. dev_change_xdp_fd() is
> > split into two
> > parts: getting bpf_progs from FDs and attachment logic, working
> > with
> > bpf_progs. This makes attachment logic a bit m
From: Matthieu Baerts
Date: Mon, 27 Jul 2020 12:24:33 +0200
> Unblocking sockets used for outgoing connections were not containing
> inet info about the initial connection due to a typo there: the value of
> "err" variable is negative in the kernelspace.
>
> This fixes the creation of additional
> From: Eric Dumazet
> Sent: Monday, July 27, 2020 11:40 AM
> To: Dexuan Cui
>
> On Mon, Jul 27, 2020 at 11:38 AM Dexuan Cui wrote:
> >
> > > From: Greg KH
> > > Sent: Friday, July 24, 2020 10:59 PM
> > > > [...]
> > > > Eric Dumazet made an alternative that performs the csum validation
> earl
From: Yangbo Lu
Date: Mon, 27 Jul 2020 18:26:14 +0800
> From: laurent brando
>
> The next hw timestamp should be snapshoot to the read registers
> only once the current timestamp has been read.
> If none of the pending skbs matches the current HW timestamp
> just gracefully flush the available
From: Alexander Lobakin
Date: Mon, 27 Jul 2020 14:51:33 +0300
> Dan reports static checker warning:
>
> "The patch 9b6ee3cf95d3: "qed: sanitize PBL chains allocation" from Jul
> 23, 2020, leads to the following static checker warning:
>
> drivers/net/ethernet/qlogic/qed/qed_chain.c:299 qe
On 7/27/2020 8:47 AM, Jamie Gloudon wrote:
> Hey,
>
> While having a discussion with Sasha from Intel. I noticed link partner
> advertised support is broken in ethtool 5.7. Sasha hinted to me, the
> new API that ethtool is using.
>
> I see the actual cause in dump_peer_modes() in netlink/setti
From: Roopa Prabhu
netdev protodown is a mechanism that allows protocols to
hold an interface down. It was initially introduced in
the kernel to hold links down by a multihoming protocol.
There was also an attempt to introduce protodown
reason at the time but was rejected. protodown and protodown
From: Murali Karicheri
Date: Wed, 22 Jul 2020 10:40:15 -0400
> This series is dependent on the following patches sent out to
> netdev list. All (1-3) are already merged to net/master as of
> sending this, but not on the net-next master branch. So need
> to apply them to net-next before applying t
From: Edward Cree
Date: Mon, 27 Jul 2020 12:53:54 +0100
> EF100 is a new NIC architecture under development at Xilinx, based
> partly on existing Solarflare technology. As many of the hardware
> interfaces resemble EF10, support is implemented within the 'sfc'
> driver, which previous patch s
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wirele
Briana Oursler writes:
> I git bisected and found d0e450438571("tc: q_red: Add support for
> qevents "mark" and "early_drop"), the commit that introduced the
> formatting change causing the break.
>
> - print_string(PRINT_FP, NULL, "max %s ", sprint_size(qopt->qth_max,
> b3));
> +
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-
From: Vadym Kochan
Date: Mon, 27 Jul 2020 15:22:37 +0300
> + /* called by device driver to pass event up to the higher layer */
> + int (*recv_msg)(struct prestera_device *dev, u8 *msg, size_t size);
> +
> + /* called by higher layer to send request to the firmware */
> + int (*se
On 7/27/20 9:25 AM, Tanner Love wrote:
> From: Tanner Love
>
> When size_t maps to unsigned int (e.g. on 32-bit powerpc), then the
> comparison with 1<<35 is always true. Clang 9 threw:
> warning: result of comparison of constant 34359738368 with \
> expression of type 'size_t' (aka 'unsigned
From:
Date: Mon, 27 Jul 2020 12:56:52 +
> diff --git a/net/core/filter.c b/net/core/filter.c
> index bdd2382e6..93e790d7b 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -3452,6 +3452,62 @@ static const struct bpf_func_proto
> bpf_xdp_adjust_head_proto = {
> .arg2_type
On 7/27/20 11:57 AM, Dexuan Cui wrote:
>> From: Eric Dumazet
> Oh, yes! :-) Thank you!
>
> Eric, I'll add your Signed-off-by and mine. Please let me know in case
> this is not ok.
Sure, do not worry about this.
>
> I'll do a little more testing with the patch and I plan to post the patch
>
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-
From: kernel test robot
Date: Mon, 27 Jul 2020 23:52:50 +0800
> All warnings (new ones prefixed by >>):
>
>net/tipc/topsrv.c: In function 'tipc_conn_send_to_sock':
>>> net/tipc/topsrv.c:259:10: warning: 'return' with a value, in function
>>> returning void [-Wreturn-type]
> 259 | ret
Hi Cong Wang,
I'm wishing to change a driver from using "hard_header_len" to using
"needed_headroom" to declare its needed headroom. I submitted a patch
and it is decided it needs to be reviewed. I see you participated in
"hard_header_len vs needed_headroom" discussions in the past. Can you
help m
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wirele
On Mon, 2020-07-27 at 14:44 -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
[]
> diff --git a/drivers/net/wireless/ath/ath1
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wirele
On Mon, Jul 27, 2020 at 12:06:08PM -0700, David Miller wrote:
> From: Yangbo Lu
> Date: Mon, 27 Jul 2020 18:26:14 +0800
>
> > From: laurent brando
> >
> > The next hw timestamp should be snapshoot to the read registers
> > only once the current timestamp has been read.
> > If none of the pendin
On 7/27/20 11:48 AM, Ioana Ciornei wrote:
>> Subject: Re: [PATCH net-next v4 0/5] net: phy: add Lynx PCS MDIO module
>>
>>
>>
>> On 7/24/2020 1:01 AM, Ioana Ciornei wrote:
>>> Add support for the Lynx PCS as a separate module in drivers/net/phy/.
>>> The advantage of this structure is that multiple
From: Srujana Challa
Date: Mon, 27 Jul 2020 14:12:46 +
> On our test setup, the build is always successful, as we are adding
> "af/" subdirectory in ccflags list ([PATCH 4/4] crypto: marvell:
> enable OcteonTX2 cpt options for build).
A patch series must be fully bisectable, the tree must bu
From: 王文虎
Date: Mon, 27 Jul 2020 23:03:16 +0800 (GMT+08:00)
> Currently the qmi_handle is initialized single threaded and strictly
> ordered with the active set to 1. This is pretty simple and safe but
> sometimes ineffency. So it is better to allow user to decide whether
> a high priority workqu
On Sun, Jul 26, 2020 at 8:39 PM Gaurav Singh wrote:
>
> ipv6_pinfo is initlialized by inet6_sk() which returns NULL.
Why? It only returns NULL for timewait or request sock, but
I don't see how ip6_autoflowlabel() could be called on these
sockets. So please explain.
> Hence it can cause segmentat
From: Tanner Love
Date: Mon, 27 Jul 2020 12:25:27 -0400
> This is essentially a v2 of
> http://patchwork.ozlabs.org/project/netdev/patch/20200724181757.2331172-1-tannerlove.ker...@gmail.com/,
> but it has been split up in order to have only one "Fixes" tag per
> patch.
Series applied, thank you.
On Mon, Jul 27, 2020 at 12:19:13PM -0700, Jacob Keller wrote:
>
>
> On 7/27/2020 8:47 AM, Jamie Gloudon wrote:
> > Hey,
> >
> > While having a discussion with Sasha from Intel. I noticed link partner
> > advertised support is broken in ethtool 5.7. Sasha hinted to me, the
> > new API that ethtool i
From: Tony Nguyen
Date: Mon, 27 Jul 2020 10:13:30 -0700
> This series contains updates to igc driver only.
>
> Sasha cleans up double definitions, unneeded and non applicable
> registers, and removes unused fields in structs. Ensures the Receive
> Descriptor Minimum Threshold Count is cleared an
From: "Gustavo A. R. Silva"
Date: Mon, 27 Jul 2020 12:55:26 -0500
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1]
> https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-
From: "Gustavo A. R. Silva"
Date: Mon, 27 Jul 2020 13:03:56 -0500
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
>
> [1]
> https://www.kernel.org/doc/ht
From: Al Viro
Date: Mon, 27 Jul 2020 19:22:20 +0100
> commit 547ce4cfb34c ("switch cmsghdr_from_user_compat_to_kern() to
> copy_from_user()") missed one of the places where ucmlen should've been
> replaced with cmsg.cmsg_len, now that we are fetching the entire struct
> rather than doing it
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-
> Andrew, what directory structure do you have in mind such that Ioana can
> already start putting the PCS drivers in the right location?
Hi Florian
I will push out an RFC soon. It will need some build testing, just to
make sure i've not broken any Kconfig dependencies.
Andrew
On Mon, 27 Jul 2020 21:31:36 +0200
Petr Machata wrote:
> Briana Oursler writes:
>
> > I git bisected and found d0e450438571("tc: q_red: Add support for
> > qevents "mark" and "early_drop"), the commit that introduced the
> > formatting change causing the break.
> >
> > - print_string(PRIN
On Fri, 24 Jul 2020, Casey Schaufler wrote:
> Change netlink netfilter interfaces to use lsmcontext
> pointers, and remove scaffolding.
>
> Reviewed-by: Kees Cook
> Reviewed-by: John Johansen
> Acked-by: Stephen Smalley
> Signed-off-by: Casey Schaufler
> cc: netdev@vger.kernel.org
I'd like t
On Mon, Jul 27, 2020 at 04:09:12PM -0400, Jamie Gloudon wrote:
> On Mon, Jul 27, 2020 at 12:19:13PM -0700, Jacob Keller wrote:
> >
> >
> > On 7/27/2020 8:47 AM, Jamie Gloudon wrote:
> > > Hey,
> > >
> > > While having a discussion with Sasha from Intel. I noticed link partner
> > > advertised suppo
Hi Igor,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Igor-Russkikh/qed-introduce-devlink-health-support/20200728-024531
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
a57066
This header file is currently included into the ethernet driver via a
relative path into the PHY subsystem. This is bad practice, and causes
issues for the upcoming move of the MDIO driver. Move the header file
into include/linux to clean this up.
Signed-off-by: Andrew Lunn
---
drivers/net/ether
On Mon, 27 Jul 2020 12:21:17 -0700
Roopa Prabhu wrote:
> -+ nla_total_size(1) /* IFLA_PROTO_DOWN */
> ++ rtnl_proto_down_size(dev) /* proto down */
Changing the size of a netlink field is an ABI change in the kernel.
This has the potential to break existing programs.
W
Create a subdirectory for PCS drivers. Introduce a new naming
convention for PCS drivers, in that the files should have the prefix
pcs-, and the Kconfig symbols should use the PCS_ prefix. This means
renaming the one such driver that currently exists.
Signed-off-by: Andrew Lunn
---
drivers/net/e
Move the PHY drivers into the phy subdirectory
Move the MDIO bus drivers into the mdio subdirectory
Take this opportunity to sort the Kconfig entries based on the text
that appears in the menu, and the Makefiles.
Signed-off-by: Andrew Lunn
---
drivers/net/phy/Kconfig | 481
RFC Because it needs 0-day build testing
The directory drivers/net/phy is getting rather cluttered with the
growing number of MDIO bus drivers and PHY device drivers. We also
have one PCS driver and more are expected soon.
Restructure the directory, moving MDIO bus drivers into /mdio. PHY
driver
On Mon 27 Jul 08:03 PDT 2020, ? wrote:
> Currently the qmi_handle is initialized single threaded and strictly
> ordered with the active set to 1. This is pretty simple and safe but
> sometimes ineffency. So it is better to allow user to decide whether
> a high priority workqueue should be
1 - 100 of 543 matches
Mail list logo
