[PATCH v5] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Sriram Krishnan
Vlan tagged packets are getting dropped when used with DPDK that uses the AF_PACKET interface on a hyperV guest. The packet layer uses the tpacket interface to communicate the vlans information to the upper layers. On Rx path, these drivers can read the vlan info from the tpacket header but on the

[PATCH net-next] net: explicitly include in net/core/sock.c

2020-07-22 Thread Christoph Hellwig
The buildbot found a config where the header isn't already implicitly pulled in, so add an explicit include as well. Fixes: 8c918ffbbad4 ("net: remove compat_sock_common_{get,set}sockopt") Signed-off-by: Christoph Hellwig --- net/core/sock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ne

Re: [PATCH 03/24] net: add a new sockptr_t type

2020-07-22 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 10:55:43AM -0700, Eric Biggers wrote: > On Mon, Jul 20, 2020 at 07:43:22PM +0200, Christoph Hellwig wrote: > > On Mon, Jul 20, 2020 at 09:37:48AM -0700, Eric Biggers wrote: > > > How does this not introduce a massive security hole when > > > CONFIG_ARCH_HAS_NON_OVERLAPPING_A

Re: get rid of the address_space override in setsockopt

2020-07-22 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 01:47:56PM -0700, Alexei Starovoitov wrote: > > a kernel pointer. This is something that works for most common sockopts > > (and is something that the ePBF support relies on), but unfortunately > > in various corner cases we either don't use the passed in length, or in > >

Re: [PATCH 12/24] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t

2020-07-22 Thread 'Christoph Hellwig'
On Tue, Jul 21, 2020 at 08:36:57AM +, David Laight wrote: > From: Christoph Hellwig > > Sent: 20 July 2020 13:47 > > > > This is mostly to prepare for cleaning up the callers, as bpfilter by > > design can't handle kernel pointers. > ^^^ user ?? No, it can't handle user

Re: [PATCH 12/24] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t

2020-07-22 Thread 'Christoph Hellwig'
On Wed, Jul 22, 2020 at 10:00:23AM +0200, 'Christoph Hellwig' wrote: > On Tue, Jul 21, 2020 at 08:36:57AM +, David Laight wrote: > > From: Christoph Hellwig > > > Sent: 20 July 2020 13:47 > > > > > > This is mostly to prepare for cleaning up the callers, as bpfilter by > > > design can't handl

Re: get rid of the address_space override in setsockopt

2020-07-22 Thread 'Christoph Hellwig'
On Tue, Jul 21, 2020 at 09:38:23AM +, David Laight wrote: > From: Christoph Hellwig > > Sent: 20 July 2020 13:47 > > > > setsockopt is the last place in architecture-independ code that still > > uses set_fs to force the uaccess routines to operate on kernel pointers. > > > > This series adds a

Re: get rid of the address_space override in setsockopt

2020-07-22 Thread 'Christoph Hellwig'
On Tue, Jul 21, 2020 at 10:26:58AM +, David Laight wrote: > From: Christoph Hellwig > > Sent: 20 July 2020 13:47 > > > > setsockopt is the last place in architecture-independ code that still > > uses set_fs to force the uaccess routines to operate on kernel pointers. > > > > This series adds

[PATCH net-next] net: mscc: ocelot: fix non-initialized CPU port on VSC7514

2020-07-22 Thread Vladimir Oltean
From: Vladimir Oltean The VSC7514 is marketed as a 10-port switch, however it has 11 physical ports (0->10) in the block diagram: https://www.microsemi.com/product-directory/ethernet-switches/3992-vsc7514 (also in the device tree at arch/mips/boot/dts/mscc/ocelot.dtsi) Additionally, by architect

Re: [PATCH v3] net: ethernet: ravb: exit if re-initialization fails in tx timeout

2020-07-22 Thread Sergei Shtylyov
On 21.07.2020 9:23, Yoshihiro Shimoda wrote: According to the report of [1], this driver is possible to cause the following error in ravb_tx_timeout_work(). ravb e680.ethernet ethernet: failed to switch device to config mode This error means that the hardware could not change the state fro

Re: [PATCH bpf-next] tools/bpftool: strip BPF .o files before skeleton generation

2020-07-22 Thread Quentin Monnet
On 22/07/2020 05:38, Andrii Nakryiko wrote: > Strip away DWARF info from .bpf.o files, before generating BPF skeletons. > This reduces bpftool binary size from 3.43MB to 2.58MB. > > Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet

RE: get rid of the address_space override in setsockopt

2020-07-22 Thread David Laight
From: 'Christoph Hellwig' > Sent: 22 July 2020 09:07 > On Tue, Jul 21, 2020 at 09:38:23AM +, David Laight wrote: > > From: Christoph Hellwig > > > Sent: 20 July 2020 13:47 > > > > > > setsockopt is the last place in architecture-independ code that still > > > uses set_fs to force the uaccess ro

Re: [MPTCP] [PATCH 24/24] net: pass a sockptr_t into ->setsockopt

2020-07-22 Thread Matthieu Baerts
Hi Christoph, On 20/07/2020 14:47, Christoph Hellwig wrote: Rework the remaining setsockopt code to pass a sockptr_t instead of a plain user pointer. This removes the last remaining set_fs(KERNEL_DS) outside of architecture specific code. Signed-off-by: Christoph Hellwig --- ... diff --git

[PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread Eelco Chaudron
This patch makes the masks cache size configurable, or with a size of 0, disable it. Reviewed-by: Paolo Abeni Signed-off-by: Eelco Chaudron --- include/uapi/linux/openvswitch.h |1 net/openvswitch/datapath.c | 11 + net/openvswitch/flow_table.c | 86 ++

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-22 Thread Roger Pau Monné
On Tue, Jul 21, 2020 at 07:55:09PM +, Anchal Agarwal wrote: > On Tue, Jul 21, 2020 at 10:30:18AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the con

[PATCH net-next 0/2] net: openvswitch: masks cache enhancements

2020-07-22 Thread Eelco Chaudron
This patchset adds two enhancements to the Open vSwitch masks cache. Signed-off-by: Eelco Chaudron Eelco Chaudron (2): net: openvswitch: add masks cache hit counter net: openvswitch: make masks cache size configurable include/uapi/linux/openvswitch.h |3 + net/openvswitch/data

[PATCH net-next 1/2] net: openvswitch: add masks cache hit counter

2020-07-22 Thread Eelco Chaudron
Add a counter that counts the number of masks cache hits, and export it through the megaflow netlink statistics. Reviewed-by: Paolo Abeni Signed-off-by: Eelco Chaudron --- include/uapi/linux/openvswitch.h |2 +- net/openvswitch/datapath.c |5 - net/openvswitch/datapath.h

Re: [PATCH v2] selftest: txtimestamp: fix net ns entry logic

2020-07-22 Thread Paolo Pisati
On Tue, Jul 21, 2020 at 6:26 PM Willem de Bruijn wrote: > > Fixes: cda261f421ba ("selftests: add txtimestamp kselftest") > > Acked-by: Willem de Bruijn Besides, is it just me or this test fails frequently? I've been running it on 5.4.x, 5.7.x and 5.8-rcX and it often fails: ... USR: 1595405

Re: [PATCH net-next 0/2] net: openvswitch: masks cache enhancements

2020-07-22 Thread Eelco Chaudron
On 22 Jul 2020, at 10:27, Eelco Chaudron wrote: This patchset adds two enhancements to the Open vSwitch masks cache. Signed-off-by: Eelco Chaudron Eelco Chaudron (2): net: openvswitch: add masks cache hit counter net: openvswitch: make masks cache size configurable include/u

Re: [PATCH 05/29] l2tp: cleanup difficult-to-read line breaks

2020-07-22 Thread Tom Parkin
On Tue, Jul 21, 2020 at 13:59:38 -0700, Jakub Kicinski wrote: > On Tue, 21 Jul 2020 18:31:57 +0100 Tom Parkin wrote: > > #if IS_ENABLED(CONFIG_IPV6) > > - if (info->attrs[L2TP_ATTR_IP6_SADDR] && > > - info->attrs[L2TP_ATTR_IP6_DADDR]) { > > - cfg.local_ip

Re: [PATCH net-next 00/29] l2tp: cleanup checkpatch.pl warnings

2020-07-22 Thread Tom Parkin
On Tue, Jul 21, 2020 at 16:19:17 -0700, David Miller wrote: > > This patch set is way too large to be reasonably reviewed by other > developers. > > Please either find a way to combine some of the patches, or submit > this in stages of about 10 or so patches at a time. > > I am not applying thi

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-22 Thread David Laight
From: Andrew Lunn > Sent: 21 July 2020 18:25 > > On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote: > > NAPI gets scheduled on the CPU core which got the > > interrupt. The linux scheduler cannot move it to a > > different core, even if the CPU on which NAPI is running > > is heavily l

答复: [PATCH] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
This check of ip head checksum should be add in ipvlan_get_L3_hdr,if the ipvlan_get_L3_hdr return value is null, the packet should be dropped. Because the IP packet will do ip forward in the ipvlan l3/l3s mode and the corrupted ip packet should not go ahead, the other type packet will be dropped

[PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread guodeqing
The ip header checksum can be error in the following steps. $ ip netns add ns1 $ ip link add gw link eth0 type ipvlan $ ip addr add 168.16.0.1/24 dev gw $ ip link set dev gw up $ ip link add ip1 link eth0 type ipvlan $ ip link set ip1 netns ns1 $ ip netns exec ns1 ip link set ip1 up $ ip netns exec

Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Steffen Klassert
On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: > In pfkey_dump() dplen and splen can both be specified to access the > xfrm_address_t structure out of bounds in__xfrm_state_filter_match() > when it calls addr_match() with the indexes. Return EINVAL if either > are out of range. > >

Re: [PATCH v2 04/11] x86/xen: add system core suspend and resume callbacks

2020-07-22 Thread Julien Grall
Hi, On 02/07/2020 19:22, Anchal Agarwal wrote: diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index 2521d6a306cd..9fa8a4082d68 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -41,6 +41,8 @@ u64 xen_steal_clock(int cpu); int xen_setup_shutdown_event(void); boo

[PATCH V3 0/6] IRQ offloading for vDPA

2020-07-22 Thread Zhu Lingshan
This series intends to implement IRQ offloading for vhost_vdpa. By the feat of irq forwarding facilities like posted interrupt on X86, irq bypass can help deliver interrupts to vCPU directly. vDPA devices have dedicated hardware backends like VFIO pass-throughed devices. So it would be possibl

[PATCH V3 1/6] vhost: introduce vhost_vring_call

2020-07-22 Thread Zhu Lingshan
From: Zhu Lingshan This commit introduces struct vhost_vring_call which replaced raw struct eventfd_ctx *call_ctx in struct vhost_virtqueue. Besides eventfd_ctx, it contains a spin lock and an irq_bypass_producer in its structure. Signed-off-by: Zhu Lingshan Signed-off-by: lszhu Signed-off-by:

KMSAN: uninit-value in __skb_flow_dissect (3)

2020-07-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:14525656 compiler.h: reinstate missing KMSAN_INIT git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=154bb20f10 kernel config: https://syzkaller.appspot.com/x/.config

Re: [PATCH V3 1/6] vhost: introduce vhost_vring_call

2020-07-22 Thread Zhu Lingshan
Please ignore this patchset incorrect metadata, will resend soon. Thanks! On 7/22/2020 5:49 PM, Zhu Lingshan wrote: From: Zhu Lingshan This commit introduces struct vhost_vring_call which replaced raw struct eventfd_ctx *call_ctx in struct vhost_virtqueue. Besides eventfd_ctx, it contains a sp

[PATCH V3 0/6] IRQ offloading for vDPA

2020-07-22 Thread Zhu Lingshan
This series intends to implement IRQ offloading for vhost_vdpa. By the feat of irq forwarding facilities like posted interrupt on X86, irq bypass can help deliver interrupts to vCPU directly. vDPA devices have dedicated hardware backends like VFIO pass-throughed devices. So it would be possible

[PATCH V3 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

2020-07-22 Thread Zhu Lingshan
This patch introduce a set of functions for setup/unsetup and update irq offloading respectively by register/unregister and re-register the irq_bypass_producer. Signed-off-by: Zhu Lingshan --- drivers/vhost/Kconfig | 1 + drivers/vhost/vdpa.c | 66 ++- 2

[PATCH V3 2/6] kvm: detect assigned device via irqbypass manager

2020-07-22 Thread Zhu Lingshan
vDPA devices has dedicated backed hardware like passthrough-ed devices. Then it is possible to setup irq offloading to vCPU for vDPA devices. Thus this patch tries to manipulated assigned device counters by kvm_arch_start/end_assignment() in irqbypass manager, so that assigned devices could be dete

[PATCH V3 3/6] vDPA: implement vq IRQ allocate/free helpers in vDPA core

2020-07-22 Thread Zhu Lingshan
This commit implements vq IRQ allocate/free helpers in vDPA core by introducing two couple of functions: vdpa_devm_request_Irq() and vdpa_devm_free_irq(): request irq and free irq, and setup irq offloading. vdpa_setup_irq() and vdpa_unsetup_irq(): supportive functions, will call vhost_vdpa helper

[PATCH V3 1/6] vhost: introduce vhost_vring_call

2020-07-22 Thread Zhu Lingshan
This commit introduces struct vhost_vring_call which replaced raw struct eventfd_ctx *call_ctx in struct vhost_virtqueue. Besides eventfd_ctx, it contains a spin lock and an irq_bypass_producer in its structure. Signed-off-by: Zhu Lingshan --- drivers/vhost/vdpa.c | 4 ++-- drivers/vhost/vhost

[PATCH V3 5/6] ifcvf: replace irq_request/free with vDPA helpers

2020-07-22 Thread Zhu Lingshan
This commit replaced irq_request/free() with vDPA helpers vdpa_devm_request/free_irq() so that it can request/free irq and setup irq offloading on order. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --g

[PATCH V3 6/6] irqbypass: do not start cons/prod when failed connect

2020-07-22 Thread Zhu Lingshan
If failed to connect, there is no need to start consumer nor producer. Signed-off-by: Zhu Lingshan --- virt/lib/irqbypass.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c index 28fda42e471b..c9bb3957f58a 100644 --

[PATCH 1/2] ipw2100: Use GFP_KERNEL instead of GFP_ATOMIC in some memory allocation

2020-07-22 Thread Christophe JAILLET
The call chain is: ipw2100_pci_init_one(the probe function) --> ipw2100_queues_allocate --> ipw2100_tx_allocate No lock is taken in the between. So it is safe to use GFP_KERNEL in 'ipw2100_tx_allocate()'. BTW, 'ipw2100_queues_allocate()' also calls 'ipw2100_msg_allocate

[PATCH 2/2] ipw2x00: switch from 'pci_' to 'dma_' API

2020-07-22 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'ipw2100_msg_allocate()' (ipw2100.c), GFP_KERNEL can

Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Mark Salyzyn
On 7/22/20 2:33 AM, Steffen Klassert wrote: On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: In pfkey_dump() dplen and splen can both be specified to access the xfrm_address_t structure out of bounds in__xfrm_state_filter_match() when it calls addr_match() with the indexes. Return

[PATCH] p54: switch from 'pci_' to 'dma_' API

2020-07-22 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'p54p_probe()', GFP_KERNEL can be used because it is

[PATCH v3 0/2] Add 802.1AD protocol support for dsa switch and ocelot driver

2020-07-22 Thread hongbo . wang
From: "hongbo.wang" 1. the patch 0001* is for setting single port into 802.1AD(QinQ) mode, before this patch, the function dsa_slave_vlan_rx_add_vid didn't pass the parameter "proto" to next port level, so switch's port can't get parameter "proto" after applying this patch, we can use the foll

[PATCH v3 2/2] net: dsa: ocelot: Add support for QinQ Operation

2020-07-22 Thread hongbo . wang
From: "hongbo.wang" This featue can be test using network test tools TX-tool -> swp0 -> swp1 -> RX-tool TX-tool simulates Customer that will send and receive packets with single VLAN tag(CTAG), RX-tool simulates Service-Provider that will send and receive packets with double VLA

[PATCH v3 1/2] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch and port

2020-07-22 Thread hongbo . wang
From: "hongbo.wang" the following command will be supported: Add VLAN: ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 Delete VLAN: ip link del link swp1 name swp1.100 when adding vlan, this patch only set protocol for user port, cpu port don't care it, so set param

Re: [PATCH net-next] efx: convert to new udp_tunnel infrastructure

2020-07-22 Thread Edward Cree
On 21/07/2020 20:48, Jakub Kicinski wrote: > #define TUNNEL_ENCAP_UDP_PORT_ENTRY_INVALID 0x > Can I add that in mcdi_pcol.h or better next to struct efx_udp_tunnel? > > mcdi_pcol.h looks generated. It is generated, yeah. So best add it with struct efx_udp_tunnel. -ed

Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Steffen Klassert
On Wed, Jul 22, 2020 at 03:20:59AM -0700, Mark Salyzyn wrote: > On 7/22/20 2:33 AM, Steffen Klassert wrote: > > On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: > > > In pfkey_dump() dplen and splen can both be specified to access the > > > xfrm_address_t structure out of bounds in__xf

Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-22 Thread Sriram Krishnan (srirakr2)
On 22/07/20, 3:48 AM, "Haiyang Zhang" wrote: > If you make this change, did you see any drop in a live test? The > "packet->total_bytes" in struct hv_netvsc_packet is for book keeping > only, which is used for stats info, and not visible by the host at all. > I made this sugg

[PATCH] prism54: switch from 'pci_' to 'dma_' API

2020-07-22 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'islpci_alloc_memory()' (islpci_dev.c), GFP_KERNEL c

Re: [PATCH v4] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Sriram Krishnan (srirakr2)
On 21/07/20, 9:36 PM, Stephen Hemminger wrote: > Printing error messages is good for debugging but bad IRL. > Users ignore it, or it overflows the log buffer. > A better alternative would be to add a counter to netvsc_ethtool_stats. Thanks, the recommended change can be foun

Re: [RFC PATCH net-next v2 6/6] devlink: add overwrite mode to flash update

2020-07-22 Thread Jiri Pirko
Tue, Jul 21, 2020 at 07:04:06PM CEST, kubak...@wp.pl wrote: >On Tue, 21 Jul 2020 15:53:56 +0200 Jiri Pirko wrote: >> Mon, Jul 20, 2020 at 05:51:59PM CEST, kubak...@wp.pl wrote: >> >On Mon, 20 Jul 2020 12:09:53 +0200 Jiri Pirko wrote: >> >> This looks odd. You have a single image yet you somehow d

Re: [patch net-next v2] sched: sch_api: add missing rcu read lock to silence the warning

2020-07-22 Thread Jiri Pirko
Tue, Jul 21, 2020 at 08:57:45PM CEST, xiyou.wangc...@gmail.com wrote: >On Mon, Jul 20, 2020 at 1:10 AM Jiri Pirko wrote: >> diff --git a/include/linux/hashtable.h b/include/linux/hashtable.h >> index 78b6ea5fa8ba..f6c666730b8c 100644 >> --- a/include/linux/hashtable.h >> +++ b/include/linux/hashta

Re: BUG: using smp_processor_id() in preemptible code in tipc_crypto_xmit

2020-07-22 Thread syzbot
syzbot has bisected this issue to: commit e1f32190cf7ddd55778b460e7d44af3f76529698 Author: Tuong Lien Date: Fri Nov 8 05:05:12 2019 + tipc: add support for AEAD key setting via netlink bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11b738a090 start commit: 11ba4688

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Bruno Thomsen
Hi Andrew,  > > > I have been having issues with Ethernet PHY type ID > > > auto-detection when changing from the deprecated fec > > > phy-reset-{gpios,duration,post-delay} properties to the > > > modern mdio reset-{assert-us,deassert-us,gpios} > > > properties in the device tree. > > > > Kernel e

[PATCH v2] af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Mark Salyzyn
In pfkey_dump() dplen and splen can both be specified to access the xfrm_address_t structure out of bounds in__xfrm_state_filter_match() when it calls addr_match() with the indexes. Return EINVAL if either are out of range. Signed-off-by: Mark Salyzyn Cc: netdev@vger.kernel.org Cc: linux-ker...@

[PATCH] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe

2020-07-22 Thread Vikas Singh
Auto-probe of c45 devices with extended scanning in xgmac_mdio works well but fails to update device "fwnode" while registering PHYs on MDIO bus. This patch is based on https://www.spinics.net/lists/netdev/msg662173.html This change will update the "fwnode" while PHYs get registered and allow look

[PATCH 0/2] Add fwnode helper functions to MDIO bus driver

2020-07-22 Thread Vikas Singh
This patch add helper functions to handle fwnodes on MDIO bus in case of ACPI probing. These helper functions will be used in DPAA MAC driver. The patches are in below logical order: 1. Add helper function to attach MAC with PHY 2. Associate device node with fixed PHY by extending "fixed_phy_statu

[PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-07-22 Thread Vikas Singh
This patch will extend "struct fixed_phy_status" by adding new "struct device *dev" member entry in it. This change will help to handle the fixed phy registration in ACPI probe case for fwnodes. Signed-off-by: Vikas Singh --- drivers/net/phy/fixed_phy.c | 2 ++ include/linux/phy_fixed.h | 2 ++

[PATCH 1/2] net: phy: Add fwnode helper functions

2020-07-22 Thread Vikas Singh
Add support of fwnode helper functions to MDIO bus driver. 1. fwnode_phy_find_device() to find phy_device associated to a fwnod 2. fwnode_phy_connect() to attach the mac to the phy Signed-off-by: Vikas Singh --- drivers/net/phy/mdio_bus.c | 66 ++ incl

[PATCH 2/2] appletalk: Improve handling of broadcast packets

2020-07-22 Thread Vincent Duvert
When a broadcast AppleTalk packet is received, prefer queuing it on the socket whose address matches the address of the interface that received the packet (and is listening on the correct port). Userspace applications that handle such packets will usually send a response on the same socket that rec

[PATCH 1/2] appletalk: Fix atalk_proc_init return path

2020-07-22 Thread Vincent Duvert
Add a missing return statement to atalk_proc_init so it doesn't return -ENOMEM when successful. This allows the appletalk module to load properly. Signed-off-by: Vincent Duvert --- net/appletalk/atalk_proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/appletalk/atalk_proc.c b/net/a

Re: [PATCH net-next] net: phy: fix check in get_phy_c45_ids

2020-07-22 Thread Vladimir Oltean
On Mon, Jul 20, 2020 at 08:26:54PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > After the patch below, the iteration through the available MMDs is > completely short-circuited, and devs_in_pkg remains set to the initial > value of zero. > > Due to devs_in_pkg being zero, the rest of

KASAN: use-after-free Read in linkwatch_fire_event

2020-07-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:2c4dc314 net: ethernet: ti: add NETIF_F_HW_TC hw feature f.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=16a6aa4490 kernel config: https://syzkaller.appspot.com/x/.config?x=dddbcb5a9f4192db dashboar

Re: linux-next: manual merge of the bpf-next tree with the net tree

2020-07-22 Thread Jakub Sitnicki
On Wed, Jul 22, 2020 at 05:21 AM CEST, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the bpf-next tree got conflicts in: > > net/ipv4/udp.c > net/ipv6/udp.c > > between commit: > > efc6b6f6c311 ("udp: Improve load balancing for SO_REUSEPORT.") > > from the net tree and com

Netdev conf 0x14 update and logistics

2020-07-22 Thread Jamal Hadi Salim
Some logistics for Netdev 0x14 virtual conference: Netdev 0x14 virtual conference will kick off on July 28th 3PM GMT(This coming Tuesday!) with a keynote from networking industry visionary Nick McKeown. What does Nick want to talk to us about? Nick has a vision on how we can work together to rea

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2020-07-22 Thread Felix Fietkau
On 2020-07-21 23:53, Rajkumar Manoharan wrote: > On 2020-07-21 10:14, Rakesh Pillai wrote: >> NAPI instance gets scheduled on a CPU core on which >> the IRQ was triggered. The processing of rx packets >> can be CPU intensive and since NAPI cannot be moved >> to a different CPU core, to get better p

[PATCH net] enetc: Remove the mdio bus on PF probe bailout

2020-07-22 Thread Claudiu Manoil
For ENETC ports that register an external MDIO bus, the bus doesn't get removed on the error bailout path of enetc_pf_probe(). Fix this by unregistering the bus inside enetc_of_put_phy(), since enetc_of_get_phy() is were it gets registered. This issue became much more visible after recent: commit

[PATCH net-next] enetc: Remove the imdio bus on PF probe bailout

2020-07-22 Thread Claudiu Manoil
enetc_imdio_remove() is missing from the enetc_pf_probe() bailout path. Not surprisingly because enetc_setup_serdes() is registering the imdio bus for internal purposes, and it's not obvious that enetc_imdio_remove() currently performs the teardown of enetc_setup_serdes(). To fix this, define enetc

Re: [PATCH v2] selftest: txtimestamp: fix net ns entry logic

2020-07-22 Thread Willem de Bruijn
On Wed, Jul 22, 2020 at 4:37 AM Paolo Pisati wrote: > > On Tue, Jul 21, 2020 at 6:26 PM Willem de Bruijn > wrote: > > > > Fixes: cda261f421ba ("selftests: add txtimestamp kselftest") > > > > Acked-by: Willem de Bruijn > > Besides, is it just me or this test fails frequently? I've been > running

Re: [PATCH v3 2/2] net: dsa: ocelot: Add support for QinQ Operation

2020-07-22 Thread Vladimir Oltean
On Wed, Jul 22, 2020 at 06:32:00PM +0800, hongbo.w...@nxp.com wrote: > From: "hongbo.wang" > > This featue can be test using network test tools > TX-tool -> swp0 -> swp1 -> RX-tool > > TX-tool simulates Customer that will send and receive packets with single > VLAN tag(CTAG), RX

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2020-07-22 Thread Johannes Berg
On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: > I'm considering testing a different approach (with mt76 initially): > - Add a mac80211 rx function that puts processed skbs into a list > instead of handing them to the network stack directly. Would this be *after* all the mac80211 process

Re: [PATCH 0/2] Add fwnode helper functions to MDIO bus driver

2020-07-22 Thread Andrew Lunn
> *Disclaimer* -The information transmitted is intended solely for the > individual > or entity to which it is addressed and may contain confidential > and/or > privileged material. Any review, re-transmission, dissemination or > other use of > or taking action in reliance upon this information

Re: [RFC 1/7] mac80211: Add check for napi handle before WARN_ON

2020-07-22 Thread Johannes Berg
On Tue, 2020-07-21 at 22:44 +0530, Rakesh Pillai wrote: > The function ieee80211_rx_napi can be now called > from a thread context as well, with napi context > being NULL. > > Hence add the napi context check before giving out > a warning for softirq count being 0. > > Tested-on: WCN3990 hw1.0 SN

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2020-07-22 Thread Felix Fietkau
On 2020-07-22 14:55, Johannes Berg wrote: > On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: > >> I'm considering testing a different approach (with mt76 initially): >> - Add a mac80211 rx function that puts processed skbs into a list >> instead of handing them to the network stack directly

Re: [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-22 Thread Murali Karicheri
Hi Randy On 7/20/20 2:37 PM, Randy Dunlap wrote: On 7/20/20 9:57 AM, Murali Karicheri wrote: diff --git a/net/hsr/Kconfig b/net/hsr/Kconfig index 8095b034e76e..e2e396870230 100644 --- a/net/hsr/Kconfig +++ b/net/hsr/Kconfig @@ -4,24 +4,35 @@ # config HSR - tristate "High-availabil

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Andrew Lunn
Hi Bruno Is it held in reset, and the reset is released, or is the reset line toggled active and then inactive? > > void mdio_device_reset(struct mdio_device *mdiodev, int value) > > { > > unsigned int d; > > > > .. > > > > d = value ? mdiodev->reset_assert_delay : mdiodev->rese

general protection fault in udp_tunnel_notify_del_rx_port

2020-07-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:88825726 Merge tag 'drm-fixes-2020-07-17-1' of git://anong.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=143518bb10 kernel config: https://syzkaller.appspot.com/x/.config?x=a160d1053fc89af5 das

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Heiner Kallweit
On 22.07.2020 12:59, Bruno Thomsen wrote: > Hi Andrew,  > I have been having issues with Ethernet PHY type ID auto-detection when changing from the deprecated fec phy-reset-{gpios,duration,post-delay} properties to the modern mdio reset-{assert-us,deassert-us,gpios} proper

[PATCH net-next v2] cxgb4: add loopback ethtool self-test

2020-07-22 Thread Vishal Kulkarni
In this test, loopback pkt is created and sent on default queue. v2: - Add only loopback self-test. Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 8 ++ .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c| 52 + drivers/net/ethernet/chelsio/cxgb4/sge.c

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-22 Thread sundeep subbaraya
Hi David, On Wed, Jul 22, 2020 at 4:47 AM David Miller wrote: > > From: sundeep.l...@gmail.com > Date: Tue, 21 Jul 2020 22:44:05 +0530 > > > Subbaraya Sundeep (3): > > octeontx2-pf: Fix reset_task bugs > > octeontx2-pf: cancel reset_task work > > octeontx2-pf: Unregister netdev at driver re

RE: [PATCH net] enetc: Remove the mdio bus on PF probe bailout

2020-07-22 Thread Claudiu Manoil
>-Original Message- >From: netdev-ow...@vger.kernel.org On >Behalf Of Claudiu Manoil >Sent: Wednesday, July 22, 2020 3:38 PM >To: David S . Miller >Cc: netdev@vger.kernel.org >Subject: [PATCH net] enetc: Remove the mdio bus on PF probe bailout Please disregard this patch, it was backport

Re: [PATCH] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe

2020-07-22 Thread Andrew Lunn
> *Disclaimer* -The information transmitted is intended solely for the > individual or entity to which it is addressed and may contain > confidential and/or privileged material. Any review, > re-transmission, dissemination or other use of or taking action in > reliance upon this information by pers

Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-22 Thread Claudiu.Beznea
On 21.07.2020 20:13, Codrin Ciubotariu wrote: > Adding the PHY nodes directly under the Ethernet node became deprecated, > so the aim of this patch series is to make MACB use an MDIO node as > container for MDIO devices. > This patch series starts with a small patch to use the device-managed > de

Re: [RFC PATCH] net: dsa: microchip: delete dead code

2020-07-22 Thread Andrew Lunn
On Tue, Jul 21, 2020 at 10:33:01AM +0200, Helmut Grohne wrote: > None of the removed assignments is ever read back and never influences > logic. > > Signed-off-by: Helmut Grohne Hi Helmut This patch probably is correct. But it is not obviously correct, because there are so many changes at once.

[PATCH net v2] enetc: Remove the mdio bus on PF probe bailout

2020-07-22 Thread Claudiu Manoil
For ENETC ports that register an external MDIO bus, the bus doesn't get removed on the error bailout path of enetc_pf_probe(). This issue became much more visible after recent: commit 07095c025ac2 ("net: enetc: Use DT protocol information to set up the ports") Before this commit, one could make p

[net-next v5 PATCH 6/7] net: prp: add packet handling support

2020-07-22 Thread Murali Karicheri
DAN-P (Dual Attached Nodes PRP) nodes are expected to receive traditional IP packets as well as PRP (Parallel Redundancy Protocol) tagged (trailer) packets. PRP trailer is 6 bytes of PRP protocol unit called RCT, Redundancy Control Trailer (RCT) similar to HSR tag. PRP network can have traditional

[net-next v5 PATCH 7/7] net: prp: enhance debugfs to display PRP info

2020-07-22 Thread Murali Karicheri
Print PRP specific information from node table as part of debugfs node table display. Also display the node as DAN-H or DAN-P depending on the info from node table. Signed-off-by: Murali Karicheri --- net/hsr/hsr_debugfs.c | 31 ++- 1 file changed, 22 insertions(+), 9

Re: [PATCH v2 bpf-next 2/6] bpf: propagate poke descriptors to subprograms

2020-07-22 Thread Daniel Borkmann
On 7/21/20 1:53 PM, Maciej Fijalkowski wrote: Previously, there was no need for poke descriptors being present in subprogram's bpf_prog_aux struct since tailcalls were simply not allowed in them. Each subprog is JITed independently so in order to enable JITing such subprograms, simply copy poke d

Re: [PATCH net-next] net: phy: fix check in get_phy_c45_ids

2020-07-22 Thread Andrew Lunn
On Wed, Jul 22, 2020 at 02:52:09PM +0300, Vladimir Oltean wrote: > On Mon, Jul 20, 2020 at 08:26:54PM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > After the patch below, the iteration through the available MMDs is > > completely short-circuited, and devs_in_pkg remains set to t

[net-next v5 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-22 Thread Murali Karicheri
Parallel Redundancy Protocol (PRP) is another redundancy protocol introduced by IEC 63439 standard. It is similar to HSR in many aspects:- - Use a pair of Ethernet interfaces to created the PRP device - Use a 6 byte redundancy protocol part (RCT, Redundancy Check Trailer) similar to HSR Tag.

[net-next v5 PATCH 2/7] net: hsr: introduce common code for skb initialization

2020-07-22 Thread Murali Karicheri
As a preparatory patch to introduce PRP protocol support in the driver, refactor the skb init code to a separate function. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/net/

[net-next v5 PATCH 3/7] net: hsr: introduce protocol specific function pointers

2020-07-22 Thread Murali Karicheri
As a preparatory patch to introduce support for PRP protocol, add a protocol ops ptr in the private hsr structure to hold function pointers as some of the functions at protocol level packet handling is different for HSR vs PRP. It is expected that PRP will add its of set of functions for protocol h

[net-next v5 PATCH 0/7] Add PRP driver

2020-07-22 Thread Murali Karicheri
Hello, This series is dependent on the following patches sent out to netdev list. All (1-3) are already merged to net/master as of sending this, but not on the net-next master branch. So need to apply them to net-next before applying this series. v3 of the iproute2 patches can be merged to work wi

[net-next v5 PATCH 4/7] net: prp: add supervision frame generation utility function

2020-07-22 Thread Murali Karicheri
Add support for generation of PRP supervision frames. For PRP, supervision frame format is similar to HSR version 0, but have a PRP Redundancy Control Trailer (RCT) added and uses a different message type, PRP_TLV_LIFE_CHECK_DD. Also update is_supervision_frame() to include the new message type use

[net-next v5 PATCH 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames

2020-07-22 Thread Murali Karicheri
As a preparatory patch to introduce PRP, refactor the code specific to handling HSR frames into separate functions and call them through proto_ops function pointers. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 5 +++- net/hsr/hsr_forward.c | 63 +-

[PATCH v4 00/13] "Task_isolation" mode

2020-07-22 Thread Alex Belits
This is a new version of task isolation implementation. Previous version is at https://lore.kernel.org/lkml/07c25c246c55012981ec0296eee23e68c719333a.ca...@marvell.com/ Mostly this covers race conditions prevention on breaking isolation. Early after kernel entry, task_isolation_enter() is called t

[PATCH v4 01/13] task_isolation: vmstat: add quiet_vmstat_sync function

2020-07-22 Thread Alex Belits
In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when the function returned. For task isolation, we need a synchronous version of the function that guarantees t

[PATCH v4 02/13] task_isolation: vmstat: add vmstat_idle function

2020-07-22 Thread Alex Belits
From 7823be8cd3ba2e66308f334a2e47f60ba7829e0b Mon Sep 17 00:00:00 2001 From: Chris Metcalf Date: Sat, 1 Feb 2020 08:05:45 + Subject: [PATCH 02/13] task_isolation: vmstat: add vmstat_idle function This function checks to see if a vmstat worker is not running, and the vmstat diffs don't require

[PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-07-22 Thread Alex Belits
The existing nohz_full mode is designed as a "soft" isolation mode that makes tradeoffs to minimize userspace interruptions while still attempting to avoid overheads in the kernel entry/exit path, to provide 100% kernel semantics, etc. However, some applications require a "hard" commitment from th

Re: linux-next: manual merge of the bpf-next tree with the net tree

2020-07-22 Thread Kuniyuki Iwashima
From: Jakub Sitnicki Date: Wed, 22 Jul 2020 14:17:05 +0200 > On Wed, Jul 22, 2020 at 05:21 AM CEST, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the bpf-next tree got conflicts in: > > > > net/ipv4/udp.c > > net/ipv6/udp.c > > > > between commit: > > > > efc6b6

[PATCH v4 04/13] task_isolation: Add task isolation hooks to arch-independent code

2020-07-22 Thread Alex Belits
This commit adds task isolation hooks as follows: - __handle_domain_irq() and handle_domain_nmi() generate an isolation warning for the local task - irq_work_queue_on() generates an isolation warning for the remote task being interrupted for irq_work (through __smp_call_single_queue()) - g

  1   2   3   4   5   >