Re: linux-next: build failures after merge of the vfs tree

2020-06-17 Thread Herbert Xu
On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote: > > Presumably another include needed: > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function > 'kmalloc' [-Werror=implicit-function-declaration] > arch/s390/lib/test_unwind.c:99:2: error: implicit declarati

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 01:01:30AM +0200, David Sterba wrote: > > On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: > > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > > > v4: > > > > - Break out the memzero_explicit() chan

Re: linux-next: build failures after merge of the vfs tree

2020-06-17 Thread Stephen Rothwell
Hi Herbert, On Wed, 17 Jun 2020 17:03:17 +1000 Herbert Xu wrote: > > On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote: > > > > Presumably another include needed: > > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function > > 'kmalloc' [-Werror=implicit-f

Re: linux-next: build failures after merge of the vfs tree

2020-06-17 Thread Herbert Xu
On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote: > > > > > > Presumably another include needed: > > > > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function > > > 'kmalloc' [-Werror=implicit-function-declaration] > > > arch/s390/lib/test_unwind.c:99:2: e

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Jo -l
Bonjour, Désolé, aucune traduction possible, En français pour comprendre! Merci slts > Le 17 06 2020 à 02:37, Matthew Wilcox a écrit : > > On Wed, Jun 17, 2020 at 01:01:30AM +0200, David Sterba wrote: >> On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: >>> On Mon, 2020-06-15 at 21:5

Re: [net-next PATCH 1/5] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag

2020-06-17 Thread Linus Walleij
On Thu, Jun 4, 2020 at 1:23 PM Vladimir Oltean wrote: > In the code you pointed to, there is a potentially relevant comment: > > 1532//CPU tag: Realtek Ethertype==0x8899(2 bytes)+protocol==0x9(4 > MSB)+priority(2 bits)+reserved(4 bits)+portmask(6 LSB) > > https://svn.dd-wrt.com/browser/src/linux/

Re: linux-next: build failures after merge of the vfs tree

2020-06-17 Thread Stephen Rothwell
Hi Herbert, On Wed, 17 Jun 2020 17:03:17 +1000 Herbert Xu wrote: > > On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote: > > > > Presumably another include needed: > > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function > > 'kmalloc' [-Werror=implicit-f

net/dsa/microchip: correct placement of dt property phy-mode?

2020-06-17 Thread Helmut Grohne
Hi, According to Documentation/devicetree/bindings/net/dsa/dsa.txt, the phy-mode property should be specified on port nodes rather than the enclosing switch node. In drivers/net/dsa/microchip/ksz_common.c, ksz_switch_register parses the phy-mode property from the switch node instead: | int ksz_sw

[net-next PATCH 1/5 v2] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag

2020-06-17 Thread Linus Walleij
This implements the known parts of the Realtek 4 byte tag protocol version 0xA, as found in the RTL8366RB DSA switch. It is designated as protocol version 0xA as a different Realtek 4 byte tag format with protocol version 0x9 is known to exist in the Realtek RTL8306 chips. The tag and switch chip

[net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging

2020-06-17 Thread Linus Walleij
The code in net/8021q/vlan.c, vlan_device_event() sets VLAN 0 for a VLAN-capable ethernet device when it comes up. Since the RTL8366 DSA switches must have a VLAN and PVID set up for any packets to come through we have already set up default VLAN for each port as part of bringing the switch online

[net-next PATCH 3/5 v2] net: dsa: rtl8366: Split out default VLAN config

2020-06-17 Thread Linus Walleij
We loop over the ports to initialize the default VLAN and PVID for each port. As we need to reuse the code to reinitialize a single port, break out the function rtl8366_set_default_vlan_and_pvid(). Cc: DENG Qingfang Cc: Mauri Sandberg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased

[net-next PATCH 5/5 v2] net: dsa: rtl8366: Use top VLANs for default

2020-06-17 Thread Linus Walleij
The RTL8366 DSA switches will not work unless we set up a default VLAN for each port. We are currently using e.g. VLAN 1..6 for a 5-port switch as default VLANs. This is not very helpful for users, move it to allocate the top VLANs for default instead, for example on RTL8366RB there are 16 VLANs s

[net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag

2020-06-17 Thread Linus Walleij
This activates the support to use the CPU tag to properly direct ingress traffic to the right port. Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to 1 to disable the insertion of the CPU tag which is what the code currently does. The bit 15 define calls this setting RTL8368RB_CPU_INSTAG whi

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-17 Thread Roger Pau Monné
On Tue, Jun 16, 2020 at 09:49:25PM +, Anchal Agarwal wrote: > On Thu, Jun 04, 2020 at 09:05:48AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the con

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2020 at 11:36:19AM +0800, wenxu wrote: > > On 6/17/2020 4:38 AM, Pablo Neira Ayuso wrote: > > On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: > >> On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > >>> 在 2020/6/16 22:34, Simon Horman 写道: > On Tue, Jun 16, 2

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-17 Thread Roger Pau Monné
On Tue, Jun 16, 2020 at 10:30:03PM +, Anchal Agarwal wrote: > On Tue, Jun 16, 2020 at 09:49:25PM +, Anchal Agarwal wrote: > > On Thu, Jun 04, 2020 at 09:05:48AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 03, 2020 at 11:33:52PM +, Agarwal, Anchal wrote: > > > > On Tue, May 19, 2

Re: [PATCH v2 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 07:52:45AM +0300, Maxim Kochetkov wrote: > Add Marvell 88E1340 support > Signed-off-by: Maxim Kochetkov > --- > drivers/net/phy/marvell.c | 23 +++ > include/linux/marvell_phy.h | 1 + > 2 files changed, 24 insertions(+) > > diff --git a/drivers/net

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2020 at 10:42:19AM +0800, wenxu wrote: [...] > >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> index ef7f6bc..042c285 100644 > >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > >> +++ b/drivers/net/ethernet

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-06-17 Thread Jisheng Zhang
On Fri, 15 May 2020 19:30:38 +0200 Heiner Kallweit wrote: > > > On 15.05.2020 18:18, Florian Fainelli wrote: > > > > > > On 5/15/2020 12:41 AM, Jisheng Zhang wrote: > >> On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: > >> > >>> > >>> > >>> On 14.05.2020 08:25, Jisheng Zhang wrote

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
Hi Helmut, On Tue, 16 Jun 2020 at 11:00, Helmut Grohne wrote: > > The macb driver does not support configuring rgmii delays. At least for > the Zynq GEM, delays are not supported by the hardware at all. However, > the driver happily accepts and ignores any such delays. > > When operating in a mac

Re: [PATCH 4/4] Bluetooth: Add get/set device flags mgmt op

2020-06-17 Thread Marcel Holtmann
Hi Abhishek, > Add the get device flags and set device flags mgmt ops and the device > flags changed event. Their behavior is described in detail in > mgmt-api.txt in bluez. > > Sample btmon trace when a HID device is added (trimmed to 75 chars): > > @ MGMT Command: Unknown (0x0050) plen 11

Re: [PATCH v2 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-17 Thread Maxim Kochetkov
I just copied this part from another marvell PHY description. I can remove &-style reference for all marvell PHY's at next patch. 17.06.2020 11:47, Russell King - ARM Linux admin wrote: On Wed, Jun 17, 2020 at 07:52:45AM +0300, Maxim Kochetkov wrote: Add Marvell 88E1340 support Signed-off-by: M

[PATCH net 0/2] mptcp: cope with syncookie on MP_JOINs

2020-06-17 Thread Paolo Abeni
Currently syncookies on MP_JOIN connections are not handled correctly: the connections fallback to TCP and are kept alive instead of resetting them at fallback time. The first patch propagates the required information up to syn_recv_sock time, and the 2nd patch addresses the unifying the error pat

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-17 Thread wenxu
On 6/17/2020 4:38 PM, Pablo Neira Ayuso wrote: > On Wed, Jun 17, 2020 at 11:36:19AM +0800, wenxu wrote: >> On 6/17/2020 4:38 AM, Pablo Neira Ayuso wrote: >>> On Tue, Jun 16, 2020 at 05:47:17PM +0200, Simon Horman wrote: On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > 在 2020/6/16

[PATCH net 2/2] mptcp: drop MP_JOIN request sock on syn cookies

2020-06-17 Thread Paolo Abeni
Currently any MPTCP socket using syn cookies will fallback to TCP at 3rd ack time. In case of MP_JOIN requests, the RFC mandate closing the child and sockets, but the existing error paths do not handle the syncookie scenario correctly. Address the issue always forcing the child shutdown in case of

[PATCH net 1/2] mptcp: cache msk on MP_JOIN init_req

2020-06-17 Thread Paolo Abeni
The msk ownership is transferred to the child socket at 3rd ack time, so that we avoid more lookups later. If the request does not reach the 3rd ack, the MSK reference is dropped at request sock release time. As a side effect, fallback is now tracked by a NULL msk reference instead of zeroed 'mp_j

Re: [PATCH v5 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-17 Thread Marcel Holtmann
Hi Miao-chen, > This adds support for Advertisement Monitor API. Here are the commands > and events added. > - Read Advertisement Monitor Feature command > - Add Advertisement Pattern Monitor command > - Remove Advertisement Monitor command > - Advertisement Monitor Added event > - Advertisement M

Re: [PATCH v2] Bluetooth: Terminate the link if pairing is cancelled

2020-06-17 Thread Marcel Holtmann
Hi Manish, > If user decides to cancel the ongoing pairing process (e.g. by clicking > the cancel button on pairing/passkey window), abort any ongoing pairing > and then terminate the link if it was created because of the pair > device action. > > Signed-off-by: Manish Mandlik > --- > > Changes

Re: [PATCH v2] bluetooth: Adding a configurable autoconnect timeout

2020-06-17 Thread Marcel Holtmann
Hi Alain, > This patch adds a configurable LE autoconnect timeout. > > Signed-off-by: Alain Michaud > --- > > Changes in v1: > Fixing longer than 80 char line. > > include/net/bluetooth/hci_core.h | 1 + > net/bluetooth/hci_core.c | 1 + > net/bluetooth/hci_event.c| 2 +- > net

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > The macb driver does not support configuring rgmii delays. At least for > the Zynq GEM, delays are not supported by the hardware at all. However, > the driver happily accepts and ignores any such delays. > > When operating in a mac t

[PATCH bpf-next v4 3/3] bpf: add SO_KEEPALIVE and related options to bpf_setsockopt

2020-06-17 Thread Dmitry Yakunin
This patch adds support of SO_KEEPALIVE flag and TCP related options to bpf_setsockopt() routine. This is helpful if we want to enable or tune TCP keepalive for applications which don't do it in the userspace code. v2: - update kernel-doc (Nikita Vetoshkin ) Signed-off-by: Dmitry Yakunin Acked

[PATCH bpf-next v4 1/3] sock: move sock_valbool_flag to header

2020-06-17 Thread Dmitry Yakunin
This is preparation for usage in bpf_setsockopt. Signed-off-by: Dmitry Yakunin Acked-by: Martin KaFai Lau --- include/net/sock.h | 9 + net/core/sock.c| 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index c53cc42.

[PATCH bpf-next v4 2/3] tcp: expose tcp_sock_set_keepidle_locked

2020-06-17 Thread Dmitry Yakunin
This is preparation for usage in bpf_setsockopt. v2: - remove redundant EXPORT_SYMBOL (Alexei Starovoitov) Signed-off-by: Dmitry Yakunin --- include/linux/tcp.h | 1 + net/ipv4/tcp.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/tcp.h b/include/

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > Not just performance critical, but correctness critical. Since kvfree() > > may allocate from the vmalloc allocator, I really think that kvfree() > > should assert that it's !in_atom

[v2][PATCH] e1000e: continue to init phy even when failed to disable ULP

2020-06-17 Thread Aaron Ma
After commit: e086ba2fccd ("e1000e: disable s0ix entry and exit flows for ME systems"). ThinkPad P14s always failed to disable ULP by ME. commit: 0c80cdbf33 ("e1000e: Warn if disabling ULP failed") break out of init phy: error log: [ 42.364753] e1000e :00:1f.6 enp0s31f6: Failed to disable U

net-next test error: KASAN: use-after-free Write in afs_wake_up_async_call

2020-06-17 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:69119673 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=151b62f110 kernel config: https://syzkaller.appspot.com/x/.config?x=b8ad29058cb749bc das

net test error: KASAN: use-after-free Write in afs_wake_up_async_call

2020-06-17 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:69119673 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1054fc4e10 kernel config: https://syzkaller.appspot.com/x/.config?x=b8ad29058cb749bc dashboar

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
Hi Vladimir, On Wed, Jun 17, 2020 at 11:57:23AM +0200, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 11:00, Helmut Grohne wrote: > > --- a/drivers/net/ethernet/cadence/macb_main.c > > +++ b/drivers/net/ethernet/cadence/macb_main.c > > @@ -514,7 +514,7 @@ static void macb_validate(struct phylink

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
On Wed, Jun 17, 2020 at 12:55:18PM +0200, Russell King - ARM Linux admin wrote: > The individual RGMII delay modes are more about what the PHY itself is > asked to do with respect to inserting delays, so I don't think your > patch makes sense. This seems to be the same aspect that Vladimir Oltean

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > > Not just performance critical, but correctness critical. Since kvfree() > > > may allocate from the vmalloc allocator, I really

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 13:56, Russell King - ARM Linux admin wrote: > > On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > > The macb driver does not support configuring rgmii delays. At least for > > the Zynq GEM, delays are not supported by the hardware at all. However, > > the dri

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 02:32:09PM +0300, Vladimir Oltean wrote: > On Wed, 17 Jun 2020 at 13:56, Russell King - ARM Linux admin > wrote: > > > > On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > > > The macb driver does not support configuring rgmii delays. At least for > > > the Zy

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 14:34, Russell King - ARM Linux admin wrote: > > > Why are you so abrasive? > > Not responding to this until you start behaving more reasonably. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connect

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 01:21:53PM +0200, Helmut Grohne wrote: > On Wed, Jun 17, 2020 at 12:55:18PM +0200, Russell King - ARM Linux admin > wrote: > > The individual RGMII delay modes are more about what the PHY itself is > > asked to do with respect to inserting delays, so I don't think your > >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
On Wed, Jun 17, 2020 at 01:40:25PM +0200, Russell King - ARM Linux admin wrote: > > For a fixed-link, the validation function is never called. Therefore, it > > cannot reject PHY_INTERFACE_MODE_RGMII. It works in practice. > > Hmm, I'm not so sure, but then I don't know exactly what code you're >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 02:38:25PM +0300, Vladimir Oltean wrote: > On Wed, 17 Jun 2020 at 14:34, Russell King - ARM Linux admin > wrote: > > > > > > > Why are you so abrasive? > > > > Not responding to this until you start behaving more reasonably. > > > > -- > > RMK's Patch system: https://www.a

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 01:52:01PM +0200, Helmut Grohne wrote: > On Wed, Jun 17, 2020 at 01:40:25PM +0200, Russell King - ARM Linux admin > wrote: > > > For a fixed-link, the validation function is never called. Therefore, it > > > cannot reject PHY_INTERFACE_MODE_RGMII. It works in practice. > >

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Wed, Jun 17, 2020 at 01:31:57PM +0200, Michal Hocko wrote: > On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > > If you call vfree() under > > a spinlock, you're in trouble. in_atomic() only knows if we hold a > > spinlock for CONFIG_PREEMPT, so it's not safe to check for in_atomic() > > in __v

KASAN: use-after-free Read in cgroup_path_ns_locked

2020-06-17 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12ad963e10 kernel config: https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312 das

Re: 答复: [PATCH] net: Fix the arp error in some cases

2020-06-17 Thread David Ahern
On 6/16/20 9:38 PM, Guodeqing (A) wrote: > rt_set_nexthop in __mkroute_output will check the nh->nh_scope value to > determine whether to use the gw or not. > if (nh->nh_gw && nh->nh_scope == RT_SCOPE_LINK) { > rt->rt_gateway = nh->nh_gw; >

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Wed 17-06-20 05:23:21, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 01:31:57PM +0200, Michal Hocko wrote: > > On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > > > If you call vfree() under > > > a spinlock, you're in trouble. in_atomic() only knows if we hold a > > > spinlock for CONFIG_PRE

ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-17 Thread Maxim Mikityanskiy
Hi, I discovered Intel ADQ feature [1] that allows to boost performance by picking dedicated queues for application traffic. We did some research, and I got some level of understanding how it works, but I have some questions, and I hope you could answer them. 1. SO_INCOMING_NAPI_ID usage. In

Re: [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv

2020-06-17 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc1 next-20200616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option t

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Nicolas Ferre
On 16/06/2020 at 09:49, Helmut Grohne wrote: The macb driver does not support configuring rgmii delays. At least for the Zynq GEM, delays are not supported by the hardware at all. However, the driver happily accepts and ignores any such delays. When operating in a mac to phy connection, the dela

qmi_wwan not using netif_carrier_*()

2020-06-17 Thread Tanjeff-Nicolai Moos
Hi netdevs, Kernel version: I'm working with kernel 4.14.137 (OpenWRT project). But I looked at the source of kernel 5.7 and found the same situation. Problem: I'm using the qmi_wwan driver for a Sierra Wireless EM7455 LTE modem. This driver does not use netif_carrier_on()/netif_carri

[PATCH net-next v2 0/8] net: phy: mscc: PHC and timestamping support

2020-06-17 Thread Antoine Tenart
Hello, This series aims at adding support for PHC and timestamping operations in the MSCC PHY driver, for the VSC858x and VSC8575. Those PHYs are capable of timestamping in 1-step and 2-step for both L2 and L4 traffic. As of this series, only IPv4 support was implemented when using L4 mode. This

[PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC support

2020-06-17 Thread Antoine Tenart
This patch adds support for PHC and timestamping operations for the MSCC PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP. To get and set the PHC time, a GPIO has to be used and changes are only retrieved or committed when on a rising edge. The same GPIO is shared by all PHYs,

[PATCH net-next v2 8/8] MIPS: dts: ocelot: describe the load/save GPIO

2020-06-17 Thread Antoine Tenart
From: Quentin Schulz This patch adds a description of the load/save GPIN pin, used in the VSC8584 PHY for timestamping operations. The related pinctrl description is also added. Signed-off-by: Quentin Schulz Signed-off-by: Antoine Tenart --- arch/mips/boot/dts/mscc/ocelot_pcb120.dts | 12

[PATCH net-next v2 2/8] net: phy: mscc: fix copyright and author information in MACsec

2020-06-17 Thread Antoine Tenart
All headers in the MSCC PHY driver have been copied and pasted from the original mscc.c file. However the information is not necessarily correct, as in the MACsec support. Fix this. Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_fc_buffer.h | 2 +- drivers/net/phy/mscc/mscc_mac.h

[PATCH net-next v2 5/8] net: phy: mscc: 1588 block initialization

2020-06-17 Thread Antoine Tenart
From: Quentin Schulz This patch adds the first parts of the 1588 support in the MSCC PHY, with registers definition and the 1588 block initialization. Those PHYs are distributed in hardware packages containing multiple times the PHY. The VSC8584 for example is composed of 4 PHYs. With hardware p

[PATCH net-next v2 1/8] net: phy: add support for a common probe between shared PHYs

2020-06-17 Thread Antoine Tenart
Shared PHYs (PHYs in the same hardware package) may have shared registers and their drivers would usually need to share information. There is currently a way to have a shared (part of the) init, by using phy_package_init_once(). This patch extends the logic to share parts of the probe to allow shar

[PATCH net-next v2 7/8] dt-bindings: net: phy: vsc8531: document the load/save GPIO

2020-06-17 Thread Antoine Tenart
A new optional property can be used to reference the load/save GPIO, used for PTP hardware clock (PHC) operations. This patch documents it in the binding documentation. Signed-off-by: Antoine Tenart --- Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++ 1 file changed, 3 inserti

[PATCH net-next v2 3/8] net: phy: mscc: remove the TR CLK disable magic value

2020-06-17 Thread Antoine Tenart
From: Quentin Schulz This patch adds a define for the 0x8000 magic value used to perform enable/disable actions on the "token ring clock". The patch is only cosmetic. Signed-off-by: Quentin Schulz Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc.h | 1 + drivers/net/phy/mscc/

[PATCH net-next v2 4/8] net: phy: mscc: take into account the 1588 block in MACsec init

2020-06-17 Thread Antoine Tenart
This patch takes in account the use of the 1588 block in the MACsec initialization, as a conditional configuration has to be done (when the 1588 block is used). Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_macsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --g

RE: [PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-17 Thread David Laight
From: Jeremy Kerr > Sent: 15 June 2020 03:55 While you are looking as this driver you might want to worry about what it sets skp->truesize to. > --- a/drivers/net/usb/ax88179_178a.c > +++ b/drivers/net/usb/ax88179_178a.c > @@ -1414,10 +1414,10 @@ static int ax88179_rx_fixup(struct usbnet *dev, >

[PATCH net 1/2] s390/qeth: fix error handling for isolation mode cmds

2020-06-17 Thread Julian Wiedmann
Current(?) OSA devices also store their cmd-specific return codes for SET_ACCESS_CONTROL cmds into the top-level cmd->hdr.return_code. So once we added stricter checking for the top-level field a while ago, none of the error logic that rolls back the user's configuration to its old state is applied

[PATCH net 0/2] s390/qeth: fixes 2020-06-17

2020-06-17 Thread Julian Wiedmann
Hi Dave & Jakub, please apply the following patch series for qeth to netdev's net tree. The first patch fixes a regression in the error handling for a specific cmd type. I have some follow-ups queued up for net-next to clean this up properly... The second patch fine-tunes the HW offload restrict

[PATCH net 2/2] s390/qeth: let isolation mode override HW offload restrictions

2020-06-17 Thread Julian Wiedmann
When a device is configured with ISOLATION_MODE_FWD, traffic never goes through the internal switch. Don't apply the offload restrictions in this case. Fixes: c619e9a6f52f ("s390/qeth: don't use restricted offloads for local traffic") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_cor

bpf-next is OPEN

2020-06-17 Thread Alexei Starovoitov

RE: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-17 Thread David Laight
From: Kees Cook > Sent: 16 June 2020 04:25 > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a > wrapper named fd_install_receiv

Dobrý deň pán / pani,

2020-06-17 Thread Hassan clement
Dobrý deň pán / pani, E-mail, ktorý ste dostali, bol špecificky adresovaný vám. Vaša e-mailová adresa bola náhodne vybraná zo Spojených štátov amerických pre kompenzačné velenie v spojení s Medzinárodným trestným súdom (ICC) spolu s BTCI BANK LOME TOGO, kde vaša platba tristo tisíc dolárov ( 300 00

[PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Dejin Zheng
Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() to simplify the code") will print a lot of logs as follows when Ethernet cable is not connected: [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: lan87xx_read_status failed: -110 So fix it by read_poll_timeout(). Fixe

RE: [PATCH v4 03/11] fs: Add fd_install_received() wrapper for __fd_install_received()

2020-06-17 Thread David Laight
From: Kees Cook > Sent: 16 June 2020 04:25 > > For both pidfd and seccomp, the __user pointer is not used. Update > __fd_install_received() to make writing to ufd optional. (ufd > itself cannot checked for NULL because this changes the SCM_RIGHTS > interface behavior.) In these cases, the new fd n

Re: [PATCH bpf 2/2] selftests/bpf: add variable-length data concatenation pattern test

2020-06-17 Thread Daniel Borkmann
On 6/17/20 1:14 AM, Andrii Nakryiko wrote: On Tue, Jun 16, 2020 at 3:23 PM Daniel Borkmann wrote: On 6/16/20 11:27 PM, Andrii Nakryiko wrote: On Tue, Jun 16, 2020 at 1:21 PM Daniel Borkmann wrote: On 6/16/20 7:04 AM, Andrii Nakryiko wrote: Add selftest that validates variable-length data re

Re: [net-next v2] tipc: update a binding service via broadcast

2020-06-17 Thread David Miller
From: Hoang Huu Le Date: Wed, 17 Jun 2020 13:56:05 +0700 > Currently, updating binding table (add service binding to > name table/withdraw a service binding) is being sent over replicast. > However, if we are scaling up clusters to > 100 nodes/containers this > method is less affection because of

[PATCH bpf-next] libbpf: bump version to 0.0.10

2020-06-17 Thread Andrii Nakryiko
Let's start new cycle with another libbpf version bump. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.map | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map index f732c77b7ed0..3b37b8867cec 100644 --- a/tools/lib/bpf/libbpf.map ++

Re: [PATCH bpf-next] libbpf: bump version to 0.0.10

2020-06-17 Thread Alexei Starovoitov
On Wed, Jun 17, 2020 at 8:59 AM Andrii Nakryiko wrote: > > Let's start new cycle with another libbpf version bump. > > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/libbpf.map | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map >

Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 01:36:27 +0800 Xin Long wrote: > This patch is to register a callback function tunnel4_rcv_cb with > is_ipip set in a xfrm_input_afinfo object for tunnel4 and tunnel64. > > It will be called by xfrm_rcv_cb() from xfrm_input() when family > is AF_INET and proto is IPPROTO_IPIP o

Re: [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 01:36:28 +0800 Xin Long wrote: > This patch is to register a callback function tunnel6_rcv_cb with > is_ipip set in a xfrm_input_afinfo object for tunnel6 and tunnel46. > > It will be called by xfrm_rcv_cb() from xfrm_input() when family > is AF_INET6 and proto is IPPROTO_IPIP

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2020 at 11:33:40PM +0800, Dejin Zheng wrote: > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > to simplify the code") will print a lot of logs as follows when Ethernet > cable is not connected: > > [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: >

Re: [PATCH bpf-next] libbpf: bump version to 0.0.10

2020-06-17 Thread Andrii Nakryiko
On Wed, Jun 17, 2020 at 9:18 AM Alexei Starovoitov wrote: > > On Wed, Jun 17, 2020 at 8:59 AM Andrii Nakryiko wrote: > > > > Let's start new cycle with another libbpf version bump. > > > > Signed-off-by: Andrii Nakryiko > > --- > > tools/lib/bpf/libbpf.map | 3 +++ > > 1 file changed, 3 inserti

Re: [PATCH net v2] bareudp: Fixed multiproto mode configuration

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 10:01:39 +0530 Martin Varghese wrote: > From: Martin > > Code to handle multiproto configuration is missing. > > Signed-off-by: Martin No Fixes tag on this one?

Re: [PATCH net-next 3/5] cxgb4: add support to flash boot image

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 11:59:05 +0530 Vishal Kulkarni wrote: > Update set_flash to flash boot image to flash region > > Signed-off-by: Vishal Kulkarni This patch adds 4 new warnings to the plethora of warnings in drivers/net/ethernet/chelsio/cxgb4/t4_hw.c when built with W=1 C=1 flags. Please don'

Re: [PATCH AUTOSEL 5.7 264/274] vxlan: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-17 Thread Sasha Levin
On Tue, Jun 09, 2020 at 09:55:48AM +0300, Ido Schimmel wrote: On Mon, Jun 08, 2020 at 07:05:57PM -0400, Sasha Levin wrote: From: Ido Schimmel [ Upstream commit 8066e6b449e050675df48e7c4b16c29f00507ff0 ] Hi, In the same patch set I also included a similar fix for the bridge module: https://g

Re: [v2][PATCH] e1000e: continue to init phy even when failed to disable ULP

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 19:12:48 +0800 Aaron Ma wrote: > After commit: e086ba2fccd ("e1000e: disable s0ix entry and exit flows > for ME systems"). > ThinkPad P14s always failed to disable ULP by ME. > commit: 0c80cdbf33 ("e1000e: Warn if disabling ULP failed") > break out of init phy: > > error log:

Re: [PATCH] net: macb: undo operations in case of failure

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 16:23:55 +0300 Claudiu Beznea wrote: > Undo previously done operation in case macb_phylink_connect() > fails. Since macb_reset_hw() is the 1st undo operation the > napi_exit label was renamed to reset_hw. > > Fixes: b2b041417299 ("net: macb: convert to phylink") > Signed-off-by

Re: [PATCH net-next v2 5/8] net: phy: mscc: 1588 block initialization

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 15:31:24 +0200 Antoine Tenart wrote: > +/* Two PHYs share the same 1588 processor and it's to be entirely configured > + * through the base PHY of this processor. > + */ > +/* phydev->bus->mdio_lock should be locked when using this function */ > +static inline int phy_ts_base_wr

Re: [PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC support

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 15:31:25 +0200 Antoine Tenart wrote: > This patch adds support for PHC and timestamping operations for the MSCC > PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP. > > To get and set the PHC time, a GPIO has to be used and changes are only > retrieved or co

Re: qmi_wwan not using netif_carrier_*()

2020-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2020 at 03:21:53PM +0200, Tanjeff-Nicolai Moos wrote: > Hi netdevs, > > Kernel version: > > I'm working with kernel 4.14.137 (OpenWRT project). But I looked at > the source of kernel 5.7 and found the same situation. > > Problem: > > I'm using the qmi_wwan driver for a Sie

[PATCH net v4 1/4] flow_offload: add flow_indr_block_cb_alloc/remove function

2020-06-17 Thread wenxu
From: wenxu Add flow_indr_block_cb_alloc/remove function prepare for the bug fix in the third patch. Signed-off-by: wenxu --- include/net/flow_offload.h | 13 + net/core/flow_offload.c| 43 --- 2 files changed, 45 insertions(+), 11 deleti

[PATCH net v4 3/4] net: flow_offload: fix flow_indr_dev_unregister path

2020-06-17 Thread wenxu
From: wenxu If the representor is removed, then identify the indirect flow_blocks that need to be removed by the release callback and the port representor structure. To identify the port representor structure, a new indr.cb_priv field needs to be introduced. The flow_block also needs to be remove

[PATCH net v4 0/4] several fixes for indirect flow_blocks offload

2020-06-17 Thread wenxu
From: wenxu v2: patch2: store the cb_priv of representor to the flow_block_cb->indr.cb_priv in the driver. And make the correct check with the statments this->indr.cb_priv == cb_priv patch4: del the driver list only in the indriect cleanup callbacks v3: add the cover letter and changlogs. v4:

[PATCH net v4 2/4] flow_offload: use flow_indr_block_cb_alloc/remove function

2020-06-17 Thread wenxu
From: wenxu Prepare fix the bug in the next patch. use flow_indr_block_cb_alloc/remove function and remove the __flow_block_indr_binding. Signed-off-by: wenxu --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 19 --- .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c| 2

[PATCH net v4 4/4] net/sched: cls_api: fix nooffloaddevcnt warning dmesg log

2020-06-17 Thread wenxu
From: wenxu The block->nooffloaddevcnt should always count for indr block. even the indr block offload successful. The representor maybe gone away and the ingress qdisc can work in software mode. block->nooffloaddevcnt warning with following dmesg log: [ 760.667058] ###

Re: qmi_wwan not using netif_carrier_*()

2020-06-17 Thread Dan Williams
On Wed, 2020-06-17 at 18:48 +0200, Andrew Lunn wrote: > On Wed, Jun 17, 2020 at 03:21:53PM +0200, Tanjeff-Nicolai Moos wrote: > > Hi netdevs, > > > > Kernel version: > > > > I'm working with kernel 4.14.137 (OpenWRT project). But I looked > > at > > the source of kernel 5.7 and found the same

[PATCH net v3] bareudp: Fixed multiproto mode configuration

2020-06-17 Thread Martin Varghese
From: Martin Code to handle multiproto configuration is missing. Fixes: 4b5f67232d95 ("net: Special handling for IP & MPLS") Signed-off-by: Martin --- Changes in v2: - Initialization of conf structure is removed as that change is included in another patch. Changes in v3: - Fix

Re: [PATCH bpf] xdp: handle frame_sz in xdp_convert_zc_to_xdp_frame()

2020-06-17 Thread Alexei Starovoitov
On Tue, Jun 16, 2020 at 11:03 PM John Fastabend wrote: > > Jesper Dangaard Brouer wrote: > > On Tue, 16 Jun 2020 18:35:18 +0800 > > Hangbin Liu wrote: > > > > > In commit 34cc0b338a61 we only handled the frame_sz in > > > convert_to_xdp_frame(). > > > This patch will also handle frame_sz in xdp_

Re: [PATCH net v2] bareudp: Fixed multiproto mode configuration

2020-06-17 Thread Martin Varghese
On Wed, Jun 17, 2020 at 09:21:37AM -0700, Jakub Kicinski wrote: > On Wed, 17 Jun 2020 10:01:39 +0530 Martin Varghese wrote: > > From: Martin > > > > Code to handle multiproto configuration is missing. > > > > Signed-off-by: Martin > > No Fixes tag on this one? Missed. Updated version sent wit

Re: [PATCH bpf] devmap: use bpf_map_area_alloc() for allocating hash buckets

2020-06-17 Thread Alexei Starovoitov
On Tue, Jun 16, 2020 at 11:07 PM John Fastabend wrote: > > Toke Høiland-Jørgensen wrote: > > Syzkaller discovered that creating a hash of type devmap_hash with a large > > number of entries can hit the memory allocator limit for allocating > > contiguous memory regions. There's really no reason to

Re: [PATCH bpf v5 1/3] bpf: don't return EINVAL from {get,set}sockopt when optlen > PAGE_SIZE

2020-06-17 Thread Alexei Starovoitov
On Tue, Jun 16, 2020 at 06:04:14PM -0700, Stanislav Fomichev wrote: > Attaching to these hooks can break iptables because its optval is > usually quite big, or at least bigger than the current PAGE_SIZE limit. > David also mentioned some SCTP options can be big (around 256k). > > For such optvals

  1   2   3   4   >