Re: [v3 PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-15 Thread Christoph Hellwig
On Fri, Jun 12, 2020 at 04:57:37PM +1000, Herbert Xu wrote: > The header file linux/uio.h includes crypto/hash.h which pulls in > most of the Crypto API. Since linux/uio.h is used throughout the > kernel this means that every tiny bit of change to the Crypto API > causes the entire kernel to get r

Re: [PATCH] proc: Use new_inode not new_inode_pseudo

2020-06-15 Thread Jan Kara
On Fri 12-06-20 14:15:51, Eric W. Biederman wrote: > > Recently syzbot reported that unmounting proc when there is an ongoing > inotify watch on the root directory of proc could result in a use > after free when the watch is removed after the unmount of proc > when the watcher exits. > > Commit 6

[PATCH net] net/rds: NULL pointer de-reference in rds_ib_add_one()

2020-06-15 Thread Ka-Cheong Poon
The parent field of a struct device may be NULL. The macro ibdev_to_node() should check for that. Signed-off-by: Ka-Cheong Poon --- net/rds/ib.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/rds/ib.h b/net/rds/ib.h index 5ae069d..8dfff43 100644 --- a/net/rds/ib.

Re: [PATCH/RFC] net: ethernet: ravb: Try to wake subqueue instead of stop on timeout

2020-06-15 Thread Sergei Shtylyov
Hello! On 15.06.2020 8:58, Yoshihiro Shimoda wrote: From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM According to the report of [1], this driver is possible to cause the following error in ravb_tx_timeout_work(). ravb e680.ethernet ethernet: failed to switch device to config m

Re: [PATCH] MAINTAINERS: switch to my private email for Renesas Ethernet drivers

2020-06-15 Thread Geert Uytterhoeven
Hi Sergei, On Sat, Jun 13, 2020 at 10:59 PM Sergei Shtylyov wrote: > Subject: MAINTAINERS: switch to my private email for Renesas Ethernet drivers > > I no longer work for Cogent Embedded (but my old email still works :-)), > and still would like to continue looking after the Renesas Ethernet dri

[PATCH ipsec] xfrm: policy: match with both mark and mask on user interfaces

2020-06-15 Thread Xin Long
In commit ed17b8d377ea ("xfrm: fix a warning in xfrm_policy_insert_list"), it would take 'priority' to make a policy unique, and allow duplicated policies with different 'priority' to be added, which is not expected by userland, as Tobias reported in strongswan. To fix this duplicated policies iss

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Thomas Bogendoerfer
On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: > > ./scripts/documentation-file-ref-check > > in order to solve those issues while submitting patches. > This tool can eve

[PATCH] net: axienet: fix spelling mistake in comment "Exteneded" -> "extended"

2020-06-15 Thread Colin King
From: Colin Ian King There is a spelling mistake in a comment. Fix it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/

Re: [PATCH v3 0/2] Fixing memory leaks in perf events parser

2020-06-15 Thread Markus Elfring
> fix some memleaks in parse_events_term__sym_hw and parse_events_term__clone. Can it be more appropriate to refer to the term “memory leak” in consistent ways? > v1 ==> v2 > 1. split into two patches Corresponding development consequences can become more interesting. > v2 ==> v3 > add more

[PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR

2020-06-15 Thread Geliang Tang
We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate macro. Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface") Signed-off-by: Geliang Tang --- Changes in v2: - change Subject from "mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX" --- net/mptcp/protocol.h | 2 -

[PATCH net-next v2] mptcp: use list_first_entry_or_null

2020-06-15 Thread Geliang Tang
Use list_first_entry_or_null to simplify the code. Signed-off-by: Geliang Tang --- Changes in v2: - Add "net-next" tag in Subject. --- net/mptcp/protocol.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 70ed698bd206..d

Re: [PATCH v3 1/2] perf tools: Fix potential memory leaks in perf events parser

2020-06-15 Thread Markus Elfring
> Fix memory leak of in function parse_events_term__sym_hw() > and parse_events_term__clone() when string duplication failed. Can a wording like “Fix memory leaks in …” be more appropriate for the final commit message? Would you find any other description variant more pleasing? Regards, Markus

Re: [PATCH] mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX

2020-06-15 Thread Geliang Tang
On Fri, Jun 12, 2020 at 07:33:11PM +0200, Matthieu Baerts wrote: > Hi Geliang, > > On 12/06/2020 07:27, Geliang Tang wrote: > > Unify these two duplicate macros into 8. > > Thank you for this new patch! > > (...) > > > diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h > > index 809687d3f

Re: [PATCH] mptcp: use list_first_entry_or_null

2020-06-15 Thread Geliang Tang
On Fri, Jun 12, 2020 at 11:22:31AM -0700, Mat Martineau wrote: > > Hello Geliang, > > On Fri, 12 Jun 2020, Geliang Tang wrote: > > > Use list_first_entry_or_null to simplify the code. > > > > Signed-off-by: Geliang Tang > > --- > > net/mptcp/protocol.h | 5 + > > 1 file changed, 1 insertion

Re: [PATCH v3 2/2] perf tools: Fix potential memory leaks in perf events parser

2020-06-15 Thread Markus Elfring
> Fix potential memory leak. Function new_term may return error, so > it is need to free memory when the return value is negative. I hope that a typo will be avoided for the final commit message. Would you find any other description variant more pleasing? Regards, Markus

Re: [PATCH] net: axienet: fix spelling mistake in comment "Exteneded" -> "extended"

2020-06-15 Thread Michal Simek
On 15. 06. 20 10:29, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a comment. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ether

[PATCH] qlcnic: Use kobj_to_dev() instead

2020-06-15 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 34 +++ 1 file changed, 17 insertions(+), 17 deletions(-) mode change 100644 => 100755 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c diff --git a

Re: [RFC PATCH bpf-next 8/8] tools/bpftool: show PIDs with FDs open against BPF map/prog/link/btf

2020-06-15 Thread Toke Høiland-Jørgensen
Arnaldo Carvalho de Melo writes: > Em Fri, Jun 12, 2020 at 10:57:59PM -0700, Andrii Nakryiko escreveu: >> On Fri, Jun 12, 2020 at 8:45 PM Alexei Starovoitov >> wrote: >> > >> > On Fri, Jun 12, 2020 at 03:31:50PM -0700, Andrii Nakryiko wrote: >> > > Add bpf_iter-based way to find all the processe

Re: [PATCH 1/1] mvpp2: ethtool rxtx stats fix

2020-06-15 Thread Sven Auhagen
On Mon, Jun 15, 2020 at 12:23:20AM +, Matteo Croce wrote: > On Sun, Jun 14, 2020 at 7:19 AM Sven Auhagen > wrote: > > > > The ethtool rx and tx queue statistics are reporting wrong values. > > Fix reading out the correct ones. > > > > Signed-off-by: Sven Auhagen > > Hi Sven, > > seems to w

Re: [PATCH 1/1] mvneta: fix prefetch location

2020-06-15 Thread Sven Auhagen
On Sun, Jun 14, 2020 at 10:23:43AM +0200, Jesper Dangaard Brouer wrote: > On Sun, 14 Jun 2020 09:11:28 +0200 > Sven Auhagen wrote: > > > The packet header prefetch is at an offset > > now. Correct the prefetch address. > > > > Signed-off-by: Sven Auhagen > > --- > > drivers/net/ethernet/marvel

Re: [RFC PATCH bpf-next 8/8] tools/bpftool: show PIDs with FDs open against BPF map/prog/link/btf

2020-06-15 Thread Quentin Monnet
2020-06-15 11:04 UTC+0200 ~ Toke Høiland-Jørgensen > Arnaldo Carvalho de Melo writes: > >> Em Fri, Jun 12, 2020 at 10:57:59PM -0700, Andrii Nakryiko escreveu: >>> On Fri, Jun 12, 2020 at 8:45 PM Alexei Starovoitov >>> wrote: On Fri, Jun 12, 2020 at 03:31:50PM -0700, Andrii Nakryiko wr

Re: [PATCH ipsec] xfrm: policy: match with both mark and mask on user interfaces

2020-06-15 Thread Tobias Brunner
Hi Xin, > To fix this duplicated policies issue, and also fix the issue in > commit ed17b8d377ea ("xfrm: fix a warning in xfrm_policy_insert_list"), > when doing add/del/get/update on user interfaces, this patch is to change > to look up a policy with both mark and mask by doing: > > mark.v ==

Re: [REGRESSION] mlx5: Driver remove during hot unplug is broken

2020-06-15 Thread Niklas Schnelle
Hello Saeed, On 6/13/20 12:01 AM, Saeed Mahameed wrote: > On Fri, 2020-06-12 at 15:09 +0200, Niklas Schnelle wrote: >> Hello Parav, Hello Saeed, >> ... snip ... >> >> So without really knowing anything about these functions I would >> guess that with the device still registered the drained >> queu

Re: [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR

2020-06-15 Thread Matthieu Baerts
Hi Geliang, On 15/06/2020 10:28, Geliang Tang wrote: We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate macro. Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface") Signed-off-by: Geliang Tang --- Changes in v2: - change Subject from "mptcp: unify MPTCP_PM_MAX_A

Re: [PATCH net v2 1/4] flow_offload: fix incorrect cleanup for indirect flow_blocks

2020-06-15 Thread Vlad Buslov
On Sat 13 Jun 2020 at 12:25, we...@ucloud.cn wrote: > From: wenxu > > If the representor is removed, then identify the indirect > flow_blocks that need to be removed by the release callback. > > Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block > infrastructure") > Signed-o

Re: Good idea to rename files in include/uapi/ ?

2020-06-15 Thread Geert Uytterhoeven
Hi Alexander, On Mon, Jun 15, 2020 at 1:11 AM Alexander A. Klimov wrote: > Am 14.06.20 um 22:34 schrieb Stefano Brivio: > > On Sun, 14 Jun 2020 21:41:17 +0200 > >> Also even on a case-sensitive one VIm seems to have trouble with editing > >> both case-insensitively equal files at the same time. >

Re: Good idea to rename files in include/uapi/ ?

2020-06-15 Thread Geert Uytterhoeven
Hi Alexander, On Sun, Jun 14, 2020 at 9:44 PM Alexander A. Klimov wrote: > *Is it a good idea to rename files in include/uapi/ ?* No it is not: include/uapi/ is append-only. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@l

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: I also previously acked this one in 20200504100822.ga5...@sirena.org.uk. Has anything changed here to cause the ack to be dropped?

Re: [(RFC) PATCH ] NULL pointer dereference on rmmod iptable_mangle.

2020-06-15 Thread Florian Westphal
Florian Westphal wrote: > dwilder wrote: > > > Since the netns core already does an unconditional synchronize_rcu after > > > the pre_exit hooks this would avoid the problem as well. > > > > Something like this? (un-tested) > > Yes. > > > diff --git a/net/ipv4/netfilter/iptable_mangle.c > > b

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mauro Carvalho Chehab
Hi Mark, Em Mon, 15 Jun 2020 12:19:27 +0100 Mark Brown escreveu: > On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > > There are some new broken doc links due to yaml renames > > at DT. Developers should really run: > > I also previously acked this one in 20200504100822

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 01:57:39PM +0200, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > > > There are some new broken doc links due to yaml renames > > > at DT. Developers should really run: > > I also previously

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk wrote: > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > What kind of testing? 100GiB? Low latency? > Hi Konrad. I tested this version of the patch: htt

Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE

2020-06-15 Thread Chuck Lever
> On Jun 15, 2020, at 2:25 AM, Christophe Leroy > wrote: > > Even if that's only a warning, not including asm/cacheflush.h > leads to svc_flush_bvec() being empty allthough powerpc defines > ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE. > > CC net/sunrpc/svcsock.o > net/sunrpc/svcsock.c:227:5: wa

Re: [PATCH net] net: dsa: sja1105: fix PTP timestamping with large tc-taprio cycles

2020-06-15 Thread Richard Cochran
On Sun, Jun 14, 2020 at 11:54:09PM +0300, Vladimir Oltean wrote: > So fix this case of premature optimization by simply reordering the > sja1105_ptpegr_ts_poll and the sja1105_ptpclkval_read function calls. It > turns out that in practice, the 135 ms hard deadline for PTP timestamp > wraparound is

[PATCH 3/4] thunderbolt: NHI can use HopIDs 1-7

2020-06-15 Thread Mika Westerberg
NHI (The host interface adapter) is allowed to use HopIDs 1-7 as well so relax the restriction in tb_port_alloc_hopid() to support this. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/switch.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/

[PATCH 1/4] thunderbolt: Build initial XDomain property block upon first connect

2020-06-15 Thread Mika Westerberg
On a systems where the Thunderbolt controller is present all the time the kernel nodename may not yet set by the userspace when the driver is loaded. This means when another host is connected it may see the default "(none)" hostname instead of the system real hostname. For this reason build the in

[PATCH 2/4] thunderbolt: No need to warn if NHI hop_count != 12 or hop_count != 32

2020-06-15 Thread Mika Westerberg
While Intel hardware typically has hop_count (Total Paths in the spec) 12 the USB4 spec allows this to be anything between 1 and 21 so no need to warn about this. Simply log number of paths at debug level. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/nhi.c | 4 +--- 1 file changed, 1 i

[PATCH 0/4] thunderbolt: XDomain and NHI improvements

2020-06-15 Thread Mika Westerberg
Hi, This small series improves the "data" path handling when doing host-to-host connections over TBT/USB4 cable. First patch delays setting nodename upon first connect to allow the userspace to fill in host name. Rest of the series deal with the NHI (TBT/USB4 host interface) HopID allocation so th

[PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Mika Westerberg
The end-to-end (E2E) workaround is needed for Falcon Ridge (TBT 2) controller when E2E is enabled for both ends of the host-to-host connection. However, we never supported full E2E in the first place so this code is not necessary at the moment. Further this allows us to use all available rings for

Re: BUG: kernel NULL pointer dereference in __cgroup_bpf_run_filter_skb

2020-06-15 Thread Daniël Sonck
Op zo 14 jun. 2020 om 22:43 schreef Daniël Sonck : > > Hello, > > Op zo 14 jun. 2020 om 20:29 schreef Cong Wang : > > > > Hello, > > > > On Sun, Jun 14, 2020 at 5:39 AM Daniël Sonck wrote: > > > > > > Hello, > > > > > > I found on the archive that this bug I encountered also happened to > > > othe

[PATCH] net: macb: Only disable NAPI on the actual error path

2020-06-15 Thread Charles Keepax
A recent change added a disable to NAPI into macb_open, this was intended to only happen on the error path but accidentally applies to all paths. This causes NAPI to be disabled on the success path, which leads to the network to no longer functioning. Fixes: 014406babc1f ("net: cadence: macb: disa

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg wrote: > > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h > index ff397c0d5c07..5db2b11ab085 100644 > --- a/include/linux/thunderbolt.h > +++ b/include/linux/thunderbolt.h > @@ -504,8 +504,6 @@ struct tb_ring { > #define RING

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Greg Kroah-Hartman
On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg > wrote: > > > > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h > > index ff397c0d5c07..5db2b11ab085 100644 > > --- a/include/linux/thunderbolt.h > > +++ b/inc

Re: [PATCH net 1/2] net/sched: act_ct: Make tcf_ct_flow_table_restore_skb inline

2020-06-15 Thread Marcelo Ricardo Leitner
On Sun, Jun 14, 2020 at 02:12:48PM +0300, Roi Dayan wrote: > From: Alaa Hleihel > > Currently, tcf_ct_flow_table_restore_skb is exported by act_ct > module, therefore modules using it will have hard-dependency > on act_ct and will require loading it all the time. > > This can lead to an unnecess

Re: [v3 PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-15 Thread Al Viro
On Fri, Jun 12, 2020 at 04:57:37PM +1000, Herbert Xu wrote: > The header file linux/uio.h includes crypto/hash.h which pulls in > most of the Crypto API. Since linux/uio.h is used throughout the > kernel this means that every tiny bit of change to the Crypto API > causes the entire kernel to get r

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman wrote: > > On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg > > wrote: > > > > > > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h > > > index ff397c0d5c07

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Mika Westerberg
On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wrote: > On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > > > On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg > > > wrote: > > > > > > > > diff --git a/i

Re: [PATCH net 2/2] netfilter: flowtable: Make nf_flow_table_offload_add/del_cb inline

2020-06-15 Thread Marcelo Ricardo Leitner
On Sun, Jun 14, 2020 at 02:12:49PM +0300, Roi Dayan wrote: > From: Alaa Hleihel > > Currently, nf_flow_table_offload_add/del_cb are exported by nf_flow_table > module, therefore modules using them will have hard-dependency > on nf_flow_table and will require loading it all the time. > > This can

Re: [PATCH] ath10k: Wait until copy complete is actually done before completing

2020-06-15 Thread Kalle Valo
Douglas Anderson wrote: > On wcn3990 we have "per_ce_irq = true". That makes the > ath10k_ce_interrupt_summary() function always return 0xfff. The > ath10k_ce_per_engine_service_any() function will see this and think > that _all_ copy engines have an interrupt. Without checking, the > ath10k_ce

[PATCH] ipvs: avoid drop first packet by reusing conntrack

2020-06-15 Thread YangYuxi
Since 'commit f719e3754ee2 ("ipvs: drop first packet to redirect conntrack")', when a new TCP connection meet the conditions that need reschedule, the first syn packet is dropped, this cause one second latency for the new connection, more discussion about this problem can easy search from google, s

Re: [PATCH] ath10k: Wait until copy complete is actually done before completing

2020-06-15 Thread Doug Anderson
Hi, On Mon, Jun 15, 2020 at 7:32 AM Kalle Valo wrote: > > Douglas Anderson wrote: > > > On wcn3990 we have "per_ce_irq = true". That makes the > > ath10k_ce_interrupt_summary() function always return 0xfff. The > > ath10k_ce_per_engine_service_any() function will see this and think > > that _al

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-15 Thread Lorenz Bauer
On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov wrote: > > On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > > > Using BPF_PROG_ATTACH on a flow dissector program supports neither flags > > nor target_fd but accepts any value. Return EINVAL if either are non-zero. > > > > Signed-off-by: Lo

[PATCH v3 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-15 Thread Heiko Stuebner
From: Heiko Stuebner At least VSC8530/8531/8540/8541 contain a clock output that can emit a predefined rate of 25, 50 or 125MHz. This may then feed back into the network interface as source clock. So follow the example the at803x already set and introduce a vsc8531,clk-out-frequency property to

[PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

2020-06-15 Thread Heiko Stuebner
From: Heiko Stuebner The different probe functions share a lot of code, so move the common parts into a helper to reduce duplication. This moves the devm_phy_package_join below the general allocation but as all components just allocate things, this should be ok. Suggested-by: Andrew Lunn Signe

[PATCH v3 2/3] dt-bindings: net: ethernet-phy: add enet-phy-clock-out-frequency

2020-06-15 Thread Heiko Stuebner
From: Heiko Stuebner Some ethernet phys have a configurable clock output, so add a generic property to describe its target rate. Suggested-by: Andrew Lunn Signed-off-by: Heiko Stuebner --- changes in v3: - new patch Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 + 1 file ch

Re: [PATCH] net: macb: Only disable NAPI on the actual error path

2020-06-15 Thread LABBE Corentin
On Mon, Jun 15, 2020 at 02:18:54PM +0100, Charles Keepax wrote: > A recent change added a disable to NAPI into macb_open, this was > intended to only happen on the error path but accidentally applies > to all paths. This causes NAPI to be disabled on the success path, which > leads to the network t

Re: [PATCH net] ibmvnic: Harden device login requests

2020-06-15 Thread Thomas Falcon
On 6/12/20 4:10 PM, David Miller wrote: From: Thomas Falcon Date: Fri, 12 Jun 2020 13:31:39 -0500 @@ -841,13 +841,14 @@ static int ibmvnic_login(struct net_device *netdev) { struct ibmvnic_adapter *adapter = netdev_priv(netdev); unsigned long timeout = msecs_to_jiffies(3)

Re: [PATCH] ath10k: Wait until copy complete is actually done before completing

2020-06-15 Thread Kalle Valo
Doug Anderson writes: > On Mon, Jun 15, 2020 at 7:32 AM Kalle Valo wrote: >> >> Douglas Anderson wrote: >> >> > On wcn3990 we have "per_ce_irq = true". That makes the >> > ath10k_ce_interrupt_summary() function always return 0xfff. The >> > ath10k_ce_per_engine_service_any() function will see

[PATCH 0/5] Adding Huawei BMA drivers

2020-06-15 Thread yunaixin03610
From: yunaixin This patch set contains 5 communication drivers for Huawei BMA software. The BMA software is a system management software. It supports the status monitoring, performance monitoring, and event monitoring of various components, including server CPUs, memory, hard disks, NICs, IB card

[PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv

2020-06-15 Thread yunaixin03610
From: yunaixin The BMA software is a system management software offered by Huawei. It supports the status monitoring, performance monitoring, and event monitoring of various components, including server CPUs, memory, hard disks, NICs, IB cards, PCIe cards, RAID controller cards, and optical mo

[PATCH net] net: core: reduce recursion limit value

2020-06-15 Thread Taehee Yoo
In the current code, ->ndo_start_xmit() can be executed recursively only 10 times because of stack memory. But, in the case of the vxlan, 10 recursion limit value results in a stack overflow. In the current code, the nested interface is limited by 8 depth. There is no critical reason that the recur

Re: [PATCH] ath10k: Wait until copy complete is actually done before completing

2020-06-15 Thread Doug Anderson
Hi, On Mon, Jun 15, 2020 at 7:56 AM Kalle Valo wrote: > > Doug Anderson writes: > > > On Mon, Jun 15, 2020 at 7:32 AM Kalle Valo wrote: > >> > >> Douglas Anderson wrote: > >> > >> > On wcn3990 we have "per_ce_irq = true". That makes the > >> > ath10k_ce_interrupt_summary() function always ret

Benötigen Sie einen Kredit zwischen Privatpersonen?

2020-06-15 Thread Magdalena Weidner
Mit Kredit ohne Bank haben Sie eine andere Möglichkeit zu leihen, ohne durch die Banken gehen zu müssen, wo Sie nach bestimmten Kriterien ausgewählt werden, die unter anderem Ihre familiäre und finanzielle Situation betreffen. Wenn Sie beispielsweise in einem temporären Geschäft arbeiten, können S

[PATCH net] ip_tunnel: fix use-after-free in ip_tunnel_lookup()

2020-06-15 Thread Taehee Yoo
In the datapath, the ip_tunnel_lookup() is used and it internally uses fallback tunnel device pointer, which is fb_tunnel_dev. This pointer is protected by RTNL. It's not enough to be used in the datapath. So, this pointer would be used after an interface is deleted. It eventually results in the us

[PATCH net] ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()

2020-06-15 Thread Taehee Yoo
In the datapath, the ip6gre_tunnel_lookup() is used and it internally uses fallback tunnel device pointer, which is fb_tunnel_dev. This pointer is protected by RTNL. It's not enough to be used in the datapath. So, this pointer would be used after an interface is deleted. It eventually results in th

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 5:22 PM Mika Westerberg wrote: > > On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > > > > On Mon, Jun 15, 2020 a

Re: [PATCH net] net: core: reduce recursion limit value

2020-06-15 Thread Florian Westphal
Taehee Yoo wrote: > In the current code, ->ndo_start_xmit() can be executed recursively only > 10 times because of stack memory. > But, in the case of the vxlan, 10 recursion limit value results in > a stack overflow. [..] > Fixes: 97cdcf37b57e ("net: place xmit recursion in softnet data") That

[PATCH net v2] ibmvnic: Harden device login requests

2020-06-15 Thread Thomas Falcon
The VNIC driver's "login" command sequence is the final step in the driver's initialization process with device firmware, confirming the available device queue resources to be utilized by the driver. Under high system load, firmware may not respond to the request in a timely manner or may abort the

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Mika Westerberg
On Mon, Jun 15, 2020 at 06:15:47PM +0300, Yehezkel Bernat wrote: > On Mon, Jun 15, 2020 at 5:22 PM Mika Westerberg > wrote: > > > > On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wrote: > > > On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Mon, Jun 15

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 6:32 PM Mika Westerberg wrote: > > On Mon, Jun 15, 2020 at 06:15:47PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 5:22 PM Mika Westerberg > > wrote: > > > > > > On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wrote: > > > > On Mon, Jun 15, 2020 at 4

[PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-15 Thread Era Mayflower
Allow using 32bit netlink attribute for packet number when creating or updating SA in an XPN link. Now utilities like iproute2's `ip` do not have to know the link type (XPN or not) when setting the packet number field of an SA. Signed-off-by: Era Mayflower --- drivers/net/macsec.c | 95 +

Re: [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv

2020-06-15 Thread Randy Dunlap
Hi-- On 6/15/20 7:59 AM, yunaixin03...@163.com wrote: > diff --git a/drivers/net/ethernet/huawei/bma/Kconfig > b/drivers/net/ethernet/huawei/bma/Kconfig > index 1a92c1dd83f3..12979128fa9d 100644 > --- a/drivers/net/ethernet/huawei/bma/Kconfig > +++ b/drivers/net/ethernet/huawei/bma/Kconfig > @@ -

[PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

2020-06-15 Thread yunaixin03610
From: yunaixin The BMA software is a system management software offered by Huawei. It supports the status monitoring, performance monitoring, and event monitoring of various components, including server CPUs, memory, hard disks, NICs, IB cards, PCIe cards, RAID controller cards, and optical mo

[PATCH v2] net: alx: fix race condition in alx_remove

2020-06-15 Thread Zekun Shen
There is a race condition exist during termination. The path is alx_stop and then alx_remove. An alx_schedule_link_check could be called before alx_stop by interrupt handler and invoke alx_link_check later. Alx_stop frees the napis, and alx_remove cancels any pending works. If any of the work is sc

Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

2020-06-15 Thread Randy Dunlap
On 6/15/20 7:59 AM, yunaixin03...@163.com wrote: > diff --git a/drivers/net/ethernet/huawei/bma/Kconfig > b/drivers/net/ethernet/huawei/bma/Kconfig > new file mode 100644 > index ..1a92c1dd83f3 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/bma/Kconfig > @@ -0,0 +1 @@ > +source "d

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Mika Westerberg
On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote: > > I think you are talking about the "prtstns" property in the network > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1). This is the > > thing that get exposed to the other side of the connection and we never > > announced

Maintainers / Kernel Summit 2020 submissions

2020-06-15 Thread Theodore Y. Ts'o
So far, we have received 5 techinical topic submissions for the Kernel Summit; thanks to those who have submitted. If you have some additional ideas of technical topics you'd like to discuss at the Kernel Summit, please submit them this week. For details on how to proposal a topic for the Kernel

Re: [PATCH net] ip_tunnel: fix use-after-free in ip_tunnel_lookup()

2020-06-15 Thread Eric Dumazet
On 6/15/20 8:06 AM, Taehee Yoo wrote: > In the datapath, the ip_tunnel_lookup() is used and it internally uses > fallback tunnel device pointer, which is fb_tunnel_dev. > This pointer is protected by RTNL. It's not enough to be used > in the datapath. > So, this pointer would be used after an in

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-15 Thread Eugenio Pérez
On Thu, 2020-06-11 at 07:30 -0400, Michael S. Tsirkin wrote: > On Wed, Jun 10, 2020 at 06:18:32PM +0200, Eugenio Perez Martin wrote: > > On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin wrote: > > > On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > > > > +/* This function

Re: [PATCH RFC v8 03/11] vhost/net: pass net specific struct pointer

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > In preparation for further cleanup, pass net specific pointer > to ubuf callbacks so we can move net specific fields > out to net structures. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/net.c | 14 +++--- > 1 f

Re: [PATCH RFC v8 05/11] vhost: format-independent API for used buffers

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > Add a new API that doesn't assume used ring, heads, etc. > For now, we keep the old APIs around to make it easier > to convert drivers. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 73 +

RE: [(RFC) PATCH ] NULL pointer dereference on rmmod iptable_mangle.

2020-06-15 Thread dwilder
On 2020-06-15 04:44, Florian Westphal wrote: Florian Westphal wrote: dwilder wrote: > > Since the netns core already does an unconditional synchronize_rcu after > > the pre_exit hooks this would avoid the problem as well. > > Something like this? (un-tested) Yes. > diff --git a/net/ipv4/net

Re: [PATCH v4 6/7] Bluetooth: Notify adv monitor removed event

2020-06-15 Thread Jakub Kicinski
On Fri, 12 Jun 2020 16:45:55 -0700 Miao-chen Chou wrote: > This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event. > > The following test was performed. > - Start two btmgmt consoles, issue a btmgmt advmon-remove command on one > console and observe a MGMT_EV_ADV_MONITOR_REMOVED eve

Re: [PATCH] net: Fix the arp error in some cases

2020-06-15 Thread Jakub Kicinski
On Sat, 13 Jun 2020 14:49:55 +0800 guodeqing wrote: > ie., > $ ifconfig eth0 6.6.6.6 netmask 255.255.255.0 > > $ ip rule add from 6.6.6.6 table > > $ ip route add 9.9.9.9 via 6.6.6.6 > > $ ping -I 6.6.6.6 9.9.9.9 > PING 9.9.9.9 (9.9.9.9) from 6.6.6.6 : 56(84) bytes of data. > > ^C > --- 9.

KMSAN: uninit-value in hash_ip6_del

2020-06-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f0d5ec90 kmsan: apply __no_sanitize_memory to dotraplinkag.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=17927f2e10 kernel config: https://syzkaller.appspot.co

Re: [PATCH net] MAINTAINERS: merge entries for felix and ocelot drivers

2020-06-15 Thread Jakub Kicinski
On Sun, 14 Jun 2020 01:07:53 +0300 Vladimir Oltean wrote: > From: Vladimir Oltean > > The ocelot switchdev driver also provides a set of library functions for > the felix DSA driver, which in practice means that most of the patches > will be of interest to both groups of driver maintainers. > >

[PATCH v2 net] MAINTAINERS: merge entries for felix and ocelot drivers

2020-06-15 Thread Vladimir Oltean
From: Vladimir Oltean The ocelot switchdev driver also provides a set of library functions for the felix DSA driver, which in practice means that most of the patches will be of interest to both groups of driver maintainers. So, as also suggested in the discussion here, let's merge the 2 entries

Re: [PATCH net] MAINTAINERS: merge entries for felix and ocelot drivers

2020-06-15 Thread Vladimir Oltean
On Mon, 15 Jun 2020 at 19:37, Jakub Kicinski wrote: > > On Sun, 14 Jun 2020 01:07:53 +0300 Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The ocelot switchdev driver also provides a set of library functions for > > the felix DSA driver, which in practice means that most of the patches >

Re: [PATCH net] net/rds: NULL pointer de-reference in rds_ib_add_one()

2020-06-15 Thread santosh . shilimkar
On 6/15/20 12:40 AM, Ka-Cheong Poon wrote: The parent field of a struct device may be NULL. The macro ibdev_to_node() should check for that. Signed-off-by: Ka-Cheong Poon --- Looks good. Acked-by: Santosh Shilimkar

Re: [PATCH net-next v6 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-06-15 Thread Rob Herring
On Thu, 04 Jun 2020 06:14:09 -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83869.yaml | 16 +++- > 1 file changed, 15 in

Re: [PATCH net-next v6 1/4] dt-bindings: net: Add tx and rx internal delays

2020-06-15 Thread Rob Herring
On Thu, Jun 04, 2020 at 06:14:07AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the >

Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-15 Thread Rob Herring
On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > This patch documents the qca8k's SGMII related properties that allow > configuration of the SGMII port. > > Signed-off-by: Jonathan McDowell > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 > 1 file changed

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-15 Thread Dan Carpenter
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 23c7500eea7d..c08bc7eb20bd 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1707,17 +1707,17 @@ void *krealloc(const void *p, size_t new_size, gfp_t > flags) > EXP

Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-15 Thread Jonathan McDowell
On Mon, Jun 15, 2020 at 11:45:16AM -0600, Rob Herring wrote: > On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > > This patch documents the qca8k's SGMII related properties that allow > > configuration of the SGMII port. > > > > Signed-off-by: Jonathan McDowell > > --- > > Doc

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-15 Thread Waiman Long
On 6/15/20 2:07 PM, Dan Carpenter wrote: On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: diff --git a/mm/slab_common.c b/mm/slab_common.c index 23c7500eea7d..c08bc7eb20bd 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1707,17 +1707,17 @@ void *krealloc(const void *p, size_

RE: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-06-15 Thread Brown, Aaron F
> From: Chen Yu > Sent: Thursday, May 21, 2020 10:59 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; Kok, Auke-jan H > ; Jeff Garzik > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Brown, Len ; Rafael J. Wysocki > ; Shevchenko, A

Re: [RFC PATCH bpf-next 1/8] libbpf: generalize libbpf externs support

2020-06-15 Thread Andrii Nakryiko
On Mon, Jun 15, 2020 at 9:44 AM Hao Luo wrote: > > Andrii, > > Thanks for this patch, it looks very nice! Decoupling kconfig from generic > externs is much needed. > > On Fri, Jun 12, 2020 at 3:34 PM Andrii Nakryiko wrote: >> >> Switch existing Kconfig externs to be just one of few possible kind

Re: [PATCH 00/17] spelling.txt: /decriptors/descriptors/

2020-06-15 Thread Jason Gunthorpe
On Tue, Jun 09, 2020 at 01:45:53PM +0100, Kieran Bingham wrote: > I wouldn't normally go through spelling fixes, but I caught sight of > this typo twice, and then foolishly grepped the tree for it, and saw how > pervasive it was. > > so here I am ... fixing a typo globally... but with an addition

[PATCH] rtl_nic: add firmware for RTL8125B

2020-06-15 Thread Heiner Kallweit
This adds firmware for RTL8125B rev.a and RTL8125B rev.b. Signed-off-by: Heiner Kallweit Signed-off-by: Chunhao Lin --- WHENCE| 6 ++ rtl_nic/rtl8125b-1.fw | Bin 0 -> 9952 bytes rtl_nic/rtl8125b-2.fw | Bin 0 -> 3264 bytes 3 files changed, 6 insertions(+) create mode 100

[PATCH] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-06-15 Thread David Christensen
The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. The function is called once with the PCI state pci_channel_io_frozen and then c

  1   2   3   >