[PATCH -next] netfilter: ctnetlink: Fix memleak in ctnetlink_alloc_filter

2020-06-11 Thread Zheng Bin
ctnetlink_alloc_filter filter = kzalloc In the following process(such as ctnetlink_parse_zone, ctnetlink_parse_filter), if return fail, need to kfree filter. Fixes: cb8aa9a3affb ("netfilter: ctnetlink: add kernel side filtering for dump") Signed-off-by: Zheng Bin --- net/netfilter/nf_conn

[PATCH] mld: fix memory leak in ipv6_mc_destroy_dev()

2020-06-11 Thread Wang Hai
Commit a84d01647989 ("mld: fix memory leak in mld_del_delrec()") fixed the memory leak of MLD, but missing the ipv6_mc_destroy_dev() path, in which mca_sources are leaked after ma_put(). Using ip6_mc_clear_src() to take care of the missing free. BUG: memory leak unreferenced object 0x8881113d

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread Björn Töpel
On Thu, 11 Jun 2020 at 07:11, Li RongQing wrote: > > propagate sock_alloc_send_skb error code, not set it > to EAGAIN unconditionally, when fail to allocate skb, > which maybe causes that user space unnecessary loops > > Fixes: 35fcde7f8deb "(xsk: support for Tx)" > Signed-off-by: Li RongQing T

Re: [PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-06-11 Thread Xin Long
On Thu, Jun 11, 2020 at 12:32 AM Xin Long wrote: > > On Tue, Jun 9, 2020 at 10:18 PM Tobias Brunner wrote: > > > > Hi Xin, > > > > >> I guess we could workaround this issue in strongSwan by installing > > >> policies that share the same mark and selector with the same priority, > > >> so only one

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 08:14:03PM +0100, Jonathan McDowell wrote: > Update the driver to use the new PHYLINK callbacks, removing the > legacy adjust_link callback. Looks good, there's a couple of issues / questions > static void > +qca8k_phylink_mac_config(struct dsa_switch *ds, int port, unsig

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Vladimir Oltean
Hi Jonathan, On Wed, 10 Jun 2020 at 23:19, Jonathan McDowell wrote: > > Update the driver to use the new PHYLINK callbacks, removing the > legacy adjust_link callback. > > Signed-off-by: Jonathan McDowell > --- > drivers/net/dsa/qca8k.c | 309 +++- > 1 file c

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-11 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 08:15:13PM +0100, Jonathan McDowell wrote: > This patch improves the handling of the SGMII interface on the QCA8K > devices. Previously the driver did no configuration of the port, even if > it was selected. We now configure it up in the appropriate > PHY/MAC/Base-X mode dep

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Vladimir Oltean
Hi Russell, On Thu, 11 Jun 2020 at 11:57, Russell King - ARM Linux admin wrote: > > > Alternatively, phylink supports polling mode, but due to the layered > way DSA is written, DSA drivers don't have access to that as that is > in the DSA upper levels in net/dsa/slave.c (dsa_slave_phy_setup(), >

Re: [PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2020 at 11:02:57AM +0800, Jason Wang wrote: > > On 2020/6/10 下午7:05, Michael S. Tsirkin wrote: > > > > +EXPORT_SYMBOL_GPL(vhost_get_vq_desc); > > > >/* Reverse the effect of vhost_get_vq_desc. Useful for error > > > > handling. */ > > > >void vhost_discard_vq_desc(struct v

Re: [PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-06-11 Thread Tobias Brunner
Hi Xin, > For 'new/update/del', we should do an exact match with > "mark.v == pol->mark.v && mark.m == pol->mark.m", as these are MSGs to > manage the policies, every policy should be able to be matched. Agreed, using an exact match for mark/mask would probably make the most sense here. > But fo

[PATCH] ipvs: avoid drop first packet to reuse conntrack

2020-06-11 Thread YangYuxi
Since commit f719e3754ee ("ipvs: drop first packet to redirect conntrack"), when a new TCP connection meet the conditions that need reschedule, the first syn packet is dropped, this cause one second latency for the new connection, more discussion about this problem can easy seach from google, such

Re: [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft_cb type

2020-06-11 Thread Pablo Neira Ayuso
On Thu, Jun 11, 2020 at 11:30:17AM +0800, we...@ucloud.cn wrote: > From: wenxu > > Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb. > But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in > mlx5e driver. > It is better to just check the indr_release_cb, all

[PATCH] ipvs: avoid drop first packet to reuse conntrack

2020-06-11 Thread YangYuxi
Since 'commit f719e3754ee2 ("ipvs: drop first packet to redirect conntrack")', when a new TCP connection meet the conditions that need reschedule, the first syn packet is dropped, this cause one second latency for the new connection, more discussion about this problem can easy search from google, s

[PATCH net v2] flow_offload: fix incorrect cleanup for indirect flow_blocks

2020-06-11 Thread wenxu
From: wenxu If the representor is removed, then identify the indirect flow_blocks that need to be removed by the release callback. Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure") Signed-off-by: wenxu --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

[net] tipc: fix kernel WARNING in tipc_msg_append()

2020-06-11 Thread Tuong Lien
syzbot found the following issue: WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 check_copy_size include/linux/thread_info.h:150 [inline] WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 copy_from_iter include/linux/uio.h:144 [inline] WARNING: CPU: 0 PID: 6808 at includ

[net] tipc: fix NULL pointer dereference in tipc_disc_rcv()

2020-06-11 Thread Tuong Lien
When a bearer is enabled, we create a 'tipc_discoverer' object to store the bearer related data along with a timer and a preformatted discovery message buffer for later probing... However, this is only carried after the bearer was set 'up', that left a race condition resulting in kernel panic. It

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Daniel Thompson
On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: > On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: > > > On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: > > > > On Wed, 2020-06-10 at 15:37 +0200, Greg Kr

Re: [PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option

Re: [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft_cb type

2020-06-11 Thread Vlad Buslov
On Thu 11 Jun 2020 at 06:30, we...@ucloud.cn wrote: > From: wenxu > > Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb. > But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in > mlx5e driver. > It is better to just check the indr_release_cb, all the setup_cb t

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Jonathan McDowell
On Thu, Jun 11, 2020 at 11:58:43AM +0300, Vladimir Oltean wrote: > Hi Jonathan, > > On Wed, 10 Jun 2020 at 23:19, Jonathan McDowell wrote: > > > > Update the driver to use the new PHYLINK callbacks, removing the > > legacy adjust_link callback. > > > > Signed-off-by: Jonathan McDowell ... > > s

Re: [PATCH net v2] flow_offload: fix incorrect cleanup for indirect flow_blocks

2020-06-11 Thread Pablo Neira Ayuso
On Thu, Jun 11, 2020 at 06:03:17PM +0800, we...@ucloud.cn wrote: [...] > diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c > index 0cfc35e..40eaf64 100644 > --- a/net/core/flow_offload.c > +++ b/net/core/flow_offload.c > @@ -372,14 +372,13 @@ int flow_indr_dev_register(flow_indr_block_

Re: [PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-11 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 06:18:32PM +0200, Eugenio Perez Martin wrote: > On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin wrote: > > > > On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > > > +/* This function returns a value > 0 if a descriptor was found, or 0 > > > > if

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Stanimir Varbanov
On 6/11/20 1:52 PM, Daniel Thompson wrote: > On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: >> On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: >>> On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: >>>

[PATCH RFC v8 09/11] vhost/scsi: switch to buf APIs

2020-06-11 Thread Michael S. Tsirkin
Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/scsi.c | 73 ++-- 1 file changed, 44 insertions(+), 29 dele

[PATCH RFC v8 04/11] vhost: reorder functions

2020-06-11 Thread Michael S. Tsirkin
Reorder functions in the file to not rely on forward declarations, in preparation to making them static down the road. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/vhost/vhost.

[PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-11 Thread Michael S. Tsirkin
As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- drivers/vhost/vhost.c | 314

[PATCH RFC v8 11/11] vhost: drop head based APIs

2020-06-11 Thread Michael S. Tsirkin
Everyone's using buf APIs, no need for head based ones anymore. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 64 ++- drivers/vhost/vhost.h | 12 2 files changed, 8 insertions(+), 68 deletions(-) diff --git a/drivers/vhost/vhost.c

[PATCH RFC v8 05/11] vhost: format-independent API for used buffers

2020-06-11 Thread Michael S. Tsirkin
Add a new API that doesn't assume used ring, heads, etc. For now, we keep the old APIs around to make it easier to convert drivers. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 73 +-- drivers/vhost/vhost.h | 17 +- 2 files changed

[PATCH RFC v8 03/11] vhost/net: pass net specific struct pointer

2020-06-11 Thread Michael S. Tsirkin
In preparation for further cleanup, pass net specific pointer to ubuf callbacks so we can move net specific fields out to net structures. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/net

[PATCH RFC v8 06/11] vhost/net: convert to new API: heads->bufs

2020-06-11 Thread Michael S. Tsirkin
Convert vhost net to use the new format-agnostic API. In particular, don't poke at vq internals such as the heads array. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 154 +++- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/d

[PATCH RFC v8 00/11] vhost: ring format independence

2020-06-11 Thread Michael S. Tsirkin
This still causes corruption issues for people so don't try to use in production please. Posting to expedite debugging. This adds infrastructure required for supporting multiple ring formats. The idea is as follows: we convert descriptors to an independent format first, and process that convert

[PATCH RFC v8 08/11] vhost/test: convert to the buf API

2020-06-11 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index 7d69778aaa26..12304eb8da15 100644 --- a/drivers/vhost/test.c +++ b/drivers/vhost/test.c @@ -44,9 +

[PATCH RFC v8 10/11] vhost/vsock: switch to the buf API

2020-06-11 Thread Michael S. Tsirkin
A straight-forward conversion. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vsock.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index a483cec31d5c..61c6d3dd2ae3 100644 --- a/drivers/vhos

[PATCH RFC v8 07/11] vhost/net: avoid iov length math

2020-06-11 Thread Michael S. Tsirkin
Now that API exposes buffer length, we no longer need to scan IOVs to figure it out. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 830fe84912a5..0b509be8d7b1 10

[PATCH RFC v8 01/11] vhost: option to fetch descriptors through an independent struct

2020-06-11 Thread Michael S. Tsirkin
The idea is to support multiple ring formats by converting to a format-independent array of descriptors. This costs extra cycles, but we gain in ability to fetch a batch of descriptors in one go, which is good for code cache locality. When used, this causes a minor performance degradation, it's b

Re: [PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-11 Thread Stanimir Varbanov
Hi Greg, Thanks for the comments! On 6/9/20 2:12 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:02PM +0300, Stanimir Varbanov wrote: >> +int venus_dbgfs_init(struct venus_core *core) >> +{ >> +core->root = debugfs_create_dir("venus", NULL); >> +if (IS_ERR(core->root)) >> +

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Daniel Thompson
On Thu, Jun 11, 2020 at 02:31:07PM +0300, Stanimir Varbanov wrote: > On 6/11/20 1:52 PM, Daniel Thompson wrote: > > On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: > >> On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: > >>> On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perc

Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-11 Thread Alex Elder
On 6/10/20 6:36 PM, David Miller wrote: > From: Alex Elder > Date: Wed, 10 Jun 2020 14:53:32 -0500 > >> When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are >> enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes >> to 56 bytes currently). As a consequence the size of the

Re: [PATCH] perf tools: Fix potential memory leak in perf events parser

2020-06-11 Thread Markus Elfring
> Fix potential memory leak in function parse_events_term__sym_hw() > and parse_events_term__clone(). Would you like to add the tag “Fixes” to the commit message? … > +++ b/tools/perf/util/parse-events.c … > @@ -2957,9 +2958,20 @@ int parse_events_term__sym_hw(struct > parse_events_term **term

Re: [PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes

2020-06-11 Thread Meir Lichtinger
On 02-May-20 18:08, Andrew Lunn wrote: On Thu, Apr 30, 2020 at 04:41:05PM -0700, Saeed Mahameed wrote: From: Meir Lichtinger Define 100G, 200G and 400G link modes using 100Gbps per lane Signed-off-by: Meir Lichtinger CC: Andrew Lunn Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed ---

Re: [PATCH v2 2/2] net: phy: mscc: handle the clkout control on some phy variants

2020-06-11 Thread Andrew Lunn
On Tue, Jun 09, 2020 at 03:31:40PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > a predefined rate of 25, 50 or 125MHz. > > This may then feed back into the network interface as source clock. > So follow the example

Re: [PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes

2020-06-11 Thread Andrew Lunn
> > How do you know you have connected a 40baseLR4 to a > > 40baseER4 with a 40Km and it is not expected to work, when looking > > at ethtool? I assume the EEPROM contents tell you if the module is > > LR4, ER4, or FR4? > > > > Andrew > Correct. Hi Meir Do you also have patches to

[PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-11 Thread Bartosz Golaszewski
From: Bartosz Golaszewski During development we tried to make the interrupt handling as fine-grained as possible with TX and RX interrupts being disabled/enabled independently and the counter registers reset from workqueue context. Unfortunately after thorough testing of current mainline, we not

Re: [PATCH] xdp_rxq_info_user: Add null check after malloc

2020-06-11 Thread Daniel Borkmann
On 6/10/20 5:01 AM, Gaurav Singh wrote: Signed-off-by: Gaurav Singh The memset call is made right after malloc call which can return a NULL pointer upon failure causing a segmentation fault. Fix this by adding a null check right after malloc() and then do memset(). The SoB should come after t

Re: [PATCH] perf tools: Fix potential memory leak in perf events parser

2020-06-11 Thread Greg KH
On Thu, Jun 11, 2020 at 03:17:17PM +0200, Markus Elfring wrote: > > Fix potential memory leak in function parse_events_term__sym_hw() > > and parse_events_term__clone(). > > Would you like to add the tag “Fixes” to the commit message? > > > … > > +++ b/tools/perf/util/parse-events.c > … > > @@ -

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread Daniel Borkmann
On 6/11/20 10:18 AM, Björn Töpel wrote: On Thu, 11 Jun 2020 at 07:11, Li RongQing wrote: propagate sock_alloc_send_skb error code, not set it to EAGAIN unconditionally, when fail to allocate skb, which maybe causes that user space unnecessary loops Fixes: 35fcde7f8deb "(xsk: support for Tx)"

Re: [PATCH] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-11 Thread Dominique Martinet
Wang Hai wrote on Thu, Jun 11, 2020: > p9_read_work and p9_fd_cancelled may be called concurrently. Good catch. I'm sure this fixes some of the old syzbot bugs... I'll check other transports handle this properly as well. > Before list_del(&m->rreq->req_list) in p9_read_work is called, > the req->

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c b/samples/bpf/xdp_rxq_info_user.c index 4fe47502ebed..caa4e7ffcfc7 100644 --- a/sam

[PATCH] can current ECMP implementation support consistent hashing for next hop?

2020-06-11 Thread 杨燚
Hi, folks We need to use Linux ECMP to do active-active load balancer, but consistent hash is necessary because load balance node may be added or removed dynamically, so number of hash bucket is changeable, but we have to distribute flow to load balance node which is handling this flow and has

[PATCH] dt-bindings: Fix more incorrect 'reg' property sizes in examples

2020-06-11 Thread Rob Herring
The examples template is a 'simple-bus' with a size of 1 cell for had between 2 and 4 cells which really only errors on I2C or SPI type devices with a single cell. The easiest fix in most cases is to change the 'reg' property to 1 cell for address and size. Cc: "Heiko Stübner" Cc: Ezequiel Garci

Re: [PATCH] dt-bindings: Fix more incorrect 'reg' property sizes in examples

2020-06-11 Thread Mark Brown
On Thu, Jun 11, 2020 at 09:19:23AM -0600, Rob Herring wrote: > The examples template is a 'simple-bus' with a size of 1 cell for > had between 2 and 4 cells which really only errors on I2C or SPI type > devices with a single cell. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-11 Thread Konrad Rzeszutek Wilk
On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. What kind of testing? 100GiB? Low latency?

RE: [Intel-wired-lan] [PATCH] i40e: silence an UBSAN false positive

2020-06-11 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Qian Cai > Sent: Saturday, June 6, 2020 1:01 PM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Qian Cai > ; intel-wired-...@lists.osuosl.org; da...@davemloft.net > Subject: [Intel-wired-lan]

RE: [Intel-wired-lan] [PATCH net 1/3] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-06-11 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Ciara Loftus > Sent: Tuesday, June 9, 2020 6:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Topel, Bjorn ; > Karlsson, Magnus > Subject: [Intel-wired-lan] [PATCH net 1/3] ixgbe: protect ring accesses w

RE: [Intel-wired-lan] [PATCH net 2/3] i40e: protect ring accesses with READ- and WRITE_ONCE

2020-06-11 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Ciara Loftus > Sent: Tuesday, June 9, 2020 6:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Topel, Bjorn ; > Karlsson, Magnus > Subject: [Intel-wired-lan] [PATCH net 2/3] i40e: protect ring accesses wi

RE: [Intel-wired-lan] [PATCH net 3/3] ice: protect ring accesses with WRITE_ONCE

2020-06-11 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Ciara Loftus > Sent: Tuesday, June 9, 2020 6:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Topel, Bjorn ; > Karlsson, Magnus > Subject: [Intel-wired-lan] [PATCH net 3/3] ice: protect ring accesses wit

Re: [PATCH iproute2 net-next v2 0/2] support for fdb nexthop groups

2020-06-11 Thread David Ahern
On 6/10/20 6:35 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series adds iproute2 support for recently added > kernel fdb nexthop groups > > example: > /* create fdb nexthop group */ > $ip nexthop add id 12 via 172.16.1.2 fdb > $ip nexthop add id 13 via 172.16.1.3 fdb > $ip nexthop add

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-11 Thread Marc Kleine-Budde
On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > Hello, > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > Controller with MCP2517FD as the target controller version. This series is > mostly inspired (or taken) from the previous iterations posted by Martin > Sperl. >

Re: [PATCH net v2] flow_offload: fix incorrect cleanup for indirect flow_blocks

2020-06-11 Thread wenxu
在 2020/6/11 19:05, Pablo Neira Ayuso 写道: On Thu, Jun 11, 2020 at 06:03:17PM +0800, we...@ucloud.cn wrote: [...] diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index 0cfc35e..40eaf64 100644 --- a/net/core/flow_offload.c +++ b/net/core/flow_offload.c @@ -372,14 +372,13 @@ int flo

[PATCH] devlink: update include files

2020-06-11 Thread Stephen Hemminger
Use the tool iwyu to get more complete list of includes for all the bits used by devlink. This should also fix build with musl libc. Fixes: c4dfddccef4e ("fix JSON output of mon command") Reported-off-by: Dan Robertson Signed-off-by: Stephen Hemminger --- This is more complete version of sugge

[PATCH net v3 2/2] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-11 Thread wenxu
From: wenxu In the function __flow_block_indr_cleanup, The match stataments this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv is totally different data from the flow_indr_dev->cb_priv. Store the representor cb_priv to the flow_block_cb->indr.cb_priv in the driver. Fixes: 1fac

[PATCH net v3 1/2] flow_offload: fix incorrect cleanup for indirect flow_blocks

2020-06-11 Thread wenxu
From: wenxu If the representor is removed, then identify the indirect flow_blocks that need to be removed by the release callback. Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure") Signed-off-by: wenxu --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

[PATCH bpf] bpf: sockmap: don't attach programs to UDP sockets

2020-06-11 Thread Lorenz Bauer
The stream parser infrastructure isn't set up to deal with UDP sockets, so we mustn't try to attach programs to them. I remember making this change at some point, but I must have lost it while rebasing or something similar. Fixes: 7b98cd42b049 ("bpf: sockmap: Add UDP support") Signed-off-by: Lore

[RFC 6/8] docs: networking: move AppleTalk / LocalTalk drivers to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move docs for cops and ltpc under device_drivers/appletalk. Signed-off-by: Jakub Kicinski --- .../{ => device_drivers/appletalk}/cops.rst | 0 .../device_drivers/appletalk/index.rst| 19 +++ .../{ => device_drivers/appletalk}/ltpc.rst | 0 .../networking/device_driv

[RFC 7/8] docs: networking: move ATM drivers to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move docs for cxacru, fore200e and iphase under device_drivers/atm. Signed-off-by: Jakub Kicinski -- CC: accessrunner-gene...@lists.sourceforge.net CC: 3ch...@gmail.com CC: linux-atm-gene...@lists.sourceforge.net --- .../{ => device_drivers/atm}/cxacru-cf.py | 0 .../{ => device_drivers/atm

[RFC 5/8] docs: networking: move remaining Ethernet driver docs to the hw section

2020-06-11 Thread Jakub Kicinski
Move docs for hinic and altera_tse under device_drivers/ethernet. Signed-off-by: Jakub Kicinski -- CC: luob...@huawei.com --- .../{ => device_drivers/ethernet/altera}/altera_tse.rst | 0 .../networking/{ => device_drivers/ethernet/huawei}/hinic.rst | 0 Documentation/networking/device_

[RFC 1/8] docs: networking: reorganize driver documentation again

2020-06-11 Thread Jakub Kicinski
Organize driver documentation by device type. Most documents have fairly verbose yet uninformative names, so let users first select a well defined device type, and then search for a particular driver. While at it rename the section from Vendor drivers to Hardware drivers. This seems more accurate,

[RFC 4/8] docs: networking: move ray_cs to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move ray_cs into Wi-Fi driver docs subdirectory. Signed-off-by: Jakub Kicinski --- Documentation/networking/device_drivers/wifi/index.rst| 1 + Documentation/networking/{ => device_drivers/wifi}/ray_cs.rst | 0 Documentation/networking/index.rst| 1 - drivers/

[RFC 8/8] docs: networking: move FDDI drivers to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move docs for defza and skfp under device_drivers/fddi. Signed-off-by: Jakub Kicinski -- CC: ma...@linux-mips.org --- .../{ => device_drivers/fddi}/defza.rst | 0 .../networking/device_drivers/fddi/index.rst | 19 +++ .../{ => device_drivers/fddi}/skfp.rst| 0 ..

[RFC 2/8] docs: networking: move z8530 to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move z8530 docs to hamradio and wan subdirectories. Signed-off-by: Jakub Kicinski -- CC: jreu...@yaina.de CC: linux-h...@vger.kernel.org --- .../device_drivers/hamradio/index.rst | 18 ++ .../{ => device_drivers/hamradio}/z8530drv.rst | 0 .../networking/device_drivers/

[RFC 0/8] net: organize driver docs by device type

2020-06-11 Thread Jakub Kicinski
Hi! This series finishes off what I started in commit b255e500c8dc ("net: documentation: build a directory structure for drivers"). The objective is to de-clutter our documentation folder so folks have a chance of finding relevant info. I _think_ I got all the driver docs from the main documentat

[RFC 3/8] docs: networking: move baycom to the hw driver section

2020-06-11 Thread Jakub Kicinski
Move baycom to hamradio. Signed-off-by: Jakub Kicinski -- CC: t.sai...@alumni.ethz.ch --- .../networking/{ => device_drivers/hamradio}/baycom.rst | 0 .../networking/device_drivers/hamradio/index.rst | 1 + Documentation/networking/index.rst| 1 - drivers/net/h

[PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99

2020-06-11 Thread Roi Dayan
On some distros, i.e. rhel 7.6, compilation fails with the following: ipaddress.c: In function ‘lookup_flag_data_by_name’: ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 0; i < ARRAY_SIZE(ifa_flag_data); ++i) { ^ ipaddress.c:1260:2: note:

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-11 Thread Jonathan McDowell
On Wed, Jun 10, 2020 at 08:31:11PM -0700, Florian Fainelli wrote: > On 6/10/2020 12:15 PM, Jonathan McDowell wrote: > > This patch improves the handling of the SGMII interface on the QCA8K > > devices. Previously the driver did no configuration of the port, even if > > it was selected. We now confi

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Jesper Dangaard Brouer
On Thu, 11 Jun 2020 11:02:21 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc Please also mention/describe that this also solves the bug you found. As this fix a potential bug, it will be appropriate to add a "Fixes:" line, just before "Signed-off-by" (meaning no newline between t

PROBLEM: IPv4 route exception patch breaks BIRD2

2020-06-11 Thread Joseph Marsden
Hi all, While upgrading my kernel from 5.2 to 5.4.43, I noticed a very sharp increase in CPU usage - coming from BIRD, the routing daemon on my system. I ran a Netlink capture and saw that BIRD was attempting to insert routes twice into the kernel routing table. This was causing routes to be re-in

Re: [PATCH] can current ECMP implementation support consistent hashing for next hop?

2020-06-11 Thread David Ahern
On 6/11/20 8:56 AM, Yi Yang (杨燚)-云服务集团 wrote: > Hi, folks > > We need to use Linux ECMP to do active-active load balancer, but consistent > hash is necessary because load balance node may be added or removed > dynamically, so number of hash bucket is changeable, but we have to > distribute flow

Re: [PATCH] ipvs: avoid drop first packet to reuse conntrack

2020-06-11 Thread Julian Anastasov
Hello, On Thu, 11 Jun 2020, YangYuxi wrote: > Since commit f719e3754ee ("ipvs: drop first packet > to redirect conntrack"), when a new TCP connection > meet the conditions that need reschedule, the first > syn packet is dropped, this cause one second latency > for the new connection, mor

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

2020-06-11 Thread Markus Elfring
> Fix memory leak of in function parse_events_term__sym_hw() > and parse_events_term__clone() when error occur. How do you think about a wording variant like the following? Release a configuration object after a string duplication failed. Regards, Markus

Re: [PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes

2020-06-11 Thread Meir Lichtinger
On 11-Jun-20 16:54, Andrew Lunn wrote: How do you know you have connected a 40baseLR4 to a 40baseER4 with a 40Km and it is not expected to work, when looking at ethtool? I assume the EEPROM contents tell you if the module is LR4, ER4, or FR4? Andrew Correct. Hi Meir Do you also

Re: [PATCH v2 2/2] perf tools: Improve exception handling in two functions of perf events parser

2020-06-11 Thread Markus Elfring
> Fix potential memory leak. Function new_term may return error, so > it is need to free memory when the return value is negative. How do you think about a wording variant like the following? Add jump targets so that a configuration object and a duplicated string are released after a call o

Re: [PATCH net 1/5] net: ipa: program metadata mask differently

2020-06-11 Thread Alex Elder
-Alex > [auto build test WARNING on net/master] > > url: > https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-endpoint-configuration-fixes/20200611-035600 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git > 89dc68533b190117e1a2fb4298d88b96

Re: [PATCH] drivers: dpaa2: Use devm_kcalloc() in setup_dpni()

2020-06-11 Thread David Miller
From: Xu Wang Date: Thu, 11 Jun 2020 02:45:20 + > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang Applied, thanks.

Re: [PATCH net] ionic: remove support for mgmt device

2020-06-11 Thread David Miller
From: Shannon Nelson Date: Wed, 10 Jun 2020 21:07:39 -0700 > We no longer support the mgmt device in the ionic driver, > so remove the device id and related code. > > Fixes: b3f064e9746d ("ionic: add support for device id 0x1004") > Signed-off-by: Shannon Nelson Applied, thank you.

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread David Miller
From: Li RongQing Date: Thu, 11 Jun 2020 13:11:06 +0800 > @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk) > len = desc.len; > skb = sock_alloc_send_skb(sk, len, 1, &err); > if (unlikely(!skb)) { > - err = -EAGAIN; >

[PATCH net v2 0/4] net: ipa: endpoint configuration fixes

2020-06-11 Thread Alex Elder
This series fixes four bugs in the configuration of IPA endpoints. See the description of each for more information. In this version I have dropped the last patch from the series, and restored a "static" keyword that had inadvertently gotten removed. -Alex

[PATCH net v2 2/4] net: ipa: fix modem LAN RX endpoint id

2020-06-11 Thread Alex Elder
The endpoint id assigned to the modem LAN RX endpoint for the SC7180 SoC is incorrect. The erroneous value might have been copied from SDM845 and never updated. The correct endpoint id to use for this SoC is 11. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data-sc7180.c | 2 +- 1 file cha

Re: [net] tipc: fix kernel WARNING in tipc_msg_append()

2020-06-11 Thread David Miller
From: Tuong Lien Date: Thu, 11 Jun 2020 17:07:35 +0700 > syzbot found the following issue: > > WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 check_copy_size > include/linux/thread_info.h:150 [inline] > WARNING: CPU: 0 PID: 6808 at include/linux/thread_info.h:150 copy_from_iter >

Re: [net] tipc: fix NULL pointer dereference in tipc_disc_rcv()

2020-06-11 Thread David Miller
From: Tuong Lien Date: Thu, 11 Jun 2020 17:08:08 +0700 > When a bearer is enabled, we create a 'tipc_discoverer' object to store > the bearer related data along with a timer and a preformatted discovery > message buffer for later probing... However, this is only carried after > the bearer was set

[PATCH net v2 3/4] net: ipa: program upper nibbles of sequencer type

2020-06-11 Thread Alex Elder
The upper two nibbles of the sequencer type were not used for SDM845, and were assumed to be 0. But for SC7180 they are used, and so they must be programmed by ipa_endpoint_init_seq(). Fix this bug. IPA_SEQ_PKT_PROCESS_NO_DEC_NO_UCP_DMAP doesn't have a descriptive comment, so add one. Signed-of

[PATCH net v2 4/4] net: ipa: header pad field only valid for AP->modem endpoint

2020-06-11 Thread Alex Elder
Only QMAP endpoints should be configured to find a pad size field within packet headers. They are found in the first byte of the QMAP header (and the hardware fills only the 6 bits in that byte that constitute the pad_len field). The RMNet driver assumes the pad_len field is valid for received pa

[PATCH net v2 1/4] net: ipa: program metadata mask differently

2020-06-11 Thread Alex Elder
The way the mask value is programmed for QMAP RX endpoints was based on some wrong assumptions about the way metadata containing the QMAP mux_id value is formatted. The metadata value supplied by the modem is *not* in QMAP format, and in fact contains the mux_id we want in its (big endian) low-ord

Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-11 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 11 Jun 2020 16:01:39 +0200 > Unfortunately after thorough testing of current mainline, we noticed the > driver has become unstable under heavy load. While this is hard to > reproduce, it's quite consistent in the driver's current form. Maybe you should work t

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-11 Thread Marc Kleine-Budde
On 6/11/20 6:26 PM, Marc Kleine-Budde wrote: > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but > Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is

Re: [PATCH net] ionic: remove support for mgmt device

2020-06-11 Thread Michal Schmidt
Dne 11. 06. 20 v 6:07 Shannon Nelson napsal(a): We no longer support the mgmt device in the ionic driver, so remove the device id and related code. ...> @@ -252,8 +248,6 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) } pci_set_master(pdev); -

Re: [PATCH net 2/2] net/sched: act_gate: fix configuration of the periodic timer

2020-06-11 Thread Cong Wang
On Wed, Jun 10, 2020 at 2:43 PM Davide Caratti wrote: > +static void gate_setup_timer(struct tcf_gate *gact, u64 basetime, > +enum tk_offsets tko, s32 clockid, > +bool do_init) > +{ > + bool timer_change = basetime != gact->param.tcfg_b

[RFC] .BTF section data alignment issue on s390

2020-06-11 Thread Jiri Olsa
hi, we're hitting a problem on s390 with BTF data alignment. When running simple test, we're getting this message from verifier and console: bpf_common.c:91: BROK: Failed verification: in-kernel BTF is malformed [ 41.545572] BPF:Total section length too long AFAICS it happens when .BTF se

  1   2   >