Re: WARNING in dev_change_net_namespace

2020-06-08 Thread Will Deacon
On Sat, Jun 06, 2020 at 07:03:03AM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 13dc4d836179444f0ca90188cfccd23f9cd9ff05 > Author: Will Deacon > Date: Tue Apr 21 14:29:18 2020 + > > arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() > > bisection

Re: Hang on wireless removal..

2020-06-08 Thread Sedat Dilek
On Sat, Jun 6, 2020 at 9:56 AM Johannes Berg wrote: > > Hi, sorry for the top post, on my phone. > > Yes, your analysis is spot on I think. I've got a fix for this in my > jberg/mac80211 tree, there's a deadlock with a work struct and the rtnl. > > Sorry about that. My testing should've caught it

Re: Hang on wireless removal..

2020-06-08 Thread Johannes Berg
On Mon, 2020-06-08 at 09:14 +0200, Sedat Dilek wrote: > On Sat, Jun 6, 2020 at 9:56 AM Johannes Berg > wrote: > > Hi, sorry for the top post, on my phone. > > > > Yes, your analysis is spot on I think. I've got a fix for this in my > > jberg/mac80211 tree, there's a deadlock with a work struct a

[PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode

2020-06-08 Thread Sascha Hauer
The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode called DRSGMII. This patch adds a corresponding phy-mode string 'drsgmii' and parses it from DT. The MVNETA then configures the SERDES protocol value accordingly. It was successfully tested on a MV78460 connected to a FPGA. Si

[PATCH] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread Geliang Tang
In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: +---+---+---+ |Subtype|(resvd)| Address ID | +---+---+---+ | | ptrptr+1 We sho

pull-request: mac80211 2020-06-08

2020-06-08 Thread Johannes Berg
Hi Dave, We have a couple of updates - most importantly the fix for the deadlock issue that came up. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 98749b7188affbf2900c2aab704a8853901d1139: yam: fix possible memory leak in yam_init_d

Re: [PATCH v3] Bluetooth: Allow suspend even when preparation has failed

2020-06-08 Thread Marcel Holtmann
Hi Abhishek, > It is preferable to allow suspend even when Bluetooth has problems > preparing for sleep. When Bluetooth fails to finish preparing for > suspend, log the error and allow the suspend notifier to continue > instead. > > To also make it clearer why suspend failed, change bt_dev_dbg to

RE: packed structures used in socket options

2020-06-08 Thread David Laight
From: Michael Tuexen > Sent: 07 June 2020 22:51 > > On 7. Jun 2020, at 22:21, David Laight wrote: > > > > From: Michael Tuexen > >> Sent: 07 June 2020 18:24 > >>> On 7. Jun 2020, at 19:14, David Laight wrote: > >>> > >>> From: Michael Tuexen > Sent: 07 June 2020 16:15 > > On 7. Jun 2020

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Jason Wang
On 2020/6/8 下午2:32, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: On 2020/6/7 下午9:51, Michael S. Tsirkin wrote: On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: On 2020/6/2 下午3:08, Jason Wang wrote: +static const struct pci_device_id vp_vdp

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 05:18:44PM +0800, Jason Wang wrote: > > On 2020/6/8 下午2:32, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: > > > On 2020/6/7 下午9:51, Michael S. Tsirkin wrote: > > > > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > >

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Jason Wang
On 2020/6/8 下午5:31, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:18:44PM +0800, Jason Wang wrote: On 2020/6/8 下午2:32, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: On 2020/6/7 下午9:51, Michael S. Tsirkin wrote: On Fri, Jun 05, 2020 at 04:54:17P

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: > > > > > Looking at > > > pci_match_one_device() it checks both subvendor and subdevice there. > > > > > > Thanks > > > > But IIUC there is no guarantee that driver with a specific subvendor > > matches in presence of a generic one. >

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Jason Wang
On 2020/6/8 下午5:45, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: Looking at pci_match_one_device() it checks both subvendor and subdevice there. Thanks But IIUC there is no guarantee that driver with a specific subvendor matches in presence of a gener

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 05:46:52PM +0800, Jason Wang wrote: > > On 2020/6/8 下午5:45, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: > > > > > Looking at > > > > > pci_match_one_device() it checks both subvendor and subdevice there. > > > > > > > > > > Tha

Re: [PATCH RFC v5 11/13] vhost/scsi: switch to buf APIs

2020-06-08 Thread Stefan Hajnoczi
On Sun, Jun 07, 2020 at 10:11:46AM -0400, Michael S. Tsirkin wrote: > Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: > all used bufs are marked with length 0. > Fix that is left for another day. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/scsi.c | 73 +

Re: [PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-08 Thread Stefan Hajnoczi
On Sun, Jun 07, 2020 at 10:11:49AM -0400, Michael S. Tsirkin wrote: > A straight-forward conversion. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vsock.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) Reviewed-by: Stefan Hajnoczi signa

RE: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-08 Thread Amit Cohen
Andrew Lunn writes: >> +Link extended states: >> + >> + >> = >> + ``Autoneg failure`` Failure during auto negotiation mechanism > >I think you need to define 'failure' here. > >Linux PHYs don't have this st

RE: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-08 Thread Amit Cohen
Andrew Lunn writes: >> +/** >> + * enum ethtool_ext_substate_cable_issue - more information in >> + * addition to ETHTOOL_EXT_STATE_CABLE_ISSUE. >> + */ >> +enum ethtool_ext_substate_cable_issue { >> +ETHTOOL_EXT_SUBSTATE_UNSUPPORTED_CABLE = 1, >> +ETHTOOL_EXT_SUBSTATE_SHORTED_CABLE, >> +

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Jason Wang
On 2020/6/8 下午5:54, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:46:52PM +0800, Jason Wang wrote: On 2020/6/8 下午5:45, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: Looking at pci_match_one_device() it checks both subvendor and subdevice there.

Re: [PATCH] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread Matthieu Baerts
Hi Geliang, On 08/06/2020 09:48, Geliang Tang wrote: In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: +---+---+---+ |Subtype|(resvd)| Address ID | +---+---+---

Re: [PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-08 Thread Stefano Garzarella
On Sun, Jun 07, 2020 at 10:11:49AM -0400, Michael S. Tsirkin wrote: > A straight-forward conversion. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vsock.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) The changes for vsock part LGTM: Rev

[PATCH net v2] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread Geliang Tang
In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: +---+---+---+ |Subtype|(resvd)| Address ID | +---+---+---+ | | ptrptr+1 We sho

Re: [PATCH] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread Geliang Tang
On Mon, Jun 08, 2020 at 12:10:23PM +0200, Matthieu Baerts wrote: > Hi Geliang, > > On 08/06/2020 09:48, Geliang Tang wrote: > > In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the > > "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: > > > >+---+

Re: [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread Matthieu Baerts
Hi Geliang, On 08/06/2020 12:47, Geliang Tang wrote: In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: +---+---+---+ |Subtype|(resvd)| Address ID | +---+---+---

Re: [PATCH] ath10k: Acquire tx_lock in tx error paths

2020-06-08 Thread Kalle Valo
Evan Green writes: > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > is held. Acquire the lock in a couple of error paths when calling that > function to ensure this condition is met. > > Fixes: 6421969f248fd ("ath10k: refactor tx pending management") > Fixes: e62ee5c381c

Re: [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh

2020-06-08 Thread Michal Kubecek
On Thu, Apr 23, 2020 at 04:39:17PM +0900, Masahiro Yamada wrote: > The user mode helper should be compiled for the same architecture as > the kernel. > > This Makefile reuses the 'hostprogs' syntax by overriding HOSTCC with CC. > > Now that Kbuild provides the syntax 'userprogs', use it to fix th

Re: [PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-06-08 Thread Tobias Brunner
Hi Steffen, Xin, This change could be problematic. Actually, it's not really this one but the original one that causes the issue: > Fixes: 7cb8a93968e3 ("xfrm: Allow inserting policies with matching mark and > different priorities") However, because the code in xfrm_policy_mark_match() treated

[PATCH] vhost/test: fix up after API change

2020-06-08 Thread Michael S. Tsirkin
Pass a flag to request kernel thread use. Fixes: 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker") Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c in

[PATCH RFC v6 00/11] vhost: ring format independence

2020-06-08 Thread Michael S. Tsirkin
This adds infrastructure required for supporting multiple ring formats. The idea is as follows: we convert descriptors to an independent format first, and process that converting to iov later. Used ring is similar: we fetch into an independent struct first, convert that to IOV later. The poin

[PATCH RFC v6 10/11] vhost/vsock: switch to the buf API

2020-06-08 Thread Michael S. Tsirkin
A straight-forward conversion. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vsock.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index a483cec31d5c..61c6d3dd2ae3 100644 --- a/drivers/vhos

[PATCH RFC v6 09/11] vhost/scsi: switch to buf APIs

2020-06-08 Thread Michael S. Tsirkin
Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/scsi.c | 73 ++-- 1 file changed, 44 insertions(+), 29 dele

[PATCH RFC v6 11/11] vhost: drop head based APIs

2020-06-08 Thread Michael S. Tsirkin
Everyone's using buf APIs, no need for head based ones anymore. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 43 --- drivers/vhost/vhost.h | 12 2 files changed, 8 insertions(+), 47 deletions(-) diff --git a/drivers/vhost/vho

[PATCH RFC v6 05/11] vhost: format-independent API for used buffers

2020-06-08 Thread Michael S. Tsirkin
Add a new API that doesn't assume used ring, heads, etc. For now, we keep the old APIs around to make it easier to convert drivers. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 52 ++- drivers/vhost/vhost.h | 17 +- 2 files cha

[PATCH RFC v6 07/11] vhost/net: avoid iov length math

2020-06-08 Thread Michael S. Tsirkin
Now that API exposes buffer length, we no longer need to scan IOVs to figure it out. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 830fe84912a5..0b509be8d7b1 10

[PATCH RFC v6 06/11] vhost/net: convert to new API: heads->bufs

2020-06-08 Thread Michael S. Tsirkin
Convert vhost net to use the new format-agnostic API. In particular, don't poke at vq internals such as the heads array. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 154 +++- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/d

[PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-08 Thread Michael S. Tsirkin
As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- drivers/vhost/vhost.c | 318

[PATCH RFC v6 04/11] vhost: reorder functions

2020-06-08 Thread Michael S. Tsirkin
Reorder functions in the file to not rely on forward declarations, in preparation to making them static down the road. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/vhost/vhost.

[PATCH RFC v6 03/11] vhost/net: pass net specific struct pointer

2020-06-08 Thread Michael S. Tsirkin
In preparation for further cleanup, pass net specific pointer to ubuf callbacks so we can move net specific fields out to net structures. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/net

[PATCH RFC v6 08/11] vhost/test: convert to the buf API

2020-06-08 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index 7d69778aaa26..12304eb8da15 100644 --- a/drivers/vhost/test.c +++ b/drivers/vhost/test.c @@ -44,9 +

[PATCH RFC v6 01/11] vhost: option to fetch descriptors through an independent struct

2020-06-08 Thread Michael S. Tsirkin
The idea is to support multiple ring formats by converting to a format-independent array of descriptors. This costs extra cycles, but we gain in ability to fetch a batch of descriptors in one go, which is good for code cache locality. When used, this causes a minor performance degradation, it's b

liquidio vs smp_call_function_single_async()

2020-06-08 Thread Peter Zijlstra
Hi, I'm going through the smp_call_function_single_async() users, and stumbled over your liquidio thingy. It does: call_single_data_t *csd = &droq->csd; csd->func = napi_schedule_wrapper; csd->info = &droq->napi; csd->flags = 0;

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 06:07:36PM +0800, Jason Wang wrote: > > On 2020/6/8 下午5:54, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2020 at 05:46:52PM +0800, Jason Wang wrote: > > > On 2020/6/8 下午5:45, Michael S. Tsirkin wrote: > > > > On Mon, Jun 08, 2020 at 05:43:58PM +0800, Jason Wang wrote: > >

Re: [PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 12:17:46PM +0200, Stefano Garzarella wrote: > On Sun, Jun 07, 2020 at 10:11:49AM -0400, Michael S. Tsirkin wrote: > > A straight-forward conversion. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/vhost/vsock.c | 30 ++ > > 1 file

Re: [PATCH] net/mlx5: E-Switch, Fix some error pointer dereferences

2020-06-08 Thread Dan Carpenter
On Sun, Jun 07, 2020 at 09:25:55AM +0300, Leon Romanovsky wrote: > On Fri, Jun 05, 2020 at 01:52:03PM +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 01:32:55PM +0300, Leon Romanovsky wrote: > > > + netdev > > > > > > > This is sort of useless. What's netdev going to do with a patch they >

Re: [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh

2020-06-08 Thread Masahiro Yamada
On Mon, Jun 8, 2020 at 8:56 PM Michal Kubecek wrote: > > On Thu, Apr 23, 2020 at 04:39:17PM +0900, Masahiro Yamada wrote: > > The user mode helper should be compiled for the same architecture as > > the kernel. > > > > This Makefile reuses the 'hostprogs' syntax by overriding HOSTCC with CC. > > >

Re: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-08 Thread Andrew Lunn
On Mon, Jun 08, 2020 at 10:02:04AM +, Amit Cohen wrote: > Andrew Lunn writes: > > >> +Link extended states: > >> + > >> + > >> = > >> + ``Autoneg failure`` Failure during auto negotiation > >> mechanis

Re: [PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-06-08 Thread Allan W. Nielsen
On 03.06.2020 13:04, Vladimir Oltean wrote: On Tue, 2 Jun 2020 at 11:38, Allan W. Nielsen wrote: Hi Xiaoliang, Happy to see that you are moving in the directions of multi chain - this seems ilke a much better fit to me. On 02.06.2020 13:18, Xiaoliang Yang wrote: >There are three hardware TC

fentry/fexit attach to EXT type XDP program does not work

2020-06-08 Thread Eelco Chaudron
I'm trying for a while to do a fentry/fexit trace an EXT program attached to an XDP program. To make it easier to explain I've created a test case (see patch below) to show the issue. Without the changes to test_xdp_bpf2bpf.c I'll get the following error: libbpf: -- BEGIN DUMP LOG --- libbpf:

Re: [PATCH] bpf_stats_record: Add null check after malloc

2020-06-08 Thread Daniel Borkmann
On 6/7/20 1:46 AM, gaurav singh wrote: Hi, The memset call is made right after malloc call. To fix this, add the null check right after malloc and then do memset. Please find the patch below. Thanks and regards, Gaurav. Hello Gaurav, your patch is whitespace damaged. Please try and resubmit

Re: [PATCH bpf] selftests/bpf: fix ringbuf selftest sample counting undeterminism

2020-06-08 Thread Daniel Borkmann
On 6/8/20 2:36 AM, Andrii Nakryiko wrote: Fix test race, in which background poll can get either 5 or 6 samples, depending on timing of notification. Prevent this by open-coding sample triggering and forcing notification for the very last sample only. Also switch to using atomic increments and e

[PATCH 1/1] devlink: fix build with musl libc

2020-06-08 Thread Dan Robertson
The devlink tool makes use of the sigaction function and structure, but does not include the signal.h header. This causes builds with musl libc to fail. According to the Open Group specification this header should be included for the sigaction function and structure definition. Fixes: c4dfddccef4e

[PATCH 0/1] devlink: fix build with musl libc

2020-06-08 Thread Dan Robertson
I was unable to compile the devlink tool with musl libc. It seems like the signal.h header should be included. Cheers, - Dan Dan Robertson (1): devlink: fix build with musl libc devlink/devlink.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode

2020-06-08 Thread Andrew Lunn
On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote: > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > called DRSGMII. > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > from DT. The MVNETA then configures the SERDES protocol value > acco

[PATCH bpf] bpf: Reset data_meta before running programs attached to devmap entry

2020-06-08 Thread David Ahern
This is a new context that does not handle metadata at the moment, so mark data_meta invalid. Fixes: fbee97feed9b ("bpf: Add support to attach bpf program to a devmap entry") Signed-off-by: David Ahern --- kernel/bpf/devmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/bpf/devmap.

[PATCH bpf] libbpf: Fix BTF-to-C conversion of noreturn function pointers

2020-06-08 Thread Jean-Philippe Brucker
When trying to convert the BTF for a function pointer marked "noreturn" to C code, bpftool currently generates a syntax error. This happens with the exit() pointer in drivers/firmware/efi/libstub/efistub.h, in an arm64 vmlinux. When dealing with this declaration: efi_status_t __noreturn (_

Re: [PATCH -next] sunrpc: use kmemdup_nul() in gssp_stringify()

2020-06-08 Thread J. Bruce Fields
Thanks, applied.--b. On Fri, May 08, 2020 at 08:40:00PM +0800, Chen Zhou wrote: > It is more efficient to use kmemdup_nul() if the size is known exactly > . > > According to doc: > "Note: Use kmemdup_nul() instead if the size is known exactly." > > Signed-off-by: Chen Zhou > --- > net/sunrpc/a

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-06-08 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > On Thu, Jun 04, 2020 at 06:02:54PM +0200, Toke Høiland-Jørgensen wrote: >> Hangbin Liu writes: >> >> > On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen >> > wrote: >> >> > Now I use the ethtool_stats.pl to count forwarding speed and here is >> >> >

Re: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-08 Thread Amit Cohen
On 07-Jun-20 22:11, Florian Fainelli wrote: > > > On 6/7/2020 7:59 AM, Amit Cohen wrote: >> Add link extended state attributes. >> >> Signed-off-by: Amit Cohen >> Reviewed-by: Petr Machata >> Reviewed-by: Jiri Pirko > > If you need to resubmit, I would swap the order of patches #4 and #5 > su

[PATCH] net: phy: mscc: handle the clkout control on some phy variants

2020-06-08 Thread Heiko Stuebner
From: Heiko Stuebner At least VSC8530/8531/8540/8541 contain a clock output that can emit a predefined rate of 25, 50 or 125MHz. This may then feed back into the network interface as source clock. So follow the example the at803x already set and introduce a vsc8531,clk-out-frequency property to

RE: [PATCH] bpf/sockmap: fix kernel panic at __tcp_bpf_recvmsg

2020-06-08 Thread John Fastabend
dihu wrote: > When user application calls read() with MSG_PEEK flag to read data > of bpf sockmap socket, kernel panic happens at > __tcp_bpf_recvmsg+0x12c/0x350. sk_msg is not removed from ingress_msg > queue after read out under MSG_PEEK flag is set. Because it's not > judged whether sk_msg is th

Re: [PATCH] ath10k: Acquire tx_lock in tx error paths

2020-06-08 Thread Evan Green
On Mon, Jun 8, 2020 at 4:39 AM Kalle Valo wrote: > > Evan Green writes: > > > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > > is held. Acquire the lock in a couple of error paths when calling that > > function to ensure this condition is met. > > > > Fixes: 6421969f248f

Re: [PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode

2020-06-08 Thread Russell King - ARM Linux admin
On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote: > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > called DRSGMII. > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > from DT. The MVNETA then configures the SERDES protocol value > acco

RE: packed structures used in socket options

2020-06-08 Thread David Laight
From: Ivan Skytte Jørgensen > Sent: 07 June 2020 22:35 ... > > > contains: > > > > > > struct sctp_paddrparams { > > > sctp_assoc_tspp_assoc_id; > > > struct sockaddr_storage spp_address; > > > __u32 spp_hbinterval; > > > >>

[PATCH bpf] bpf: cgroup: allow multi-attach program to replace itself

2020-06-08 Thread Lorenz Bauer
When using BPF_PROG_ATTACH to attach a program to a cgroup in BPF_F_ALLOW_MULTI mode, it is not possible to replace a program with itself. This is because the check for duplicate programs doesn't take the replacement program into account. Replacing a program with itself might seem weird, but it ha

Re: [PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-08 Thread Stefano Garzarella
On Mon, Jun 08, 2020 at 09:30:38AM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 08, 2020 at 12:17:46PM +0200, Stefano Garzarella wrote: > > On Sun, Jun 07, 2020 at 10:11:49AM -0400, Michael S. Tsirkin wrote: > > > A straight-forward conversion. > > > > > > Signed-off-by: Michael S. Tsirkin > >

Re: [PATCH] net: phy: mscc: handle the clkout control on some phy variants

2020-06-08 Thread Andrew Lunn
On Mon, Jun 08, 2020 at 06:02:07PM +0200, Heiko Stuebner wrote: > +static int vsc8531_probe(struct phy_device *phydev) > +{ > + struct vsc8531_private *vsc8531; > + int rate_magic; > + u32 default_mode[2] = {VSC8531_LINK_1000_ACTIVITY, > +VSC8531_LINK_100_ACTIVITY}; > + > +

[PATCH bpf 0/3] bpf: avoid using/returning file descriptor value zero

2020-06-08 Thread Jesper Dangaard Brouer
Make it easier to handle UAPI/kABI extensions by avoid BPF using/returning file descriptor value zero. Use this in recent devmap extension to keep older applications compatible with newer kernels. For special type maps (e.g. devmap and cpumap) the map-value data-layout is a configuration interface

[PATCH bpf 3/3] bpf: selftests and tools use struct bpf_devmap_val from uapi

2020-06-08 Thread Jesper Dangaard Brouer
Sync tools uapi bpf.h header file and update selftests that use struct bpf_devmap_val. Signed-off-by: Jesper Dangaard Brouer --- tools/include/uapi/linux/bpf.h | 18 ++ .../selftests/bpf/prog_tests/xdp_devmap_attach.c |8 .../selftests/bpf/pro

[PATCH bpf 2/3] bpf: devmap adjust uapi for attach bpf program

2020-06-08 Thread Jesper Dangaard Brouer
The recent commit fbee97feed9b ("bpf: Add support to attach bpf program to a devmap entry"), introduced ability to attach (and run) a separate XDP bpf_prog for each devmap entry. A bpf_prog is added via a file-descriptor. As zero were a valid FD, not using the feature requires using value minus-1.

[PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Jesper Dangaard Brouer
This patch change BPF syscall to avoid returning file descriptor value zero. As mentioned in cover letter, it is very impractical when extending kABI that the file-descriptor value 'zero' is valid, as this requires new fields must be initialised as minus-1. First step is to change the kernel such

Re: [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-06-08 Thread Anchal Agarwal
On Fri, Jun 05, 2020 at 05:39:54PM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 6/4/20 7:03 PM, Anchal Agarwal wrote: > > On

Re: fentry/fexit attach to EXT type XDP program does not work

2020-06-08 Thread Yonghong Song
On 6/8/20 7:11 AM, Eelco Chaudron wrote: I'm trying for a while to do a fentry/fexit trace an EXT program attached to an XDP program. To make it easier to explain I've created a test case (see patch below) to show the issue. Without the changes to test_xdp_bpf2bpf.c I'll get the following erro

Re: [PATCH RFC v6 10/11] vhost/vsock: switch to the buf API

2020-06-08 Thread Stefano Garzarella
On Mon, Jun 08, 2020 at 08:53:13AM -0400, Michael S. Tsirkin wrote: > A straight-forward conversion. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vsock.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) I ran the vsock tests again with this

Re: [PATCH 04/12] x86/xen: add system core suspend and resume callbacks

2020-06-08 Thread Anchal Agarwal
On Fri, Jun 05, 2020 at 05:24:37PM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 6/3/20 6:40 PM, Agarwal, Anchal wrote: > >

Re: [PATCH RFC v6 00/11] vhost: ring format independence

2020-06-08 Thread Stefano Garzarella
Hi Michael, On Mon, Jun 08, 2020 at 08:52:51AM -0400, Michael S. Tsirkin wrote: > > > This adds infrastructure required for supporting > multiple ring formats. > > The idea is as follows: we convert descriptors to an > independent format first, and process that converting to > iov later. > > U

Re: packed structures used in socket options

2020-06-08 Thread Michael Tuexen
> On 8. Jun 2020, at 18:18, David Laight wrote: > > From: Ivan Skytte Jørgensen >> Sent: 07 June 2020 22:35 > ... contains: struct sctp_paddrparams { sctp_assoc_tspp_assoc_id; struct sockaddr_storage spp_address;

Re: [PATCH ghak90 V8 07/16] audit: add contid support for signalling the audit daemon

2020-06-08 Thread Richard Guy Briggs
On 2020-04-22 13:24, Paul Moore wrote: > On Fri, Apr 17, 2020 at 6:26 PM Eric W. Biederman > wrote: > > Paul Moore writes: > > > On Thu, Apr 16, 2020 at 4:36 PM Eric W. Biederman > > > wrote: > > >> Paul Moore writes: > > >> > On Mon, Mar 30, 2020 at 1:49 PM Richard Guy Briggs > > >> > wrot

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > This patch change BPF syscall to avoid returning file descriptor value zero. > > As mentioned in cover letter, it is very impractical when extending kABI > that the file-descriptor value 'zero' is valid, as this requires new fields > must be initialised as minus-1

Re: [PATCH bpf 2/3] bpf: devmap adjust uapi for attach bpf program

2020-06-08 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > The recent commit fbee97feed9b ("bpf: Add support to attach bpf program to a > devmap entry"), introduced ability to attach (and run) a separate XDP > bpf_prog for each devmap entry. A bpf_prog is added via a file-descriptor. > As zero were a valid FD, not using t

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Andrii Nakryiko
On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer wrote: > > This patch change BPF syscall to avoid returning file descriptor value zero. > > As mentioned in cover letter, it is very impractical when extending kABI > that the file-descriptor value 'zero' is valid, as this requires new fields >

[RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > I'll go away and roll a v2 moving qca8k over to phylink and then using > that to auto select the appropriate SGMII mode. Thanks for the feedback. Ok, take 2. I've switched the driver over to phylink which has let me drop the need

[PATCH net 0/2] rxrpc: Fix hang due to missing notification

2020-06-08 Thread David Howells
Here's a fix for AF_RXRPC. Occasionally calls hang because there are circumstances in which rxrpc generate a notification when a call is completed - primarily because initial packet transmission failed and the call was killed off and an error returned. But the AFS filesystem driver doesn't chec

[PATCH net 2/2] rxrpc: Fix missing notification

2020-06-08 Thread David Howells
Under some circumstances, rxrpc will fail a transmit a packet through the underlying UDP socket (ie. UDP sendmsg returns an error). This may result in a call getting stuck. In the instance being seen, where AFS tries to send a probe to the Volume Location server, tracepoints show the UDP Tx failu

[PATCH net 1/2] rxrpc: Move the call completion handling out of line

2020-06-08 Thread David Howells
Move the handling of call completion out of line so that the next patch can add more code in that area. Signed-off-by: David Howells Reviewed-by: Marc Dionne --- net/rxrpc/ar-internal.h | 119 ++- net/rxrpc/recvmsg.c | 74 +

Re: [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-06-08 Thread Boris Ostrovsky
On 6/8/20 12:52 PM, Anchal Agarwal wrote: > > +void xen_hvm_map_shared_info(void) > +{ > + xen_hvm_init_shared_info(); > + if (shared_info_pfn) > + HYPERVISOR_shared_info = __va(PFN_PHYS(shared_info_pfn)); > +} > + AFAICT it is only called once s

Re: [RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Andrew Lunn
On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote: > On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > > I'll go away and roll a v2 moving qca8k over to phylink and then using > > that to auto select the appropriate SGMII mode. Thanks for the feedback. > > Ok, ta

Re: [RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Russell King - ARM Linux admin
Hi Jonathan, A quick read through on the first review... On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote: > +static int > +qca8k_phylink_mac_link_state(struct dsa_switch *ds, int port, > + struct phylink_link_state *state) > +{ > + struct qca8k_priv

[PATCH net] selftests/net: in timestamping, strncpy needs to preserve null byte

2020-06-08 Thread Tanner Love
From: tannerlove If user passed an interface option longer than 15 characters, then device.ifr_name and hwtstamp.ifr_name became non-null-terminated strings. The compiler warned about this: timestamping.c:353:2: warning: ‘strncpy’ specified bound 16 equals \ destination size [-Wstringop-truncati

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Jesper Dangaard Brouer
On Mon, 8 Jun 2020 11:36:33 -0700 Andrii Nakryiko wrote: > On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer > wrote: > > > > This patch change BPF syscall to avoid returning file descriptor value zero. > > > > As mentioned in cover letter, it is very impractical when extending kABI > > tha

Re: [PATCH bpf 1/3] bpf: syscall to start at file-descriptor 1

2020-06-08 Thread Andrii Nakryiko
-- Andrii On Mon, Jun 8, 2020 at 12:45 PM Jesper Dangaard Brouer wrote: > > On Mon, 8 Jun 2020 11:36:33 -0700 > Andrii Nakryiko wrote: > > > On Mon, Jun 8, 2020 at 9:51 AM Jesper Dangaard Brouer > > wrote: > > > > > > This patch change BPF syscall to avoid returning file descriptor value > >

Re: [GIT] Networking

2020-06-08 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 17:11:11 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git > refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2 Thank you! -- Deet-do

[PATCH net-next 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
Slave devices in a bond doing hardware encryption also need to be aware that they're slaves, so we operate on the slave instead of the bonding master to do the actual hardware encryption offload bits. CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirs

[PATCH net-next 3/4] bonding: support hardware encryption offload to slaves

2020-06-08 Thread Jarod Wilson
Currently, this support is limited to active-backup mode, as I'm not sure about the feasilibity of mapping an xfrm_state's offload handle to multiple hardware devices simultaneously, and we rely on being able to pass some hints to both the xfrm and NIC driver about whether or not they're operating

[PATCH net-next 4/4] mlx5: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
I've been unable to get my hands on suitable supported hardware to date, but I believe this ought to be all that is needed to enable the mlx5 driver to also work with bonding active-backup crypto offload passthru. CC: Boris Pismenny CC: Saeed Mahameed CC: Leon Romanovsky CC: Jay Vosburgh CC: V

[PATCH net-next 1/4] xfrm: bail early on slave pass over skb

2020-06-08 Thread Jarod Wilson
This is prep work for initial support of bonding hardware encryption pass-through support. The bonding driver will fill in the slave_dev pointer, and we use that to know not to skb_push() again on a given skb that was already processed on the bond device. CC: Jay Vosburgh CC: Veaceslav Falico CC

Re: [PATCH 8/8 net] net: remove indirect block netdev event registration

2020-06-08 Thread Jacob Keller
On 5/13/2020 9:41 AM, Pablo Neira Ayuso wrote: > Drivers do not register to netdev events to set up indirect blocks > anymore. Remove __flow_indr_block_cb_register() and > __flow_indr_block_cb_unregister(). > > The frontends set up the callbacks through flow_indr_dev_setup_block() > > Signed-o

Re: [PATCH] virtio_net: Unregister and re-register xdp_rxq across freeze/restore

2020-06-08 Thread Sean Christopherson
On Sun, Jun 07, 2020 at 09:23:03AM -0400, Michael S. Tsirkin wrote: > On Fri, Jun 05, 2020 at 02:46:24PM -0700, Sean Christopherson wrote: > > @@ -1480,17 +1495,10 @@ static int virtnet_open(struct net_device *dev) > > if (!try_fill_recv(vi, &vi->rq[i], GFP_KERNEL)) > >

RE: packed structures used in socket options

2020-06-08 Thread David Laight
From: Michael Tuexen > Sent: 08 June 2020 18:37 > > On 8. Jun 2020, at 18:18, David Laight wrote: > > > > From: Ivan Skytte Jørgensen > >> Sent: 07 June 2020 22:35 > > ... > contains: > > struct sctp_paddrparams { > sctp_assoc_tspp_assoc_id; > >

Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs

2020-06-08 Thread Nathan Chancellor
On Thu, Jun 04, 2020 at 04:44:00AM +, Saeed Mahameed wrote: > On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote: > > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote: > > > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky

Re: [PATCH 8/8 net] net: remove indirect block netdev event registration

2020-06-08 Thread Pablo Neira Ayuso
On Mon, Jun 08, 2020 at 02:07:57PM -0700, Jacob Keller wrote: > > > On 5/13/2020 9:41 AM, Pablo Neira Ayuso wrote: > > Drivers do not register to netdev events to set up indirect blocks > > anymore. Remove __flow_indr_block_cb_register() and > > __flow_indr_block_cb_unregister(). > > > > The fro

  1   2   3   4   5   >