linux-next: build failure after merge of the mmc tree

2020-06-01 Thread Stephen Rothwell
Hi all, After merging the mmc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: In function 'brcmf_sdiod_probe': drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:915:7: error: 'SDIO_DEVICE_ID_CYPRESS_437

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-01 Thread Nathan Chancellor
On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > > 'err' is used uninitialized whenever 'if' condition is true > >

Re: [PATCH 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:43:09PM -0700, John Hubbard wrote: > This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to p

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread Victor Julien
On 01-06-2020 23:45, David Miller wrote: > From: Victor Julien > Date: Mon, 1 Jun 2020 22:49:37 +0200 > >> @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALIDThis flag indicates that at >> least the transport >> validated on the kernel side. If the flag is not set >>

Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

2020-06-01 Thread Boris Pismenny
On 02/06/2020 1:12, Jakub Kicinski wrote: > On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote: >> On 30/05/2020 0:50, Jakub Kicinski wrote: >> >>> IIUC every ooo packet causes a resync request in your >>> implementation - is that true? >>> >> No, only header loss. We never required a resyn

[net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

2020-06-01 Thread Tuong Lien
This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. There is no actual tipc_node refcnt leak as stated in the above commit. The refcnt is hold carefully for the case of an asynchronous decryption (i.e. -EINPROGRESS/-EBUSY and skb = NULL is returned), so that the node object cannot be fre

[net 0/2] tipc: revert two patches

2020-06-01 Thread Tuong Lien
We revert two patches: tipc: Fix potential tipc_node refcnt leak in tipc_rcv tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv which prevented TIPC encryption from working properly and caused kernel panic. Tuong Lien (2): Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv

[net 2/2] Revert "tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv"

2020-06-01 Thread Tuong Lien
This reverts commit 441870ee4240cf67b5d3ab8e16216a9ff42eb5d6. Like the previous patch in this series, we revert the above commit that causes similar issues with the 'aead' object. Acked-by: Jon Maloy Signed-off-by: Tuong Lien --- net/tipc/crypto.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Michael S. Tsirkin
Wang/vDPA-doorbell-mapping/20200531-070834 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > linux-next > config: m68k-randconfig-r011-20200601 (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wg

Re: [PATCH 1/6] vhost: allow device that does not depend on vhost worker

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:02:58PM +0800, Jason Wang wrote: > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index d450e16c5c25..70105e045768 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -166,11 +166,16 @@ static int vhost_poll_wakeup(wait_queue_entry_t *wai

[PATCH bpf-next] selftests/bpf: fix sample_cnt shared between two threads

2020-06-01 Thread Andrii Nakryiko
Make sample_cnt volatile to fix possible selftests failure due to compiler optimization preventing latest sample_cnt value to be visible to main thread. sample_cnt is incremented in background thread, which is then joined into main thread. So in terms of visibility sample_cnt update is ok. But beca

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: > +static void vp_vdpa_set_vq_ready(struct vdpa_device *vdpa, > + u16 qid, bool ready) > +{ > + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa); > + > + vp_iowrite16(qid, &vp_vdpa->common->queue_select); > +

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-01 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: > Note that since virtio specification does not support get/restore > virtqueue state. So we can not use this driver for VM. This can be > addressed by extending the virtio specification. Looks like exactly the kind of hardware limitation

[PATCH v2 net-next 01/10] net: mscc: ocelot: introduce a new ocelot_target_{read,write} API

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean There are some targets (register blocks) in the Ocelot switch that are instantiated more than once. For example, the VCAP IS1, IS2 and ES0 blocks all share the same register layout for interacting with the cache for the TCAM and the action RAM. For the VCAPs, the procedure

[PATCH v2 net-next 05/10] net: mscc: ocelot: VCAP IS1 support

2020-06-01 Thread Xiaoliang Yang
VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and TCP/UDP ports keys, and do Qos classified and VLAN retag actions. This patch added VCAP IS1 support in ocelot ace driver, which can supports vlan modify and skbedit priority action of tc filter. Usage: tc qdisc add dev

[PATCH v2 net-next 02/10] net: mscc: ocelot: generalize existing code for VCAP

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean The Ocelot driver only supports VCAP IS2, the security enforcement block which implements Access Control List actions (trap, drop, police). In preparation of VCAP IS1 support, generalize the existing code to work with any VCAP. In that direction, move all VCAP instantiation

[PATCH v2 net-next 06/10] net: mscc: ocelot: VCAP ES0 support

2020-06-01 Thread Xiaoliang Yang
VCAP ES0 is an egress VCAP working on all outgoing frames. This patch added ES0 driver to support vlan push action of tc filter. Usage: tc filter add dev swp1 egress protocol 802.1Q flower skip_sw vlan_id 1 vlan_prio 1 action vlan push id 2 priority 2 Signed-off-by: Xiaoliang Yang

[PATCH v2 net-next 09/10] net: dsa: felix: correct VCAP IS2 keys offset

2020-06-01 Thread Xiaoliang Yang
Some of IS2 IP4_TCP_UDP keys are not correct, like L4_DPORT, L4_SPORT and other L4 keys. It causes the issue that VCAP IS2 could not filter a right dst/src port for TCP/UDP packages. Signed-off-by: Xiaoliang Yang --- drivers/net/dsa/ocelot/felix_vsc9959.c | 16 1 file changed, 8

[PATCH v2 net-next 08/10] net: ocelot: return error if rule is not found

2020-06-01 Thread Xiaoliang Yang
Return error if rule is not found in rule list to avoid Kernel panic. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_a

[PATCH v2 net-next 03/10] net: mscc: ocelot: allocated rules to different hardware VCAP TCAMs by chain index

2020-06-01 Thread Xiaoliang Yang
There are three hardware TCAMs for ocelot chips: IS1, IS2 and ES0. Each one supports different actions. The hardware flow order is: IS1->IS2->ES0. This patch add three blocks to store rules according to chain index. chain 0 is offloaded to IS1, chain 1 is offloaded to IS2, and egress chain 0 is of

[PATCH v2 net-next 07/10] net: mscc: ocelot: multiple actions support

2020-06-01 Thread Xiaoliang Yang
Support multiple actions for each flower rule, multiple actions can only set on the same VCAP, and all actions can mix with action goto chain. Action drop, trap, and police on VCAP IS2 could not be mixed. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace.c| 15 +-

[PATCH v2 net-next 10/10] net: dsa: tag_ocelot: use VLAN information from tagging header when available

2020-06-01 Thread Xiaoliang Yang
From: Vladimir Oltean When the Extraction Frame Header contains a valid classified VLAN, use that instead of the VLAN header present in the packet. Signed-off-by: Vladimir Oltean --- net/dsa/tag_ocelot.c | 29 + 1 file changed, 29 insertions(+) diff --git a/net/dsa

[PATCH v2 net-next 04/10] net: mscc: ocelot: change vcap to be compatible with full and quad entry

2020-06-01 Thread Xiaoliang Yang
When calculating vcap data offset, the function only supports half key entry. This patch modify vcap_data_offset_get function to calculate a correct data offset when setting VCAP Type-Group to VCAP_TG_FULL or VCAP_TG_QUARTER. Signed-off-by: Xiaoliang Yang --- drivers/net/ethernet/mscc/ocelot_ace

[PATCH v2 net-next 00/10] net: ocelot: VCAP IS1 and ES0 support

2020-06-01 Thread Xiaoliang Yang
This series patches adds support for VCAP IS1 and ES0 module, each VCAP correspond to a flow chain to offload. VCAP IS1 supports FLOW_ACTION_VLAN_MANGLE action to filter MAC, IP, VLAN, protocol, and TCP/UDP ports keys and retag vlian tag, FLOW_ACTION_PRIORITY action to classify packages to differe

Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums

2020-06-01 Thread Michael Forney
Hi, On 2020-03-04, Daniel Borkmann wrote: > I was about to push the series out, but agree that there may be a risk for > #ifndefs > in the BPF C code. If we want to be on safe side, #define FOO FOO would be > needed. I did indeed hit some breakage due to this change, but not for the anticipated

Re: [net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

2020-06-01 Thread hoang.h.le
On Tue, Jun 02, 2020 at 11:46:40AM +0700, Tuong Lien wrote: Tested-by: Hoang Le > This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. > > There is no actual tipc_node refcnt leak as stated in the above commit. > The refcnt is hold carefully for the case of an asynchronous decryption >

Re: netif_device_present() and Runtime PM / PCI D3

2020-06-01 Thread Heiner Kallweit
On 31.05.2020 17:05, Andrew Lunn wrote: > On Sun, May 31, 2020 at 02:07:46PM +0200, Heiner Kallweit wrote: >> I just wonder about the semantics of netif_device_present(). >> If a device is in PCI D3 (e.g. being runtime-suspended), then it's >> not accessible. So is it present or not? >> The descrip

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 09:50:23PM CEST, xiyou.wangc...@gmail.com wrote: >On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko wrote: >> The first command just says "early drop position should be processed by >> block 10" >> >> The second command just adds a filter to the block 10. > >This is exactly why it loo

Re: [PATCH v2 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-01 Thread Pankaj Gupta
> This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to pin_user_pages*() + unpin_user_pages() calls. > > There is some

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 09:59:30AM -0700, Rao Shoaib wrote: > > On 5/29/20 4:41 PM, David Miller wrote: > > From: rao.sho...@oracle.com > > Date: Wed, 27 May 2020 01:17:42 -0700 > > > > > diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h > > > index cba368e55863..7273c681e6c1 100644

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 10:08:44AM -0700, Rao Shoaib wrote: > > On 5/31/20 3:08 AM, Leon Romanovsky wrote: > > On Wed, May 27, 2020 at 01:17:42AM -0700, rao.sho...@oracle.com wrote: > > > From: Rao Shoaib > > > > > > This enhancement auto loads transport module when the transport > > > is set via

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 11:44:36PM CEST, k...@kernel.org wrote: >On Mon, 1 Jun 2020 08:39:18 +0200 Jiri Pirko wrote: >> > If the permanent (NVRAM) parameter is true, all loaded new drivers >> > will indicate support for this feature and set the runtime value to >> > true by default. The runtime value

RE: [RFC PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-01 Thread ASIX_Allan [Office]
Hi Louis, Please help to take care of this problem. Thanks a lot. --- Best regards, Allan Chou ASIX Electronics Corporation TEL: 886-3-5799500 ext.228 FAX: 886-3-5799558 E-mail: al...@asix.com.tw https://www.asix.com.tw/ -Original Message- From: Jeremy Kerr Sent: Tuesday, June 2,

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Tue, Jun 02, 2020 at 01:24:16AM CEST, k...@kernel.org wrote: >On Mon, 1 Jun 2020 21:01:42 +0530 Vasundhara Volam wrote: >> > I think that the legacy ethtool should stick with the "ordinary fw reset", >> > becase that is what user expects. You should add an attribute to >> > "devlink dev reload" to

[PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set

2020-06-01 Thread Rohit Maheshwari
cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which is under CONFIG_CHELSIO_TLS_DEVICE macro. Signed-off-by: Rohit Maheshwari --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cx

[PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

2020-06-01 Thread YueHaibing
dumpit info is freed by cb->done now (genl_lock_done()/ genl_parallel_done()), however if any error occurs before cb->done is called, info and attrs will leak. unreferenced object 0x888119904840 (size 32): comm "syz-executor.0", pid 857, jiffies 4295306979 (age 18.692s) hex dump (first 32 byte

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Jason Wang
ll-mapping/20200531-070834 base:https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-randconfig-r011-20200601 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wgethttps://raw.githubusercontent.com/intel/lkp-tests/m

[PATCH] seg6: Fix slab-out-of-bounds in fl6_update_dst()

2020-06-01 Thread YueHaibing
When update flowi6 daddr in fl6_update_dst() for srcrt, the used index of segments should be segments_left minus one per RFC8754 (section 4.3.1.1) S15 S16. Otherwise it may results in an out-of-bounds read. Reported-by: syzbot+e8c028b62439eac42...@syzkaller.appspotmail.com Fixes: 0cb7498f234e ("se

<    1   2   3