pull request: bluetooth-next 2020-06-01

2020-06-01 Thread Johan Hedberg
Hi Dave, Here's one last bluetooth-next pull request for 5.8, which I hope can still be accepted. - Enabled Wide-Band Speech (WBS) support for Qualcomm wcn3991 - Multiple fixes/imprvovements to Qualcomm-based devices - Fix GAP/SEC/SEM/BI-10-C qualfication test case - Added support for Broadco

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Tue, May 26, 2020 at 04:23:48PM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Tue, May 26, 2020 at 7:10 PM Jiri Pirko wrote: >> >> Tue, May 26, 2020 at 08:42:28AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Tue, May 26, 2020 at 10:17 AM Jiri Pirko wrote: >> >> >> >> Tue, May 26, 2020 a

[PATCH net v4] cxgb4/chcr: Enable ktls settings at run time

2020-06-01 Thread Rohit Maheshwari
Current design enables ktls setting from start, which is not efficient. Now the feature will be enabled when user demands TLS offload on any interface. v1->v2: - taking ULD module refcount till any single connection exists. - taking rtnl_lock() before clearing tls_devops. v2->v3: - cxgb4 is now r

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Sergei Shtylyov
Hello! On 31.05.2020 21:07, Vladimir Oltean wrote: From: Vladimir Oltean Sometimes debugging a device is easiest using devmem on its register map, and that can be seen with /proc/iomem. But some device drivers have many memory regions. Take for example a networking switch. Its memory map used

RE: [PATCH 2/4] sctp: refactor sctp_setsockopt_bindx

2020-06-01 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 29 May 2020 17:06 > On Fri, May 29, 2020 at 02:09:41PM +0200, Christoph Hellwig wrote: > > Split out a sctp_setsockopt_bindx_kernel that takes a kernel pointer > > to the sockaddr and make sctp_setsockopt_bindx a small wrapper around > > it. This prepares for

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 12:09 PM Jiri Pirko wrote: > > Wed, May 27, 2020 at 10:57:11PM CEST, michael.c...@broadcom.com wrote: > >On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: > >> > >> On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: > >> > Here is a sample sequence of commands t

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 12:48 PM Jiri Pirko wrote: > > Tue, May 26, 2020 at 04:23:48PM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Tue, May 26, 2020 at 7:10 PM Jiri Pirko wrote: > >> > >> Tue, May 26, 2020 at 08:42:28AM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >On Tue, May 26

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: > > Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: > >Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >>Live device reset capability allows the users to reset the device in real > >>time. For example, a

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Vladimir Oltean
Hi Sergei, On Mon, 1 Jun 2020 at 10:51, Sergei Shtylyov wrote: > > Hello! > > On 31.05.2020 21:07, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > Sometimes debugging a device is easiest using devmem on its register > > map, and that can be seen with /proc/iomem. But some device drive

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Greg Kroah-Hartman
On Mon, Jun 01, 2020 at 12:36:08PM +0300, Vladimir Oltean wrote: > Hi Sergei, > > On Mon, 1 Jun 2020 at 10:51, Sergei Shtylyov > wrote: > > > > Hello! > > > > On 31.05.2020 21:07, Vladimir Oltean wrote: > > > > > From: Vladimir Oltean > > > > > > Sometimes debugging a device is easiest using dev

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 10:50:50AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 12:09 PM Jiri Pirko wrote: >> >> Wed, May 27, 2020 at 10:57:11PM CEST, michael.c...@broadcom.com wrote: >> >On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: >> >> >> >> On Wed, 27 May 2020 09

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 10:53:19AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 12:48 PM Jiri Pirko wrote: >> >> Tue, May 26, 2020 at 04:23:48PM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Tue, May 26, 2020 at 7:10 PM Jiri Pirko wrote: >> >> >> >> Tue, May 26, 2020 at

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: >> >> Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: >> >Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >>Live device rese

Re: Self-XORing BPF registers is undefined behavior

2020-06-01 Thread Edward Cree
On 29/05/2020 13:28, Alexander Potapenko wrote:> If the performance is really critical here, perhaps a better > alternative is to introduce a BPF instruction (which could be an alias > of BPF_XOR REG, REG) for zeroing out a register? Then different > architectures may choose more efficient impleme

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:19 PM Jiri Pirko wrote: > > Mon, Jun 01, 2020 at 10:50:50AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Jun 1, 2020 at 12:09 PM Jiri Pirko wrote: > >> > >> Wed, May 27, 2020 at 10:57:11PM CEST, michael.c...@broadcom.com wrote: > >> >On Wed, May 27, 2020 at 1:1

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: [...] > Documentation/networking/devlink/bnxt.rst | 4 ++ > .../networking/devlink/devlink-params.rst | 28 ++ > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- > drivers/net/e

[PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Vladimir Oltean
From: Vladimir Oltean Sometimes debugging a device is easiest using devmem on its register map, and that can be seen with /proc/iomem. But some device drivers have many memory regions. Take for example a networking switch. Its memory map used to look like this in /proc/iomem: 1fc00-1fc3f

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:20 PM Jiri Pirko wrote: > > Mon, Jun 01, 2020 at 10:53:19AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Jun 1, 2020 at 12:48 PM Jiri Pirko wrote: > >> > >> Tue, May 26, 2020 at 04:23:48PM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >On Tue, May 26,

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: >> >> Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: >> >Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >>Live device rese

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Greg KH
On Mon, Jun 01, 2020 at 12:58:26PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > Sometimes debugging a device is easiest using devmem on its register > map, and that can be seen with /proc/iomem. But some device drivers have > many memory regions. Take for example a networking switch.

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 11:57:28AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 3:19 PM Jiri Pirko wrote: >> >> Mon, Jun 01, 2020 at 10:50:50AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Mon, Jun 1, 2020 at 12:09 PM Jiri Pirko wrote: >> >> >> >> Wed, May 27, 2020 at

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 11:59:38AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 3:20 PM Jiri Pirko wrote: >> >> Mon, Jun 01, 2020 at 10:53:19AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Mon, Jun 1, 2020 at 12:48 PM Jiri Pirko wrote: >> >> >> >> Tue, May 26, 2020 at

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:22 PM Jiri Pirko wrote: > > Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: > >> > >> Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: > >> >Sun, May 31, 2020 at 09:03:39AM CEST

Re: [PATCH v4 00/11] Stop monitoring disabled devices

2020-06-01 Thread Peter Kästle
Hi, 28. Mai 2020 21:21, "Andrzej Pietrasiewicz" schrieb: [...] > This v4 series addresses those concerns: it takes a more gradual > approach and uses explicit tzd state initialization, hence there are more > insertions than in v3, and the net effect is -63 lines versus -139 lines > in v3. I'd

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:28 PM Jiri Pirko wrote: > > Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: > > [...] > > > Documentation/networking/devlink/bnxt.rst | 4 ++ > > .../networking/devlink/devlink-params.rst | 28 ++ > > drivers/net/ethern

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Vladimir Oltean
Hi Greg, On Mon, 1 Jun 2020 at 13:04, Greg KH wrote: > > On Mon, Jun 01, 2020 at 12:58:26PM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Sometimes debugging a device is easiest using devmem on its register > > map, and that can be seen with /proc/iomem. But some device drivers

Re: [PATCH v4 00/11] Stop monitoring disabled devices

2020-06-01 Thread Andrzej Pietrasiewicz
W dniu 01.06.2020 o 12:02, Peter Kästle pisze: Hi, 28. Mai 2020 21:21, "Andrzej Pietrasiewicz" schrieb: [...] This v4 series addresses those concerns: it takes a more gradual approach and uses explicit tzd state initialization, hence there are more insertions than in v3, and the net effect i

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Greg KH
On Mon, Jun 01, 2020 at 01:13:16PM +0300, Vladimir Oltean wrote: > Hi Greg, > > On Mon, 1 Jun 2020 at 13:04, Greg KH wrote: > > > > On Mon, Jun 01, 2020 at 12:58:26PM +0300, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > Sometimes debugging a device is easiest using devmem on its

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jiri Pirko
Mon, Jun 01, 2020 at 12:08:14PM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Jun 1, 2020 at 3:22 PM Jiri Pirko wrote: >> >> Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: >> >> >> >> Mon, Jun 01, 2020 at

Re: [PATCH] staging: qlge: qlge_main.c: fixed spaces coding style issues

2020-06-01 Thread Jil Rouceau
On Mon, 1 Jun 2020 14:19:47 +0900 Benjamin Poirier wrote: > On 2020-05-29 17:17 +0200, Jil Rouceau wrote: > > Fixed the missing spaces before and after binary operators. > > > > Signed-off-by: Jil Rouceau > > This patch does not apply cleanly. I think your base tree is missing > commit ec269

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Andy Shevchenko
On Mon, Jun 1, 2020 at 12:13 AM Vladimir Oltean wrote: > On Mon, 1 Jun 2020 at 00:05, Andy Shevchenko > wrote: > > On Sunday, May 31, 2020, Vladimir Oltean wrote: > >> Sometimes debugging a device is easiest using devmem on its register > >> map, and that can be seen with /proc/iomem. But some

Re: [PATCH v2] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Vladimir Oltean
On Mon, 1 Jun 2020 at 13:39, Andy Shevchenko wrote: > > On Mon, Jun 1, 2020 at 12:13 AM Vladimir Oltean wrote: > > On Mon, 1 Jun 2020 at 00:05, Andy Shevchenko > > wrote: > > > On Sunday, May 31, 2020, Vladimir Oltean wrote: > > > >> Sometimes debugging a device is easiest using devmem on its

[PATCH v2] staging: qlge: qlge_main.c: fixed spaces coding style issues

2020-06-01 Thread Jil Rouceau
Fixed the missing spaces before and after binary operators. Signed-off-by: Jil Rouceau --- Changes in v2: - Based tree changed from Linus' to linux-next. drivers/staging/qlge/qlge_main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/stagi

Re: ABI breakage in sctp_event_subscribe (was [PATCH net-next 0/4] sctp: add some missing events from rfc5061)

2020-06-01 Thread Harald Welte
Dear SCTP developers, I have to get back to this bug. It is slowly turning into a nightmare. Not only affected it forwards/backwards compatibility of application binaries during upgrades of a distribution, but it also affects the ability to run containerized workloads with SCTP. It's sort-of ob

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-06-01 Thread Vadym Kochan
Hi Ido, On Sat, May 30, 2020 at 06:48:01PM +0300, Ido Schimmel wrote: > On Thu, May 28, 2020 at 06:12:40PM +0300, Vadym Kochan wrote: > [...] > Nit: "From" ? > > > + PRESTERA_DSA_CMD_FROM_CPU, > > +}; > > + > > +struct prestera_dsa_vlan { > > + u16 vid; > > + u8 vpt; > > + u8 cfi_bit;

Re: [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization

2020-06-01 Thread Mark Brown
On Sun, May 31, 2020 at 03:26:28PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > Similar to the standalone regfields, add an initializer for the users > who need to set .id_size and .id_offset in order to use the > regmap_fields_update_bits_base API. > > Signed-off-by: Vladimir Oltea

[PATCH net-next v5] hinic: add set_channels ethtool_ops support

2020-06-01 Thread Luo bin
add support to change TX/RX queue number with "ethtool -L combined". V4 -> V5: change time zone in patch header V4 -> V3: update date in patch header V3 -> V2: remove check for zero channels->combined_count V1 -> V2: update commit message("ethtool -L" to "ethtool -L combined") V0 -> V1: remove che

Re: [PATCH net-next 1/1] wireguard: reformat to 100 column lines

2020-06-01 Thread Joe Perches
On Mon, 2020-06-01 at 00:29 -0600, Jason A. Donenfeld wrote: > While this sort of change is typically viewed as "trivial", "cosmetic", > or even "bikesheddy", I think there's a very serious argument to be made > about the readability and comprehensibility of the code as a result. Hey Jason. I thi

Re: [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization

2020-06-01 Thread Vladimir Oltean
Hi Mark, On Mon, 1 Jun 2020 at 13:54, Mark Brown wrote: > > On Sun, May 31, 2020 at 03:26:28PM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Similar to the standalone regfields, add an initializer for the users > > who need to set .id_size and .id_offset in order to use the > >

[PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread patrickeigensatz
From: Patrick Eigensatz After allocating the spare nexthop group it should be tested for kzalloc() returning NULL, instead the already used nexthop group (which cannot be NULL at this point) had been tested so far. Additionally, if kzalloc() fails, return ERR_PTR(-ENOMEM) instead of NULL. Cover

Re: [PATCH v4 06/11] thermal: Add mode helpers

2020-06-01 Thread Andrzej Pietrasiewicz
Hi Guenter, W dniu 29.05.2020 o 17:52, Guenter Roeck pisze: On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote: Prepare for making the drivers not access tzd's private members. Signed-off-by: Andrzej Pietrasiewicz + Nit: unnecessary empty line. + retur

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread Nikolay Aleksandrov
On 01/06/2020 14:12, patrickeigens...@gmail.com wrote: > From: Patrick Eigensatz > > After allocating the spare nexthop group it should be tested for kzalloc() > returning NULL, instead the already used nexthop group (which cannot be > NULL at this point) had been tested so far. > > Additionally

Re: [PATCH net-next 1/1] wireguard: reformat to 100 column lines

2020-06-01 Thread Jason A. Donenfeld
On Mon, Jun 1, 2020 at 5:12 AM Joe Perches wrote: > Newspaper columns are pretty narrow for a reason. > > Please remember that left to right scanning of text, especially for > comments, is not particularly improved by longer lines. I agree that extra long lines make reading text impossible -- 500

INFO: task hung in corrupted (2)

2020-06-01 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b0c3ba31 Merge tag 'fsnotify_for_v5.7-rc8' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14089eee10 kernel config: https://syzkaller.appspot.com/x/.config?x=ce116858301bc2ea das

Re: [PATCH 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-01 Thread Jan Kara
On Fri 29-05-20 16:43:09, John Hubbard wrote: > This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to pin_user_pages*()

Re: [PATCH v2 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

2020-06-01 Thread Jan Kara
On Sun 31-05-20 22:26:32, John Hubbard wrote: > There are four cases listed in pin_user_pages.rst. These are > intended to help developers figure out whether to use > get_user_pages*(), or pin_user_pages*(). However, the four cases > do not cover all the situations. For example, drivers/vhost/vhost

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:21, "Andrzej Pietrasiewicz" schrieb: > Prepare for storing mode in struct thermal_zone_device. > > Signed-off-by: Andrzej Pietrasiewicz > --- [...] > drivers/platform/x86/acerhdf.c | 8 -- Acked-by: Peter Kaestle

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:21, "Andrzej Pietrasiewicz" schrieb: > Prepare for eliminating get_mode(). > > Signed-off-by: Andrzej Pietrasiewicz > --- [...] > drivers/platform/x86/acerhdf.c | 15 ++--- Acked-by: Peter Kaestle

Re: [PATCH v4 07/11] thermal: Use mode helpers in drivers

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:22, "Andrzej Pietrasiewicz" schrieb: > Use thermal_zone_device_{en|dis}able() and thermal_zone_device_is_enabled(). > > Consequently, all set_mode() implementations in drivers: > > - can stop modifying tzd's "mode" member, > - shall stop taking tzd's lock, as it is taken in the

Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:21, "Andrzej Pietrasiewicz" schrieb: > get_mode() is now redundant, as the state is stored in struct > thermal_zone_device. > > Consequently the "mode" attribute in sysfs can always be visible, because > it is always possible to get the mode from struct tzd. > > Signed-off-by: A

Re: [PATCH v4 10/11] thermal: Simplify or eliminate unnecessary set_mode() methods

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:22, "Andrzej Pietrasiewicz" schrieb: > Setting polling_delay is now done at thermal_core level (by not polling > DISABLED devices), so no need to repeat this code. > > int340x: Checking for an impossible enum value is unnecessary. > acpi/thermal: It only prints debug messages. >

Re: [PATCH v4 11/11] thermal: Rename set_mode() to change_mode()

2020-06-01 Thread Peter Kästle
28. Mai 2020 21:22, "Andrzej Pietrasiewicz" schrieb: > set_mode() is only called when tzd's mode is about to change. Actual > setting is performed in thermal_core, in thermal_zone_device_set_mode(). > The meaning of set_mode() callback is actually to notify the driver about > the mode being chang

Re: [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization

2020-06-01 Thread Alexandre Belloni
On 01/06/2020 14:12:38+0300, Vladimir Oltean wrote: > Hi Mark, > > On Mon, 1 Jun 2020 at 13:54, Mark Brown wrote: > > > > On Sun, May 31, 2020 at 03:26:28PM +0300, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > Similar to the standalone regfields, add an initializer for the users

Re: [PATCH net-next] vxlan: remove fdb when out interface is removed

2020-06-01 Thread Taehee Yoo
On Sat, 30 May 2020 at 08:42, David Miller wrote: > Hi David, Thanks a lot for your review! > From: Taehee Yoo > Date: Wed, 27 May 2020 16:29:50 + > > > vxlan fdb can have NDA_IFINDEX, which indicates an out interface. > > If the interface is removed, that fdb will not work. > > So, when in

Re: ABI breakage in sctp_event_subscribe (was [PATCH net-next 0/4] sctp: add some missing events from rfc5061)

2020-06-01 Thread Neil Horman
On Sun, Apr 19, 2020 at 12:25:36PM +0200, Harald Welte wrote: > Dear Linux SCTP developers, > > this patchset (merged back in Q4/2019) has broken ABI compatibility, more > or less exactly as it was discussed/predicted in Message-Id > <20190206201430.18830-1-jul...@arista.com> > "[PATCH net] sctp:

Re: [PATCH v3 net-next 01/13] regmap: add helper for per-port regfield initialization

2020-06-01 Thread Mark Brown
On Mon, Jun 01, 2020 at 01:51:31PM +0200, Alexandre Belloni wrote: > On 01/06/2020 14:12:38+0300, Vladimir Oltean wrote: > > In my mind I am not exactly sure what the pull request does to improve > > the work flow. My simplified idea was that you would send a pull > > request upstream, then David

[PATCH net 0/2] Fix infinite loop in bridge and vxlan modules

2020-06-01 Thread Ido Schimmel
From: Ido Schimmel When suppressing invalid IPv6 Neighbour Solicitation messages, it is possible for the bridge and vxlan modules to get stuck in an infinite loop. See the individual changelogs for detailed explanation of the problem and solution. The bug was originally reported against the brid

[PATCH net 2/2] vxlan: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-01 Thread Ido Schimmel
From: Ido Schimmel When proxy mode is enabled the vxlan device might reply to Neighbor Solicitation (NS) messages on behalf of remote hosts. In case the NS message includes the "Source link-layer address" option [1], the vxlan device will use the specified address as the link-layer destination a

[PATCH net 1/2] bridge: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-01 Thread Ido Schimmel
From: Ido Schimmel When neighbor suppression is enabled the bridge device might reply to Neighbor Solicitation (NS) messages on behalf of remote hosts. In case the NS message includes the "Source link-layer address" option [1], the bridge device will use the specified address as the link-layer d

Re: [PATCH net 2/2] vxlan: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-01 Thread Nikolay Aleksandrov
On 01/06/2020 15:58, Ido Schimmel wrote: > From: Ido Schimmel > > When proxy mode is enabled the vxlan device might reply to Neighbor > Solicitation (NS) messages on behalf of remote hosts. > > In case the NS message includes the "Source link-layer address" option > [1], the vxlan device will us

Re: [PATCH net 1/2] bridge: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-01 Thread Nikolay Aleksandrov
On 01/06/2020 15:58, Ido Schimmel wrote: > From: Ido Schimmel > > When neighbor suppression is enabled the bridge device might reply to > Neighbor Solicitation (NS) messages on behalf of remote hosts. > > In case the NS message includes the "Source link-layer address" option > [1], the bridge de

Re: [PATCH net-next v8 7/7] net: vhost: make busyloop_intr more accurate

2020-06-01 Thread Michael S. Tsirkin
On Tue, Aug 21, 2018 at 08:47:35AM +0800, Jason Wang wrote: > > > On 2018年08月21日 08:33, Jason Wang wrote: > > > > > > On 2018年08月19日 20:11, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > The patch uses vhost_has_work_pending() to check if > > > the specified handler is

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Jiri Pirko
Thu, May 28, 2020 at 11:48:50AM CEST, pe...@mellanox.com wrote: > >Cong Wang writes: > >> On Wed, May 27, 2020 at 2:56 AM Petr Machata wrote: >>> >>> >>> Cong Wang writes: >>> >>> > On Tue, May 26, 2020 at 10:11 AM Petr Machata wrote: >>> >> >>> >> The Spectrum hardware allows execution of one

Re: [PATCH v4 06/11] thermal: Add mode helpers

2020-06-01 Thread Guenter Roeck
On 6/1/20 4:16 AM, Andrzej Pietrasiewicz wrote: > Hi Guenter, > > W dniu 29.05.2020 o 17:52, Guenter Roeck pisze: >> On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote: >>> Prepare for making the drivers not access tzd's private members. >>> >>> Signed-off-by: Andrzej Pietrasiew

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Jiri Pirko
Wed, May 27, 2020 at 06:09:03AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 26, 2020 at 10:11 AM Petr Machata wrote: >> >> The Spectrum hardware allows execution of one of several actions as a >> result of queue management events: tail-dropping, early-dropping, marking a >> packet, or passi

[PATCH net] crypto/chcr: IPV6 code needs to be in CONFIG_IPV6

2020-06-01 Thread Rohit Maheshwari
Error messages seen while building kernel with CONFIG_IPV6 disabled. Signed-off-by: Rohit Maheshwari --- drivers/crypto/chelsio/chcr_ktls.c | 48 -- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/ch

Re: [bpf-next PATCH 1/3] bpf: refactor sockmap redirect code so its easy to reuse

2020-06-01 Thread Jakub Sitnicki
On Fri, 29 May 2020 16:06:41 -0700 John Fastabend wrote: > We will need this block of code called from tls context shortly > lets refactor the redirect logic so its easy to use. This also > cleans up the switch stmt so we have fewer fallthrough cases. > > No logic changes are intended. > > Fixe

Re: [RDMA RFC v6 00/16] Intel RDMA Driver Updates 2020-05-19

2020-06-01 Thread Jason Gunthorpe
On Fri, May 29, 2020 at 03:21:05PM +, Saleem, Shiraz wrote: > > Subject: Re: [RDMA RFC v6 00/16] Intel RDMA Driver Updates 2020-05-19 > > > > [..] > > > > > I'm looking on it and see static assignments, to by dynamic you will need > > "to play" > > with hw_shifts/hw_masks later, but yo

Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

2020-06-01 Thread Jakub Sitnicki
On Fri, 29 May 2020 16:06:59 -0700 John Fastabend wrote: > KTLS uses a stream parser to collect TLS messages and send them to > the upper layer tls receive handler. This ensures the tls receiver > has a full TLS header to parse when it is run. However, when a > socket has BPF_SK_SKB_STREAM_VERDIC

Re: [bpf-next PATCH 1/3] bpf: refactor sockmap redirect code so its easy to reuse

2020-06-01 Thread John Fastabend
Jakub Sitnicki wrote: > On Fri, 29 May 2020 16:06:41 -0700 > John Fastabend wrote: > > > We will need this block of code called from tls context shortly > > lets refactor the redirect logic so its easy to use. This also > > cleans up the switch stmt so we have fewer fallthrough cases. > > > > No

Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

2020-06-01 Thread John Fastabend
Jakub Sitnicki wrote: > On Fri, 29 May 2020 16:06:59 -0700 > John Fastabend wrote: > > > KTLS uses a stream parser to collect TLS messages and send them to > > the upper layer tls receive handler. This ensures the tls receiver > > has a full TLS header to parse when it is run. However, when a > >

Fw: [Bug 208003] New: kernel panic RIP: 0010:__cgroup_bpf_run_filter_skb+0xd9/0x230

2020-06-01 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 31 May 2020 14:08:42 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 208003] New: kernel panic RIP: 0010:__cgroup_bpf_run_filter_skb+0xd9/0x230 https://bugzilla.kernel.org/show_bug.cgi?id=208003 Bug

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:34 PM Jiri Pirko wrote: > > Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: > >> > >> Mon, Jun 01, 2020 at 08:18:19AM CEST, j...@resnulli.us wrote: > >> >Sun, May 31, 2020 at 09:03:39AM CEST

Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

2020-06-01 Thread John Fastabend
John Fastabend wrote: > Jakub Sitnicki wrote: > > On Fri, 29 May 2020 16:06:59 -0700 > > John Fastabend wrote: > > > > > KTLS uses a stream parser to collect TLS messages and send them to > > > the upper layer tls receive handler. This ensures the tls receiver > > > has a full TLS header to parse

[PATCH] net/mlx5: DR, Fix freeing in dr_create_rc_qp()

2020-06-01 Thread Denis Efremov
Variable "in" in dr_create_rc_qp() is allocated with kvzalloc() and should be freed with kvfree(). Fixes: 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- drivers/net/ethernet/mellanox/mlx5/core/steering/d

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Rao Shoaib
On 5/29/20 4:41 PM, David Miller wrote: From: rao.sho...@oracle.com Date: Wed, 27 May 2020 01:17:42 -0700 diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index cba368e55863..7273c681e6c1 100644 --- a/include/uapi/linux/rds.h +++ b/include/uapi/linux/rds.h @@ -64,7 +64,7 @@

RE: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function warning

2020-06-01 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Arnd > Bergmann > Sent: Wednesday, May 27, 2020 6:47 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; Lifshits, Vitaly > > Cc: Arnd Bergmann ; Konstantin Khlebnikov > ; netdev@vger.kernel.org; Wysocki, Rafael J > ; linux-ker...@vger.kernel.or

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Rao Shoaib
On 5/31/20 3:08 AM, Leon Romanovsky wrote: On Wed, May 27, 2020 at 01:17:42AM -0700, rao.sho...@oracle.com wrote: From: Rao Shoaib This enhancement auto loads transport module when the transport is set via SO_RDS_TRANSPORT socket option. Orabug: 31032127 I think that it is internal to Orac

RE: [PATCH v2] e1000: use generic power management

2020-06-01 Thread Brown, Aaron F
> From: Vaibhav Gupta > Sent: Monday, May 25, 2020 5:27 AM > To: Vaibhav Gupta ; Bjorn Helgaas > ; Bjorn Helgaas ; > bj...@helgaas.com; Kirsher, Jeffrey T ; David S. > Miller ; r...@rjwysocki.net > Cc: Vaibhav Gupta ; Brandeburg, Jesse > ; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org

[PATCH net-next V2 2/2] Crypto/chcr: Fixes a coccinile check error

2020-06-01 Thread Ayush Sawal
This fixes an error observed after running coccinile check. drivers/crypto/chelsio/chcr_algo.c:1462:5-8: Unneeded variable: "err". Return "0" on line 1480 This line is missed in the commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). Fixes: 567be3a5d227

[PATCH net-next V2 1/2] Crypto/chcr: Fixes compilations warnings

2020-06-01 Thread Ayush Sawal
This patch fixes the compilation warnings displayed by sparse tool for chcr driver. V1->V2 Avoid type casting by using get_unaligned_be32() and put_unaligned_be16/32() functions. The key which comes from stack is an u8 byte stream so we store it in an unsigned char array(ablkctx->key). The funct

[PATCH net-next V2 0/2] Fixing compilation warnings and errors

2020-06-01 Thread Ayush Sawal
Patch 1: Fixes the warnings seen when compiling using sparse tool. Patch 2: Fixes a cocci check error introduced after commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). V1->V2 patch1: Avoid type casting by using get_unaligned_be32() and put_u

Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

2020-06-01 Thread David Miller
From: Luo bin Date: Mon, 1 Jun 2020 18:57:48 +0800 > @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct > net_device *netdev) > struct hinic_txq *txq; > struct hinic_qp *qp; > > + if (unlikely(!netif_carrier_ok(netdev))) { > + dev_kfree_sk

Re: new seccomp mode aims to improve performance

2020-06-01 Thread Kees Cook
On Sun, May 31, 2020 at 10:19:15AM -0700, Alexei Starovoitov wrote: > Thank you for crafting a benchmark. > The only thing that it's not doing a fair comparison. > The problem with that patch [1] that is using: > > static noinline u32 __seccomp_benchmark(struct bpf_prog *prog, >

Re: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-06-01 Thread David Miller
From: Davide Caratti Date: Fri, 29 May 2020 00:05:32 +0200 > trying to configure TC 'act_gate' rules with invalid control actions, the > following splat can be observed: > > general protection fault, probably for non-canonical address > 0xdc02: [#1] SMP KASAN NOPTI > KASAN: n

Re: [PATCH] drivers/net/wan/lapbether.c: Fixed kernel panic when used with AF_PACKET sockets

2020-06-01 Thread David Miller
From: Xie He Date: Wed, 27 May 2020 20:21:33 -0700 > When we use "AF_PACKET" sockets to send data directly over LAPB over > Ethernet using this driver, the kernel will panic because of > insufficient header space allocated in the "sk_buff" struct. > > The header space needs 18 bytes because: >

[PATCH net-next,v3] crypto/chtls: IPv6 support for inline TLS

2020-06-01 Thread Vinay Kumar Yadav
Extends support to IPv6 for Inline TLS server. Signed-off-by: Vinay Kumar Yadav v1->v2: - cc'd tcp folks. v2->v3: - changed EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL() --- drivers/crypto/chelsio/chtls/chtls_cm.c | 195 +- drivers/crypto/chelsio/chtls/chtls_cm.h | 1 + driv

[PATCH 5.6 020/177] sctp: Dont add the shutdown timer if its already been added

2020-06-01 Thread Greg Kroah-Hartman
From: Neil Horman [ Upstream commit 20a785aa52c82246055a089e55df9dac47d67da1 ] This BUG halt was reported a while back, but the patch somehow got missed: PID: 2879 TASK: c16adaa0 CPU: 1 COMMAND: "sctpn" #0 [f418dd28] crash_kexec at c04a7d8c #1 [f418dd7c] oops_end at c0863e02 #2 [f418dd9

Re: [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver

2020-06-01 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 28 May 2020 17:45:01 +0200 > From: Bartosz Golaszewski > > I noticed that oftentimes I use regmap_update_bits() for simple bit > setting or clearing. In this case the fourth argument is superfluous as > it's always 0 or equal to the mask argument. > > This

Re: [PATCH net-next 0/8] the indirect flow_block infrastructure, revisited

2020-06-01 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 29 May 2020 02:25:33 +0200 > This series fixes b5140a36da78 ("netfilter: flowtable: add indr block > setup support") that adds support for the indirect block for the > flowtable. ... Series applied, thanks Pablo.

Re: [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld()

2020-06-01 Thread David Miller
From: Dan Carpenter Date: Thu, 28 May 2020 15:49:57 +0300 > The caller doesn't care about the error codes, they only check for zero > vs non-zero. Still, it's better to preserve the negative error codes > from alloc_uld_rxqs() instead of changing it to 1. We can also return > directly if there

Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-06-01 Thread David Miller
From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by: syzbot+8eac6d030e7807c21...@syzkaller.a

Re: [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules

2020-06-01 Thread David Miller
From: Ido Schimmel Date: Mon, 1 Jun 2020 15:58:53 +0300 > From: Ido Schimmel > > When suppressing invalid IPv6 Neighbour Solicitation messages, it is > possible for the bridge and vxlan modules to get stuck in an infinite > loop. See the individual changelogs for detailed explanation of the >

[PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf()

2020-06-01 Thread Jules Irenge
Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() warning: context imbalance in efx_ef10_try_update_nic_stats_vf() - unexpected unlock The root cause is the missing annotation at efx_ef10_try_update_nic_stats_vf() Add the missing _must_hold(&efx->stats_lock) annotation Signed-

Re: [PATCH 0/9] Netfilter updates for net-next

2020-06-01 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 29 May 2020 19:50:17 +0200 > The following patchset contains Netfilter updates for net-next > to extend ctnetlink and the flowtable infrastructure: > > 1) Extend ctnetlink kernel side netlink dump filtering capabilities, >from Romain Bellan. > > 2) General

Re: [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver

2020-06-01 Thread Mark Brown
On Mon, Jun 01, 2020 at 11:35:36AM -0700, David Miller wrote: > > v2 -> v3: > > - drop unneeded ternary operator > Series applied to net-next, thank you. I already applied patch 1 and sent a pull request to Linus for it. As I said: | Let me know if you need a pull request for this, given the m

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Sergei Shtylyov
On 06/01/2020 12:58 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Sometimes debugging a device is easiest using devmem on its register > map, and that can be seen with /proc/iomem. But some device drivers have > many memory regions. Take for example a networking switch. Its memory > map

[PATCH 5.4 018/142] sctp: Dont add the shutdown timer if its already been added

2020-06-01 Thread Greg Kroah-Hartman
From: Neil Horman [ Upstream commit 20a785aa52c82246055a089e55df9dac47d67da1 ] This BUG halt was reported a while back, but the patch somehow got missed: PID: 2879 TASK: c16adaa0 CPU: 1 COMMAND: "sctpn" #0 [f418dd28] crash_kexec at c04a7d8c #1 [f418dd7c] oops_end at c0863e02 #2 [f418dd9

Re: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-06-01 Thread Cong Wang
On Mon, Jun 1, 2020 at 11:40 AM David Miller wrote: > > From: Davide Caratti > Date: Fri, 29 May 2020 00:05:32 +0200 > > > trying to configure TC 'act_gate' rules with invalid control actions, the > > following splat can be observed: > > > > general protection fault, probably for non-canonical a

Re: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-06-01 Thread Davide Caratti
On Mon, 2020-06-01 at 11:37 -0700, David Miller wrote: > From: Davide Caratti > Date: Fri, 29 May 2020 00:05:32 +0200 > > > trying to configure TC 'act_gate' rules with invalid control actions, the > > following splat can be observed: > > > > general protection fault, probably for non-canonical

  1   2   3   >