Re: [PATCH] vlan: fix the bug that cannot create vlan4095

2020-05-18 Thread Ido Schimmel
On Mon, May 18, 2020 at 01:27:55PM +0800, Huang Qijun wrote: > According to the 8021q standard, the VLAN id range is 1 to 4095. No, on IEEE8021VlanIndex the standard says: "A value used to index per-VLAN tables: values of 0 and 4095 are not permitted. If the value is between 1 and 4094 inclusive,

Re: [PATCH] Bluetooth: L2CAP: Replace zero-length array with flexible-array

2020-05-18 Thread Marcel Holtmann
Hi Gustavo, > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { >int stuff; >st

RE

2020-05-18 Thread María L . Ferreyra
-- IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD AUSGEWÄHLT CHARITY.BITTE KONTAKTIEREN SIE UNS FÜR WEITERE INFORMATIONEN. ALLE NACHRICHTEN MÜSSEN DIESE E-MAIL NUR DIESE E-MAIL KONTAKTIEREN: cont...@postnet-express.com

[PATCH net-next 3/4] bnxt_en: Use enable_hot_fw_reset generic devlink parameter

2020-05-18 Thread Vasundhara Volam
enable_hot_fw_reset parameter supports both permanent and runtime configuration modes. This parameter enables or disables the hot firmware reset capability of the device which either resets the currently running firmware or upgrades/downgrades flashed firmware. For the runtime parameter to be true

[PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-18 Thread Vasundhara Volam
This patchset adds support for a "enable_hot_fw_reset" generic devlink parameter and use it in bnxt_en driver. Also, firmware spec. is updated to 1.10.1.40. Vasundhara Volam (4): devlink: Add new "enable_hot_fw_reset" generic device parameter. bnxt_en: Update firmware spec. to 1.10.1.40. bn

[PATCH net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40.

2020-05-18 Thread Vasundhara Volam
Major changes are to add additional flags to configure hot firmware reset. Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 64 --- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git

[PATCH net-next 4/4] bnxt_en: Check if hot_fw_reset is allowed before doing ETHTOOL_RESET

2020-05-18 Thread Vasundhara Volam
If device does not allow hot_fw_reset, issue firmware reset without graceful flag. Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH net-next 1/4] devlink: Add new "enable_hot_fw_reset" generic device parameter.

2020-05-18 Thread Vasundhara Volam
Add a new "enable_hot_fw_reset" generic device parameter to enable or disable hot firmware reset capability on the device. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- Documentation/networking/devlink/devlink-params.rst | 6 ++ include/net/de

net: netdev_sync_lower_features()

2020-05-18 Thread Michał Mirosław
Hi! I just saw commit dd912306ff008 ("net: fix a potential recursive NETDEV_FEAT_CHANGE") landing in Linux master. The problem with it (or rather: with the netdev_sync_lower_features() function) is that netdev_update_features() is allowed to change more than one feature at a time, including force-

Re: [RFC PATCHv2 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-05-18 Thread Hangbin Liu
Hi Toke, On Fri, Apr 24, 2020 at 04:34:49PM +0200, Toke Høiland-Jørgensen wrote: > > Yeah, the new helper is much cleaner! > > > To achive this I add a new ex_map for struct bpf_redirect_info. > > in the helper I set tgt_value to NULL to make a difference with > > bpf_xdp_redirect_map() > > > >

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Lad, Prabhakar
Hi Wolfram, Thank for the review. On Fri, May 15, 2020 at 6:10 PM Wolfram Sang wrote: > > On Fri, May 15, 2020 at 04:08:43PM +0100, Lad Prabhakar wrote: > > Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree. > > > > Automatic transmission for PMIC control is not available on

[PATCH net] cxgb4/chcr: Enable ktls settings at run time

2020-05-18 Thread Rohit Maheshwari
Current design enables ktls setting from start, which is not efficient. Now the feature will be enabled when user demands TLS offload on any interface. Signed-off-by: Rohit Maheshwari --- drivers/crypto/chelsio/chcr_ktls.c| 19 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h|

[PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Boris Sukholitko
__netif_receive_skb_core may change the skb pointer passed into it (e.g. in rx_handler). The original skb may be freed as a result of this operation. The callers of __netif_receive_skb_core may further process original skb by using pt_prev pointer returned by __netif_receive_skb_core thus leading

Re: [PATCH v5 bpf-next 00/11] net: Add support for XDP in egress path

2020-05-18 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 5/13/20 4:43 AM, Toke Høiland-Jørgensen wrote: >> I don't like this. I makes the egress hook asymmetrical with the ingress >> hook (ingress hook sees all traffic, egress only some of it). If the >> performance hit of disabling GSO is the concern, maybe it's better to >> w

Re: [PATCH v2 bpf-next 6/7] bpf: add support for %pT format specifier for bpf_trace_printk() helper

2020-05-18 Thread Alan Maguire
On Wed, 13 May 2020, Yonghong Song wrote: > > > + while (isbtffmt(fmt[i])) > > + i++; > > The pointer passed to the helper may not be valid pointer. I think you > need to do a probe_read_kernel() here. Do an atomic memory allocation > h

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Lad, Prabhakar
Hi Wolfram, On Sun, May 17, 2020 at 10:08 PM Wolfram Sang wrote: > > On Fri, May 15, 2020 at 04:08:57PM +0100, Lad Prabhakar wrote: > > Add a device node for the Watchdog Timer (RWDT) controller on the Renesas > > RZ/G1H (r8a7742) SoC. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Marian

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
> > However, both versions (with and without automatic transmission) are > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > to detect the reduced variant at runtime somehow? > > > I couldn't find anything the manual that would be useful to detect at runtime. > > > My

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Wolfram Sang
> Its similar to as seen on Rcar-H2 where just the A15 cores are up and > A7 cores fail to boot. Attached is the boot log where reboot works as > expected with all A15 core up. Although I have tested the internal > release based on 3.10 where all the cores are up which used bootarg > apmu=multiclu

Re: "Forwarding" from TC classifier

2020-05-18 Thread Lorenz Bauer
On Fri, 15 May 2020 at 15:24, David Ahern wrote: > > On 5/15/20 3:59 AM, Lorenz Bauer wrote: > > > > Yes, but that doesn't play well with changing the source address to > > the local machine's, since the upper part of the stack will drop the > > packet due to accept_local=0. > > Can you defer the

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Lad, Prabhakar
Hi Wolfram, On Mon, May 18, 2020 at 10:26 AM Wolfram Sang wrote: > > > > > However, both versions (with and without automatic transmission) are > > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > > to detect the reduced variant at runtime somehow? > > > > > I couldn

Re: [PATCH v2 bpf-next 2/7] bpf: move to generic BTF show support, apply it to seq files/strings

2020-05-18 Thread Alan Maguire
On Wed, 13 May 2020, Yonghong Song wrote: > > > +struct btf_show { > > + u64 flags; > > + void *target; /* target of show operation (seq file, buffer) */ > > + void (*showfn)(struct btf_show *show, const char *fmt, ...); > > + const struct btf *btf; > > + /* below are used during iter

Re: [PATCH V2] dynamic_debug: Add an option to enable dynamic debug for modules only

2020-05-18 Thread Petr Mladek
On Sat 2020-05-16 11:55:04, Orson Zhai wrote: > On Fri, May 15, 2020 at 5:55 PM Petr Mladek wrote: > > > > On Thu 2020-04-23 00:02:48, Orson Zhai wrote: > > > On Wed, Apr 22, 2020 at 10:25 PM Leon Romanovsky wrote: > > > > > > > > On Wed, Apr 22, 2020 at 09:06:08PM +0800, Orson Zhai wrote: > > >

Re: unstable xdp tests. Was: [PATCH net-next v4 31/33] bpf: add xdp.frame_sz in bpf_prog_test_run_xdp().

2020-05-18 Thread Jesper Dangaard Brouer
On Sat, 16 May 2020 21:02:01 -0700 Alexei Starovoitov wrote: > On Thu, May 14, 2020 at 3:51 AM Jesper Dangaard Brouer > wrote: > > > > Update the memory requirements, when adding xdp.frame_sz in BPF test_run > > function bpf_prog_test_run_xdp() which e.g. is used by XDP selftests. > > > > Specif

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
Hi Prabhakar, > > Leaves us with a seperate compatible entry for it? > > > Sounds okay to me, how about "renesas,iic-no-dvfs" ? So that this > could be used on all the SoC's which don't support DVFS. Well, the feature missing is used for DVFS, but its name is "automatic transmission". So, I'd rat

Re: [PATCH 01/17] dt-bindings: i2c: renesas,i2c: Document r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:09 PM Lad Prabhakar wrote: > Document i2c controller for RZ/G1H (R8A7742) SoC, which is compatible > with R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 02/17] dt-bindings: i2c: renesas,iic: Document r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:09 PM Lad Prabhakar wrote: > Document IIC controller for RZ/G1H (R8A7742) SoC, which is compatible > with R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, May 18, 2020 at 11:26 AM Wolfram Sang wrote: > > > However, both versions (with and without automatic transmission) are > > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > > to detect the reduced variant at runtime somehow? > > > > > I couldn't f

Re: unstable xdp tests. Was: [PATCH net-next v4 31/33] bpf: add xdp.frame_sz in bpf_prog_test_run_xdp().

2020-05-18 Thread Jesper Dangaard Brouer
On Mon, 18 May 2020 11:52:34 +0200 Jesper Dangaard Brouer wrote: > ... I'm getting unrelated compile errors for selftests/bpf in > bpf-next tree (HEAD 96586dd9268d2). > > The compile error, see below signature, happens in > ./progs/bpf_iter_ipv6_route.c > (tools/testing/selftests/bpf/progs/bpf_

Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-18 Thread Jiri Pirko
Mon, May 18, 2020 at 10:27:15AM CEST, vasundhara-v.vo...@broadcom.com wrote: >This patchset adds support for a "enable_hot_fw_reset" generic devlink >parameter and use it in bnxt_en driver. > >Also, firmware spec. is updated to 1.10.1.40. Hi. We've been discussing this internally for some time. I

Re: [PATCH 04/17] dt-bindings: mmc: renesas,sdhi: Document r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:09 PM Lad Prabhakar wrote: > Document SDHI controller for RZ/G1H (R8A7742) SoC, which is compatible > with R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 08/17] dt-bindings: ata: renesas,rcar-sata: Add r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Document SATA support for the RZ/G1H, which is compatible with > R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 10/17] dt-bindings: net: renesas,ravb: Add support for r8a7742 SoC

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH 11/17] dt-bindings: net: renesas,ether: Document R8A7742 SoC

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH 14/17] dt-bindings: power: renesas,apmu: Document r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Document APMU and SMP enable method for RZ/G1H (also known as r8a7742) > SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

[PATCH bpf-next] selftests/bpf: add general instructions for test execution

2020-05-18 Thread Alan Maguire
Getting a clean BPF selftests run involves ensuring latest trunk LLVM/clang are used, pahole is recent (>=1.16) and config matches the specified config file as closely as possible. Document all of this in the general README.rst file. Also note how to work around timeout failures. Signed-off-by:

Re: [PATCH 05/17] mmc: renesas_sdhi_sys_dmac: Add support for r8a7742 SoC

2020-05-18 Thread Geert Uytterhoeven
Hi Wolfram, Prabhakar, On Fri, May 15, 2020 at 7:17 PM Wolfram Sang wrote: > On Fri, May 15, 2020 at 04:08:45PM +0100, Lad Prabhakar wrote: > > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) SDHI is identical to > > the R-Car Gen2 family. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-

Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

2020-05-18 Thread Simon Horman
On Fri, May 15, 2020 at 12:49:01PM -0700, Jakub Kicinski wrote: > Core will now perform this check. > > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --gi

AN OPPORTUNITY FOR YOU

2020-05-18 Thread Mrs.MARTINEZ MONICA
-- Good Day, I know that this mail might be a surprise to you, but i plead that you take a little time to read this it, if it is something you can handle, then you reply me. I work with one of the leading banks in my country, and i have worked with this bank for more than 11yrs, There is an aba

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Geert Uytterhoeven
Hi Prabhakar, On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Add a device node for the Watchdog Timer (RWDT) controller on the Renesas > RZ/G1H (r8a7742) SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Thanks for your patch! > --- a/arch/arm/boot/dts/r8

[PATCH 9/9] ipv6: use ->ndo_tunnel_ctl in addrconf_set_dstaddr

2020-05-18 Thread Christoph Hellwig
Use the new ->ndo_tunnel_ctl instead of overriding the address limit and using ->ndo_do_ioctl just to do a pointless user copy. Signed-off-by: Christoph Hellwig --- net/ipv6/addrconf.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/add

[PATCH 7/9] ipv6: stub out even more of addrconf_set_dstaddr if SIT is disabled

2020-05-18 Thread Christoph Hellwig
There is no point in copying the structure from userspace or looking up a device if SIT support is not disabled and we'll eventually return -ENODEV anyway. Signed-off-by: Christoph Hellwig --- net/ipv6/addrconf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/a

add a new ->ndo_tunnel_ctl method to avoid a few set_fs calls

2020-05-18 Thread Christoph Hellwig
Hi Dave, both the ipv4 and ipv6 code have an ioctl each that can be used to create a tunnel using code that doesn't live in the core kernel or ipv6 module. Currently they call ioctls on the tunnel devices to create these, for which the code needs to override the address limit, which is a "feature"

[PATCH 6/9] sit: impement ->ndo_tunnel_ctl

2020-05-18 Thread Christoph Hellwig
Implement the ->ndo_tunnel_ctl method, and use ip_tunnel_ioctl to handle userspace requests for the SIOCGETTUNNEL, SIOCADDTUNNEL, SIOCCHGTUNNEL and SIOCDELTUNNEL ioctls. Signed-off-by: Christoph Hellwig --- net/ipv6/sit.c | 73 +++--- 1 file changed, 3

[PATCH 3/9] net: add a new ndo_tunnel_ioctl method

2020-05-18 Thread Christoph Hellwig
This method is used to properly allow kernel callers of the IPv4 route management ioctls. The exsting ip_tunnel_ioctl helper is renamed to ip_tunnel_ctl to better reflect that it doesn't directly implement ioctls touching user memory, and is used for the guts of ndo_tunnel_ctl implementations. A n

[PATCH 1/9] ipv4: streamline ipmr_new_tunnel

2020-05-18 Thread Christoph Hellwig
Reduce a few level of indentation to simplify the function. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 73 - 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 5c218db2dede7..a1169b69

[PATCH 2/9] ipv4: consolidate the VIFF_TUNNEL handling in ipmr_new_tunnel

2020-05-18 Thread Christoph Hellwig
Also move the dev_set_allmulti call and the error handling into the ioctl helper. This allows reusing already looked up tunnel_dev pointer and the set up argument structure for the deletion in the error handler. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 53 -

[PATCH 5/9] sit: refactor ipip6_tunnel_ioctl

2020-05-18 Thread Christoph Hellwig
Split the ioctl handler into one function per command instead of having a all the logic sit in one giant switch statement. Signed-off-by: Christoph Hellwig --- net/ipv6/sit.c | 368 - 1 file changed, 210 insertions(+), 158 deletions(-) diff --git

[PATCH 8/9] ipv6: streamline addrconf_set_dstaddr

2020-05-18 Thread Christoph Hellwig
Factor out a addrconf_set_sit_dstaddr helper for the actual work if we found a SIT device, and only hold the rtnl lock around the device lookup and that new helper, as there is no point in holding it over a copy_from_user call. Signed-off-by: Christoph Hellwig --- net/ipv6/addrconf.c | 87 ++

[PATCH 4/9] impr: use ->ndo_tunnel_ctl in ipmr_new_tunnel

2020-05-18 Thread Christoph Hellwig
Use the new ->ndo_tunnel_ctl instead of overriding the address limit and using ->ndo_do_ioctl just to do a pointless user copy. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr

Re: [PATCH 06/17] ARM: dts: r8a7742: Add SDHI nodes

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:09 PM Lad Prabhakar wrote: > Add the SDHI devices nodes to the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.9. Gr{oetje,eeting}s,

Re: [PATCH 07/17] ARM: dts: r8a7742: Add MMC0 node

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Describe MMC0 device node in the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.9. Gr{oetje,eeting}s,

Re: [PATCH 09/17] ARM: dts: r8a7742: Add sata nodes

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Add the sata devices nodes to the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.9. Gr{oetje,eeting}s,

Re: [PATCH 12/17] ARM: dts: r8a7742: Add Ethernet AVB support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Add Ethernet AVB support for R8A7742 SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.9. Gr{oetje,eeting}s, Ge

Re: [PATCH 13/17] ARM: dts: r8a7742: Add Ether support

2020-05-18 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar wrote: > Define the generic R8A7742 part of the Ether device node. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.9. Gr{oetje,eeting}s,

Re: [PATCH v3 0/1] net: ethernet: stmmac: simplify phy modes management for stm32

2020-05-18 Thread Christophe ROULLIER
Hi, Just a "gentleman ping" Regards, Christophe. On 27/04/2020 12:00, Christophe Roullier wrote: > No new feature, just to simplify stm32 part to be easier to use. > Add by default all Ethernet clocks in DT, and activate or not in function > of phy mode, clock frequency, if property "st,ext-phy

Re: [PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Currently ldo_pwr has the LDO25 voltage bits set to zero and then > it is overwritten with the new voltage setting. The assignment > looks incorrect, it should be bit-wise or'ing in the new voltage > setting rather than a direct assignment. > > Addr

Re: [PATCH] mwifiex: Fix memory corruption in dump_station

2020-05-18 Thread Kalle Valo
Pali Rohár wrote: > The mwifiex_cfg80211_dump_station() uses static variable for iterating > over a linked list of all associated stations (when the driver is in UAP > role). This has a race condition if .dump_station is called in parallel > for multiple interfaces. This corruption can be trigger

Re: [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop

2020-05-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The for-loop seems to be redundant, the assignments for indexes > 0..2 are being over-written by the last index 3 in the loop. Remove > the loop and use index 3 instead. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patc

Re: linux-next: manual merge of the jc_docs tree with the vfs and net-next trees

2020-05-18 Thread Jonathan Corbet
On Mon, 18 May 2020 12:30:13 +1000 Stephen Rothwell wrote: > Today's linux-next merge of the jc_docs tree got a conflict in: > > kernel/sysctl.c > > between commit: > > f461d2dcd511 ("sysctl: avoid forward declarations") > > from the vfs tree and commit: > > 2f4c33063ad7 ("docs: sysctl

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Mon, May 18, 2020 at 12:47 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar > wrote: > > Add a device node for the Watchdog Timer (RWDT) controller on the Renesas > > RZ/G1H (r8a7742) SoC. > > > > Signed-off-

Re: BUG: Bad rss-counter state (4)

2020-05-18 Thread syzbot
syzbot has bisected this bug to: commit 0d8dd67be013727ae57645ecd3ea2c36365d7da8 Author: Song Liu Date: Wed Dec 6 22:45:14 2017 + perf/headers: Sync new perf_event.h with the tools/include/uapi version bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13240a0210 start c

Re: [PATCH net 1/1] net sched: fix reporting the first-time use timestamp

2020-05-18 Thread Jamal Hadi Salim
On 2020-05-17 9:10 p.m., Roman Mashak wrote: Cong Wang writes: On Sun, May 17, 2020 at 5:47 AM Roman Mashak wrote: When a new action is installed, firstuse field of 'tcf_t' is explicitly set to 0. Value of zero means "new action, not yet used"; as a packet hits the action, 'firstuse' is sta

Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

2020-05-18 Thread Jamal Hadi Salim
ping? Note: these are trivial bug fixes. cheers, jamal On 2020-04-28 12:15 p.m., Jamal Hadi Salim wrote: Stephen, What happened to this? cheers, jamal On 2020-04-23 1:58 p.m., Jamal Hadi Salim wrote: From: Jamal Hadi Salim Changes from V2:   1) Dont initialize tmp on stack (Stephen)   2)

[PATCH bpf-next] bpf: fix too large copy from user in bpf_test_init

2020-05-18 Thread Jesper Dangaard Brouer
Commit bc56c919fce7 ("bpf: Add xdp.frame_sz in bpf_prog_test_run_xdp().") recently changed bpf_prog_test_run_xdp() to use larger frames for XDP in order to test tail growing frames (via bpf_xdp_adjust_tail) and to have memory backing frame better resemble drivers. The commit contains a bug, as it

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread Jamal Hadi Salim
On 2020-05-17 9:28 a.m., Roman Mashak wrote: Have print_tm() dump firstuse value along with install, lastuse and expires. Signed-off-by: Roman Mashak --- tc/tc_util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tc/tc_util.c b/tc/tc_util.c index 12f865cc71bf..f6aa2ed552a9 100644

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Sergei Shtylyov
Hello! On 18.05.2020 15:27, Lad, Prabhakar wrote: Add a device node for the Watchdog Timer (RWDT) controller on the Renesas RZ/G1H (r8a7742) SoC. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Thanks for your patch! --- a/arch/arm/boot/dts/r8a7742.dtsi +++ b/arch/arm/b

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Lad, Prabhakar
Hi Sergei, On Mon, May 18, 2020 at 2:17 PM Sergei Shtylyov wrote: > > Hello! > > On 18.05.2020 15:27, Lad, Prabhakar wrote: > > >>> Add a device node for the Watchdog Timer (RWDT) controller on the Renesas > >>> RZ/G1H (r8a7742) SoC. > >>> > >>> Signed-off-by: Lad Prabhakar > >>> Reviewed-by: Ma

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-18 Thread Murali Karicheri
Hi, On 5/17/20 11:06 AM, Michael Walle wrote: What about the Qbu handshake state? And some NICs support overriding this. I.e. enable frame preemption even if the handshake wasn't successful. You are talking about Verify procedure to hand shake with peer to know if remote support IET fragmentat

Re: [PATCH v3 10/15] net: ethernet: mtk-eth-mac: new driver

2020-05-18 Thread Bartosz Golaszewski
pt., 15 maj 2020 o 15:32 Arnd Bergmann napisał(a): > > On Thu, May 14, 2020 at 10:00 AM Bartosz Golaszewski wrote: > > +static int mtk_mac_ring_pop_tail(struct mtk_mac_ring *ring, > > +struct mtk_mac_ring_desc_data *desc_data) > > I took another look at this functi

Re: iproute2: tc deletion freezes whole server

2020-05-18 Thread Václav Zindulka
On Sun, May 17, 2020 at 9:35 PM Cong Wang wrote: > > On Fri, May 8, 2020 at 6:59 AM Václav Zindulka > wrote: > > > > > > > > > > I tried to emulate your test case in my VM, here is the script I use: > > > > > > > > > > > > > > > ip li set dev dummy0 up > > > > > tc qd add dev dummy0 root han

[PATCH] dns: Apply a default TTL to records obtained from getaddrinfo()

2020-05-18 Thread David Howells
Address records obtained from getaddrinfo() don't come with any TTL information, even if they're obtained from the DNS, with the result that key.dns_resolver upcall program doesn't set an expiry time on dns_resolver records unless they include a component obtained directly from the DNS, such as an

Re: "Forwarding" from TC classifier

2020-05-18 Thread David Ahern
On 5/18/20 3:38 AM, Lorenz Bauer wrote: > On Fri, 15 May 2020 at 15:24, David Ahern wrote: >> >> On 5/15/20 3:59 AM, Lorenz Bauer wrote: >>> >>> Yes, but that doesn't play well with changing the source address to >>> the local machine's, since the upper part of the stack will drop the >>> packet d

Re: [PATCH v3 10/15] net: ethernet: mtk-eth-mac: new driver

2020-05-18 Thread Arnd Bergmann
On Mon, May 18, 2020 at 4:07 PM Bartosz Golaszewski wrote: > pt., 15 maj 2020 o 15:32 Arnd Bergmann napisał(a): > > I would get rid of the 'count' here, as it duplicates the information > > that is already known from the difference between head and tail, and you > > can't update it atomically wi

Re: [PATCH v5 bpf-next 00/11] net: Add support for XDP in egress path

2020-05-18 Thread David Ahern
On 5/18/20 3:08 AM, Toke Høiland-Jørgensen wrote: > I can see your point that fixing up the whole skb after the program has > run is not a good idea. But to me that just indicates that the hook is > in the wrong place: that it really should be in the driver, executed at > a point where the skb data

Re: [PATCH v2 bpf-next 6/7] bpf: add support for %pT format specifier for bpf_trace_printk() helper

2020-05-18 Thread Yonghong Song
On 5/18/20 2:10 AM, Alan Maguire wrote: On Wed, 13 May 2020, Yonghong Song wrote: + while (isbtffmt(fmt[i])) + i++; The pointer passed to the helper may not be valid pointer. I think you need to do a probe_read_kernel()

Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F

2020-05-18 Thread Andrew Lunn
> Hi, Andrew. > > There are two type of phys we are using, rtl8211f and "Marvell 88E1512". > "Marvell 88E1512" has already supported loopback > (f0f9b4ed2338 ("net: phy: Add phy loopback support in net phy framework")). > So now we adds loopback support to the rtl8211f. > From the data sheet othe

Re: [PATCH iproute2/net-next] man: tc-ct.8: Add manual page for ct tc action

2020-05-18 Thread David Ahern
On 5/14/20 8:10 AM, Paul Blakey wrote: > Signed-off-by: Paul Blakey > --- > man/man8/tc-ct.8 | 107 > +++ > man/man8/tc-flower.8 | 6 +++ > 2 files changed, 113 insertions(+) > create mode 100644 man/man8/tc-ct.8 > > diff --git a/man/man8/t

Re: [PATCH iproute2-next] tc: mqprio: reject queues count/offset pair count higher than num_tc

2020-05-18 Thread David Ahern
On 5/13/20 1:47 PM, Maciej Fijalkowski wrote: > Provide a sanity check that will make sure whether queues count/offset > pair count will not exceed the actual number of TCs being created. > > Example command that is invalid because there are 4 count/offset pairs > whereas num_tc is only 2. > > #

Re: [PATCH net-next] net: ipa: Remove ipa_endpoint_stop{,_rx_dma} again

2020-05-18 Thread Alex Elder
On 5/9/20 12:52 AM, Jakub Kicinski wrote: On Fri, 8 May 2020 12:41:33 -0700 Nathan Chancellor wrote: When building arm64 allyesconfig: drivers/net/ipa/ipa_endpoint.c: In function 'ipa_endpoint_stop_rx_dma': drivers/net/ipa/ipa_endpoint.c:1274:13: error: 'IPA_ENDPOINT_STOP_RX_SIZE' undeclared

[PATCH net-next v3 2/2] realtek/8139cp: use generic power management

2020-05-18 Thread Vaibhav Gupta
compile-tested only With legacy PM hooks, it was the responsibility of a driver to manage PCI states and also device's power state. The generic approach is to let PCI core handle the work. The suspend callback enables/disables PCI wake on the basis of "cp->wol_enabled" variable which is unknown t

[PATCH net-next v3 1/2] realtek/8139too: use generic power management

2020-05-18 Thread Vaibhav Gupta
compile-tested only With legacy PM hooks, it was the responsibility of a driver to manage PCI states and also device's power state. The generic approach is to let PCI core handle the work. PCI core passes "struct device*" as an argument to the .suspend() and .resume() callbacks. As these callabck

[PATCH net-next v3 0/2] realtek ethernet : use generic power management.

2020-05-18 Thread Vaibhav Gupta
The purpose of this patch series is to remove legacy power management callbacks from realtek ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement themselves, which is not recomm

Re: [PATCH] drivers: ipa: use devm_kzalloc for simplicity

2020-05-18 Thread Alex Elder
On 5/14/20 2:47 PM, David Miller wrote: From: Jakub Kicinski Date: Thu, 14 May 2020 10:15:16 -0700 On Wed, 13 May 2020 20:55:20 -0700 Wang Wenhu wrote: Make a substitution of kzalloc with devm_kzalloc to simplify the ipa_probe() process. Signed-off-by: Wang Wenhu The code is perfectly fin

Re: [PATCH iproute2-next] tc: mqprio: reject queues count/offset pair count higher than num_tc

2020-05-18 Thread Stephen Hemminger
On Wed, 13 May 2020 21:47:17 +0200 Maciej Fijalkowski wrote: > Provide a sanity check that will make sure whether queues count/offset > pair count will not exceed the actual number of TCs being created. > > Example command that is invalid because there are 4 count/offset pairs > whereas num_tc i

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-18 Thread Christoph Hellwig
On Sat, May 16, 2020 at 12:42:59PM +0900, Masami Hiramatsu wrote: > > Provide alternative versions of probe_kernel_read, probe_kernel_write > > and strncpy_from_kernel_unsafe that don't need set_fs magic, but instead > > use arch hooks that are modelled after unsafe_{get,put}_user to access > > ker

Re: [PATCH] drivers: ipa: fix typos for ipa_smp2p structure doc

2020-05-18 Thread Alex Elder
On 5/14/20 3:07 PM, David Miller wrote: From: Wang Wenhu Date: Thu, 14 May 2020 04:02:22 -0700 Remove the duplicate "mutex", and change "Motex" to "Mutex". Also I recommend it's easier for understanding to make the "ready-interrupt" a bundle for it is a parallel description as "shutdown" which

Re: [PATCH iproute2-next] tc: mqprio: reject queues count/offset pair count higher than num_tc

2020-05-18 Thread David Ahern
On 5/18/20 9:08 AM, Stephen Hemminger wrote: > On Wed, 13 May 2020 21:47:17 +0200 > Maciej Fijalkowski wrote: > >> Provide a sanity check that will make sure whether queues count/offset >> pair count will not exceed the actual number of TCs being created. >> >> Example command that is invalid bec

[PATCH bpf-next 0/4] Add get{peer,sock}name cgroup attach types

2020-05-18 Thread Daniel Borkmann
Trivial patch to add get{peer,sock}name cgroup attach types to the BPF sock_addr programs in order to enable rewriting sockaddr structs from both calls along with libbpf and bpftool support as well as selftests. Thanks! Daniel Borkmann (4): bpf: add get{peer,sock}name attach types for sock_addr

[PATCH bpf-next 2/4] bpf, libbpf: enable get{peer,sock}name attach types

2020-05-18 Thread Daniel Borkmann
Trivial patch to add the new get{peer,sock}name attach types to the section definitions in order to hook them up to sock_addr cgroup program type. Signed-off-by: Daniel Borkmann --- tools/lib/bpf/libbpf.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/

[PATCH bpf-next 1/4] bpf: add get{peer,sock}name attach types for sock_addr

2020-05-18 Thread Daniel Borkmann
As stated in 983695fa6765 ("bpf: fix unconnected udp hooks"), the objective for the existing cgroup connect/sendmsg/recvmsg/bind BPF hooks is to be transparent to applications. In Cilium we make use of these hooks [0] in order to enable E-W load balancing for existing Kubernetes service types for a

[PATCH bpf-next 3/4] bpf, bpftool: enable get{peer,sock}name attach types

2020-05-18 Thread Daniel Borkmann
Make bpftool aware and add the new get{peer,sock}name attach types to its cli, documentation and bash completion to allow attachment/detachment of sock_addr programs there. Signed-off-by: Daniel Borkmann --- .../bpf/bpftool/Documentation/bpftool-cgroup.rst | 10 +++--- tools/bpf/bpftool/Doc

[PATCH bpf-next 4/4] bpf, testing: add get{peer,sock}name selftests to test_progs

2020-05-18 Thread Daniel Borkmann
Extend the existing connect_force_port test to assert get{peer,sock}name programs as well. The workflow for e.g. IPv4 is as follows: i) server binds to concrete port, ii) client calls getsockname() on server fd which exposes 1.2.3.4:6 to client, iii) client connects to service address 1.2.3.4:

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread David Ahern
On 5/17/20 7:28 AM, Roman Mashak wrote: > Have print_tm() dump firstuse value along with install, lastuse > and expires. > > Signed-off-by: Roman Mashak > --- > tc/tc_util.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tc/tc_util.c b/tc/tc_util.c > index 12f865cc71bf..f6aa2ed55

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-18 Thread Edward Cree
On 15/05/2020 12:40, Vlad Buslov wrote: > In order to > significantly improve filter dump rate this patch sets implement new > mode of TC filter dump operation named "terse dump" mode. In this mode > only parameters necessary to identify the filter (handle, action cookie, > etc.) and data that can

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread David Ahern
On 5/18/20 7:10 AM, Jamal Hadi Salim wrote: > On 2020-05-17 9:28 a.m., Roman Mashak wrote: >> Have print_tm() dump firstuse value along with install, lastuse >> and expires. >> >> Signed-off-by: Roman Mashak >> --- >>   tc/tc_util.c | 5 + >>   1 file changed, 5 insertions(+) >> >> diff --git a

Re: [PATCH v3 7/7] perf expr: Migrate expr ids table to a hashmap

2020-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 15, 2020 at 03:17:32PM -0700, Ian Rogers escreveu: > Use a hashmap between a char* string and a double* value. While bpf's > hashmap entries are size_t in size, we can't guarantee sizeof(size_t) >= > sizeof(double). Avoid a memory allocation when gathering ids by making 0.0 > a special

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Geert Uytterhoeven
On Mon, May 18, 2020 at 3:23 PM Lad, Prabhakar wrote: > On Mon, May 18, 2020 at 2:17 PM Sergei Shtylyov > wrote: > > On 18.05.2020 15:27, Lad, Prabhakar wrote: > > >>> Add a device node for the Watchdog Timer (RWDT) controller on the > > >>> Renesas > > >>> RZ/G1H (r8a7742) SoC. > > >>> > > >>>

Re: [PATCH] dns: Apply a default TTL to records obtained from getaddrinfo()

2020-05-18 Thread Ben Boeckel
On Mon, May 18, 2020 at 15:22:45 +0100, David Howells wrote: > Address records obtained from getaddrinfo() don't come with any TTL > information, even if they're obtained from the DNS, with the result that > key.dns_resolver upcall program doesn't set an expiry time on dns_resolver > records unless

Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Eric Dumazet
On 5/18/20 2:01 AM, Boris Sukholitko wrote: > __netif_receive_skb_core may change the skb pointer passed into it (e.g. > in rx_handler). The original skb may be freed as a result of this > operation. > > The callers of __netif_receive_skb_core may further process original skb > by using pt_prev

  1   2   3   4   >