Re: [PATCH net] ipv6: Fix suspicious RCU usage warning in ip6mr

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 12:32:04 +0530 madhuparnabhowmi...@gmail.com wrote: > From: Madhuparna Bhowmik > > This patch fixes the following warning: > > = > WARNING: suspicious RCU usage > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted > - > ne

Re: [PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Christoph Hellwig
On Thu, May 14, 2020 at 06:16:04PM +0200, Daniel Borkmann wrote: > Small set of fixes in order to restrict BPF helpers for tracing which are > broken on archs with overlapping address ranges as per discussion in [0]. > I've targetted this for -bpf tree so they can be routed as fixes. Thanks! Does

[PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread Bartosz Golaszewski
From: Bartosz Golaszewski mdio-moxart doesn't use regulators in the driver code. We can remove the regulator include. Signed-off-by: Bartosz Golaszewski --- drivers/net/phy/mdio-moxart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/phy/mdio-moxart.c b/drivers/net/phy/mdio-mox

[PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Jeremy Linton
The commit "disregard Clause 22 registers present bit..." clears the low bit of the devices_in_package data which is being used in get_phy_c45_ids() to determine if a phy/register is responding correctly. That check is against 0x1FFF, but since the low bit is always cleared, the check can never

Re: [PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 06:59:38PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread Florian Fainelli
On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] drivers: ipa: use devm_kzalloc for simplicity

2020-05-14 Thread Jakub Kicinski
On Wed, 13 May 2020 20:55:20 -0700 Wang Wenhu wrote: > Make a substitution of kzalloc with devm_kzalloc to simplify the > ipa_probe() process. > > Signed-off-by: Wang Wenhu The code is perfectly fine as is. What problem are you trying to solve?

Re: [PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread Bartosz Golaszewski
czw., 14 maj 2020 o 19:13 Florian Fainelli napisał(a): > > > > On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > mdio-moxart doesn't use regulators in the driver code. We can remove > > the regulator include. > > > > Signed-off-by: Bartosz Golaszewski > > Rev

Re: [PATCH net-next 0/4] Implement filter terse dump mode support

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 14:40:22 +0300 Vlad Buslov wrote: > Implement support for terse dump mode which provides only essential > classifier/action info (handle, stats, cookie, etc.). Use new > TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from > kernel. Looks reasonable: Reviewed-

Re: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-14 Thread Oleksij Rempel
On Thu, May 14, 2020 at 06:01:52PM +0200, Andrew Lunn wrote: > On Thu, May 14, 2020 at 03:47:16PM +, Christian Herber wrote: > > Hi Andrew, > > > > > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote: > > >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote: > > >> ETHT

Re: [PATCH net-next 0/5] net: hns3: add some cleanups for -next

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 20:41:21 +0800 Huazhong Tan wrote: > This patchset adds some cleanups for the HNS3 ethernet driver. You may want to spell out 'state' instead of 'stat' in patch 3, stat is often used as abbreviation of statistic. But that's a nit pick, up to you: Reviewed-by: Jakub Kicinski

Re: [PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread Florian Fainelli
On 5/14/2020 10:20 AM, Bartosz Golaszewski wrote: > czw., 14 maj 2020 o 19:13 Florian Fainelli napisał(a): >> >> >> >> On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> mdio-moxart doesn't use regulators in the driver code. We can remove >>> the regulator i

[PATCH net-next 0/2] DP83822 Fiber enablement

2020-05-14 Thread Dan Murphy
Hello The DP83822 Ethernet PHY has the ability to connect via a Fiber port. The DP83825 or DP83826 do not have this ability. In order to keep the same driver the DP83822 and the 825/826 phy_driver call backs need to be changed so that the DP83822 has it's own call back for config_init and adds a

[PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Dan Murphy
Add a dt binding for the TI dp83822 ethernet phy device. CC: Rob Herring Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83822.yaml | 49 +++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml diff --git a

[PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-05-14 Thread Dan Murphy
The DP83822 can be configured to use a Fiber connection. The strap register is read to determine if the device has been configured to use a fiber connection. With the fiber connection the PHY can be configured to detect whether the fiber connection is active by either a high signal or a low signa

Re: [PATCH bpf 2/3] bpf: add bpf_probe_read_{user, kernel}_str() to do_refine_retval_range

2020-05-14 Thread Yonghong Song
On 5/14/20 9:16 AM, Daniel Borkmann wrote: Given bpf_probe_read{,str}() BPF helpers are now only available under CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, we need to add the drop-in replacements of bpf_probe_read_{kernel,user}_str() to do_refine_retval_range() as well to avoid hitting the

Re: [PATCH v2 bpf-next 0/7] bpf, printk: add BTF-based type printing

2020-05-14 Thread Alan Maguire
On Wed, 13 May 2020, Alexei Starovoitov wrote: > On Tue, May 12, 2020 at 06:56:38AM +0100, Alan Maguire wrote: > > The printk family of functions support printing specific pointer types > > using %p format specifiers (MAC addresses, IP addresses, etc). For > > full details see Documentation/co

Re: [PATCH] libiptc.c: pragma disable a gcc compiler warning

2020-05-14 Thread Pablo Neira Ayuso
On Mon, May 11, 2020 at 02:34:04PM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Fixes: > In file included from libip4tc.c:113: > In function ‘iptcc_compile_chain’, > inlined from ‘iptcc_compile_table’ at libiptc.c:1246:13, > inlined from ‘iptc_commit’ at libip

[PATCH net v2 1/2] ipmr: Fix RCU list debugging warning

2020-05-14 Thread Amol Grover
ipmr_for_each_table() macro uses list_for_each_entry_rcu() for traversing outside of an RCU read side critical section but under the protection of rtnl_mutex. Hence, add the corresponding lockdep expression to silence the following false-positive warning at boot: [4.319347] ===

[PATCH net v2 2/2] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-14 Thread Amol Grover
During the initialization process, ipmr_new_table() is called to create new tables which in turn calls ipmr_get_table() which traverses net->ipv4.mr_tables without holding the writer lock. However, this is safe to do so as no tables exist at this time. Hence add a suitable lockdep expression to sil

Re: linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread Amol Grover
On Thu, May 14, 2020 at 08:24:54AM -0400, Qian Cai wrote: > > > > On May 14, 2020, at 7:37 AM, syzbot > > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: c9529331 Add linux-next specific files f

Re: [PATCH bpf 3/3] bpf: restrict bpf_trace_printk()'s %s usage and add %psK, %psU specifier

2020-05-14 Thread Yonghong Song
On 5/14/20 9:16 AM, Daniel Borkmann wrote: Usage of plain %s conversion specifier in bpf_trace_printk() suffers from the very same issue as bpf_probe_read{,str}() helpers, that is, it is broken on archs with overlapping address ranges. While the helpers have been addressed through work in 6ae

[PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-14 Thread Colin King
From: Colin Ian King Currently ldo_pwr has the LDO25 voltage bits set to zero and then it is overwritten with the new voltage setting. The assignment looks incorrect, it should be bit-wise or'ing in the new voltage setting rather than a direct assignment. Addresses-Coverity: ("Unused value") Fix

[PATCH][next] net: dsa: felix: fix incorrect clamp calculation for burst

2020-05-14 Thread Colin King
From: Colin Ian King Currently burst is clamping on rate and not burst, the assignment of burst from the clamping discards the previous assignment of burst. This looks like a cut-n-paste error from the previous clamping calculation on ramp. Fix this by replacing ramp with burst. Addresses-Cover

Re: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 12:30:54PM -0500, Dan Murphy wrote: > Add a dt binding for the TI dp83822 ethernet phy device. > > CC: Rob Herring > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83822.yaml | 49 +++ > 1 file changed, 49 insertions(+) > create mod

[PATCH AUTOSEL 5.6 31/62] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-14 Thread Sasha Levin
From: Yoshiyuki Kurauchi [ Upstream commit 846c68f7f1ac82c797a2f1db3344a2966c0fe2e1 ] In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers. Sign

[PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend on PTP_1588_CLOCK

2020-05-14 Thread Sasha Levin
From: Clay McClure [ Upstream commit b6d49cab44b567b3e0a5544b3d61e516a7355fad ] Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP c

[PATCH AUTOSEL 5.4 23/49] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

Re: "Forwarding" from TC classifier

2020-05-14 Thread David Ahern
On 5/14/20 9:41 AM, Lorenz Bauer wrote: > On Wed, 13 May 2020 at 18:48, David Ahern wrote: >> >> On 5/13/20 10:40 AM, Lorenz Bauer wrote: >>> We've recently open sourced a key component of our L4 load balancer: >>> cls_redirect [1]. >>> In the commit description, I call out the following caveat: >

[PATCH AUTOSEL 4.9 05/27] batman-adv: Fix refcnt leak in batadv_show_throughput_override

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit f872de8185acf1b48b954ba5bd8f9bc0a0d14016 ] batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When bata

[PATCH AUTOSEL 4.9 16/27] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

[PATCH AUTOSEL 4.9 23/27] net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

2020-05-14 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 40e473071dbad04316ddc3613c3a3d1c75458299 ] When ENOSPC is set the idx is still valid and gets set to the global MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that ENOSPC is impossible from mlx4_cmd_imm() and gives this warning: drivers/

[PATCH AUTOSEL 4.4 07/14] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

Re: [PATCH bpf 1/3] bpf: restrict bpf_probe_read{,str}() only to archs where they work

2020-05-14 Thread Linus Torvalds
On Thu, May 14, 2020 at 9:18 AM Daniel Borkmann wrote: > > However, their use should be restricted to archs with non-overlapping > address ranges where they are working in their current form. Therefore, > move this behind a CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE and > have x86, arm64, arm s

[PATCH AUTOSEL 4.4 10/14] net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

2020-05-14 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 40e473071dbad04316ddc3613c3a3d1c75458299 ] When ENOSPC is set the idx is still valid and gets set to the global MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that ENOSPC is impossible from mlx4_cmd_imm() and gives this warning: drivers/

[PATCH AUTOSEL 4.4 05/14] dp83640: reverse arguments to list_add_tail

2020-05-14 Thread Sasha Levin
From: Julia Lawall [ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ] In this code, it appears that phyter_clocks is a list head, based on the previous list_for_each, and that clock->list is intended to be a list element, given that it has just been initialized in dp83640_clock_init.

[PATCH AUTOSEL 4.4 08/14] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 4.4 03/14] batman-adv: fix batadv_nc_random_weight_tq

2020-05-14 Thread Sasha Levin
From: George Spelvin [ Upstream commit fd0c42c4dea54335967c5a86f15fc064235a2797 ] and change to pseudorandom numbers, as this is a traffic dithering operation that doesn't need crypto-grade. The previous code operated in 4 steps: 1. Generate a random byte 0 <= rand_tq <= 255 2. Multiply it by

[PATCH AUTOSEL 4.4 04/14] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 4.4 06/14] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

[PATCH AUTOSEL 4.9 17/27] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

[PATCH AUTOSEL 4.9 21/27] net: usb: qmi_wwan: add support for DW5816e

2020-05-14 Thread Sasha Levin
From: Matt Jolly [ Upstream commit 57c7f2bd758eed867295c81d3527fff4fab1ed74 ] Add support for Dell Wireless 5816e to drivers/net/usb/qmi_wwan.c Signed-off-by: Matt Jolly Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 1 + 1 f

[PATCH AUTOSEL 4.9 18/27] net: macsec: preserve ingress frame ordering

2020-05-14 Thread Sasha Levin
From: Scott Dial [ Upstream commit ab046a5d4be4c90a3952a0eae75617b49c0cb01b ] MACsec decryption always occurs in a softirq context. Since the FPU may not be usable in the softirq context, the call to decrypt may be scheduled on the cryptd work queue. The cryptd work queue does not provide orderi

[PATCH AUTOSEL 4.9 20/27] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-14 Thread Sasha Levin
From: Yoshiyuki Kurauchi [ Upstream commit 846c68f7f1ac82c797a2f1db3344a2966c0fe2e1 ] In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers. Sign

[PATCH AUTOSEL 4.9 13/27] net/mlx5: Fix forced completion access non initialized command entry

2020-05-14 Thread Sasha Levin
From: Moshe Shemesh [ Upstream commit f3cb3cebe26ed4c8036adbd9448b372129d3c371 ] mlx5_cmd_flush() will trigger forced completions to all valid command entries. Triggered by an asynch event such as fast teardown it can happen at any stage of the command, including command initialization. It will

[PATCH AUTOSEL 4.9 15/27] dp83640: reverse arguments to list_add_tail

2020-05-14 Thread Sasha Levin
From: Julia Lawall [ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ] In this code, it appears that phyter_clocks is a list head, based on the previous list_for_each, and that clock->list is intended to be a list element, given that it has just been initialized in dp83640_clock_init.

[PATCH AUTOSEL 4.9 19/27] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 4.9 14/27] net/mlx5: Fix command entry leak in Internal Error State

2020-05-14 Thread Sasha Levin
From: Moshe Shemesh [ Upstream commit cece6f432cca9f18900463ed01b97a152a03600a ] Processing commands by cmd_work_handler() while already in Internal Error State will result in entry leak, since the handler process force completion without doorbell. Forced completion doesn't release the entry and

[PATCH AUTOSEL 4.9 06/27] batman-adv: Fix refcnt leak in batadv_store_throughput_override

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit 6107c5da0fca8b50b4d3215e94d619d38cc4a18c ] batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When bata

[PATCH AUTOSEL 4.9 04/27] batman-adv: fix batadv_nc_random_weight_tq

2020-05-14 Thread Sasha Levin
From: George Spelvin [ Upstream commit fd0c42c4dea54335967c5a86f15fc064235a2797 ] and change to pseudorandom numbers, as this is a traffic dithering operation that doesn't need crypto-grade. The previous code operated in 4 steps: 1. Generate a random byte 0 <= rand_tq <= 255 2. Multiply it by

[PATCH AUTOSEL 4.9 10/27] bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().

2020-05-14 Thread Sasha Levin
From: Michael Chan [ Upstream commit c72cb303aa6c2ae7e4184f0081c6d11bf03fb96b ] The current logic in bnxt_fix_features() will inadvertently turn on both CTAG and STAG VLAN offload if the user tries to disable both. Fix it by checking that the user is trying to enable CTAG or STAG before enablin

[PATCH AUTOSEL 4.9 07/27] batman-adv: Fix refcnt leak in batadv_v_ogm_process

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit 6f91a3f7af4186099dd10fa530dd7e0d9c29747d ] batadv_v_ogm_process() invokes batadv_hardif_neigh_get(), which returns a reference of the neighbor object to "hardif_neigh" with increased refcount. When batadv_v_ogm_process() returns, "hardif_neigh" becomes invalid,

[PATCH AUTOSEL 4.9 11/27] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 4.14 26/39] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

[PATCH AUTOSEL 4.14 27/39] net: macsec: preserve ingress frame ordering

2020-05-14 Thread Sasha Levin
From: Scott Dial [ Upstream commit ab046a5d4be4c90a3952a0eae75617b49c0cb01b ] MACsec decryption always occurs in a softirq context. Since the FPU may not be usable in the softirq context, the call to decrypt may be scheduled on the cryptd work queue. The cryptd work queue does not provide orderi

[PATCH AUTOSEL 4.14 28/39] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 4.14 32/39] net: usb: qmi_wwan: add support for DW5816e

2020-05-14 Thread Sasha Levin
From: Matt Jolly [ Upstream commit 57c7f2bd758eed867295c81d3527fff4fab1ed74 ] Add support for Dell Wireless 5816e to drivers/net/usb/qmi_wwan.c Signed-off-by: Matt Jolly Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 1 + 1 f

[PATCH AUTOSEL 4.14 25/39] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

[PATCH AUTOSEL 4.14 30/39] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-14 Thread Sasha Levin
From: Yoshiyuki Kurauchi [ Upstream commit 846c68f7f1ac82c797a2f1db3344a2966c0fe2e1 ] In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers. Sign

[PATCH AUTOSEL 4.14 34/39] net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

2020-05-14 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 40e473071dbad04316ddc3613c3a3d1c75458299 ] When ENOSPC is set the idx is still valid and gets set to the global MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that ENOSPC is impossible from mlx4_cmd_imm() and gives this warning: drivers/

[PATCH AUTOSEL 4.14 24/39] dp83640: reverse arguments to list_add_tail

2020-05-14 Thread Sasha Levin
From: Julia Lawall [ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ] In this code, it appears that phyter_clocks is a list head, based on the previous list_for_each, and that clock->list is intended to be a list element, given that it has just been initialized in dp83640_clock_init.

[PATCH AUTOSEL 4.14 18/39] bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().

2020-05-14 Thread Sasha Levin
From: Michael Chan [ Upstream commit c72cb303aa6c2ae7e4184f0081c6d11bf03fb96b ] The current logic in bnxt_fix_features() will inadvertently turn on both CTAG and STAG VLAN offload if the user tries to disable both. Fix it by checking that the user is trying to enable CTAG or STAG before enablin

[PATCH AUTOSEL 4.14 23/39] net/mlx5: Fix command entry leak in Internal Error State

2020-05-14 Thread Sasha Levin
From: Moshe Shemesh [ Upstream commit cece6f432cca9f18900463ed01b97a152a03600a ] Processing commands by cmd_work_handler() while already in Internal Error State will result in entry leak, since the handler process force completion without doorbell. Forced completion doesn't release the entry and

[PATCH AUTOSEL 4.14 22/39] net/mlx5: Fix forced completion access non initialized command entry

2020-05-14 Thread Sasha Levin
From: Moshe Shemesh [ Upstream commit f3cb3cebe26ed4c8036adbd9448b372129d3c371 ] mlx5_cmd_flush() will trigger forced completions to all valid command entries. Triggered by an asynch event such as fast teardown it can happen at any stage of the command, including command initialization. It will

[PATCH AUTOSEL 4.14 19/39] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 4.14 17/39] vhost/vsock: fix packet delivery order to monitoring devices

2020-05-14 Thread Sasha Levin
From: Stefano Garzarella [ Upstream commit 107bc0766b9feb5113074c753735a3f115c2141f ] We want to deliver packets to monitoring devices before it is put in the virtqueue, to avoid that replies can appear in the packet capture before the transmitted packet. Signed-off-by: Stefano Garzarella Sign

[PATCH AUTOSEL 4.14 04/39] batman-adv: fix batadv_nc_random_weight_tq

2020-05-14 Thread Sasha Levin
From: George Spelvin [ Upstream commit fd0c42c4dea54335967c5a86f15fc064235a2797 ] and change to pseudorandom numbers, as this is a traffic dithering operation that doesn't need crypto-grade. The previous code operated in 4 steps: 1. Generate a random byte 0 <= rand_tq <= 255 2. Multiply it by

[PATCH AUTOSEL 4.14 05/39] batman-adv: Fix refcnt leak in batadv_show_throughput_override

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit f872de8185acf1b48b954ba5bd8f9bc0a0d14016 ] batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When bata

[PATCH AUTOSEL 4.14 06/39] batman-adv: Fix refcnt leak in batadv_store_throughput_override

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit 6107c5da0fca8b50b4d3215e94d619d38cc4a18c ] batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When bata

[PATCH AUTOSEL 4.14 07/39] batman-adv: Fix refcnt leak in batadv_v_ogm_process

2020-05-14 Thread Sasha Levin
From: Xiyu Yang [ Upstream commit 6f91a3f7af4186099dd10fa530dd7e0d9c29747d ] batadv_v_ogm_process() invokes batadv_hardif_neigh_get(), which returns a reference of the neighbor object to "hardif_neigh" with increased refcount. When batadv_v_ogm_process() returns, "hardif_neigh" becomes invalid,

[PATCH AUTOSEL 4.19 18/31] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

[PATCH AUTOSEL 4.19 25/31] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-14 Thread Sasha Levin
From: Maxim Petrov [ Upstream commit f42234ffd531ca6b13d9da02faa60b72eccf8334 ] The paranoidal pointer check in IRQ handler looks very strange - it really protects us only against bogus drivers which request IRQ line with null pointer dev_id. However, the code fragment is incorrect because the d

[PATCH AUTOSEL 4.19 17/31] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

[PATCH AUTOSEL 4.19 19/31] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 4.19 21/31] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-14 Thread Sasha Levin
From: Yoshiyuki Kurauchi [ Upstream commit 846c68f7f1ac82c797a2f1db3344a2966c0fe2e1 ] In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers. Sign

[PATCH AUTOSEL 4.19 11/31] aquantia: Fix the media type of AQC100 ethernet controller in the driver

2020-05-14 Thread Sasha Levin
From: Richard Clark [ Upstream commit 6de556c31061e3b9c36546ffaaac5fdb679a2f14 ] The Aquantia AQC100 controller enables a SFP+ port, so the driver should configure the media type as '_TYPE_FIBRE' instead of '_TYPE_TP'. Signed-off-by: Richard Clark Cc: Igor Russkikh Cc: "David S. Miller" Acke

[PATCH AUTOSEL 4.19 12/31] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 5.4 33/49] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-14 Thread Sasha Levin
From: Maxim Petrov [ Upstream commit f42234ffd531ca6b13d9da02faa60b72eccf8334 ] The paranoidal pointer check in IRQ handler looks very strange - it really protects us only against bogus drivers which request IRQ line with null pointer dev_id. However, the code fragment is incorrect because the d

[PATCH AUTOSEL 4.19 10/31] vhost/vsock: fix packet delivery order to monitoring devices

2020-05-14 Thread Sasha Levin
From: Stefano Garzarella [ Upstream commit 107bc0766b9feb5113074c753735a3f115c2141f ] We want to deliver packets to monitoring devices before it is put in the virtqueue, to avoid that replies can appear in the packet capture before the transmitted packet. Signed-off-by: Stefano Garzarella Sign

[PATCH AUTOSEL 5.4 22/49] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Alexei Starovoitov
On Wed, May 13, 2020 at 12:25:27PM -0700, Andrii Nakryiko wrote: > + > +/* Given pointer to ring buffer record metadata, restore pointer to struct > + * bpf_ringbuf itself by using page offset stored at offset 4 > + */ > +static struct bpf_ringbuf *bpf_ringbuf_restore_from_rec(void *meta_ptr) > +{

[PATCH AUTOSEL 5.4 24/49] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 5.4 28/49] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-14 Thread Sasha Levin
From: Yoshiyuki Kurauchi [ Upstream commit 846c68f7f1ac82c797a2f1db3344a2966c0fe2e1 ] In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers. Sign

[PATCH AUTOSEL 5.4 21/49] ibmvnic: Skip fatal error reset after passive init

2020-05-14 Thread Sasha Levin
From: Juliet Kim [ Upstream commit f9c6cea0b38518741c8dcf26ac056d26ee2fd61d ] During MTU change, the following events may happen. Client-driven CRQ initialization fails due to partner’s CRQ closed, causing client to enqueue a reset task for FATAL_ERROR. Then passive (server-driven) CRQ initializ

[PATCH AUTOSEL 5.4 13/49] aquantia: Fix the media type of AQC100 ethernet controller in the driver

2020-05-14 Thread Sasha Levin
From: Richard Clark [ Upstream commit 6de556c31061e3b9c36546ffaaac5fdb679a2f14 ] The Aquantia AQC100 controller enables a SFP+ port, so the driver should configure the media type as '_TYPE_FIBRE' instead of '_TYPE_TP'. Signed-off-by: Richard Clark Cc: Igor Russkikh Cc: "David S. Miller" Acke

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 12:57:16 +0300 Igor Russkikh wrote: > FastLinQ devices as a complex systems may observe various hardware > level error conditions, both severe and recoverable. > > Driver is able to detect and report this, but so far it only did > trace/dmesg based reporting. > > Here we imple

[PATCH AUTOSEL 5.4 17/49] net/ena: Fix build warning in ena_xdp_set()

2020-05-14 Thread Sasha Levin
From: Gavin Shan [ Upstream commit caec66198d137c26f0d234abc498866a58c64150 ] This fixes the following build warning in ena_xdp_set(), which is observed on aarch64 with 64KB page size. In file included from ./include/net/inet_sock.h:19, from ./include/net/ip.h:27, from drivers/ne

[PATCH AUTOSEL 5.4 02/49] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()

2020-05-14 Thread Sasha Levin
From: Masahiro Yamada [ Upstream commit 1cd9b3abf5332102d4d967555e7ed861a75094bf ] In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR. The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR from being 'm' when NET_DEVLINK=y. With the planned Kconfig change that relaxes the 'i

[PATCH AUTOSEL 5.4 14/49] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 5.4 12/49] vhost/vsock: fix packet delivery order to monitoring devices

2020-05-14 Thread Sasha Levin
From: Stefano Garzarella [ Upstream commit 107bc0766b9feb5113074c753735a3f115c2141f ] We want to deliver packets to monitoring devices before it is put in the virtqueue, to avoid that replies can appear in the packet capture before the transmitted packet. Signed-off-by: Stefano Garzarella Sign

[PATCH AUTOSEL 5.6 51/62] wireguard: selftests: initalize ipv6 members to NULL to squelch clang warning

2020-05-14 Thread Sasha Levin
From: "Jason A. Donenfeld" [ Upstream commit 4fed818ef54b08d4b29200e416cce65546ad5312 ] Without setting these to NULL, clang complains in certain configurations that have CONFIG_IPV6=n: In file included from drivers/net/wireguard/ratelimiter.c:223: drivers/net/wireguard/selftest/ratelimiter.c:1

[PATCH AUTOSEL 5.6 50/62] net: mscc: ocelot: ANA_AUTOAGE_AGE_PERIOD holds a value in seconds, not ms

2020-05-14 Thread Sasha Levin
From: Vladimir Oltean [ Upstream commit c0d7eccbc76115b7eb337956c03d47d6a889cf8c ] One may notice that automatically-learnt entries 'never' expire, even though the bridge configures the address age period at 300 seconds. Actually the value written to hardware corresponds to a time interval 1000

[PATCH AUTOSEL 5.6 49/62] net: dsa: ocelot: the MAC table on Felix is twice as large

2020-05-14 Thread Sasha Levin
From: Vladimir Oltean [ Upstream commit 21ce7f3e16fbf89faaf149cfe0f730edfc553914 ] When running 'bridge fdb dump' on Felix, sometimes learnt and static MAC addresses would appear, sometimes they wouldn't. Turns out, the MAC table has 4096 entries on VSC7514 (Ocelot) and 8192 entries on VSC9959

[PATCH AUTOSEL 5.6 37/62] net: stmmac: gmac5+: fix potential integer overflow on 32 bit multiply

2020-05-14 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 44d95cc6b10ff7439d45839c96c581cb4368c088 ] The multiplication of cfg->ctr[1] by 10 is performed using a 32 bit multiplication (since cfg->ctr[1] is a u32) and this can lead to a potential overflow. Fix this by making the constant a ULL to ensure a 6

[PATCH AUTOSEL 5.6 36/62] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-14 Thread Sasha Levin
From: Maxim Petrov [ Upstream commit f42234ffd531ca6b13d9da02faa60b72eccf8334 ] The paranoidal pointer check in IRQ handler looks very strange - it really protects us only against bogus drivers which request IRQ line with null pointer dev_id. However, the code fragment is incorrect because the d

[PATCH AUTOSEL 5.6 29/62] hv_netvsc: Fix netvsc_start_xmit's return type

2020-05-14 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 7fdc66debebc6a7170a37c8c9b0d9585a9788fb4 ] netvsc_start_xmit is used as a callback function for the ndo_start_xmit function pointer. ndo_start_xmit's return type is netdev_tx_t but netvsc_start_xmit's return type is int. This causes a failure with Contr

Re: [PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-05-14 Thread Andrew Lunn
> +static int dp83822_config_init(struct phy_device *phydev) > +{ > + struct dp83822_private *dp83822 = phydev->priv; > + int err = 0; > + > + if (dp83822->fx_enabled) { > + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, > + phydev->supported); >

[PATCH AUTOSEL 5.6 23/62] net: ipa: fix a bug in ipa_endpoint_stop()

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 713b6ebb4c376b3fb65fdceb3b59e401c93248f9 ] In ipa_endpoint_stop(), for TX endpoints we set the number of retries to 0. When we break out of the loop, retries being 0 means we return EIO rather than the value of ret (which should be 0). Fix this by using a non

[PATCH AUTOSEL 5.6 24/62] net: moxa: Fix a potential double 'free_irq()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: C

[PATCH AUTOSEL 5.6 14/62] aquantia: Fix the media type of AQC100 ethernet controller in the driver

2020-05-14 Thread Sasha Levin
From: Richard Clark [ Upstream commit 6de556c31061e3b9c36546ffaaac5fdb679a2f14 ] The Aquantia AQC100 controller enables a SFP+ port, so the driver should configure the media type as '_TYPE_FIBRE' instead of '_TYPE_TP'. Signed-off-by: Richard Clark Cc: Igor Russkikh Cc: "David S. Miller" Acke

<    1   2   3   4   5   >