[PATCH net-next v4 30/33] xdp: clear grow memory in bpf_xdp_adjust_tail()

2020-05-14 Thread Jesper Dangaard Brouer
Clearing memory of tail when grow happens, because it is too easy to write a XDP_PASS program that extend the tail, which expose this memory to users that can run tcpdump. Signed-off-by: Jesper Dangaard Brouer Acked-by: Toke Høiland-Jørgensen --- net/core/filter.c |4 1 file changed, 4

[PATCH net-next v4 33/33] selftests/bpf: xdp_adjust_tail add grow tail tests

2020-05-14 Thread Jesper Dangaard Brouer
Extend BPF selftest xdp_adjust_tail with grow tail tests, which is added as subtest's. The first grow test stays in same form as original shrink test. The second grow test use the newer bpf_prog_test_run_xattr() calls, and does extra checking of data contents. Signed-off-by: Jesper Dangaard Brouer

[PATCH net-next v4 26/33] ice: add XDP frame size to driver

2020-05-14 Thread Jesper Dangaard Brouer
This driver uses different memory models depending on PAGE_SIZE at compile time. For PAGE_SIZE 4K it uses page splitting, meaning for normal MTU frame size is 2048 bytes (and headroom 192 bytes). For larger MTUs the driver still use page splitting, by allocating order-1 pages (8192 bytes) for RX fr

[PATCH net-next v4 25/33] i40e: add XDP frame size to driver

2020-05-14 Thread Jesper Dangaard Brouer
This driver uses different memory models depending on PAGE_SIZE at compile time. For PAGE_SIZE 4K it uses page splitting, meaning for normal MTU frame size is 2048 bytes (and headroom 192 bytes). For larger MTUs the driver still use page splitting, by allocating order-1 pages (8192 bytes) for RX fr

[PATCH net-next v4 28/33] mlx5: rx queue setup time determine frame_sz for XDP

2020-05-14 Thread Jesper Dangaard Brouer
The mlx5 driver have multiple memory models, which are also changed according to whether a XDP bpf_prog is attached. The 'rx_striding_rq' setting is adjusted via ethtool priv-flags e.g.: # ethtool --set-priv-flags mlx5p2 rx_striding_rq off On the general case with 4K page_size and regular MTU pa

[PATCH net-next v4 32/33] selftests/bpf: adjust BPF selftest for xdp_adjust_tail

2020-05-14 Thread Jesper Dangaard Brouer
Current selftest for BPF-helper xdp_adjust_tail only shrink tail. Make it more clear that this is a shrink test case. Signed-off-by: Jesper Dangaard Brouer --- .../selftests/bpf/prog_tests/xdp_adjust_tail.c |9 +- .../testing/selftests/bpf/progs/test_adjust_tail.c | 30

[PATCH net-next v4 31/33] bpf: add xdp.frame_sz in bpf_prog_test_run_xdp().

2020-05-14 Thread Jesper Dangaard Brouer
Update the memory requirements, when adding xdp.frame_sz in BPF test_run function bpf_prog_test_run_xdp() which e.g. is used by XDP selftests. Specifically add the expected reserved tailroom, but also allocated a larger memory area to reflect that XDP frames usually comes in this format. Limit the

[PATCH net-next v4 27/33] xdp: for Intel AF_XDP drivers add XDP frame_sz

2020-05-14 Thread Jesper Dangaard Brouer
Intel drivers implement native AF_XDP zerocopy in separate C-files, that have its own invocation of bpf_prog_run_xdp(). The setup of xdp_buff is also handled in separately from normal code path. This patch update XDP frame_sz for AF_XDP zerocopy drivers i40e, ice and ixgbe, as the code changes nee

[PATCH net-next v4 29/33] xdp: allow bpf_xdp_adjust_tail() to grow packet size

2020-05-14 Thread Jesper Dangaard Brouer
Finally, after all drivers have a frame size, allow BPF-helper bpf_xdp_adjust_tail() to grow or extend packet size at frame tail. Remember that helper/macro xdp_data_hard_end have reserved some tailroom. Thus, this helper makes sure that the BPF-prog don't have access to this tailroom area. V2:

Re: netfilter: does the API break or something else ?

2020-05-14 Thread Phil Sutter
Hi, On Wed, May 13, 2020 at 11:20:35PM +0800, Xiubo Li wrote: > Recently I hit one netfilter issue, it seems the API breaks or something > else. Just for the record, this was caused by a misconfigured kernel. Cheers, Phil

[PATCH] drivers: ipa: fix typos for ipa_smp2p structure doc

2020-05-14 Thread Wang Wenhu
Remove the duplicate "mutex", and change "Motex" to "Mutex". Also I recommend it's easier for understanding to make the "ready-interrupt" a bundle for it is a parallel description as "shutdown" which is appended after the slash. Signed-off-by: Wang Wenhu Cc: Alex Elder --- drivers/net/ipa/ipa_s

RE: remove kernel_setsockopt and kernel_getsockopt

2020-05-14 Thread David Laight
From: 'Christoph Hellwig' > Sent: 14 May 2020 11:35 > On Thu, May 14, 2020 at 10:26:41AM +, David Laight wrote: > > From: Christoph Hellwig > > > Only for those were we have users, and all those are covered. > > > > What do we tell all our users when our kernel SCTP code > > no longer works? >

Re: netfilter: does the API break or something else ?

2020-05-14 Thread Xiubo Li
On 2020/5/14 18:54, Phil Sutter wrote: Hi, On Wed, May 13, 2020 at 11:20:35PM +0800, Xiubo Li wrote: Recently I hit one netfilter issue, it seems the API breaks or something else. Just for the record, this was caused by a misconfigured kernel. Yeah, thanks Phil for your help. BRs Xiubo

linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c9529331 Add linux-next specific files for 20200514 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17119f4810 kernel config: https://syzkaller.appspot.com/x/.config?x=404a80e135048067 dashboard

[PATCH net-next 4/4] selftests: implement flower classifier terse dump tests

2020-05-14 Thread Vlad Buslov
Implement two basic tests to verify terse dump functionality of flower classifier: - Test that verifies that terse dump works. - Test that verifies that terse dump doesn't print filter key. Signed-off-by: Vlad Buslov --- .../tc-testing/tc-tests/filters/tests.json| 38 +++ 1

[PATCH net-next 1/4] net: sched: introduce terse dump flag

2020-05-14 Thread Vlad Buslov
Add new TCA_DUMP_FLAGS attribute and use it in cls API to request terse filter output from classifiers with TCA_DUMP_FLAGS_TERSE flag. This option is intended to be used to improve performance of TC filter dump when userland only needs to obtain stats and not the whole classifier/action data. Exten

[PATCH net-next 3/4] net: sched: cls_flower: implement terse dump support

2020-05-14 Thread Vlad Buslov
Implement tcf_proto_ops->terse_dump() callback for flower classifier. Only dump handle, flags and action data in terse mode. Signed-off-by: Vlad Buslov Reviewed-by: Jiri Pirko --- net/sched/cls_flower.c | 43 ++ 1 file changed, 43 insertions(+) diff --gi

[PATCH net-next 0/4] Implement filter terse dump mode support

2020-05-14 Thread Vlad Buslov
Implement support for terse dump mode which provides only essential classifier/action info (handle, stats, cookie, etc.). Use new TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from kernel. Implement classifier-action terse dump mode Output rate of current upstream kernel TC fil

[PATCH net-next 2/4] net: sched: implement terse dump support in act

2020-05-14 Thread Vlad Buslov
Extend tcf_action_dump() with boolean argument 'terse' that is used to request terse-mode action dump. In terse mode only essential data needed to identify particular action (action kind, cookie, etc.) and its stats is put to resulting skb and everything else is omitted. Implement tcf_exts_terse_du

Re: [PATCH 0/8 net] the indirect flow_block offload, revisited

2020-05-14 Thread Edward Cree
On 13/05/2020 17:41, Pablo Neira Ayuso wrote: > Hi, > > This patchset fixes the indirect flow_block support for the tc CT action > offload. Please, note that this batch is probably slightly large for the > net tree, however, I could not find a simple incremental fix. > > = The problem > > The nf_fl

[PATCH net 1/1] MAINTAINERS: another add of Karsten Graul for S390 networking

2020-05-14 Thread Ursula Braun
Complete adding of Karsten as maintainer for all S390 networking parts in the kernel. Cc: Julian Wiedmann Acked-by: Julian Wiedmann Signed-off-by: Ursula Braun --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 85894787825e..391e7eea6a3e 100644

Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr

2020-05-14 Thread Joe Perches
On Thu, 2020-05-14 at 12:30 +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 02:00:43PM -0700, Joe Perches wrote: > > On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote: > > > Add a helper to directly set the IP_RECVERR sockopt from kernel space > > > without going through a fake u

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-14 Thread Oleksij Rempel
On Wed, May 13, 2020 at 08:01:40PM +0200, Andrew Lunn wrote: > > What would be the best place to do a test before the link is getting up? > > Can it be done in the phy core, or it should be done in the PHY driver? > > > > So far, no action except of logging these errors is needed. > > You could

[PATCH][next] selftest/bpf: fix spelling mistake "SIGALARM" -> "SIGALRM"

2020-05-14 Thread Colin King
From: Colin Ian King There is a spelling mistake in an error message, fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/bpf/bench.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/bench.c b/tools/testing/selftests/bpf/bench.c ind

[PATCH 1/6] netfilter: conntrack: avoid gcc-10 zero-length-bounds warning

2020-05-14 Thread Pablo Neira Ayuso
From: Arnd Bergmann gcc-10 warns around a suspicious access to an empty struct member: net/netfilter/nf_conntrack_core.c: In function '__nf_conntrack_alloc': net/netfilter/nf_conntrack_core.c:1522:9: warning: array subscript 0 is outside the bounds of an interior zero-length array 'u8[0]' {aka

[PATCH 5/6] netfilter: flowtable: set NF_FLOW_TEARDOWN flag on entry expiration

2020-05-14 Thread Pablo Neira Ayuso
If the flow timer expires, the gc sets on the NF_FLOW_TEARDOWN flag. Otherwise, the flowtable software path might race to refresh the timeout, leaving the state machine in inconsistent state. Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support") Reported-by: Paul Blakey Revie

[PATCH 3/6] netfilter: flowtable: Remove WQ_MEM_RECLAIM from workqueue

2020-05-14 Thread Pablo Neira Ayuso
From: Roi Dayan This workqueue is in charge of handling offloaded flow tasks like add/del/stats we should not use WQ_MEM_RECLAIM flag. The flag can result in the following warning. [ 485.557189] [ cut here ] [ 485.562976] workqueue: WQ_MEM_RECLAIM nf_flow_table_offload:

[PATCH 4/6] netfilter: conntrack: fix infinite loop on rmmod

2020-05-14 Thread Pablo Neira Ayuso
From: Florian Westphal 'rmmod nf_conntrack' can hang forever, because the netns exit gets stuck in nf_conntrack_cleanup_net_list(): i_see_dead_people: busy = 0; list_for_each_entry(net, net_exit_list, exit_list) { nf_ct_iterate_cleanup(kill_all, net, 0, 0); if (atomic_read(&net->ct.count)

[PATCH 2/6] netfilter: flowtable: Add pending bit for offload work

2020-05-14 Thread Pablo Neira Ayuso
From: Paul Blakey Gc step can queue offloaded flow del work or stats work. Those work items can race each other and a flow could be freed before the stats work is executed and querying it. To avoid that, add a pending bit that if a work exists for a flow don't queue another work for it. This will

[PATCH 0/6] Netfilter fixes for net

2020-05-14 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Fix gcc-10 compilation warning in nf_conntrack, from Arnd Bergmann. 2) Add NF_FLOW_HW_PENDING to avoid races between stats and deletion commands, from Paul Blakey. 3) Remove WQ_MEM_RECLAIM from the offload workqueue, from Roi Da

[PATCH 6/6] netfilter: nft_set_rbtree: Add missing expired checks

2020-05-14 Thread Pablo Neira Ayuso
From: Phil Sutter Expired intervals would still match and be dumped to user space until garbage collection wiped them out. Make sure they stop matching and disappear (from users' perspective) as soon as they expire. Fixes: 8d8540c4f5e03 ("netfilter: nft_set_rbtree: add timeout support") Signed-o

Re: [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success

2020-05-14 Thread Pablo Neira Ayuso
On Mon, May 11, 2020 at 02:33:49PM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This looks like an oversight which is easy to fix. Applied.

Re: linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread Qian Cai
> On May 14, 2020, at 7:37 AM, syzbot > wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:c9529331 Add linux-next specific files for 20200514 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=

RE: [PATCH 32/33] sctp: add sctp_sock_get_primary_addr

2020-05-14 Thread David Laight
From: David Laight > Sent: 14 May 2020 10:51 > From: Marcelo Ricardo Leitner > > Sent: 13 May 2020 19:03 > > > > On Wed, May 13, 2020 at 08:26:47AM +0200, Christoph Hellwig wrote: > > > Add a helper to directly get the SCTP_PRIMARY_ADDR sockopt from kernel > > > space without going through a fake u

[PATCH net/next] r8152: Use MAC address from device tree if available

2020-05-14 Thread Thierry Reding
From: Thierry Reding If a MAC address was passed via the device tree node for the r8152 device, use it and fall back to reading from EEPROM otherwise. This is useful for devices where the r8152 EEPROM was not programmed with a valid MAC address, or if users want to explicitly set a MAC address in

[PATCH net-next 1/5] net: hns3: modify some incorrect spelling

2020-05-14 Thread Huazhong Tan
This patch modifies some incorrect spelling. Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 2 +- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-

[PATCH net-next 3/5] net: hns3: modify an incorrect error log in hclge_mbx_handler()

2020-05-14 Thread Huazhong Tan
When handling HCLGE_MBX_GET_LINK_STATUS, PF will return the link status to the VF, so the error log of hclge_get_link_info() is incorrect. Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH net-next 4/5] net: hns3: remove some unused macros

2020-05-14 Thread Huazhong Tan
There are some macros defined in hns3_enet.h, but not used in anywhere. Reported-by: Yonglong Liu Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

[PATCH net-next 5/5] net: hns3: remove unnecessary frag list checking in hns3_nic_net_xmit()

2020-05-14 Thread Huazhong Tan
The skb_has_frag_list() in hns3_nic_net_xmit() is redundant, since skb_walk_frags() includes this checking implicitly. Reported-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH net-next 0/5] net: hns3: add some cleanups for -next

2020-05-14 Thread Huazhong Tan
This patchset adds some cleanups for the HNS3 ethernet driver. Huazhong Tan (5): net: hns3: modify some incorrect spelling net: hns3: remove a duplicated printing in hclge_configure() net: hns3: modify an incorrect error log in hclge_mbx_handler() net: hns3: remove some unused macros net

[PATCH net-next 2/5] net: hns3: remove a duplicated printing in hclge_configure()

2020-05-14 Thread Huazhong Tan
Since hclge_get_cfg() already has error print, so hclge_configure() should not print error when calling hclge_get_cfg() fail. Reported-by: Guangbin Huang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 04:26:30AM +0200, Marek Vasut wrote: > On 5/14/20 3:57 AM, Andrew Lunn wrote: > >> diff --git a/drivers/net/ethernet/micrel/ks8851_par.c > >> b/drivers/net/ethernet/micrel/ks8851_par.c > >> new file mode 100644 > >> index ..90fffacb1695 > >> --- /dev/null > >> +

[PATCH iproute2-next 1/2] tc: skip actions that don't have options attribute when printing

2020-05-14 Thread Vlad Buslov
Modify implementations that return error from action_until->print_aopt() callback to silently skip actions that don't have their corresponding TCA_ACT_OPTIONS attribute set (some actions already behave like this). This is necessary to support terse dump mode in following patch in the series. Signe

[PATCH iproute2-next 0/2] Implement filter terse dump mode support

2020-05-14 Thread Vlad Buslov
Implement support for terse dump mode which provides only essential classifier/action info (handle, stats, cookie, etc.). Use new TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from kernel. Vlad Buslov (2): tc: skip actions that don't have options attribute when printing tc:

[PATCH iproute2-next 2/2] tc: implement support for terse dump

2020-05-14 Thread Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when user requested it with following example CLI: > tc -s filter show terse dev ens1f0 ingress In terse mode dump only outputs essential data needed t

RE: [PATCH 32/33] sctp: add sctp_sock_get_primary_addr

2020-05-14 Thread David Laight
From: David Laight > Sent: 14 May 2020 13:30 > Subject: RE: [PATCH 32/33] sctp: add sctp_sock_get_primary_addr > > From: David Laight > > Sent: 14 May 2020 10:51 > > From: Marcelo Ricardo Leitner > > > Sent: 13 May 2020 19:03 > > > > > > On Wed, May 13, 2020 at 08:26:47AM +0200, Christoph Hellwig

Re: [bpf-next PATCH 2/3] bpf: sk_msg helpers for probe_* and *current_task*

2020-05-14 Thread John Fastabend
Yonghong Song wrote: > > > On 5/13/20 12:24 PM, John Fastabend wrote: > > Often it is useful when applying policy to know something about the > > task. If the administrator has CAP_SYS_ADMIN rights then they can > > use kprobe + sk_msg and link the two programs together to accomplish > > this. Ho

Hi

2020-05-14 Thread Jessica Vail
Hi dear, I'm Jessica Vail, from the United States,please i wish to have a communication with you. I wait for your answer. Jessica Vail.

Re: [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE

2020-05-14 Thread Richard Cochran
On Thu, May 14, 2020 at 12:28:07PM +0200, Olivier Dautricourt wrote: > This commit allows a user to specify a flag value for configuring > timestamping through hwtsamp_config structure. > > New flags introduced: > > HWTSTAMP_FLAGS_NONE = 0 > No flag specified: as it is of value 0, this will

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote: > On Wed, May 13, 2020 at 08:01:40PM +0200, Andrew Lunn wrote: > > > What would be the best place to do a test before the link is getting up? > > > Can it be done in the phy core, or it should be done in the PHY driver? > > > > > > So

Re: [PATCH iproute2-next 1/2] tc: skip actions that don't have options attribute when printing

2020-05-14 Thread Jiri Pirko
Thu, May 14, 2020 at 03:23:05PM CEST, vla...@mellanox.com wrote: >Modify implementations that return error from action_until->print_aopt() >callback to silently skip actions that don't have their corresponding >TCA_ACT_OPTIONS attribute set (some actions already behave like this). This >is necessar

Re: [PATCH iproute2-next 2/2] tc: implement support for terse dump

2020-05-14 Thread Jiri Pirko
Thu, May 14, 2020 at 03:23:06PM CEST, vla...@mellanox.com wrote: >Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS >tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when >user requested it with following example CLI: > >> tc -s filter show terse dev e

[PATCH net-next 1/3] netfilter: flowtable: Control flow offload timeout interval

2020-05-14 Thread Paul Blakey
Add support for setting per flow table flow timeout in seconds, which determines the after how many seconds from last seen packet to delete the flow from offload. This can be set by the user of the API before initializing the table, otherwise, the default value (30 seconds) will be used. Signed-of

[PATCH net-next 2/3] net/sched: act_ct: Add policy_pkts tuple offload control policy

2020-05-14 Thread Paul Blakey
Use netfilter packet accounting to add support for tc user specifying per zone policy_pkts, which determines after how many packets a tuple will be offloaded to the zone's flow table. To avoid conflicting policies, the same policy must be given for all act ct instances of the same zone. Usage exa

[PATCH net-next 0/3] net/sched: act_ct: Add support for specifying tuple offload policy

2020-05-14 Thread Paul Blakey
This patchset adds support for specifying the offload policy of act ct offloaded flows to the nf flow table (and then hardware). policy_pkts - specifies after how many software packets to offload a flow to the flow table policy_timeout - specifies the aging timeout, in seconds, from last seen pac

[PATCH net-next 3/3] net/sched: act_ct: Add policy_timeout tuple offload control policy

2020-05-14 Thread Paul Blakey
Use nf flow table flow timeout param, to add support for tc user specifying per zone policy_timeout, which determines the time, in seconds, a tuple will remain offloaded in the flow table after last seen packet. To avoid conflicting policies, the same policy must be given for all act ct instances

Re: [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock

2020-05-14 Thread Richard Cochran
On Thu, May 14, 2020 at 12:28:05PM +0200, Olivier Dautricourt wrote: > This patch series covers a use case where an embedded system is > disciplining an internal clock to a GNSS signal, which provides a > stable frequency, and wants to act as a PTP Grandmaster by disciplining > a ptp clock to this

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Marek Vasut
On 5/14/20 3:15 PM, Andrew Lunn wrote: > On Thu, May 14, 2020 at 04:26:30AM +0200, Marek Vasut wrote: >> On 5/14/20 3:57 AM, Andrew Lunn wrote: diff --git a/drivers/net/ethernet/micrel/ks8851_par.c b/drivers/net/ethernet/micrel/ks8851_par.c new file mode 100644 index 00

Re: [PATCH net-next 0/3] net/sched: act_ct: Add support for specifying tuple offload policy

2020-05-14 Thread Edward Cree
On 14/05/2020 14:48, Paul Blakey wrote: > To avoid conflicting policies, the policy is applied per zone on the first > act ct instance for that zone, and must be repeated in all further act ct > instances of the same zone. Is the scope of this the entire zone, or just offload of that zone to a  spe

Netdev conf 0x14 update

2020-05-14 Thread Jamal Hadi Salim
Hi, Apologies for taking longer than promised to provide an update on the conference. We finally have a decision - the conference is going fully virtual. For details please see: https://netdevconf.info/0x14/news.html?virtual-netdev-0x14 cheers, jamal

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Andrew Lunn
> All right > > btw is jiffies-based timeout OK? Like this: If you can, make use of include/linux/iopoll.h Andrew

[PATCH iproute2/net-next] man: tc-ct.8: Add manual page for ct tc action

2020-05-14 Thread Paul Blakey
Signed-off-by: Paul Blakey --- man/man8/tc-ct.8 | 107 +++ man/man8/tc-flower.8 | 6 +++ 2 files changed, 113 insertions(+) create mode 100644 man/man8/tc-ct.8 diff --git a/man/man8/tc-ct.8 b/man/man8/tc-ct.8 new file mode 100644 index 0

[PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c

2020-05-14 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik This patch fixes the following warning: = WARNING: suspicious RCU usage 5.7.0-rc5-next-20200514-syzkaller #0 Not tainted - drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!! Since rtnl

Re: linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread Madhuparna Bhowmik
On Thu, May 14, 2020 at 08:24:54AM -0400, Qian Cai wrote: > > > > On May 14, 2020, at 7:37 AM, syzbot > > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: c9529331 Add linux-next specific files f

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Marek Vasut
On 5/14/20 4:07 PM, Andrew Lunn wrote: >> All right >> >> btw is jiffies-based timeout OK? Like this: > > If you can, make use of include/linux/iopoll.h I can't, because I need those weird custom accessors, see ks8851_wrreg16_par(), unless I'm missing something there?

Re: [PATCH iproute2/net-next] man: tc-ct.8: Add manual page for ct tc action

2020-05-14 Thread Edward Cree
On 14/05/2020 15:10, Paul Blakey wrote: > Signed-off-by: Paul Blakey > --- > man/man8/tc-ct.8 | 107 > +++ > man/man8/tc-flower.8 | 6 +++ > 2 files changed, 113 insertions(+) > create mode 100644 man/man8/tc-ct.8 Glad to see this, better tc

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 04:14:13PM +0200, Marek Vasut wrote: > On 5/14/20 4:07 PM, Andrew Lunn wrote: > >> All right > >> > >> btw is jiffies-based timeout OK? Like this: > > > > If you can, make use of include/linux/iopoll.h > > I can't, because I need those weird custom accessors, see > ks8851_

Re: is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx

2020-05-14 Thread David Teigland
On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote: > > > And call it directly from dlm instead of going through kernel_setsockopt. > > >

[PATCH 2/4] ipv6: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl

2020-05-14 Thread Christoph Hellwig
To prepare removing the global routing_ioctl hack start lifting the code into a newly added ipv6 ->compat_ioctl handler. Signed-off-by: Christoph Hellwig --- include/net/ipv6.h | 2 ++ net/dccp/ipv6.c | 1 + net/ipv6/af_inet6.c | 53 + net/ipv6/raw.c

[PATCH 4/4] ipv4,appletalk: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl

2020-05-14 Thread Christoph Hellwig
To prepare removing the global routing_ioctl hack start lifting the code into the ipv4 and appletalk ->compat_ioctl handlers. Unlike the existing handler we don't bother copying in the name - there are no compat issues for char arrays. Signed-off-by: Christoph Hellwig --- include/net/compat.h |

move the SIOCDELRT and SIOCADDRT compat_ioctl handlers

2020-05-14 Thread Christoph Hellwig
Hi Dave, this series moves the compat_ioctl handlers into the protocol handlers, avoiding the need to override the address space limited as in the current handler.

[PATCH 3/4] appletalk: factor out a atrtr_ioctl_addrt helper

2020-05-14 Thread Christoph Hellwig
Add a helper than can be shared with the upcoming compat ioctl handler. Signed-off-by: Christoph Hellwig --- net/appletalk/ddp.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index b41375d4d295d..

[PATCH 1/4] ipv6: lift copy_from_user out of ipv6_route_ioctl

2020-05-14 Thread Christoph Hellwig
Prepare for better compat ioctl handling by moving the user copy out of ipv6_route_ioctl. Signed-off-by: Christoph Hellwig --- include/net/ip6_route.h | 3 ++- net/ipv6/af_inet6.c | 16 +-- net/ipv6/route.c| 44 +++-- 3 files changed,

Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

2020-05-14 Thread Marek Vasut
On 5/14/20 4:22 PM, Andrew Lunn wrote: > On Thu, May 14, 2020 at 04:14:13PM +0200, Marek Vasut wrote: >> On 5/14/20 4:07 PM, Andrew Lunn wrote: All right btw is jiffies-based timeout OK? Like this: >>> >>> If you can, make use of include/linux/iopoll.h >> >> I can't, because I need t

Re: [PATCH net-next 0/3] net/sched: act_ct: Add support for specifying tuple offload policy

2020-05-14 Thread Jiri Pirko
Thu, May 14, 2020 at 04:04:02PM CEST, ec...@solarflare.com wrote: >On 14/05/2020 14:48, Paul Blakey wrote: >> To avoid conflicting policies, the policy is applied per zone on the first >> act ct instance for that zone, and must be repeated in all further act ct >> instances of the same zone. >Is th

[PATCH 3/4] ipv4: use symbol_get to access ipip symbols

2020-05-14 Thread Christoph Hellwig
Instead of going through the ioctl handler from kernel space, use symbol_get to access the ip_tunnel_ioctl directly. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/

[PATCH 1/4] ipv4: streamline ipmr_new_tunnel

2020-05-14 Thread Christoph Hellwig
Reduce a few level of indentation to simplify the function. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 73 - 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 9cf83cc85e4ad..84541c60

use symbol_get to create the magic ipv4/ipv6 tunnels

2020-05-14 Thread Christoph Hellwig
Hi Dave, both the ipv4 and ipv6 code have an ioctl each that can be used to create a tunnel using code that doesn't live in the core kernel or ipv6 module. Currently they call ioctls on the tunnel devices to create these, for which the code needs to override the address limit, which is a "feature"

[PATCH 4/4] ipv6: symbol_get to access a sit symbol

2020-05-14 Thread Christoph Hellwig
Instead of going through the ioctl handler from kernel space, use symbol_get to the newly factored out ipip6_set_dstaddr helper, bypassing addrconf.c entirely. Signed-off-by: Christoph Hellwig --- include/net/addrconf.h | 1 - include/net/ipv6.h | 2 ++ net/ipv6/addrconf.c| 66

[PATCH 2/4] ipv4: consolidate the VIFF_TUNNEL handling in ipmr_new_tunnel

2020-05-14 Thread Christoph Hellwig
Also move the dev_set_allmulti call and the error handling into the ioctl helper. This allows reusing already looked up tunnel_dev pointer and the set up argument structure for the deletion in the error handler. Signed-off-by: Christoph Hellwig --- net/ipv4/ipmr.c | 53 -

Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-14 Thread Igor Russkikh
> > So do you mean like the changes below? > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c > b/drivers/net/ethernet/qlogic/qed/qed_debug.c > index f4eebaabb6d0..95cb7da2542e 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c

Re: [RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-14 Thread Alexander Duyck
On Mon, May 11, 2020 at 9:45 PM Punit Agrawal wrote: > > It's an error if the value of the RX/TX tail descriptor does not match > what was written. The error condition is true regardless the duration > of the interference from ME. But the code only performs the reset if > E1000_ICH_FWSM_PCIM2PCI_C

[PATCH net-next] dt-bindings: net: dp83869: Update licensing info

2020-05-14 Thread Dan Murphy
Add BSD 2 Clause to the licensing. CC: Rob Herring Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/net/ti,dp83869.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/ti,dp83869.yaml b/Documentation/devicetree/bindings/n

Re: [PATCH][next] selftest/bpf: fix spelling mistake "SIGALARM" -> "SIGALRM"

2020-05-14 Thread Yonghong Song
On 5/14/20 5:15 AM, Colin King wrote: From: Colin Ian King There is a spelling mistake in an error message, fix it. Signed-off-by: Colin Ian King Acked-by: Yonghong Song

Re: [PATCH net-next 1/4] net: sched: introduce terse dump flag

2020-05-14 Thread kbuild test robot
to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Vlad-Buslov/Implement-filter-terse-dump-mode-support/20200514-194322 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock

2020-05-14 Thread Olivier Dautricourt
The 05/14/2020 06:53, Richard Cochran wrote: > On Thu, May 14, 2020 at 12:28:05PM +0200, Olivier Dautricourt wrote: > > This patch series covers a use case where an embedded system is > > disciplining an internal clock to a GNSS signal, which provides a > > stable frequency, and wants to act as a P

Re: [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE

2020-05-14 Thread Olivier Dautricourt
The 05/14/2020 06:38, Richard Cochran wrote: > On Thu, May 14, 2020 at 12:28:07PM +0200, Olivier Dautricourt wrote: > > This commit allows a user to specify a flag value for configuring > > timestamping through hwtsamp_config structure. > > > > New flags introduced: > > > > HWTSTAMP_FLAGS_NONE = 0

Re: [PATCH net-next 0/4] DSA: promisc on master, generic flow dissector code

2020-05-14 Thread Vladimir Oltean
Hi Florian, On Tue, 12 May 2020 at 03:03, Florian Fainelli wrote: > > > > On 5/11/2020 4:52 PM, Vladimir Oltean wrote: > > On Tue, 12 May 2020 at 02:28, Florian Fainelli wrote: > >> > >> > >> > >> On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > >>> From: Vladimir Oltean > >>> > >>> The initial p

Re: [PATCH net-next 0/3] net/sched: act_ct: Add support for specifying tuple offload policy

2020-05-14 Thread Edward Cree
On 14/05/2020 15:49, Jiri Pirko wrote: > Thu, May 14, 2020 at 04:04:02PM CEST, ec...@solarflare.com wrote: >> Either way, the need to repeat the policy on every tc command suggests >>  that there really ought to instead be a separate API for configuring >>  conntrack offload policy, either per zone

Re: "Forwarding" from TC classifier

2020-05-14 Thread Lorenz Bauer
On Wed, 13 May 2020 at 18:48, David Ahern wrote: > > On 5/13/20 10:40 AM, Lorenz Bauer wrote: > > We've recently open sourced a key component of our L4 load balancer: > > cls_redirect [1]. > > In the commit description, I call out the following caveat: > > > > cls_redirect relies on receiving

Re: "Forwarding" from TC classifier

2020-05-14 Thread Lorenz Bauer
On Wed, 13 May 2020 at 22:23, David Ahern wrote: > > On 5/13/20 10:40 AM, Lorenz Bauer wrote: > > Really, I'd like to get rid of step 1, and instead rely on the network > > stack to switch or route > > the packet for me. The bpf_fib_lookup helper is very close to what I need. > > I've > > hacked

RE: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-14 Thread Christian Herber
Hi Andrew, > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote: >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote: >> ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active. >> >> The TJA1102 is able to detect it if partner link is master. >> > mast

Re: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 03:47:16PM +, Christian Herber wrote: > Hi Andrew, > > > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote: > >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote: > >> ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active. > >>

[PATCH net-next] dt-bindings: dp83867: Convert DP83867 to yaml

2020-05-14 Thread Dan Murphy
Convert the dp83867 binding to yaml. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83867.txt| 68 -- .../devicetree/bindings/net/ti,dp83867.yaml | 127 ++ 2 files changed, 127 insertions(+), 68 deletions(-) delete mode 100644 Documentation/devicet

[PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Daniel Borkmann
Small set of fixes in order to restrict BPF helpers for tracing which are broken on archs with overlapping address ranges as per discussion in [0]. I've targetted this for -bpf tree so they can be routed as fixes. Thanks! [0] https://lore.kernel.org/bpf/CAHk-=wjjko0gvixylmqpn-q22wfu0xhabsjkeo7e

[PATCH bpf 1/3] bpf: restrict bpf_probe_read{,str}() only to archs where they work

2020-05-14 Thread Daniel Borkmann
Given the legacy bpf_probe_read{,str}() BPF helpers are broken on archs with overlapping address ranges, we should really take the next step to disable them from BPF use there. To generally fix the situation, we've recently added new helper variants bpf_probe_read_{user,kernel}() and bpf_probe_rea

[PATCH bpf 3/3] bpf: restrict bpf_trace_printk()'s %s usage and add %psK, %psU specifier

2020-05-14 Thread Daniel Borkmann
Usage of plain %s conversion specifier in bpf_trace_printk() suffers from the very same issue as bpf_probe_read{,str}() helpers, that is, it is broken on archs with overlapping address ranges. While the helpers have been addressed through work in 6ae08ae3dea2 ("bpf: Add probe_read_{user, kernel} a

[PATCH bpf 2/3] bpf: add bpf_probe_read_{user, kernel}_str() to do_refine_retval_range

2020-05-14 Thread Daniel Borkmann
Given bpf_probe_read{,str}() BPF helpers are now only available under CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, we need to add the drop-in replacements of bpf_probe_read_{kernel,user}_str() to do_refine_retval_range() as well to avoid hitting the same issue as in 849fa50662fbc ("bpf/verifier:

Re: [PATCH v3 10/15] net: ethernet: mtk-eth-mac: new driver

2020-05-14 Thread Arnd Bergmann
On Thu, May 14, 2020 at 10:00 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > family. For now we only support full-duplex. > > Signed-off-by: Bartosz Golaszewski Looks very nice overall. Just a few things

RE: [PATCH bpf 2/3] bpf: add bpf_probe_read_{user, kernel}_str() to do_refine_retval_range

2020-05-14 Thread John Fastabend
Daniel Borkmann wrote: > Given bpf_probe_read{,str}() BPF helpers are now only available under > CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, we need to add the drop-in > replacements of bpf_probe_read_{kernel,user}_str() to do_refine_retval_range() > as well to avoid hitting the same issue as in

<    1   2   3   4   5   >