Re: [PATCH rdma-next v1 0/4] Add steering support for default miss

2020-05-13 Thread Leon Romanovsky
On Mon, May 04, 2020 at 08:30:08AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog > v1: > * Rebased on latest rdma-next > * Removed attr_is_valid() check from flags > v0: https://lore.kernel.org/linux-rdma/20200413135220.934007-1-l...@kernel.org > > -

Re: [PATCH] ath9k: release allocated buffer if timed out

2020-05-13 Thread Kalle Valo
Brian Norris writes: > On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost > wrote: >> >> In ath9k_wmi_cmd, the allocated network buffer needs to be released >> if timeout happens. Otherwise memory will be leaked. >> >> Signed-off-by: Navid Emamdoost > > I wonder, did you actually test your patches

general protection fault in cfg80211_dev_rename

2020-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2b6c6f07 bpf, i386: Remove unneeded conversion to bool git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=142a6eec10 kernel config: https://syzkaller.appspot.com/x/.config?x=da7097535df759be dashboard

Re: [PATCH 0/3] Bluetooth: Prevent scanning when device is not configured for wakeup

2020-05-13 Thread Marcel Holtmann
Hi Abhishek, > This patch series adds a hook to prevent Bluetooth from scanning during > suspend if it is not configured to wake up. It's not always clear who > the wakeup owner is from looking at hdev->dev so we need the driver to > inform us whether to set up scanning. > > By default, when no `

Re: net: phylink: supported modes set to 0 with genphy sfp module

2020-05-13 Thread Julien Beraud
On 12/05/2020 14:28, Russell King - ARM Linux admin wrote: On Tue, May 12, 2020 at 11:28:40AM +0200, Julien Beraud wrote: On 11/05/2020 21:06, Florian Fainelli wrote: On 5/11/2020 11:29 AM, Russell King - ARM Linux admin wrote: On Mon, May 11, 2020 at 05:45:02PM +0200, Julien Beraud wro

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-13 Thread Jason Wang
On 2020/5/13 下午12:42, Zhu, Lingshan wrote: On 5/13/2020 12:12 PM, Jason Wang wrote: On 2020/5/12 下午4:00, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requ

Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions

2020-05-13 Thread Дмитрий Якунин
13.05.2020, 05:03, "David Ahern" : > On 5/9/20 10:52 AM, Dmitry Yakunin wrote: >>  This patch prepares infrastructure for matching sockets by cgroups. >>  Two helper functions are added for transformation between cgroup v2 ID >>  and pathname. Cgroup v2 cache is implemented as hash table indexed

[PATCH net 1/2] s390/ism: fix error return code in ism_probe()

2020-05-13 Thread Ursula Braun
From: Wei Yongjun Fix to return negative error code -ENOMEM from the smcd_alloc_dev() error handling case instead of 0, as done elsewhere in this function. Fixes: 684b89bc39ce ("s390/ism: add device driver for internal shared memory") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Signed-o

[PATCH net 0/2] s390/net: updates 2020-05-13

2020-05-13 Thread Ursula Braun
Dave, please apply the fix from Wei Yongjun to netdev's net tree and add Karsten Graul as co-maintainer for drivers/s390/net. Thanks, Ursula Ursula Braun (1): MAINTAINERS: add Karsten Graul as S390 NETWORK DRIVERS maintainer Wei Yongjun (1): s390/ism: fix error return code in ism_probe()

[PATCH net 2/2] MAINTAINERS: add Karsten Graul as S390 NETWORK DRIVERS maintainer

2020-05-13 Thread Ursula Braun
Add Karsten as additional maintainer for drivers/s390/net . One of his focal points is the ism driver. Cc: Julian Wiedmann Acked-by: Julian Wiedmann Signed-off-by: Ursula Braun --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 88bf36ab2b22..858

[PATCH bpf-next] bpf, bpftool: Allow probing for CONFIG_HZ from kernel config

2020-05-13 Thread Daniel Borkmann
In Cilium we've recently switched to make use of bpf_jiffies64() for parts of our tc and XDP datapath since bpf_ktime_get_ns() is more expensive and high-precision is not needed for our timeouts we have anyway. Our agent has a probe manager which picks up the json of bpftool's feature probe and we

Re: [PATCH v1] Bluetooth: L2CAP: add support for waiting disconnection resp

2020-05-13 Thread Marcel Holtmann
Hi Archie, > Whenever we disconnect a L2CAP connection, we would immediately > report a disconnection event (EPOLLHUP) to the upper layer, without > waiting for the response of the other device. > > This patch offers an option to wait until we receive a disconnection > response before reporting d

Re: [PATCH 01/11] dt-bindings: add a binding document for MediaTek PERICFG controller

2020-05-13 Thread Bartosz Golaszewski
śr., 13 maj 2020 o 04:38 Rob Herring napisał(a): > > On Tue, May 05, 2020 at 04:02:21PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds a binding document for the PERICFG controller present on > > MediaTek SoCs. For now the only variant supported is 'mt8516-peric

Désinfectants

2020-05-13 Thread Cecylia Lazar
Bonjour Je contacte au nom du fabricant de savons, liquides et gels pour la désinfection des mains et les produits de nettoyage. Je voudrais vous offrir des produits de désinfection inodores qui nettoient et désinfectent efficacement la peau, éliminant les virus et les bactéries de vos mains.

pull request: bluetooth-next 2020-05-13

2020-05-13 Thread Johan Hedberg
Hi, Here's a second attempt at a bluetooth-next pull request which supercedes the one dated 2020-05-09. This should have the issues discovered by Jakub fixed. - Add support for Intel Typhoon Peak device (8087:0032) - Add device tree bindings for Realtek RTL8723BS device - Add device tree bindi

[PATCH net-net] nfp: flower: inform firmware of flower features in the driver

2020-05-13 Thread Simon Horman
From: Louis Peens For backwards compatibility it may be required for the firmware to disable certain features depending on the features supported by the host. Combine the host feature bits and firmware feature bits and write this back to the firmware. Signed-off-by: Louis Peens Signed-off-by: S

[PATCH net-next] net: phy: realtek: add loopback support for RTL8211F

2020-05-13 Thread Huazhong Tan
From: Yufeng Mo PHY loopback is already supported by genphy driver. This patch adds the set_loopback interface to RTL8211F PHY driver, so the PHY selftest can run properly on it. Signed-off-by: Yufeng Mo Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/phy/realtek.c | 1 +

[PATCH v3] doc: document danger of applying REJECT to INVALID CTs

2020-05-13 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt --- Spello fix near "indiscriminately". extensions/libip6t_REJECT.man | 20 extensions/libipt_REJECT.man | 20 2 files changed, 40 insertions(+) diff --git a/extensions/libip6t_REJECT.man b/extensions/libip6t_REJECT.man i

Re: mmotm 2020-05-11-15-43 uploaded (ethernet/ti/ti_cpsw)

2020-05-13 Thread Grygorii Strashko
On 12/05/2020 05:12, Randy Dunlap wrote: On 5/11/20 3:44 PM, Andrew Morton wrote: The mm-of-the-moment snapshot 2020-05-11-15-43 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a sna

Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-13 Thread Russell King - ARM Linux admin
On Wed, May 13, 2020 at 06:34:05AM +0100, Russell King - ARM Linux admin wrote: > On Tue, May 12, 2020 at 08:48:22PM -0700, Doug Berger wrote: > > On 5/12/2020 11:55 AM, Russell King - ARM Linux admin wrote: > > > On Tue, May 12, 2020 at 11:31:39AM -0700, Doug Berger wrote: > > >> This was intended

Re: [PATCH v3] doc: document danger of applying REJECT to INVALID CTs

2020-05-13 Thread Maciej Żenczykowski
you still missed: succesful -> successful On Wed, May 13, 2020 at 2:17 AM Jan Engelhardt wrote: > > Signed-off-by: Jan Engelhardt > --- > > Spello fix near "indiscriminately". > > extensions/libip6t_REJECT.man | 20 > extensions/libipt_REJECT.man | 20

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Ido Schimmel
On Mon, May 11, 2020 at 01:59:12PM +0200, Christoph Hellwig wrote: > Factor out two helpes to keep the code tidy. > > Signed-off-by: Christoph Hellwig Christoph, After installing net-next (fb9f2e92864f) on a Fedora 32 machine I cannot ssh to it. Bisected it to this commit [1]. When trying to c

Re: [PATCH][next] sfc: fix dereference of table before it is null checked

2020-05-13 Thread Edward Cree
On 12/05/2020 18:13, Colin King wrote: > From: Colin Ian King > > Currently pointer table is being dereferenced on a null check of > table->must_restore_filters before it is being null checked, leading > to a potential null pointer dereference issue. Fix this by null > checking table before deref

[PATCH v4] doc: document danger of applying REJECT to INVALID CTs

2020-05-13 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt --- 4th time is the charm?! extensions/libip6t_REJECT.man | 20 extensions/libipt_REJECT.man | 20 2 files changed, 40 insertions(+) diff --git a/extensions/libip6t_REJECT.man b/extensions/libip6t_REJECT.man index 0030a51

Re: [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause

2020-05-13 Thread Russell King - ARM Linux admin
On Mon, May 11, 2020 at 05:24:09PM -0700, Doug Berger wrote: > This commit introduces the phy_set_pause function to the phylib as > a helper to support the set_pauseparam ethtool method. > > It is hoped that the new behavior introduced by this function will > be widely embraced and the phy_set_sym

[PATCH rdma-next 00/14] RAW format dumps through RDMAtool

2020-05-13 Thread Leon Romanovsky
From: Leon Romanovsky >From Maor: Hi, The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is to enable vendors to return the entire QP/CQ/MR data without a need from the vendor to set each field separately. Thanks Maor Gottlieb (14

Re: [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control

2020-05-13 Thread Russell King - ARM Linux admin
On Mon, May 11, 2020 at 05:24:10PM -0700, Doug Berger wrote: > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c > b/drivers/net/ethernet/broadcom/genet/bcmmii.c > index 511d553a4d11..788da1ecea0c 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > +++ b/drivers/net/ethernet/broa

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Ido Schimmel
On Wed, May 13, 2020 at 11:49:08AM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 12:29:18PM +0300, Ido Schimmel wrote: > > On Mon, May 11, 2020 at 01:59:12PM +0200, Christoph Hellwig wrote: > > > Factor out two helpes to keep the code tidy. > > > > > > Signed-off-by: Christoph Hellwig

[PATCH mlx5-next 02/14] net/mlx5: Add support in query QP, CQ and MKEY segments

2020-05-13 Thread Leon Romanovsky
From: Maor Gottlieb Introduce new resource dump segments - PRM_QUERY_QP, PRM_QUERY_CQ and PRM_QUERY_MKEY. These segments contains the resource dump in PRM query format. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c | 3

[PATCH mlx5-next 01/14] net/mlx5: Export resource dump interface

2020-05-13 Thread Leon Romanovsky
From: Maor Gottlieb Export some of the resource dump API, so it could be used by the mlx5_ib driver as well. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- .../mellanox/mlx5/core/diag/rsc_dump.c| 3 ++ .../mellanox/mlx5/core/diag/rsc_dump.h| 33 +-

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:29:18PM +0300, Ido Schimmel wrote: > On Mon, May 11, 2020 at 01:59:12PM +0200, Christoph Hellwig wrote: > > Factor out two helpes to keep the code tidy. > > > > Signed-off-by: Christoph Hellwig > > Christoph, > > After installing net-next (fb9f2e92864f) on a Fedora 32

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-13 Thread Tang Bin
Hi David: On 2020/5/8 4:18, David Miller wrote: From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() to simplify code, avoid redundant judgements. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Saeed, please pick this up. Doe

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:58:11PM +0300, Ido Schimmel wrote: > On Wed, May 13, 2020 at 11:49:08AM +0200, Christoph Hellwig wrote: > > On Wed, May 13, 2020 at 12:29:18PM +0300, Ido Schimmel wrote: > > > On Mon, May 11, 2020 at 01:59:12PM +0200, Christoph Hellwig wrote: > > > > Factor out two helpes

Re: [PATCH rdma-next 00/14] RAW format dumps through RDMAtool

2020-05-13 Thread Leon Romanovsky
On Wed, May 13, 2020 at 12:50:20PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Maor: > > Hi, > > The following series adds support to get the RDMA resource data in RAW > format. The main motivation for doing this is to enable vendors to return > the entire QP/CQ/MR data without

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:10:37PM +0200, Christoph Hellwig wrote: > Ok. I'll see what went wrong for real and will hopefully have a > different patch for you in a bit. Can you try this patch instead of the previous one? diff --git a/net/core/scm.c b/net/core/scm.c index a75cd637a71ff..875df1c29

Re: bpf: ability to attach freplace to multiple parents

2020-05-13 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Tue, May 12, 2020 at 10:34:58AM +0200, Toke Høiland-Jørgensen wrote: >> Alexei Starovoitov writes: >> >> >> > Currently fentry/fexit/freplace progs have single >> >> > prog->aux->linked_prog pointer. >> >> > It just needs to become a linked list. >> >> > T

Re: [PATCH 2/3] net/scm: cleanup scm_detach_fds

2020-05-13 Thread Ido Schimmel
On Wed, May 13, 2020 at 12:17:51PM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 12:10:37PM +0200, Christoph Hellwig wrote: > > Ok. I'll see what went wrong for real and will hopefully have a > > different patch for you in a bit. > > Can you try this patch instead of the previous one?

[PATCH ipsec] esp6: calculate transport_header correctly when sel.family != AF_INET6

2020-05-13 Thread Xin Long
In esp6_init_state() for beet mode when x->sel.family != AF_INET6: x->props.header_len = sizeof(struct ip_esp_hdr) + crypto_aead_ivsize(aead) + IPV4_BEET_PHMAXLEN + (sizeof(struct ipv6hdr) - sizeof(struct iphdr)) In xfrm6_beet_gso_segment() skb->transport_header is supposed to move to

Re: [PATCH bpf-next] bpf, bpftool: Allow probing for CONFIG_HZ from kernel config

2020-05-13 Thread Quentin Monnet
2020-05-13 09:58 UTC+0200 ~ Daniel Borkmann > In Cilium we've recently switched to make use of bpf_jiffies64() for > parts of our tc and XDP datapath since bpf_ktime_get_ns() is more > expensive and high-precision is not needed for our timeouts we have > anyway. Our agent has a probe manager which

Re: [PATCH v5 bpf-next 00/11] net: Add support for XDP in egress path

2020-05-13 Thread Toke Høiland-Jørgensen
David Ahern writes: > From: David Ahern > > This series adds support for XDP in the egress path by introducing > a new XDP attachment type, BPF_XDP_EGRESS, and adding a UAPI to > if_link.h for attaching the program to a netdevice and reporting > the program. This allows bpf programs to be run on

Re: [PATCH v6 bpf-next 0/3] Introduce CAP_BPF

2020-05-13 Thread Marek Majkowski
On Wed, May 13, 2020 at 4:19 AM Alexei Starovoitov wrote: > > CAP_BPF solves three main goals: > 1. provides isolation to user space processes that drop CAP_SYS_ADMIN and > switch to CAP_BPF. >More on this below. This is the major difference vs v4 set back from Sep > 2019. > 2. makes network

[PATCH] net: ignore sock_from_file errors in __scm_install_fd

2020-05-13 Thread Christoph Hellwig
The code had historically been ignoring these errors, and my recent refactoring changed that, which broke ssh in some setups. Fixes: 2618d530dd8b ("net/scm: cleanup scm_detach_fds") Reported-by: Ido Schimmel Signed-off-by: Christoph Hellwig --- net/core/scm.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH bpf-next] bpf, bpftool: Allow probing for CONFIG_HZ from kernel config

2020-05-13 Thread Daniel Borkmann
On 5/13/20 12:42 PM, Quentin Monnet wrote: 2020-05-13 09:58 UTC+0200 ~ Daniel Borkmann In Cilium we've recently switched to make use of bpf_jiffies64() for parts of our tc and XDP datapath since bpf_ktime_get_ns() is more expensive and high-precision is not needed for our timeouts we have anywa

Re: [PATCH] net: ignore sock_from_file errors in __scm_install_fd

2020-05-13 Thread Ido Schimmel
On Wed, May 13, 2020 at 01:07:59PM +0200, Christoph Hellwig wrote: > The code had historically been ignoring these errors, and my recent > refactoring changed that, which broke ssh in some setups. > > Fixes: 2618d530dd8b ("net/scm: cleanup scm_detach_fds") > Reported-by: Ido Schimmel > Signed-off

Re: [PATCH] Fix suspicious RCU usage warning

2020-05-13 Thread Stephen Rothwell
Hi all, On Wed, 13 May 2020 11:46:10 +0530 madhuparnabhowmi...@gmail.com wrote: > > From: Madhuparna Bhowmik > > This patch fixes the following warning: > > = > WARNING: suspicious RCU usage > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted > ---

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-13 Thread Stephen Rothwell
Hi all, On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik wrote: > > > > I think what is happening is this: > > > > ipmr_net_init() -> ipmr_rules_init() -> ipmr_new_table() > > > > ipmr_new_table() returns an existing table if there is one, but > > obviously none can exist at init. So a

RE: [PATCHv2 10/10] net: eth: altera: update devicetree bindings documentation

2020-05-13 Thread Ooi, Joyce
> -Original Message- > From: Rob Herring > Sent: Wednesday, May 13, 2020 6:53 AM > To: Ooi, Joyce > Cc: Thor Thayer ; David S . Miller > ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Westergreen, Dalon > ; Tan, Ley Foon ; > See, Chin Liang ; Nguyen, Dinh > ; devicet...@vger.k

Re: [RFC PATCH bpf-next 0/1] bpf, x64: optimize JIT prologue/epilogue generation

2020-05-13 Thread Maciej Fijalkowski
On Mon, May 11, 2020 at 05:01:53PM -0700, Alexei Starovoitov wrote: > On Mon, May 11, 2020 at 10:05:25PM +0200, Daniel Borkmann wrote: > > Hey Maciej, Sorry for the delay. Combining two answers in here (Alexei/Daniel). I appreciate your input. > > > > On 5/11/20 4:39 PM, Maciej Fijalkowski wrote

[PATCH v1] net: phy: at803x: add cable test support

2020-05-13 Thread Oleksij Rempel
The cable test seems to be support by all of currently support Atherso PHYs, so add support for all of them. This patch was tested only on AR9331 PHY with following results: - No cable is detected as short - A 15m long cable connected only on one side is detected as 9m open. - A cable test with act

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-13 Thread Murali Karicheri
Hello netdev experts, On 5/6/20 12:30 PM, Murali Karicheri wrote: This RFC series add support for Parallel Redundancy Protocol (PRP) as defined in IEC-62439-3 in the kernel networking subsystem. PRP Uses a Redundancy Control Trailer (RCT) the format of which is similar to HSR Tag. This is used f

[net 1/3] tipc: fix large latency in smart Nagle streaming

2020-05-13 Thread Tuong Lien
Currently when a connection is in Nagle mode, we set the 'ack_required' bit in the last sending buffer and wait for the corresponding ACK prior to pushing more data. However, on the receiving side, the ACK is issued only when application really reads the whole data. Even if part of the last buffer

[net 0/3] tipc: add some patches

2020-05-13 Thread Tuong Lien
This series adds patches to fix some issues in TIPC streaming & service subscription. Tuong Lien (3): tipc: fix large latency in smart Nagle streaming tipc: fix memory leak in service subscripting tipc: fix failed service subscription deletion net/tipc/socket.c | 42 +++

[net 2/3] tipc: fix memory leak in service subscripting

2020-05-13 Thread Tuong Lien
Upon receipt of a service subscription request from user via a topology connection, one 'sub' object will be allocated in kernel, so it will be able to send an event of the service if any to the user correspondingly then. Also, in case of any failure, the connection will be shutdown and all the per

[net 3/3] tipc: fix failed service subscription deletion

2020-05-13 Thread Tuong Lien
When a service subscription is expired or canceled by user, it needs to be deleted from the subscription list, so that new subscriptions can be registered (max = 65535 per net). However, there are two issues in code that can cause such an unused subscription to persist: 1) The 'tipc_conn_delete_su

[PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-13 Thread Oleksij Rempel
Add initial cable testing support. This PHY needs only 100usec for this test and it is recommended to run it before the link is up. For now, provide at least ethtool support, so it can be tested by more developers. This patch was tested with TJA1102 PHY with following results: - No cable, is detec

Re: [PATCH 11/33] tcp: tcp_sock_set_nodelay

2020-05-13 Thread Jason Gunthorpe
On Wed, May 13, 2020 at 08:26:26AM +0200, Christoph Hellwig wrote: > Add a helper to directly set the TCP_NODELAY sockopt from kernel space > without going through a fake uaccess. Cleanup the callers to avoid > pointless wrappers now that this is a simple function call. > > Signed-off-by: Christo

Re: [oss-drivers] [RFC v2] current devlink extension plan for NICs

2020-05-13 Thread Simon Horman
On Fri, May 01, 2020 at 11:14:49AM +0200, Jiri Pirko wrote: > Hi all. > > First, I would like to apologize for very long email. But I think it > would be beneficial to the see the whole picture, where we are going. > > Currently we are working internally on several features with > need of extensi

[PATCH] staging: qlge: Remove unnecessary spaces in qlge_main.c

2020-05-13 Thread Xiangyang Zhang
Fix checkpatch.pl check: CHECK: No space is necessary after a cast Signed-off-by: Xiangyang Zhang --- drivers/staging/qlge/qlge_main.c | 36 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge

RE: [PATCHv2 10/10] net: eth: altera: update devicetree bindings documentation

2020-05-13 Thread Ooi, Joyce
> -Original Message- > From: Ooi, Joyce > Sent: Wednesday, May 13, 2020 8:01 PM > To: Rob Herring > Cc: Thor Thayer ; David S . Miller > ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Westergreen, Dalon ; > Tan, Ley Foon ; See, Chin Liang > ; Nguyen, Dinh ; > devicet...@vger.k

Re: [PATCH v4 3/5] net: macb: fix macb_get/set_wol() when moving to phylink

2020-05-13 Thread Russell King - ARM Linux admin
On Wed, May 06, 2020 at 01:37:39PM +0200, nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre > > Keep previous function goals and integrate phylink actions to them. > > phylink_ethtool_get_wol() is not enough to figure out if Ethernet driver > supports Wake-on-Lan. > Initialization of "sup

Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F

2020-05-13 Thread Andrew Lunn
On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote: > From: Yufeng Mo > > PHY loopback is already supported by genphy driver. This patch > adds the set_loopback interface to RTL8211F PHY driver, so the PHY > selftest can run properly on it. > > Signed-off-by: Yufeng Mo > Signed-off-by

Re: [PATCH 29/33] rxrpc_sock_set_min_security_level

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > +int rxrpc_sock_set_min_security_level(struct sock *sk, unsigned int val); > + Looks good - but you do need to add this to Documentation/networking/rxrpc.txt also, thanks. David

Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David

Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > Add a helper to directly set the IP_RECVERR sockopt from kernel space > without going through a fake uaccess. It looks like if this is an AF_INET6 socket, it will just pass the message straight through to AF_INET4, so: Reviewed-by: David Howells

Re: [PATCH 23/33] ipv6: add ip6_sock_set_recverr

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > Add a helper to directly set the IPV6_RECVERR sockopt from kernel space > without going through a fake uaccess. > > Signed-off-by: Christoph Hellwig Reviewed-by: David Howells

[PATCH net-next 1/2] ethernet: ti: am65-cpts: add routines to support taprio offload

2020-05-13 Thread Murali Karicheri
From: Ivan Khoronzhuk TAPRIO/EST offload support in CPSW2G requires EST scheduler function enabled in CPTS. So this patch add a function to set cycle time for EST scheduler. It also add a function for getting time in ns of PHC clock for taprio qdisc configuration. Mostly to verify if timer updat

[PATCH net-next 0/2] am65-cpsw: add taprio/EST offload support

2020-05-13 Thread Murali Karicheri
AM65 CPSW h/w supports Enhanced Scheduled Traffic (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018) configuration. EST allows express queue traffic to be scheduled (placed) on the wire at specific repeatable time intervals. In Linux kernel, EST configuration is done thro

[PATCH net-next 2/2] ethernet: ti: am65-cpsw-qos: add TAPRIO offload support

2020-05-13 Thread Murali Karicheri
From: Ivan Khoronzhuk AM65 CPSW h/w supports Enhanced Scheduled Traffic (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018) configuration. EST allows express queue traffic to be scheduled (placed) on the wire at specific repeatable time intervals. In Linux kernel, EST co

Re: [PATCH 06/33] net: add sock_set_timestamps

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > Add a helper to directly set the SO_TIMESTAMP* sockopts from kernel space > without going through a fake uaccess. > > Signed-off-by: Christoph Hellwig Reviewed-by: David Howells

Re: [PATCH v1] net: phy: at803x: add cable test support

2020-05-13 Thread Andrew Lunn
On Wed, May 13, 2020 at 02:06:48PM +0200, Oleksij Rempel wrote: > The cable test seems to be support by all of currently support Atherso > PHYs, so add support for all of them. This patch was tested only on > AR9331 PHY with following results: > - No cable is detected as short > - A 15m long cable

RE: [PATCH] net: ignore sock_from_file errors in __scm_install_fd

2020-05-13 Thread Ioana Ciornei
> Subject: [PATCH] net: ignore sock_from_file errors in __scm_install_fd > > The code had historically been ignoring these errors, and my recent > refactoring > changed that, which broke ssh in some setups. > > Fixes: 2618d530dd8b ("net/scm: cleanup scm_detach_fds") > Reported-by: Ido Schimmel

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-13 Thread Andrew Lunn
On Wed, May 13, 2020 at 02:34:40PM +0200, Oleksij Rempel wrote: > Add initial cable testing support. > This PHY needs only 100usec for this test and it is recommended to run it > before the link is up. For now, provide at least ethtool support, so it > can be tested by more developers. > > This pa

Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-13 Thread Andrew Lunn
> So, I think consistency of implementation is more important than fixing > this; the current behaviour has been established for many years now. Hi Russell, Doug With netlink ethtool we have the possibility of adding a new API to control this. And we can leave the IOCTL API alone, and the current

Re: [PATCH v1] net: phy: at803x: add cable test support

2020-05-13 Thread Russell King - ARM Linux admin
On Wed, May 13, 2020 at 03:32:09PM +0200, Andrew Lunn wrote: > On Wed, May 13, 2020 at 02:06:48PM +0200, Oleksij Rempel wrote: > > The cable test seems to be support by all of currently support Atherso > > PHYs, so add support for all of them. This patch was tested only on > > AR9331 PHY with follo

Re: [PATCH bpf-next v2 05/17] inet: Run SK_LOOKUP BPF program on socket lookup

2020-05-13 Thread Jakub Sitnicki
On Wed, May 13, 2020 at 01:58 AM CEST, Alexei Starovoitov wrote: > On Tue, May 12, 2020 at 03:52:52PM +0200, Jakub Sitnicki wrote: >> On Mon, May 11, 2020 at 10:44 PM CEST, Alexei Starovoitov wrote: >> > On Mon, May 11, 2020 at 08:52:06PM +0200, Jakub Sitnicki wrote: >> >> Run a BPF program before

[PATCH RESEND net-next] dpaa2-eth: add bulking to XDP_TX

2020-05-13 Thread Ioana Ciornei
Add driver level bulking to the XDP_TX action. An array of frame descriptors is held for each Tx frame queue and populated accordingly when the action returned by the XDP program is XDP_TX. The frames will be actually enqueued only when the array is filled. At the end of the NAPI cycle a flush on

[PATCH net-next] netns: enable to inherit devconf from current netns

2020-05-13 Thread Nicolas Dichtel
The goal is to be able to inherit the initial devconf parameters from the current netns, ie the netns where this new netns has been created. This is useful in a containers environment where /proc/sys is read only. For example, if a pod is created with specifics devconf parameters and has the capab

[PATCH] dt-bindings: net: dsa: b53: Add missing size and address cells to example

2020-05-13 Thread Kurt Kanzenbach
Add the missing size and address cells to the b53 example. Otherwise, it may not compile or issue warnings if directly copied into a device tree. Signed-off-by: Kurt Kanzenbach --- Documentation/devicetree/bindings/net/dsa/b53.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentat

Re: [PATCH v4 3/5] net: macb: fix macb_get/set_wol() when moving to phylink

2020-05-13 Thread Nicolas Ferre
Russell, Thanks for the feedback. On 13/05/2020 at 15:05, Russell King - ARM Linux admin wrote: On Wed, May 06, 2020 at 01:37:39PM +0200, nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Keep previous function goals and integrate phylink actions to them. phylink_ethtool_get_wol() is n

Re: [PATCH bpf-next v2 05/17] inet: Run SK_LOOKUP BPF program on socket lookup

2020-05-13 Thread Lorenz Bauer
On Tue, 12 May 2020 at 14:52, Jakub Sitnicki wrote: > > On Mon, May 11, 2020 at 10:44 PM CEST, Alexei Starovoitov wrote: > > On Mon, May 11, 2020 at 08:52:06PM +0200, Jakub Sitnicki wrote: > >> Run a BPF program before looking up a listening socket on the receive path. > >> Program selects a liste

Re: [PATCH bpf-next v2 02/17] bpf: Introduce SK_LOOKUP program type with a dedicated attach point

2020-05-13 Thread Jakub Sitnicki
On Wed, May 13, 2020 at 07:41 AM CEST, Martin KaFai Lau wrote: > On Mon, May 11, 2020 at 08:52:03PM +0200, Jakub Sitnicki wrote: > > [ ... ] > >> +BPF_CALL_3(bpf_sk_lookup_assign, struct bpf_sk_lookup_kern *, ctx, >> + struct sock *, sk, u64, flags) > The SK_LOOKUP bpf_prog may have already s

Re: [PATCH bpf-next v2 05/17] inet: Run SK_LOOKUP BPF program on socket lookup

2020-05-13 Thread Jakub Sitnicki
On Wed, May 13, 2020 at 04:21 PM CEST, Lorenz Bauer wrote: > On Tue, 12 May 2020 at 14:52, Jakub Sitnicki wrote: [...] >> So if IIUC the rough idea here would be like below? >> >> - 1st program calls >> >> bpf_sk_assign(ctx, sk1, 0 /*flags*/) -> 0 (OK) >> >> - 2nd program calls >> >> bpf_sk_

[PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC assocs. These events are described in rfc6458#section-6.1 SCTP_PEER_ADDR_CHANGE: This tag indicates that an address that is part of an existing association has experienced a change of state (e.g., a failure or return to servi

Re: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes

2020-05-13 Thread Murali Karicheri
Hi Vinicius, On 3/18/20 10:07 AM, Murali Karicheri wrote: Hi Vinicius, On 03/12/2020 07:34 PM, Vinicius Costa Gomes wrote: Hi, Po Liu writes: Hi Vinicius, Br, Po Liu -Original Message- From: Vinicius Costa Gomes Sent: 2020年2月22日 5:44 To: Po Liu ; da...@davemloft.net; hauke.meh

Re: [PATCH bpf-next v4] libbpf: fix probe code to return EPERM if encountered

2020-05-13 Thread Daniel Borkmann
On 5/12/20 11:04 AM, Eelco Chaudron wrote: When the probe code was failing for any reason ENOTSUP was returned, even if this was due to no having enough lock space. This patch fixes this by returning EPERM to the user application, so it can respond and increase the RLIMIT_MEMLOCK size. Signed-of

Re: [PATCH] dt-bindings: net: dsa: b53: Add missing size and address cells to example

2020-05-13 Thread Florian Fainelli
On 5/13/2020 7:02 AM, Kurt Kanzenbach wrote: > Add the missing size and address cells to the b53 example. Otherwise, it may > not > compile or issue warnings if directly copied into a device tree. > > Signed-off-by: Kurt Kanzenbach Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

2020-05-13 Thread Michal Kubecek
On Wed, May 13, 2020 at 03:49:25PM +0200, Andrew Lunn wrote: > > So, I think consistency of implementation is more important than fixing > > this; the current behaviour has been established for many years now. > > With netlink ethtool we have the possibility of adding a new API to > control this.

[PATCH REPOST] net: dsa: mt7530: fix roaming from DSA user ports

2020-05-13 Thread DENG Qingfang
When a client moves from a DSA user port to a software port in a bridge, it cannot reach any other clients that connected to the DSA user ports. That is because SA learning on the CPU port is disabled, so the switch ignores the client's frames from the CPU port and still thinks it is at the user po

Re: mmotm 2020-05-11-15-43 uploaded (ethernet/ti/ti_cpsw)

2020-05-13 Thread Randy Dunlap
On 5/13/20 2:20 AM, Grygorii Strashko wrote: > > > On 12/05/2020 05:12, Randy Dunlap wrote: >> On 5/11/20 3:44 PM, Andrew Morton wrote: >>> The mm-of-the-moment snapshot 2020-05-11-15-43 has been uploaded to >>> >>>     http://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> READ

netfilter: does the API break or something else ?

2020-05-13 Thread Xiubo Li
Hi Experts, Recently I hit one netfilter issue, it seems the API breaks or something else. On CentOS8.1 with the recent upstream kernel built from source, such as 5.6.0-rc6/5.7.0-rc4. When running the following command: $ sudo bash -c 'iptables -A FORWARD -o enp3s0f1 -i ceph-brx -j ACCEPT' i

Re: [PATCH v1] net: phy: at803x: add cable test support

2020-05-13 Thread Florian Fainelli
On 5/13/2020 5:06 AM, Oleksij Rempel wrote: > The cable test seems to be support by all of currently support Atherso > PHYs, so add support for all of them. This patch was tested only on > AR9331 PHY with following results: > - No cable is detected as short > - A 15m long cable connected only on

KMSAN: uninit-value in hash_ip6_test

2020-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:14bcee29 DO-NOT-SUBMIT: kmsan: block: nullb: handle read r.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=14f266a410 kernel config: https://syzkaller.appspot.co

KMSAN: kernel-infoleak in _copy_to_iter (5)

2020-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:14bcee29 DO-NOT-SUBMIT: kmsan: block: nullb: handle read r.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1752af7c10 kernel config: https://syzkaller.appspot.co

Re: [PATCH bpf-next 1/3] samples: bpf: refactor kprobe tracing user progs with libbpf

2020-05-13 Thread Yonghong Song
On 5/12/20 11:51 PM, Daniel T. Lee wrote: On Wed, May 13, 2020 at 10:40 AM Yonghong Song wrote: On 5/12/20 7:43 AM, Daniel T. Lee wrote: Currently, the kprobe BPF program attachment method for bpf_load is quite old. The implementation of bpf_load "directly" controls and manages(create, d

[PATCH net-next 0/3] mptcp: fix MP_JOIN failure handling

2020-05-13 Thread Paolo Abeni
Currently if we hit an MP_JOIN failure on the third ack, the child socket is closed with reset, but the request socket is not deleted, causing weird behaviors. The main problem is that MPTCP's MP_JOIN code needs to plug it's own 'valid 3rd ack' checks and the current TCP callbacks do not allow tha

[PATCH net-next 2/3] inet_connection_sock: factor out destroy helper.

2020-05-13 Thread Paolo Abeni
Move the steps to prepare an inet_connection_sock for forced disposal inside a separate helper. No functional changes inteded, this will just simplify the next patch. Signed-off-by: Paolo Abeni --- include/net/inet_connection_sock.h | 8 net/ipv4/inet_connection_sock.c| 6 +- 2

[PATCH net-next 3/3] mptcp: cope better with MP_JOIN failure

2020-05-13 Thread Paolo Abeni
Currently, on MP_JOIN failure we reset the child socket, but leave the request socket untouched. tcp_check_req will deal with it according to the 'tcp_abort_on_overflow' sysctl value - by default the req socket will stay alive. The above leads to inconsistent behavior on MP JOIN failure, and bad

[PATCH net-next 1/3] mptcp: add new sock flag to deal with join subflows

2020-05-13 Thread Paolo Abeni
MP_JOIN subflows must not land into the accept queue. Currently tcp_check_req() calls an mptcp specific helper to detect such scenario. Such helper leverages the subflow context to check for MP_JOIN subflows. We need to deal also with MP JOIN failures, even when the subflow context is not availabl

[PATCH net-next] net: dsa: mt7530: set CPU port to fallback mode

2020-05-13 Thread DENG Qingfang
Currently, setting a bridge's self PVID to other value and deleting the default VID 1 renders untagged ports of that VLAN unable to talk to the CPU port: bridge vlan add dev br0 vid 2 pvid untagged self bridge vlan del dev br0 vid 1 self bridge vlan add dev sw0p0 vid 2 pvid

Re: [PATCH 3/3] net: cleanly handle kernel vs user buffers for ->msg_control

2020-05-13 Thread Eric Dumazet
On 5/11/20 4:59 AM, Christoph Hellwig wrote: > The msg_control field in struct msghdr can either contain a user > pointer when used with the recvmsg system call, or a kernel pointer > when used with sendmsg. To complicate things further kernel_recvmsg > can stuff a kernel pointer in and then us

  1   2   3   4   >