Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-07 Thread Andrew Lunn
On Thu, May 07, 2020 at 12:50:15PM +0200, Bartosz Golaszewski wrote: > czw., 7 maj 2020 o 11:46 Mark-MC.Lee napisał(a): > > > > Hi Bartosz: > > I think the naming of this driver and its Kconfig option is too generic > > that will confuse with current mediatek SoCs eth driver architecture(for > >

Re: [PATCH] via-rhine: Add platform dependencies

2020-05-07 Thread Arnd Bergmann
On Thu, May 7, 2020 at 1:42 PM Geert Uytterhoeven wrote: > > The VIA Rhine Ethernet interface is only present on PCI devices or > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > VIA_RHINE config symbol, to avoid asking the user about it when > configuring a kernel without P

[PATCH net-next] net: sfp: add some quirks for FreeTel direct attach modules

2020-05-07 Thread Marek Behún
FreeTel P.C30.2 and P.C30.3 may fail to report anything useful from their EEPROM. They report correct nominal bitrate of 10300 MBd, but do not report sfp_ct_passive nor sfp_ct_active in their ERPROM. These modules can also operate at 1000baseX and 2500baseX. Signed-off-by: Marek Behún Cc: Russel

pull-request: wireless-drivers-next-2020-05-07

2020-05-07 Thread Kalle Valo
Hi, here's a pull request to net-next tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the git repository at: git://git.kernel.

[PATCH -next] cxgb4: remove duplicate headers

2020-05-07 Thread Chen Zhou
Remove duplicate headers which are included twice. Signed-off-by: Chen Zhou --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h index e46a14f44a6f..30d25a37fc3

Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

2020-05-07 Thread Jeremy Linton
Hi, On 5/5/20 8:29 AM, Calvin Johnson wrote: Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/phy/phy_device.c | 21

[PATCH -next] net: ipa: remove duplicate headers

2020-05-07 Thread Chen Zhou
Remove duplicate headers which are included twice. Signed-off-by: Chen Zhou --- drivers/net/ipa/ipa_mem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index aa8f6b0f3d50..3ef814119aab 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread Leon Romanovsky
On Thu, May 07, 2020 at 07:50:10PM +0800, Tang Bin wrote: > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 5 ++--- >

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > Before I start hacking on this, I might as well check with the XDP > folks if this considered a crappy idea or not. :-) > > The XDP redirect flow for a packet is typical a dance of > bpf_redirect_map() that updates the bpf_redirect_info structure with > maps type/items, whic

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Jiri Olsa
On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread Björn Töpel
On Thu, 7 May 2020 at 15:44, Toke Høiland-Jørgensen wrote: > > Björn Töpel writes: > > > Before I start hacking on this, I might as well check with the XDP > > folks if this considered a crappy idea or not. :-) > > > > The XDP redirect flow for a packet is typical a dance of > > bpf_redirect_map(

RE: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

2020-05-07 Thread Saleem, Shiraz
> Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA > > On Wed, May 06, 2020 at 02:04:58PM -0700, Jeff Kirsher wrote: > > From: Dave Ertman > > > > The RDMA block does not have its own PCI function, instead it must > > utilize the ice driver to gain access to the PCI de

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-07 Thread Josh Poimboeuf
On Wed, May 06, 2020 at 05:03:57PM -0700, Alexei Starovoitov wrote: > > > > > diff --git a/include/linux/compiler-gcc.h > > > > > b/include/linux/compiler-gcc.h > > > > > index d7ee4c6bad48..05104c3cc033 100644 > > > > > --- a/include/linux/compiler-gcc.h > > > > > +++ b/include/linux/compiler-gcc

Re: [PATCH] net: remove spurious declaration of tcp_default_init_rwnd()

2020-05-07 Thread Eric Dumazet
On 5/7/20 12:58 AM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > it doesn't actually exist... > > Test: builds and 'git grep tcp_default_init_rwnd' comes up empty > Signed-off-by: Maciej Żenczykowski > --- > include/net/tcp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --

[PATCH] e1000e: Disable TSO for buffer overrun workaround

2020-05-07 Thread Kai-Heng Feng
Commit b10effb92e27 ("e1000e: fix buffer overrun while the I219 is processing DMA transactions") imposes roughly 30% performance penalty. The commit log states that "Disabling TSO eliminates performance loss for TCP traffic without a noticeable impact on CPU performance", so let's disable TSO by d

Re: [PATCH V4 07/19] net: ks8851: Remove ks8851_rdreg32()

2020-05-07 Thread Marek Vasut
On 4/20/20 5:50 PM, Andrew Lunn wrote: > On Mon, Apr 20, 2020 at 05:38:16PM +0200, Marek Vasut wrote: >> On 4/20/20 4:44 PM, Lukas Wunner wrote: >>> On Mon, Apr 20, 2020 at 04:24:05PM +0200, Marek Vasut wrote: On 4/20/20 4:20 PM, Lukas Wunner wrote: > On Mon, Apr 20, 2020 at 04:12:59PM +02

[PATCH net-next] net/smc: remove set but not used variables 'del_llc, del_llc_resp'

2020-05-07 Thread Karsten Graul
From: YueHaibing Fixes gcc '-Wunused-but-set-variable' warning: net/smc/smc_llc.c: In function 'smc_llc_cli_conf_link': net/smc/smc_llc.c:753:31: warning: variable 'del_llc' set but not used [-Wunused-but-set-variable] struct smc_llc_msg_del_link *del_llc; ^ net

[PATCH AUTOSEL 5.4 26/35] SUNRPC: defer slow parts of rpc_free_client() to a workqueue.

2020-05-07 Thread Sasha Levin
From: NeilBrown [ Upstream commit 7c4310ff56422ea43418305d22bbc5fe19150ec4 ] The rpciod workqueue is on the write-out path for freeing dirty memory, so it is important that it never block waiting for memory to be allocated - this can lead to a deadlock. rpc_execute() - which is often called by

[PATCH][next] net: phy: fix less than zero comparison with unsigned variable val

2020-05-07 Thread Colin King
From: Colin Ian King The unsigned variable val is being checked for an error by checking if it is less than zero. This can never occur because val is unsigned. Fix this by making val a plain int. Addresses-Coverity: ("Unsigned compared against zero") Fixes: bdbdac7649fa ("ethtool: provide UAPI f

[PATCH AUTOSEL 5.6 34/50] SUNRPC: defer slow parts of rpc_free_client() to a workqueue.

2020-05-07 Thread Sasha Levin
From: NeilBrown [ Upstream commit 7c4310ff56422ea43418305d22bbc5fe19150ec4 ] The rpciod workqueue is on the write-out path for freeing dirty memory, so it is important that it never block waiting for memory to be allocated - this can lead to a deadlock. rpc_execute() - which is often called by

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On Thu, 7 May 2020 at 15:44, Toke Høiland-Jørgensen wrote: >> >> Björn Töpel writes: >> >> > Before I start hacking on this, I might as well check with the XDP >> > folks if this considered a crappy idea or not. :-) >> > >> > The XDP redirect flow for a packet is typical a

Re: [PATCH v2] virtio_net: fix lockdep warning on 32 bit

2020-05-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 7 May 2020 03:25:56 -0400 > When we fill up a receive VQ, try_fill_recv currently tries to count > kicks using a 64 bit stats counter. Turns out, on a 32 bit kernel that > uses a seqcount. sequence counts are "lock" constructs where you need to > make sure th

[RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Edward Cree
Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that drivers and __flow_action_hw_stats_check can use simple bitwise checks. In mlxsw we check for DISABLED first, because we'd rather save the counter resources in the DONT_CARE case. Signed-off-by: Edward Cree --- Compile

Re: [PATCH] net: remove spurious declaration of tcp_default_init_rwnd()

2020-05-07 Thread David Miller
From: Maciej Żenczykowski Date: Thu, 7 May 2020 00:58:05 -0700 > From: Maciej Żenczykowski > > it doesn't actually exist... > > Test: builds and 'git grep tcp_default_init_rwnd' comes up empty > Signed-off-by: Maciej Żenczykowski Applied, thank you.

Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

2020-05-07 Thread Greg KH
On Thu, May 07, 2020 at 02:04:04PM +, Saleem, Shiraz wrote: > > Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA > > > > On Wed, May 06, 2020 at 02:04:58PM -0700, Jeff Kirsher wrote: > > > From: Dave Ertman > > > > > > The RDMA block does not have its own PCI funct

[PATCH] wil6210: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH v2] ARM: dts: am437x: fix networking on boards with ksz9031 phy

2020-05-07 Thread Grygorii Strashko
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on boards: am437x-gp-evm am437x-sk-evm am437x-idk-evm All above boards have phy-mode = "rgmii" and this is worked before, because KSZ9031 PHY started with default RGMII internal del

[PATCH] net: microchip: encx24j600: add missed kthread_stop

2020-05-07 Thread Chuhong Yuan
This driver calls kthread_run() in probe, but forgets to call kthread_stop() in probe failure and remove. Add the missed kthread_stop() to fix it. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/microchip/encx24j600.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/d

Re: [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy

2020-05-07 Thread Grygorii Strashko
On 07/05/2020 07:40, Oleksij Rempel wrote: Hi Grygorii, thank you for you patches! On Wed, May 06, 2020 at 10:08:35PM +0300, Grygorii Strashko wrote: Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on boards: am437x-gp-evm

[PATCH] wcn36xx: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH] carl9170: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

Re: [PATCH v2] ARM: dts: am437x: fix networking on boards with ksz9031 phy

2020-05-07 Thread Philippe Schenker
On Thu, 2020-05-07 at 18:12 +0300, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for > the > KSZ9031 PHY") the networking is broken on boards: > am437x-gp-evm > am437x-sk-evm > am437x-idk-evm > > All above boards have phy-mode = "rgmii" and this i

Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

2020-05-07 Thread Edward Cree
On 07/05/2020 16:06, Greg KH wrote: > I can't accept that this series is using a virtual bus properly without > actually using the virtual bus driver code, can you? I might be misunderstanding, but I *think* a hardware driver likeice is  the 'provider' of a virtbus, and it's only 'consumers' of it

Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Pablo Neira Ayuso
On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: > Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that > drivers and __flow_action_hw_stats_check can use simple bitwise checks. You have have to explain why this makes sense in terms of semantics. _DISABLED and _

Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Pablo Neira Ayuso
On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: [...] > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c > index 890b078851c9..1f0caeae24e1 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static

2020-05-07 Thread Florian Fainelli
On 5/7/2020 1:03 AM, Zheng Zengkai wrote: > Fix sparse warnings: > > drivers/net/phy/mdio-bcm-iproc.c:182:5: warning: > symbol 'iproc_mdio_resume' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai Acked-by: Florian Fainelli -- Florian

Re: [RFC PATCH 1/3] x86/kprobes: Support nested kprobes

2020-05-07 Thread Masami Hiramatsu
On Thu, 7 May 2020 18:59:55 +0900 Masami Hiramatsu wrote: > Make kprobes to accept 1-level nesting instead of > diff --git a/arch/x86/kernel/kprobes/ftrace.c > b/arch/x86/kernel/kprobes/ftrace.c > index 681a4b36e9bb..b695c2e118f8 100644 > --- a/arch/x86/kernel/kprobes/ftrace.c > +++ b/arch/x86/

Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Edward Cree
On 07/05/2020 16:32, Pablo Neira Ayuso wrote: > On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: >> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that >> drivers and __flow_action_hw_stats_check can use simple bitwise checks. > > You have have to explain why th

Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

2020-05-07 Thread Florian Fainelli
On 5/7/2020 3:03 AM, Marek Szyprowski wrote: > Hi > > On 07.05.2020 11:46, Marek Szyprowski wrote: >> On 25.02.2020 14:11, Nicolas Saenz Julienne wrote: >>> Outdated Raspberry Pi 4 firmware might configure the external PHY as >>> rgmii although the kernel currently sets it as rgmii-rxid. This m

Re: [PATCH v3] net: bpf: permit redirect from ingress L3 to egress L2 devices at near max mtu

2020-05-07 Thread Daniel Borkmann
On 5/7/20 4:36 AM, Maciej Żenczykowski wrote: From: Maciej Żenczykowski __bpf_skb_max_len(skb) is used from: bpf_skb_adjust_room __bpf_skb_change_tail __bpf_skb_change_head but in the case of forwarding we're likely calling these functions during receive processing on ingress and bpf_

Re: [PATCH bpf-next v3 1/5] selftests/bpf: generalize helpers to control background listener

2020-05-07 Thread Jakub Sitnicki
On Wed, 6 May 2020 23:09:21 -0700 Martin KaFai Lau wrote: > On Wed, May 06, 2020 at 03:32:06PM -0700, Stanislav Fomichev wrote: > > Move the following routines that let us start a background listener > > thread and connect to a server by fd to the test_prog: > > * start_server_thread - start back

Re: [PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-07 Thread Daniel Borkmann
On 5/7/20 12:04 AM, Martin KaFai Lau wrote: On Wed, May 06, 2020 at 10:03:52PM +0800, Jason Yan wrote: The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: Make sense. It may belong to bpf-next instead. Acked-by: Martin KaFai La

Re: [PATCH v3 net-next 0/4] Cross-chip bridging for disjoint DSA trees

2020-05-07 Thread Vladimir Oltean
Hi David, On Mon, 4 May 2020 at 01:12, Vladimir Oltean wrote: > > From: Vladimir Oltean > > This series adds support for boards where DSA switches of multiple types > are cascaded together. Actually this type of setup was brought up before > on netdev, and it looks like utilizing disjoint trees

Re: [PATCH bpf-next v3 3/5] selftests/bpf: move existing common networking parts into network_helpers

2020-05-07 Thread Andrii Nakryiko
On Thu, May 7, 2020 at 9:14 AM wrote: > > On 05/06, Martin KaFai Lau wrote: > > On Wed, May 06, 2020 at 03:32:08PM -0700, Stanislav Fomichev wrote: > > > 1. Move pkt_v4 and pkt_v6 into network_helpers and adjust the users. > > > 2. Copy-paste spin_lock_thread into two tests that use it. > > Instea

Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

2020-05-07 Thread Greg KH
On Thu, May 07, 2020 at 04:24:32PM +0100, Edward Cree wrote: > On 07/05/2020 16:06, Greg KH wrote: > > I can't accept that this series is using a virtual bus properly without > > actually using the virtual bus driver code, can you? > I might be misunderstanding, but I *think* a hardware driver like

[PATCH][next] ath11k: remove redundant initialization of pointer info

2020-05-07 Thread Colin King
From: Colin Ian King Pointer info is being assigned twice, once at the start of the function and secondly when it is just about to be accessed. Remove the redundant initialization and keep the original assignment to info that is close to the memcpy that uses it. Addresses-Coverity: ("Unused valu

Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Pablo Neira Ayuso
On Thu, May 07, 2020 at 04:49:15PM +0100, Edward Cree wrote: > On 07/05/2020 16:32, Pablo Neira Ayuso wrote: > > On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: > >> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that > >> drivers and __flow_action_hw_stats_chec

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 11:25:01 +0200 Bartosz Golaszewski wrote: > śr., 6 maj 2020 o 19:12 Jakub Kicinski napisał(a): > > > > On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > > > wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > > > > > > > On Tue, 5 May 2020 16:02:25 +0200 Ba

[PATCH net] mptcp: set correct vfs info for subflows

2020-05-07 Thread Paolo Abeni
When a subflow is created via mptcp_subflow_create_socket(), a new 'struct socket' is allocated, with a new i_ino value. When inspecting TCP sockets via the procfs and or the diag interface, the above ones are not related to the process owning the MPTCP master socket, even if they are a logical pa

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-07 Thread Bartosz Golaszewski
czw., 7 maj 2020 o 15:16 Andrew Lunn napisał(a): > > On Thu, May 07, 2020 at 12:50:15PM +0200, Bartosz Golaszewski wrote: > > czw., 7 maj 2020 o 11:46 Mark-MC.Lee napisał(a): > > > > > > Hi Bartosz: > > > I think the naming of this driver and its Kconfig option is too generic > > > that will con

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Bartosz Golaszewski
czw., 7 maj 2020 o 18:53 Jakub Kicinski napisał(a): > > On Thu, 7 May 2020 11:25:01 +0200 Bartosz Golaszewski wrote: > > śr., 6 maj 2020 o 19:12 Jakub Kicinski napisał(a): > > > > > > On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > > > > wt., 5 maj 2020 o 19:31 Jakub Kicinski napi

Re: [PATCH net-next] net: relax SO_TXTIME CAP_NET_ADMIN check

2020-05-07 Thread Willem de Bruijn
On Thu, May 7, 2020 at 1:05 PM Eric Dumazet wrote: > > Now sch_fq has horizon feature, we want to allow QUIC/UDP applications > to use EDT model so that pacing can be offloaded to the kernel (sch_fq) > or the NIC. > > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn Acked-by: Willem de Bruijn

Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

2020-05-07 Thread Andy Shevchenko
On Thu, May 7, 2020 at 4:26 PM Jeremy Linton wrote: > On 5/5/20 8:29 AM, Calvin Johnson wrote: > > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", > > +&upper, &lower) == 2) { > > + *phy_id = ((upper & 0x) << 16) | (lower & 0x); > > +

Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

2020-05-07 Thread Markus Elfring
… > +++ b/drivers/net/wireless/ath/wcn36xx/main.c … > @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev) > out_unmap: > iounmap(wcn->ccu_base); > iounmap(wcn->dxe_base); > +out_channel: > + rpmsg_destroy_ept(wcn->smd_channel); > out_wq: > ieee80211_

Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

2020-05-07 Thread Kalle Valo
Markus Elfring writes: > … >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c > … >> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev) >> out_unmap: >> iounmap(wcn->ccu_base); >> iounmap(wcn->dxe_base); >> +out_channel: >> +rpmsg_destroy_ept(wcn->smd_channe

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Andi Kleen
On Thu, May 07, 2020 at 01:14:29AM -0700, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics

Re: [PATCH next] ARM: dts: am57xx: fix networking on boards with ksz9031 phy

2020-05-07 Thread Tony Lindgren
* Philippe Schenker [200507 08:43]: > On Wed, 2020-05-06 at 22:11 +0300, Grygorii Strashko wrote: > > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for > > the > > KSZ9031 PHY") the networking is broken on boards: > > am571x-idk > > am572x-idk > > am574x-idk > > am57xx-bea

Re: [PATCH v2] ARM: dts: am437x: fix networking on boards with ksz9031 phy

2020-05-07 Thread Tony Lindgren
* Philippe Schenker [200507 15:17]: > On Thu, 2020-05-07 at 18:12 +0300, Grygorii Strashko wrote: > > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for > > the > > KSZ9031 PHY") the networking is broken on boards: > > am437x-gp-evm > > am437x-sk-evm > > am437x-idk-evm > >

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread John Fastabend
Toke Høiland-Jørgensen wrote: > Björn Töpel writes: > > > On Thu, 7 May 2020 at 15:44, Toke Høiland-Jørgensen wrote: > >> > >> Björn Töpel writes: > >> > >> > Before I start hacking on this, I might as well check with the XDP > >> > folks if this considered a crappy idea or not. :-) > >> > > >>

Re: [PATCH net-next] net: relax SO_TXTIME CAP_NET_ADMIN check

2020-05-07 Thread Vinicius Costa Gomes
Hi, Eric Dumazet writes: > Now sch_fq has horizon feature, we want to allow QUIC/UDP applications > to use EDT model so that pacing can be offloaded to the kernel (sch_fq) > or the NIC. > > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn > --- > net/core/sock.c | 28 ++-

Re: [bpf-next PATCH 03/10] bpf: selftests, sockmap test prog run without setting cgroup

2020-05-07 Thread John Fastabend
Jakub Sitnicki wrote: > On Tue, 05 May 2020 13:50:35 -0700 > John Fastabend wrote: > > > Running test_sockmap with arguments to specify a test pattern requires > > including a cgroup argument. Instead of requiring this if the option is > > not provided create one > > > > This is not used by self

Re: [bpf-next PATCH 00/10] bpf: selftests, test_sockmap improvements

2020-05-07 Thread John Fastabend
Jakub Sitnicki wrote: > On Tue, 05 May 2020 13:49:36 -0700 > John Fastabend wrote: > > > Update test_sockmap to add ktls tests and in the process make output > > easier to understand and reduce overall runtime significantly. Before > > this series test_sockmap did a poor job of tracking sent byte

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-07 Thread John Hubbard
On 2020-05-07 03:32, Souptick Joarder wrote: ... OK, so no real problem with any of these callers. I still don't see a justification for the churn you suggest... Auditting all those code sites is going to be pretty tedious. I try to audit all 42 callers of {get|pin}_user_pages_fast() and figure

Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Cong Wang
On Wed, May 6, 2020 at 1:31 PM Nikolay Aleksandrov wrote: > The patch looks good, but note that __netdev_update_features() used to return > -1 > before the commit in the Fixes tag above (between 6cb6a27c45ce and > 00ee59271777). > It only restored that behaviour. Good point! But commit fd867d51

[PATCH] libbpf: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Nikolay Aleksandrov
On 07/05/2020 21:45, Cong Wang wrote: > On Wed, May 6, 2020 at 1:31 PM Nikolay Aleksandrov > wrote: >> The patch looks good, but note that __netdev_update_features() used to >> return -1 >> before the commit in the Fixes tag above (between 6cb6a27c45ce and >> 00ee59271777). >> It only restored t

Re: iproute2: tc deletion freezes whole server

2020-05-07 Thread Cong Wang
On Tue, May 5, 2020 at 1:46 AM Václav Zindulka wrote: > > On Mon, May 4, 2020 at 7:46 PM Cong Wang wrote: > > > > Sorry for the delay. I lost connection to my dev machine, I am trying > > to setup this on my own laptop. > > Sorry to hear that. I will gladly give you access to my testing > machine

[PATCH] IB/mlx4: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH] net/mlx5: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH] ipv6: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH] net: atarilance: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH net 2/2] net: ipa: use tag process on modem crash

2020-05-07 Thread Alex Elder
One part of recovering from a modem crash is performing a "tag sequence" of several IPA immediate commands, to clear the hardware pipeline. The sequence ends with a data transfer request on the command endpoint (which is not otherwise done). Unfortunately, attempting to do the data transfer led t

[PATCH net 1/2] net: ipa: set DMA length in gsi_trans_cmd_add()

2020-05-07 Thread Alex Elder
When a command gets added to a transaction for the AP->command channel we set the DMA address of its scatterlist entry, but not its DMA length. Fix this bug. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi_trans.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH net 0/2] net: ipa: fix cleanup after modem crash

2020-05-07 Thread Alex Elder
The first patch in this series fixes a bug where the size of a data transfer request was never set, meaning it was 0. The consequence of this was that such a transfer request would never complete if attempted, and led to a hung task timeout. This data transfer is required for cleaning up IPA hard

[Patch net v3] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Cong Wang
syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event between bonding master and slave. I managed to find a reproducer for this: ip li set bond0 up ifenslave bond0 eth0 brctl addbr br0 ethtool -K eth0 lro off brctl addif br0 bond0 ip li set br0 up When a NETDEV_FEAT_CHANGE ev

[PATCH] team: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

Re: [EXT] Re: [PATCH v1 net-next 4/6] net: mscc: ocelot: VCAP IS1 support

2020-05-07 Thread Allan W. Nielsen
On 07.05.2020 11:23, Xiaoliang Yang wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hi Allan, Hi Vladimir, On 06.05.2020 13:53, Vladimir Oltean wrote: [snip] >At the moment, the driver does not support more than 1 action. We might >need to

Re: [PATCH net-next 7/7] net: atlantic: unify get_mac_permanent

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 11:15:10 +0300 Igor Russkikh wrote: > From: Mark Starovoytov > > MAC generation in case if MAC is not populated is the same for both A1 and > A2. > This patch moves MAC generation into a separate function, which is called > from both places to reduce the amount of copy/paste.

Re: [Patch net v3] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Nikolay Aleksandrov
On 07/05/2020 22:19, Cong Wang wrote: > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > between bonding master and slave. I managed to find a reproducer > for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off > brctl addif br

Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

2020-05-07 Thread Jeremy Linton
Hi, On 5/7/20 12:27 PM, Andy Shevchenko wrote: On Thu, May 7, 2020 at 4:26 PM Jeremy Linton wrote: On 5/5/20 8:29 AM, Calvin Johnson wrote: + if (sscanf(cp, "ethernet-phy-id%4x.%4x", +&upper, &lower) == 2) { + *phy_id = ((upper & 0xFFF

Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static

2020-05-07 Thread David Miller
From: Zheng Zengkai Date: Thu, 7 May 2020 16:03:26 +0800 > Fix sparse warnings: > > drivers/net/phy/mdio-bcm-iproc.c:182:5: warning: > symbol 'iproc_mdio_resume' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai Applied.

Re: [PATCH] usb: hso: correct debug message

2020-05-07 Thread David Miller
From: Oliver Neukum Date: Thu, 7 May 2020 11:49:49 +0200 > If you do not find the OUT endpoint, you should say so, > rather than copy the error message for the IN endpoint. > Presumably a copy and paste error. > > Signed-off-by: Oliver Neukum Applied, thank you.

Re: [PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:09:05 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: > "ret". Return "0" on line 653 >

Re: [PATCH net-next] net: tulip: de4x5: make PCI_signature() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:47 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable: > "status". Return "0" on line 3912

Re: [PATCH net-next] net: atheros: remove dead code in atl1c_resume()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:36 +0800 > This code has been marked dead for nearly 10 years. Remove it. > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:57 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded > variable: "err". Return "0" on line 1411 > > Signed-off-by: Jason Yan Applied.

Re: [net-next] net:enetc: bug fix for qos sfi operate space after freed

2020-05-07 Thread David Miller
From: Po Liu Date: Thu, 7 May 2020 18:57:38 +0800 > 'Dan Carpenter' reported: > This code frees "sfi" and then dereferences it on the next line: >> kfree(sfi); >> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap); > > This "sfi->index" should be "index". > > Reported

Re: [PATCH] via-rhine: Add platform dependencies

2020-05-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 May 2020 13:42:05 +0200 > The VIA Rhine Ethernet interface is only present on PCI devices or > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > VIA_RHINE config symbol, to avoid asking the user about it when > configuring a kernel with

Re: [PATCH] net: hisilicon: Make CONFIG_HNS invisible

2020-05-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 May 2020 13:45:11 +0200 > The HNS config symbol enables the framework support for the Hisilicon > Network Subsystem. It is already selected by all of its users, so there > is no reason to make it visible. > > Signed-off-by: Geert Uytterhoeven Applied, th

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread David Miller
From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Saeed, please pick this up. Thank you.

Re: [RFC PATCH bpf-next 2/3] bpf, arm64: Optimize AND,OR,XOR,JSET BPF_K using arm64 logical immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{AND,OR,XOR,JSET} BPF_K loads the immediate to a temporary register before use. This patch changes the code to avoid using a temporary register when the BPF immediate is encodable using an arm64 logical immediate instruction. If the

Re: [PATCH v2 0/2] Add QRTR MHI client driver

2020-05-07 Thread David Miller
From: Manivannan Sadhasivam Date: Thu, 7 May 2020 18:23:04 +0530 > Here is the series adding MHI client driver support to Qualcomm IPC router > protocol. MHI is a newly added bus to kernel which is used to communicate to > external modems over a physical interface like PCI-E. This driver is used

Re: [RFC PATCH bpf-next 3/3] bpf, arm64: Optimize ADD,SUB,JMP BPF_K using arm64 add/sub immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{ADD,SUB} BPF_K loads the BPF immediate to a temporary register before performing the addition/subtraction. Similarly, BPF_JMP BPF_K cases load the immediate to a temporary register before comparison. This patch introduces optimizati

Re: pull-request: wireless-drivers-next-2020-05-07

2020-05-07 Thread David Miller
From: Kalle Valo Date: Thu, 07 May 2020 16:21:06 +0300 > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. Pulled, thanks Kalle.

Re: [PATCH -next] net: ipa: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:39:45 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou The net-next tree already has this fixed.

Re: [PATCH -next] cxgb4: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:26:39 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou Applied.

Re: [PATCH bpf-next v4 4/4] bpf: allow any port in bpf_bind helper

2020-05-07 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2020-05-07 12:12 -0700]: > We want to have a tighter control on what ports we bind to in > the BPF_CGROUP_INET{4,6}_CONNECT hooks even if it means > connect() becomes slightly more expensive. The expensive part > comes from the fact that we now need to call inet_csk_get_po

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overflow warning

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Xie XiuQi Sent: Monday, May 4, 2020 7:45 PM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-ker...@vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: fix

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove unused inline function ixgbe_irq_disable_queues

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of YueHaibing Sent: Tuesday, May 5, 2020 1:36 AM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: netdev@vger.kernel.org; YueHaibing ; intel-wired-...@lists.osuosl.org; linux-ker...@vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-n

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove conversion to bool in ixgbe_device_supports_autoneg_fc()

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 12:42 AM To: Kirsher, Jeffrey T ; da...@davemloft.net; intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Jason Yan Subject: [Intel-wired-lan] [PATCH net-n

  1   2   3   >