[net-next RFC PATCH 1/2] add support for PRP similar to HSR

2020-05-06 Thread Murali Karicheri
PRP protocol is similar to HSR in many aspects and this patch add a command type prp to create prp interface using two slave interfaces similar to HSR HSR and PRP interfaces are setup in a similar way in kernel as the protocols shares many similar attributes. So restructure the code to avoid dupli

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-06 Thread Alexei Starovoitov
On Wed, May 6, 2020 at 8:53 AM Josh Poimboeuf wrote: > > On Tue, May 05, 2020 at 04:59:39PM -0700, Alexei Starovoitov wrote: > > As far as workaround I prefer the following: > > From 94bbc27c5a70d78846a5cb675df4cf8732883564 Mon Sep 17 00:00:00 2001 > > From: Alexei Starovoitov > > Date: Tue, 5 Ma

Re: pulling cap_perfmon

2020-05-06 Thread Alexei Starovoitov
On Mon, May 4, 2020 at 1:52 PM Alexei Starovoitov wrote: > > On Thu, Apr 30, 2020 at 11:03 AM Alexei Starovoitov > wrote: > > > > Hi Ingo, > > > > I'd like to pull > > commit 980737282232 ("capabilities: Introduce CAP_PERFMON to kernel > > and user space") > > into bpf-next to base my CAP_BPF wor

Re: pulling cap_perfmon

2020-05-06 Thread Thomas Gleixner
Alexei Starovoitov writes: > > I'd like to pull > commit 980737282232 ("capabilities: Introduce CAP_PERFMON to kernel > and user space") > into bpf-next to base my CAP_BPF work on top of it. > could you please prepare a stable tag for me to pull ? > Last release cycle Thomas did a tag for bpf+rt p

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > > > On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Provide devm_register_netdev() - a device resource managed variant

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 09:09:52 +0200 Bartosz Golaszewski wrote: > > > +} > > > > Why do you clean the TX ring from a work rather than from the NAPI > > context? > > So this was unclear to me, that's why I went with a workqueue. The > budget argument in napi poll is for RX. Should I put some cap on

Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Vinicius Costa Gomes
Hi Murali, Murali Karicheri writes: > Fix following sparse checker warning:- > > net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different > base types) > net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [usertype] > protocol > net/hsr/hsr_slave.c:38:18:go

Re: [PATCH bpf-next v2 13/20] bpf: add bpf_seq_printf and bpf_seq_write helpers

2020-05-06 Thread Andrii Nakryiko
On Sun, May 3, 2020 at 11:26 PM Yonghong Song wrote: > > Two helpers bpf_seq_printf and bpf_seq_write, are added for > writing data to the seq_file buffer. > > bpf_seq_printf supports common format string flag/width/type > fields so at least I can get identical results for > netlink and ipv6_route

Re: [PATCH bpf-next v2 14/20] bpf: handle spilled PTR_TO_BTF_ID properly when checking stack_boundary

2020-05-06 Thread Andrii Nakryiko
On Sun, May 3, 2020 at 11:28 PM Yonghong Song wrote: > > This specifically to handle the case like below: >// ptr below is a socket ptr identified by PTR_TO_BTF_ID >u64 param[2] = { ptr, val }; >bpf_seq_printf(seq, fmt, sizeof(fmt), param, sizeof(param)); > > In this case, the 16 bytes

Re: [PATCH bpf-next v2 15/20] bpf: support variable length array in tracing programs

2020-05-06 Thread Andrii Nakryiko
On Sun, May 3, 2020 at 11:27 PM Yonghong Song wrote: > > In /proc/net/ipv6_route, we have > struct fib6_info { > struct fib6_table *fib6_table; > ... > struct fib6_nh fib6_nh[0]; > } > struct fib6_nh { > struct fib_nh_common nh_common; > struct rt6_info **rt6i_pcpu; >

Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-06 Thread Denis Kirjanov
On 5/5/20, Paul Durrant wrote: >> -Original Message- >> >> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device >> >> *dev, >> >> set_backend_state(be, XenbusStateConnected); >> >> break; >> >> >> >> + case XenbusStateReconfiguring: >> >> + rea

Re: [PATCH 08/15] maccess: rename strnlen_unsafe_user to strnlen_user_unsafe

2020-05-06 Thread Linus Torvalds
On Tue, May 5, 2020 at 11:22 PM Christoph Hellwig wrote: > > This matches the convention of always having _unsafe as a suffix, as > well as match the naming of strncpy_from_user_unsafe. Hmm. While renaming them, can we perhaps clarify what the rules are? We now have two different kinds of "unsaf

[PATCH net-next 0/2] dpaa2-eth: add bulking to XDP_TX

2020-05-06 Thread Ioana Ciornei
This patch set adds support for bulk enqueue in terms of XDP_TX packets. XDP_TX packets are qeueued no longer than the end of the NAPI cycle or until the array of frame descriptors stored per frame queue is full. The first patch just cleans up the bulk enqueue and creates a new routine to enqueue

[PATCH net-next 2/2] dpaa2-eth: add bulking to XDP_TX

2020-05-06 Thread Ioana Ciornei
Add driver level bulking to the XDP_TX action. An array of frame descriptors is held for each Tx frame queue and populated accordingly when the action returned by the XDP program is XDP_TX. The frames will be actually enqueued only when the array is filled. At the end of the NAPI cycle a flush on

[PATCH net-next 1/2] dpaa2-eth: create a function to flush the XDP fds

2020-05-06 Thread Ioana Ciornei
Create an independent function that takes a particular frame queue and an array of frame descriptors and tries to enqueue them until it hits the maximum number fo retries. The same function will be used in the next patch also on the XDP_TX path. Also, create the dpaa2_eth_xdp_fds structure to inco

Re: [PATCH 08/15] maccess: rename strnlen_unsafe_user to strnlen_user_unsafe

2020-05-06 Thread Christoph Hellwig
On Wed, May 06, 2020 at 10:44:15AM -0700, Linus Torvalds wrote: > So while I think using a consistent convention is good, and it's true > that there is a difference in the convention between the two cases > ("unsafe" at the beginning vs end), one of them is actually about the > safety and security

[PATCH net] net: dsa: sja1105: the PTP_CLK extts input reacts on both edges

2020-05-06 Thread Vladimir Oltean
From: Vladimir Oltean It looks like the sja1105 external timestamping input is not as generic as we thought. When fed a signal with 50% duty cycle, it will timestamp both the rising and the falling edge. When fed a short pulse signal, only the timestamp of the falling edge will be seen in the PTP

Re: [PATCH bpf-next v2 10/20] net: bpf: add netlink and ipv6_route bpf_iter targets

2020-05-06 Thread Yonghong Song
On 5/5/20 10:21 PM, Andrii Nakryiko wrote: On Sun, May 3, 2020 at 11:29 PM Yonghong Song wrote: This patch added netlink and ipv6_route targets, using the same seq_ops (except show() and minor changes for stop()) for /proc/net/{netlink,ipv6_route}. The net namespace for these targets are t

Re: [PATCH bpf-next v2 1/5] selftests/bpf: generalize helpers to control background listener

2020-05-06 Thread Martin KaFai Lau
On Wed, May 06, 2020 at 09:28:02AM -0700, s...@google.com wrote: > On 05/06, Martin KaFai Lau wrote: > > On Tue, May 05, 2020 at 01:27:26PM -0700, Stanislav Fomichev wrote: > > > Move the following routines that let us start a background listener > > > thread and connect to a server by fd to the te

Re: [PATCH 15/15] x86: use non-set_fs based maccess routines

2020-05-06 Thread Linus Torvalds
On Tue, May 5, 2020 at 11:23 PM Christoph Hellwig wrote: > > +#define arch_kernel_read(dst, src, type, err_label)\ > + __get_user_size(*((type *)dst), (__force type __user *)src, \ > + sizeof(type), __kr_err);\ .. > +#defi

Re: [PATCH 08/15] maccess: rename strnlen_unsafe_user to strnlen_user_unsafe

2020-05-06 Thread Linus Torvalds
On Wed, May 6, 2020 at 10:47 AM Christoph Hellwig wrote: > > > The fact that we have "probe_kernel_read()" but then > > "strncpy_from_user_unsafe()" for the _same_ conceptual difference > > really tells me how inconsistent the naming for these kinds of "we > > can't take page faults" is. No? > > T

Re: [PATCH bpf-next v2 03/20] bpf: support bpf tracing/iter programs for BPF_LINK_CREATE

2020-05-06 Thread Alexei Starovoitov
On 5/5/20 8:09 PM, Andrii Nakryiko wrote: On Tue, May 5, 2020 at 5:54 PM Alexei Starovoitov wrote: On 5/5/20 5:14 PM, Yonghong Song wrote: On 5/5/20 2:30 PM, Andrii Nakryiko wrote: On Sun, May 3, 2020 at 11:26 PM Yonghong Song wrote: Given a bpf program, the step to create an anonymous

Re: [PATCH bpf-next v2 4/5] bpf: allow any port in bpf_bind helper

2020-05-06 Thread Martin KaFai Lau
On Wed, May 06, 2020 at 09:22:45AM -0700, s...@google.com wrote: > On 05/05, Martin KaFai Lau wrote: > > On Tue, May 05, 2020 at 01:27:29PM -0700, Stanislav Fomichev wrote: > > > We want to have a tighter control on what ports we bind to in > > > the BPF_CGROUP_INET{4,6}_CONNECT hooks even if it me

[PATCH net-next 2/3] dt-binding: net: ti: am65x-cpts: make reg and compatible required

2020-05-06 Thread Grygorii Strashko
This patch follows K3 CPTS review comments from Rob Herring . - "reg" and "compatible" properties are required now - minor format changes - K3 CPTS example added to K3 MCU CPSW bindings Cc: Rob Herring Signed-off-by: Grygorii Strashko --- .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 15 ++

[PATCH net-next 3/3] arm64: dts: ti: k3-am65/j721e-mcu: update cpts node

2020-05-06 Thread Grygorii Strashko
Update CPTS node following DT binding update: - add reg and compatible properties - fix node name Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 +++- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 +++- 2 files changed, 6 insertions(+), 2 deletio

[PATCH net-next 0/3] net: ethernet: ti: am65x-cpts: follow up dt bindings update

2020-05-06 Thread Grygorii Strashko
Hi Rob, David, This series is follow update for TI A65x/J721E Common platform time sync (CPTS) driver [1] to implement DT bindings review comments from Rob Herring [2]. - "reg" and "compatible" properties are made required for CPTS DT nodes which also required to change K3 CPSW driver to us

[PATCH net-next 1/3] net: ethernet: ti: am65-cpsw-nuss: use of_platform_device_create() for mdio

2020-05-06 Thread Grygorii Strashko
The MCU CPSW expected to populate only MDIO device, but follow up patches will add "compatible" property to the MCU CPSW CPTS node which will cause creation of CPTS device and MCU CPSW init failure. Hence, switch to use of_platform_device_create() instead of of_platform_populate() for MDIO device p

Re: [PATCH 15/15] x86: use non-set_fs based maccess routines

2020-05-06 Thread Christoph Hellwig
On Wed, May 06, 2020 at 10:51:51AM -0700, Linus Torvalds wrote: > My private tree no longer has those __get/put_user_size() things, > because "unsafe_get/put_user()" is the only thing that remains with my > conversion to asm goto. > > And we're actively trying to get rid of the whole __get_user()

Re: [PATCH net,v3] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE

2020-05-06 Thread Jiri Pirko
Wed, May 06, 2020 at 01:55:39PM CEST, pa...@netfilter.org wrote: >This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver >that the frontend does not need counters, this hw stats type request >never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests >the driver to disab

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-06 Thread Edwin Peer
On Tue, May 5, 2020 at 11:46 PM Bartosz Golaszewski wrote: > Re the last bit in priv_flags: is this really a problem though? It's > not like struct net_device must remain stable - e.g. we can make > priv_flags a bitmap. Fair enough. Regards, Edwin Peer

Re: [PATCH bpf-next v2 11/20] bpf: add task and task/file iterator targets

2020-05-06 Thread Yonghong Song
On 5/6/20 12:30 AM, Andrii Nakryiko wrote: On Sun, May 3, 2020 at 11:28 PM Yonghong Song wrote: Only the tasks belonging to "current" pid namespace are enumerated. For task/file target, the bpf program will have access to struct task_struct *task u32 fd struct file *file where fd/

[PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE

2020-05-06 Thread Pablo Neira Ayuso
This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver that the frontend does not need counters, this hw stats type request never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests the driver to disable the stats, however, if the driver cannot disable counters, it bail

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Tue, May 5, 2020 at 3:42 PM Jay Vosburgh wrote: > > Cong Wang wrote: > > >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > >between bonding master and slave. I managed to find a reproducer > >for this: > > > > ip li set bond0 up > > ifenslave bond0 eth0 > > brctl addbr br0 >

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Wed, May 6, 2020 at 11:46 AM Cong Wang wrote: > > On Tue, May 5, 2020 at 3:42 PM Jay Vosburgh > wrote: > > > > Cong Wang wrote: > > > > >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > > >between bonding master and slave. I managed to find a reproducer > > >for this: > > > >

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2020-05-06 Thread Naresh Kamboju
On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > Make sure to deregister and free any fixed-link PHY registered using > of_phy_register_fixed_link() on probe errors and on driver unbind. > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > Signed-off-by: Johan Hovold > ---

Re: [PATCH 15/15] x86: use non-set_fs based maccess routines

2020-05-06 Thread Linus Torvalds
On Wed, May 6, 2020 at 11:15 AM Christoph Hellwig wrote: > > That was the first prototype, and or x86 it works great, just the > __user cases in maccess.c are a little ugly. And they point to > the real problem - for architectures like sparc and s390 that use > an entirely separate address space

Re: [PATCH net-next 1/7] dt-binding: ti: am65x: document common platform time sync cpts module

2020-05-06 Thread Rob Herring
On Tue, May 5, 2020 at 10:01 AM Grygorii Strashko wrote: > > > > On 05/05/2020 07:04, Rob Herring wrote: > > On Fri, May 01, 2020 at 11:50:05PM +0300, Grygorii Strashko wrote: > >> Document device tree bindings for TI AM654/J721E SoC The Common Platform > >> Time Sync (CPTS) module. The CPTS modul

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 09:56:41 +0200 Julian Wiedmann wrote: > On 05.05.20 23:28, Jakub Kicinski wrote: > > On Tue, 5 May 2020 21:57:43 +0200 Julian Wiedmann wrote: > >>> This is the comment from the uAPI header: > >>> > >>> /* The reset() operation must clear the flags for the components which > >>>

[PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy

2020-05-06 Thread Grygorii Strashko
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on boards: am437x-gp-evm am437x-sk-evm am437x-idk-evm All above boards have phy-mode = "rgmii" and this is worked before, because KSZ9031 PHY started with default RGMII internal del

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Tue, May 5, 2020 at 10:26 PM Michal Kubecek wrote: > > On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > > > > diff --git a/net/core/dev.c b/net/core/dev.c > > >

Re: [PATCH net-next 1/7] dt-binding: ti: am65x: document common platform time sync cpts module

2020-05-06 Thread Grygorii Strashko
On 06/05/2020 22:07, Rob Herring wrote: On Tue, May 5, 2020 at 10:01 AM Grygorii Strashko wrote: On 05/05/2020 07:04, Rob Herring wrote: On Fri, May 01, 2020 at 11:50:05PM +0300, Grygorii Strashko wrote: Document device tree bindings for TI AM654/J721E SoC The Common Platform Time Sync

[PATCH next] ARM: dts: am57xx: fix networking on boards with ksz9031 phy

2020-05-06 Thread Grygorii Strashko
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on boards: am571x-idk am572x-idk am574x-idk am57xx-beagle-x15 All above boards have phy-mode = "rgmii" and this is worked before because KSZ9031 PHY started with default RGMII inte

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-06 Thread Leon Romanovsky
On Tue, May 5, 2020 at 5:03 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > family. For now we only support full-duplex. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/mediatek/Kconfig

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 22:16:11 +0300 Leon Romanovsky wrote: > > +#define MTK_MAC_DRVNAME"mtk_eth_mac" > > +#define MTK_MAC_VERSION"1.0" > > Please don't add driver version to new driver. It has already been pointed out. Please trim yo

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-06 Thread Joe Perches
On Wed, 2020-05-06 at 22:16 +0300, Leon Romanovsky wrote: > On Tue, May 5, 2020 at 5:03 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > > family. For now we only support full-duplex. [] > > diff --git a

Re: [PATCH net-next 06/12] net: qed: gather debug data on hw errors

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 14:33:08 +0300 Igor Russkikh wrote: > To implement debug dump retrieval on a live system we add callbacks to > collect the same data which is collected now during manual `ethtool -d` > call. > > But we instead collect the dump immediately at the moment bad thing > happens, and s

[Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event between bonding master and slave. I managed to find a reproducer for this: ip li set bond0 up ifenslave bond0 eth0 brctl addbr br0 ethtool -K eth0 lro off brctl addif br0 bond0 ip li set br0 up When a NETDEV_FEAT_CHANGE ev

Re: [PATCH net] net: dsa: sja1105: the PTP_CLK extts input reacts on both edges

2020-05-06 Thread Richard Cochran
On Wed, May 06, 2020 at 08:48:13PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > It looks like the sja1105 external timestamping input is not as generic > as we thought. When fed a signal with 50% duty cycle, it will timestamp > both the rising and the falling edge. When fed a short p

Re: [PATCH net-next] sunrpc: Remove unused function ip_map_update

2020-05-06 Thread J. Bruce Fields
Thanks, applying for 5.8.--b. On Tue, May 05, 2020 at 04:45:37PM +0800, YueHaibing wrote: > commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related > code.") > left behind this, remove it. > > Signed-off-by: YueHaibing > --- > net/sunrpc/svcauth_unix.c | 9 - > 1 f

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Michal Kubecek
On Wed, May 06, 2020 at 12:08:35PM -0700, Cong Wang wrote: > On Tue, May 5, 2020 at 10:26 PM Michal Kubecek wrote: > > > > On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > > > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong W

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi Qian, On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai wrote: > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/ > > Never been picked up fo

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre > > Use the proper struct device pointer to check if the wakeup flag > and wakeup source are positioned. > Use the one passed by function call which is equivalent to > &bp->dev->dev.parent. > > It's preven

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Qian Cai
> On May 6, 2020, at 4:16 PM, Stephen Rothwell wrote: > > Hi Qian, > > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai wrote: >> >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! >> >> https://lore.kernel.org/netdev/2

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi all, On Thu, 7 May 2020 06:16:35 +1000 Stephen Rothwell wrote: > > Hi Qian, > > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai wrote: > > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > > > https://lo

Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?

2020-05-06 Thread Michael S. Tsirkin
On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote: > On 05.05.20 18:20, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > >> On 05.05.20 17:44, Michael S. Tsirkin wrote: > >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbran

[PATCH] MAINTAINERS: put DYNAMIC INTERRUPT MODERATION in proper order

2020-05-06 Thread Lukas Bulwahn
Commit 9b038086f06b ("docs: networking: convert DIM to RST") added a new file entry to DYNAMIC INTERRUPT MODERATION to the end, and not following alphabetical order. So, ./scripts/checkpatch.pl -f MAINTAINERS complains: WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic

Re: [PATCH net-next 19/33] tun: add XDP frame size

2020-05-06 Thread Michael S. Tsirkin
On Wed, Apr 22, 2020 at 06:08:57PM +0200, Jesper Dangaard Brouer wrote: > The tun driver have two code paths for running XDP (bpf_prog_run_xdp). > In both cases 'buflen' contains enough tailroom for skb_shared_info. > > Cc: Jason Wang > Signed-off-by: Jesper Dangaard Brouer Acked-by: Michael S.

Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Nikolay Aleksandrov
On 06/05/2020 22:46, Cong Wang wrote: > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > between bonding master and slave. I managed to find a reproducer > for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off > brctl addif br

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi all, On Wed, 6 May 2020 21:09:41 +0530 Amol Grover wrote: > > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > > > > >> = > > >> WARNING: suspicious RCU usage > > >> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted > > >> - >

Re: [PATCH net-next v2 19/33] tun: add XDP frame size

2020-05-06 Thread Michael S. Tsirkin
On Thu, Apr 30, 2020 at 01:21:58PM +0200, Jesper Dangaard Brouer wrote: > The tun driver have two code paths for running XDP (bpf_prog_run_xdp). > In both cases 'buflen' contains enough tailroom for skb_shared_info. > > Cc: Jason Wang > Signed-off-by: Jesper Dangaard Brouer > Acked-by: Jason Wan

Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?

2020-05-06 Thread David Hildenbrand
> Am 06.05.2020 um 22:28 schrieb Michael S. Tsirkin : > > On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote: >>> On 05.05.20 18:20, Michael S. Tsirkin wrote: >>> On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: On 05.05.20 17:44, Michael S. Tsirkin wrote:

Re: [PATCH net-next v2 20/33] vhost_net: also populate XDP frame size

2020-05-06 Thread Michael S. Tsirkin
On Thu, Apr 30, 2020 at 01:22:03PM +0200, Jesper Dangaard Brouer wrote: > In vhost_net_build_xdp() the 'buf' that gets queued via an xdp_buff > have embedded a struct tun_xdp_hdr (located at xdp->data_hard_start) > which contains the buffer length 'buflen' (with tailroom for > skb_shared_info). Als

Re: [PATCH net-next v2 21/33] virtio_net: add XDP frame size in two code paths

2020-05-06 Thread Michael S. Tsirkin
On Thu, Apr 30, 2020 at 01:22:08PM +0200, Jesper Dangaard Brouer wrote: > The virtio_net driver is running inside the guest-OS. There are two > XDP receive code-paths in virtio_net, namely receive_small() and > receive_mergeable(). The receive_big() function does not support XDP. > > In receive_sm

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi Qian, On Wed, 6 May 2020 16:21:05 -0400 Qian Cai wrote: > > > On May 6, 2020, at 4:16 PM, Stephen Rothwell wrote: > > > > Hi Qian, > > > > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai wrote: > >> > >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > net/ipv4/ipmr.c:136 RC

Re: [PATCH] virtio_net: fix lockdep warning on 32 bit

2020-05-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 5 May 2020 20:01:31 -0400 > - u64_stats_update_end(&rq->stats.syncp); > + u64_stats_update_end_irqrestore(&rq->stats.syncp); Need to pass flags to this function.

Re: [PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread David Miller
From: Samuel Zou Date: Wed, 6 May 2020 10:54:58 +0800 > Fixes coccicheck warning: > > drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Applied to net-next, thank you.

Re: [PATCH] MAINTAINERS: put DYNAMIC INTERRUPT MODERATION in proper order

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 22:29:06 +0200 Lukas Bulwahn wrote: > Commit 9b038086f06b ("docs: networking: convert DIM to RST") added a new > file entry to DYNAMIC INTERRUPT MODERATION to the end, and not following > alphabetical order. > > So, ./scripts/checkpatch.pl -f MAINTAINERS complains: > > WARNI

Re: [PATCH net] selftests: net: tcp_mmap: clear whole tcp_zerocopy_receive struct

2020-05-06 Thread David Miller
From: Eric Dumazet Date: Tue, 5 May 2020 20:51:06 -0700 > We added fields in tcp_zerocopy_receive structure, > so make sure to clear all fields to not pass garbage to the kernel. > > We were lucky because recent additions added 'out' parameters, > still we need to clean our reference implementa

Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Murali Karicheri
Hi Vinicius, On 5/6/20 1:33 PM, Vinicius Costa Gomes wrote: Hi Murali, Murali Karicheri writes: Fix following sparse checker warning:- net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [u

Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

2020-05-06 Thread David Miller
From: Manivannan Sadhasivam Date: Wed, 6 May 2020 10:20:14 +0530 > +/* From QRTR to MHI */ > +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev, > + struct mhi_result *mhi_res) > +{ > + struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr

Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

2020-05-06 Thread David Miller
Also when you resubmit, please provide a proper introduction posting that explains what the patch series does, how it does it, and why it is doing it that way. Thanks.

Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Jay Vosburgh
Cong Wang wrote: >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event >between bonding master and slave. I managed to find a reproducer >for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off > brctl addif br0 bond0 > ip li set br0 up

Re: [PATCH bpf-next v2 11/20] bpf: add task and task/file iterator targets

2020-05-06 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 11:24 AM Yonghong Song wrote: > > > > On 5/6/20 12:30 AM, Andrii Nakryiko wrote: > > On Sun, May 3, 2020 at 11:28 PM Yonghong Song wrote: > >> > >> Only the tasks belonging to "current" pid namespace > >> are enumerated. > >> > >> For task/file target, the bpf program will

Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:16:30 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded > variable: "err". Return "0" on line 1252 > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: cortina: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 14:10:41 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied.

Re: [PATCH v2] net: ethernet: ti: Remove TI_CPTS_MOD workaround

2020-05-06 Thread Grygorii Strashko
On 06/05/2020 09:51, Clay McClure wrote: On Tue, May 05, 2020 at 10:41:26AM +0300, Grygorii Strashko wrote: It's better if you send v2 not as reply to v1. Noted, thank you, and thank you for taking the time to review my patch. just to clarify. After these two patches - the PTP_1588_CLO

Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:16:16 +0800 > Fix the following coccicheck warning: > > net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function > 'br_mrp_enabled' with return type bool > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:18:35 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/intel/i40e/i40e_adminq.c:699:13-21: Unneeded > variable: "ret_code". Return "0" on line 710 > > Signed-off-by: Jason Yan Jeff, please pick this up. Thank you.

Re: [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

2020-05-06 Thread David Miller
From: Samuel Zou Date: Wed, 6 May 2020 14:27:30 +0800 > Fix the following sparse warning: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning: > symbol 'mtk_m32' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Applied, thanks.

[net-next v3 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-05

2020-05-06 Thread Jeff Kirsher
This series contains the initial implementation of the Virtual Bus, virtbus_device, virtbus_driver, updates to 'ice' and 'i40e' to use the new Virtual Bus. The primary purpose of the Virtual bus is to put devices on it and hook the devices up to drivers. This will allow drivers, like the RDMA dri

[net-next v3 1/9] Implementation of Virtual Bus

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman This is the initial implementation of the Virtual Bus, virtbus_device and virtbus_driver. The virtual bus is a software based bus intended to support registering virtbus_devices and virtbus_drivers and provide matching between them and probing of the registered drivers. The bu

[net-next v3 6/9] ice: Allow reset operations

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman Enable the PF to notify peers when it's going to reset so that peer devices can prepare accordingly. Also enable the peer devices to request the PF to reset. Implement ice_peer_is_vsi_ready() so the peer device can determine when the VSI is ready for operations following a rese

[net-next v3 8/9] i40e: Move client header location

2020-05-06 Thread Jeff Kirsher
From: Shiraz Saleem Move i40e_client.h to include/linux/net/intel/* since its shared between i40iw and i40e. Signed-off-by: Shiraz Saleem Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/infiniband/hw/i40iw/Makefile| 1 - drivers/infiniband/hw/i40i

[net-next v3 7/9] ice: Pass through communications to VF

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman Allow for forwarding of RDMA and VF virt channel messages. The driver will forward messages from the RDMA driver to the VF via the vc_send operation and invoke the peer's vc_receive() call when receiving a virt channel message destined for the peer driver. Signed-off-by: Dave E

[net-next v3 9/9] i40e: Register a virtbus device to provide RDMA

2020-05-06 Thread Jeff Kirsher
From: Shiraz Saleem Register client virtbus device on the virtbus for the RDMA virtbus driver (irdma) to bind to. It allows to realize a single RDMA driver capable of working with multiple netdev drivers over multi-generation Intel HW supporting RDMA. There is also no load ordering dependencies b

[net-next v3 3/9] ice: Complete RDMA peer registration

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman Ensure that the peer supports the minimal set of operations required for operation and, if so, open the connection to the peer. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice

[net-next v3 5/9] ice: Enable event notifications

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman Enable registration of notifications. Peer devices can register to be notified of certain events as well as notify the driver of its state changes. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/et

Re: [PATCH v2 net-next 00/10] s390/qeth: updates 2020-05-06

2020-05-06 Thread David Miller
From: Julian Wiedmann Date: Wed, 6 May 2020 10:09:39 +0200 > please apply the following patch series for qeth to netdev's net-next > tree. > Same patches as yesterday, except that the ethtool reset has been > dropped for now. > > This primarily adds infrastructure to deal with HW offloads when

Re: [PATCH net-next] net: renesas: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 17:25:14 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied, thanks.

[net-next v3 4/9] ice: Support resource allocation requests

2020-05-06 Thread Jeff Kirsher
From: Dave Ertman Enable the peer device to request queue sets from the PF. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 1 + .../net/ethernet/intel/ice/ice_adminq_cmd.h |

Re: [PATCH v1 net-next 4/6] net: mscc: ocelot: VCAP IS1 support

2020-05-06 Thread Allan W. Nielsen
Hi Vladimir, On 06.05.2020 13:53, Vladimir Oltean wrote: On Wed, 6 May 2020 at 12:45, Allan W. Nielsen wrote: Hi Xiaoliang, On 06.05.2020 15:48, Xiaoliang Yang wrote: >VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and >TCP/UDP ports keys, and do Qos and VLAN retag actio

Re: [PATCH 1/2 net] net: mvpp2: prevent buffer overflow in mvpp22_rss_ctx()

2020-05-06 Thread David Miller
From: Dan Carpenter Date: Wed, 6 May 2020 13:16:22 +0300 > The "rss_context" variable comes from the user via ethtool_get_rxfh(). > It can be any u32 value except zero. Eventually it gets passed to > mvpp22_rss_ctx() and if it is over MVPP22_N_RSS_TABLES (8) then it > results in an array overfl

Re: [PATCH 2/2 net] net: mvpp2: cls: Prevent buffer overflow in mvpp2_ethtool_cls_rule_del()

2020-05-06 Thread David Miller
From: Dan Carpenter Date: Wed, 6 May 2020 13:16:56 +0300 > The "info->fs.location" is a u32 that comes from the user via the > ethtool_set_rxnfc() function. We need to check for invalid values to > prevent a buffer overflow. > > I copy and pasted this check from the mvpp2_ethtool_cls_rule_ins()

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-06 Thread Josh Poimboeuf
On Wed, May 06, 2020 at 09:45:01AM -0700, Alexei Starovoitov wrote: > On Wed, May 6, 2020 at 8:53 AM Josh Poimboeuf wrote: > > > > On Tue, May 05, 2020 at 04:59:39PM -0700, Alexei Starovoitov wrote: > > > As far as workaround I prefer the following: > > > From 94bbc27c5a70d78846a5cb675df4cf8732883

Re: [PATCH -next] net: enetc: Make some symbols static

2020-05-06 Thread David Miller
From: ChenTao Date: Wed, 6 May 2020 19:22:17 +0800 > Fix the following warning: > > drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning: > symbol 'enetc_act_fwd' was not declared. Should it be static? > drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning: > symbol 'enet

Re: [PATCH net-next] net: mediatek: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 19:13:08 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied.

Re: [PATCH net-next] net: socionext: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 19:04:59 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied.

Re: [PATCH bpf-next v2 11/20] bpf: add task and task/file iterator targets

2020-05-06 Thread Yonghong Song
On 5/6/20 1:51 PM, Andrii Nakryiko wrote: On Wed, May 6, 2020 at 11:24 AM Yonghong Song wrote: On 5/6/20 12:30 AM, Andrii Nakryiko wrote: On Sun, May 3, 2020 at 11:28 PM Yonghong Song wrote: Only the tasks belonging to "current" pid namespace are enumerated. For task/file target, the

Re: [PATCH net-next] net: lantiq: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 19:38:46 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied.

Re: [PATCH net-next] net: cpmac: Fix use correct return type for ndo_start_xmit()

2020-05-06 Thread David Miller
From: wangyunjian Date: Wed, 6 May 2020 20:21:45 +0800 > From: Yunjian Wang > > The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix > the ndo function to use the correct type. > > Signed-off-by: Yunjian Wang Applied.

<    1   2   3   4   5   >