Re: [PATCH v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-04 Thread Bartlomiej Zolnierkiewicz
On 4/23/20 6:57 PM, Andrzej Pietrasiewicz wrote: > Thermal zone devices' mode is stored in individual drivers. This patch > changes it so that mode is stored in struct thermal_zone_device instead. > > As a result all driver-specific variables storing the mode are not needed > and are removed. Co

[PATCH v5 2/2] net: phy: tja11xx: add support for master-slave configuration

2020-05-04 Thread Oleksij Rempel
The TJA11xx PHYs have a vendor specific Master/Slave configuration bit, which is not compatible with IEEE 803.2-2018 spec for 100Base-T1 devices. So, provide a custom config_ange call back to solve this problem. Signed-off-by: Oleksij Rempel --- drivers/net/phy/nxp-tja11xx.c | 43 +++

[PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of auto-negotiation support, we needed to be able to configure the MASTER-SLAVE role of the port manually or from an application in user space. The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to force MASTER or S

[PATCH net-next v4 0/2] provide support for PHY master/slave configuration

2020-05-04 Thread Oleksij Rempel
changes v5: - set MASTER_SLAVE_CFG_UNSUPPORTED as default value - send a netlink error message on validation error - more code fixes changes v4: - rename port_mode to master_slave - move validation code to net/ethtool/linkmodes.c - add UNSUPPORTED state and avoid sending unsupported fields - mor

Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()

2020-05-04 Thread Markus Elfring
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, Do you distinguish between releasing items and the role of such a pointer? > which can lead to a memory leak bug. Would you like to reconsider the usage of the word “can” for such change descriptions? Regards, Markus

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
@Michal, i noticed that linkmodes_fill_reply() some times get not enough tailroom. if data->peer_empty == 0 linkmodes_reply_size() size: 476 linkmodes_fill_reply() skb tailroom: 724 if data->peer_empty == 1 linkmodes_reply_size() size: 216 linkmodes_fill_rep

[PATCH ipsec-next v2 0/7] xfrm: remove three more indirect calls from packet path

2020-05-04 Thread Florian Westphal
v2: rebase on top of ipsec-next, no other changes. This patch series removes three more indirect calls from the state_afinfo struct. These are: - extract_input (no dependencies on other modules) - output_finish (same) - extract_output (has dependency on ipv6 module, but that is only needed for

[PATCH ipsec-next v2 3/7] xfrm: move xfrm4_extract_header to common helper

2020-05-04 Thread Florian Westphal
The function only initializes the XFRM CB in the skb. After previous patch xfrm4_extract_header is only called from net/xfrm/xfrm_{input,output}.c. Because of IPV6=m linker errors the ipv6 equivalent (xfrm6_extract_header) was already placed in xfrm_inout.h because we can't call functions residin

[PATCH ipsec-next v2 4/7] xfrm: expose local_rxpmtu via ipv6_stubs

2020-05-04 Thread Florian Westphal
We cannot call this function from the core kernel unless we would force CONFIG_IPV6=y. Therefore expose this via ipv6_stubs so we can call it from net/xfrm in the followup patch. Since the call is expected to be unlikely, no extra code for the IPV6=y case is added and we will always eat the indir

[PATCH ipsec-next v2 2/7] xfrm: state: remove extract_input indirection from xfrm_state_afinfo

2020-05-04 Thread Florian Westphal
In order to keep CONFIG_IPV6=m working, xfrm6_extract_header needs to be duplicated. It will be removed again in a followup change when the remaining caller is moved to net/xfrm as well. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 3 --- net/ipv4/xfrm4_input.c | 5 - ne

[PATCH ipsec-next v2 1/7] xfrm: avoid extract_output indirection for ipv4

2020-05-04 Thread Florian Westphal
We can use a direct call for ipv4, so move the needed functions to net/xfrm/xfrm_output.c and call them directly. For ipv6 the indirection can be avoided as well but it will need a bit more work -- to ease review it will be done in another patch. Signed-off-by: Florian Westphal --- include/net/

[PATCH ipsec-next v2 7/7] xfrm: remove output_finish indirection from xfrm_state_afinfo

2020-05-04 Thread Florian Westphal
There are only two implementaions, one for ipv4 and one for ipv6. Both are almost identical, they clear skb->cb[], set the TRANSFORMED flag in IP(6)CB and then call the common xfrm_output() function. By placing the IPCB handling into the common function, we avoid the need for the output_finish in

[PATCH ipsec-next v2 5/7] xfrm: place xfrm6_local_dontfrag in xfrm.h

2020-05-04 Thread Florian Westphal
so next patch can re-use it from net/xfrm/xfrm_output.c without causing a linker error when IPV6 is a module. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 16 net/ipv6/xfrm6_output.c | 21 ++--- 2 files changed, 18 insertions(+), 19 deletions(-)

[PATCH ipsec-next v2 6/7] xfrm: remove extract_output indirection from xfrm_state_afinfo

2020-05-04 Thread Florian Westphal
Move this to xfrm_output.c. This avoids the state->extract_output indirection. This patch also removes the duplicated __xfrm6_extract_header helper added in an earlier patch, we can now use the one from xfrm_inout.h . Signed-off-by: Florian Westphal --- include/net/xfrm.h | 3 -- net/ipv

[RFC PATCH] dt-bindings: net: nxp,tja11xx: add compatible support

2020-05-04 Thread Oleksij Rempel
... and correct SPDX-License-Identifier. Signed-off-by: Oleksij Rempel --- .../devicetree/bindings/net/nxp,tja11xx.yaml | 51 --- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bi

[PATCH net] devlink: Fix reporter's recovery condition

2020-05-04 Thread Aya Levin
Devlink health core conditions the reporter's recovery with the expiration of the grace period. This is not relevant for the first recovery. Explicitly demand that the grace period will only apply to recoveries other than the first. Fixes: c8e1da0bf923 ("devlink: Add health report functionality")

[PATCHv2 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher

2020-05-04 Thread Joyce Ooi
This patch series cleans up the Altera TSE driver and adds support for the newer msgdma prefetcher as well as ptp support when using the msgdma prefetcher. v2: Rename altera_ptp to intel_fpga_tod, modify msgdma and sgdma tx_buffer functions to be of type netdev_tx_t, and minor suggested edits

[PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

[PATCHv2 03/10] net: eth: altera: fix altera_dmaops declaration

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change --- drivers/net/ethernet/altera/altera_tse.h | 30 +

[PATCHv2 02/10] net: eth: altera: set rx and tx ring size before init_dma call

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change --- drivers/net/ethernet/altera/altera_tse_main.c | 6 -- 1 file changed, 4 insertions(+)

[PATCHv2 05/10] net: eth: altera: Move common functions to altera_utils

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Move request_and_map and other shared functions to altera_utils. This is the first step to moving common code out of tse specific code so that it can be shared with future altera ethernet ip. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change --

[PATCHv2 07/10] net: eth: altera: change tx functions to type netdev_tx_t

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Modify all msgdma and sgdma tx_buffer functions to be of type netdev_tx_t, and also modify main tx function to be of netdev_tx_t type. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: this patch is added in patch set version 2 --- drivers/net/ethernet/

[PATCHv2 08/10] net: eth: altera: add support for ptp and timestamping

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Add support for the ptp clock used with the tse, and update the driver to support timestamping when enabled. We also enable debugfs entries for the ptp clock to allow some user control and interaction with the ptp clock. Cc: Richard Cochran Signed-off-by: Dalon Westergr

[PATCHv2 09/10] net: eth: altera: add msgdma prefetcher

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Add support for the mSGDMA prefetcher. The prefetcher adds support for a linked list of descriptors in system memory. The prefetcher feeds these to the mSGDMA dispatcher. The prefetcher is configured to poll for the next descriptor in the list to be owned by hardware, t

[PATCHv2 04/10] net: eth: altera: add optional function to start tx dma

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Allow for optional start up of tx dma if the start_txdma function is defined in altera_dmaops. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change --- drivers/net/ethernet/altera/altera_tse.h | 1 + drivers/net/ethernet/altera/altera_tse_ma

[PATCHv2 06/10] net: eth: altera: Add missing identifier names to function declarations

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen The sgdma and msgdma header files included function declarations without identifier names for pointers. Add appropriate identifier names. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: this patch is added in patch version 2 --- drivers/net/ethernet/

[PATCHv2 10/10] net: eth: altera: update devicetree bindings documentation

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen Update devicetree bindings documentation to include msgdma prefetcher and ptp bindings. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change --- .../devicetree/bindings/net/altera_tse.txt |

[PATCH net v1] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Dejin Zheng
the related system resources were not released when pci_iomap() return error in the rtw_pci_io_mapping() function. add pci_release_regions() to fix it. Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver") Cc: Andy Shevchenko Signed-off-by: Dejin Zheng --- drivers/net/wireless/realtek/r

[PATCH net] net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

2020-05-04 Thread Tariq Toukan
When ENOSPC is set the idx is still valid and gets set to the global MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that ENOSPC is impossible from mlx4_cmd_imm() and gives this warning: drivers/net/ethernet/mellanox/mlx4/main.c:2552:28: warning: 'idx' may be used uninitialized

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 10:04:17AM +0200, Oleksij Rempel wrote: > @Michal, > > i noticed that linkmodes_fill_reply() some times get not enough > tailroom. > if data->peer_empty == 0 > linkmodes_reply_size() size: 476 > linkmodes_fill_reply() skb tailroom: 724 > > > if data->peer_empty == 1 > lin

RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Tony Chuang
> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources > > the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. > > Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac d

[PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-04 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netback/rx.c | 7 ++- drivers/net/xe

[PATCH net-next v7 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-04 Thread Denis Kirjanov
The patch adds a basic XDP processing to xen-netfront driver. We ran an XDP program for an RX response received from netback driver. Also we request xen-netback to adjust data offset for bpf_xdp_adjust_head() header space for custom headers. synchronization between frontend and backend parts is d

Re: [RFC PATCH] dt-bindings: net: nxp,tja11xx: add compatible support

2020-05-04 Thread Oleksij Rempel
Hi all, here is first attempt to rework this binding. So far I have following questions and/or issues: - currently this PHY is identified by ID, not by compatible. Should it be probed by compatible? Theoretically I can use: compatible = "nxp,tja1102", "ethernet-phy-ieee802.3-c22"; B

[PATCH net-next 02/15] bnxt_en: Allocate TQM ring context memory according to fw specification.

2020-05-04 Thread Michael Chan
Newer firmware spec. will specify the number of TQM rings to allocate context memory for. Use the firmware specified value and fall back to the old value derived from bp->max_q if it is not available. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 30 +++

[PATCH net-next 04/15] bnxt_en: Do not include ETH_FCS_LEN in the max packet length sent to fw.

2020-05-04 Thread Michael Chan
From: Vasundhara Volam The firmware does not expect the CRC to be included in the length passed from the driver. The firmware always configures the chip to strip out the CRC. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +

[PATCH net-next 01/15] bnxt_en: Update firmware spec. to 1.10.1.33.

2020-05-04 Thread Michael Chan
Changes include additional statistics, ECN support, context memory interface change for better TQM context memory sizing, firmware health status definitions, etc. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 216 ++ 1 file changed, 184 i

[PATCH net-next 08/15] bnxt_en: Improve kernel log messages related to ethtool reset.

2020-05-04 Thread Michael Chan
From: Edwin Peer Kernel log messages for failed AP reset commands should be suppressed. These are expected to fail on devices that do not have an AP. Add missing driver reload message after AP reset and log it in a common way without duplication. Signed-off-by: Edwin Peer Signed-off-by: Michae

[PATCH net-next 05/15] bnxt_en: prepare to refactor ethtool reset types

2020-05-04 Thread Michael Chan
From: Edwin Peer Extract bnxt_hwrm_firmware_reset() for performing firmware reset operations. This new helper function will be used in a subsequent patch to separate unrelated reset types out of bnxt_firmware_reset(). Signed-off-by: Edwin Peer Signed-off-by: Michael Chan --- drivers/net/ether

[PATCH net-next 06/15] bnxt_en: refactor ethtool firmware reset types

2020-05-04 Thread Michael Chan
From: Edwin Peer The case statement in bnxt_firmware_reset() dangerously mixes types. This patch separates the application processor and whole chip resets from the rest such that the selection is performed on a pure type. Signed-off-by: Edwin Peer Signed-off-by: Michael Chan --- drivers/net/e

[PATCH net-next 00/15] bnxt_en: Updates for net-next.

2020-05-04 Thread Michael Chan
This patchset includes these main changes: 1. Firmware spec. update. 2. Context memory sizing improvements for the hardware TQM block. 3. ethtool chip reset improvements and fixes for correctness. 4. Improve L2 doorbell mapping by mapping only up to the size specified by firmware. This allows the

[PATCH net-next 03/15] bnxt_en: Improve TQM ring context memory sizing formulas.

2020-05-04 Thread Michael Chan
The current formulas to calculate the TQM slow path and fast path ring context memory sizes are not quite correct. TQM slow path entry is array index 0 of ctx->tqm_mem[]. The other array entries are for fast path. Fix these sizes according to latest firmware spec. for 57500 and newer chips. Fix

[PATCH net-next 07/15] bnxt_en: fix ethtool_reset_flags ABI violations

2020-05-04 Thread Michael Chan
From: Edwin Peer The ethtool ABI specifies that the reset operation should only clear the flags that were actually reset. Setting the flags to zero after a chip reset violates this because it does not include resetting the application processor complex. Similarly, components that are not yet defi

[PATCH net-next 09/15] bnxt_en: Define the doorbell offsets on 57500 chips.

2020-05-04 Thread Michael Chan
Define the 57500 chip doorbell offsets instead of using the magic values in the C file. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[PATCH net-next 10/15] bnxt_en: Set the db_offset on 57500 chips for the RDMA MSIX entries.

2020-05-04 Thread Michael Chan
The driver provides completion ring or NQ doorbell offset for each MSIX entry requested by the RDMA driver. The NQ offset on 57500 chips is different than legacy chips. Set it correctly based on chip type for correctness. The RDMA driver is ignoring this field for the 57500 chips so it is not ca

[PATCH net-next 14/15] bnxt_en: Split HW ring statistics strings into RX and TX parts.

2020-05-04 Thread Michael Chan
This will allow the RX and TX ring statistics to be separated if needed. In the next patch, we'll be able to only display RX or TX statistcis if the channel is RX only or TX only. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 53 ++- 1 fi

[PATCH net-next 15/15] bnxt_en: show only relevant ethtool stats for a TX or RX ring

2020-05-04 Thread Michael Chan
From: Rajesh Ravi Currently, ethtool -S shows all TX/RX ring counters whether the channel is combined, RX, or TX. The unused counters will always be zero. Improve it by showing only the relevant counters if the channel is RX or TX. If the channel is combined, the counters will be shown exactly

[PATCH net-next 11/15] bnxt_en: Add support for L2 doorbell size.

2020-05-04 Thread Michael Chan
Read the L2 doorbell size from the firmware and only map the portion of the doorbell BAR for L2 use. This will leave the remaining doorbell BAR available for the RoCE driver to use. The RoCE driver can map the remaining portion as write-combining to support the push feature. Signed-off-by: Micha

[PATCH net-next 13/15] bnxt_en: Refactor the software ring counters.

2020-05-04 Thread Michael Chan
We currently have 3 software ring counters, rx_l4_csum_errors, rx_buf_errors, and missed_irqs. The 1st two are RX counters and the last one is a common counter. Organize them into 2 structures bnxt_rx_sw_stats and bnxt_cmn_sw_stats. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom

[PATCH net-next 12/15] bnxt_en: Add doorbell information to bnxt_en_dev struct.

2020-05-04 Thread Michael Chan
The purpose of this is to inform the RDMA driver the size of the doorbell BAR that the L2 driver has mapped and the portion that is mapped uncacheable. The unchaeable portion is shared with the RoCE driver. Any remaining unmapped doorbell BAR can be used by the RDMA driver for its own purpose. Cu

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
On Mon, May 04, 2020 at 10:37:34AM +0200, Michal Kubecek wrote: > On Mon, May 04, 2020 at 10:04:17AM +0200, Oleksij Rempel wrote: > > @Michal, > > > > i noticed that linkmodes_fill_reply() some times get not enough > > tailroom. > > if data->peer_empty == 0 > > linkmodes_reply_size() size: 476 > >

Re: [PATCH bpf-next] libbpf: fix probe code to return EPERM if encountered

2020-05-04 Thread Eelco Chaudron
On 1 May 2020, at 21:16, Andrii Nakryiko wrote: > On Fri, May 1, 2020 at 2:56 AM Eelco Chaudron wrote: >> >> Let me know, and I sent out a v2. > > Yes, that's the split I had in mind, but I'd move > bpf_object__probe_loading() call directly into bpf_object__load() to > be the first thing to c

[PATCH bpf-next v2] libbpf: fix probe code to return EPERM if encountered

2020-05-04 Thread Eelco Chaudron
When the probe code was failing for any reason ENOTSUP was returned, even if this was due to no having enough lock space. This patch fixes this by returning EPERM to the user application, so it can respond and increase the RLIMIT_MEMLOCK size. Signed-off-by: Eelco Chaudron --- v2: Split bpf_objec

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Michal Kubecek
On Mon, May 04, 2020 at 09:12:13AM +0200, Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same

Re: [PATCH 24/37] docs: networking: device drivers: convert intel/ipw2100.txt to ReST

2020-05-04 Thread Kalle Valo
Mauro Carvalho Chehab writes: > - add SPDX header; > - adjust titles and chapters, adding proper markups; > - comment out text-only TOC from html/pdf output; > - use copyright symbol; > - use :field: markup; > - mark code blocks and literals as such; > - mark tables as such; > - adjust identation

Re: [PATCH 25/37] docs: networking: device drivers: convert intel/ipw2200.txt to ReST

2020-05-04 Thread Kalle Valo
Mauro Carvalho Chehab writes: > - add SPDX header; > - adjust titles and chapters, adding proper markups; > - comment out text-only TOC from html/pdf output; > - use copyright symbol; > - use :field: markup; > - mark code blocks and literals as such; > - mark tables as such; > - adjust identation

[PATCH] docs: dt: fix broken links due to txt->yaml renames

2020-05-04 Thread Mauro Carvalho Chehab
There are some new broken doc links due to yaml renames at DT. Developers should really run: ./scripts/documentation-file-ref-check in order to solve those issues while submitting patches. This tool can even fix most of the issues with: ./scripts/documentation-file-ref-check --fi

Re: [PATCH][next] rtw88: fix spelling mistake "fimrware" -> "firmware"

2020-05-04 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in two rtw_err error messages. Fix them. > > Signed-off-by: Colin Ian King > Acked-by: Sebastian Andrzej Siewior Patch applied to wireless-drivers-next.git, thanks. a6336094c3ab rtw88: fix spelling mistake "fimrware"

Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()

2020-05-04 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40: > WARNING: Comparison to bool > > Signed-off-by: Jason Yan > Reviewed-by: Chi-hsien Lin Patch applied to wireless-drivers-next.git, thanks. ff2af09f4515 brcmfm

Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions

2020-05-04 Thread Kalle Valo
Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > In doing this, make brcmf_debugfs_add_entry() return void as no one was > even

Re: [PATCH] docs: dt: fix broken links due to txt->yaml renames

2020-05-04 Thread Mark Brown
On Mon, May 04, 2020 at 11:30:20AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v5 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-04 Thread Oleksij Rempel
On Mon, May 04, 2020 at 11:10:44AM +0200, Michal Kubecek wrote: > On Mon, May 04, 2020 at 09:12:13AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > > MASTER-SLAVE role of

Re: [RFC PATCH net-next] net: dsa: mt7530: fix roaming from DSA user ports

2020-05-04 Thread Vladimir Oltean
Hi Qingfang, On Sat, 25 Apr 2020 at 15:03, DENG Qingfang wrote: > > When a client moves from a DSA user port to a software port in a bridge, > it cannot reach any other clients that connected to the DSA user ports. > That is because SA learning on the CPU port is disabled, so the switch > ignores

Re: INFO: rcu detected stall in wg_packet_tx_worker

2020-05-04 Thread Jason A. Donenfeld
So in spite of this Syzkaller bug being unrelated in the end, I've continued to think about the stacktrace a bit, and combined with some other [potentially false alarm] bug reports I'm trying to wrap my head around, I'm a bit a curious about ideal usage for the udp_tunnel API. All the uses I've se

[PATCH] b43: remove Comparison of 0/1 to bool variable in pio.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/pio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broa

[PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:476:6-14: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:54:5-22: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf

[PATCH] b43: remove Comparison of 0/1 to bool variable in phy_n.c

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless

[PATCH] ath11k: use true,false for bool variables

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/ath/ath11k/dp_rx.c:2964:1-39: WARNING: Assignment of 0/1 to bool variable drivers/net/wireless/ath/ath11k/dp_rx.c:2965:1-38: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/wireless/ath/ath11k/dp_rx.

[PATCH] brcmsmac: remove Comparison to bool in brcms_b_txstatus()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:1060:6-12: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[PATCH] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1781:9-12: WARNING: Comparison to bool drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/brcm80211/b

[RFC PATCH bpf-next 03/13] xsk: move defines only used by AF_XDP internals to xsk.h

2020-05-04 Thread Björn Töpel
From: Björn Töpel Move the XSK_NEXT_PG_CONTIG_{MASK,SHIFT}, and XDP_UMEM_USES_NEED_WAKEUP defines from xdp_sock.h to the AF_XDP internal xsk.h file. Also, start using the BIT{,_ULL} macro instead of explicit shifts. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 14 -- net

[RFC PATCH bpf-next 01/13] xsk: move xskmap.c to net/xdp/

2020-05-04 Thread Björn Töpel
From: Björn Töpel The XSKMAP is partly implemented by net/xdp/xsk.c. Move xskmap.c from kernel/bpf/ to net/xdp/, which is the logical place for AF_XDP related code. Also, move AF_XDP struct definitions, and function declarations only used by AF_XDP internals into net/xdp/xsk.h. Signed-off-by: Bj

[RFC PATCH bpf-next 04/13] xsk: introduce AF_XDP buffer allocation API

2020-05-04 Thread Björn Töpel
From: Björn Töpel In order to simplify AF_XDP zero-copy enablement for NIC driver developers, a new AF_XDP buffer allocation API is added. The implementation is based on a single core (single producer/consumer) buffer pool for the AF_XDP UMEM. A buffer is allocated using the xsk_buff_alloc() fun

[RFC PATCH bpf-next 02/13] xsk: move driver interface to xdp_sock_drv.h

2020-05-04 Thread Björn Töpel
From: Magnus Karlsson Move the AF_XDP zero-copy driver interface to its own include file called xdp_sock_drv.h. This, hopefully, will make it more clear for NIC driver implementors to know what functions to use for zero-copy support. Signed-off-by: Magnus Karlsson --- drivers/net/ethernet/inte

[RFC PATCH bpf-next 00/13] Introduce AF_XDP buffer allocation API

2020-05-04 Thread Björn Töpel
Driver adoption for AF_XDP has been slow. The amount of code required to proper support AF_XDP is substantial and the driver/core APIs are vague or even non-existing. Drivers have to manually adjust data offsets, updating AF_XDP handles differently for different modes (aligned/unaligned). This ser

[RFC PATCH bpf-next 10/13] mlx5, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL

2020-05-04 Thread Björn Töpel
From: Björn Töpel Use the new MEM_TYPE_XSK_BUFF_POOL API in lieu of MEM_TYPE_ZERO_COPY in mlx5e. It allows to drop a lot of code from the driver (which is now common in AF_XDP core and was related to XSK RX frame allocation, DMA mapping, etc.) and slightly improve performance. Signed-off-by: Bjö

[RFC PATCH bpf-next 05/13] i40e: refactor rx_bi accesses

2020-05-04 Thread Björn Töpel
From: Björn Töpel As a first step to migrate i40e to the new MEM_TYPE_XSK_BUFF_POOL APIs, code that accesses the rx_bi (SW/shadow ring) is refactored to use an accessor function. Cc: intel-wired-...@lists.osuosl.org Signed-off-by: Björn Töpel --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1

[RFC PATCH bpf-next 13/13] MAINTAINERS, xsk: update AF_XDP section after moves/adds

2020-05-04 Thread Björn Töpel
From: Björn Töpel Update MAINTAINERS to correctly mirror the current AF_XDP socket file layout. Also, add the AF_XDP files of libbpf. Signed-off-by: Björn Töpel --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index db7a6d462dff

[RFC PATCH bpf-next 11/13] xsk: remove MEM_TYPE_ZERO_COPY and corresponding code

2020-05-04 Thread Björn Töpel
From: Björn Töpel There are no users of MEM_TYPE_ZERO_COPY. Remove all corresponding code, including the "handle" member of struct xdp_sock. Signed-off-by: Björn Töpel --- drivers/net/hyperv/netvsc_bpf.c | 1 - include/net/xdp.h | 9 +-- include/net/xdp_sock.h | 45

[RFC PATCH bpf-next 09/13] ixgbe, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL

2020-05-04 Thread Björn Töpel
From: Björn Töpel Remove MEM_TYPE_ZERO_COPY in favor of the new MEM_TYPE_XSK_BUFF_POOL APIs. Cc: intel-wired-...@lists.osuosl.org Signed-off-by: Björn Töpel --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 9 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 +- .../ethernet/intel/ix

[RFC PATCH bpf-next 07/13] i40e, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL

2020-05-04 Thread Björn Töpel
From: Björn Töpel Remove MEM_TYPE_ZERO_COPY in favor of the new MEM_TYPE_XSK_BUFF_POOL APIs. The AF_XDP zero-copy rx_bi ring is now simply a struct xdp_buff pointer. Cc: intel-wired-...@lists.osuosl.org Signed-off-by: Björn Töpel --- drivers/net/ethernet/intel/i40e/i40e_main.c | 19 +- driver

[RFC PATCH bpf-next 08/13] ice, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL

2020-05-04 Thread Björn Töpel
From: Björn Töpel Remove MEM_TYPE_ZERO_COPY in favor of the new MEM_TYPE_XSK_BUFF_POOL APIs. Cc: intel-wired-...@lists.osuosl.org Signed-off-by: Maciej Fijalkowski Signed-off-by: Björn Töpel --- drivers/net/ethernet/intel/ice/ice_base.c | 16 +- drivers/net/ethernet/intel/ice/ice_txrx.h |

[RFC PATCH bpf-next 12/13] xsk: explicitly inline functions and move definitions

2020-05-04 Thread Björn Töpel
From: Björn Töpel In order to reduce the number of function calls, the struct xsk_buff_pool definition is moved to xsk_buff_pool.h. The functions xp_get_dma(), xp_dma_sync_for_cpu() and xp_dma_sync_for_device() are explicitly inlined. Further, move xp_get_handle() and xp_release() to xsk.c, to a

[RFC PATCH bpf-next 06/13] i40e: separate kernel allocated rx_bi rings from AF_XDP rings

2020-05-04 Thread Björn Töpel
From: Björn Töpel Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP zero-copy/sk_buff rx_bi rings are now separate. Functions to properly allocate the different rings are added as well. Cc: intel-wired-...@lists.osuosl.org Signed-off-by: Björn Töpel --- drivers/net/ethernet/int

Re: [RFC v2] current devlink extension plan for NICs

2020-05-04 Thread Jiri Pirko
Mon, May 04, 2020 at 04:12:18AM CEST, sridhar.samudr...@intel.com wrote: > > >On 5/1/2020 2:14 AM, Jiri Pirko wrote: >> Hi all. >> >> First, I would like to apologize for very long email. But I think it >> would be beneficial to the see the whole picture, where we are going. >> >> Currently we ar

Re: [RFC PATCH bpf-next 11/13] xsk: remove MEM_TYPE_ZERO_COPY and corresponding code

2020-05-04 Thread Björn Töpel
On Mon, 4 May 2020 at 13:38, Björn Töpel wrote: > > From: Björn Töpel > > There are no users of MEM_TYPE_ZERO_COPY. Remove all corresponding > code, including the "handle" member of struct xdp_sock. > "struct xdp_buff"

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > Hi Arnd, > > On 4/30/20 16:30, Arnd Bergmann wrote: >> gcc-10 started warning about out-of-bounds access for zero-length >> arrays: >> >> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >> from drivers/net/wireless/ath/ath10k/htt_

[PATCH net v1] net: enetc: fix an issue about leak system resources

2020-05-04 Thread Dejin Zheng
the related system resources were not released when enetc_hw_alloc() return error in the enetc_pci_mdio_probe(), add iounmap() for error handling label "err_hw_alloc" to fix it. Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") Cc: Andy Shevchenko

[GIT PULL] vhost: fixes

2020-05-04 Thread Michael S. Tsirkin
The following changes since commit 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c: Linux 5.7-rc3 (2020-04-26 13:51:02 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 0b841030625cde5f784dd62a

[PATCH net-next 07/12] net/smc: assign link to a new connection

2020-05-04 Thread Karsten Graul
For new connections, assign a link from the link group, using some simple load balancing. Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun --- net/smc/smc_core.c | 65 -- 1 file changed, 46 insertions(+), 19 deletions(-) diff --git a/net/smc/sm

[PATCH net-next 00/12] net/smc: add failover processing

2020-05-04 Thread Karsten Graul
This patch series adds the actual SMC-R link failover processing and improved link group termination. There will be one more (very small) series after this which will complete the SMC-R link failover support. Karsten Graul (12): net/smc: save state of last sent CDC message net/smc: switch co

[PATCH net-next 08/12] net/smc: asymmetric link tagging

2020-05-04 Thread Karsten Graul
New connections must not be assigned to asymmetric links. Add asymmetric link tagging using new link variable link_is_asym. The new helpers smcr_lgr_set_type() and smcr_lgr_set_type_asym() are called to set the state of the link group, and tag all links accordingly. smcr_lgr_conn_assign_link() resp

[PATCH net-next 10/12] net/smc: improve termination processing

2020-05-04 Thread Karsten Graul
Add helper smcr_lgr_link_deactivate_all() and eliminate duplicate code. In smc_lgr_free(), clear the smc-r links before smc_lgr_free_bufs() is called so buffers are already prepared for free. The usage of the soft parameter in __smc_lgr_terminate() is no longer needed, smc_lgr_free() can be called

[PATCH net-next 06/12] net/smc: send DELETE_LINK,ALL message and wait for send to complete

2020-05-04 Thread Karsten Graul
Add smc_llc_send_message_wait() which uses smc_wr_tx_send_wait() to send an LLC message and waits for the message send to complete. smc_llc_send_link_delete_all() calls the new function to send an DELETE_LINK,ALL LLC message. The RFC states that the sender of this type of message needs to wait for

[PATCH net-next 04/12] net/smc: handle incoming CDC validation message

2020-05-04 Thread Karsten Graul
Call smc_cdc_msg_validate() when a CDC message with the failover validation bit enabled was received. Validate that the sequence number sent with the message is one we already have received. If not, messages were lost and the connection is terminated using a new abort_work. Signed-off-by: Karsten

[PATCH net-next 09/12] net/smc: add termination reason and handle LLC protocol violation

2020-05-04 Thread Karsten Graul
Allow to set the reason code for the link group termination, and set meaningful values before termination processing is triggered. This reason code is sent to the peer in the final delete link message. When the LLC request or response layer receives a message type that was not handled, drop a warni

[PATCH net-next 03/12] net/smc: send failover validation message

2020-05-04 Thread Karsten Graul
When a connection is switched to a new link then a link validation message must be sent to the peer over the new link, containing the sequence number of the last CDC message that was sent over the old link. The peer will validate if this sequence number is the same or lower then the number he recei

[PATCH net-next 12/12] net/smc: save SMC-R peer link_uid

2020-05-04 Thread Karsten Graul
During SMC-R link establishment the peers exchange the link_uid that is used for debugging purposes. Save the peer link_uid in smc_link so it can be retrieved by the smc_diag netlink interface. Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun --- net/smc/af_smc.c | 2 ++ net/smc/smc_cor

[PATCH net-next 05/12] net/smc: wait for departure of an IB message

2020-05-04 Thread Karsten Graul
Introduce smc_wr_tx_send_wait() to send an IB message and wait for the tx completion event of the message. This makes sure that the message is no longer in-flight when the function returns. Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun --- net/smc/smc_core.h | 1 + net/smc/smc_wr.c

[PATCH net-next 11/12] net/smc: create improved SMC-R link_uid

2020-05-04 Thread Karsten Graul
The link_uid of an SMC-R link is exchanged between SMC peers and its value can be used for debugging purposes. Create a unique link_uid during link initialization and use it in communication with SMC-R peers. Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun --- net/smc/smc_core.c | 1 +

  1   2   3   4   >