[PATCH 3/3] tipc: fix issue of calling smp_processor_id() in preemptible

2019-08-09 Thread Ying Xue
syzbot found the following issue: [ 81.119772][ T8612] BUG: using smp_processor_id() in preemptible [] code: syz-executor834/8612 [ 81.136212][ T8612] caller is dst_cache_get+0x3d/0xb0 [ 81.141450][ T8612] CPU: 0 PID: 8612 Comm: syz-executor834 Not tainted 5.2.0-rc6+ #48 [ 81.149

[PATCH 2/3] tipc: fix memory leak issue

2019-08-09 Thread Ying Xue
syzbot found the following memory leak issue: [ 72.286706][ T7064] kmemleak: 1 new suspected memory leaks (see /sys/kernel/debug/kmemleak) BUG: memory leak unreferenced object 0x888122bca200 (size 128): comm "syz-executor232", pid 7065, jiffies 4294943817 (age 8.880s) hex dump (first 32

[PATCH 0/3] Fix three issues found by syzbot

2019-08-09 Thread Ying Xue
In this series, try to fix two memory leak issues and another issue of calling smp_processor_id() in preemptible context. Ying Xue (3): tipc: fix memory leak issue tipc: fix memory leak issue tipc: fix issue of calling smp_processor_id() in preemptible net/tipc/group.c | 22 +++

[PATCH 1/3] tipc: fix memory leak issue

2019-08-09 Thread Ying Xue
syzbot found the following memory leak: [ 68.602482][ T7130] kmemleak: 2 new suspected memory leaks (see /sys/kernel/debug/kmemleak) BUG: memory leak unreferenced object 0x88810df83c00 (size 512): comm "softirq", pid 0, jiffies 4294942354 (age 19.830s) hex dump (first 32 bytes): 38

Re: [PATCH net-next] r8169: make use of xmit_more

2019-08-09 Thread Holger Hoffstätte
On 8/8/19 10:08 PM, Heiner Kallweit wrote: (..snip..) I was about to ask exactly that, whether you have TSO enabled. I don't know what can trigger the HW issue, it was just confirmed by Realtek that this chip version has a problem with TSO. So the logical conclusion is: test w/o TSO, ideally th

Re: [PATCH net-next] r8169: make use of xmit_more

2019-08-09 Thread Eric Dumazet
On Fri, Aug 9, 2019 at 10:04 AM Holger Hoffstätte wrote: > > On 8/8/19 10:08 PM, Heiner Kallweit wrote: > (..snip..) > >>> > >>> I was about to ask exactly that, whether you have TSO enabled. I don't > >>> know what > >>> can trigger the HW issue, it was just confirmed by Realtek that this chip

Re: [PATCH v2 net-next 2/2] net: mvpp2: support multiple comphy lanes

2019-08-09 Thread Antoine Tenart
Hello Matt, On Thu, Aug 08, 2019 at 07:06:06PM -0400, Matt Pelland wrote: > > static void mvpp2_port_enable(struct mvpp2_port *port) > @@ -3389,7 +3412,9 @@ static void mvpp2_stop_dev(struct mvpp2_port *port) > > if (port->phylink) > phylink_stop(port->phylink); > - ph

Re: [PATCH v2 net-next 1/2] net: mvpp2: implement RXAUI support

2019-08-09 Thread Antoine Tenart
Hello Matt, On Thu, Aug 08, 2019 at 07:06:05PM -0400, Matt Pelland wrote: > > +static void mvpp22_gop_init_rxaui(struct mvpp2_port *port) > +{ > + struct mvpp2 *priv = port->priv; > + void __iomem *xpcs; > + u32 val; > + > + xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id

Re: [PATCH v2 net-next 0/2] net: mvpp2: Implement RXAUI Support

2019-08-09 Thread Antoine Tenart
Hello Matt, One small comment: it seems you made a typo on davem's email address. It's .net, not .com :) Thanks, Antoine On Thu, Aug 08, 2019 at 07:06:04PM -0400, Matt Pelland wrote: > This patch set implements support for configuring Marvell's mvpp2 hardware for > RXAUI operation. There are two

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Toke Høiland-Jørgensen
Ido Schimmel writes: > From: Ido Schimmel > > So far drop monitor supported only one mode of operation in which a > summary of recent packet drops is periodically sent to user space as a > netlink event. The event only includes the drop location (program > counter) and number of drops in the las

Re: [PATCH net-next] r8169: make use of xmit_more

2019-08-09 Thread Holger Hoffstätte
On 8/9/19 10:25 AM, Eric Dumazet wrote: (snip) So that didn't take long - got another timeout this morning during some random light usage, despite sg/tso being disabled this time. Again the only common element is the xmit_more patch. :( Not sure whether you want to revert this right away or wait

[patch net-next] netdevsim: register couple of devlink params

2019-08-09 Thread Jiri Pirko
From: Jiri Pirko Register couple of devlink params, one generic, one driver-specific. Make the values available over debugfs. Example: $ echo "111" > /sys/bus/netdevsim/new_device $ devlink dev param netdevsim/netdevsim111: name max_macs type generic values: cmode driverinit value 32

[PATCH net-next] tcp: batch calls to sk_flush_backlog()

2019-08-09 Thread Eric Dumazet
Starting from commit d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket backlog") loopback flows got hurt, because for each skb sent, the socket receives an immediate ACK and sk_flush_backlog() causes extra work. Intent was to not let the backlog grow too much, but we went a bit too far. We

Re: [PATCH 00/17] Networking driver debugfs cleanups

2019-08-09 Thread Greg KH
On Thu, Aug 08, 2019 at 06:42:37PM -0700, David Miller wrote: > From: David Miller > Date: Thu, 08 Aug 2019 18:37:56 -0700 (PDT) > > > I applied this without patch #17 which you said you would respin in order > > to get rid of the now unused local variable. > > Actually, there is a bunch of fall

[PATCH v2 01/17] wimax: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs wimax files, making all of this much simpler and

[PATCH v2 00/17] Networking driver debugfs cleanups

2019-08-09 Thread Greg Kroah-Hartman
There is no need to test the result of any debugfs call anymore. The debugfs core warns the user if something fails, and the return value of a debugfs call can always be fed back into another debugfs call with no problems. Also, debugfs is for debugging, so if there are problems with debugfs (i.e

[PATCH v2 02/17] bonding: no need to print a message if debugfs_create_dir() fails

2019-08-09 Thread Greg Kroah-Hartman
The debugfs core now will print a message if this function fails, so don't duplicate that logic. Also, no need to change the code logic if the call fails either, as no debugfs calls should interrupt normal kernel code for any reason. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc

[PATCH v2 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v2 14/17] fm10k: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

[PATCH v2 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Michael Hennerich Cc: Alexander Aring Cc: "David S. Miller" Cc: Harry Morris Cc: linux-w...@vger.kernel.org

[PATCH v2 12/17] skge: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Mirko Lindner Cc: Stephen Hemminger Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroa

[PATCH v2 15/17] i40e: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

[PATCH v2 04/17] xgbe: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v2 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jakub Kicinski Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer

[PATCH v2 16/17] ixgbe: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

[PATCH v2 09/17] stmmac: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because we don't care about the individual files, we can remove the stored dentry for the files, as they are not nee

[PATCH v2 10/17] dpaa2: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because we don't care about the individual files, we can remove the stored dentry for the files, as they are not nee

[PATCH v2 11/17] qca: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Stefan Wahren Cc: Michael Heimpold Cc: Yangtao Li Cc: netdev@vger.kernel.org Signed-of

[PATCH v2 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Maxime Chevallier Cc: Nick Desaulniers Cc: Nathan Huckleberry Cc: netdev@vger.kernel.o

[PATCH v2 07/17] hns3: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Yisen Zhuang Cc: Salil Mehta Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartm

[PATCH v2 05/17] bnxt: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v2 06/17] cxgb4: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. If a debugfs call fails, it will properly warn in the syslog, there's no need for all individual drivers to also pri

RE: [PATCH v2 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-09 Thread Hennerich, Michael
> -Original Message- > From: Greg Kroah-Hartman > Sent: Freitag, 9. August 2019 14:31 > To: netdev@vger.kernel.org > Cc: Greg Kroah-Hartman ; Hennerich, Michael > ; Alexander Aring ; > David S. Miller ; Harry Morris > ; linux-w...@vger.kernel.org; Stefan Schmidt > > Subject: [PATCH v2

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Ido Schimmel
On Thu, Aug 08, 2019 at 03:08:25PM -0600, David Ahern wrote: > On top of your dropwatch changes I added the ability to print the > payload as hex. e.g., > > Issue Ctrl-C to stop monitoring > drop at: nf_hook_slow+0x59/0x98 (0x814ec532) > input port ifindex: 1 > timestamp: Thu Aug 8 15:04:

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Ido Schimmel
On Fri, Aug 09, 2019 at 10:41:47AM +0200, Toke Høiland-Jørgensen wrote: > This is great. Are you planning to add the XDP integration as well? :) Thanks, Toke. From one of your previous replies I got the impression that another hook needs to be added in order to catch 'XDP_DROP' as it is not covere

Re: [PATCH net-next] tcp: batch calls to sk_flush_backlog()

2019-08-09 Thread Soheil Hassas Yeganeh
On Fri, Aug 9, 2019 at 8:04 AM Eric Dumazet wrote: > > Starting from commit d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket > backlog") > loopback flows got hurt, because for each skb sent, the socket receives an > immediate ACK and sk_flush_backlog() causes extra work. > > Intent was to n

[patch net-next] devlink: remove pointless data_len arg from region snapshot create

2019-08-09 Thread Jiri Pirko
From: Jiri Pirko The size of the snapshot has to be the same as the size of the region, therefore no need to pass it again during snapshot creation. Remove the arg and use region->size instead. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx4/crdump.c | 7 ++- include/net/d

[v4,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-09 Thread Daniel T. Lee
By this commit, using `bpftool net attach`, user can attach XDP prog on interface. New type of enum 'net_attach_type' has been made, as stated at cover-letter, the meaning of 'attach' is, prog will be attached on interface. With 'overwrite' option at argument, attached XDP program could be replace

[v4,0/4] tools: bpftool: add net attach/detach command to attach XDP prog

2019-08-09 Thread Daniel T. Lee
Currently, bpftool net only supports dumping progs attached on the interface. To attach XDP prog on interface, user must use other tool (eg. iproute2). By this patch, with `bpftool net attach/detach`, user can attach/detach XDP prog on interface. # bpftool prog 16: xdp name xdp_prog1

[v4,3/4] tools: bpftool: add bash-completion for net attach/detach

2019-08-09 Thread Daniel T. Lee
This commit adds bash-completion for new "net attach/detach" subcommand for attaching XDP program on interface. Signed-off-by: Daniel T. Lee --- tools/bpf/bpftool/bash-completion/bpftool | 65 +++ 1 file changed, 55 insertions(+), 10 deletions(-) diff --git a/tools/bpf/bpfto

[v4,4/4] tools: bpftool: add documentation for net attach/detach

2019-08-09 Thread Daniel T. Lee
Since, new sub-command 'net attach/detach' has been added for attaching XDP program on interface, this commit documents usage and sample output of `net attach/detach`. Signed-off-by: Daniel T. Lee --- .../bpf/bpftool/Documentation/bpftool-net.rst | 57 ++- 1 file changed, 54 inse

[v4,2/4] tools: bpftool: add net detach command to detach XDP on interface

2019-08-09 Thread Daniel T. Lee
By this commit, using `bpftool net detach`, the attached XDP prog can be detached. Detaching the BPF prog will be done through libbpf 'bpf_set_link_xdp_fd' with the progfd set to -1. Signed-off-by: Daniel T. Lee --- tools/bpf/bpftool/net.c | 42 - 1 file c

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Stanislav Fomichev
On 08/09, Peter Wu wrote: > /proc/config has never existed as far as I can see, but /proc/config.gz > is present on Arch Linux. Add support for decompressing config.gz using > zlib which is a mandatory dependency of libelf. Replace existing stdio > functions with gzFile operations since the latter

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Roopa Prabhu
On Thu, Aug 8, 2019 at 11:25 PM Jiri Pirko wrote: > > Fri, Aug 09, 2019 at 06:11:30AM CEST, ro...@cumulusnetworks.com wrote: > >On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: > >> > >> From: Jiri Pirko > >> > >> Add two commands to add and delete alternative ifnames for net device. > >> Each

Re: [PATCH bpf 0/2] tools: bpftool: fix pinning error messages

2019-08-09 Thread Daniel Borkmann
On 8/7/19 2:19 AM, Jakub Kicinski wrote: Hi! First make sure we don't use "prog" in error messages because the pinning operation could be performed on a map. Second add back missing error message if pin syscall failed. Jakub Kicinski (2): tools: bpftool: fix error message (prog -> object)

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Michal Kubecek
On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > to that point, I am also not sure why we have a new API For multiple > names. I mean why support more than two names (existing old name and > a new name to remove the length limitation) ? One use case is to allow "predictable names"

Re: [bpf-next v3 PATCH 0/3] bpf: improvements to xdp_fwd sample

2019-08-09 Thread Daniel Borkmann
On 8/8/19 6:17 PM, Jesper Dangaard Brouer wrote: V3: Hopefully fixed all issues point out by Yonghong Song V2: Addressed issues point out by Yonghong Song - Please ACK patch 2/3 again - Added ACKs and reviewed-by to other patches This patchset is focused on improvements for XDP forwarding s

[PATCH bpf-next v2 2/4] bpf: support cloning sk storage on accept()

2019-08-09 Thread Stanislav Fomichev
Add new helper bpf_sk_storage_clone which optionally clones sk storage and call it from sk_clone_lock. Cc: Martin KaFai Lau Cc: Yonghong Song Signed-off-by: Stanislav Fomichev --- include/net/bpf_sk_storage.h | 10 include/uapi/linux/bpf.h | 3 ++ net/core/bpf_sk_storage.c| 100

[PATCH bpf-next v2 1/4] bpf: export bpf_map_inc_not_zero

2019-08-09 Thread Stanislav Fomichev
Rename existing bpf_map_inc_not_zero to __bpf_map_inc_not_zero to indicate that it's caller's responsibility to do proper locking. Create and export bpf_map_inc_not_zero wrapper that properly locks map_idr_lock. Will be used in the next commit to hold a map while cloning a socket. Cc: Martin KaFai

[PATCH bpf-next v2 4/4] selftests/bpf: add sockopt clone/inheritance test

2019-08-09 Thread Stanislav Fomichev
Add a test that calls setsockopt on the listener socket which triggers BPF program. This BPF program writes to the sk storage and sets clone flag. Make sure that sk storage is cloned for a newly accepted connection. We have two cloned maps in the tests to make sure we hit both cases in bpf_sk_stor

[PATCH bpf-next v2 3/4] bpf: sync bpf.h to tools/

2019-08-09 Thread Stanislav Fomichev
Sync new sk storage clone flag. Cc: Martin KaFai Lau Cc: Yonghong Song Acked-by: Yonghong Song Signed-off-by: Stanislav Fomichev --- tools/include/uapi/linux/bpf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 4393

[PATCH bpf-next v2 0/4] bpf: support cloning sk storage on accept()

2019-08-09 Thread Stanislav Fomichev
Currently there is no way to propagate sk storage from the listener socket to a newly accepted one. Consider the following use case: fd = socket(); setsockopt(fd, SOL_IP, IP_TOS,...); /* ^^^ setsockopt BPF program triggers here and saves something * into sk storage

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread David Ahern
On 8/9/19 9:40 AM, Roopa Prabhu wrote: diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index ce2a623abb75..b36cfd83eb76 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include/uapi/linux/rtnetlink.h @@ -164,6 +164,13 @@ enum {

Re: [PATCH ethtool] gitignore: ignore vim swapfiles and patches

2019-08-09 Thread John W. Linville
On Mon, Jul 29, 2019 at 03:10:03PM +0200, Michal Kubecek wrote: > The .*.swp files are created by vim to hold the undo/redo log. Add them to > .gitignore to prevent "git status" or "git gui" from showing them whenever > some file is open in editor. > > Add also *.patch to hide patches created by e

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-09 Thread John W. Linville
On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > Usually kernel drivers set the regs->len value to the same length as > info->regdump_len, which was used for the allocation. In case where > regs->len is smaller than the allocated info->regdump_len length, > we may assume that the d

AW: tcan4x5x on a Raspberry Pi

2019-08-09 Thread FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu)
> Konstantin >> On 7/29/19 6:19 AM, FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu) wrote: >> Hi all, >> >> I am currently working on a project where I am trying to use the tcan4550 >> chip with a Raspberry PI 3B. >> I am struggling to create a working device tree overlay file for the >> Rasp

Re: [PATCH v2 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 14:30:59 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jakub Kicinski > Cc: "David S. Miller"

RE: [PATCH v3 net-next 0/3] net: batched receive in GRO path

2019-08-09 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Edward Cree > Sent: Tuesday, August 6, 2019 4:52 PM > To: David Miller > Cc: netdev ; Eric Dumazet > ; linux-net-driv...@solarflare.com > Subject: [PATCH v3 net-next 0/3] net: batched receive in GRO path > > This se

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-09 Thread Michal Kubecek
On Fri, Aug 09, 2019 at 12:23:36PM -0400, John W. Linville wrote: > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > Usually kernel drivers set the regs->len value to the same length as > > info->regdump_len, which was used for the allocation. In case where > > regs->len is small

Re: [PATCH v3 net-next 0/3] net: batched receive in GRO path

2019-08-09 Thread Edward Cree
On 09/08/2019 18:14, Ioana Ciocoi Radulescu wrote: > Hi Edward, > > I'm probably missing a lot of context here, but is there a reason > this change targets only the napi_gro_frags() path and not the > napi_gro_receive() one? > I'm trying to understand what drivers that don't call napi_gro_frags() >

Re: [PATCH v3] tools: bpftool: fix reading from /proc/config.gz

2019-08-09 Thread Quentin Monnet
2019-08-09 01:39 UTC+0100 ~ Peter Wu > /proc/config has never existed as far as I can see, but /proc/config.gz > is present on Arch Linux. Add support for decompressing config.gz using > zlib which is a mandatory dependency of libelf. Replace existing stdio > functions with gzFile operations since

Re: [PATCH net-next] tcp: batch calls to sk_flush_backlog()

2019-08-09 Thread David Miller
From: Eric Dumazet Date: Fri, 9 Aug 2019 05:04:47 -0700 > Starting from commit d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket > backlog") > loopback flows got hurt, because for each skb sent, the socket receives an > immediate ACK and sk_flush_backlog() causes extra work. > > Intent wa

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Toke Høiland-Jørgensen
Ido Schimmel writes: > On Fri, Aug 09, 2019 at 10:41:47AM +0200, Toke Høiland-Jørgensen wrote: >> This is great. Are you planning to add the XDP integration as well? :) > > Thanks, Toke. From one of your previous replies I got the impression > that another hook needs to be added in order to catch

Re: [PATCH v2 00/17] Networking driver debugfs cleanups

2019-08-09 Thread David Miller
From: Greg Kroah-Hartman Date: Fri, 9 Aug 2019 14:30:51 +0200 > v2: fix up build warnings, it's as if I never even built these. Ugh, so > sorry for wasting people's time with the v1 series. I need to stop > relying on 0-day as it isn't working well anymore :( One more try Greg: drive

Re: [patch net-next] devlink: remove pointless data_len arg from region snapshot create

2019-08-09 Thread David Miller
From: Jiri Pirko Date: Fri, 9 Aug 2019 15:27:15 +0200 > From: Jiri Pirko > > The size of the snapshot has to be the same as the size of the region, > therefore no need to pass it again during snapshot creation. Remove the > arg and use region->size instead. > > Signed-off-by: Jiri Pirko App

[net-next 08/15] ice: allow empty Rx descriptors

2019-08-09 Thread Jeff Kirsher
From: Mitch Williams In some circumstances, the hardware will hand us a receive descriptor which has no data attached, but is otherwise valid. The receive code was improperly ignoring these descriptors, which result in an infinite loop. To fix this, change the receive code to process all descrip

[net-next 15/15] ice: improve print for VF's when adding/deleting MAC filters

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley When we fail to add/delete MAC filters in the VF, the print doesn't distinguish between the two. Fix that by printing whether or not we failed to add/delete the MAC filter respectively. Signed-off-by: Brett Creeley Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-09

2019-08-09 Thread Jeff Kirsher
This series contains updates to ice driver only. Henry adds support to query/add queues or channels on a VSI via ethtool operations. Brett fixes the detection of a hung transmit ring by checking the software based tail (next_to_use) to determine if there is pending work. Updates the driver to ass

[net-next 03/15] ice: Assume that more than one Rx queue is rare in ice_napi_poll

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently we divide budget by the number of Rx queues per Rx ring container in ice_napi_poll even if there is only 1. This is an unnecessary divide for the normal case of 1 Rx ring per Rx ring container. Fix this by using an unlikely() call in the case where we actually need t

[net-next 09/15] ice: Do not always bring up PF VSI in ice_ena_vsi()

2019-08-09 Thread Jeff Kirsher
From: Tony Nguyen During rebuild ice_ena_vsi() is called to recover the VSI state. This function assumes the PF VSI is always to be enabled, however, it's possible that during reset/rebuild the interface can be brought down. If this occurs, we can attempt to bring up the PF VSI on a downed inter

[net-next 11/15] ice: Reduce wait times during VF bringup/reset

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently there are a couple places where the VF is waiting too long when checking the status of registers. This is causing the AVF driver to spin for longer than necessary in the __IAVF_STARTUP state. Sometimes it causes the AVF to go into the __IAVF_COMM_FAILED, which may re

[net-next 10/15] ice: update GLINT_DYN_CTL and GLINT_VECT2FUNC register access

2019-08-09 Thread Jeff Kirsher
From: Paul Greenwalt Register access for GLINT_DYN_CTL and GLINT_VECT2FUNC should be within the PF space and not the absolute device space. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 24 +++---

[net-next 04/15] ice: Restructure VFs initialization flows

2019-08-09 Thread Jeff Kirsher
From: Akeem G Abodunrin This patch restructures how VFs are configured, and resources allocated. Instead of freeing resources that were never allocated, and resetting empty VFs that have never been created - the new flow will just allocate resources for number of requested VFs based on the availa

[net-next 06/15] ice: Set WB_ON_ITR when we don't re-enable interrupts

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently when busy polling is enabled we aren't setting/enabling WB_ON_ITR in the driver. This doesn't break the driver, but it does cause issues. If we don't enable WB_ON_ITR mode we will still get write-backs from hardware during polling when a cache line has been filled, b

[net-next 07/15] ice: Fix kernel hang with DCB reset in CEE mode

2019-08-09 Thread Jeff Kirsher
From: Usha Ketineni This patch fixes the set local MIB AQ call failures in the DCB rebuild path by setting the defaults for the ETS recommended DCB configuration. Also, willing bits for the DCB configuration needs to be set correctly. Resets works fine in IEEE mode as the ETS recommended DCB conf

[net-next 01/15] ice: Implement ethtool ops for channels

2019-08-09 Thread Jeff Kirsher
From: Henry Tieman Add code to query and set the number of queues on the primary VSI for a PF. This is accessed from the 'ethtool -l' and 'ethtool -L' commands, respectively. Signed-off-by: Henry Tieman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- driv

[net-next 14/15] ice: Change type for queue counts

2019-08-09 Thread Jeff Kirsher
From: Pawel Kaminski These queue variables are being assigned values that are type u16. Change the local variables to match these types. Since these represent queue counts, they should never be negative. Signed-off-by: Pawel Kaminski Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-

[net-next 02/15] ice: Use the software based tail when checking for hung Tx ring

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently in ice_get_tx_pending we try to read a Tx ring's tail. This is then compared with the software based head (next_to_clean) to determine if we have pending work. This will never work because reading of the Tx ring's tail is no longer supported. Fix this by using the so

[net-next 13/15] ice: Move VF resources definition to SR-IOV specific file

2019-08-09 Thread Jeff Kirsher
From: Akeem G Abodunrin In order to use some of the VF resources definition in the SR-IOV specific virtchnl header file, this patch moves applicable code to ice_virtchnl_pf.h file accordingly... and they should have been defined in the destination file originally. Signed-off-by: Akeem G Abodunri

[net-next 12/15] ice: Increase size of Mailbox receive queue for many VFs

2019-08-09 Thread Jeff Kirsher
From: Brett Creeley Currently we use the ICE_MBXQ_LEN for both the Mailbox send and receive queues that are used to communicate with VFs. This is fine for the send queue because the PF driver will lock the queue for every single send, but for the Mailbox receive queue every VF is posting to its M

[net-next 05/15] ice: fix set pause param autoneg check

2019-08-09 Thread Jeff Kirsher
From: Paul Greenwalt When ETHTOOL_GLINKSETTINGS is defined get pause param pause->autoneg reports SW configured setting, however when not defined get pause param pause->autoneg reports the link status. Set pause param needs to compare pause->autoneg with the same source as get pause param to bloc

[PATCH net-next 01/12] net: stmmac: Get correct timestamp values from XGMAC

2019-08-09 Thread Jose Abreu
TX Timestamp in XGMAC comes from MAC instead of descriptors. Implement this in a new callback. Also, RX Timestamp in XGMAC must be cheked against corruption and we need a barrier to make sure that descriptor fields are read correctly. Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmma

[PATCH net-next 05/12] net: stmmac: Add a counter for Split Header packets

2019-08-09 Thread Jose Abreu
Add a counter that increments each time a packet with split header is received. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c| 2 ++ 3 fil

[PATCH net-next 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one

2019-08-09 Thread Jose Abreu
Return the correct value when RX descriptor is not the last one. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ether

[PATCH net-next 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement

2019-08-09 Thread Jose Abreu
Add 4 new tests: - SA Insertion (register based) - SA Insertion (descriptor based) - SA Replacament (register based) - SA Replacement (descriptor based) Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 98 +- 1

[PATCH net-next 07/12] net: stmmac: Add ethtool register dump for XGMAC cores

2019-08-09 Thread Jose Abreu
Add the ethtool interface to dump the register map in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++ .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 11 +- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 10 - .../

[PATCH net-next 00/12] net: stmmac: Improvements for -next

2019-08-09 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-

[PATCH net-next 08/12] net: stmmac: Add support for SA Insertion/Replacement in XGMAC cores

2019-08-09 Thread Jose Abreu
Add the support for Source Address Insertion and Replacement in XGMAC cores. Two methods are supported: Descriptor based and register based. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 11 +

[PATCH net-next 11/12] net: stmmac: Add support for VLAN Insertion Offload

2019-08-09 Thread Jose Abreu
Adds the logic to insert a given VLAN ID in a packet. This is offloaded to HW and its descriptor based. For now, only XGMAC implements the necessary callbacks. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 8 drivers/net/ethernet/stmicro/stmmac/dwxgmac2

[PATCH net-next 06/12] net: stmmac: dwxgmac: Add Flexible PPS support

2019-08-09 Thread Jose Abreu
Add the support for Flexible PPS in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 19 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 56 ++ 2 files changed, 75 insertions(+) diff --git a/drivers/net/ethernet/st

[PATCH net-next 10/12] net: stmmac: xgmac: Add EEE support

2019-08-09 Thread Jose Abreu
Add support for EEE in XGMAC cores by implementing the necessary callbacks. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 12 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 75 -- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma

[PATCH net-next 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores

2019-08-09 Thread Jose Abreu
Add the support for Split Header feature in the RX path and enable it in XGMAC cores. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/common.h | 1 + drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 ++ .../net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 18 +

[PATCH net-next 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload

2019-08-09 Thread Jose Abreu
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner and outer VLAN offloading. Signed-off-by: Jose Abreu --- .../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 96 +- 1 file changed, 94 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmi

[PATCH net-next 02/12] net: stmmac: Prepare to add Split Header support

2019-08-09 Thread Jose Abreu
In order to add Split Header support, stmmac_rx() needs to take into account that packet may be split accross multiple descriptors. Refactor the logic of this function in order to support this scenario. Signed-off-by: Jose Abreu --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 6 + dri

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread Josh Hunt
On 8/7/19 11:13 PM, Eric Dumazet wrote: On 8/8/19 1:52 AM, Josh Hunt wrote: TCP_BASE_MSS is used as the default initial MSS value when MTU probing is enabled. Update the comment to reflect this. Suggested-by: Neal Cardwell Signed-off-by: Josh Hunt --- Signed-off-by: Eric Dumazet Dave

[PATCH net-next v2 0/4] net: phy: realtek: add support for integrated 2.5Gbps PHY in RTL8125

2019-08-09 Thread Heiner Kallweit
This series adds support for the integrated 2.5Gbps PHY in RTL8125. First three patches add necessary functionality to phylib. Changes in v2: - added patch 1 - changed patch 4 to use a fake PHY ID that is injected by the network driver. This allows to use a dedicated PHY driver. Heiner Kallweit

RE: Clause 73 and USXGMII

2019-08-09 Thread Jose Abreu
From: Russell King - ARM Linux admin Date: Aug/08/2019, 13:09:03 (UTC+00:00) > On Thu, Aug 08, 2019 at 11:45:29AM +, Jose Abreu wrote: > > From: Russell King - ARM Linux admin > > Date: Aug/08/2019, 10:23:13 (UTC+00:00) > > > > > On Thu, Aug 08, 2019 at 09:02:57AM +, Jose Abreu wrote: >

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread David Miller
From: Josh Hunt Date: Fri, 9 Aug 2019 11:38:05 -0700 > I forgot to tag these at net-next. Do I need to resubmit a v3 with > net-next in the subject? No need.

Re: [PATCH v2 2/2] tcp: Update TCP_BASE_MSS comment

2019-08-09 Thread Josh Hunt
On 8/9/19 11:43 AM, David Miller wrote: From: Josh Hunt Date: Fri, 9 Aug 2019 11:38:05 -0700 I forgot to tag these at net-next. Do I need to resubmit a v3 with net-next in the subject? No need. Thanks

[PATCH net-next v2 3/4] net: phy: add phy_modify_paged_changed

2019-08-09 Thread Heiner Kallweit
Add helper function phy_modify_paged_changed, behavios is the same as for phy_modify_changed. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-core.c | 29 - include/linux/phy.h| 2 ++ 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/driv

  1   2   >