Re: [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions

2019-07-28 Thread Gal Pressman
On 26/07/2019 16:23, Jason Gunthorpe wrote: > On Fri, Jul 26, 2019 at 08:42:07AM +, Michal Kalderon wrote: > But we don't free entires from the xa_array ( only when ucontext is destroyed) so how will There be an empty element after we wrap ? >>> >>> Oh! >>> >>> That should be fixed u

[PATCH net-next] r8169: make use of xmit_more

2019-07-28 Thread Heiner Kallweit
There was a previous attempt to use xmit_more, but the change had to be reverted because under load sometimes a transmit timeout occurred [0]. Maybe this was caused by a missing memory barrier, the new attempt keeps the memory barrier before the call to netif_stop_queue like it is used by the drive

Re: [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions

2019-07-28 Thread Kamal Heib
On Thu, Jul 25, 2019 at 02:55:40PM -0300, Jason Gunthorpe wrote: > On Tue, Jul 09, 2019 at 05:17:30PM +0300, Michal Kalderon wrote: > > Create some common API's for adding entries to a xa_mmap. > > Searching for an entry and freeing one. > > > > The code was copied from the efa driver almost as is

RE: [PATCH] net/mlx5e: Fix zero table prio set by user.

2019-07-28 Thread Paul Blakey
On 7/26/2019 5:01 PM, Marcelo Ricardo Leitner wrote: > On Fri, Jul 26, 2019 at 08:39:43PM +0800, wenxu wrote: >> >> 在 2019/7/26 20:19, Or Gerlitz 写道: >>> On Fri, Jul 26, 2019 at 12:24 AM Saeed Mahameed wrote: On Thu, 2019-07-25 at 19:24 +0800, we...@ucloud.cn wrote: > From: wenxu >

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-28 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 7:08 PM Yonghong Song wrote: > > > > On 7/27/19 12:36 AM, Sedat Dilek wrote: > > On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov > > wrote: > >> > >> On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > >>> > >>> On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: >

ip route JSON format is unparseable for "unreachable" routes

2019-07-28 Thread Michael Ziegler
Hi, I created a couple "unreachable" routes on one of my systems, like such: > ip route add unreachable 10.0.0.0/8 metric 255 > ip route add unreachable 192.168.0.0/16 metric 255 Unfortunately this results in unparseable JSON output from "ip": > # ip -j route show | jq . > parse error: Obj

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-28 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 7:11 PM Yonghong Song wrote: > > > > On 7/27/19 1:16 AM, Sedat Dilek wrote: > > On Sat, Jul 27, 2019 at 9:36 AM Sedat Dilek wrote: > >> > >> On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov > >> wrote: > >>> > >>> On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > >>

[patch net] net: fix ifindex collision during namespace removal

2019-07-28 Thread Jiri Pirko
From: Jiri Pirko Commit aca51397d014 ("netns: Fix arbitrary net_device-s corruptions on net_ns stop.") introduced a possibility to hit a BUG in case device is returning back to init_net and two following conditions are met: 1) dev->ifindex value is used in a name of another "dev%d" device in i

Re: [PATCH] tcp: add new tcp_mtu_probe_floor sysctl

2019-07-28 Thread Eric Dumazet
On Sun, Jul 28, 2019 at 1:21 AM Josh Hunt wrote: > > On 7/27/19 12:05 AM, Eric Dumazet wrote: > > On Sat, Jul 27, 2019 at 4:23 AM Josh Hunt wrote: > >> > >> The current implementation of TCP MTU probing can considerably > >> underestimate the MTU on lossy connections allowing the MSS to get down

Re: ip route JSON format is unparseable for "unreachable" routes

2019-07-28 Thread Stephen Hemminger
On Sun, 28 Jul 2019 13:09:55 +0200 Michael Ziegler wrote: > Hi, > > I created a couple "unreachable" routes on one of my systems, like such: > > > ip route add unreachable 10.0.0.0/8 metric 255 > > ip route add unreachable 192.168.0.0/16 metric 255 > > Unfortunately this results in unpar

Linux Plumbers BPF micro-conference CFP (reminder)

2019-07-28 Thread Alexei Starovoitov
Hey Folks, August 2nd deadline to submit a proposal for BPF uconf is quickly approaching. If you're attending LPC in Lisbon and interested in awesome BPF uconf you need to submit a proposal. Some of you already submitted them to lpc-bpf@vger per instructions that were sent back on July 12. Some p

Re: [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately

2019-07-28 Thread Jakub Kicinski
On Sun, 28 Jul 2019 14:52:48 +0800, we...@ucloud.cn wrote: > From: wenxu > > When thre indr device register, it can get the default block > from tc immediately if the block is exist. > > Signed-off-by: wenxu > --- > v3: no change > v4: get tc default block without callback Please stop repostin

Re: [PATCH] tcp: add new tcp_mtu_probe_floor sysctl

2019-07-28 Thread Josh Hunt
On 7/28/19 6:54 AM, Eric Dumazet wrote: On Sun, Jul 28, 2019 at 1:21 AM Josh Hunt wrote: On 7/27/19 12:05 AM, Eric Dumazet wrote: On Sat, Jul 27, 2019 at 4:23 AM Josh Hunt wrote: The current implementation of TCP MTU probing can considerably underestimate the MTU on lossy connections allow

Re: [PATCH] tcp: add new tcp_mtu_probe_floor sysctl

2019-07-28 Thread Josh Hunt
On 7/28/19 2:14 PM, Josh Hunt wrote: On 7/28/19 6:54 AM, Eric Dumazet wrote: On Sun, Jul 28, 2019 at 1:21 AM Josh Hunt wrote: On 7/27/19 12:05 AM, Eric Dumazet wrote: On Sat, Jul 27, 2019 at 4:23 AM Josh Hunt wrote: The current implementation of TCP MTU probing can considerably underestim

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-28 Thread Andrew Lunn
On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer that the MAC supports flow control. The PHY

Re: [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately

2019-07-28 Thread wenxu
On 7/29/2019 4:16 AM, Jakub Kicinski wrote: > . > The TC default block is there because the indirect registration may > happen _after_ the block is installed and populated. It's the device > driver that usually does the indirect registration, the tunnel device > and its rules may already be set

Re: [PATCH net-next] netfilter: nf_table_offload: Fix zero prio of flow_cls_common_offload

2019-07-28 Thread wenxu
Hi pablo Any suggestion for this case.  Tthe 0 prio vlaue for driver is an invalid priority. So What should we do for this case? Currently there is no prio for each nft rules. BR wenxu On 7/25/2019 11:45 AM, Marcelo Ricardo Leitner wrote: > On Thu, Jul 25, 2019 at 11:03:52AM +0800, wenxu w

Re: [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately

2019-07-28 Thread Jakub Kicinski
On Mon, 29 Jul 2019 10:43:56 +0800, wenxu wrote: > On 7/29/2019 4:16 AM, Jakub Kicinski wrote: > > I don't know the nft code, but it seems unlikely it wouldn't have the > > same problem/need.. > > nft don't have the same problem.  The offload rule can only attached > to offload base chain. > >

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-28 Thread xiaofeis
On 2019-07-29 06:31, Andrew Lunn wrote: On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer th