[PATCH mlx5-next] net/mlx5: Convert mkey_table to XArray

2019-06-20 Thread Saeed Mahameed
From: Matthew Wilcox The lock protecting the data structure does not need to be an rwlock. The only read access to the lock is in an error path, and if that's limiting your scalability, you have bigger performance problems. Eliminate mlx5_mkey_table in favour of using the xarray directly. reg_m

Re: [PATCH net-next 1/3] net/sched: Introduce action ct

2019-06-20 Thread Paul Blakey
On 6/19/2019 9:33 PM, Marcelo Ricardo Leitner wrote: > On Tue, Jun 11, 2019 at 04:28:31PM +0300, Paul Blakey wrote: > ... >> +static int tcf_ct_fill_params_nat(struct tcf_ct_params *p, >> + struct tc_ct *parm, >> + struct nlattr **tb, >> +

[PATCH] fjes: no need to check return value of debugfs_create functions

2019-06-20 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Yangtao Li Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/ne

Re: [PATCH net-next 1/3] net/sched: Introduce action ct

2019-06-20 Thread Paul Blakey
On 6/18/2019 7:03 PM, Cong Wang wrote: > On Fri, Jun 14, 2019 at 12:24 PM Marcelo Ricardo Leitner > wrote: >> On Fri, Jun 14, 2019 at 11:07:37AM -0700, Cong Wang wrote: >>> On Tue, Jun 11, 2019 at 9:44 AM Marcelo Ricardo Leitner >>> wrote: I had suggested to let act_ct handle the above as w

Re: network unstable on odroid-c1/meson8b.

2019-06-20 Thread Aymeric
Hi, On 2019-06-20 00:14, Heiner Kallweit wrote: On 19.06.2019 22:18, Aymeric wrote: Hello all, Kernel 3.10 didn't have a dedicated RTL8211F PHY driver yet, therefore I assume the genphy driver was used. Do you have a line with "attached PHY driver" in dmesg output of the vendor kernel? No.

Re: [PATCH net-next v4 2/7] etf: Add skip_sock_check

2019-06-20 Thread Sergei Shtylyov
On 19.06.2019 20:40, Vedang Patel wrote: Currently, etf expects a socket with SO_TXTIME option set for each packet it encounters. So, it will drop all other packets. But, in the future commits we are planning to add functionality which where tstamp value will One of "which" and "where", not

[PATCH] sis900: fix TX completion

2019-06-20 Thread Sergej Benilov
Since commit 605ad7f184b60cfaacbc038aa6c55ee68dee3c89 "tcp: refine TSO autosizing", outbound throughput is dramatically reduced for some connections, as sis900 is doing TX completion within idle states only. Make TX completion happen after every transmitted packet. Test: netperf before patch: >

[PATCH iproute2-next v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-20 Thread Denis Kirjanov
Current code assumes that we print Etheret mac and that doesn't work in IPoIB case with SRIOV-enabled hardware Before: 11: ib1: mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:f

[PATCH iproute2-next v2 2/2] uapi: update if_link.h

2019-06-20 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index bfe7f

Re: [PATCH v3 01/16] dt-bindings: net: Add YAML schemas for the generic Ethernet options

2019-06-20 Thread Maxime Ripard
Hi Andrew, On Wed, Jun 19, 2019 at 04:03:14PM +0200, Andrew Lunn wrote: > > + phy-connection-type: > > +description: > > + Operation mode of the PHY interface > > +enum: > > + # There is not a standard bus between the MAC and the PHY, > > + # something proprietary is being

[PATCH net-next v2] ipv6: Error when route does not have any valid nexthops

2019-06-20 Thread Ido Schimmel
From: Ido Schimmel When user space sends invalid information in RTA_MULTIPATH, the nexthop list in ip6_route_multipath_add() is empty and 'rt_notif' is set to NULL. The code that emits the in-kernel notifications does not check for this condition, which results in a NULL pointer dereference [1].

Re: [PATCH bpf-next v5 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-20 Thread Björn Töpel
On Tue, 18 Jun 2019 at 14:00, Maxim Mikityanskiy wrote: > > This series contains improvements to the AF_XDP kernel infrastructure > and AF_XDP support in mlx5e. The infrastructure improvements are > required for mlx5e, but also some of them benefit to all drivers, and > some can be useful for othe

Re: [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops

2019-06-20 Thread Jiri Pirko
Thu, Jun 20, 2019 at 11:10:21AM CEST, ido...@idosch.org wrote: >From: Ido Schimmel > >When user space sends invalid information in RTA_MULTIPATH, the nexthop >list in ip6_route_multipath_add() is empty and 'rt_notif' is set to >NULL. > >The code that emits the in-kernel notifications does not chec

Re: [RFC PATCH bpf-next 6/8] libbpf: allow specifying map definitions using BTF

2019-06-20 Thread Lorenz Bauer
On Mon, 17 Jun 2019 at 22:00, Andrii Nakryiko wrote: > > In my mind, BPF loaders should be able to pass through BTF to the kernel > > as a binary blob as much as possible. That's why I want the format to > > be "self describing". Compatibility then becomes a question of: what > > feature are you u

Re: [PATCH v3 03/16] dt-bindings: net: Add a YAML schemas for the generic MDIO options

2019-06-20 Thread Maxime Ripard
Hi, On Wed, Jun 19, 2019 at 08:17:52AM -0600, Rob Herring wrote: > On Wed, Jun 19, 2019 at 3:47 AM Maxime Ripard > wrote: > > > > The MDIO buses have a number of available device tree properties that can > > be used in their device tree node. Add a YAML schemas for those. > > > > Suggested-by: A

[PATCH bpf-next v3 1/2] xsk: remove AF_XDP socket from map when the socket is released

2019-06-20 Thread Björn Töpel
From: Björn Töpel When an AF_XDP socket is released/closed the XSKMAP still holds a reference to the socket in a "released" state. The socket will still use the netdev queue resource, and block newly created sockets from attaching to that queue, but no user application can access the fill/complet

[PATCH bpf-next v3 0/2] net: xdp: XSKMAP improvements

2019-06-20 Thread Björn Töpel
This series add two improvements for the XSKMAP, used by AF_XDP sockets. 1. Automatic cleanup when an AF_XDP socket goes out of scope. Instead of manually cleaning out the "released" state socket from the map, this is done automatically. This mimics the SOCKMAP behavior; Each socket track

[PATCH bpf-next v3 2/2] xsk: support BPF_EXIST and BPF_NOEXIST flags in XSKMAP

2019-06-20 Thread Björn Töpel
From: Björn Töpel The XSKMAP did not honor the BPF_EXIST/BPF_NOEXIST flags when updating an entry. This patch addresses that. Signed-off-by: Björn Töpel --- kernel/bpf/xskmap.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/xskmap.c b/kernel/

Re: [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops

2019-06-20 Thread Ido Schimmel
On Thu, Jun 20, 2019 at 11:22:03AM +0200, Jiri Pirko wrote: > Thu, Jun 20, 2019 at 11:10:21AM CEST, ido...@idosch.org wrote: > >+if (list_empty(&rt6_nh_list)) { > >+NL_SET_ERR_MSG(extack, > >+ "Invalid nexthop configuration - no valid > >nexthops"); > > N

[PATCH net] tipc: change to use register_pernet_device

2019-06-20 Thread Xin Long
This patch is to fix a dst defcnt leak, which can be reproduced by doing: # ip net a c; ip net a s; modprobe tipc # ip net e s ip l a n eth1 type veth peer n eth1 netns c # ip net e c ip l s lo up; ip net e c ip l s eth1 up # ip net e s ip l s lo up; ip net e s ip l s eth1 up # ip net e

Re: [PATCH net-next v4 1/7] igb: clear out tstamp after sending the packet

2019-06-20 Thread Eric Dumazet
On 6/19/19 10:40 AM, Vedang Patel wrote: > skb->tstamp is being used at multiple places. On the transmit side, it > is used to determine the launchtime of the packet. It is also used to > determine the software timestamp after the packet has been transmitted. > > So, clear out the tstamp value

Re: [PATCH nf-next] netfilter: bridge: Fix non-untagged fragment packet

2019-06-20 Thread Pablo Neira Ayuso
On Wed, Jun 19, 2019 at 10:35:07PM +0800, we...@ucloud.cn wrote: [...] > So if the first fragment packet don't contain vlan tag, all of the > remain should not contain vlan tag.. If I understand correctly, the problem is this: * First fragment comes with no vlan tag. * Second fragment comes with

[PATCH net] tipc: add dst_cache support for udp media

2019-06-20 Thread Xin Long
As other udp/ip tunnels do, tipc udp media should also have a lockless dst_cache supported on its tx path. Here we add dst_cache into udp_replicast to support dst cache for both rmcast and rcast, and rmcast uses ub->rcast and each rcast uses its own node in ub->rcast.list. Signed-off-by: Xin Long

[PATCH][net-next] netns: restore ops before calling ops_exit_list

2019-06-20 Thread Li RongQing
ops has been iterated to first element when call pre_exit, and it needs to restore from save_ops, not save ops to save_ops Fixes: d7d99872c144 ("netns: add pre_exit method to struct pernet_operations") Signed-off-by: Li RongQing --- net/core/net_namespace.c | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH][net-next] netns: restore ops before calling ops_exit_list

2019-06-20 Thread Eric Dumazet
On Thu, Jun 20, 2019 at 7:24 AM Li RongQing wrote: > > ops has been iterated to first element when call pre_exit, and > it needs to restore from save_ops, not save ops to save_ops > > Fixes: d7d99872c144 ("netns: add pre_exit method to struct pernet_operations") > Signed-off-by: Li RongQing Than

Re: [PATCH nf-next] netfilter: bridge: Fix non-untagged fragment packet

2019-06-20 Thread wenxu
在 2019/6/20 18:48, Pablo Neira Ayuso 写道: > On Wed, Jun 19, 2019 at 10:35:07PM +0800, we...@ucloud.cn wrote: > [...] >> So if the first fragment packet don't contain vlan tag, all of the >> remain should not contain vlan tag.. > If I understand correctly, the problem is this: > > * First fragment

[PATCH net] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-20 Thread Taehee Yoo
__vxlan_dev_create() destroys FDB using specific pointer which indicates a fdb when error occurs. But that pointer should not be used when register_netdevice() fails because register_netdevice() internally destroys fdb when error occurs. In order to avoid un-registered dev's notification, fdb dest

[PATCH nfnext v4] netfilter: add support for matching IPv4 options

2019-06-20 Thread Stephen Suryaputra
This is the kernel change for the overall changes with this description: Add capability to have rules matching IPv4 options. This is developed mainly to support dropping of IP packets with loose and/or strict source route route options. v2: Fix style issues. Make this work with NFPROTO_INET (inet

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-20 Thread Florian Westphal
Jakub Sitnicki wrote: > > Sorry for the question, but where is the problem? > > (i.e., is it with TPROXY or bpf side)? > > The way I see it is that the problem is that we have mappings for > steering traffic into sockets split between two places: (1) the socket > lookup tables, and (2) the TPROXY

Re: [PATCH bpf] samples/bpf: xdp_redirect, correctly get dummy program id

2019-06-20 Thread Toke Høiland-Jørgensen
Prashant Bhole writes: > When we terminate xdp_redirect, it ends up with following message: > "Program on iface OUT changed, not removing" > This results in dummy prog still attached to OUT interface. > It is because signal handler checks if the programs are the same that > we had attached. But w

RE: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

2019-06-20 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, June 18, 2019 4:24 AM > To: Sudarsana Reddy Kalluru > Cc: da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon > ; Ariel Elior ; Jiri Pirko > > Subject: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for > conf

[PATCH v2 net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-20 Thread René van Dorst
Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 switch both supports TRGMII mode. MT7621 TRGMII speed is fix 1200MBit. v1->v2: - Fix breakage on non MT7621 SOC - Support 25MHz and 40MHz XTAL as MT7530 clocksource René van Dorst (2): net: ethernet: mediatek: Add MT7621 T

[PATCH v2 net-next 1/2] net: ethernet: mediatek: Add MT7621 TRGMII mode support

2019-06-20 Thread René van Dorst
MT7621 SOC also supports TRGMII. TRGMII speed is 1200MBit. Signed-off-by: René van Dorst --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 38 ++--- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 11 ++ 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH v2 net-next 2/2] net: dsa: mt7530: Add MT7621 TRGMII mode support

2019-06-20 Thread René van Dorst
This patch add support TRGMII mode for MT7621 internal MT7530 switch. MT7621 TRGMII has only one fix speed mode of 1200MBit. Also adding support for mt7530 25MHz and 40MHz crystal clocksource. Values are based on Banana Pi R2 bsp [1]. Don't change MT7623 registers on a MT7621 device. [1] https:

[PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-20 Thread Nicolas Dichtel
The scenario is the following: the user uses a raw socket to send an ipv6 packet, destinated to a not-connected network, and specify a connected nh. Here is the corresponding python script to reproduce this scenario: import socket IPPROTO_RAW = 255 send_s = socket.socket(socket.AF_INET6, socket

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-20 Thread Davide Caratti
hello Cong, thanks for reading. On Wed, 2019-06-19 at 15:04 -0700, Cong Wang wrote: > On Wed, Jun 19, 2019 at 2:10 PM Davide Caratti wrote: > > on some CPUs (e.g. i686), tcf_walker.cookie has the same size as the IDR. > > In this situation, the following script: > > > > # tc filter add dev eth0

RE: [PATCH net] tipc: add dst_cache support for udp media

2019-06-20 Thread Jon Maloy
Acked-by: Jon Maloy > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Xin Long > Sent: 20-Jun-19 07:04 > To: network dev > Cc: da...@davemloft.net; Jon Maloy ; Ying Xue > ; tipc-discuss...@lists.sourceforge.net; Paolo > Abeni > Subject: [PATCH net] tipc: add dst_

RE: [PATCH net] tipc: change to use register_pernet_device

2019-06-20 Thread Jon Maloy
Acked-by: Jon Maloy > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Xin Long > Sent: 20-Jun-19 06:39 > To: network dev > Cc: da...@davemloft.net; Jon Maloy ; Ying Xue > ; tipc-discuss...@lists.sourceforge.net > Subject: [PATCH net] tipc: change to use register_p

Re: [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops

2019-06-20 Thread David Ahern
On 6/20/19 3:10 AM, Ido Schimmel wrote: > From: Ido Schimmel > > When user space sends invalid information in RTA_MULTIPATH, the nexthop > list in ip6_route_multipath_add() is empty and 'rt_notif' is set to > NULL. > > The code that emits the in-kernel notifications does not check for this > con

Re: [PATCH v2 net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-20 Thread Frank Wunderlich
Tested on Bananapi R2 (mt7623) Tested-by: "Frank Wunderlich" Am 20. Juni 2019 14:21:53 MESZ schrieb "René van Dorst" : >Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 >switch both supports TRGMII mode. MT7621 TRGMII speed is fix 1200MBit. > >v1->v2: > - Fix breakage on no

Re: [PATCH nfnext v4] netfilter: add support for matching IPv4 options

2019-06-20 Thread Pablo Neira Ayuso
On Thu, Jun 20, 2019 at 07:51:40AM -0400, Stephen Suryaputra wrote: [...] > diff --git a/net/netfilter/nft_exthdr.c b/net/netfilter/nft_exthdr.c > index a940c9fd9045..703269359dba 100644 > --- a/net/netfilter/nft_exthdr.c > +++ b/net/netfilter/nft_exthdr.c > @@ -62,6 +62,103 @@ static void nft_exth

Re: [PATCH net-next v6 03/11] ipv4/route: Allow NULL flowinfo in rt_fill_info()

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > In the next patch, we're going to use rt_fill_info() to dump exception > routes upon RTM_GETROUTE with NLM_F_ROOT, meaning userspace is requesting > a dump and not a specific route selection, which in turn implies the input > interface is not relevant. Up

Re: [PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > diff --git a/include/net/route.h b/include/net/route.h > index 065b47754f05..e7f65388a6d4 100644 > --- a/include/net/route.h > +++ b/include/net/route.h > @@ -44,6 +44,7 @@ > #define RT_CONN_FLAGS_TOS(sk,tos) (RT_TOS(tos) | sock_flag(sk, > SOCK_LOCALR

Re: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

2019-06-20 Thread Jiri Pirko
Thu, Jun 20, 2019 at 02:09:29PM CEST, skall...@marvell.com wrote: >> -Original Message- >> From: Jakub Kicinski >> Sent: Tuesday, June 18, 2019 4:24 AM >> To: Sudarsana Reddy Kalluru >> Cc: da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon >> ; Ariel Elior ; Jiri Pirko >> >> S

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Willem de Bruijn
On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > When an application is run that: > a) Sets its scheduler to be SCHED_FIFO > and > b) Opens a memory mapped AF_PACKET socket, and sends frames with the > MSG_DONTWAIT flag cleared, its possible for the application to hang > forever in the kerne

[PATCH net-next v2 2/4] net/flow_dissector: add connection tracking dissection

2019-06-20 Thread Paul Blakey
Retreives connection tracking zone, mark, label, and state from a SKB. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Acked-by: Jiri Pirko --- include/linux/skbuff.h | 10 ++ include/net/flow_dissector.h | 15 +++ net/core/flow_dissector.c| 44 +

[PATCH net-next v2 1/4] net/sched: Introduce action ct

2019-06-20 Thread Paul Blakey
Allow sending a packet to conntrack module for connection tracking. The packet will be marked with conntrack connection's state, and any metadata such as conntrack mark and label. This state metadata can later be matched against with tc classifers, for example with the flower classifier as below.

[PATCH net-next v2 3/4] net/sched: cls_flower: Add matching on conntrack info

2019-06-20 Thread Paul Blakey
New matches for conntrack mark, label, zone, and state. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Yossi Kuperman Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 16 ++ net/sched/cls_flower.c | 127 ++

[PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking

2019-06-20 Thread Paul Blakey
Hi, This patch series add connection tracking capabilities in tc sw datapath. It does so via a new tc action, called act_ct, and new tc flower classifier matching on conntrack state, mark and label. Usage is as follows: $ tc qdisc add dev ens1f0_0 ingress $ tc qdisc add dev ens1f0_1 ingress $ t

[PATCH net-next v2 4/4] tc-tests: Add tc action ct tests

2019-06-20 Thread Paul Blakey
Add 13 tests ensuring the command line is doing what is supposed to do. Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Marcelo Ricardo Leitner --- .../selftests/tc-testing/tc-tests/actions/ct.json | 314 + 1 file changed, 314 insertions(+) create mode 100644 tools/t

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Matteo Croce
On Thu, Jun 20, 2019 at 3:42 PM Willem de Bruijn wrote: > > On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > > > When an application is run that: > > a) Sets its scheduler to be SCHED_FIFO > > and > > b) Opens a memory mapped AF_PACKET socket, and sends frames with the > > MSG_DONTWAIT flag

Re: [PATCH net-next v6 06/11] ipv6/route: Don't match on fc_nh_id if not set in ip6_route_del()

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > If fc_nh_id isn't set, we shouldn't try to match against it. This > actually matters just for the RTF_CACHE case below (where this is > already handled): if iproute2 gets a route exception and tries to > delete it, it won't reference its fc_nh_id, even if

Re: [PATCH net-next v6 07/11] ipv6/route: Change return code of rt6_dump_route() for partial node dumps

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > In the next patch, we are going to add optional dump of exceptions to > rt6_dump_route(). > > Change the return code of rt6_dump_route() to accomodate partial node > dumps: we might dump multiple routes per node, and might be able to dump > only a given

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Neil Horman
On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > > > When an application is run that: > > a) Sets its scheduler to be SCHED_FIFO > > and > > b) Opens a memory mapped AF_PACKET socket, and sends frames with the > > MSG_DONTWA

Re: [PATCH net-next v6 08/11] ipv6: Dump route exceptions if requested

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > + if (filter->dump_exceptions) { > + struct fib6_nh_exception_dump_walker w = { .dump = arg, > +.rt = rt, > +.flags = flags, >

RE: [PATCH] net: phylink: set the autoneg state in phylink_phy_change

2019-06-20 Thread Ioana Ciornei
> Subject: Re: [PATCH] net: phylink: set the autoneg state in phylink_phy_change > > On Sat, Jun 15, 2019 at 06:08:54PM -0700, David Miller wrote: > > From: Russell King - ARM Linux admin > > Date: Sat, 15 Jun 2019 23:13:28 +0100 > > > > > On Sat, Jun 15, 2019 at 01:30:21PM -0700, David Miller wr

Re: [PATCH v2 bpf-next 00/11] BTF-defined BPF map definitions

2019-06-20 Thread Lorenz Bauer
On Tue, 18 Jun 2019 at 22:37, Andrii Nakryiko wrote: > > I would just drop the object-scope pinning. We avoided using it and I'm not > > aware if anyone else make use. It also has the ugly side-effect that this > > relies on AF_ALG which e.g. on some cloud provider shipped kernels is > > disable

HI

2019-06-20 Thread James Williams
-- My greeting to you and your family, I am Captain JAMES WILLIAMS. I'm 49 years old, from the united states, but I am currently in Syria for peace keeping mission. I am the commanding officer of the third Battalion soldier regime. Please forgive my manners I am not good when it comes to the

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-20 Thread David Ahern
On 6/20/19 6:34 AM, Nicolas Dichtel wrote: > The scenario is the following: the user uses a raw socket to send an ipv6 > packet, destinated to a not-connected network, and specify a connected nh. > Here is the corresponding python script to reproduce this scenario: > > import socket > IPPROTO_RA

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Willem de Bruijn
On Thu, Jun 20, 2019 at 10:24 AM Neil Horman wrote: > > On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > > On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > > > > > When an application is run that: > > > a) Sets its scheduler to be SCHED_FIFO > > > and > > > b) Opens a mem

Re: [PATCH v3 bpf-next 1/9] bpf: track spill/fill of constants

2019-06-20 Thread Alexei Starovoitov
On Wed, Jun 19, 2019 at 10:04 PM John Fastabend wrote: > > working my way through the series now, but for this patch > > Acked-by: John Fastabend Thanks a lot for review! It's landed now, but if you find anything I'll send follow up patches. Which I plan to do anyway for few things in backtracki

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-20 Thread Nicolas Dichtel
Le 20/06/2019 à 17:12, David Ahern a écrit : > On 6/20/19 6:34 AM, Nicolas Dichtel wrote: >> The scenario is the following: the user uses a raw socket to send an ipv6 >> packet, destinated to a not-connected network, and specify a connected nh. >> Here is the corresponding python script to reproduc

Re: network unstable on odroid-c1/meson8b.

2019-06-20 Thread Heiner Kallweit
On 20.06.2019 09:55, Aymeric wrote: > Hi, > On 2019-06-20 00:14, Heiner Kallweit wrote: >> On 19.06.2019 22:18, Aymeric wrote: >>> Hello all, >>> > >> Kernel 3.10 didn't have a dedicated RTL8211F PHY driver yet, therefore >> I assume the genphy driver was used. Do you have a line with >> "attached

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Neil Horman
On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman wrote: > > > > On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > > > On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > > > > > > > When an application is run tha

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Willem de Bruijn
On Thu, Jun 20, 2019 at 12:14 PM Neil Horman wrote: > > On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman wrote: > > > > > > On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > > > > On Wed, Jun 19, 2019 at 4:26 PM N

[PATCH nf-next v5] netfilter: add support for matching IPv4 options

2019-06-20 Thread Stephen Suryaputra
This is the kernel change for the overall changes with this description: Add capability to have rules matching IPv4 options. This is developed mainly to support dropping of IP packets with loose and/or strict source route route options. v2: Fix style issues. Make this work with NFPROTO_INET (inet

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-20 Thread David Ahern
On 6/20/19 9:42 AM, Nicolas Dichtel wrote: > Le 20/06/2019 à 17:12, David Ahern a écrit : >> On 6/20/19 6:34 AM, Nicolas Dichtel wrote: >>> The scenario is the following: the user uses a raw socket to send an ipv6 >>> packet, destinated to a not-connected network, and specify a connected nh. >>> He

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-20 Thread David Ahern
On 6/20/19 10:36 AM, David Ahern wrote: > > Also, this does not fix the forwarding case. For the forwarding case I > still see it trying to resolve fd00:200::fa from dut. nevermind. I used the wrong address for the forwarding case.

Re: [PATCH net-next v4 1/7] igb: clear out tstamp after sending the packet

2019-06-20 Thread Patel, Vedang
> On Jun 20, 2019, at 3:47 AM, Eric Dumazet wrote: > > > > On 6/19/19 10:40 AM, Vedang Patel wrote: >> skb->tstamp is being used at multiple places. On the transmit side, it >> is used to determine the launchtime of the packet. It is also used to >> determine the software timestamp after the

[PATCH 00/11] XDP unaligned chunk placement support

2019-06-20 Thread Kevin Laatz
This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem as well as limiting the packet sizes that are suppo

[PATCH 01/11] i40e: simplify Rx buffer recycle

2019-06-20 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'old_bi' values directly without

[PATCH 06/11] xsk: add support to allow unaligned chunk placement

2019-06-20 Thread Kevin Laatz
Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be placed at 0,2k,4k,6k,8k... and so on (ie. every 2k starting from 0). This patch introduces t

[PATCH 05/11] ixgbe: add offset to zca_free

2019-06-20 Thread Kevin Laatz
This patch adds the offset param to for zero_copy_allocator to ixgbe_zca_free. This change is required to calculate the handle, otherwise, this function will not work in unaligned chunk mode since we can't easily mask back to the original handle in unaligned chunk mode. Signed-off-by: Kevin Laatz

[PATCH 02/11] ixgbe: simplify Rx buffer recycle

2019-06-20 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'obi' values directly without ha

[PATCH 11/11] doc/af_xdp: include unaligned chunk case

2019-06-20 Thread Kevin Laatz
The addition of unaligned chunks mode, the documentation needs to be updated to indicate that the incoming addr to the fill ring will only be masked if the user application is run in the aligned chunk mode. This patch also adds a line to explicitly indicate that the incoming addr will not be masked

[PATCH 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-06-20 Thread Kevin Laatz
This patch adds support for the unaligned chunks mode. The addition of the unaligned chunks option will allow users to run the application with more relaxed chunk placement in the XDP umem. Unaligned chunks mode can be used with the '-u' or '--unaligned' command line options. Signed-off-by: Kevin

[PATCH 04/11] i40e: add offset to zca_free

2019-06-20 Thread Kevin Laatz
This patch adds the offset param to for zero_copy_allocator to i40e_zca_free. This change is required to calculate the handle, otherwise, this function will not work in unaligned chunk mode since we can't easily mask back to the original handle in unaligned chunk mode. Signed-off-by: Kevin Laatz

[PATCH 03/11] xdp: add offset param to zero_copy_allocator

2019-06-20 Thread Kevin Laatz
This patch adds an offset parameter for zero_copy_allocator. This change is required for the unaligned chunk mode which will come later in this patch set. The offset parameter is required for calculating the original handle in unaligned mode since we can't easily mask back to it like in the aligne

[PATCH 07/11] libbpf: add flags to umem config

2019-06-20 Thread Kevin Laatz
This patch adds a 'flags' field to the umem_config and umem_reg structs. This will allow for more options to be added for configuring umems. The first use for the flags field is to add a flag for unaligned chunks mode. These flags can either be user-provided or filled with a default. Signed-off-b

[PATCH 10/11] samples/bpf: use hugepages in xdpsock app

2019-06-20 Thread Kevin Laatz
This patch modifies xdpsock to use mmap instead of posix_memalign. With this change, we can use hugepages when running the application in unaligned chunks mode. Using hugepages makes it more likely that we have physically contiguous memory, which supports the unaligned chunk mode better. Signed-of

[PATCH 09/11] samples/bpf: add buffer recycling for unaligned chunks to xdpsock

2019-06-20 Thread Kevin Laatz
This patch adds buffer recycling support for unaligned buffers. Since we don't mask the addr to 2k at umem_teg in unaligned mode, we need to make sure we give back the correct, original addr to the fill queue. To do this, we need to mask the addr with the buffer size. To pass in a buffer size, use

Re: [PATCH nf-next] netfilter: bridge: Fix non-untagged fragment packet

2019-06-20 Thread Florian Westphal
we...@ucloud.cn wrote: > From: wenxu > > ip netns exec ns1 ip a a dev eth0 10.0.0.7/24 > ip netns exec ns2 ip link a link eth0 name vlan type vlan id 200 > ip netns exec ns2 ip a a dev vlan 10.0.0.8/24 > > ip l add dev br0 type bridge vlan_filtering 1 > brctl addif br0 veth1 > brctl addif br0 v

Re: [PATCH net-next v4 1/7] igb: clear out tstamp after sending the packet

2019-06-20 Thread Eric Dumazet
On 6/20/19 9:49 AM, Patel, Vedang wrote: > > >> On Jun 20, 2019, at 3:47 AM, Eric Dumazet wrote: >> >> >> >> On 6/19/19 10:40 AM, Vedang Patel wrote: >>> skb->tstamp is being used at multiple places. On the transmit side, it >>> is used to determine the launchtime of the packet. It is also us

[PATCH 04/11] i40e: add offset to zca_free

2019-06-20 Thread Kevin Laatz
This patch adds the offset param to for zero_copy_allocator to i40e_zca_free. This change is required to calculate the handle, otherwise, this function will not work in unaligned chunk mode since we can't easily mask back to the original handle in unaligned chunk mode. Signed-off-by: Kevin Laatz

[PATCH 05/11] ixgbe: add offset to zca_free

2019-06-20 Thread Kevin Laatz
This patch adds the offset param to for zero_copy_allocator to ixgbe_zca_free. This change is required to calculate the handle, otherwise, this function will not work in unaligned chunk mode since we can't easily mask back to the original handle in unaligned chunk mode. Signed-off-by: Kevin Laatz

[PATCH 02/11] ixgbe: simplify Rx buffer recycle

2019-06-20 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'obi' values directly without ha

[PATCH 10/11] samples/bpf: use hugepages in xdpsock app

2019-06-20 Thread Kevin Laatz
This patch modifies xdpsock to use mmap instead of posix_memalign. With this change, we can use hugepages when running the application in unaligned chunks mode. Using hugepages makes it more likely that we have physically contiguous memory, which supports the unaligned chunk mode better. Signed-of

[PATCH 06/11] xsk: add support to allow unaligned chunk placement

2019-06-20 Thread Kevin Laatz
Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be placed at 0,2k,4k,6k,8k... and so on (ie. every 2k starting from 0). This patch introduces t

[PATCH 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-06-20 Thread Kevin Laatz
This patch adds support for the unaligned chunks mode. The addition of the unaligned chunks option will allow users to run the application with more relaxed chunk placement in the XDP umem. Unaligned chunks mode can be used with the '-u' or '--unaligned' command line options. Signed-off-by: Kevin

[PATCH 01/11] i40e: simplify Rx buffer recycle

2019-06-20 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'old_bi' values directly without

[PATCH 07/11] libbpf: add flags to umem config

2019-06-20 Thread Kevin Laatz
This patch adds a 'flags' field to the umem_config and umem_reg structs. This will allow for more options to be added for configuring umems. The first use for the flags field is to add a flag for unaligned chunks mode. These flags can either be user-provided or filled with a default. Signed-off-b

[PATCH 03/11] xdp: add offset param to zero_copy_allocator

2019-06-20 Thread Kevin Laatz
This patch adds an offset parameter for zero_copy_allocator. This change is required for the unaligned chunk mode which will come later in this patch set. The offset parameter is required for calculating the original handle in unaligned mode since we can't easily mask back to it like in the aligne

[PATCH 00/11] XDP unaligned chunk placement support

2019-06-20 Thread Kevin Laatz
This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem as well as limiting the packet sizes that are suppo

[PATCH 11/11] doc/af_xdp: include unaligned chunk case

2019-06-20 Thread Kevin Laatz
The addition of unaligned chunks mode, the documentation needs to be updated to indicate that the incoming addr to the fill ring will only be masked if the user application is run in the aligned chunk mode. This patch also adds a line to explicitly indicate that the incoming addr will not be masked

[PATCH 09/11] samples/bpf: add buffer recycling for unaligned chunks to xdpsock

2019-06-20 Thread Kevin Laatz
This patch adds buffer recycling support for unaligned buffers. Since we don't mask the addr to 2k at umem_teg in unaligned mode, we need to make sure we give back the correct, original addr to the fill queue. To do this, we need to mask the addr with the buffer size. To pass in a buffer size, use

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-20 Thread Neil Horman
On Thu, Jun 20, 2019 at 12:18:41PM -0400, Willem de Bruijn wrote: > On Thu, Jun 20, 2019 at 12:14 PM Neil Horman wrote: > > > > On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > > > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman > > > wrote: > > > > > > > > On Thu, Jun 20, 2019 a

Re: [PATCH v2 net-next 2/2] net: dsa: mt7530: Add MT7621 TRGMII mode support

2019-06-20 Thread Frank Wunderlich
Tested on Bananapi R2 (mt7623) with 5.2-rc5 + net-next Tested-by: Frank Wunderlich Am 20. Juni 2019 14:21:55 MESZ schrieb "René van Dorst" : >This patch add support TRGMII mode for MT7621 internal MT7530 switch. >MT7621 TRGMII has only one fix speed mode of 1200MBit. > >Also adding support for m

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-20 Thread Cong Wang
On Thu, Jun 20, 2019 at 5:52 AM Davide Caratti wrote: > > hello Cong, thanks for reading. > > On Wed, 2019-06-19 at 15:04 -0700, Cong Wang wrote: > > On Wed, Jun 19, 2019 at 2:10 PM Davide Caratti wrote: > > > on some CPUs (e.g. i686), tcf_walker.cookie has the same size as the IDR. > > > In this

Re: [PATCH net-next v6 03/11] ipv4/route: Allow NULL flowinfo in rt_fill_info()

2019-06-20 Thread Stefano Brivio
On Thu, 20 Jun 2019 07:15:55 -0600 David Ahern wrote: > On 6/19/19 5:59 PM, Stefano Brivio wrote: > > In the next patch, we're going to use rt_fill_info() to dump exception > > routes upon RTM_GETROUTE with NLM_F_ROOT, meaning userspace is requesting > > a dump and not a specific route selection,

Re: [PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-20 Thread Stefano Brivio
On Thu, 20 Jun 2019 07:31:32 -0600 David Ahern wrote: > On 6/19/19 5:59 PM, Stefano Brivio wrote: > > diff --git a/include/net/route.h b/include/net/route.h > > index 065b47754f05..e7f65388a6d4 100644 > > --- a/include/net/route.h > > +++ b/include/net/route.h > > @@ -44,6 +44,7 @@ > > #define R

  1   2   >