On 03.06.19 21:43, David Miller wrote:
> From: Julian Wiedmann
> Date: Mon, 3 Jun 2019 17:04:44 +0200
>
>> While qeth_l3 uses netif_keep_dst() to hold onto the dst, a skb's dst
>> may still have been obsoleted (via dst_dev_put()) by the time that we
>> end up using it. The dst then points to the
On 2019-06-03 15:19, Maciej Fijalkowski wrote:
Let's get into the driver via ndo_bpf with command set to XDP_SETUP_UMEM
with fill queue that already contains some available entries that can be
used by Rx driver rings. Things worked in such way on old version of
xdpsock (that lacked libbpf support
On 2019-06-03 15:19, Maciej Fijalkowski wrote:
When it comes down to ethtool's get channels API, various drivers are
reporting the queue count in two ways - they are setting max_combined or
max_tx/max_rx fields. When creating the eBPF maps for xsk socket, this
API is used so that we have an entri
On 2019-06-03 15:19, Maciej Fijalkowski wrote:
Since xsk support in libbpf loads the xdp program interface, make it
also responsible for its removal. Store the prog id in xsk_socket_config
so when removing the program we are still able to compare the current
program id with the id from the atta
On 2019-06-03 15:19, Maciej Fijalkowski wrote:
In case where multiple xsk sockets are attached to a single interface
and one of them gets detached, the eBPF maps and program are removed.
This should not happen as the rest of xsksocks are still using these
resources.
In order to fix that, let's h
When selecting the cast type of a neighbourless IPv4 skb (eg. on a raw
socket), qeth_l3 falls back to the packet's destination IP address.
For this case we should classify traffic sent to 255.255.255.255 as
broadcast.
This fixes DHCP requests, which were misclassified as unicast
(and for IQD interf
From: Alexandra Winter
Enabling sysfs attribute bridge_hostnotify triggers a series of udev events
for the MAC addresses of all currently connected peers. In case no VLAN is
set for a peer, the device reports the corresponding MAC addresses with
VLAN ID 4096. This currently results in attribute V
Hi Dave,
same patch series as yesterday, except that patch 2 has been adjusted
as per your review to use dst_check(). Please have another look.
>From the v1 cover letter:
Please apply the following set of qeth fixes to -net.
- The first two patches fix issues in the L3 driver's cast type
sel
netif_set_real_num_tx_queues() can return an error, deal with it.
Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff
While qeth_l3 uses netif_keep_dst() to hold onto the dst, a skb's dst
may still have been obsoleted (via dst_dev_put()) by the time that we
end up using it. The dst then points to the loopback interface, which
means the neighbour lookup in qeth_l3_get_cast_type() determines a bogus
cast type of RTN
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: b7034146756b9e91cc059b19df7fe4defd4d7de7
commit: 9ffee4a8276c734956b8eab19d1c9b0ecb6b79c5 [493/503] net: ethernet:
mediatek: Extend SGMII related functions
config: arm-allmodconfig (attached as .config)
comp
On Tue, 4 Jun 2019 09:28:22 +0200
Tom Barbette wrote:
> Thanks Jesper for looking into this!
>
> I don't think I will be of much help further on this matter. My take
> out would be: as a first-time user looking into XDP after watching a
> dozen of XDP talks, I would have expected XDP default set
As Eric noted, the current wrapper for ptype func hook inside
__netif_receive_skb_list_ptype() has no chance of avoiding the indirect
call: we enter such code path only for protocols other than ipv4 and
ipv6.
Instead we can wrap the list_func invocation.
v1 -> v2:
- use the correct fix tag
Fixe
On Mon, 3 Jun 2019 21:20:30 +
Saeed Mahameed wrote:
> On Mon, 2019-06-03 at 11:04 +0200, Björn Töpel wrote:
> > On Sat, 1 Jun 2019 at 21:42, Jakub Kicinski
> > wrote:
> > > On Fri, 31 May 2019 19:18:17 +, Saeed Mahameed wrote:
> > > > On Fri, 2019-05-31 at 11:42 +0200, Björn Töpel wr
Merge commit 1c8c5a9d38f60 ("Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
applications") by taking the gpl_compatible 1-bit field definition from
commit b85fab0e67b162 ("bpf: Add gpl_compatible flag
Hi Baruch,
On Tue, Jun 4, 2019 at 1:40 PM Baruch Siach wrote:
> Merge commit 1c8c5a9d38f60 ("Merge
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
> fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
> applications") by taking the gpl_compatible 1-bit fi
On Tue, Jun 04, 2019 at 08:10:50AM +0200, Heiner Kallweit wrote:
> We have a Xilinx GBit PHY that doesn't have BMSR_ESTATEN set
> (what violates the Clause 22 standard). Instead of having the PHY
> driver to implement almost identical copies of few generic functions
> let's add a flag for this quir
Hi all,
I'm working on a custom board with a 88E6321 and an i.MX28. Port 5 is directly
connected per RMII to the CPU.
The switch is running in CPU attached mode. On Port 2 and 6 we have 2 external
Micrel KSZ9031 PHYs.
Here is the snip of my device tree:
&mac0 {
pinctrl-0 = <&mac0_pins_
From: Nikita Danilov
WoL magic packet configuration sometimes does not work due to
couple of leakages found.
Mainly there was a regression introduced during readx_poll refactoring.
Next, fw request waiting time was too small. Sometimes that
caused sleep proxy config function to return with an e
On Sun, Jun 02, 2019 at 03:13:47PM +0200, Guillaume Nault wrote:
> With commit 997dd9647164 ("net: IP6 defrag: use rbtrees in
> nf_conntrack_reasm.c"), nf_ct_frag6_reasm() is now called from
> nf_ct_frag6_queue(). With this change, nf_ct_frag6_queue() can fail
> after the skb has been added to the
On Tue, Jun 4, 2019 at 2:45 AM Paolo Abeni wrote:
>
> As Eric noted, the current wrapper for ptype func hook inside
> __netif_receive_skb_list_ptype() has no chance of avoiding the indirect
> call: we enter such code path only for protocols other than ipv4 and
> ipv6.
>
> Instead we can wrap the l
From: Jiri Pirko
When user is flashing device using devlink, he currenly does not see any
information about what is going on, percentages, etc.
Drivers, for example mlxsw and mlx5, have notion about the progress
and what is happening. This patchset exposes this progress
information to userspace.
From: Jiri Pirko
Benefit from the devlink flash update implementation and ethtool
fallback to it and move firmware flash implementation there.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/core.c| 15 ++
drivers/net/ethernet/mellanox/mlxsw
From: Jiri Pirko
Introduce a function to be called from drivers during flash. It sends
notification to userspace about flash update progress.
Signed-off-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
Reviewed-by: Ido Schimmel
---
include/net/devlink.h| 8 +++
include/uapi/linux/devlink
From: Jiri Pirko
Currently the error messages are printed to dmesg. Propagate them also
to directly to user doing the flashing through extack.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
v1->v2:
- dropped "is which" from errmsg.
---
drivers/net/ethernet/mellanox/mlx5/core/fw.c |
From: Jiri Pirko
Add new op status_notify which is called to update the user about
flashing status.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxfw/mlxfw.h | 4
.../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 24 +++
2 files
From: Jiri Pirko
Implement mlxfw status_notify op by passing notification down to
devlink. Also notify about flash update begin and end.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 18 +-
1 file changed, 17 insertion
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
v1->v2:
- added debugfs toggle to enable/disable flash status notifications
---
drivers/net/netdevsim/dev.c | 44 +++
drivers/net/netdevsim/netdevsim.h | 1 +
2 files changed, 45 insertions(+)
diff --git a/driver
From: Jiri Pirko
Benefit from the devlink flash update implementation and ethtool
fallback to it and move firmware flash implementation there.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 --
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 35 ---
From: Jiri Pirko
Utilizes the devlink flash code.
Suggested-by: Jakub Kicinski
Signed-off-by: Jiri Pirko
---
v2->v3:
- new patch
---
.../drivers/net/netdevsim/devlink.sh | 53 +++
1 file changed, 53 insertions(+)
create mode 100755 tools/testing/selftests/drivers/net
From: Jiri Pirko
Kernel sends notifications about flash update status, so implement these
messages for monitoring.
Signed-off-by: Jiri Pirko
---
devlink/devlink.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlin
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 3b6a9e6be3ac..6544824a0b97 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/de
From: Jiri Pirko
Listen to status notifications coming from kernel during flashing and
put them on stdout to inform user about the status.
Signed-off-by: Jiri Pirko
---
v2->v3:
- added example in man
v1->v2:
- fixed endless loop bug in case of no notifications
---
devlink/devlink.c | 209
On 06/03, Stanislav Fomichev wrote:
> > BTF is mandatory for _any_ new feature.
> If something is easy to support without asking everyone to upgrade to
> a bleeding edge llvm, why not do it?
> So much for backwards compatibility and flexibility.
>
> > It's for introspection and debuggability in th
On Tue, Jun 04, 2019 at 03:07:25PM +0200, Benjamin Beckmeyer wrote:
> Hi all,
>
> I'm working on a custom board with a 88E6321 and an i.MX28. Port 5 is
> directly connected per RMII to the CPU.
> The switch is running in CPU attached mode. On Port 2 and 6 we have 2
> external Micrel KSZ9031 PHY
ctinfo is a tc action restoring data stored in conntrack marks to
various fields. At present it has two independent modes of operation,
restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
marks into packet skb marks.
It understands a number of parameters specific to this action
This and next 2 patches are aimed at iproute2/net-next. Sorry for
messing up the subject prefix.
On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote:
> From: Shalom Toledo
>
> The MTUTC register configures the HW UTC counter.
Why is this called the "UTC" counter?
The PTP time scale is TAI. Is this counter intended to reflect the
Linux CLOCK_REALTIME system time?
> +/* MTUTC - Ma
On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote:
> From: Shalom Toledo
>
> Publish scaled_ppm_to_ppb to allow drivers to use it.
But why?
> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(struct
> timestamp_event_queue *queue,
> spin_unlock_irqrestore(&queue->lock,
On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote:
> +static int
> +mlxsw_sp1_ptp_update_phc_settime(struct mlxsw_sp_ptp_clock *clock, u64 nsec)
Six words ^^^
What is wrong with "mlxsw_phc_settime" ?
> +{
> + struct mlxsw_core *mlxsw_core = clock->core;
> + char mtutc_pl[MLXS
On 06/03/2019 06:38 PM, Jonathan Lemon wrote:
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue. Instead of doing this,
> have bpf_map_lookup_elem() return the queue_id, as a way of
> indicating that there is a valid entry at the map index.
>
>
On Tue, Jun 04, 2019 at 03:26:05PM +0200, Pablo Neira Ayuso wrote:
> On Sun, Jun 02, 2019 at 03:13:47PM +0200, Guillaume Nault wrote:
> > With commit 997dd9647164 ("net: IP6 defrag: use rbtrees in
> > nf_conntrack_reasm.c"), nf_ct_frag6_reasm() is now called from
> > nf_ct_frag6_queue(). With this
On Tue, 4 Jun 2019 10:06:36 +0200
Björn Töpel wrote:
> On 2019-06-03 15:19, Maciej Fijalkowski wrote:
> > Let's get into the driver via ndo_bpf with command set to XDP_SETUP_UMEM
> > with fill queue that already contains some available entries that can be
> > used by Rx driver rings. Things worke
On Tue, 4 Jun 2019 10:06:57 +0200
Björn Töpel wrote:
> On 2019-06-03 15:19, Maciej Fijalkowski wrote:
> > When it comes down to ethtool's get channels API, various drivers are
> > reporting the queue count in two ways - they are setting max_combined or
> > max_tx/max_rx fields. When creating the
On Tue, 4 Jun 2019 10:07:25 +0200
Björn Töpel wrote:
>
> On 2019-06-03 15:19, Maciej Fijalkowski wrote:
> > Since xsk support in libbpf loads the xdp program interface, make it
> > also responsible for its removal. Store the prog id in xsk_socket_config
> > so when removing the program we are st
On Tue, 4 Jun 2019 10:08:03 +0200
Björn Töpel wrote:
> On 2019-06-03 15:19, Maciej Fijalkowski wrote:
> > In case where multiple xsk sockets are attached to a single interface
> > and one of them gets detached, the eBPF maps and program are removed.
> > This should not happen as the rest of xskso
On Tue, Jun 4, 2019 at 6:41 AM Jiri Pirko wrote:
>
> From: Jiri Pirko
>
> When user is flashing device using devlink, he currenly does not see any
> information about what is going on, percentages, etc.
> Drivers, for example mlxsw and mlx5, have notion about the progress
> and what is happening.
Hi Geert,
On Tue, Jun 04 2019, Geert Uytterhoeven wrote:
> On Tue, Jun 4, 2019 at 1:40 PM Baruch Siach wrote:
>> Merge commit 1c8c5a9d38f60 ("Merge
>> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
>> fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
>>
On Tue, Jun 4, 2019 at 4:40 AM Baruch Siach wrote:
>
> Merge commit 1c8c5a9d38f60 ("Merge
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
> fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
> applications") by taking the gpl_compatible 1-bit field defini
Hi Alexei,
On Tue, Jun 4, 2019 at 5:17 PM Alexei Starovoitov
wrote:
> On Tue, Jun 4, 2019 at 4:40 AM Baruch Siach wrote:
> > Merge commit 1c8c5a9d38f60 ("Merge
> > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
> > fix from commit 36f9814a494 ("bpf: fix uapi hole for 32
The bpf_redirect_map() helper used by XDP programs doesn't return any
indication of whether it can successfully redirect to the map index it was
given. Instead, BPF programs have to track this themselves, leading to
programs using duplicate maps to track which entries are populated in the
devmap.
When using the bpf_redirect_map() helper to redirect packets from XDP, the eBPF
program cannot currently know whether the redirect will succeed, which makes it
impossible to gracefully handle errors. To properly fix this will probably
require deeper changes to the way TX resources are allocated, bu
We don't currently allow lookups into a devmap from eBPF, because the map
lookup returns a pointer directly to the dev->ifindex, which shouldn't be
modifiable from eBPF.
However, being able to do lookups in devmaps is useful to know (e.g.)
whether forwarding to a specific interface is enabled. Cur
On 06/04/2019 04:54 PM, Daniel Borkmann wrote:
> On 06/03/2019 06:38 PM, Jonathan Lemon wrote:
>> Currently, the AF_XDP code uses a separate map in order to
>> determine if an xsk is bound to a queue. Instead of doing this,
>> have bpf_map_lookup_elem() return the queue_id, as a way of
>> indicati
On Tue, Jun 04, 2019 at 05:23:46PM +0200, Geert Uytterhoeven wrote:
> Hi Alexei,
>
> On Tue, Jun 4, 2019 at 5:17 PM Alexei Starovoitov
> wrote:
> > On Tue, Jun 4, 2019 at 4:40 AM Baruch Siach wrote:
> > > Merge commit 1c8c5a9d38f60 ("Merge
> > > git://git.kernel.org/pub/scm/linux/kernel/git/dave
On Tue, 4 Jun 2019 07:45:47 +0200 Heiner wrote:
> In preparation of factoring out firmware handling rename r8169.c to
> r8169_main.c.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Jesse Brandeburg
On Tue, 4 Jun 2019 07:46:44 +0200 Heiner wrote:
> Let's factor out firmware handling into a separate source code file.
> This simplifies reading the code and makes clearer what the interface
> between driver and firmware handling is.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Jesse Brandebu
On 4 Jun 2019, at 8:04, Maciej Fijalkowski wrote:
On Tue, 4 Jun 2019 10:06:36 +0200
Björn Töpel wrote:
On 2019-06-03 15:19, Maciej Fijalkowski wrote:
Let's get into the driver via ndo_bpf with command set to
XDP_SETUP_UMEM
with fill queue that already contains some available entries that
ca
On Tue, Jun 04, 2019 at 05:02:21PM +0200, Guillaume Nault wrote:
> On Tue, Jun 04, 2019 at 03:26:05PM +0200, Pablo Neira Ayuso wrote:
> > On Sun, Jun 02, 2019 at 03:13:47PM +0200, Guillaume Nault wrote:
> > > With commit 997dd9647164 ("net: IP6 defrag: use rbtrees in
> > > nf_conntrack_reasm.c"), n
On Fri, May 31, 2019 at 12:38:32AM +0200, Steinar H. Gunderson wrote:
> As a proof of concept (no error handling, probably poor performance, not
> implemented for IPv6, other issues?), this patch works and fixes my problem:
Hi,
Any comments on this?
/* Steinar */
--
Homepage: https://www.sesse.
On Tue, 04 Jun 2019 17:24:10 +0200
Toke Høiland-Jørgensen wrote:
> We don't currently allow lookups into a devmap from eBPF, because the map
> lookup returns a pointer directly to the dev->ifindex, which shouldn't be
> modifiable from eBPF.
>
> However, being able to do lookups in devmaps is use
On 2019-06-03 11:37 p.m., Heiner Kallweit wrote:
>> +/* Xilinx PHY wrongly indicates BMSR_ESTATEN = 0 even though
>> + * extended status registers are supported. So we force the PHY
>> + * features to PHY_GBIT_FEATURES in order to allow gigabit support
>> + * to be detected.
>> +
On Fri, 31 May 2019 14:12:15 +0200
Davide Caratti wrote:
> while at it, fix missing square bracket near 'ptype' and a typo in the
> action description (it's -> its).
>
> Signed-off-by: Davide Caratti
Applied. Thanks
On Mon, 3 Jun 2019 09:38:51 -0700
Jonathan Lemon wrote:
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue. Instead of doing this,
> have bpf_map_lookup_elem() return the queue_id, as a way of
> indicating that there is a valid entry at the map
On Thu, 30 May 2019 18:32:27 +0300
Baruch Siach wrote:
> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
> use the sys/sysinfo.h header for the sysinfo(2) system call. But since
> iproute2 carries a local version of the kernel struct sysinfo, this
> causes a collision wit
On Thu, 30 May 2019 18:32:27 +0300
Baruch Siach wrote:
> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
> use the sys/sysinfo.h header for the sysinfo(2) system call. But since
> iproute2 carries a local version of the kernel struct sysinfo, this
> causes a collision wit
> So it seems like what is missing is the ability of genphy_config_init to
> detect the bits in the extended status register for 1000Base-X and add
> the corresponding mode flags. It appears bit 15 for 1000Base-X full
> duplex is standardized in 802.3 Clause 22, so I would expect Linux
> should be
On Fri, 31 May 2019 11:34:46 +0200
Davide Caratti wrote:
> don't hardcode the 'pipe' control action, so that the following TDC test
>
> b776 - Replace simple action with invalid goto chain control
>
> can detect kernels that correctly validate 'goto chain' control action.
>
> CC: Andrea Claud
On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote:
> +struct mlxsw_sp_ptp_clock *
> +mlxsw_sp1_ptp_clock_init(struct mlxsw_sp *mlxsw_sp, struct device *dev)
> +{
> + u64 overflow_cycles, nsec, frac = 0;
> + struct mlxsw_sp_ptp_clock *clock;
> + int err;
> +
> + clock = kz
On Mon, Jun 03, 2019 at 03:12:44PM +0300, Ido Schimmel wrote:
> From: Shalom Toledo
>
> Test the PTP Physical Hardware Clock functionality using the "phc_ctl" (a
> part of "linuxptp").
>
> The test contains three sub-tests:
> * "settime" test
> * "adjtime" test
> * "adjfreq" test
This loo
While running selftest bpf: test_maps the kernel BUG found on i386 kernel
running on x86_64 machine Linux version 5.2.0-rc3-next-20190604
Full test log can be found in the below link [1]
# helper_fill_hashmap(261)FAILfailed to create hashmap err Cannot
allocate memory, flags 0x0
to
Kernel panic while running bpf: test_xdp_vlan.sh test case on
arm64 Juno hardware Linux version 5.2.0-rc3-next-20190604
bpf: test_xdp_vlan.sh
# --- 100.64.41.2 ping statistics ---
100.64.41.2: ping_statistics #
# 3 packets transmitted, 3 received, 0% packet loss, time 2049ms
packets: transmitted
On Fri, 31 May 2019, David Ahern wrote:
> On 5/31/19 6:24 AM, Alan Maguire wrote:
> > I was wondering if there is a way to pop multiple MPLS labels at
> > once for local delivery using iproute2?
> >
> > Adding multiple labels for encapsulation is supported via
> > label1/label2/... syntax, but I
On 6/3/19 7:56 PM, Tim Beale wrote:
> By default, packets received in another VRF should not be passed to an
> unbound socket in the default VRF. This patch updates the IPv4 UDP
> multicast logic to match the unicast VRF logic (in compute_score()),
> as well as the IPv6 mcast logic (in __udp_v6_is_
On Tue, 04 Jun 2019 07:57:48 +0100, David Woodhouse wrote:
> On Tue, 2019-06-04 at 02:15 +, Bshara, Nafea wrote:
> > On Jun 3, 2019, at 6:52 PM, Andrew Lunn wrote:
> > > > Any "SmartNIC" vendor has temptation of uAPI-level hand off to the
> > > > firmware (including my employer), we all run pr
On 4 Jun 2019, at 9:43, Jesper Dangaard Brouer wrote:
> On Mon, 3 Jun 2019 09:38:51 -0700
> Jonathan Lemon wrote:
>
>> Currently, the AF_XDP code uses a separate map in order to
>> determine if an xsk is bound to a queue. Instead of doing this,
>> have bpf_map_lookup_elem() return the queue_id,
On Tue, Jun 4, 2019 at 6:45 AM Stanislav Fomichev wrote:
>
> On 06/03, Stanislav Fomichev wrote:
> > > BTF is mandatory for _any_ new feature.
> > If something is easy to support without asking everyone to upgrade to
> > a bleeding edge llvm, why not do it?
> > So much for backwards compatibility
When the flow_offload infrastructure was added, per-action statistics,
which were previously possible for drivers to support in TC offload,
were not plumbed through, perhaps because the drivers in the tree did
not implement them.
In TC (and in the previous offload API) statistics are per-action,
Populated with the address of the struct tc_action from which it was made.
Required for support of shared counters (and possibly other shared per-
action entities in future).
Signed-off-by: Edward Cree
---
include/net/flow_offload.h | 1 +
net/sched/cls_api.c| 1 +
2 files changed, 2 in
When handling RTM_GETACTION (e.g. tc actions get/list), make a callback to
blocks with hardware offload of the action to update stats from hardware.
In order to support this, track each action/block binding by allocating a
struct tc_action_block_binding and adding it to a list on the action.
Sig
cls_matchall, cls_u32, and cls_bpf all have offloads as well, so they also
need to bind actions to blocks for RTM_GETACTION stats collection.
Signed-off-by: Edward Cree
---
net/sched/cls_bpf.c | 10 +-
net/sched/cls_matchall.c | 7 +++
net/sched/cls_u32.c | 7 +++
3
Drivers that support per-action stats should implement TC_ACTION_STATS
rather than TC_CLSFLOWER_STATS/TC_CLSMATCHALL_STATS.
Signed-off-by: Edward Cree
---
include/net/act_api.h | 5 +
include/net/flow_offload.h | 1 +
net/sched/act_api.c| 3 ++-
net/sched/cls_api.c| 1 +
On 2019-06-04 10:54 a.m., Andrew Lunn wrote:
>> So it seems like what is missing is the ability of genphy_config_init to
>> detect the bits in the extended status register for 1000Base-X and add
>> the corresponding mode flags. It appears bit 15 for 1000Base-X full
>> duplex is standardized in 802.
On Sat, Jun 1, 2019 at 9:22 PM Eli Britstein wrote:
>
>
> On 6/1/2019 1:50 AM, Cong Wang wrote:
> > On Fri, May 31, 2019 at 3:01 PM Davide Caratti wrote:
> >> Please note: this loop was here also before this patch (the 'goto again;'
> >> line is only patch context). It has been introduced with co
Hi Stephen,
On Tue, Jun 04 2019, Stephen Hemminger wrote:
> On Thu, 30 May 2019 18:32:27 +0300
> Baruch Siach wrote:
>
>> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
>> use the sys/sysinfo.h header for the sysinfo(2) system call. But since
>> iproute2 carries a local
On 04.06.2019 18:54, Andrew Lunn wrote:
>> So it seems like what is missing is the ability of genphy_config_init to
>> detect the bits in the extended status register for 1000Base-X and add
>> the corresponding mode flags. It appears bit 15 for 1000Base-X full
>> duplex is standardized in 802.3 Cla
On Tue, 4 Jun 2019 15:40:43 +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Signed-off-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
On Sat, Jun 1, 2019 at 9:22 PM Eli Britstein wrote:
>
> I think that's because QinQ, or VLAN is not an encapsulation. There is
> no outer/inner packets, and if you want to mangle fields in the packet
> you can do it and the result is well-defined.
Sort of, perhaps VLAN tags are too short to be ca
On Tue, 4 Jun 2019 15:40:44 +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Utilizes the devlink flash code.
>
> Suggested-by: Jakub Kicinski
> Signed-off-by: Jiri Pirko
Acked-by: Jakub Kicinski
All looks good too me now, thanks Jiri!
Hello all,
it appears that there is an issue with the content of the checksum field
in udp packets which are transmitted through a gue encapsulated ipip
tunnel over ipv6.
I spent the past few days with experimenting around with the gue
encapsulation capabilities for ipip tunnels in the linux
> If I remember the Marvell specs correctly, there was some bit to switch the
> complete register set to fibre mode.
Hi Heiner
The Marvell PHY has a second page for Fibre. It mostly mirrors the
normal registers, and you need to look at both pages to determine if
copper or fibre has link, etc. Fib
On Tue, Jun 04, 2019 at 10:25:23AM -0700, Jonathan Lemon wrote:
> On 4 Jun 2019, at 9:43, Jesper Dangaard Brouer wrote:
>
> > On Mon, 3 Jun 2019 09:38:51 -0700
> > Jonathan Lemon wrote:
> >
> >> Currently, the AF_XDP code uses a separate map in order to
> >> determine if an xsk is bound to a queu
On 2019-06-04 19:25, Jonathan Lemon wrote:
On 4 Jun 2019, at 9:43, Jesper Dangaard Brouer wrote:
On Mon, 3 Jun 2019 09:38:51 -0700
Jonathan Lemon wrote:
Currently, the AF_XDP code uses a separate map in order to
determine if an xsk is bound to a queue. Instead of doing this,
have bpf_map_lo
On 6/4/2019 8:55 PM, Cong Wang wrote:
> On Sat, Jun 1, 2019 at 9:22 PM Eli Britstein wrote:
>> I think that's because QinQ, or VLAN is not an encapsulation. There is
>> no outer/inner packets, and if you want to mangle fields in the packet
>> you can do it and the result is well-defined.
> Sort o
From: Jakub Kicinski
Date: Fri, 31 May 2019 20:11:59 -0700
> Take two of making sure we don't use a NULL netdev pointer
> for RX resync. This time using a bit and an open coded
> wait loop.
>
> Posting as revert + new patch, hopefully this will make it
> easier to backport to stable (unless thi
On Tue, 2019-06-04 at 15:40 +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Benefit from the devlink flash update implementation and ethtool
> fallback to it and move firmware flash implementation there.
>
> Signed-off-by: Jiri Pirko
Acked-by: Saeed Mahameed
Jesper Dangaard Brouer writes:
> On Tue, 04 Jun 2019 17:24:10 +0200
> Toke Høiland-Jørgensen wrote:
>
>> We don't currently allow lookups into a devmap from eBPF, because the map
>> lookup returns a pointer directly to the dev->ifindex, which shouldn't be
>> modifiable from eBPF.
>>
>> However,
From: Russell King
Date: Sun, 02 Jun 2019 15:12:54 +0100
> Avoid reducing the support mask as a result of the interface type
> selected for SFP modules, or when setting the link settings through
> ethtool - this should only change when the supported link modes of
> the hardware combination change
From: Vladimir Oltean
Date: Mon, 3 Jun 2019 00:11:52 +0300
> This patch series adds:
>
> - FDB switchdev support for the second generation of switches (P/Q/R/S).
> I could test/code these now that I got a board with a SJA1105Q.
>
> - Management route support for SJA1105 P/Q/R/S. This is need
On Tue, 04 Jun 2019 11:23:57 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski
> Date: Fri, 31 May 2019 20:11:59 -0700
>
> > Take two of making sure we don't use a NULL netdev pointer
> > for RX resync. This time using a bit and an open coded
> > wait loop.
> >
> > Posting as revert + new
1 - 100 of 230 matches
Mail list logo
