> On Jun 1, 2019, at 6:09 PM, Martin Lau wrote:
>
> On Sat, Jun 01, 2019 at 04:54:46PM -0700, Song Liu wrote:
>>
>>
>>> On May 31, 2019, at 3:29 PM, Martin KaFai Lau wrote:
>>>
>>> When the commit a6024562ffd7 ("udp: Add GRO functions to UDP socket")
>>> added udp[46]_lib_lookup_skb to the
Please ignore this patch. Have just realised I’ve sent completely
the wrong thing. Somehow managed to send the kernel space patch
again which is already accepted. I will send a v3 of the user space
patch shortly.
Apologies.
Kevin
> On 31 May 2019, at 09:10, ldir@icloud.com wrote:
>
> Fro
> On Jun 1, 2019, at 9:18 PM, Jonathan Lemon wrote:
>
>
>
> On 1 Jun 2019, at 16:05, Song Liu wrote:
>
>>> On May 31, 2019, at 11:57 AM, Jonathan Lemon
>>> wrote:
>>>
>>> Use the recent change to XSKMAP bpf_map_lookup_elem() to test if
>>> there is a xsk present in the map instead of dup
Hi Robert,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Robert-Hancock/Xilinx-axienet-driver-updates/20190602-124146
reproduce:
# apt-get install sparse
# sparse version
Use paged versions of phylib MDIO access functions to simplify
the code.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 105 +--
1 file changed, 33 insertions(+), 72 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/
On Dienstag, 19. Februar 2019 15:14:01 CEST Rob Herring wrote:
> > > How is this used?
> >
> > rtl8723bs-bt needs 2 firmware binaries -- one is actual firmware,
> > another is firmware config which is specific to the board. If
> > firmware-postfix is specified, driver appends it to the name of con
On Fri, 31 May 2019 10:34:03 -0700
Tom Herbert wrote:
> On Fri, May 31, 2019 at 10:07 AM Ahmed Abdelsalam
> wrote:
> >
> > On Fri, 31 May 2019 09:48:40 -0700
> > Tom Herbert wrote:
> >
> > > Mutable fields related to segment routing are: destination address,
> > > segments left, and modifiable
Hi David,
On Fri, May 31, 2019 at 02:26:15PM -0700, David Miller wrote:
> From: Phil Sutter
> Date: Wed, 29 May 2019 15:51:20 +0200
>
> > Unlike with bridges, one can't add an interface to a bond and set it up
> > at the same time:
> >
> > | # ip link set dummy0 down
> > | # ip link set dummy0
sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2,
otherwise the bc packets from $rp2 won't be forwarded. This patch is to
add this setting for $rp2.
Also, as ping_test_from does grep "$from" only, which could match some
unexpected output, some test case doesn't really work, l
With the topo:
h1 ---| rp1|
| route rp3 |--- h3 (192.168.200.1)
h2 ---| rp2|
If rp1 bc_forwarding is set while rp2 bc_forwarding is not, after
doing "ping 192.168.200.255" on h1, then ping 192.168.200.255 on
h2, and the packets can still be forwared.
In Jianlin's testing, netperf was broken with 'Connection reset by peer',
as the cookie check failed in rt6_check() and ip6_dst_check() always
returned NULL.
It's caused by Commit 93531c674315 ("net/ipv6: separate handling of FIB
entries from dst based routes"), where the cookie can be got only wh
With commit 997dd9647164 ("net: IP6 defrag: use rbtrees in
nf_conntrack_reasm.c"), nf_ct_frag6_reasm() is now called from
nf_ct_frag6_queue(). With this change, nf_ct_frag6_queue() can fail
after the skb has been added to the fragment queue and
nf_ct_frag6_gather() was adapted to handle this case.
From: wenxu
CONFIG_NETFILTER=m and CONFIG_NF_DEFRAG_IPV6 is not set
ERROR: "nf_ct_frag6_gather" [net/ipv6/ipv6.ko] undefined!
Fixes: c9bb6165a16e ("netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y")
Reported-by: kbuild test robot
Signed-off-by: wenxu
---
net/ipv6/netfilter.c | 4 +++-
1 fil
From: wenxu
CONFIG_NETFILTER=m and CONFIG_NF_DEFRAG_IPV6 is not set
ERROR: "nf_ct_frag6_gather" [net/ipv6/ipv6.ko] undefined!
Fixes: c9bb6165a16e ("netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y")
Reported-by: kbuild test robot
Signed-off-by: wenxu
---
v2: Forgot to include "net-next"
ne
On Thu, May 30, 2019 at 10:12:57AM +0200, Marc Haber wrote:
> on my primary notebook, a Lenovo X260, with an Intel Wireless 8260
> (8086:24f3), running Debian unstable, I have started to see network
> hangs since upgrading to kernel 5.1. In this situation, I cannot
> restart Network-Manager (the ca
Avoid reducing the support mask as a result of the interface type
selected for SFP modules, or when setting the link settings through
ethtool - this should only change when the supported link modes of
the hardware combination change.
Signed-off-by: Russell King
---
drivers/net/phy/phylink.c | 13
Some SFP modules do not like reads longer than 16 bytes, so read the
EEPROM in chunks of 16 bytes at a time. This behaviour is not specified
in the SFP MSAs, which specifies:
"The serial interface uses the 2-wire serial CMOS E2PROM protocol
defined for the ATMEL AT24C01A/02/04 family of compon
On Fri, May 31, 2019 at 06:17:51PM -0600, Robert Hancock wrote:
> Our device is mainly intended for fiber modules, which is why 1000BaseX
> is being used. The variant of fiber modules we are using (for example,
> Finisar FCLF8520P2BTL) are set up for 1000BaseX, and seem like they are
> kind of a ha
On Sun, Jun 2, 2019 at 2:54 AM Ahmed Abdelsalam wrote:
>
> On Fri, 31 May 2019 10:34:03 -0700
> Tom Herbert wrote:
>
> > On Fri, May 31, 2019 at 10:07 AM Ahmed Abdelsalam
> > wrote:
> > >
> > > On Fri, 31 May 2019 09:48:40 -0700
> > > Tom Herbert wrote:
> > >
> > > > Mutable fields related to s
syzbot reported nasty use-after-free [1]
Lets remove frag_list field from structs ip_fraglist_iter
and ip6_fraglist_iter. This seens not needed anyway.
[1] :
BUG: KASAN: use-after-free in kfree_skb_list+0x5d/0x60 net/core/skbuff.c:706
Read of size 8 at addr 888085a3cbc0 by task syz-executor30
ctinfo is an action restoring data stored in conntrack marks to various
fields. At present it has two independent modes of operation,
restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
marks into packet skb marks.
It understands a number of parameters specific to this action i
From: David Ahern
Date: Thu, 30 May 2019 12:06:36 -0700
> From: David Ahern
>
> Add functional test cases for nexthop objects.
>
> Signed-off-by: David Ahern
Applied, thanks.
From: Nirranjan Kirubaharan
Date: Thu, 30 May 2019 23:14:28 -0700
> + while (--ethqidx >= 0) {
> + --msi_index;
It is more canonical to use "msi_index--;" here.
Kevin Darbyshire-Bryant writes:
> ctinfo is an action restoring data stored in conntrack marks to various
> fields. At present it has two independent modes of operation,
> restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
> marks into packet skb marks.
>
> It understands a n
From: Wei Liu
Date: Fri, 31 May 2019 08:31:02 +0100
> Signed-off-by: Wei Liu
Applied.
This appends to the L2 Forwarding and L2 Forwarding Parameters tables
(originally added for first-generation switches) the bits that are new
in the second generation.
Signed-off-by: Vladimir Oltean
---
.../net/dsa/sja1105/sja1105_static_config.c | 18 ++---
.../net/dsa/sja1105/sja1105_
This patch series adds:
- FDB switchdev support for the second generation of switches (P/Q/R/S).
I could test/code these now that I got a board with a SJA1105Q.
- Management route support for SJA1105 P/Q/R/S. This is needed to send
PTP/STP/management frames over the CPU port.
- Logic to hide
Only a single dynamic configuration table of the SJA1105 P/Q/R/S
supports this operation: the FDB.
To keep the existing structure in place (sja1105_dynamic_config_read and
sja1105_dynamic_config_write) and not introduce any new function, a
convention is made for sja1105_dynamic_config_read that a
This structure is merely an implementation detail and should be hidden
from the sja1105_dynamic_config.h header, which provides to the rest of
the driver an abstract access to the dynamic configuration interface of
the switch.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105_dy
This was inadvertently copied from the SJA1105 E/T structure and not
tested. Cross-checking with the P/Q/R/S documentation (UM11040) makes
it immediately obvious what the correct bit offsets for this field are.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105_dynamic_config.c
The DSA callbacks were written with the E/T (first generation) in mind,
which is quite different.
For P/Q/R/S completely new implementations need to be provided, which
are held as function pointers in the priv->info structure. We are
taking a slightly roundabout way for this (a function from
sja1
These are needed in order to implement the switchdev FDB callbacks.
Compared to the E/T generation, not only the ABI (bit offsets) is
different, but also the introduction of the HOSTCMD field which permits
O(1) TCAM search for an FDB entry. Make use of the newly introduce
OP_SEARCH to permit that
Conceptually, if an entry is not found in the requested hardware table,
it is not an invalid request - so change the error returned
appropriately.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105_dynamic_config.c | 2 +-
drivers/net/dsa/sja1105/sja1105_main.c | 2 +-
Management routes are one-shot FDB rules installed on the CPU port for
sending link-local traffic. They are a prerequisite for STP, PTP etc to
work.
Also make a note that removing a management route was not supported on
the previous generation of switches.
Signed-off-by: Vladimir Oltean
---
..
This adds support for manipulating the L2 forwarding database (dump,
add, delete) for the second generation of NXP SJA1105 switches.
At the moment only FDB entries installed statically through 'bridge fdb'
are visible in the dump callback - the dynamically learned ones are
still under investigatio
This is a cosmetic patch that simplifies the code by removing a
redundant check. A logical AND-with-zero performed on a zero is still
zero.
Signed-off-by: Vladimir Oltean
---
drivers/net/dsa/sja1105/sja1105_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ne
TX VLANs and RX VLANs are an internal implementation detail of DSA for
frame tagging. They work by installing special VLANs on switch ports in
the operating modes where no behavior change w.r.t. VLANs can be
observed by the user.
Therefore it makes sense to hide these VLANs in the 'bridge fdb'
co
> On 2 Jun 2019, at 21:39, Toke Høiland-Jørgensen wrote:
>
> Kevin Darbyshire-Bryant writes:
>
>> ctinfo is an action restoring data stored in conntrack marks to various
>> fields. At present it has two independent modes of operation,
>> restoration of DSCP into IPv4/v6 diffserv and restorat
The hardware values for link speed are held in the sja1105_speed_t enum.
However they do not increase in the order that sja1105_get_speed_cfg was
iterating over them (basically from SJA1105_SPEED_AUTO - 0 - to
SJA1105_SPEED_1000MBPS - 1 - skipping the other two).
Another bug is that the code in sj
This patchset avoids two bugs in the logic handling of the enum
sja1105_speed_t which caused link speeds of 10 and 100 Mbps to not be
interpreted correctly and thus not be applied to the switch MACs.
v1 patchset can be found at:
https://www.spinics.net/lists/netdev/msg574477.html
Changes from v1:
On Fri, 31 May 2019 15:58:41 -0700, Andrii Nakryiko wrote:
> On Fri, May 31, 2019 at 2:28 PM Stanislav Fomichev wrote:
> > On 05/31, Andrii Nakryiko wrote:
> > > This patch adds support for a new way to define BPF maps. It relies on
> > > BTF to describe mandatory and optional attributes of a ma
On Mon, Jun 03, 2019 at 02:31:37AM +0300, Vladimir Oltean wrote:
> The hardware values for link speed are held in the sja1105_speed_t enum.
> However they do not increase in the order that sja1105_get_speed_cfg was
> iterating over them (basically from SJA1105_SPEED_AUTO - 0 - to
> SJA1105_SPEED_10
From: Willem de Bruijn
Date: Fri, 31 May 2019 12:37:23 -0400
> From: Willem de Bruijn
>
> Rollover used to use a complex RCU mechanism for assignment, which had
> a race condition. The below patch fixed the bug and greatly simplified
> the logic.
>
> The feature depends on fanout, but the stat
From: Florian Westphal
Date: Fri, 31 May 2019 18:27:02 +0200
> v3: fix typo in patch1 commit message
> All other patches are unchanged.
> v2: remove ifa_list iteration in afs instead of conversion
>
> Eric Dumazet reported following problem:
>
> It looks that unless RTNL is held, accessin
From: Heiner Kallweit
Date: Fri, 31 May 2019 19:14:44 +0200
> pci_device_to_OF_node(to_pci_dev(dev)) is the same as dev->of_node,
> so we can simplify the code. In addition add an empty line before
> the return statement.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: Heiner Kallweit
Date: Fri, 31 May 2019 19:17:15 +0200
> Use helper skb_is_gso() and simplify access to tx_dropped.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: David Ahern
Date: Fri, 31 May 2019 12:44:09 -0600
> From: David Ahern
>
> Add entry to MAINTAINERS file for new nexthop code.
>
> Signed-off-by: David Ahern
Applied.
From: Heiner Kallweit
Date: Fri, 31 May 2019 19:52:24 +0200
> This series removes most function pointers from struct rtl8169_private
> and uses direct calls instead. This simplifies the code and avoids
> the penalty of indirect calls in times of retpoline.
Series applied, thanks.
On 6/1/19 12:54 AM, Zhu Yanjun wrote:
The variable cache_allocs is to indicate how many frags (KiB) are in one
rds connection frag cache.
The command "rds-info -Iv" will output the rds connection cache
statistics as below:
"
RDS IB Connections:
LocalAddr RemoteAddr Tos SL LocalDev
On 6/1/19 12:05 AM, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: dfb569f2 net: ll_temac: Fix compile error
just an FYI: this is before any of my IPv6 changes in 5.2-next that are
relevant. At this commit the only IPv6 changes of mine are:
19a3b7eea424 ipv6
On 6/1/19 12:05 AM, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: f4aa8012 cxgb4: Make t4_get_tp_e2c_map static
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=1662cb12a0
> kernel config: https://syzkaller.appspot.c
From: David Ahern
Add struct nexthop and nh_list list_head to fib6_info. nh_list is the
fib6_info side of the nexthop <-> fib_info relationship. Since a fib6_info
referencing a nexthop object can not have 'sibling' entries (the old way
of doing multipath routes), the nh_list is a union with fib6_
From: David Ahern
Use helpers to access fib_nh and fib_nhs fields of a fib_info. Drop the
fib_dev macro which is an alias for the first nexthop. Replacements:
fi->fib_dev--> fib_info_nh(fi, 0)->fib_nh_dev
fi->fib_nh --> fib_info_nh(fi, 0)
fi->fib_nh[i] --> fib_info_nh(fi, i)
fi-
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
---
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
b/dr
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/ne
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
---
drivers/net/ethernet/rocker/rocker_main.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker_main.c
b/drivers/net/ethe
On 2019/6/3 11:03, santosh.shilim...@oracle.com wrote:
On 6/1/19 12:54 AM, Zhu Yanjun wrote:
The variable cache_allocs is to indicate how many frags (KiB) are in one
rds connection frag cache.
The command "rds-info -Iv" will output the rds connection cache
statistics as below:
"
RDS IB Connect
From: David Ahern
This sets adds 'struct nexthop' to fib_info and fib6_info. IPv4
already handles multiple fib_nh entries in a single fib_info, so
the conversion to use a nexthop struct is fairly mechanical. IPv6
using a nexthop struct with a fib6_info impacts a lot of core logic
which is built a
From: David Ahern
Convert more IPv4 code to use fib_nh_common over fib_nh to enable routes
to use a fib6_nh based nexthop. In the end, only code not using a
nexthop object in a fib_info should directly access fib_nh in a fib_info
without checking the famiy and going through fib_nh_common. Those
f
From: David Ahern
Add 'struct nexthop' and nh_list list_head to fib_info. nh_list is the
fib_info side of the nexthop <-> fib_info relationship.
Add fi_list list_head to 'struct nexthop' to track fib_info entries
using a nexthop instance. Add __remove_nexthop_fib and add it to
__remove_nexthop t
The variable cache_allocs is to indicate how many frags (KiB) are in one
rds connection frag cache.
The command "rds-info -Iv" will output the rds connection cache
statistics as below:
"
RDS IB Connections:
LocalAddr RemoteAddr Tos SL LocalDevRemoteDev
1.1.1.14 1.1.1.14 5
Thu, May 30, 2019 at 05:32:27PM CEST, bar...@tkos.co.il wrote:
>Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
>use the sys/sysinfo.h header for the sysinfo(2) system call. But since
>iproute2 carries a local version of the kernel struct sysinfo, this
>causes a collision w
On Mon, Jun 3, 2019 at 5:29 AM David Ahern wrote:
>
> On 6/1/19 12:05 AM, syzbot wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:f4aa8012 cxgb4: Make t4_get_tp_e2c_map static
> > git tree: net-next
> > console output: https://syzkaller.appspot.com/x/log
63 matches
Mail list logo
