[PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli --- drivers/net/ethernet/cadence/macb_main.c | 16 1 file changed, 8 insert

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Nicolas.Ferre
On 14/05/2019 at 09:14, Luca Ceresoli wrote: > External E-Mail > > > Errors are negative numbers. Using %u shows them as very large positive > numbers such as 4294967277 that don't make sense. Use the %d format > instead, and get a much nicer -19. > > Signed-off-by: Luca Ceresoli Indeed! Acked

Re: [PATCH net v2] rtnetlink: always put ILFA_LINK for links with a link-netnsid

2019-05-14 Thread Nicolas Dichtel
Le 13/05/2019 à 23:46, Sabrina Dubroca a écrit : > 2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote: >> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit : >>> 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote: Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit : > Currently, nla_put_iflink() do

mvpp2: oops on first received packet

2019-05-14 Thread Yanko Kaneti
Hello, I am trying to get some Fedora working on the MACCHIATObin SingleShot and I am getting an OOPS on what seems to be the first received packet on the gigabit port. I've tried both 5.0.x stable and 5.1.1 with the same result. Otherwise the port seems to work fine in u-boot (also latest from t

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-14 Thread Björn Töpel
On Mon, 13 May 2019 at 22:44, Jonathan Lemon wrote: > > Tossing in my .02 cents: > > > I anticipate that most users of AF_XDP will want packet processing > for a given RX queue occurring on a single core - otherwise we end > up with cache delays. The usual model is one thread, one socket, > one c

Re: [PATCH bpf 1/3] bpf: add map_lookup_elem_sys_only for lookups from syscall side

2019-05-14 Thread Daniel Borkmann
On 05/14/2019 07:04 AM, Andrii Nakryiko wrote: > On Mon, May 13, 2019 at 4:20 PM Daniel Borkmann wrote: >> >> Add a callback map_lookup_elem_sys_only() that map implementations >> could use over map_lookup_elem() from system call side in case the >> map implementation needs to handle the latter di

Re: [PATCH net v2] rtnetlink: always put ILFA_LINK for links with a link-netnsid

2019-05-14 Thread Sabrina Dubroca
2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote: > Le 13/05/2019 à 23:46, Sabrina Dubroca a écrit : > > 2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote: > >> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit : > >>> 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote: > Le 13/05/2019 à 15:47, S

[PATCH] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread YueHaibing
BUG: unable to handle kernel paging request at a018f000 PGD 3270067 P4D 3270067 PUD 3271063 PMD 2307eb067 PTE 0 Oops: [#1] PREEMPT SMP CPU: 0 PID: 4138 Comm: modprobe Not tainted 5.1.0-rc7+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qem

[RFC] vsock: proposal to support multiple transports at runtime

2019-05-14 Thread Stefano Garzarella
Hi guys, I'm currently interested on implement a multi-transport support for VSOCK in order to handle nested VMs. As Stefan suggested me, I started to look at this discussion: https://lkml.org/lkml/2017/8/17/551 Below I tried to summarize a proposal for a discussion, following the ideas from Dexua

Re: [RFC PATCH net-next 3/3] flow_offload: support CVLAN match

2019-05-14 Thread Jianbo Liu
The 05/13/2019 14:28, Edward Cree wrote: > On 13/05/2019 13:54, Jianbo Liu wrote: > > Could you please push to 5.1 and 5.0-stable? The original patch brought a > > bug > > in mlx5_core driver. Need your patch to fix. > > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > +++ b/drivers/n

[PATCH] NFC: Orphan the subsystem

2019-05-14 Thread Johannes Berg
Samuel clearly hasn't been working on this in many years and patches getting to the wireless list are just being ignored entirely now. Mark the subsystem as orphan to reflect the current state and revert back to the netdev list so at least some fixes can be picked up by Dave. Signed-off-by: Johann

[PATCH] net/mlx5e: Fix calling wrong function to get inner vlan key and mask

2019-05-14 Thread Jianbo Liu
When flow_rule_match_XYZ() functions were first introduced, flow_rule_match_cvlan() for inner vlan is missing. In mlx5_core driver, to get inner vlan key and mask, flow_rule_match_vlan() is just called, which is wrong because it obtains outer vlan information by FLOW_DISSECTOR_KEY_VLAN. This comm

Re: [PATCH bpf] libbpf: detect supported kernel BTF features and sanitize BTF

2019-05-14 Thread Lorenz Bauer
On Fri, 10 May 2019 at 17:19, Andrii Nakryiko wrote: > > On Fri, May 10, 2019 at 8:17 AM Lorenz Bauer wrote: > > > > On Fri, 10 May 2019 at 15:16, Andrii Nakryiko > > wrote: > > > > > > On Fri, May 10, 2019 at 2:46 AM Lorenz Bauer wrote: > > > > > > > > On Fri, 10 May 2019 at 05:37, Andrii Nak

Re: [PATCH] NFC: Orphan the subsystem

2019-05-14 Thread Andy Shevchenko
On Tue, May 14, 2019 at 11:02:31AM +0200, Johannes Berg wrote: > Samuel clearly hasn't been working on this in many years and > patches getting to the wireless list are just being ignored > entirely now. Mark the subsystem as orphan to reflect the > current state and revert back to the netdev list

Re: [PATCH] NFC: Orphan the subsystem

2019-05-14 Thread Johannes Berg
On Tue, 2019-05-14 at 13:02 +0300, Andy Shevchenko wrote: > On Tue, May 14, 2019 at 11:02:31AM +0200, Johannes Berg wrote: > > Samuel clearly hasn't been working on this in many years and > > patches getting to the wireless list are just being ignored > > entirely now. Mark the subsystem as orphan

Re: [PATCH net v2] rtnetlink: always put ILFA_LINK for links with a link-netnsid

2019-05-14 Thread Nicolas Dichtel
Le 14/05/2019 à 10:01, Sabrina Dubroca a écrit : > 2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote: [snip] >> What about this one? >> Fixes: d8a5ec672768 ("[NET]: netlink support for moving devices between >> network >> namespaces.") > > Nice. Now I think the bug can't really trigger unless one

Re: mvpp2: oops on first received packet

2019-05-14 Thread Jesper Dangaard Brouer
On Tue, 14 May 2019 10:29:31 +0300 Yanko Kaneti wrote: > Hello, > > I am trying to get some Fedora working on the MACCHIATObin SingleShot > and I am getting an OOPS on what seems to be the first received packet > on the gigabit port. > > I've tried both 5.0.x stable and 5.1.1 with the same resu

Re: [PATCH net v2] rtnetlink: always put ILFA_LINK for links with a link-netnsid

2019-05-14 Thread Sabrina Dubroca
2019-05-14, 12:05:16 +0200, Nicolas Dichtel wrote: > Le 14/05/2019 à 10:01, Sabrina Dubroca a écrit : > > 2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote: > [snip] > >> What about this one? > >> Fixes: d8a5ec672768 ("[NET]: netlink support for moving devices between > >> network > >> namespaces.

[PATCH net] net/mlx4_core: Change the error print to info print

2019-05-14 Thread wangyunjian
From: Yunjian Wang The error print within mlx4_flow_steer_promisc_add() should be a info print. Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device managed flow-steering') Signed-off-by: Yunjian Wang --- drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 +- 1 file changed, 1 ins

Re: [PATCH] net/smc: Fix error path in smc_init

2019-05-14 Thread Ursula Braun
On 5/14/19 8:39 AM, YueHaibing wrote: > If register_pernet_subsys success in smc_init, > we should cleanup it in case any other error. > Thanks, looks good. Your patch will be part of our next patch submission. Regards, Ursula > Fixes: 64e28b52c7a6 (net/smc: add pnet table namespace support"

Re: [PATCH net] net/mlx4_core: Change the error print to info print

2019-05-14 Thread Tariq Toukan
On 5/14/2019 2:03 PM, wangyunjian wrote: > From: Yunjian Wang > > The error print within mlx4_flow_steer_promisc_add() should > be a info print. > > Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device > managed flow-steering') > Signed-off-by: Yunjian Wang > --- > driver

[PATCH mlx5-next 2/2] net/mlx5: Set completion EQs as shared resources

2019-05-14 Thread Leon Romanovsky
From: Yishai Hadas Mark completion EQs as shared resources so that they can be used by CQs with uid != 0. Fixes: 7efce3691d33 ("IB/mlx5: Add obj create and destroy functionality") Signed-off-by: Yishai Hadas Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky --- drivers/net/etherne

[PATCH rdma-next 0/2] DevX fixes

2019-05-14 Thread Leon Romanovsky
From: Leon Romanovsky Hi, There are two very short but important fixes to DevX flows. Thanks Yishai Hadas (2): IB/mlx5: Verify DEVX general object type correctly net/mlx5: Set completion EQs as shared resources drivers/infiniband/hw/mlx5/devx.c| 13 ++--- drivers/net/

[PATCH rdma-next 1/2] IB/mlx5: Verify DEVX general object type correctly

2019-05-14 Thread Leon Romanovsky
From: Yishai Hadas As the obj_id in the firmware is not globally unique in general_object, the object type must be considered upon checking for a valid object id. Fixes: 2351776e87a1 ("IB/mlx5: Verify DEVX object type") Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky --- drivers/in

Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking

2019-05-14 Thread Peter Geis
On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit wrote: > > On 12.05.2019 04:50, Peter Geis wrote: > > On 5/11/2019 10:37 PM, Andrew Lunn wrote: > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote: > >>> Good Evening, > >>> > >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy

Re: [PATCH net v2] rtnetlink: always put ILFA_LINK for links with a link-netnsid

2019-05-14 Thread Nicolas Dichtel
Le 14/05/2019 à 12:24, Sabrina Dubroca a écrit : [snip] > Yes, that's possible although quite unlikely. I'll go with d8a5ec672768. > Agreed. Thank you, Nicolas

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-14 Thread Igor Russkikh
On 09.05.2019 12:08, Oliver Neukum wrote: > When writing to the phy on BE architectures an internal data structure > was directly given, leading to it being byte swapped in the wrong > way for the CPU in 50% of all cases. A temporary buffer must be used. > > Signed-off-by: Oliver Neukum > --- >

Re: [PATCH net-next RFC] Dump SW SQ context as part of tx reporter

2019-05-14 Thread Jiri Pirko
Sun, May 12, 2019 at 10:37:35AM CEST, a...@mellanox.com wrote: > > >On 5/9/2019 11:23 AM, Jiri Pirko wrote: >> Tue, May 07, 2019 at 02:58:32PM CEST, a...@mellanox.com wrote: >>> >>> >>> On 5/7/2019 3:41 PM, Jiri Pirko wrote: Mon, Apr 29, 2019 at 04:17:39PM CEST, a...@mellanox.com wrote: >

CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-14 Thread Leon Romanovsky
This is a call for proposals for the 4th RDMA mini-summit at the Linux Plumbers Conference in Lisbon, Portugal, which will be happening on September 9-11h, 2019. We are looking for topics with focus on active audience discussions and problem solving. The preferable topic is up to 30 minutes with 3

Re: mvpp2: oops on first received packet

2019-05-14 Thread Maxime Chevallier
Hi Yanko, >On Tue, 14 May 2019 10:29:31 +0300 >Yanko Kaneti wrote: > >> Hello, >> >> I am trying to get some Fedora working on the MACCHIATObin SingleShot >> and I am getting an OOPS on what seems to be the first received packet >> on the gigabit port. >> >> I've tried both 5.0.x stable and 5.1

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Andrew Lunn
On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: > Errors are negative numbers. Using %u shows them as very large positive > numbers such as 4294967277 that don't make sense. Use the %d format > instead, and get a much nicer -19. Hi Luca Do you consider this a fix? If so, it should

Re: [PATCH 1/3] aqc111: fix endianness issue in aqc111_change_mtu

2019-05-14 Thread Igor Russkikh
On 09.05.2019 12:08, Oliver Neukum wrote: > If the MTU is large enough, the first write to the device > is just repeated. On BE architectures, however, the first > word of the command will be swapped a second time and garbage > will be written. Avoid that. > > Signed-off-by: Oliver Neukum > ---

[PATCH] rtlwifi: Fix null-pointer dereferences in error handling code of rtl_pci_probe()

2019-05-14 Thread Jia-Ju Bai
*BUG 1: In rtl_pci_probe(), when rtlpriv->cfg->ops->init_sw_vars() fails, rtl_deinit_core() in the error handling code is executed. rtl_deinit_core() calls rtl_free_entries_from_scan_list(), which uses rtlpriv->scan_list.list in list_for_each_entry_safe(), but it has been initialized. Thus a null-p

Re: [PATCH v2 2/4] mfd: ioc3: Add driver for SGI IOC3 chip

2019-05-14 Thread Esben Haabendal
On Tue, 09 Apr 2019, Thomas Bogendoerfer wrote: > > diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c > b/drivers/net/ethernet/sgi/ioc3-eth.c > index 358e66b81926..21fe722ebcd8 100644 > --- a/drivers/net/ethernet/sgi/ioc3-eth.c > +++ b/drivers/net/ethernet/sgi/ioc3-eth.c > > [ ... ] > > -

[BUG] rtlwifi: Resource leaks in error handling code of rtl_pci_probe()

2019-05-14 Thread Jia-Ju Bai
In rtl_pci_probe(), rtl_pci_init() allocates some resources, such as: _rtl_pci_init_trx_ring _rtl_pci_init_rx_ring _rtl_pci_init_rx_ring pci_zalloc_consistent() -- resource _rtl_pci_init_one_rxdesc dev_alloc_skb() -- resource _rtl_pci_init_trx_ring _rtl_pci_init_tx_rin

[BUG] rtlwifi: a crash in error handling code of rtl_pci_probe()

2019-05-14 Thread Jia-Ju Bai
In rtl_pci_probe(), when request_irq() in rtl_pci_intr_mode_legacy() in rtl_pci_intr_mode_decide() fails, a crash occurs. The crash information is as follows: [ 108.271155] kasan: CONFIG_KASAN_INLINE enabled [ 108.271163] kasan: GPF could be caused by NULL-ptr deref or user memory access ...

[PATCH net v3] rtnetlink: always put IFLA_LINK for links with a link-netnsid

2019-05-14 Thread Sabrina Dubroca
Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when iflink == ifindex. In some cases, a device can be created in a different netns with the same ifindex as its parent. That device will not dump its IFLA_LINK attribute, which can confuse some userspace software that expects it. For

[PATCH net RESEND] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface") Fixes: 93b31f48b3ba ("net/

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Hi Andrew, On 14/05/19 14:35, Andrew Lunn wrote: > On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: >> Errors are negative numbers. Using %u shows them as very large positive >> numbers such as 4294967277 that don't make sense. Use the %d format >> instead, and get a much nicer -19.

Re: mvpp2: oops on first received packet

2019-05-14 Thread Yanko Kaneti
On Tue, 2019-05-14 at 14:32 +0200, Maxime Chevallier wrote: > Hi Yanko, > > > On Tue, 14 May 2019 10:29:31 +0300 > > Yanko Kaneti wrote: > > > > > Hello, > > > > > > I am trying to get some Fedora working on the MACCHIATObin SingleShot > > > and I am getting an OOPS on what seems to be the firs

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-14 Thread Oliver Neukum
On Di, 2019-05-14 at 12:11 +, Igor Russkikh wrote: > On 09.05.2019 12:08, Oliver Neukum wrote: > > When writing to the phy on BE architectures an internal data structure > > was directly given, leading to it being byte swapped in the wrong > > way for the CPU in 50% of all cases. A temporary bu

Re: [PATCH] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread Guillaume Nault
On Tue, May 14, 2019 at 03:43:00PM +0800, YueHaibing wrote: > > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before return. > Then the seconed modprobe will trigger crash like this.

Re: [PATCH v2 2/4] mfd: ioc3: Add driver for SGI IOC3 chip

2019-05-14 Thread Thomas Bogendoerfer
On Fri, 10 May 2019 08:14:19 +0100 Lee Jones wrote: > On Thu, 09 May 2019, Thomas Bogendoerfer wrote: > > > > + } > > > > + pr_err("ioc3: CRC error in NIC address\n"); > > > > +} > > > > > > This all looks like networking code. If this is the case, it should > > > be moved to driver

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Stefano Brivio
On Mon, 13 May 2019 23:12:31 -0700 Wei Wang wrote: > Thanks Mikael for reporting this issue. And thanks David for the bisection. > Let me spend some time to reproduce it and see what is going on. Mikael, by the way, once this is sorted out, it would be nice if you could add your test as a case i

Re: [PATCH] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread YueHaibing
On 2019/5/14 22:05, Guillaume Nault wrote: > On Tue, May 14, 2019 at 03:43:00PM +0800, YueHaibing wrote: >> >> If ppp_deflate fails to register in deflate_init, >> module initialization failed out, however >> ppp_deflate_draft may has been regiestred and not >> unregistered before return. >> Then t

Re: [PATCH net-next,RFC 1/2] net: flow_offload: add flow_block_cb API

2019-05-14 Thread Jiri Pirko
Thu, May 09, 2019 at 06:39:50PM CEST, pa...@netfilter.org wrote: >This patch renames: > >* struct tcf_block_cb to flow_block_cb. >* struct tc_block_offload to flow_block_offload. > >And it exposes the flow_block_cb API through net/flow_offload.h. This >renames the existing codebase to adapt it to t

[PATCH v2] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread YueHaibing
BUG: unable to handle kernel paging request at a018f000 PGD 3270067 P4D 3270067 PUD 3271063 PMD 2307eb067 PTE 0 Oops: [#1] PREEMPT SMP CPU: 0 PID: 4138 Comm: modprobe Not tainted 5.1.0-rc7+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qem

[PATCH] atm: iphase: Avoid copying pointers to user space.

2019-05-14 Thread Fuqian Huang
When ia_cmds.sub_cmd is MEMDUMP_DEV in ia_ioctl, nullify the pointer fields of iadev before copying the whole structure to user space. Signed-off-by: Fuqian Huang --- drivers/atm/iphase.c | 73 +--- 1 file changed, 70 insertions(+), 3 deletions(-)

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-14 Thread Srinivas Kandagatla
On 13/05/2019 12:16, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 11:06:48]: On 13/05/2019 10:07, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 09:25:55]: My initial idea was to add compatible strings to the cell so that most of the encoding information can be derived from

Re: [PATCH] NFC: Orphan the subsystem

2019-05-14 Thread Samuel Ortiz
Hi Johannes, On Tue, May 14, 2019 at 11:02:31AM +0200, Johannes Berg wrote: > Samuel clearly hasn't been working on this in many years and > patches getting to the wireless list are just being ignored > entirely now. Mark the subsystem as orphan to reflect the > current state and revert back to th

Re: [PATCH v2] ppp: deflate: Fix possible crash in deflate_init

2019-05-14 Thread Guillaume Nault
On Tue, May 14, 2019 at 10:55:32PM +0800, YueHaibing wrote: > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before return. > Thanks! Acked-by: Guillaume Nault

Re: [PATCH 5/5] net: phy: dp83867: Use unsigned variables to store unsigned properties

2019-05-14 Thread Trent Piepho
On Mon, 2019-05-13 at 23:43 +0200, Andrew Lunn wrote: > > > > > > Are there any in tree users of DP83867_CLK_O_SEL_REF_CLK? We have to > > > be careful changing its meaning. But if nobody is actually using it... > > > > Nope. I doubt this will affect anyone. They'd need to strap the phy > > to

Re: getneigh: add nondump to retrieve single entry

2019-05-14 Thread Roopa Prabhu
On Mon, May 13, 2019 at 9:04 AM wrote: > > From: Leonard Zgrablic > > Currently there is only a dump version of RTM_GETNEIGH for PF_UNSPEC in > RTNETLINK that dumps neighbor entries, no non-dump version that can be used to > retrieve a single neighbor entry. > > Add support for the non-dump (doit

[RFC net-next v2 01/14] net: stmmac: Add MAC loopback callback to HWIF

2019-05-14 Thread Jose Abreu
In preparation for the addition of selftests support for stmmac we add a new callback to HWIF that can be used to set the controller in loopback mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/

[RFC net-next v2 03/14] net: stmmac: dwmac1000: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac1000 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

[RFC net-next v2 02/14] net: stmmac: dwmac100: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac100 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c |

[RFC net-next v2 05/14] net: stmmac: dwxgmac2: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwxgmac2 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h |

[RFC net-next v2 13/14] net: stmmac: dwmac1000: Clear unused address entries

2019-05-14 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin La

[RFC net-next v2 06/14] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback

2019-05-14 Thread Jose Abreu
From: Corentin Labbe This patch enable use of set_mac_loopback in dwmac-sun8i Signed-off-by: Corentin Labbe Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 + 1

[RFC net-next v2 14/14] net: stmmac: dwmac4/5: Fix Hash Filter

2019-05-14 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Fout out while running stmmac selftests Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + driv

[RFC net-next v2 11/14] net: stmmac: Introduce selftests support

2019-05-14 Thread Jose Abreu
We add support for selftests on stmmac driver with 9 basic sanity checks for now: - MAC Loopback - PHY Loopback - MMC Counters - EEE - Hash Filter Multicast - Perfect Filter Unicast - Multicast Filter All - Unicast Filter All -

[RFC net-next v2 04/14] net: stmmac: dwmac4/5: Add MAC loopback support

2019-05-14 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac4/5 cores. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h |

[RFC net-next v2 08/14] net: stmmac: dwmac1000: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

[RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-14 Thread Jose Abreu
[ Submitting with net-next closed for proper review and testing. ] This introduces selftests support in stmmac driver. We add 9 basic sanity checks and MAC loopback support for all cores within the driver. This way more tests can easily be added in the future and can be run in virtually any MAC/GM

[RFC net-next v2 07/14] net: stmmac: Switch MMC functions to HWIF callbacks

2019-05-14 Thread Jose Abreu
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module so that correct callbacks are automatically selected. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/

[RFC net-next v2 12/14] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-14 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 +

[RFC net-next v2 09/14] net: stmmac: dwmac4/5: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

[RFC net-next v2 10/14] net: stmmac: dwxgmac2: Also pass control frames while in promisc mode

2019-05-14 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- dr

Re: [PATCH] net: Always descend into dsa/

2019-05-14 Thread Jiri Pirko
Mon, May 13, 2019 at 11:06:24PM CEST, f.faine...@gmail.com wrote: >Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y, >CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a >functional state where the mock-up driver is registered. Turns out that >we are not descending into

Re: [PATCH bpf] libbpf: detect supported kernel BTF features and sanitize BTF

2019-05-14 Thread Andrii Nakryiko
On Tue, May 14, 2019 at 2:24 AM Lorenz Bauer wrote: > > On Fri, 10 May 2019 at 17:19, Andrii Nakryiko > wrote: > > > > On Fri, May 10, 2019 at 8:17 AM Lorenz Bauer wrote: > > > > > > On Fri, 10 May 2019 at 15:16, Andrii Nakryiko > > > wrote: > > > > > > > > On Fri, May 10, 2019 at 2:46 AM Lor

Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking

2019-05-14 Thread Serge Semin
Hello Peter On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote: > On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit wrote: > > > > On 12.05.2019 04:50, Peter Geis wrote: > > > On 5/11/2019 10:37 PM, Andrew Lunn wrote: > > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote: > > >>

RE: [PATCH] hv_sock: Fix data loss upon socket close

2019-05-14 Thread Sunil Muthuswamy
> -Original Message- > From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of David Miller > Sent: Thursday, May 9, 2019 1:58 PM > To: Sunil Muthuswamy > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; Dexuan Cui > ; Michael Kelley ; > netdev@vger.ker

Re: [Intel-wired-lan] i40e X722 RSS problem with NAT-Traversal IPsec packets

2019-05-14 Thread Lennart Sorensen
On Mon, May 13, 2019 at 12:04:00PM -0700, Alexander Duyck wrote: > So I recreated the first packet you listed via text2pcap, replayed it > on my test system via tcpreplay, updated my configuration to 12 > queues, and used the 2 hash keys you listed. I ended up seeing the > traffic bounce between qu

Re: [PATCH bpf 1/3] bpf: add map_lookup_elem_sys_only for lookups from syscall side

2019-05-14 Thread Andrii Nakryiko
On Tue, May 14, 2019 at 12:59 AM Daniel Borkmann wrote: > > On 05/14/2019 07:04 AM, Andrii Nakryiko wrote: > > On Mon, May 13, 2019 at 4:20 PM Daniel Borkmann > > wrote: > >> > >> Add a callback map_lookup_elem_sys_only() that map implementations > >> could use over map_lookup_elem() from system

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev wrote: > > On 05/08, Stanislav Fomichev wrote: > > On 05/08, Alexei Starovoitov wrote: > > > On Wed, May 08, 2019 at 10:18:41AM -0700, Stanislav Fomichev wrote: > > > > Right now we are not using rcu api correctly: we pass __rcu pointers > > > >

Re: [PATCH net-next,RFC 2/2] netfilter: nf_tables: add hardware offload support

2019-05-14 Thread Jiri Pirko
Thu, May 09, 2019 at 06:39:51PM CEST, pa...@netfilter.org wrote: >This patch adds hardware offload support for nftables through the >existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER >classifier and the flow rule API. This hardware offload support is >available for the NFPROTO_N

Re: [PATCH bpf 0/3] BPF LRU map fix

2019-05-14 Thread Andrii Nakryiko
On Mon, May 13, 2019 at 4:19 PM Daniel Borkmann wrote: > > This set fixes LRU map eviction in combination with map lookups out > of system call side from user space. Main patch is the second one and > test cases are adapted and added in the last one. Thanks! > > Daniel Borkmann (3): > bpf: add m

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Alexei Starovoitov wrote: > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev wrote: > > > > On 05/08, Stanislav Fomichev wrote: > > > On 05/08, Alexei Starovoitov wrote: > > > > On Wed, May 08, 2019 at 10:18:41AM -0700, Stanislav Fomichev wrote: > > > > > Right now we are not using rc

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-14 Thread Petr Štetiar
Srinivas Kandagatla [2019-05-14 16:13:22]: > On 13/05/2019 12:16, Petr Štetiar wrote: > > Srinivas Kandagatla [2019-05-13 11:06:48]: > > > > > On 13/05/2019 10:07, Petr Štetiar wrote: > > > > Srinivas Kandagatla [2019-05-13 > > > > 09:25:55]: > > > > > > > > > My initial idea was to add comp

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 10:30:02AM -0700, Stanislav Fomichev wrote: > On 05/14, Alexei Starovoitov wrote: > > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev > > wrote: > > > > > > On 05/08, Stanislav Fomichev wrote: > > > > On 05/08, Alexei Starovoitov wrote: > > > > > On Wed, May 08, 2019 a

Re: [PATCH bpf 0/4] bpf: remove __rcu annotations from bpf_prog_array

2019-05-14 Thread Stanislav Fomichev
On 05/14, Alexei Starovoitov wrote: > On Tue, May 14, 2019 at 10:30:02AM -0700, Stanislav Fomichev wrote: > > On 05/14, Alexei Starovoitov wrote: > > > On Mon, May 13, 2019 at 11:57 AM Stanislav Fomichev > > > wrote: > > > > > > > > On 05/08, Stanislav Fomichev wrote: > > > > > On 05/08, Alexei S

Re: [PATCH bpf 0/3] BPF LRU map fix

2019-05-14 Thread Alexei Starovoitov
On Tue, May 14, 2019 at 10:24 AM Andrii Nakryiko wrote: > > On Mon, May 13, 2019 at 4:19 PM Daniel Borkmann wrote: > > > > This set fixes LRU map eviction in combination with map lookups out > > of system call side from user space. Main patch is the second one and > > test cases are adapted and a

Re: [RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-14 Thread David Miller
From: Jose Abreu Date: Tue, 14 May 2019 17:45:22 +0200 > [ Submitting with net-next closed for proper review and testing. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests can e

IP-Aliasing for IPv6?

2019-05-14 Thread M. Buecher
Preamble: I'm just a network hobbyist at home, so please bear with me if something in this mail is "stupid" from an expert's point of view. According to the documentation [1] "IP-Aliasing" is an obsolete way to manage multiple IP[v4]-addresses/masks on an interface. For having multiple IP[v4]-a

Re: [PATCH][next] iwlwifi: d3: Use struct_size() helper

2019-05-14 Thread Gustavo A. R. Silva
On 5/14/19 12:16 AM, Luciano Coelho wrote: > > Thanks! Applied to our internal tree and it will reach the mainline > following our normal upstreaming process. > Awesome. :) Thanks, Luciano. -- Gustavo

Re: IP-Aliasing for IPv6?

2019-05-14 Thread Heiner Kallweit
On 14.05.2019 20:49, M. Buecher wrote: > Preamble: I'm just a network hobbyist at home, so please bear with me if > something in this mail is "stupid" from an expert's point of view. > > According to the documentation [1] "IP-Aliasing" is an obsolete way to manage > multiple IP[v4]-addresses/mas

Re: [PATCH 2/5] rhashtable: reorder some inline functions and macros.

2019-05-14 Thread Jakub Kicinski
On Fri, 12 Apr 2019 11:52:08 +1000, NeilBrown wrote: > This patch only moves some code around, it doesn't > change the code at all. > A subsequent patch will benefit from this as it needs > to add calls to functions which are now defined before the > call-site, but weren't before. > > Signed-off-b

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Wei Wang
I think the bug is because when creating exceptions, src_addr is not always set even though fib6_info is in the subtree. (because of rt6_is_gw_or_nonexthop() check) However, when looking up for exceptions, we always set src_addr to the passed in flow->src_addr if fib6_info is in the subtree. That c

Re: [PATCH mlx5-next 2/2] net/mlx5: Set completion EQs as shared resources

2019-05-14 Thread Saeed Mahameed
On Tue, May 14, 2019 at 4:44 AM Leon Romanovsky wrote: > > From: Yishai Hadas > > Mark completion EQs as shared resources so that they can be used by CQs > with uid != 0. > > Fixes: 7efce3691d33 ("IB/mlx5: Add obj create and destroy functionality") > Signed-off-by: Yishai Hadas > Signed-off-by:

[PATCH net 0/2] flow_offload: fix CVLAN support

2019-05-14 Thread Edward Cree
When the flow_offload infrastructure was added, CVLAN matches weren't plumbed through, and flow_rule_match_vlan() was incorrectly called in the mlx5 driver when populating CVLAN match information. This series adds flow_rule_match_cvlan(), and uses it in the mlx5 code. Both patches should also g

[PATCH net 2/2] net/mlx5e: Fix calling wrong function to get inner vlan key and mask

2019-05-14 Thread Edward Cree
From: Jianbo Liu When flow_rule_match_XYZ() functions were first introduced, flow_rule_match_cvlan() for inner vlan is missing. In mlx5_core driver, to get inner vlan key and mask, flow_rule_match_vlan() is just called, which is wrong because it obtains outer vlan information by FLOW_DISSECTOR_K

[PATCH net 1/2] flow_offload: support CVLAN match

2019-05-14 Thread Edward Cree
Plumb it through from the flow_dissector. Signed-off-by: Edward Cree --- include/net/flow_offload.h | 2 ++ net/core/flow_offload.c| 7 +++ 2 files changed, 9 insertions(+) diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index 6200900434e1..a2df99f9b196 100644 --- a

RE: [PATCH] hv_sock: Fix data loss upon socket close

2019-05-14 Thread Sunil Muthuswamy
> -Original Message- > From: Dexuan Cui > Sent: Friday, May 10, 2019 8:57 PM > To: Sunil Muthuswamy ; KY Srinivasan > ; Haiyang Zhang ; > Stephen Hemminger ; Sasha Levin ; > David S. Miller ; > Michael Kelley > Cc: netdev@vger.kernel.org; linux-hyp...@vger.kernel.org; > linux-ker...

[PATCH bpf 2/2] selftests/bpf: add prog detach to flow_dissector test

2019-05-14 Thread Stanislav Fomichev
In case we are not running in a namespace (which we don't do by default), let's try to detach the bpf program that we use for eth_get_headlen tests. Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/

[PATCH] libertas/libertas_tf: fix spelling mistake "Donwloading" -> "Downloading"

2019-05-14 Thread Colin King
From: Colin Ian King There is are two spelling mistakes in lbtf_deb_usb2 messages, fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/libertas/if_usb.c| 2 +- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH bpf 1/2] selftests/bpf: add missing \n to flow_dissector CHECK errors

2019-05-14 Thread Stanislav Fomichev
Otherwise, in case of an error, everything gets mushed together. Fixes: a5cb33464e53 ("selftests/bpf: make flow dissector tests more extensible") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 8 1 file changed, 4 insertions(+), 4 deletio

Re: [PULL] vhost: cleanups and fixes

2019-05-14 Thread pr-tracker-bot
The pull request you sent on Tue, 14 May 2019 17:11:47 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/35c99ffa20edd3c24be352d28a63cd3a23121282 Thank you! -- Deet-doot-dot, I am a bot

[PATCH net] nfp: flower: add rcu locks when accessing netdev for tunnels

2019-05-14 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Add rcu locks when accessing netdev when processing route request and tunnel keep alive messages received from hardware. Fixes: 8e6a9046b66a ("nfp: flower vxlan neighbour offload") Fixes: 856f5b135758 ("nfp: flower vxlan neighbour keep-alive") Signed-off-by: Pieter

Re: [PATCH] net: Always descend into dsa/

2019-05-14 Thread David Miller
From: Florian Fainelli Date: Mon, 13 May 2019 14:06:24 -0700 > Jiri reported that with a kernel built with CONFIG_FIXED_PHY=y, > CONFIG_NET_DSA=m and CONFIG_NET_DSA_LOOP=m, we would not get to a > functional state where the mock-up driver is registered. Turns out that > we are not descending into

Re: [PATCH v2 net] tcp: fix retrans timestamp on passive Fast Open

2019-05-14 Thread David Miller
From: Yuchung Cheng Date: Mon, 13 May 2019 10:32:05 -0700 > Commit c7d13c8faa74 ("tcp: properly track retry time on > passive Fast Open") sets the start of SYNACK retransmission > time on passive Fast Open in "retrans_stamp". However the > timestamp is not reset upon the handshake has completed.

  1   2   >