Re: [PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-05 Thread Alexei Starovoitov
On Fri, May 3, 2019 at 2:09 PM Y Song wrote: > > On Fri, May 3, 2019 at 12:54 PM William Tu wrote: > > > > On Thu, May 2, 2019 at 1:18 PM Y Song wrote: > > > > > > On Thu, May 2, 2019 at 11:34 AM William Tu wrote: > > > > > > > > The libbpf_util.h is used by xsk.h, so add it to > > > > the inst

Re: [RFC PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-05 Thread Alexei Starovoitov
On Thu, May 2, 2019 at 5:08 PM Yonghong Song wrote: > > This patch tries to solve the following specific use case. > > Currently, bpf program can already collect stack traces > when certain events happens (e.g., cache miss counter or > cpu clock counter overflows). These stack traces can be > used

[devlink] 7d172b8be5: WARNING:at_net/core/devlink.c:#devlink_port_type_warn

2019-05-05 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: 7d172b8be57c2150fa5ce9642b677859aba7aec0 ("devlink: add warning in case driver does not set port type") bash: warning: in testcase: trinity with following parameters: runtime: 300s test-description: Trinity is a linux sys

Re: [PATCH v9 net-next 0/6] exthdrs: Make ext. headers & options useful - Part I

2019-05-05 Thread David Miller
From: Tom Herbert Date: Mon, 29 Apr 2019 16:15:11 -0700 > Extension headers are the mechanism of extensibility for the IPv6 > protocol, however to date they have only seen limited deployment. > The reasons for that are because intermediate devices don't handle > them well, and there haven't reall

Re: [PATCH v4 net-next 0/3] ipv4: Move location of pcpu route cache and exceptions

2019-05-05 Thread David Miller
From: David Ahern Date: Tue, 30 Apr 2019 07:45:47 -0700 > This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common > to make the caches available for IPv6 nexthops (fib6_nh) with IPv4 > routes. This allows a fib6_nh struct to be used with both IPv4 and > and IPv6 routes. ... Serie

Re: [PATCH net] net: phy: fix phy_validate_pause

2019-05-05 Thread David Miller
From: Heiner Kallweit Date: Wed, 1 May 2019 21:54:28 +0200 > We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't > need to be supported. Therefore extend the first check to check > for rx_pause being set. > > See also phy_set_asym_pause: > rx=0 and tx=1: advertise asym pause only >

[PATCH net-next v3 00/10] Traffic support for SJA1105 DSA driver

2019-05-05 Thread Vladimir Oltean
This patch set is a continuation of the "NXP SJA1105 DSA driver" v3 series, which was split in multiple pieces for easier review. Supporting a fully-featured (traffic-capable) driver for this switch requires some rework in DSA and also leaves behind a more generic infrastructure for other dumb swi

[PATCH net-next v3 01/10] net: dsa: Call driver's setup callback after setting up its switchdev notifier

2019-05-05 Thread Vladimir Oltean
This allows the driver to perform some manipulations of its own during setup, using generic switchdev calls. Having the notifiers registered at setup time is important because otherwise any switchdev transaction emitted during this time would be ignored (dispatched to an empty call chain). One cur

[PATCH net-next v3 03/10] net: dsa: Optional VLAN-based port separation for switches without tagging

2019-05-05 Thread Vladimir Oltean
This patch provides generic DSA code for using VLAN (802.1Q) tags for the same purpose as a dedicated switch tag for injection/extraction. It is based on the discussions and interest that has been so far expressed in https://www.spinics.net/lists/netdev/msg556125.html. Unlike all other DSA-support

[PATCH net-next v3 02/10] net: dsa: Export symbols for dsa_port_vid_{add,del}

2019-05-05 Thread Vladimir Oltean
This is needed so that the newly introduced tag_8021q may access these core DSA functions when built as a module. Reported-by: kbuild test robot Signed-off-by: Vladimir Oltean --- Changes in v3: - Patch is new. net/dsa/port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/dsa/port

[PATCH net-next v3 09/10] net: dsa: sja1105: Add support for Spanning Tree Protocol

2019-05-05 Thread Vladimir Oltean
While not explicitly documented as supported in UM10944, compliance with the STP states can be obtained by manipulating 3 settings at the (per-port) MAC config level: dynamic learning, inhibiting reception of regular traffic, and inhibiting transmission of regular traffic. In all these modes, tran

[PATCH net-next v3 10/10] Documentation: net: dsa: sja1105: Add info about supported traffic modes

2019-05-05 Thread Vladimir Oltean
This adds a table which illustrates what combinations of management / regular traffic work depending on the state the switch ports are in. Signed-off-by: Vladimir Oltean --- Changes in v3: - Added a commit description. Changes in v2: - Added clarification about bridging other netdevices with

[PATCH net-next v3 04/10] net: dsa: Allow drivers to filter packets they can decode source port from

2019-05-05 Thread Vladimir Oltean
Frames get processed by DSA and redirected to switch port net devices based on the ETH_P_XDSA multiplexed packet_type handler found by the network stack when calling eth_type_trans(). The running assumption is that once the DSA .rcv function is called, DSA is always able to decode the switch tag i

[PATCH net-next v3 07/10] net: dsa: Add a private structure pointer to dsa_port

2019-05-05 Thread Vladimir Oltean
This is supposed to share information between the driver and the tagger, or used by the tagger to keep some state. Its use is optional. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Reviewed-by: Vivien Didelot --- Changes in v3: - None. Changes in v2: - None. include/net/d

[PATCH net-next v3 05/10] net: dsa: Keep private info in the skb->cb

2019-05-05 Thread Vladimir Oltean
Map a DSA structure over the 48-byte control block that will hold skb info on transmit and receive. This is only for use within the DSA processing layer (e.g. communicating between DSA core and tagger) and not for passing info around with other layers such as the master net device. Also add a DSA_

[PATCH net-next v3 06/10] net: dsa: Add support for deferred xmit

2019-05-05 Thread Vladimir Oltean
Some hardware needs to take work to get convinced to receive frames on the CPU port (such as the sja1105 which takes temporary L2 forwarding rules over SPI that last for a single frame). Such work needs a sleepable context, and because the regular .ndo_start_xmit is atomic, this cannot be done in t

[PATCH net-next v3 08/10] net: dsa: sja1105: Add support for traffic through standalone ports

2019-05-05 Thread Vladimir Oltean
In order to support this, we are creating a make-shift switch tag out of a VLAN trunk configured on the CPU port. Termination of normal traffic on switch ports only works when not under a vlan_filtering bridge. Termination of management (PTP, BPDU) traffic works under all circumstances because it u

[PATCH net-next 0/2] r8169: replace some magic with more speaking functions

2019-05-05 Thread Heiner Kallweit
Based on info from Realtek replace some magic with speaking functions even though the exact meaning of certain values isn't known. Heiner Kallweit (2): r8169: add rtl_set_fifo_size r8169: add rtl8168g_set_pause_thresholds drivers/net/ethernet/realtek/r8169.c | 45 +---

[PATCH net-next 2/2] r8169: add rtl8168g_set_pause_thresholds

2019-05-05 Thread Heiner Kallweit
Based on info from Realtek add a function for defining the thresholds controlling ethernet flow control. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/realtek/r81

[PATCH net-next 1/2] r8169: add rtl_set_fifo_size

2019-05-05 Thread Heiner Kallweit
Based on info from Realtek replace FIFO size config magic with a function. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/ne

[PATCH net-next 0/2] Introduce net_prefetch

2019-05-05 Thread Tariq Toukan
Hi Dave, In this series, I first take the repeated code structure from net device drivers into a function. Then, I call it from mlx5e driver. Series generated against net-next commit: ca96534630e2 openvswitch: check for null pointer return from nla_nest_start_noflag Thanks, Tariq Tariq Toukan

[PATCH net-next 2/2] net/mlx5e: RX, Add a prefetch command for small L1_CACHE_BYTES

2019-05-05 Thread Tariq Toukan
A single cacheline might not contain the packet header for small L1_CACHE_BYTES values. Issue an additional prefetch in this case. Signed-off-by: Tariq Toukan Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core

[PATCH net-next 1/2] net: Take common prefetch code structure into a function

2019-05-05 Thread Tariq Toukan
Many device drivers use the same prefetch code structure to deal with small L1 cacheline size. Take this code into a function and call it from the drivers. Suggested-by: Jakub Kicinski Signed-off-by: Tariq Toukan Reviewed-by: Saeed Mahameed Cc: Jesper Dangaard Brouer --- drivers/net/ethernet/

[PATCH net-next 02/11] bnxt_en: Refactor bnxt_alloc_stats().

2019-05-05 Thread Michael Chan
From: Vasundhara Volam Reverse the condition of the large "if" block and return early. This will simplify the follow up patch to add PCIe statistics. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 75 +++

[PATCH net-next 01/11] bnxt_en: Update firmware interface to 1.10.0.69.

2019-05-05 Thread Michael Chan
PTP API updates for 57500 chips, new RX port stats counters and other miscellaneous updates. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 + drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 263 +- 2 files changed, 214 insertions(

[PATCH net-next 08/11] bnxt_en: Improve NQ reservations.

2019-05-05 Thread Michael Chan
bnxt_need_reserve_rings() determines if any resources have changed and requires new reservation with firmware. The NQ checking is currently just an approximation. Improve the NQ checking logic to make it accurate. NQ reservation is only needed on 57500 PFs. This fix will eliminate unnecessary r

[PATCH net-next 11/11] bnxt_en: Add device IDs 0x1806 and 0x1752 for 57500 devices.

2019-05-05 Thread Michael Chan
0x1806 and 0x1752 are VF variant and PF variant of the 57500 chip family. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index

[PATCH net-next 03/11] bnxt_en: Add support for PCIe statistics

2019-05-05 Thread Michael Chan
From: Vasundhara Volam Gather periodic PCIe statistics for ethtool -S. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 37 - drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 drivers/net/etherne

[PATCH net-next 00/11] bnxt_en: Driver updates.

2019-05-05 Thread Michael Chan
This patch series adds some extended statistics available with the new firmware interface, package version from firmware, aRFS support on 57500 chips, new PCI IDs, and some miscellaneous fixes and improvements. Devesh Sharma (1): bnxt_en: Separate RDMA MR/AH context allocation. Michael Chan (5)

[PATCH net-next 07/11] bnxt_en: Separate RDMA MR/AH context allocation.

2019-05-05 Thread Michael Chan
From: Devesh Sharma In newer firmware, the context memory for MR (Memory Region) and AH (Address Handle) to support RDMA are specified separately. Modify driver to specify and allocate the 2 context memory types separately when supported by the firmware. Signed-off-by: Devesh Sharma Signed-off-

[PATCH net-next 10/11] bnxt_en: Add support for aRFS on 57500 chips.

2019-05-05 Thread Michael Chan
Set RSS ring table index of the RFS destination ring for the NTUPLE filters on 57500 chips. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b

[PATCH net-next 04/11] bnxt_en: Check new firmware capability to display extended stats.

2019-05-05 Thread Michael Chan
From: Vasundhara Volam Newer firmware now advertises the capability for extended stats support. Check the new capability in addition to the existing version check. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++-- drivers/

[PATCH net-next 09/11] bnxt_en: Query firmware capability to support aRFS on 57500 chips.

2019-05-05 Thread Michael Chan
Query support for the aRFS ring table index in the firmware. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 43 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/n

[PATCH net-next 05/11] bnxt_en: Read package version from firmware.

2019-05-05 Thread Michael Chan
From: Vasundhara Volam HWRM_VER_GET firmware command returns package name that is running actively on the adapter. Use this version instead of parsing from the package log in NVRAM. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan diff --git a/main/Cumulus/drivers/linux/v3/bnxt.c

[PATCH net-next 06/11] bnxt_en: read the clause type from the PHY ID

2019-05-05 Thread Michael Chan
From: Vasundhara Volam Currently driver hard code Clause 45 based on speed supported by the PHY. Instead read the clause type from the PHY ID provided as input to the mdio ioctl. Fixes: 0ca12be99667 ("bnxt_en: Add support for mdio read/write to external PHY") Signed-off-by: Vasundhara Volam Sig

[PATCH iproute2-master] devlink: Fix monitor command

2019-05-05 Thread Ido Schimmel
From: Ido Schimmel The command is supposed to allow users to filter events related to certain objects, but returns an error when an object is specified: # devlink mon dev Command "dev" not found Fix this by allowing the command to process the specified objects. Example: # devlink/devlink mon

Re: [net-next 03/15] net/mlx5: Add Crdump FW snapshot support

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:00AM CEST, sae...@mellanox.com wrote: >From: Alex Vesker > >Crdump allows the driver to create a snapshot of the FW PCI crspace. >This is useful in case of catastrophic issues which may require FW >reset. The snapshot can be used for later debug. > >The snapshot is expos

Re: [net-next 07/15] net/mlx5: Issue SW reset on FW assert

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:18AM CEST, sae...@mellanox.com wrote: >From: Feras Daoud > >If a FW assert is considered fatal, indicated by a new bit in the health >buffer, reset the FW. After the reset go through the normal recovery >flow. Only one PF needs to issue the reset, so an attempt is made t

Re: [net-next 08/15] net/mlx5: Refactor print health info

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:21AM CEST, sae...@mellanox.com wrote: >From: Moshe Shemesh > >Refactor print health info code, split to two functions: > 1. mlx5_get_health_info() - writes the health info into a buffer. > 2. mlx5_print_health_info() - prints the health info to kernel log. >This refactor

Re: [PATCH v9 net-next 0/6] exthdrs: Make ext. headers & options useful - Part I

2019-05-05 Thread Tom Herbert
On Sun, May 5, 2019 at 12:45 AM David Miller wrote: > > From: Tom Herbert > Date: Mon, 29 Apr 2019 16:15:11 -0700 > > > Extension headers are the mechanism of extensibility for the IPv6 > > protocol, however to date they have only seen limited deployment. > > The reasons for that are because inte

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.com wrote: >From: Moshe Shemesh > >Create mlx5_devlink_health_reporter for FW reporter. The FW reporter >implements devlink_health_reporter diagnose callback. > >The fw reporter diagnose command can be triggered any time by the user >to check c

Re: [net-next 11/15] net/mlx5: Add support for FW reporter dump

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:27AM CEST, sae...@mellanox.com wrote: >From: Moshe Shemesh > >Add support of dump callback for mlx5 FW reporter. >Once we trigger FW dump, the FW will write the core dump to its raw data >buffer. The tracer translates the raw data to traces and save it to a >buffer. Once

Re: [net-next 14/15] net/mlx5: Add support for FW fatal reporter dump

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 02:33:33AM CEST, sae...@mellanox.com wrote: >From: Moshe Shemesh > >Add support of dump callback for mlx5 FW fatal reporter. >The FW fatal dump use cr-dump functionality to gather cr-space data for >debug. The cr-dump uses vsc interface which is valid even if the FW >command i

Re: [PATCH iproute2-master] devlink: Fix monitor command

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 04:12:43PM CEST, ido...@idosch.org wrote: >From: Ido Schimmel > >The command is supposed to allow users to filter events related to >certain objects, but returns an error when an object is specified: > ># devlink mon dev >Command "dev" not found > >Fix this by allowing the com

Re: [devlink] 7d172b8be5: WARNING:at_net/core/devlink.c:#devlink_port_type_warn

2019-05-05 Thread Jiri Pirko
Sun, May 05, 2019 at 09:38:56AM CEST, l...@intel.com wrote: >FYI, we noticed the following commit (built with gcc-7): > >commit: 7d172b8be57c2150fa5ce9642b677859aba7aec0 ("devlink: add warning in >case driver does not set port type") >bash: warning: > >in testcase: trinity >with following paramete

[PATCH net-next 4/7] ipv4: Add function to send route updates

2019-05-05 Thread David Ahern
From: David Ahern Add fib_info_notify_update to walk the fib and send RTM_NEWROUTE notifications with NLM_F_REPLACE set for entries linked to a fib_info that have nh_updated flag set. This helper will be used by the nexthop code to notify userspace of routes that are impacted when a nexthop confi

[PATCH net-next 7/7] ipv4: export fib_info_update_nh_saddr

2019-05-05 Thread David Ahern
From: David Ahern Add scope as input argument versus relying on fib_info reference in fib_nh, and export fib_info_update_nh_saddr. Signed-off-by: David Ahern --- include/net/ip_fib.h | 3 ++- net/ipv4/fib_semantics.c | 11 +-- 2 files changed, 7 insertions(+), 7 deletions(-) diff

[PATCH net-next 2/7] ipv6: Add hook to bump sernum for a route to stubs

2019-05-05 Thread David Ahern
From: David Ahern Add hook to ipv6 stub to bump the sernum up to the root node for a route. This is needed by the nexthop code when a nexthop config changes. Signed-off-by: David Ahern --- include/net/ip6_fib.h| 1 + include/net/ipv6_stubs.h | 1 + net/ipv6/af_inet6.c | 1 + net/ipv6/

[PATCH net-next 5/7] ipv4: export fib_check_nh

2019-05-05 Thread David Ahern
From: David Ahern Change fib_check_nh to take net, table and scope as input arguments over struct fib_config and export for use by nexthop code. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 ++ net/ipv4/fib_semantics.c | 12 ++-- 2 files changed, 8 insertions(+), 6 dele

[PATCH net-next 1/7] ipv6: Add delete route hook to stubs

2019-05-05 Thread David Ahern
From: David Ahern Add ip6_del_rt to the IPv6 stub. The hook is needed by the nexthop code to remove entries linked to a nexthop that is getting deleted. Signed-off-by: David Ahern --- include/net/ipv6_stubs.h | 1 + net/ipv6/addrconf_core.c | 6 ++ net/ipv6/af_inet6.c | 1 + 3 files c

[PATCH net-next 6/7] ipv4: export fib_flush

2019-05-05 Thread David Ahern
From: David Ahern As nexthops are deleted, fib entries referencing it are marked dead. Export fib_flush so those entries can be removed in a timely manner. Signed-off-by: David Ahern --- include/net/ip_fib.h| 1 + net/ipv4/fib_frontend.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion

[PATCH net-next 3/7] ipv6: export function to send route updates

2019-05-05 Thread David Ahern
From: David Ahern Add fib6_rt_update to send RTM_NEWROUTE with NLM_F_REPLACE set. This helper will be used by the nexthop code to notify userspace of routes that are impacted when a nexthop config is updated via replace. This notification is needed for legacy apps that do not understand the new

[PATCH net-next 0/7] net: Export functions for nexthop code

2019-05-05 Thread David Ahern
From: David Ahern This set exports ipv4 and ipv6 fib functions for use by the nexthop code. It also adds new ones to send route notifications if a nexthop configuration changes. David Ahern (7): ipv6: Add delete route hook to stubs ipv6: Add hook to bump sernum for a route to stubs ipv6: e

Re: [PATCH net-next v3 02/10] net: dsa: Export symbols for dsa_port_vid_{add,del}

2019-05-05 Thread Florian Fainelli
On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > This is needed so that the newly introduced tag_8021q may access these > core DSA functions when built as a module. > > Reported-by: kbuild test robot > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 06/10] net: dsa: Add support for deferred xmit

2019-05-05 Thread Florian Fainelli
On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > Some hardware needs to take work to get convinced to receive frames on > the CPU port (such as the sja1105 which takes temporary L2 forwarding > rules over SPI that last for a single frame). Such work needs a > sleepable context, and because the regu

Re: [PATCH net-next v3 04/10] net: dsa: Allow drivers to filter packets they can decode source port from

2019-05-05 Thread Florian Fainelli
On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > Frames get processed by DSA and redirected to switch port net devices > based on the ETH_P_XDSA multiplexed packet_type handler found by the > network stack when calling eth_type_trans(). > > The running assumption is that once the DSA .rcv function

[PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
So far we report symmetric pause only, and we don't consider the local pause capabilities. Let's properly consider local and remote capabilities, and report also asymmetric pause. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 28 +++- 1 file changed, 27 inser

Re: [RFC] folding socket->wq into struct socket

2019-05-05 Thread David Miller
From: Al Viro Date: Thu, 2 May 2019 17:32:23 +0100 > it appears that we might take freeing the socket itself to the > RCU-delayed part, along with socket->wq. And doing that has > an interesting benefit - the only reason to do two separate > allocation disappears. I'm pretty sure we looked into

Re: [PATCH net-next v3 10/10] Documentation: net: dsa: sja1105: Add info about supported traffic modes

2019-05-05 Thread Florian Fainelli
On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > This adds a table which illustrates what combinations of management / > regular traffic work depending on the state the switch ports are in. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli I have finally put my brain on and unde

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 10:03 AM, Heiner Kallweit wrote: > So far we report symmetric pause only, and we don't consider the local > pause capabilities. Let's properly consider local and remote > capabilities, and report also asymmetric pause. I would go one step further which is to print what is the link s

Re: [PATCH net-next] drivers: net: davinci_mdio: fix return value check in davinci_mdio_probe()

2019-05-05 Thread David Miller
From: Wei Yongjun Date: Fri, 3 May 2019 11:18:59 + > In case of error, the function devm_ioremap() returns NULL pointer not > ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_iorema

Re: [PATCH net] net: atm: clean up a range check

2019-05-05 Thread David Miller
From: Dan Carpenter Date: Fri, 3 May 2019 15:39:48 +0300 > The code works fine but the problem is that check for negatives is a > no-op: > > if (arg < 0) > i = 0; > > The "i" value isn't used. We immediately overwrite it with: > > i = array_index_nospec(arg, MAX_LEC_

Re: [RFC PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-05 Thread Yonghong Song
On 5/5/19 12:29 AM, Alexei Starovoitov wrote: > On Thu, May 2, 2019 at 5:08 PM Yonghong Song wrote: >> >> This patch tries to solve the following specific use case. >> >> Currently, bpf program can already collect stack traces >> when certain events happens (e.g., cache miss counter or >> cpu cl

Re: [PATCH 1/2 net-next] net: ll_temac: Fix an NULL vs IS_ERR() check in temac_open()

2019-05-05 Thread David Miller
From: Dan Carpenter Date: Fri, 3 May 2019 15:50:24 +0300 > The phy_connect() function doesn't return NULL pointers. It returns > error pointers on error, so I have updated the check. > > Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree > platforms") > Signed-off-by: Dan C

Re: [PATCH 2/2 net-next] net: ll_temac: remove an unnecessary condition

2019-05-05 Thread David Miller
From: Dan Carpenter Date: Fri, 3 May 2019 15:50:51 +0300 > The "pdata->mdio_bus_id" is unsigned so this condition is always true. > This patch just removes it. > > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 19:10, Florian Fainelli wrote: > > > On 5/5/2019 10:03 AM, Heiner Kallweit wrote: >> So far we report symmetric pause only, and we don't consider the local >> pause capabilities. Let's properly consider local and remote >> capabilities, and report also asymmetric pause. > > I would

Re: [PATCH net-next 10/13] net/sched: add block pointer to tc_cls_common_offload structure

2019-05-05 Thread Jakub Kicinski
On Sat, 4 May 2019 15:16:54 +0200, Jiri Pirko wrote: > Sat, May 04, 2019 at 01:46:25PM CEST, jakub.kicin...@netronome.com wrote: > >From: Pieter Jansen van Vuuren > > > >Some actions like the police action are stateful and could share state > >between devices. This is incompatible with offloading

Re: [PATCH net-next 0/4] net: extend indirect calls helper usage

2019-05-05 Thread David Miller
From: Paolo Abeni Date: Fri, 3 May 2019 17:01:35 +0200 > This series applies the indirect calls helper introduced with commit > 283c16a2dfd3 ("indirect call wrappers: helpers to speed-up indirect > calls of builtin") to more hooks inside the network stack. > > Overall this avoids up to 4 indi

Re: [PATCH v2 net] ip6: fix skb leak in ip6frag_expire_frag_queue()

2019-05-05 Thread David Miller
From: Eric Dumazet Date: Fri, 3 May 2019 08:24:44 -0700 > Since ip6frag_expire_frag_queue() now pulls the head skb > from frag queue, we should no longer use skb_get(), since > this leads to an skb leak. > > Stefan Bader initially reported a problem in 4.4.stable [1] caused > by the skb_get(),

Re: [PATCH v2 net] neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit

2019-05-05 Thread David Miller
From: David Ahern Date: Fri, 3 May 2019 08:55:01 -0700 > From: David Ahern > > Commit cd9ff4de0107 changed the key for IFF_POINTOPOINT devices to > INADDR_ANY, but neigh_xmit which is used for MPLS encapsulations was not > updated to use the altered key. The result is that every packet Tx does

Re: [PATCH v2 net] neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit

2019-05-05 Thread David Ahern
On 5/5/19 11:42 AM, David Miller wrote: > From: David Ahern > Date: Fri, 3 May 2019 08:55:01 -0700 > >> From: David Ahern >> >> Commit cd9ff4de0107 changed the key for IFF_POINTOPOINT devices to >> INADDR_ANY, but neigh_xmit which is used for MPLS encapsulations was not >> updated to use the al

Re: [PATCH net] um: vector netdev: adjust to xmit_more API change

2019-05-05 Thread David Miller
From: Johannes Berg Date: Fri, 3 May 2019 20:21:33 +0200 > From: Johannes Berg > > Replace skb->xmit_more usage by netdev_xmit_more(). > > Fixes: 4f296edeb9d4 ("drivers: net: aurora: use netdev_xmit_more helper") > Signed-off-by: Johannes Berg Seems to be a net-next only change, so I applie

Re: [PATCH net-next] net: mvpp2: cls: Remove set but not used variable 'act'

2019-05-05 Thread David Miller
From: YueHaibing Date: Sat, 4 May 2019 04:04:05 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c: In function > 'mvpp2_cls_c2_build_match': > drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1159:28: warning: > variable 'act' set but not u

Re: [PATCH net-next] r8169: make use of phy_set_asym_pause

2019-05-05 Thread David Miller
From: Heiner Kallweit Date: Sat, 4 May 2019 12:01:03 +0200 > phy_probe() takes care that all supported modes are advertised, > in addition use phy_support_asym_pause() to advertise pause modes. > This way we don't have to deal with phylib internals directly. > > Signed-off-by: Heiner Kallweit

Re: [PATCH net-next] r8169: speed up rtl_loop_wait

2019-05-05 Thread David Miller
From: Heiner Kallweit Date: Sat, 4 May 2019 15:20:38 +0200 > When testing I figured out that most operations signal finish even > before we trigger the first delay. Seems like PCI(e) access and > memory barriers typically add enough latency. Therefore move the > first delay after the first check.

Re: [PATCH v2 net] neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit

2019-05-05 Thread David Miller
From: David Ahern Date: Sun, 5 May 2019 11:43:39 -0600 > oops on the double signoff; you actually took v1 so I need to send a delta. Aha, I see, thanks for catching that.

Re: [RFC] folding socket->wq into struct socket

2019-05-05 Thread Al Viro
On Sun, May 05, 2019 at 10:04:21AM -0700, David Miller wrote: > From: Al Viro > Date: Thu, 2 May 2019 17:32:23 +0100 > > > it appears that we might take freeing the socket itself to the > > RCU-delayed part, along with socket->wq. And doing that has > > an interesting benefit - the only reason t

Re: [Patch net-next v2] sch_htb: redefine htb qdisc overlimits

2019-05-05 Thread Eric Dumazet
On 5/4/19 2:43 PM, Cong Wang wrote: > In commit 3c75f6ee139d ("net_sched: sch_htb: add per class overlimits > counter") > we added an overlimits counter for each HTB class which could > properly reflect how many times we use up all the bandwidth > on each class. However, the overlimits counter

[PATCH net] ipv4: Define __ipv4_neigh_lookup_noref when CONFIG_INET is disabled

2019-05-05 Thread David Ahern
From: David Ahern Define __ipv4_neigh_lookup_noref to return NULL when CONFIG_INET is disabled. Fixes: 4b2a2bfeb3f0 ("neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit") Reported-by: kbuild test robot Signed-off-by: David Ahern --- include/net/arp.h | 8 1 file changed, 8 insert

Re: [PATCH net] ipv4: Define __ipv4_neigh_lookup_noref when CONFIG_INET is disabled

2019-05-05 Thread David Miller
From: David Ahern Date: Sun, 5 May 2019 11:16:20 -0700 > From: David Ahern > > Define __ipv4_neigh_lookup_noref to return NULL when CONFIG_INET is disabled. > > Fixes: 4b2a2bfeb3f0 ("neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit") > Reported-by: kbuild test robot > Signed-off-by: Da

Re: [RFC] folding socket->wq into struct socket

2019-05-05 Thread David Miller
From: Al Viro Date: Sun, 5 May 2019 18:59:43 +0100 > On Sun, May 05, 2019 at 10:04:21AM -0700, David Miller wrote: >> From: Al Viro >> Date: Thu, 2 May 2019 17:32:23 +0100 >> >> > it appears that we might take freeing the socket itself to the >> > RCU-delayed part, along with socket->wq. And d

Re: [PATCH net-next v3 04/10] net: dsa: Allow drivers to filter packets they can decode source port from

2019-05-05 Thread Vladimir Oltean
On Sun, 5 May 2019 at 20:02, Florian Fainelli wrote: > > > > On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > > Frames get processed by DSA and redirected to switch port net devices > > based on the ETH_P_XDSA multiplexed packet_type handler found by the > > network stack when calling eth_type_trans(

Re: [PATCH net-next v3 10/10] Documentation: net: dsa: sja1105: Add info about supported traffic modes

2019-05-05 Thread Vladimir Oltean
On Sun, 5 May 2019 at 20:04, Florian Fainelli wrote: > > > > On 5/5/2019 3:19 AM, Vladimir Oltean wrote: > > This adds a table which illustrates what combinations of management / > > regular traffic work depending on the state the switch ports are in. > > > > Signed-off-by: Vladimir Oltean > > Re

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 10:31 AM, Heiner Kallweit wrote: > On 05.05.2019 19:10, Florian Fainelli wrote: >> >> >> On 5/5/2019 10:03 AM, Heiner Kallweit wrote: >>> So far we report symmetric pause only, and we don't consider the local >>> pause capabilities. Let's properly consider local and remote >>> capabi

pull request: bluetooth-next 2019-05-05

2019-05-05 Thread Johan Hedberg
Hi Dave, Here's one more bluetooth-next pull request for 5.2: - Fixed Command Complete event handling check for matching opcode - Added support for Qualcomm WCN3998 controller, along with DT bindings - Added default address for Broadcom BCM2076B1 controllers Please let me know if there are an

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 12:06 PM, Heiner Kallweit wrote: > On 05.05.2019 20:46, Florian Fainelli wrote: >> >> >> On 5/5/2019 10:31 AM, Heiner Kallweit wrote: >>> On 05.05.2019 19:10, Florian Fainelli wrote: On 5/5/2019 10:03 AM, Heiner Kallweit wrote: > So far we report symmetric pause on

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 20:46, Florian Fainelli wrote: > > > On 5/5/2019 10:31 AM, Heiner Kallweit wrote: >> On 05.05.2019 19:10, Florian Fainelli wrote: >>> >>> >>> On 5/5/2019 10:03 AM, Heiner Kallweit wrote: So far we report symmetric pause only, and we don't consider the local pause capabilit

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 21:12, Florian Fainelli wrote: > > > On 5/5/2019 12:06 PM, Heiner Kallweit wrote: >> On 05.05.2019 20:46, Florian Fainelli wrote: >>> >>> >>> On 5/5/2019 10:31 AM, Heiner Kallweit wrote: On 05.05.2019 19:10, Florian Fainelli wrote: > > > On 5/5/2019 10:03 AM, Heiner

Re: pull request: bluetooth-next 2019-05-05

2019-05-05 Thread David Miller
From: Johan Hedberg Date: Sun, 5 May 2019 22:12:03 +0300 > Here's one more bluetooth-next pull request for 5.2: > > - Fixed Command Complete event handling check for matching opcode > - Added support for Qualcomm WCN3998 controller, along with DT bindings > - Added default address for Broadco

[PATCH v2 0/5] net: dsa: lantiq: Add bridge offloading

2019-05-05 Thread Hauke Mehrtens
This adds bridge offloading for the Intel / Lantiq GSWIP 2.1 switch. Changes since: v1: - fix typo signle -> single Hauke Mehrtens (5): net: dsa: lantiq: Allow special tags only on CPU port net: dsa: lantiq: Add VLAN unaware bridge offloading net: dsa: lantiq: Add VLAN aware bridge offload

[PATCH v2 3/5] net: dsa: lantiq: Add VLAN aware bridge offloading

2019-05-05 Thread Hauke Mehrtens
The VLAN aware bridge offloading is similar to the VLAN unaware offloading, this makes it possible to offload the VLAN bridge functionalities. The hardware supports up to 64 VLAN bridge entries, we already use one entry for each LAN port to prevent forwarding of packets between the ports when the

[PATCH v2 1/5] net: dsa: lantiq: Allow special tags only on CPU port

2019-05-05 Thread Hauke Mehrtens
Allow the special tag in ingress only on the CPU port and not on all ports. A packet with a special tag could circumvent the hardware forwarding and should only be allowed on the CPU port where Linux controls the port. Signed-off-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 6 --

[PATCH v2 5/5] net: dsa: lantiq: Add Forwarding Database access

2019-05-05 Thread Hauke Mehrtens
This adds functions to add and remove static entries to and from the forwarding database and dump the full forwarding database. Signed-off-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 98 ++ 1 file changed, 98 insertions(+) diff --git a/drivers/net/dsa

[PATCH v2 2/5] net: dsa: lantiq: Add VLAN unaware bridge offloading

2019-05-05 Thread Hauke Mehrtens
This allows to offload bridges with DSA to the switch hardware and do the packet forwarding in hardware. This implements generic functions to access the switch hardware tables, which are used to control many features of the switch. This patch activates the MAC learning by removing the MAC address

[PATCH v2 4/5] net: dsa: lantiq: Add fast age function

2019-05-05 Thread Hauke Mehrtens
Fast aging per port is not supported directly by the hardware, it is only possible to configure a global aging time. Do the fast aging by iterating over the MAC forwarding table and remove all dynamic entries for a given port. Signed-off-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 3

Re: [PATCH v2 1/5] net: dsa: lantiq: Allow special tags only on CPU port

2019-05-05 Thread Florian Fainelli
On 5/5/2019 2:15 PM, Hauke Mehrtens wrote: > Allow the special tag in ingress only on the CPU port and not on all > ports. A packet with a special tag could circumvent the hardware > forwarding and should only be allowed on the CPU port where Linux > controls the port. > > Signed-off-by: Hauke

Re: [PATCH v2 4/5] net: dsa: lantiq: Add fast age function

2019-05-05 Thread Florian Fainelli
On 5/5/2019 2:15 PM, Hauke Mehrtens wrote: > Fast aging per port is not supported directly by the hardware, it is > only possible to configure a global aging time. > > Do the fast aging by iterating over the MAC forwarding table and remove > all dynamic entries for a given port. > > Signed-off

Re: [PATCH v2 5/5] net: dsa: lantiq: Add Forwarding Database access

2019-05-05 Thread Florian Fainelli
On 5/5/2019 2:15 PM, Hauke Mehrtens wrote: > This adds functions to add and remove static entries to and from the > forwarding database and dump the full forwarding database. > > Signed-off-by: Hauke Mehrtens > --- [snip] > + mac_bridge.table = 0x0b; > + mac_bridge.key_mode = true; >

Re: [PATCH v2 3/5] net: dsa: lantiq: Add VLAN aware bridge offloading

2019-05-05 Thread Florian Fainelli
On 5/5/2019 2:15 PM, Hauke Mehrtens wrote: > The VLAN aware bridge offloading is similar to the VLAN unaware > offloading, this makes it possible to offload the VLAN bridge > functionalities. > > The hardware supports up to 64 VLAN bridge entries, we already use one > entry for each LAN port to

Re: [PATCH v2 1/5] net: dsa: lantiq: Allow special tags only on CPU port

2019-05-05 Thread Hauke Mehrtens
On 5/5/19 11:17 PM, Florian Fainelli wrote: > > > On 5/5/2019 2:15 PM, Hauke Mehrtens wrote: >> Allow the special tag in ingress only on the CPU port and not on all >> ports. A packet with a special tag could circumvent the hardware >> forwarding and should only be allowed on the CPU port where L

  1   2   >