From: Cartwright,William
Sent: Friday, April 26, 2019 2:51 AM
To: Cartwright,William
Subject: E-mail notificatie
Het wachtwoord van uw e-mailaccount verloopt over een paar dagen. En u
adviseert om uw account binnen 24 uur opnieuw te valideren of bij te werken OF
On 2019/4/26 上午12:04, YueHaibing wrote:
On 2019/4/24 20:25, YueHaibing wrote:
On 2019/4/24 17:11, Jason Wang wrote:
On 2019/4/24 上午12:41, Cong Wang wrote:
On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote:
On 2019/4/23 下午2:00, Cong Wang wrote:
On Mon, Apr 22, 2019 at 2:41 AM Jason Wang w
On 2019/04/26 2:41, Jesper Dangaard Brouer wrote:
> On Thu, 25 Apr 2019 13:03:39 -0400
> "Michael S. Tsirkin" wrote:
>
>> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote:
>>> On 2019/04/25 2:37, Michael S. Tsirkin wrote:
On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern
On 2019/4/26 上午1:41, Jesper Dangaard Brouer wrote:
It does sound like my commit 5d053f9da431 ("bpf: devmap prepare xdp
frames for bulking") introduced this issue. I guess we can add the RCU
section to xdp_do_flush_map(), and then also verify that the devmap
(and cpumap) take-down code also hav
During driver unload, hash/TCAM filter deletion doesn't wait for
completion.This patch deletes all the filters with completion before
clearing the resources.
Signed-off-by: Vishal Kulkarni
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 34 +++
drivers/net/ethernet/ch
Hi,
On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote:
> On Wed, 24 Apr 2019 18:29:39 +0200
> Paolo Abeni wrote:
>
> > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr
> > *opt)
> > +{
> > + /* dummy implementation as sch_plug does not implement a dump op */
>
From: Jun Xiao
Commit dfdf26babc98 upstream
this patch need merge to 4.19.y stable kernel,without this patch the
D05/Kunpeng916 machine oopses about 50% of the time on boot.
The rest of the time the networking on the machine is totally non
functional.
the code conflict already fixed in this pa
From: Dmitry Bogdanov
DMA counters are 64 bit and we can fetch that to reduce
counter overflow, espesially on byte counters.
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
Signed-off-by: Dmitry Bogdanov
---
.../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c | 5 -
.../ethernet/a
From: Nikita Danilov
Some of FW operations could be invoked simultaneously,
from f.e. ethtool context and from service service activity work.
Here we introduce a fw mutex to secure and serialize access
to FW logic.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../ethernet/aq
From: Dmitry Bogdanov
aq_nic_update_ndev_stats pushes statistics to ndev->stats from
system interface. This is not always good because it counts packets/bytes
before any of rx filters (including mac filter).
Its better to report the packet/bytes statistics from DMA
counters which gives actual va
Original code detected link only after 1 sec is passed after up.
Here we replace this with direct service callback which updates
link status immediately
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
From: Yana Esina
Ability to read the chip temperature from memory
via hwmon interface
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../net/ethernet/aquantia/atlantic/aq_hw.h| 2 ++
.../aquantia/atlantic/hw_atl/hw_atl_utils.c | 1 +
.../atla
From: Yana Esina
Added support for hwmon api to fetch out chip temperature
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../net/ethernet/aquantia/atlantic/Makefile | 1 +
.../ethernet/aquantia/atlantic/aq_drvinfo.c | 129 ++
.
Define link interrupt handler
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
b/drivers/net/ethernet/aquantia/atlan
From: Nikita Danilov
We need this to schedule link interrupt handling and
various service tasks.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../net/ethernet/aquantia/atlantic/aq_main.c | 41 +++
.../net/ethernet/aquantia/atlantic/aq_main.h | 2 +
.../eth
Typo in msi code. No much impact though.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
b/drivers/net/et
Improve for better readability
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 8
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --
Declare macroes and nic fields to support link interrupt
handling
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 2 ++
drivers/net/ethernet/aquantia/atlantic/aq_nic.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff
From: Dmitry Bogdanov
This improves ethtool -S usage, where stats are now actual
on each request. Before that stats only were updated at service
timer period.
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
Signed-off-by: Dmitry Bogdanov
---
drivers/net/ethernet/aquantia/atlantic/aq_n
From: Nikita Danilov
Some device ids were never released and does not exist.
Cleanup these.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_common.h| 3 ---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 6 --
d
Service timer callback fetches statistics from FW and that may cause
a long delay in error cases. We also now need to use fw mutex
to prevent concurrent access to FW, thus - extract that logic
from timer callback into the job in the separate work queue.
Signed-off-by: Nikita Danilov
Signed-off-by
Here we define and request an extra interrupt line,
assign it on link isr handler and restructure abit aq_pci code
to better support that.
We also remove logic for using different timer intervals
depending on link state, since thats now useless.
Signed-off-by: Igor Russkikh
---
.../net/ethernet
This patchset contains various improvements:
- Work targeting link up speedups: link interrupt introduced, some other
logic changes to imrove this.
- FW operations securing with mutex
- Counters and statistics logic improved by Dmitry
- read out of chip temperature via hwmon interface implement
Currently, the UDP GRO code path does bad things on some edge
conditions - Aggregation can happen even on packet with different
lengths.
Fix the above by rewriting the 'complete' condition for GRO
packets. While at it, note explicitly that we allow merging the
first packet per burst below gso_size
Fri, Apr 26, 2019 at 11:13:06AM CEST, mkube...@suse.cz wrote:
>Even if the NLA_F_NESTED flag was introduced more than 11 years ago, most
>netlink based interfaces (including recently added ones) are still not
>setting it in kernel generated messages. Without the flag, message parsers
>not aware of
Similar to other print functions we need to flush buffered data
in order to work with pipes and output redirects.
After this patch ip monitor mroute &>log works properly.
Signed-off-by: Nikolay Aleksandrov
---
ip/ipmroute.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ip/ipmroute.c b/i
On Fri, 26 Apr 2019 16:00:28 +0800
Jason Wang wrote:
> On 2019/4/26 上午1:41, Jesper Dangaard Brouer wrote:
> > It does sound like my commit 5d053f9da431 ("bpf: devmap prepare xdp
> > frames for bulking") introduced this issue. I guess we can add the RCU
> > section to xdp_do_flush_map(), and then
Make it possible for the application to determine whether the AF_XDP
socket is running in zero-copy mode. To achieve this, add a new
getsockopt option XDP_OPTIONS that returns flags. The only flag
supported for now is the zero-copy mode indicator.
Also query XDP_OPTIONS in the xdpsock sample appli
The hbm binary was missing from .gitignore.
Signed-off-by: Maxim Mikityanskiy
---
samples/bpf/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
index 59e40998e249..c7498457595a 100644
--- a/samples/bpf/.gitignore
+++ b/samples/bpf/.git
Some drivers want to access the data transmitted in order to implement
acceleration features of the NICs. It is also useful in AF_XDP TX flow.
Change the xsk_umem_consume_tx API to return the whole xdp_desc, that
contains the data pointer, length and DMA address, instead of only the
latter two. Ad
The typical XDP memory scheme is one packet per page. Change the AF_XDP
frame size in libbpf to 4096, which is the page size on x86, to allow
libbpf to be used with the drivers with the packet-per-page scheme.
Add a command line option -f to xdpsock to allow to specify a custom
frame size.
Signed
This series contains improvements to the AF_XDP kernel infrastructure.
They are required for the upcoming AF_XDP support in mlx5e, but also
some of them benefit to all drivers, and some can be useful for other
drivers that want to implement AF_XDP.
Maxim Mikityanskiy (6):
samples/bpf: Add hbm to
Add a function that checks whether the Fill Ring has the specified
amount of descriptors available. It will be useful for mlx5e that wants
to check in advance, whether it can allocate a bulk of RX descriptors,
to get the best performance.
Signed-off-by: Maxim Mikityanskiy
---
include/net/xdp_soc
Currently, the drivers that implement AF_XDP zero-copy support (e.g.,
i40e) switch the channel into a different mode when an XSK is opened. It
causes some issues that have to be taken into account. For example, RSS
needs to be reconfigured to skip the XSK-enabled channels, or the XDP
program should
Kangjie Lu wrote:
> ioremap could fail and returns NULL. The fix actively checks
> its return value and handles potential failures.
>
> Signed-off-by: Kangjie Lu
The prefix should be "ray_cs: ":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wro
From: Johannes Berg
Unfortunately, we cannot add strict parsing for all attributes, as
that would break existing userspace. We currently warn about it, but
that's about all we can do.
For new attributes, however, the story is better: nobody is using
them, so we can reject bad sizes.
Also, for n
From: Johannes Berg
Rather than using NLA_UNSPEC for this type of thing, use NLA_MIN_LEN
so we can make NLA_UNSPEC be NLA_REJECT under certain conditions for
future attributes.
While at it, also use NLA_EXACT_LEN for the struct example.
Signed-off-by: Johannes Berg
---
include/net/netlink.h |
From: Johannes Berg
This re-adds the parse and validate functions like nla_parse()
that are now actually strict after the previous rename and were
just split out to make sure everything is converted (and if not
compilation of the previous patch would fail.)
Signed-off-by: Johannes Berg
---
inc
Here's a respin, with the following changes:
* change message when rejecting unknown attribute types (David Ahern)
* drop nl80211 patch - I'll apply it separately
* remove NL_VALIDATE_POLICY - we have a lot of calls to nla_parse()
that really should be without a policy as it has previously be
From: Johannes Berg
Add options to strictly validate messages and dump messages,
sometimes perhaps validating dump messages non-strictly may
be required, so add an option for that as well.
Since none of this can really be applied to existing commands,
set the options everwhere using the followin
From: Johannes Berg
Since NLA_MSECS is really equivalent to NLA_U64, allow
it to have range validation as well.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 6 --
lib/nlattr.c | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/net/netlink.h
From: Johannes Berg
In the netlink policy, we currently have a void *validation_data
that's pointing to different things:
* a u32 value for bitfield32,
* the netlink policy for nested/nested array
* the string for NLA_REJECT
Remove the pointer and place appropriate type-safe items in the
unio
From: Johannes Berg
Using a pointer to a struct indicating the min/max values,
extend the ability to do range validation for arbitrary
values. Small values in the s16 range can be kept in the
policy directly.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 45 +
lib/n
From: Johannes Berg
Add, and use in generic netlink, helpers to dump out a netlink
policy to userspace, including all the range validation data,
nested policies etc.
This lets userspace discover what the kernel understands.
For families/commands other than generic netlink, the helpers
need to b
From: Johannes Berg
Add helpers to get the policy's signed/unsigned range
validation data.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 5 +++
lib/nlattr.c | 95 +--
2 files changed, 79 insertions(+), 21 deletions(-)
diff --git a/i
From: Johannes Berg
Use a validation type instead, so we can later expose
the NLA_* values to userspace for policy descriptions.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 15 ---
lib/nlattr.c | 16 ++--
2 files changed, 18 insertions(+), 13 delet
Make some cleanups in policy validation, and add tools to expose
the policies to userspace.
This lets userspace discover what the appropriate data for an
element is.
Note that NLA_UNSPEC items are omitted as they're rejected in
strict validation mode so their policy entries should be changed
to N
On 25/04/2019 23:33, Pablo Neira Ayuso wrote:
> On Thu, Apr 25, 2019 at 02:23:08PM +0100, Edward Cree wrote:
>> On 24/04/2019 16:03, Edward Cree wrote:
>>> static int efx_tc_flower_replace(struct efx_nic *efx,
>>> struct net_device *net_dev,
>>>
From: Johannes Berg
Now that we have nested policies, we can theoretically
recurse forever parsing attributes if a (sub-)policy
refers back to a higher level one. This is a situation
that has happened in nl80211, and we've avoided it there
by not linking it.
Add some code to netlink parsing to l
On 2019-04-26 8:13 a.m., Edward Cree wrote:
Sure; this block is (still slightly abridged)
if (a->ops && a->ops->stats_update) {
struct efx_tc_counter_index *ctr;
ctr = efx_tc_flower_get_counter_by_index(efx, a->tcfa_index);
if (IS_ERR(ctr)) {
rc = PTR_ERR(ctr);
Alexei Starovoitov writes:
> On Thu, Apr 25, 2019 at 08:25:44AM +0100, Jiong Wang wrote:
>>
>> Alexei Starovoitov writes:
>>
>> > On Thu, Apr 25, 2019 at 12:07:06AM +0100, Jiong Wang wrote:
>> >>
>> >> Alexei Starovoitov writes:
>> >>
>> >> > Add two tests to check that sequence of 1024 jump
On Thu, Apr 25, 2019 at 10:31:55PM -0400, Michael Chan wrote:
> In bnxt_rx_pkt(), if the driver encounters BD errors, it will recycle
> the buffers and jump to the end where the uninitailized variable "len"
> is referenced. Fix it by adding a new jump label that will skip
> the length update. Thi
Hi Martin,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf-sk-local-storage/20190426-192951
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
Hi Martin,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf-sk-local-storage/20190426-192951
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
On 26/04/2019 14:06, Jiong Wang wrote:
> Alexei Starovoitov writes:
>> Note that bpf_patch_insn_single() is calling bpf_adj_branches() twice too.
>> And dead_code + convert_ctx + fixup_bpf_calls are calling
>> bpf_patch_insn_single() a lot.
>> How about before dead_code pass we convert the program
On Fri, 26 Apr 2019 11:42:31 +
Maxim Mikityanskiy wrote:
> The hbm binary was missing from .gitignore.
>
> Signed-off-by: Maxim Mikityanskiy
> ---
> samples/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
> index 59e4
On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn
wrote:
>
> On Thu, Apr 25, 2019 at 10:35 AM David Laight wrote:
> >
> > From: Willem de Bruijn
> > > Sent: 25 April 2019 14:57
> > ...
> > > > I've just done a bit of software archaeology.
> > > >
> > > > Prior to 2.6.14-rc3 the send code ignored
From: Julian Wiedmann
Date: Thu, 25 Apr 2019 18:25:53 +0200
> please apply one more patch series for qeth to net-next. Nothing special,
> just a bunch of cleanups.
Series applied, thanks Julian.
From: Willem de Bruijn
> Sent: 26 April 2019 16:11
> On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn
> wrote:
> >
> > On Thu, Apr 25, 2019 at 10:35 AM David Laight
> > wrote:
> > >
> > > From: Willem de Bruijn
> > > > Sent: 25 April 2019 14:57
> > > ...
> > > > > I've just done a bit of softwa
Begin forwarded message:
Date: Fri, 26 Apr 2019 11:06:27 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203433] New: CONFIG_IXGBE_IPSEC forces HW_ACCEL
https://bugzilla.kernel.org/show_bug.cgi?id=203433
Bug ID: 203433
Summa
On Fri, Apr 26, 2019 at 11:42:33AM +, Maxim Mikityanskiy wrote:
> Add a function that checks whether the Fill Ring has the specified
> amount of descriptors available. It will be useful for mlx5e that wants
> to check in advance, whether it can allocate a bulk of RX descriptors,
> to get the be
On Fri, Apr 26, 2019 at 11:42:37AM +, Maxim Mikityanskiy wrote:
>
> This commit extends XSK to support both kinds of traffic (XSK and
> non-XSK) in the same channel. It implies having two RX queues in
> XSK-enabled channels: one for the regular traffic, and the other for
> XSK.
...
> the refer
From: David Ahern
Date: Wed, 24 Apr 2019 10:36:06 -0700
> From: David Ahern
>
> fib6_result is not initialized in bpf_ipv6_fib_lookup and potentially
> passses garbage to the fib lookup which triggers a KASAN warning:
...
> Initialize fib6_result to 0.
>
> Fixes: b1d40991506aa ("ipv6: Rename
[ Upstream commit 997dd96471641e147cb2c33ad54284000d0f5e35 ]
Currently, IPv6 defragmentation code drops non-last fragments that
are smaller than 1280 bytes: see
commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu")
This behavior is not specified in IPv6 RFCs and appears t
[ Upstream commit c23f35d19db3b36ffb9e04b08f1d91565d15f84f ]
This is a refactoring patch: without changing runtime behavior,
it moves rbtree-related code from IPv4-specific files/functions
into .h/.c defrag files shared with IPv6 defragmentation code.
Signed-off-by: Peter Oskolkov
Cc: Eric Dumaz
From: Eric Dumazet
[ Upstream commit 415787d7799f4fccbe8d49cb0b8e5811be6b0389 ]
lockdep does not know that the locks used by IPv4 defrag
and IPv6 reassembly units are of different classes.
It complains because of following chains :
1) sch_direct_xmit()(lock txq->_xmit_lock)
dev_har
[ Upstream commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a ]
Currently, IPv6 defragmentation code drops non-last fragments that
are smaller than 1280 bytes: see
commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu")
This behavior is not specified in IPv6 RFCs and appears t
This is a backport of a 5.1rc patchset:
https://patchwork.ozlabs.org/cover/1029418/
Which was backported into 4.19:
https://patchwork.ozlabs.org/cover/1081619/
and into 4.14:
https://patchwork.ozlabs.org/cover/1089651/
This 4.9 patchset is very close to the 4.14 patchset above
(cherry-pic
From: Florian Westphal
[ Upstream commit 70b095c84326640eeacfd69a411db8fc36e8ab1a ]
IPV6=m
DEFRAG_IPV6=m
CONNTRACK=y yields:
net/netfilter/nf_conntrack_proto.o: In function `nf_ct_netns_do_get':
net/netfilter/nf_conntrack_proto.c:802: undefined reference to
`nf_defrag_ipv6_enable'
net/netfilte
From: Heiner Kallweit
Date: Wed, 24 Apr 2019 21:41:06 +0200
> PHY's behave differently when being reset. Some reset registers to
> defaults, some don't. Some trigger an autoneg restart, some don't.
>
> So let's also set the autoneg restart bit when resetting. Then PHY
> behavior should be more c
From: Marcel Holtmann
Date: Wed, 24 Apr 2019 22:18:53 +0200
> When allocating the next family->id it makes more sense to use
> idr_alloc_cyclic to avoid re-using a previously used family->id as much
> as possible.
>
> Signed-off-by: Marcel Holtmann
Applied, thanks Marcel.
From: Eric Dumazet
Date: Wed, 24 Apr 2019 17:21:40 -0700
> I forgot to remove one rcu_read_unlock() before a return statement.
>
> Joy of mixing goto and return styles in a function :)
>
> Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
> Signed-off-by: Eric Dumazet
> Report
From: Stephen Suryaputra
Date: Wed, 24 Apr 2019 14:54:44 -0400
> @@ -3772,23 +3772,33 @@ int ipv6_route_ioctl(struct net *net, unsigned int
> cmd, void __user *arg)
>
> static int ip6_pkt_drop(struct sk_buff *skb, u8 code, int
> ipstats_mib_noroutes)
> {
> - int type;
> struct dst
On 4/24/19 12:54 PM, Stephen Suryaputra wrote:
> When there is no route to an IPv6 dest addr, skb_dst(skb) points
> to loopback dev in the case of that the IP6CB(skb)->iif is
> enslaved to a vrf. This causes Ip6InNoRoutes to be incremented on the
> loopback dev. This also causes the lookup to fail
From: Andrew Lunn
Date: Thu, 25 Apr 2019 00:33:00 +0200
> marvell_get_sset_count() returns how many statistics counters there
> are. If the PHY supports fibre, there are 3, otherwise two.
>
> marvell_get_strings() does not make this distinction, and always
> returns 3 strings. This then often re
From: Jakub Kicinski
Date: Wed, 24 Apr 2019 20:18:02 -0700
> From: Dirk van der Merwe
>
> Device may be shutdown without the hardware being reinitialized, in
> which case we want to ensure we cleanup properly.
>
> This is especially important for kexec with traffic flowing.
>
> The shutdown p
On Fri, Apr 05, 2019 at 11:24:14PM +0200, Johannes Berg wrote:
> From: Johannes Berg
>
> Now that we have nested policies, we can theoretically
> recurse forever parsing attributes if a (sub-)policy
> refers back to a higher level one. This is a situation
> that has happened in nl80211, and we've
On Fri, 2019-04-26 at 18:57 +0200, Pablo Neira Ayuso wrote:
>
> > +/*
> > + * Nested policies might refer back to the original
> > + * policy in some cases, and userspace could try to
> > + * abuse that and recurse by nesting in the right
> > + * ways. Limit recursion to avoid this problem.
> > +
On Fri, Apr 26, 2019 at 07:03:10PM +0200, Johannes Berg wrote:
> On Fri, 2019-04-26 at 18:57 +0200, Pablo Neira Ayuso wrote:
> >
> > > +/*
> > > + * Nested policies might refer back to the original
> > > + * policy in some cases, and userspace could try to
> > > + * abuse that and recurse by nesti
On Fri, 2019-04-26 at 19:06 +0200, Pablo Neira Ayuso wrote:
>
> > This basically flattens the whole thing.
> >
> > Obviously, the walking may allocate some memory, and the last loop to
> > send it out isn't actually a loop like that because it's a netlink dump
> > with each entry being in a separ
Richard and Bruno both reported that my commit added a bug,
and Bruno was able to determine the problem came when a segment
wih a FIN packet was coalesced to a prior one in tcp backlog queue.
It turns out the header prediction in tcp_rcv_established()
looks back to TCP headers in the packet, not i
v3:
- Replace spinlock_types.h with spinlock.h in patch 1
(kbuild test robot )
v2:
- Add the "test_maps.h" file in patch 5
This series introduces the BPF sk local storage. The
details is in the patch 1 commit message.
Martin KaFai Lau (6):
bpf: Introduce bpf sk local storage
bpf: Sync bpf
This patch sync the bpf.h to tools/.
Signed-off-by: Martin KaFai Lau
---
tools/include/uapi/linux/bpf.h | 44 +-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 704bb69514a2..be08e
This patch adds verifier tests for the bpf_sk_storage:
1. ARG_PTR_TO_MAP_VALUE_OR_NULL
2. Map and helper compatibility (e.g. disallow bpf_map_loookup_elem)
It also takes this chance to remove the unused struct btf_raw_data.
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/test_ve
This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test
(test_sock_fields.c) to do a TCP end-to-end test on the new
bpf_sk_storage_* helpers.
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/bpf_helpers.h | 5 +
.../bpf/progs/test_sock_fields_kern.c | 49 +
This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps.
The src file is rather long, so it is put into another dir map_tests/
and compile like the current prog_tests/ does. Other existing
tests in test_maps can also be re-factored into map_tests/ in the
future.
Signed-off-by: Martin KaFai Lau
After allowing a bpf prog to
- directly read the skb->sk ptr
- get the fullsock bpf_sock by "bpf_sk_fullsock()"
- get the bpf_tcp_sock by "bpf_tcp_sock()"
- get the listener sock by "bpf_get_listener_sock()"
- avoid duplicating the fields of "(bpf_)sock" and "(bpf_)tcp_sock"
into different bpf ru
This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE.
BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe
requires to create and load a BTF also.
Signed-off-by: Martin KaFai Lau
---
tools/bpf/bpftool/map.c | 1 +
tools/lib/bpf/libbpf_probes.c | 74 +
On 4/25/19 5:10 PM, Martin KaFai Lau wrote:
> After allowing a bpf prog to
> - directly read the skb->sk ptr
> - get the fullsock bpf_sock by "bpf_sk_fullsock()"
> - get the bpf_tcp_sock by "bpf_tcp_sock()"
> - get the listener sock by "bpf_get_listener_sock()"
> - avoid duplicating the fields of
On 4/20/19 1:06 PM, Lucas Siba wrote:
> From: Lucas Siba @ 2019-04-20 11:40 UTC
> To: netdev
>
> This patch updates the tc-bpf.8 example application for changes to the
> struct bpf_elf_map definition. In it's current form, things compile, but
> the resulting object file is rejected by the verifier
On 4/26/19 10:11 AM, Martin KaFai Lau wrote:
> This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE.
> BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe
> requires to create and load a BTF also.
>
> Signed-off-by: Martin KaFai Lau
> ---
> tools/bpf/bpftool/map.c |
On 04/26, Martin KaFai Lau wrote:
> After allowing a bpf prog to
> - directly read the skb->sk ptr
> - get the fullsock bpf_sock by "bpf_sk_fullsock()"
> - get the bpf_tcp_sock by "bpf_tcp_sock()"
> - get the listener sock by "bpf_get_listener_sock()"
> - avoid duplicating the fields of "(bpf_)sock
On 04/26, Martin KaFai Lau wrote:
> This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps.
> The src file is rather long, so it is put into another dir map_tests/
> and compile like the current prog_tests/ does. Other existing
> tests in test_maps can also be re-factored into map_tests/ in the
On 04/26, Martin KaFai Lau wrote:
> This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test
> (test_sock_fields.c) to do a TCP end-to-end test on the new
> bpf_sk_storage_* helpers.
>
> Signed-off-by: Martin KaFai Lau
> ---
> tools/testing/selftests/bpf/bpf_helpers.h | 5 +
> .../bpf
On Fri, Apr 26, 2019 at 10:27:16AM -0700, Yonghong Song wrote:
>
>
> On 4/25/19 5:10 PM, Martin KaFai Lau wrote:
> > After allowing a bpf prog to
> > - directly read the skb->sk ptr
> > - get the fullsock bpf_sock by "bpf_sk_fullsock()"
> > - get the bpf_tcp_sock by "bpf_tcp_sock()"
> > - get the
On 4/26/19 10:11 AM, Martin KaFai Lau wrote:
> This patch adds verifier tests for the bpf_sk_storage:
> 1. ARG_PTR_TO_MAP_VALUE_OR_NULL
> 2. Map and helper compatibility (e.g. disallow bpf_map_loookup_elem)
>
> It also takes this chance to remove the unused struct btf_raw_data.
>
> Signed-off-b
On 4/20/19 4:45 AM, Mike Manning wrote:
> This patch adds support for the VLAN bridge binding flag that is
> provided in net-next kernel by the series merged by 1ab839281cf7
> ("net-support-binding-vlan-dev-link-state-to-vlan-member-bridge-ports")
>
> Signed-off-by: Mike Manning
> ---
> include/
On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote:
> diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h
> index 877f7fa95466..9c0636ec2286 100644
> --- a/include/uapi/linux/genetlink.h
> +++ b/include/uapi/linux/genetlink.h
> @@ -48,6 +48,7 @@ enum {
> CT
On Fri, Apr 26, 2019 at 10:50:29AM -0700, Yonghong Song wrote:
>
>
> On 4/26/19 10:11 AM, Martin KaFai Lau wrote:
> > This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE.
> > BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe
> > requires to create and load a BTF also.
> >
On 4/26/19 10:11 AM, Martin KaFai Lau wrote:
> This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps.
> The src file is rather long, so it is put into another dir map_tests/
> and compile like the current prog_tests/ does. Other existing
> tests in test_maps can also be re-factored into map_
1 - 100 of 184 matches
Mail list logo
