[PATCH] net: dsa: Add support for port mac address

2019-03-05 Thread xiaofeis
Allow port network device's mac address to be retrieved from the device tree. Signed-off-by: xiaofeis --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt b/Documentation/devicetree/bindi

[PATCH V3 4/6] net: ethernet: stmmac: add management of clk_csr property

2019-03-05 Thread Christophe Roullier
In Documentation stmmac.txt there is possibility to fixed CSR Clock range selection with property clk_csr. This patch add the management of this property For example to use it, add in your ethernet node DT: clk_csr = <3>; Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicr

[PATCH V3 1/6] net: ethernet: stmmac: manage Ethernet WoL for stm32mp157c.

2019-03-05 Thread Christophe Roullier
Add glue codes to support magic packet on stm32mp157c Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 30 ++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/

[PATCH V3 0/6] stmmac: add some fixes for stm32

2019-03-05 Thread Christophe Roullier
For common stmmac: - Add support to set CSR Clock range selection in DT For stm32mpu: - Glue codes to support magic packet - Glue codes to support all PHY config : PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz),

[PATCH V3 6/6] ARM: dts: stm32: Add Ethernet support on stm32h7 SOC and activate it for eval and disco boards

2019-03-05 Thread Christophe Roullier
Synopsys GMAC 4.10 is used. And Phy mode for eval and disco is RMII with PHY SMSC LAN8742 Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 15 +++ arch/arm/boot/dts/stm32h743.dtsi | 13 + arch/arm/boot/dts/stm32h743i-disco.dts |

[PATCH V3 2/6] net: ethernet: stmmac: update to support all PHY config for stm32mp157c.

2019-03-05 Thread Christophe Roullier
Update glue codes to support all PHY config on stm32mp157c PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz), PHY wo crystal (50Mhz), No 125Mhz from PHY config. Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 107

[PATCH V3 3/6] dt-bindings: net: stmmac: add phys config properties

2019-03-05 Thread Christophe Roullier
Add properties to support all Phy config PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz), PHY wo crystal (50Mhz), No 125Mhz from PHY config. Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 6 +++--- 1 file changed, 3 i

[PATCH V3 5/6] dt-bindings: net: stmmac: remove syscfg clock property

2019-03-05 Thread Christophe Roullier
Syscfg clock is no more needed. Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 7:44 AM Luciano Coelho wrote: > On Mon, 2019-03-04 at 21:38 +0100, Arnd Bergmann wrote: > This was already fixed with this patch: > > https://patchwork.kernel.org/patch/10823267/ > > ...but it hasn't reached the mainline yet. > > I'm planning to send it to the v5.1-rc series

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-05 Thread Luciano Coelho
On Tue, 2019-03-05 at 09:37 +0100, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 7:44 AM Luciano Coelho < > luciano.coe...@intel.com> wrote: > > On Mon, 2019-03-04 at 21:38 +0100, Arnd Bergmann wrote: > > This was already fixed with this patch: > > > > https://patchwork.kernel.org/patch/10823267/

kernel tls interface with user space modification proposal

2019-03-05 Thread Vakul Garg
Hi The present interface of kernel tls with user space has few shortcomings. The biggest one is that when we need to add a ciphersuite in kernel tls, then we need to define new structures for passing cryptographic parameters required by record layer. And the user space ssl stack also has to be

Re: [PATCH] net: dsa: Add support for port mac address

2019-03-05 Thread Vinod Koul
On 05-03-19, 16:16, xiaofeis wrote: > Allow port network device's mac address to be retrieved from the > device tree. Reviewed-by: Vinod Koul > Signed-off-by: xiaofeis > --- > Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Docum

Re: static bpf vars. Was: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-05 Thread Daniel Borkmann
On 03/05/2019 03:28 AM, Alexei Starovoitov wrote: > On Fri, Mar 01, 2019 at 09:06:35PM +0100, Daniel Borkmann wrote: > > Overall I think the patches and direction is great. > Thanks a lot for working on it. > More thoughts below: Okay, thanks! >> By the way, from LLVM side, do you think it makes

openvswitch crash on i386

2019-03-05 Thread Juerg Haefliger
Hi, Running the following commands in a loop will crash an i386 5.0 kernel typically within a few iterations: ovs-vsctl add-br test ovs-vsctl del-br test [ 106.215748] BUG: unable to handle kernel paging request at e8a35f3b [ 106.216733] #PF error: [normal kernel read fault] [ 106.217464] *pd

Re: [PATCH net-next v3 2/3] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-03-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Mon, 04 Mar 2019 23:28:14 +0100, Toke Høiland-Jørgensen wrote: >> Jakub Kicinski writes: >> > On Mon, 04 Mar 2019 20:05:30 +0100, Toke Høiland-Jørgensen wrote: >> >> > Hm. I think you'll still need a lock (mutex?) on the alloc path, but >> >> > the free path should

Re: stmmac / meson8b-dwmac

2019-03-05 Thread Simon Huelck
Hi guys, 1. i discovered something strange. when i never configure my external VLAN interface UP ( firewall doesnt start, traffic shaper CAKE doesnt start), my non duplex iperf bandwidth increases from 600MBits to 930. 2.  duplex isnt working, TX is totally starving RX, the total bandwidth is 90

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Christian Ehrhardt
On Tue, Mar 5, 2019 at 10:58 AM Juerg Haefliger wrote: > > Hi, > > Running the following commands in a loop will crash an i386 5.0 kernel > typically within a few iterations: > > ovs-vsctl add-br test > ovs-vsctl del-br test > > [ 106.215748] BUG: unable to handle kernel paging request at e8a35f3

Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread

2019-03-05 Thread Jiri Olsa
On Mon, Mar 04, 2019 at 09:40:07PM +, Song Liu wrote: > > > > On Feb 27, 2019, at 5:21 AM, Jiri Olsa wrote: > > > > On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote: > > > > SNIP > > > >> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > >> index 8c902276d4b4..61b

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-05 Thread Kalle Valo
Arnd Bergmann writes: > do_div() expects unsigned operands and otherwise triggers a warning like: > > drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2: error: > comparison of distinct pointer types ('typeof ((rtt_avg)) *' (aka 'long long > *') and 'uint64_t *' (aka 'unsigned long lo

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:33:02AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 08:56:09 +0100, Jiri Pirko wrote: >> Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >> >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> >> Fri, Mar 01, 2019 at 07:04:50PM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:40:07AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 12:19:02 +0100, Jiri Pirko wrote: >> Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >> >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> >> Fri, Mar 01, 2019 at 07:04:50PM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:51:59AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 12:08:57 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-05 Thread Luca Coelho
On Tue, 2019-03-05 at 13:11 +0200, Kalle Valo wrote: > Arnd Bergmann writes: > > > do_div() expects unsigned operands and otherwise triggers a warning > > like: > > > > drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2: > > error: comparison of distinct pointer types ('typeof ((rtt_av

[PATCH net] ipv4/route: fail early when inet dev is missing

2019-03-05 Thread Paolo Abeni
If a non local multicast packet reaches ip_route_input_rcu() while the ingress device is NULL, we end up doing a NULL pointer dereference in IN_DEV_MFORWARD(). Since the later call to ip_route_input_mc() is going to fail if !in_dev, we can fail early in such scenario and avoid the dangerous code p

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-05 Thread Antoine Tenart
Hi Russell, On Mon, Mar 04, 2019 at 04:10:47PM +, Russell King - ARM Linux admin wrote: > On Mon, Mar 04, 2019 at 11:47:00AM +0100, Antoine Tenart wrote: > > > > I agree having a per-driver behaviour is not something we want. As I > > understand it, there is no behaviour enforced currently re

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-05 Thread Jakub Sitnicki
On Fri, Mar 01, 2019 at 10:05 PM CET, Daniel Borkmann wrote: > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns(); >

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-05 Thread Vasily Averin
On 3/4/19 6:51 PM, Eric Dumazet wrote: > On 03/04/2019 04:58 AM, Vasily Averin wrote: >> Eric, what do you think about following patch? >> I validate its backported version on RHEL7 based OpenVZ kernel before >> sending to mainline. >> >> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c >> index cf3c

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-05 Thread Daniel Borkmann
On 03/05/2019 03:12 PM, Jakub Sitnicki wrote: [...] > Could you please queue it for -stable which has d3bd7413e0ca ("bpf: fix > sanitation of alu op with pointer / scalar type from different paths")? Already done here yesterday morning: https://lore.kernel.org/stable/40b25ec1c31e234cf7eee75d62083

[PATCH] net: add missing documentation in linux/skbuff.h

2019-03-05 Thread Pedro Tammela
This patch adds missing documentation for some inline functions on linux/skbuff.h. The patch is incomplete and a lot more can be added, just wondering if it's of interest of the netdev developers. Also fixed some whitespaces. Signed-off-by: Pedro Tammela --- include/linux/skbuff.h | 64

Re: [RFC PATCH] net: dsa: mv88e6xxx: support single chip sw_addr offset

2019-03-05 Thread Rasmus Villemoes
On 04/03/2019 14.45, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 12:59:42PM +, Rasmus Villemoes wrote: >> From: Per Noergaard Christensen >> >> The 88e6250 does not support multi-chip addressing. However, one can >> still have two of them on the same mdio bus, since the device only >> uses 16

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-05 Thread Eric Dumazet
Resent in plain text mode for the lists. On Tue, Mar 5, 2019 at 7:08 AM Eric Dumazet wrote: > > > > On Tue, Mar 5, 2019 at 6:24 AM Vasily Averin wrote: >> >> On 3/4/19 6:51 PM, Eric Dumazet wrote: >> > On 03/04/2019 04:58 AM, Vasily Averin wrote: >> >> Eric, what do you think about following pat

Re: [PATCH net] ipv4/route: fail early when inet dev is missing

2019-03-05 Thread David Ahern
On 3/5/19 5:49 AM, Paolo Abeni wrote: > If a non local multicast packet reaches ip_route_input_rcu() while > the ingress device is NULL, we end up doing a NULL pointer A clarification: the ingress device is not NULL; it's the IPv4 private data (in_device). > dereference in IN_DEV_MFORWARD(). > >

Re: [PATCH net-next (fix) 1/2] net: fix GSO in bpf_lwt_push_ip_encap

2019-03-05 Thread David Ahern
On 3/4/19 5:27 PM, Peter Oskolkov wrote: > GSO needs inner headers and inner protocol set properly to work. > > skb->inner_mac_header: skb_reset_inner_headers() assigns the current > mac header value to inner_mac_header; but it is not set at the point, > so we need to call skb_reset_inner_mac_head

[PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-05 Thread Dan Murphy
Create a m_can platform framework that peripherial devices can register to and use common code and register sets. The peripherial devices may provide read/write and configuration support of the IP. Signed-off-by: Dan Murphy --- v7 - Fixed remaining new checkpatch issues, removed CSR setting, fi

[PATCH v7 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-05 Thread Dan Murphy
Rename the common m_can_priv class structure to m_can_classdev as this is more descriptive. Signed-off-by: Dan Murphy --- v7 - Fixed remaining checkpatch issues, renamed priv to cdev - https://lore.kernel.org/patchwork/patch/1047219/ v6 - No changes only rebase changes possibly can squash into

[PATCH v7 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-03-05 Thread Dan Murphy
Add the TCAN4x5x SPI CAN driver. This device uses the Bosch MCAN IP core along with a SPI interface map. Register to the MCAN common core code to manage the MCAN IP. This device has a special method to indicate a write/read operation on the data payload. Signed-off-by: Dan Murphy --- v7 - Fixe

[PATCH v7 3/4] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver

2019-03-05 Thread Dan Murphy
DT binding documentation for TI TCAN4x5x driver. Signed-off-by: Dan Murphy --- v7 - Made device state optional - https://lore.kernel.org/patchwork/patch/1047218/ v6 - No changes - https://lore.kernel.org/patchwork/patch/1042445/ .../devicetree/bindings/net/can/tcan4x5x.txt | 37

Re: [PATCH iproute2-next] bridge: fdb: add support for src_vni option

2019-03-05 Thread David Ahern
On 3/3/19 10:26 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > We already print src_vni for a fdb entry when present. > This patch adds the ability to set src_vni on a fdb > entry. When not specified, kernel will use vni specified > on the vxlan device. This can be used on a vxlan fdb entry > w

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Gerd Rausch
Hi, This patchset breaks compatibility... On 04/02/2019 16.04, Santosh Shilimkar wrote: > --- a/net/rds/ib_cm.c > +++ b/net/rds/ib_cm.c > @@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id, > bool isv6) > > /* If the peer doesn't do protocol negotiation, we must

[PATCH bpf-next v1] tools/bpftool: create map of maps

2019-03-05 Thread Alban Crequy
From: Alban Crequy Before this patch, there was no way to fill attr.inner_map_fd, necessary for array_of_maps or hash_of_maps. This patch adds keyword 'innermap' to pass the innermap, either as an id or as a pinned map. Example of commands: $ sudo bpftool map create /sys/fs/bpf/innermap type h

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Santosh Shilimkar
On 3/5/2019 8:33 AM, Gerd Rausch wrote: Hi, This patchset breaks compatibility... On 04/02/2019 16.04, Santosh Shilimkar wrote: --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c @@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id, bool isv6) /* If the peer doesn't do p

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-05 Thread Eric Dumazet
On Tue, Mar 5, 2019 at 7:11 AM Eric Dumazet wrote: > > > > > My original suggestion was to use VM_WARN_ONCE() so that the debug checks > > would > > be compiled out by the compiler, unless you compile a debug kernel. > > > > Something like : > > > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c >

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Gerd Rausch
Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: > On 3/5/2019 8:33 AM, Gerd Rausch wrote: >> If there's a mechanism that ensures compatibility with older (pre-4.1) >> versions >> of RDS I am not seeing it. > Thats handled as part of the connection reject handler as part of negotiation.

RE: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Monday, March 4, 2019 7:46 PM > To: Parav Pandit > Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net; > gre...@linuxfoundation.org; Jiri Pirko > Subject: Re: [RFC n

Re: question about memory leak in ip_mc_del1_src

2019-03-05 Thread David Miller
From: maowenan Date: Tue, 5 Mar 2019 11:33:03 +0800 > > > On 2019/3/5 2:16, David Miller wrote: >> From: maowenan >> Date: Mon, 4 Mar 2019 20:47:42 +0800 >> >>> pmc->tomb = psf; >>> rv = 1; //if it does not kfree(psf), will it >>> lead to memor

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Santosh Shilimkar
On 3/5/2019 8:48 AM, Gerd Rausch wrote: Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: On 3/5/2019 8:33 AM, Gerd Rausch wrote: If there's a mechanism that ensures compatibility with older (pre-4.1) versions of RDS I am not seeing it. Thats handled as part of the connection reject h

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jakub Kicinski
On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote: > >> >as ports. Can we invent a new command (say "partition"?) that'd take > >> >the bus info where the partition is to be spawned? > >> > >> Got it. But the question is how different this object would be from the > >> existing "port" we ha

Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12

2019-03-05 Thread Dan Williams
On Sat, 2019-03-02 at 22:19 +0100, Kristian Evensen wrote: > On Sat, Mar 2, 2019 at 4:00 PM Bjørn Mork wrote: > > I am not too happy about the double device id matching with extra > > magic > > applied. outside the device id table. It does not scale, and it > > does > > not play well at all with

[PATCH][bpf-next] bpf: hbm: fix spelling mistake "deault" -> "default"

2019-03-05 Thread Colin King
From: Colin Ian King There are a couple of typos, fix these. Signed-off-by: Colin Ian King --- samples/bpf/hbm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c index 8408ccb7409f..a79828ab273f 100644 --- a/samples/bpf/hbm.c +++ b/s

[PATCH net] xsk: fix potential crash in xsk_diag_put_umem()

2019-03-05 Thread Eric Dumazet
Fixes two typos in xsk_diag_put_umem() syzbot reported the following crash : kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 7641 Comm: syz-executor946 Not tainted 5.0.0-rc7+ #9

Re: [PATCH bpf-next v1] tools/bpftool: create map of maps

2019-03-05 Thread Jakub Kicinski
On Tue, 5 Mar 2019 17:38:03 +0100, Alban Crequy wrote: > From: Alban Crequy > > Before this patch, there was no way to fill attr.inner_map_fd, necessary > for array_of_maps or hash_of_maps. > > This patch adds keyword 'innermap' to pass the innermap, either as an id > or as a pinned map. > > E

Re: [GIT] Networking

2019-03-05 Thread pr-tracker-bot
The pull request you sent on Mon, 04 Mar 2019 15:26:27 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6456300356433873309a1cae6aa05e77d6b59153 Thank you! -- Deet-doot-dot,

Re: [PATCH net] xsk: fix potential crash in xsk_diag_put_umem()

2019-03-05 Thread Björn Töpel
On Tue, 5 Mar 2019 at 18:41, Eric Dumazet wrote: > > Fixes two typos in xsk_diag_put_umem() > > syzbot reported the following crash : > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] PREEMPT SMP KASAN

Re: kernel BUG at include/linux/mm.h:LINE! (5)

2019-03-05 Thread Eric Dumazet
On 03/04/2019 02:23 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    9e9322e5d28e selftest/net: Remove duplicate header > git tree:   net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1351623320 > kernel config:  https://syzkall

RE: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

2019-03-05 Thread Parav Pandit
> -Original Message- > From: Greg KH > Sent: Tuesday, March 5, 2019 1:14 AM > To: Parav Pandit > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > michal.l...@markovi.net; da...@davemloft.net; Jiri Pirko > ; Jakub Kicinski > Subject: Re: [RFC net-next 8/8] net/mlx5: Add subd

[PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-03-05 Thread Adalbert Lazăr
Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device hot-unplug"), vsock_core_init() was called from virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called before vsock_core_init() has the chance to run. [Wed Feb 27 14:17:09 2019] BUG: unable to handle

Re: AF_XDP design flaws

2019-03-05 Thread Björn Töpel
On Thu, 28 Feb 2019 at 11:50, Maxim Mikityanskiy wrote: > [...] Back in the saddle! Sorry for the delay! Ok, let me try to summarize. First, let's go through the current AF_XDP semantics so that we're all on the same page, and then pull Max' suggestions in. Ingress --- The simplified flow

Re: [PATCH bpf-next v1] tools/bpftool: create map of maps

2019-03-05 Thread Quentin Monnet
2019-03-05 17:38 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > Before this patch, there was no way to fill attr.inner_map_fd, necessary > for array_of_maps or hash_of_maps. > > This patch adds keyword 'innermap' to pass the innermap, either as an id > or as a pinned map. > > Example of comm

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-05 Thread Vasily Averin
On 3/5/19 7:44 PM, Eric Dumazet wrote: > On Tue, Mar 5, 2019 at 7:11 AM Eric Dumazet wrote: >>> My original suggestion was to use VM_WARN_ONCE() so that the debug checks >>> would >>> be compiled out by the compiler, unless you compile a debug kernel. >>> >>> Something like : >>> >>> diff --gi

Re: [PATCH 0/2] bpf: context casting for tail call and gtrace prog type

2019-03-05 Thread Alexei Starovoitov
On Tue, Feb 26, 2019 at 01:46:01AM -0500, Kris Van Hees wrote: > On Mon, Feb 25, 2019 at 10:18:25PM -0800, Alexei Starovoitov wrote: > > On Mon, Feb 25, 2019 at 07:54:13AM -0800, Kris Van Hees wrote: > > > > > > The goal is to further extend the BPF_PROG_TYPE_GTRACE implementation to > > > support

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread si-wei liu
On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote: On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote: When a netdev appears through hot plug then gets enslaved by a failover master that is already up and running, the slave will be opened right away after getting enslaved. Today there's a

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread Stephen Hemminger
On Tue, 5 Mar 2019 11:19:32 -0800 si-wei liu wrote: > > I have a vague idea: would it work to *not* set > > IFF_UP on slave devices at all? > Hmm, I ever thought about this option, and it appears this solution is > more invasive than required to convert existing scripts, despite the > controv

Re: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

2019-03-05 Thread Greg KH
On Tue, Mar 05, 2019 at 05:57:58PM +, Parav Pandit wrote: > > > > -Original Message- > > From: Greg KH > > Sent: Tuesday, March 5, 2019 1:14 AM > > To: Parav Pandit > > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > > michal.l...@markovi.net; da...@davemloft.net; Jiri P

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread si-wei liu
On 3/5/2019 11:24 AM, Stephen Hemminger wrote: On Tue, 5 Mar 2019 11:19:32 -0800 si-wei liu wrote: I have a vague idea: would it work to *not* set IFF_UP on slave devices at all? Hmm, I ever thought about this option, and it appears this solution is more invasive than required to convert e

RE: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Monday, March 4, 2019 7:35 PM > To: Parav Pandit > Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net; > gre...@linuxfoundation.org; Jiri Pirko > Subject: Re: [RFC n

[PATCH v1 net] lan743x: Fix RX Kernel Panic

2019-03-05 Thread Bryan Whitehead
It has been noticed that running the speed test at www.speedtest.net occasionally causes a kernel panic. Investigation revealed that under this test RX buffer allocation sometimes fails and returns NULL. But the lan743x driver did not handle this case. This patch fixes this issue by attempting to

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Joe Stringer
On Tue, Mar 5, 2019 at 2:12 AM Christian Ehrhardt wrote: > > On Tue, Mar 5, 2019 at 10:58 AM Juerg Haefliger > wrote: > > > > Hi, > > > > Running the following commands in a loop will crash an i386 5.0 kernel > > typically within a few iterations: > > > > ovs-vsctl add-br test > > ovs-vsctl del-b

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Parav Pandit
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Tuesday, March 5, 2019 11:16 AM > To: Jiri Pirko > Cc: da...@davemloft.net; netdev@vger.kernel.org; oss- > driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subport

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2019 at 11:19:32AM -0800, si-wei liu wrote: > > > On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote: > > On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote: > > > When a netdev appears through hot plug then gets enslaved by a failover > > > master that is already up and runnin

Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread

2019-03-05 Thread Song Liu
> On Mar 5, 2019, at 3:03 AM, Jiri Olsa wrote: > > On Mon, Mar 04, 2019 at 09:40:07PM +, Song Liu wrote: >> >> >>> On Feb 27, 2019, at 5:21 AM, Jiri Olsa wrote: >>> >>> On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote: >>> >>> SNIP >>> diff --git a/tools/perf/util/evlist

Re: [net 1/1] tipc: fix RDM/DGRAM connect() regression

2019-03-05 Thread David Miller
From: Jon Maloy Date: Mon, 4 Mar 2019 23:26:10 +0100 > From: Erik Hugne > > Fix regression bug introduced in > commit 365ad353c256 ("tipc: reduce risk of user starvation during link > congestion") > > Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached > sockaddr. > > Signed-off

Re: [PATCH][bpf-next] bpf: hbm: fix spelling mistake "deault" -> "default"

2019-03-05 Thread Song Liu
On Tue, Mar 5, 2019 at 9:41 AM Colin King wrote: > > From: Colin Ian King > > There are a couple of typos, fix these. > > Signed-off-by: Colin Ian King I guess this could go to bpf tree. Acked-by: Song Liu > --- > samples/bpf/hbm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH net-next v2] net/sched: act_tunnel_key: Fix double free dst_cache

2019-03-05 Thread David Miller
From: we...@ucloud.cn Date: Tue, 5 Mar 2019 08:29:28 +0800 > From: wenxu > > dst_cache_destroy will be called in dst_release > > dst_release-->dst_destroy_rcu-->dst_destroy-->metadata_dst_free > -->dst_cache_destroy > > It should not call dst_cache_destroy before dst_release > > Fixes: 41411

Re: [PATCH net] ipv4/route: fail early when inet dev is missing

2019-03-05 Thread David Miller
From: Paolo Abeni Date: Tue, 5 Mar 2019 13:49:39 +0100 > If a non local multicast packet reaches ip_route_input_rcu() while > the ingress device is NULL, we end up doing a NULL pointer > dereference in IN_DEV_MFORWARD(). > > Since the later call to ip_route_input_mc() is going to fail if > !in_

Re: [PATCH] samples: bpf: add xdp_sample_pkts to .gitignore

2019-03-05 Thread Song Liu
On Mon, Mar 4, 2019 at 5:25 PM Daniel T. Lee wrote: > > This commit adds xdp_sample_pkts to .gitignore which is > currently ommited from the ignore file. > > Signed-off-by: Daniel T. Lee I think this is for bpf-next tree, which is closed during the merge window. Please resubmit when the tree reo

[PATCH/RFC] tun: defer skb_orphan() to tun_do_read()

2019-03-05 Thread Arthur Kepner
The attachment contains an UNTESTED patch (though a similar patch was tested with a 3.10 kernel). We've been chasing a bug where packet corruption is seen on a tap device. We have a PACKET_MMAP socket which is bound to a tap interface. When throughput goes above a threshold, we begin to se

Re: [PATCH net-next (fix) 0/2] fix GSO bpf_lwt_ip_encap

2019-03-05 Thread Song Liu
On Mon, Mar 4, 2019 at 4:28 PM Peter Oskolkov wrote: > > This is a small fix and a test. Sent to net-next because > the offending patch is not in net yet. For the set: Acked-by: Song Liu > > Peter Oskolkov (2): > net: fix GSO in bpf_lwt_push_ip_encap > selftests/bpf: test that GSO works in

Re: [PATCH/RFC] tun: defer skb_orphan() to tun_do_read()

2019-03-05 Thread Willem de Bruijn
On Tue, Mar 5, 2019 at 4:03 PM Arthur Kepner wrote: > > > The attachment contains an UNTESTED patch (though a similar patch was tested > with a > 3.10 kernel). > > We've been chasing a bug where packet corruption is seen on a tap device. We > have a > PACKET_MMAP socket which is bound to a tap i

RE: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

2019-03-05 Thread Parav Pandit
> -Original Message- > From: Greg KH > Sent: Tuesday, March 5, 2019 1:27 PM > To: Parav Pandit > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > michal.l...@markovi.net; da...@davemloft.net; Jiri Pirko > ; Jakub Kicinski > Subject: Re: [RFC net-next 8/8] net/mlx5: Add subd

Re: [PATCH net v2 2/2] net/mlx5: Avoid panic when setting vport rate

2019-03-05 Thread Saeed Mahameed
On Mon, 2019-03-04 at 15:55 +, Roi Dayan wrote: > > On 04/03/2019 10:27, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > If we try to set VFs rate on a VF (not PF) net device, the kernel > > will be crash. The commands are show as below: > > > > $ echo 2 > /sys/class/net/$ML

Re: [PATCH net v2 1/2] net/mlx5: Avoid panic when setting vport mac, getting vport config

2019-03-05 Thread Saeed Mahameed
On Mon, 2019-03-04 at 15:52 +, Roi Dayan wrote: > > On 04/03/2019 10:27, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > If we try to set VFs mac address on a VF (not PF) net device, > > the kernel will be crash. The commands are show as below: > > > > $ echo 2 > /sys/class/

Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jason Gunthorpe
On Mon, Mar 04, 2019 at 06:11:07PM -0800, Jakub Kicinski wrote: > > At least in RDMA we have drivers doing all combinations of this: > > multiple ports per BDF, one port per BDF, and one composite RDMA > > device formed by combining multiple BDFs worth of ports together. > > Right, last but not l

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-05 Thread Saeed Mahameed
On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: > > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > > Remove redundant assignment to tun_entropy->enabled. > > > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > >

Re: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Kirti Wankhede
On 3/6/2019 1:16 AM, Parav Pandit wrote: > > >> -Original Message- >> From: Jakub Kicinski >> Sent: Monday, March 4, 2019 7:35 PM >> To: Parav Pandit >> Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- >> ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net; >> gre...@

[PATCH v3 bpf-next 3/3] bpf: add tests for bpf_progenyof

2019-03-05 Thread Javier Honduvilla Coto
Adding the following test cases: - progenyof(current->pid) == 1 - progenyof(current->real_parent->pid) == 1 - progenyof(1) == 1 - progenyof(0) == 1 - progenyof(-1) == 0 - progenyof(current->children[0]->pid) == 0 Signed-off-by: Javier Honduvilla Coto --- tools/testing/selftests/bpf/.gitignore

[PATCH v3 bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-05 Thread Javier Honduvilla Coto
This patch adds the bpf_progenyof helper which receives a PID and returns 1 if the process currently being executed is in the process hierarchy including itself or 0 if not. This is very useful in tracing programs when we want to filter by a given PID and all the children it might spawn. The curre

[PATCH v3 bpf-next 0/3] bpf: add bpf_progenyof helper

2019-03-05 Thread Javier Honduvilla Coto
Hi all, This patch add the bpf_progenyof helper which receives a PID and returns 1 if the process currently being executed is in the process hierarchy, including itself or 0 if not. This is very useful in tracing programs when we want to filter by a given PID and all the children it might have. T

[PATCH v3 bpf-next 2/3] bpf: sync kernel uapi headers

2019-03-05 Thread Javier Honduvilla Coto
Sync kernel uapi headers. Signed-off-by: Javier Honduvilla Coto --- tools/include/uapi/linux/bpf.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 3c38ac9a92a7..f72741766ba8 100644 --- a/tools/inclu

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread si-wei liu
On 3/5/2019 12:28 PM, Michael S. Tsirkin wrote: On Tue, Mar 05, 2019 at 11:19:32AM -0800, si-wei liu wrote: On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote: On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote: When a netdev appears through hot plug then gets enslaved by a failover mas

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Gregory Rose
On 3/5/2019 11:58 AM, Joe Stringer wrote: On Tue, Mar 5, 2019 at 2:12 AM Christian Ehrhardt wrote: On Tue, Mar 5, 2019 at 10:58 AM Juerg Haefliger wrote: Hi, Running the following commands in a loop will crash an i386 5.0 kernel typically within a few iterations: ovs-vsctl add-br test ovs

RE: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Parav Pandit
Hi Kirti, > -Original Message- > From: Kirti Wankhede > Sent: Tuesday, March 5, 2019 4:40 PM > To: Parav Pandit ; Jakub Kicinski > > Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net; > gre...@linuxfoundation.org; Jiri

RE: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Parav Pandit
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Tuesday, March 5, 2019 5:17 PM > To: Kirti Wankhede ; Jakub Kicinski > > Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; michal.l...@markovi

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote: > > > On 3/5/2019 11:24 AM, Stephen Hemminger wrote: > > On Tue, 5 Mar 2019 11:19:32 -0800 > > si-wei liu wrote: > > > > > > I have a vague idea: would it work to *not* set > > > > IFF_UP on slave devices at all? > > > Hmm, I ever thou

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread si-wei liu
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote: On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote: On 3/5/2019 11:24 AM, Stephen Hemminger wrote: On Tue, 5 Mar 2019 11:19:32 -0800 si-wei liu wrote: I have a vague idea: would it work to *not* set IFF_UP on slave devices at all? H

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Gregory Rose
On 3/5/2019 2:52 PM, Gregory Rose wrote: I have an i386 Ubuntu 18 VM to test this on.  I'll investigate and see what I can find. - Greg I have a repro.  It's not the same kernel (4.13 in my case) but looks like the same issue. - Greg

Re: [PATCH] net/sched: avoid unused-label warning

2019-03-05 Thread Cong Wang
On Mon, Mar 4, 2019 at 12:40 PM Arnd Bergmann wrote: > > The label is only used from inside the #ifdef and should be > hidden the same way, to avoid this warning: > > net/sched/act_tunnel_key.c: In function 'tunnel_key_init': > net/sched/act_tunnel_key.c:389:1: error: label 'release_tun_meta' defi

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote: > > > On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote: > > On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote: > > > > > > On 3/5/2019 11:24 AM, Stephen Hemminger wrote: > > > > On Tue, 5 Mar 2019 11:19:32 -0800 > > > > si-wei liu

RE: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-05 Thread Parav Pandit
Hi Greg, Kirti, > -Original Message- > From: Parav Pandit > Sent: Tuesday, March 5, 2019 5:45 PM > To: Parav Pandit ; Kirti Wankhede > ; Jakub Kicinski > Cc: Or Gerlitz ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; michal.l...@markovi.net; da...@davemloft.net; > gre...@linuxf

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-03-05 Thread si-wei liu
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote: On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote: On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote: On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote: On 3/5/2019 11:24 AM, Stephen Hemminger wrote: On Tue, 5 Mar 2019 11:19:32

general protection fault in sctp_sched_rr_dequeue

2019-03-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:63bdf4284c38 Merge branch 'linus' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=100347cb20 kernel config: https://syzkaller.appspot.com/x/.config?x=872be05707464aaa da

  1   2   >