Re: [PATCH bpf-next 0/2] bpf: offer maximum packet offset info

On 11/08/2018 10:08 AM, Jiong Wang wrote: > The maximum packet offset accessed by one BPF program is useful > information. > > Because sometimes there could be packet split and it is possible for some > reasons (for example performance) we want to reject the BPF program if the > maximum packet siz

Re: [iproute2 PATCH v2] tc: flower: Classify packets based port ranges

Wed, Nov 07, 2018 at 10:22:50PM CET, amritha.namb...@intel.com wrote: >Added support for filtering based on port ranges. > >Example: >1. Match on a port range: >- >$ tc filter add dev enp4s0 protocol ip parent :\ > prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw

[PATCH][net-next] net: tcp: remove BUG_ON from tcp_v4_err

if skb is NULL pointer, and the following access of skb's skb_mstamp_ns will trigger panic, which is same as BUG_ON Signed-off-by: Li RongQing --- net/ipv4/tcp_ipv4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index a336787d75e5..5424a4077c27 100

Re: [PATCH bpf-next] bpftool: Improve handling of ENOENT on map dumps

On 11/08/2018 10:25 PM, Jakub Kicinski wrote: > On Thu, 8 Nov 2018 13:00:07 -0800, David Ahern wrote: >> From: David Ahern >> >> bpftool output is not user friendly when dumping a map with only a few >> populated entries: >> >> $ bpftool map >> 1: devmap name tx_devmap flags 0x0 >>

[PATCH net-next] cxgb4: free mac_hlist properly

The locally maintained list for tracking hash mac table was not freed during driver remove. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/chelsio/c

[PATCH net-next] cxgb4vf: fix memleak in mac_hlist initialization

mac_hlist was initialized during adapter_up, which will be called every time a vf device is first brought up, or every time when device is brought up again after bringing all devices down. This means our state of previous list is lost, causing a memleak if entries are present in the list. To fix th

[PATCH net-next] cxgb4vf: free mac_hlist properly

The locally maintained list for tracking hash mac table was not freed during driver remove. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/chelsio

Re: [PATCH v2 bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

On 10/29/2018 05:02 AM, Nitin Hande wrote: > > This patch proposes to extend the sk_lookup() BPF API to the > XDP hookpoint. The sk_lookup() helper supports a lookup > on incoming packet to find the corresponding socket that will > receive this packet. Current support for this BPF API is > at the

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

W dniu 09.11.2018 o 05:52, Saeed Mahameed pisze: On Thu, 2018-11-08 at 17:42 -0700, David Ahern wrote: On 11/8/18 5:40 PM, Paweł Staszewski wrote: W dniu 08.11.2018 o 17:32, David Ahern pisze: On 11/8/18 9:27 AM, Paweł Staszewski wrote: What hardware is this? mellanox connectx 4 ethtool

[PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW uses this channel for DMAE operations (e.g., TIME_SYNC implementation). Driver also uses the same channel 0 for DMAE operations for some of the PFs (e.g., PF0 on Port0). This could lead to concurrent access to the DMAE channel

[PATCH net-next 2/8] ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl

If a gettime64 call fails, return the error and avoid copying data back to user. Cc: Richard Cochran Cc: Jacob Keller Signed-off-by: Miroslav Lichvar --- drivers/ptp/ptp_chardev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/pt

[PATCH net-next 1/8] ptp: reorder declarations in ptp_ioctl()

Reorder declarations of variables as reversed Christmas tree. Cc: Richard Cochran Suggested-by: Richard Cochran Signed-off-by: Miroslav Lichvar --- drivers/ptp/ptp_chardev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/ptp/ptp_chardev.c b/drivers/p

[PATCH net-next 3/8] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl

The PTP_SYS_OFFSET ioctl, which can be used to measure the offset between a PHC and the system clock, includes the total time that the driver needs to read the PHC timestamp. This typically involves reading of multiple PCI registers (sometimes in multiple iterations) and the register that contains

[PATCH net-next 0/8] More accurate PHC<->system clock synchronization

RFC->v1: - added new patches - separated PHC timestamp from ptp_system_timestamp - fixed memory leak in PTP_SYS_OFFSET_EXTENDED - changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays - fixed PTP_SYS_OFFSET_EXTENDED to break correctly from loop - fixed timecounter updates in drivers - split

[PATCH net-next 4/8] ptp: deprecate gettime64() in favor of gettimex64()

When a driver provides gettimex64(), use it in the PTP_SYS_OFFSET ioctl and POSIX clock's gettime() instead of gettime64(). Drivers should provide only one of the functions. Cc: Richard Cochran Cc: Jacob Keller Signed-off-by: Miroslav Lichvar --- drivers/ptp/ptp_chardev.c| 5 - dri

[PATCH net-next 5/8] e1000e: extend PTP gettime function to read system clock

This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. Cc: Richard Cochran Cc: Jacob Keller Cc: Jeff Kirsher Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++ drivers/net/ethernet/intel/e1000e/netdev.c | 42 -- drivers/net/ethernet/i

[PATCH net-next 6/8] igb: extend PTP gettime function to read system clock

This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. Cc: Richard Cochran Cc: Jacob Keller Cc: Jeff Kirsher Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/igb/igb_ptp.c | 65 1 file changed, 55 insertions(+), 10 deletions(-) diff --git a/drivers/ne

[PATCH net-next 8/8] tg3: extend PTP gettime function to read system clock

This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. Cc: Richard Cochran Cc: Michael Chan Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/broadcom/tg3.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/

[PATCH net-next 7/8] ixgbe: extend PTP gettime function to read system clock

This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. Cc: Richard Cochran Cc: Jacob Keller Cc: Jeff Kirsher Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 54 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/drivers/ne

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

W dniu 08.11.2018 o 17:06, David Ahern pisze: On 11/8/18 6:33 AM, Paweł Staszewski wrote: W dniu 07.11.2018 o 22:06, David Ahern pisze: On 11/3/18 6:24 PM, Paweł Staszewski wrote: Does your setup have any other device types besides physical ports with VLANs (e.g., any macvlans or bonds)?

Re: [PATCH 08/20] octeontx2-af: Alloc and config NPC MCAM entry at a time

On Fri, Nov 9, 2018 at 5:21 AM Sunil Kovvuri wrote: > > On Fri, Nov 9, 2018 at 2:13 AM Arnd Bergmann wrote: > > > > On Thu, Nov 8, 2018 at 7:37 PM wrote: > > > @@ -666,4 +668,20 @@ struct npc_mcam_unmap_counter_req { > > > u8 all; /* Unmap all entries using this counter ? */ > > > };

Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling

On Fri, Nov 9, 2018 at 5:35 AM Sunil Kovvuri wrote: > On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:36 PM wrote: > > > From: Sunil Goutham > > > > Hmm, I noticed that you use a different address as the patch author > > and the submitter. I'm guessing that "Sun

Re: [PATCH 11/20] octeontx2-af: Add support for stripping STAG/CTAG

On Fri, Nov 9, 2018 at 5:29 AM Sunil Kovvuri wrote: > On Fri, Nov 9, 2018 at 2:17 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:37 PM wrote: > > > > Here is another instance of bitfields in an interface structure. As > > before, please try to avoid doing that and use bit shifts and masks

[PATCH net 0/5] net: aquantia: 2018-11 bugfixes

The patchset fixes a number of bugs found in various areas after driver validation. Dmitry Bogdanov (3): net: aquantia: fix potential IOMMU fault after driver unbind net: aquantia: invalid checksumm offload implementation net: aquantia: allow rx checksum offload configuration Igor Russkikh

[PATCH net 1/5] net: aquantia: synchronized flow control between mac/phy

Flow control statuses were not synchronized between blocks, that caused packets/link drop on some corner cases, when MAC sent PFC although Phy was not expecting these to come. Driver should readout the negotiated FC from phy and configure RX block accordigly. This is done on each link change even

[PATCH net 2/5] net: aquantia: fix potential IOMMU fault after driver unbind

From: Dmitry Bogdanov IOMMU fault may occurr on unbind/bind or if_down/if_up sequence. Although driver disables the rings on down, this is not enough. Due to internal HW design, during subsequent initialization NIC sometimes may reuse RX descriptors cache and write to the host memory from the de

[PATCH net 4/5] net: aquantia: invalid checksumm offload implementation

From: Dmitry Bogdanov Packets with marked invalid IP/UDP/TCP checksums were considered as good by the driver. The error was in a logic, processing offload bits in RX descriptor. Signed-off-by: Igor Russkikh Signed-off-by: Dmitry Bogdanov --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c

[PATCH net 3/5] net: aquantia: fixed enable unicast on 32 macvlan

Fixed a condition mistake due to which macvlans unicast item number 32 was not added in the unicast filter. The consequence is that when exactly 32 macvlans are created on NIC, the last created macvlan receives no traffic because its MAC was not registered in HW. Fixes: 94b3b542303f ("net: aquant

[PATCH net 5/5] net: aquantia: allow rx checksum offload configuration

From: Dmitry Bogdanov RX Checksum offloads could not be configured and ignored netdev features flag for checksumming. Signed-off-by: Igor Russkikh Signed-off-by: Dmitry Bogdanov --- drivers/net/ethernet/aquantia/atlantic/aq_hw.h| 3 +++ drivers/net/ethernet/aquantia/atlantic/aq_m

Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges

Wed, Nov 07, 2018 at 10:22:42PM CET, amritha.namb...@intel.com wrote: >Added support in tc flower for filtering based on port ranges. > >Example: >1. Match on a port range: >- >$ tc filter add dev enp4s0 protocol ip parent :\ > prio 1 flower ip_proto tcp dst_port range

Re: [PATCH iproute2-next] devlink: Add missing region option to devlink man page

Thu, Nov 08, 2018 at 10:14:13AM CET, va...@mellanox.com wrote: >The region field was not added to the devlink man page. > >Fixes: 8b4fbf0bed8e6 ("devlink: Add support for devlink-region access") >Signed-off-by: Alex Vesker Acked-by: Jiri Pirko

[PATCH bpf-next 0/9] bpf: pass device ops as callbacks and remove some ndo_bpf subcommands

For passing device functions for offloaded eBPF programs, there used to be no place where to store the pointer without making the non-offloaded programs pay a memory price. As a consequence, three functions were called with ndo_bpf() through specific commands. Now that we have struct bpf_offload_d

[PATCH bpf-next 3/9] bpf: call verify_insn from its callback in struct bpf_offload_dev

We intend to remove the dev_ops in struct bpf_prog_offload, and to only keep the ops in struct bpf_offload_dev instead, which is accessible from more locations for passing function pointers. But dev_ops is used for calling the verify_insn hook. Switch to the newly added ops in struct bpf_prog_offl

[PATCH bpf-next 6/9] bpf: pass translate() as a callback and remove its ndo_bpf subcommand

As part of the transition from ndo_bpf() to callbacks attached to struct bpf_offload_dev for some of the eBPF offload operations, move the functions related to code translation to the struct and remove the subcommand that was used to call them through the NDO. Signed-off-by: Quentin Monnet Review

[PATCH bpf-next 8/9] bpf: pass prog instead of env to bpf_prog_offload_verifier_prep()

Function bpf_prog_offload_verifier_prep(), called from the kernel BPF verifier to run a driver-specific callback for preparing for the verification step for offloaded programs, takes a pointer to a struct bpf_verifier_env object. However, no driver callback needs the whole structure at this time: t

[PATCH bpf-next 2/9] bpf: pass a struct with offload callbacks to bpf_offload_dev_create()

For passing device functions for offloaded eBPF programs, there used to be no place where to store the pointer without making the non-offloaded programs pay a memory price. As a consequence, three functions were called with ndo_bpf() through specific commands. Now that we have struct bpf_offload_d

[PATCH bpf-next 1/9] nfp: bpf: move nfp_bpf_analyzer_ops from verifier.c to offload.c

We are about to add several new callbacks to the struct, all of them defined in offload.c. Move the struct bpf_prog_offload_ops object in that file. As a consequence, nfp_verify_insn() and nfp_finalize() can no longer be static. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- driv

[PATCH bpf-next 5/9] bpf: call verifier_prep from its callback in struct bpf_offload_dev

In a way similar to the change previously brought to the verify_insn hook and to the finalize callback, switch to the newly added ops in struct bpf_prog_offload for calling the functions used to prepare driver verifiers. Since the dev_ops pointer in struct bpf_prog_offload is no longer used by any

[PATCH bpf-next 4/9] bpf: call finalize() from its callback in struct bpf_offload_dev

In a way similar to the change previously brought to the verify_insn hook, switch to the newly added ops in struct bpf_prog_offload for calling the functions used to perform final verification steps for offloaded programs. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- kernel/bpf

[PATCH bpf-next 7/9] bpf: pass destroy() as a callback and remove its ndo_bpf subcommand

As part of the transition from ndo_bpf() to callbacks attached to struct bpf_offload_dev for some of the eBPF offload operations, move the functions related to program destruction to the struct and remove the subcommand that was used to call them through the NDO. Remove function __bpf_offload_ndo(

[PATCH bpf-next 9/9] bpf: do not pass netdev to translate() and prepare() offload callbacks

The kernel functions to prepare verifier and translate for offloaded program retrieve "offload" from "prog", and "netdev" from "offload". Then both "prog" and "netdev" are passed to the callbacks. Simplify this by letting the drivers retrieve the net device themselves from the offload object attac

bring back IPX and NCPFS, please!

Hello all! I like to please you to bring back IPX and NCPFS modules to the kernel. Whyever my admins using Novell-shares on our network which I'm not be able to use anymore - I'm forced to use cifs instead (and the admins will kill the cifs-shares in some time), because my kernel (4.18) does not h

Re: [PATCH v4 bpf-next 5/7] bpftool: add loadall command

2018-11-08 16:22 UTC-0800 ~ Stanislav Fomichev > From: Stanislav Fomichev > > This patch adds new *loadall* command which slightly differs from the > existing *load*. *load* command loads all programs from the obj file, > but pins only the first programs. *loadall* pins all programs from the > o

Re: [PATCH][RFC] udp: cache sock to avoid searching it twice

Hi, Adding Willem, I think he can be interested. On Fri, 2018-11-09 at 14:21 +0800, Li RongQing wrote: > GRO for UDP needs to lookup socket twice, first is in gro receive, > second is gro complete, so if store sock to skb to avoid looking up > twice, this can give small performance boost > > net

RE: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate

> > The fsl_mc_object_allocate function can fail because not all > > allocatable objects are probed by the fsl_mc_allocator at the call > > time. Defer the dpaa2-eth probe when this happens. > > > > Signed-off-by: Ioana Ciornei > > --- > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 30 > >

Re: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate

Hi Ioana > I will send a v2 changing the return value to -ENODEV in case no > cpus with an affine DPIO is found. It would be good to review all the cases where IS_ERR_OR_NULL() is used. It is very easy to get wrong. In fact, it has been suggested this macro is removed, because it is used wrongly

RE: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate

> Hi Ioana > > > I will send a v2 changing the return value to -ENODEV in case no cpus > > with an affine DPIO is found. > > It would be good to review all the cases where IS_ERR_OR_NULL() is used. It is > very easy to get wrong. In fact, it has been suggested this macro is removed, > because it

Re: [PATCH] net: Add trace events for all receive exit points

On Thu, 8 Nov 2018 14:56:48 -0500 Geneviève Bastien wrote: > Trace events are already present for the receive entry points, to indicate > how the reception entered the stack. > > This patch adds the corresponding exit trace events that will bound the > reception such that all events occurring b

[PATCH net-next] udp6: cleanup stats accounting in recvmsg()

In the udp6 code path, we needed multiple tests to select the correct mib to be updated. Since we touch at least a counter at each iteration, it's convenient to use the recently introduced __UDPX_MIB() helper once and remove some code duplication. Signed-off-by: Paolo Abeni --- net/ipv6/udp.c |

[PATCH net-next v2 1/2] dpaa2-eth: defer probe on object allocate

The fsl_mc_object_allocate function can fail because not all allocatable objects are probed by the fsl_mc_allocator at the call time. Defer the dpaa2-eth probe when this happens. Signed-off-by: Ioana Ciornei --- Changes in v2: - proper handling of IS_ERR_OR_NULL drivers/net/ethernet/freescal

[PATCH net-next v2 0/2] dpaa2-eth: defer probe on object allocate

Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator after the first attempts of other drivers to use them. Defer the probe when this situation happens. Changes in v2: - proper handling of IS_ERR_OR_NULL Ioana Ciornei (2): dpaa2-eth: defer probe on object allocate dpa

[PATCH net-next v2 2/2] dpaa2-ptp: defer probe when portal allocation failed

The fsl_mc_portal_allocate can fail when the requested MC portals are not yet probed by the fsl_mc_allocator. In this situation, the driver should defer the probe. Signed-off-by: Ioana Ciornei --- Changes in v2: - none drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 5 - 1 file changed

Re: [PATCH v4 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

On 11/08, Jakub Kicinski wrote: > On Thu, 8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote: > > + for (map = bpf_map__prev(map, obj); > > +map != NULL; > > +map = bpf_map__prev(map, obj)) { > > nit pick: if you need to respin all these for loops on error paths could >

Re: [PATCH v4 bpf-next 5/7] bpftool: add loadall command

On 11/09, Quentin Monnet wrote: > 2018-11-08 16:22 UTC-0800 ~ Stanislav Fomichev > > From: Stanislav Fomichev > > > > This patch adds new *loadall* command which slightly differs from the > > existing *load*. *load* command loads all programs from the obj file, > > but pins only the first progra

Re: [PATCH iproute2] bridge: fdb: remove redundant dev string in show output

On Thu, 8 Nov 2018 10:35:05 +0100 Phil Sutter wrote: > Hi Roopa, > > On Wed, Nov 07, 2018 at 03:14:09PM -0800, Roopa Prabhu wrote: > > From: Roopa Prabhu > > > > After commit 4abb8c723a64 ("bridge: fdb: Fix for missing > > keywords in non-JSON output"), I am seeing a double print for dev > > i

Re: Should the bridge learn from frames with link local destination MAC address?

On Fri, 9 Nov 2018 04:24:43 +0100 Andrew Lunn wrote: > Hi Roopa, Nikolay > > br_handle_frame() looks out for frames with a destination MAC > addresses with is Ethernet link local, those which fit > 01-80-C2-00-00-XX. It does not normally forward these, but it will > deliver them locally. > > Sh

Re: bring back IPX and NCPFS, please!

On Fri, 9 Nov 2018 14:23:27 +0100 "Johannes C. Schulz" wrote: > Hello all! > > I like to please you to bring back IPX and NCPFS modules to the kernel. > Whyever my admins using Novell-shares on our network which I'm not be > able to use anymore - I'm forced to use cifs instead (and the admins >

Re: [PATCH iproute2] bridge: fdb: remove redundant dev string in show output

On Wed, 7 Nov 2018 15:14:09 -0800 Roopa Prabhu wrote: > From: Roopa Prabhu > > After commit 4abb8c723a64 ("bridge: fdb: Fix for missing > keywords in non-JSON output"), I am seeing a double print for dev > in bridge fdb show. eg: > "44:38:39:00:6a:82 dev dev bridge vlan 1 master bridge permane

Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage

On Fri, 2 Nov 2018 10:57:41 + Luca Boccassi wrote: > ". If" gets interpreted as a macro, so move the period to the previous > line: > > 33: warning: macro `If' not defined > > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") > > Signed-off-by: Luca Boccassi Applied

Re: [PATCH iproute2] man: ss.8: break and indent long line

On Fri, 2 Nov 2018 13:27:48 + Luca Boccassi wrote: > Fixes groff warning: > ss.8 92: warning [p 2, 2.8i]: can't break line > > And makes the line also more readable. > > Signed-off-by: Luca Boccassi Applied

Re: [PATCH iproute2 1/2] testsuite: build generate_nlmsg with QUIET_CC

On Fri, 2 Nov 2018 12:35:43 + Luca Boccassi wrote: > Follow the standard pattern, and respect user's verbosity setting. > > Signed-off-by: Luca Boccassi Both applied

Re: bring back IPX and NCPFS, please!

On Fri, Nov 09, 2018 at 02:23:27PM +0100, Johannes C. Schulz wrote: > Hello all! > > I like to please you to bring back IPX and NCPFS modules to the kernel. > Whyever my admins using Novell-shares on our network which I'm not be > able to use anymore - I'm forced to use cifs instead (and the admin

Re: [iproute2 PATCH v2] tc: flower: Classify packets based port ranges

On Wed, 07 Nov 2018 13:22:50 -0800 Amritha Nambiar wrote: > Added support for filtering based on port ranges. > > Example: > 1. Match on a port range: > - > $ tc filter add dev enp4s0 protocol ip parent :\ > prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\ >

Re: [PATCH iproute2] tc: f_u32: allow skip_hw and skip_sw flags to be last

On Mon, 5 Nov 2018 19:23:27 -0800 Jakub Kicinski wrote: > u32 uses NEXT_ARG() incorrectly when parsing skip_hw and skip_sw > flags. NEXT_ARG() ensures there is another argument on the command > line, and is used in handling syntax to move past > and ensure there is a to read. > > Commit 5e

Re: [PATCH mlx5-next 02/10] IB/mlx5: Avoid hangs due to a missing completion

On Thu, Nov 08, 2018 at 07:44:44PM +, Jason Gunthorpe wrote: > On Thu, Nov 08, 2018 at 09:10:09PM +0200, Leon Romanovsky wrote: > > From: Moni Shoua > > > > Fix 2 flows that may cause a process to hang on wait_for_completion(): > > > > 1. When callback for create MKEY command returns with bad

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

On 11/9/18 3:20 AM, Paweł Staszewski wrote: > > I just catch some weird behavior :) > All was working fine for about 20k packets > > Then after xdp start to forward every 10 packets Interesting. Any counter showing drops? > ping 172.16.0.2 -i 0.1 > PING 172.16.0.2 (172.16.0.2) 56(84) bytes of

[PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector

v5 changes: * FILE -> PATH for load/loadall (can be either file or directory now) * simpler implementation for __bpf_program__pin_name * removed p_err for REQ_ARGS checks * parse_atach_detach_args -> parse_attach_detach_args * for -> while in bpf_object__pin_{programs,maps} recovery v4 changes: *

[PATCH v5 bpf-next 6/7] bpftool: add pinmaps argument to the load/loadall

This new additional argument lets users pin all maps from the object at specified path. Signed-off-by: Stanislav Fomichev Acked-by: Jakub Kicinski --- .../bpftool/Documentation/bpftool-prog.rst| 4 +++- tools/bpf/bpftool/bash-completion/bpftool | 3 ++- tools/bpf/bpftool/prog.c

[PATCH v5 bpf-next 5/7] bpftool: add loadall command

This patch adds new *loadall* command which slightly differs from the existing *load*. *load* command loads all programs from the obj file, but pins only the first programs. *loadall* pins all programs from the obj file under specified directory. The intended usecase is flow_dissector, where we wa

[PATCH v5 bpf-next 3/7] libbpf: bpf_program__pin: add special case for instances.nr == 1

When bpf_program has only one instance, don't create a subdirectory with per-instance pin files (/0). Instead, just create a single pin file for that single instance. This simplifies object pinning by not creating unnecessary subdirectories. This can potentially break existing users that depend on

[PATCH v5 bpf-next 1/7] selftests/bpf: rename flow dissector section to flow_dissector

Makes it compatible with the logic that derives program type from section name in libbpf_prog_type_by_name. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/bpf_flow.c | 2 +- tools/testing/selftests/bpf/test_flow_dissector.sh | 2 +- 2 files changed, 2 insertions(+)

[PATCH v5 bpf-next 4/7] libbpf: add internal pin_name

pin_name is the same as section_name where '/' is replaced by '_'. bpf_object__pin_programs is converted to use pin_name to avoid the situation where section_name would require creating another subdirectory for a pin (as, for example, when calling bpf_object__pin_programs for programs in sections l

[PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

bpftool will use bpf_object__pin in the next commits to pin all programs and maps from the file; in case of a partial failure, we need to get back to the clean state (undo previous program/map pins). As part of a cleanup, I've added and exported separate routines to pin all maps (bpf_object__pin_m

[PATCH v5 bpf-next 7/7] bpftool: support loading flow dissector

This commit adds support for loading/attaching/detaching flow dissector program. When `bpftool loadall` is called with a flow_dissector prog (i.e. when the 'type flow_dissector' argument is passed), we load and pin all programs. User is responsible to construct the jump table for the tail calls.

Re: Should the bridge learn from frames with link local destination MAC address?

On Fri, Nov 9, 2018 at 8:00 AM Stephen Hemminger wrote: > > On Fri, 9 Nov 2018 04:24:43 +0100 > Andrew Lunn wrote: > > > Hi Roopa, Nikolay > > > > br_handle_frame() looks out for frames with a destination MAC > > addresses with is Ethernet link local, those which fit > > 01-80-C2-00-00-XX. It doe

Re: [PATCH mlx5-next 08/10] IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously

On Thu, Nov 08, 2018 at 07:49:03PM +, Jason Gunthorpe wrote: > On Thu, Nov 08, 2018 at 09:10:15PM +0200, Leon Romanovsky wrote: > > From: Moni Shoua > > > > Telling the HCA that page fault handling is done and QP can resume > > its flow is done in the context of the page fault handler. This bl

[PATCH iproute2] testsuite: correctly use CC macros for generate_nlmsg

It's $(QUIET_CC)$(CC) not $(QUIET_CC), copy-paste error. CI does verbose build so it slipped through. Fixes: 6e7d347aabbb ("testsuite: build generate_nlmsg with QUIET_CC") Signed-off-by: Luca Boccassi --- testsuite/tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Should the bridge learn from frames with link local destination MAC address?

On 9 November 2018 18:24:18 EET, Roopa Prabhu wrote: >On Fri, Nov 9, 2018 at 8:00 AM Stephen Hemminger > wrote: >> >> On Fri, 9 Nov 2018 04:24:43 +0100 >> Andrew Lunn wrote: >> >> > Hi Roopa, Nikolay >> > >> > br_handle_frame() looks out for frames with a destination MAC >> > addresses with is Et

Re: [PATCH iproute2 net-next v2 0/2] Add DF configuration for VXLAN and GENEVE link types

On 11/8/18 4:21 AM, Stefano Brivio wrote: > This series adds configuration of the DF bit in outgoing IPv4 packets for > VXLAN and GENEVE link types. > > Stefano Brivio (2): > iplink_vxlan: Add DF configuration > iplink_geneve: Add DF configuration > > include/uapi/linux/if_link.h | 18 ++

Re: [PATCH mlx5-next 08/10] IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously

On Fri, Nov 09, 2018 at 06:26:22PM +0200, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 07:49:03PM +, Jason Gunthorpe wrote: > > On Thu, Nov 08, 2018 at 09:10:15PM +0200, Leon Romanovsky wrote: > > > From: Moni Shoua > > > > > > Telling the HCA that page fault handling is done and QP can re

Re: [PATCH 11/20] octeontx2-af: Add support for stripping STAG/CTAG

On Fri, Nov 9, 2018 at 4:42 PM Arnd Bergmann wrote: > > On Fri, Nov 9, 2018 at 5:29 AM Sunil Kovvuri wrote: > > On Fri, Nov 9, 2018 at 2:17 AM Arnd Bergmann wrote: > > > On Thu, Nov 8, 2018 at 7:37 PM wrote: > > > > > > > Here is another instance of bitfields in an interface structure. As > > >

Re: [PATCH iproute] ss: Actually print left delimiter for columns

On Mon, 29 Oct 2018 23:04:25 +0100 Stefano Brivio wrote: > While rendering columns, we use a local variable to keep track of the > field currently being printed, without touching current_field, which is > used for buffering. > > Use the right pointer to access the left delimiter for the current

Re: [PATCH][net-next] net: tcp: remove BUG_ON from tcp_v4_err

On 11/09/2018 01:04 AM, Li RongQing wrote: > if skb is NULL pointer, and the following access of skb's > skb_mstamp_ns will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing > --- > net/ipv4/tcp_ipv4.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ipv4/tcp_i

Re: [PATCH 08/20] octeontx2-af: Alloc and config NPC MCAM entry at a time

On Fri, Nov 9, 2018 at 4:32 PM Arnd Bergmann wrote: > > On Fri, Nov 9, 2018 at 5:21 AM Sunil Kovvuri wrote: > > > > On Fri, Nov 9, 2018 at 2:13 AM Arnd Bergmann wrote: > > > > > > On Thu, Nov 8, 2018 at 7:37 PM wrote: > > > > @@ -666,4 +668,20 @@ struct npc_mcam_unmap_counter_req { > > > >

Re: [PATCH bpf-next 2/4] bpf: Split bpf_sk_lookup

On Thu, Nov 08, 2018 at 08:54:23AM -0800, Andrey Ignatov wrote: > Split bpf_sk_lookup to separate core functionality, that can be reused > to make socket lookup available to more program types, from > functionality specific to program types that have access to skb. > > Core functionality is placed

Re: [PATCH bpf-next 3/4] bpf: Support socket lookup in CGROUP_SOCK_ADDR progs

On Thu, Nov 08, 2018 at 08:54:24AM -0800, Andrey Ignatov wrote: > Make bpf_sk_lookup_tcp, bpf_sk_lookup_udp and bpf_sk_release helpers > available in programs of type BPF_PROG_TYPE_CGROUP_SOCK_ADDR. > > Such programs operate on sockets and have access to socket and struct > sockaddr passed by user

Re: [PATCH][RFC] udp: cache sock to avoid searching it twice

On 11/08/2018 10:21 PM, Li RongQing wrote: > GRO for UDP needs to lookup socket twice, first is in gro receive, > second is gro complete, so if store sock to skb to avoid looking up > twice, this can give small performance boost > > netperf -t UDP_RR -l 10 > > Before: > Rate per sec: 287

Re: [PATCH bpf-next 4/4] selftest/bpf: Use bpf_sk_lookup_{tcp,udp} in test_sock_addr

On Thu, Nov 08, 2018 at 08:54:25AM -0800, Andrey Ignatov wrote: > Use bpf_sk_lookup_tcp, bpf_sk_lookup_udp and bpf_sk_release helpers from > test_sock_addr programs to make sure they're available and can lookup > and release socket properly for IPv4/IPv4, TCP/UDP. > > Reading from a few fields of

Re: bring back IPX and NCPFS, please!

Hello Willy, hello Stephen Thankyou for your reply. But I'm not able to maintain or code these modules. I'm just a bloody user/webdev. It would be really nice if these modules will find a good maintainer! Best regards Johannes Am Fr., 9. Nov. 2018 um 17:09 Uhr schrieb Willy Tarreau : > > On Fri,

Re: [PATCH bpf-next 2/4] bpf: Split bpf_sk_lookup

Martin Lau [Fri, 2018-11-09 09:19 -0800]: > On Thu, Nov 08, 2018 at 08:54:23AM -0800, Andrey Ignatov wrote: > > Split bpf_sk_lookup to separate core functionality, that can be reused > > to make socket lookup available to more program types, from > > functionality specific to program types that ha

[PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

As a heritage from the very early days of phylib member interrupts is defined as u32 even though it's just a flag whether interrupts are enabled. So we can change it to a bitfield member. In addition change the code dealing with this member in a way that it's clear we're dealing with a bool value.

Re: [PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector

2018-11-09 08:21 UTC-0800 ~ Stanislav Fomichev > v5 changes: > * FILE -> PATH for load/loadall (can be either file or directory now) > * simpler implementation for __bpf_program__pin_name > * removed p_err for REQ_ARGS checks > * parse_atach_detach_args -> parse_attach_detach_args > * for -> while

[PATCH net-next 0/3] net: phy: further phylib simplifications after recent changes to the state machine

After the recent changes to the state machine phylib can be further simplified (w/o having to make any assumptions). Heiner Kallweit (3): net: phy: don't set state PHY_CHANGELINK in phy_change net: phy: simplify phy_mac_interrupt and related functions net: phy: improve and inline phy_change

[PATCH net-next 2/3] net: phy: simplify phy_mac_interrupt and related functions

When using phy_mac_interrupt() the irq number is set to PHY_IGNORE_INTERRUPT, therefore phy_interrupt_is_valid() returns false. As a result phy_change() effectively just calls phy_trigger_machine() when called from phy_mac_interrupt() via phy_change_work(). So we can call phy_trigger_machine() from

[PATCH net-next 1/3] net: phy: don't set state PHY_CHANGELINK in phy_change

State PHY_CHANGELINK isn't needed here, we can call the state machine directly. We just have to remove the check for phy_polling_mode() to make this work also in interrupt mode. Removing this check doesn't cause any overhead because when not polling the state machine is called only if required by s

[PATCH net-next 3/3] net: phy: improve and inline phy_change

Now that phy_mac_interrupt() doesn't call phy_change() any longer it's called from phy_interrupt() only. Therefore phy_interrupt_is_valid() returns true always and the check can be removed. In case of PHY_HALTED phy_interrupt() bails out immediately, therefore the second check for PHY_HALTED includ

RE: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization

> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, November 09, 2018 2:15 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Keller, Jacob E > ; Miroslav Lichvar ; Marcelo > Tosatti ; Kirsher, Jeffrey T > ; > Michael Chan > Subject: [PATCH net-

[PATCH] add an initial version of snmp_counter.rst

The snmp_counter.rst run a set of simple experiments, explains the meaning of snmp counters depend on the experiments' results. This is an initial version, only covers a small part of the snmp counters. Signed-off-by: yupeng --- Documentation/networking/index.rst| 1 + Documentation/ne

RE: [PATCH net-next 7/8] ixgbe: extend PTP gettime function to read system clock

> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, November 09, 2018 2:15 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Keller, Jacob E > ; Miroslav Lichvar ; Kirsher, > Jeffrey T > Subject: [PATCH net-next 7/8] ixgbe: extend PTP gettime fu

[PATCH bpf-next] selftests/bpf: Fix uninitialized duration warning

Daniel Borkmann reports: test_progs.c: In function ‘main’: test_progs.c:81:3: warning: ‘duration’ may be used uninitialized in this function [-Wmaybe-uninitialized] printf("%s:PASS:%s %d nsec\n", __func__, tag, duration);\ ^~ test_progs.c:1706:8: note: ‘duration’ was declared here __u

  1   2   >