Re: [RFC PATCH 1/3] acpi: Add acpi mdio support code

2018-11-08 Thread Rafael J. Wysocki
On Thursday, November 8, 2018 8:55:47 AM CET Wang, Dongsheng wrote: > On 2018/11/8 15:44, Rafael J. Wysocki wrote: > > On Thursday, November 8, 2018 8:22:16 AM CET Wang Dongsheng wrote: > >> Add support for parsing the ACPI data node for PHY devices on an MDIO bus. > >> The current implementation d

a propose of snmp counter document

2018-11-08 Thread peng yu
I'm planing to write a document which explains the meaning of the kernel snmp counters, and combine the explanations with some tests, because I found lots of the 'TcpExt' and 'IpExt' counters are not explained in any document. Here is a draft: https://github.com/yupeng0921/iproute2_learning/blob/ma

Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group

2018-11-08 Thread David Miller
From: Hangbin Liu Date: Thu, 8 Nov 2018 15:44:10 +0800 > On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote: >> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we >> change sysctl_mld_qrv after interface up, it will has no effect. >> >> Fix it by assigning latest sy

Re: SACK compression patch causing performance drop

2018-11-08 Thread Jean-Louis Dupond
Hi, Was somebody able to check this? Really think this should be fixed :) Thanks Jean-Louis On 3/11/18 16:59, Jean-Louis Dupond wrote: Hi All, On recent kernels we noticed a way lower throughput to our SAN system than before. While on pre 4.18 kernels we had 400-700MB/sec read speed, on 4.18

[PATCH net-next] cxgb4: Add new T6 PCI device ids 0x608a

2018-11-08 Thread Ganesh Goudar
Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index 60df66f..bf7325f 100644 --- a/drivers/net/ethernet

Re: [PATCH net-next 05/10] ipv6: factor out protocol delivery helper

2018-11-08 Thread Sergei Shtylyov
On 11/7/2018 2:38 PM, Paolo Abeni wrote: So that we can re-use it at the UDP level in the next patch rfc v3 -> v1: - add the helper declaration into the ipv6 header Signed-off-by: Paolo Abeni --- include/net/ipv6.h | 2 ++ net/ipv6/ip6_input.c | 28 2 fil

[PATCH bpf-next 1/2] bpf: let verifier to calculate and record max_pkt_offset

2018-11-08 Thread Jiong Wang
In check_packet_access, update max_pkt_offset after the offset has passed __check_packet_access. It should be safe to use u32 for max_pkt_offset as explained in code comment. Also, when there is tail call, the max_pkt_offset of the called program is unknown, so conservatively set max_pkt_offset t

[PATCH bpf-next 0/2] bpf: offer maximum packet offset info

2018-11-08 Thread Jiong Wang
The maximum packet offset accessed by one BPF program is useful information. Because sometimes there could be packet split and it is possible for some reasons (for example performance) we want to reject the BPF program if the maximum packet size would trigger such split. Normally, MTU value is tre

[PATCH bpf-next 2/2] nfp: bpf: relax prog rejection through max_pkt_offset

2018-11-08 Thread Jiong Wang
NFP is refusing to offload programs whenever the MTU is set to a value larger than the max packet bytes that fits in NFP Cluster Target Memory (CTM). However, a eBPF program doesn't always need to access the whole packet data. Verifier has always calculated maximum direct packet access (DPA) offse

[PATCH iproute2-next] devlink: Add missing region option to devlink man page

2018-11-08 Thread Alex Vesker
The region field was not added to the devlink man page. Fixes: 8b4fbf0bed8e6 ("devlink: Add support for devlink-region access") Signed-off-by: Alex Vesker --- man/man8/devlink.8 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/man/man8/devlink.8 b/man/man8/devlink.8 index

Re: [PATCH iproute2] bridge: fdb: remove redundant dev string in show output

2018-11-08 Thread Phil Sutter
Hi Roopa, On Wed, Nov 07, 2018 at 03:14:09PM -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > After commit 4abb8c723a64 ("bridge: fdb: Fix for missing > keywords in non-JSON output"), I am seeing a double print for dev > in bridge fdb show. eg: > "44:38:39:00:6a:82 dev dev bridge vlan 1 maste

Re: [PATCH net-next 05/10] ipv6: factor out protocol delivery helper

2018-11-08 Thread Paolo Abeni
Hi, On Thu, 2018-11-08 at 12:01 +0300, Sergei Shtylyov wrote: > On 11/7/2018 2:38 PM, Paolo Abeni wrote: > > > So that we can re-use it at the UDP level in the next patch > > > > rfc v3 -> v1: > > - add the helper declaration into the ipv6 header > > > > Signed-off-by: Paolo Abeni > > --- >

Re: [PATCH net-next 05/10] ipv6: factor out protocol delivery helper

2018-11-08 Thread Sergei Shtylyov
On 11/8/2018 1:13 PM, Paolo Abeni wrote: So that we can re-use it at the UDP level in the next patch rfc v3 -> v1: - add the helper declaration into the ipv6 header Signed-off-by: Paolo Abeni --- include/net/ipv6.h | 2 ++ net/ipv6/ip6_input.c | 28 2

Re: [net-next 12/12] igc: Clean up code

2018-11-08 Thread Joe Perches
On Wed, 2018-11-07 at 14:48 -0800, Jeff Kirsher wrote: > From: Sasha Neftin > > Address few community comments. > Remove unused code, will be added per demand. > Remove blank lines and unneeded includes. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Jeff Kirsher >

Re: [PATCH v3 bpf-next 4/4] bpftool: support loading flow dissector

2018-11-08 Thread Quentin Monnet
Hi Stanislav, thanks for the changes! More comments below. 2018-11-07 21:39 UTC-0800 ~ Stanislav Fomichev This commit adds support for loading/attaching/detaching flow dissector program. The structure of the flow dissector program is assumed to be the same as in the selftests: * flow_dissector

[PATCH net-next v2 01/11] udp: Handle ICMP errors for tunnels with same destination port on both endpoints

2018-11-08 Thread Stefano Brivio
For both IPv4 and IPv6, if we can't match errors to a socket, try tunnels before ignoring them. Look up a socket with the original source and destination ports as found in the UDP packet inside the ICMP payload, this will work for tunnels that force the same destination port for both endpoints, i.e

[PATCH net-next v2 00/11] ICMP error handling for UDP tunnels

2018-11-08 Thread Stefano Brivio
This series introduces ICMP error handling for UDP tunnels and encapsulations and related selftests. We need to handle ICMP errors to support PMTU discovery and route redirection -- this support is entirely missing right now: - patch 1/11 adds a socket lookup for UDP tunnels that use, by design,

[PATCH net-next v2 02/11] vxlan: ICMP error lookup handler

2018-11-08 Thread Stefano Brivio
Export an encap_err_lookup() operation to match an ICMP error against a valid VNI. Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca --- v2: no changes drivers/net/vxlan.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/

[PATCH net-next v2 06/11] geneve: Allow configuration of DF behaviour

2018-11-08 Thread Stefano Brivio
draft-ietf-nvo3-geneve-08 says: It is strongly RECOMMENDED that Path MTU Discovery ([RFC1191], [RFC1981]) be used by setting the DF bit in the IP header when Geneve packets are transmitted over IPv4 (this is the default with IPv6). Now that ICMP error handling is working for GENEVE, we c

[PATCH net-next v2 05/11] geneve: ICMP error lookup handler

2018-11-08 Thread Stefano Brivio
Export an encap_err_lookup() operation to match an ICMP error against a valid VNI. Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca --- v2: no changes drivers/net/geneve.c | 52 1 file changed, 52 insertions(+) diff --git a/drivers/net/ge

[PATCH net-next v2 09/11] udp: Support for error handlers of tunnels with arbitrary destination port

2018-11-08 Thread Stefano Brivio
ICMP error handling is currently not possible for UDP tunnels not employing a receiving socket with local destination port matching the remote one, because we have no way to look them up. Add an err_handler tunnel encapsulation operation that can be exported by tunnels in order to pass the error t

[PATCH net-next v2 10/11] fou, fou6: ICMP error handlers for FoU and GUE

2018-11-08 Thread Stefano Brivio
As the destination port in FoU and GUE receiving sockets doesn't necessarily match the remote destination port, we can't associate errors to the encapsulating tunnels with a socket lookup -- we need to blindly try them instead. This means we don't even know if we are handling errors for FoU or GUE

[PATCH net-next v2 03/11] vxlan: Allow configuration of DF behaviour

2018-11-08 Thread Stefano Brivio
Allow users to set the IPv4 DF bit in outgoing packets, or to inherit its value from the IPv4 inner header. If the encapsulated protocol is IPv6 and DF is configured to be inherited, always set it. For IPv4, inheriting DF from the inner header was probably intended from the very beginning judging

[PATCH net-next v2 08/11] net: Convert protocol error handlers from void to int

2018-11-08 Thread Stefano Brivio
We'll need this to handle ICMP errors for tunnels without a sending socket (i.e. FoU and GUE). There, we might have to look up different types of IP tunnels, registered as network protocols, before we get a match, so we want this for the error handlers of IPPROTO_IPIP and IPPROTO_IPV6 in both inet_

[PATCH net-next v2 11/11] selftests: pmtu: Introduce FoU and GUE PMTU exceptions tests

2018-11-08 Thread Stefano Brivio
Introduce eight tests, for FoU and GUE, with IPv4 and IPv6 payload, on IPv4 and IPv6 transport, that check that PMTU exceptions are created with the right value when exceeding the MTU on a link of the path. Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca --- v2: no changes tools/tes

[PATCH net-next v2 07/11] selftests: pmtu: Introduce tests for IPv4/IPv6 over GENEVE over IPv4/IPv6

2018-11-08 Thread Stefano Brivio
Use a router between endpoints, implemented via namespaces, set a low MTU between router and destination endpoint, exceed it and check PMTU value in route exceptions. v2: - Introduce IPv4 tests right away, if iproute2 doesn't support the 'df' link option they will be skipped (David Ahern) Signe

[PATCH net-next v2 04/11] selftests: pmtu: Introduce tests for IPv4/IPv6 over VXLAN over IPv4/IPv6

2018-11-08 Thread Stefano Brivio
Use a router between endpoints, implemented via namespaces, set a low MTU between router and destination endpoint, exceed it and check PMTU value in route exceptions. v2: - Change all occurrences of VxLAN to VXLAN (Jiri Benc) - Introduce IPv4 tests right away, if iproute2 doesn't support the 'df'

[PATCH iproute2 net-next v2 2/2] iplink_geneve: Add DF configuration

2018-11-08 Thread Stefano Brivio
Allow to set the DF bit behaviour for outgoing IPv4 packets: it can be always on, inherited from the inner header, or, by default, always off, which is the current behaviour. v2: - Indicate in the man page what DF refers to, using RFC 791 wording (David Ahern) Signed-off-by: Stefano Brivio ---

[PATCH iproute2 net-next v2 0/2] Add DF configuration for VXLAN and GENEVE link types

2018-11-08 Thread Stefano Brivio
This series adds configuration of the DF bit in outgoing IPv4 packets for VXLAN and GENEVE link types. Stefano Brivio (2): iplink_vxlan: Add DF configuration iplink_geneve: Add DF configuration include/uapi/linux/if_link.h | 18 ++ ip/iplink_geneve.c | 29 ++

[PATCH iproute2 net-next v2 1/2] iplink_vxlan: Add DF configuration

2018-11-08 Thread Stefano Brivio
Allow to set the DF bit behaviour for outgoing IPv4 packets: it can be always on, inherited from the inner header, or, by default, always off, which is the current behaviour. v2: - Indicate in the man page what DF refers to, using RFC 791 wording (David Ahern) Signed-off-by: Stefano Brivio ---

Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads

2018-11-08 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > Hi! > > This series refactors the "switchdev" Qdisc offloads a little. We have > a few Qdiscs which can be fully offloaded today to the forwarding plane > of switching devices. > > First patch adds a helper for handing statistic dumps, the code seems > to be copy pasted

[PATCH bpf 3/4] tools: bpftool: pass an argument to silence open_obj_pinned()

2018-11-08 Thread Quentin Monnet
Function open_obj_pinned() prints error messages when it fails to open a link in the BPF virtual file system. However, in some occasions it is not desirable to print an error, for example when we parse all links under the bpffs root, and the error is due to some paths actually being symbolic links.

[PATCH bpf 4/4] tools: bpftool: update references to other man pages in documentation

2018-11-08 Thread Quentin Monnet
Update references to other bpftool man pages at the bottom of each manual page. Also reference the "bpf(2)" and "bpf-helpers(7)" man pages. References are sorted by number of man section, then by "prog-and-map-go-first", the other pages in alphabetical order. Signed-off-by: Quentin Monnet Review

[PATCH bpf 0/4] tools: bpftool: bring several minor fixes to bpftool

2018-11-08 Thread Quentin Monnet
Hi, This set contains minor fixes for bpftool code and documentation. Please refer to individual patches for details. Quentin Monnet (4): tools: bpftool: prevent infinite loop in get_fdinfo() tools: bpftool: fix plain output and doc for --bpffs option tools: bpftool: pass an argument to sile

[PATCH bpf 2/4] tools: bpftool: fix plain output and doc for --bpffs option

2018-11-08 Thread Quentin Monnet
Edit the documentation of the -f|--bpffs option to make it explicit that it dumps paths of pinned programs when bpftool is used to list the programs only, so that users do not believe they will see the name of the newly pinned program with "bpftool prog pin" or "bpftool prog load". Also fix the pl

[PATCH bpf 1/4] tools: bpftool: prevent infinite loop in get_fdinfo()

2018-11-08 Thread Quentin Monnet
Function getline() returns -1 on failure to read a line, thus creating an infinite loop in get_fdinfo() if the key is not found. Fix it by calling the function only as long as we get a strictly positive return value. Found by copying the code for a key which is not always present... Fixes: 71bb42

Re: [net-next 12/12] igc: Clean up code

2018-11-08 Thread Neftin, Sasha
On 11/8/2018 13:00, Joe Perches wrote: On Wed, 2018-11-07 at 14:48 -0800, Jeff Kirsher wrote: From: Sasha Neftin Address few community comments. Remove unused code, will be added per demand. Remove blank lines and unneeded includes. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-

[PATCH][net-next] openvswitch: remove BUG_ON from get_dpdev

2018-11-08 Thread Li RongQing
if local is NULL pointer, and the following access of local's dev will trigger panic, which is same as BUG_ON Signed-off-by: Li RongQing --- net/openvswitch/vport-netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 2e5

[PATCH net-next 2/2] dpaa2-ptp: defer probe when portal allocation failed

2018-11-08 Thread Ioana Ciornei
The fsl_mc_portal_allocate can fail when the requested MC portals are not yet probed by the fsl_mc_allocator. In this situation, the driver should defer the probe. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 5 - 1 file changed, 4 insertions(+), 1 dele

[PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate

2018-11-08 Thread Ioana Ciornei
The fsl_mc_object_allocate function can fail because not all allocatable objects are probed by the fsl_mc_allocator at the call time. Defer the dpaa2-eth probe when this happens. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 30 +--- 1 fi

[PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate

2018-11-08 Thread Ioana Ciornei
Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator after the first attempts of other drivers to use them. Defer the probe when this situation happens. Ioana Ciornei (2): dpaa2-eth: defer probe on object allocate dpaa2-ptp: defer probe when portal allocation failed dr

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread Paweł Staszewski
W dniu 07.11.2018 o 22:06, David Ahern pisze: On 11/3/18 6:24 PM, Paweł Staszewski wrote: Does your setup have any other device types besides physical ports with VLANs (e.g., any macvlans or bonds)? no. just phy(mlnx)->vlans only config VLAN and non-VLAN (and a mix) seem to work ok. Patch

[PATCH net-next 3/8] s390/qeth: unify transmit code

2018-11-08 Thread Julian Wiedmann
Since commit 82bf5c0867f6 ("s390/qeth: add support for IPv6 TSO"), qeth_xmit() also knows how to build TSO packets and is practically identical to qeth_l3_xmit(). Convert qeth_l3_xmit() into a thin wrapper that merely strips the L2 header off a packet, and calls qeth_xmit() for the actual TX proces

[PATCH net-next 2/8] s390/qeth: handle af_iucv skbs in qeth_l3_fill_header()

2018-11-08 Thread Julian Wiedmann
Filling the HW header from one single function will make it easier to rip out all the duplicated transmit code in qeth_l3_xmit(). On top, this saves one conditional branch in the TSO path. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h| 2 +- drivers/s390/net/qeth_l3_main.c

[PATCH net-next 7/8] s390/qeth: remove unused fallback in Layer3's MAC code

2018-11-08 Thread Julian Wiedmann
If the CREATE ADDR sent by qeth_l3_iqd_read_initial_mac() fails, its callback sets a random MAC address on the net_device. The error then propagates back, and qeth_l3_setup_netdev() bails out without registering the net_device. Any subsequent call to qeth_l3_setup_netdev() will then attempt a fres

[PATCH net-next 8/8] s390/qeth: don't process hsuid in qeth_l3_setup_netdev()

2018-11-08 Thread Julian Wiedmann
qeth_l3_setup_netdev() checks if the hsuid attribute is set on the qeth device, and propagates it to the net_device. In the past this was needed to pick up any hsuid that was set before allocation of the net_device. With commit d3d1b205e89f ("s390/qeth: allocate netdevice early") this is no longer

[PATCH net-next 6/8] s390/qeth: remove two IPA command helpers

2018-11-08 Thread Julian Wiedmann
qeth_l3_send_ipa_arp_cmd() is merely a wrapper around qeth_send_control_data() now. So push the length adjustment into QETH_SETASS_BASE_LEN, and remove the wrapper. While at it, also remove some redundant 0-initializations. qeth_send_setassparms() requires that callers prepare their command parame

[PATCH net-next 4/8] s390/qeth: remove card list

2018-11-08 Thread Julian Wiedmann
Re-implement the card-by-RDEV lookup by using device model concepts, and remove the now redundant list of all qeth card instances in the system. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 8 +--- drivers/s390/net/qeth_core_main.c | 25 +++-- d

[PATCH net-next 5/8] s390/qeth: replace open-coded cmd setup

2018-11-08 Thread Julian Wiedmann
Call qeth_prepare_ipa_cmd() during setup of a new IPA cmd buffer, so that it is used for all commands. Thus ARP and SNMP requests don't have to do their own initialization. This will now also set the proper MPC protocol version for SNMP requests on L2 devices. Signed-off-by: Julian Wiedmann ---

[PATCH net-next 0/8] s390/qeth: updates 2018-11-08

2018-11-08 Thread Julian Wiedmann
Hi Dave, please apply the following qeth patches to net-next. The first patch allows one more device type to query the FW for a MAC address, the others are all basically just removal of duplicated or unused code. Thanks, Julian Julian Wiedmann (8): s390/qeth: utilize virtual MAC for Layer2 O

[PATCH net-next 1/8] s390/qeth: utilize virtual MAC for Layer2 OSD devices

2018-11-08 Thread Julian Wiedmann
By default, READ MAC on a Layer2 OSD device returns the adapter's burnt-in MAC address. Given the default scenario of many virtual devices on the same adapter, qeth can't make any use of this address and therefore skips the READ MAC call for this device type. But in some configurations, the READ M

[PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt

2018-11-08 Thread David Barmann
When setting the SO_MARK socket option, if the mark changes, the dst needs to be reset so that a new route lookup is performed. This fixes the case where an application wants to change routing by setting a new sk_mark. If this is done after some packets have already been sent, the dst is cached a

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread Paweł Staszewski
W dniu 08.11.2018 o 01:59, Paweł Staszewski pisze: W dniu 05.11.2018 o 21:17, Jesper Dangaard Brouer pisze: On Sun, 4 Nov 2018 01:24:03 +0100 Paweł Staszewski wrote: And today again after allpy patch for page allocator - reached again 64/64 Gbit/s with only 50-60% cpu load Great. to

[PATCH net 0/4] Slowpath Queue bug fixes

2018-11-08 Thread Denis Bolotin
Hi Dave, This patch series fixes several bugs in the SPQ mechanism. It deals with SPQ entries management, preventing resource leaks, memory corruptions and handles error cases throughout the driver. Please consider applying to net. Thanks, Denis Denis Bolotin (4): qed: Fix memory/entry leak in

[PATCH net 2/4] qed: Fix blocking/unlimited SPQ entries leak

2018-11-08 Thread Denis Bolotin
When there are no SPQ entries left in the free_pool, new entries are allocated and are added to the unlimited list. When an entry in the pool is available, the content is copied from the original entry, and the new entry is sent to the device. qed_spq_post() is not aware of that, so the additional

[PATCH net 4/4] qed: Fix potential memory corruption

2018-11-08 Thread Denis Bolotin
From: Sagiv Ozeri A stuck ramrod should be deleted from the completion_pending list, otherwise it will be added again in the future and corrupt the list. Return error value to inform that ramrod is stuck and should be deleted. Signed-off-by: Sagiv Ozeri Signed-off-by: Denis Bolotin --- drive

[PATCH net 3/4] qed: Fix SPQ entries not returned to pool in error flows

2018-11-08 Thread Denis Bolotin
qed_sp_destroy_request() API was added for SPQ users that need to free/return the entry they acquired in their error flows. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qed/qed_fcoe.c| 11 --- drivers/net/ethernet/qlogic/qed/qed_isc

[PATCH net 1/4] qed: Fix memory/entry leak in qed_init_sp_request()

2018-11-08 Thread Denis Bolotin
Free the allocated SPQ entry or return the acquired SPQ entry to the free list in error flows. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qed/qed_sp_commands.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/

[PATCH bpf-next] filter: add BPF_ADJ_ROOM_DATA mode to bpf_skb_adjust_room()

2018-11-08 Thread Nicolas Dichtel
This new mode enables to add or remove an l2 header in a programmatic way with cls_bpf. For example, it enables to play with mpls headers. Signed-off-by: Nicolas Dichtel --- include/uapi/linux/bpf.h | 3 ++ net/core/filter.c | 54 ++ tools/incl

Re: (2) (2) (2) [Kernel][NET] Bug report on packet defragmenting

2018-11-08 Thread Eric Dumazet
r:11369_2:11382] ipv6_defrag +++ > <6>[ 119.702922] I[1: Binder:11369_2:11382] ipv6_defrag --- > <6>[ 119.702966] I[1: Binder:11369_2:11382] ipv6_rcv --- > <0>[ 119.703792] [1: Binder:11369_2:11382] BUG: sleeping function called > from invalid c

Re: SACK compression patch causing performance drop

2018-11-08 Thread Eric Dumazet
On 11/08/2018 12:23 AM, Jean-Louis Dupond wrote: > Hi, > > Was somebody able to check this? > Really think this should be fixed :) > > Thanks > Jean-Louis > I somehow missed this email. Packet captures might help, please send me tcpdump -s 128 -i ethX -w sack.pcap of some samples with or

Re: [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt

2018-11-08 Thread Eric Dumazet
On 11/08/2018 06:13 AM, David Barmann wrote: > When setting the SO_MARK socket option, if the mark changes, the dst > needs to be reset so that a new route lookup is performed. > > This fixes the case where an application wants to change routing by > setting a new sk_mark. If this is done afte

[net-next, PATCH 1/2] net: socionext: different approach on DMA

2018-11-08 Thread Ilias Apalodimas
Current driver dynamically allocates an skb and maps it as DMA Rx buffer. In order to prepare for upcoming XDP changes, let's introduce a different allocation scheme. Buffers are allocated dynamically and mapped into hardware. During the Rx operation the driver uses build_skb() to produce the neces

[net-next, PATCH 2/2] net: socionext: refactor netsec_alloc_dring()

2018-11-08 Thread Ilias Apalodimas
return -ENOMEM directly instead of assigning it in a variable Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/nets

Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads

2018-11-08 Thread Jakub Kicinski
On Thu, 08 Nov 2018 12:48:27 +0100, Toke Høiland-Jørgensen wrote: > Jakub Kicinski writes: > > Hi! > > > > This series refactors the "switchdev" Qdisc offloads a little. We have > > a few Qdiscs which can be fully offloaded today to the forwarding plane > > of switching devices. > > > > First pat

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread David Ahern
On 11/8/18 6:33 AM, Paweł Staszewski wrote: > > > W dniu 07.11.2018 o 22:06, David Ahern pisze: >> On 11/3/18 6:24 PM, Paweł Staszewski wrote: Does your setup have any other device types besides physical ports with VLANs (e.g., any macvlans or bonds)? >>> no. >>> just >>> phy(

Re: [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter

2018-11-08 Thread Ido Schimmel
On Wed, Nov 07, 2018 at 11:05:18AM -0800, Jakub Kicinski wrote: > On Wed, 7 Nov 2018 12:11:32 +0200, Ido Schimmel wrote: > > On Tue, Nov 06, 2018 at 02:47:13PM -0800, Jakub Kicinski wrote: > > > On Tue, 6 Nov 2018 22:37:51 +0200, Ido Schimmel wrote: > > > > On Tue, Nov 06, 2018 at 12:19:13PM -080

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread Paweł Staszewski
W dniu 08.11.2018 o 17:06, David Ahern pisze: On 11/8/18 6:33 AM, Paweł Staszewski wrote: W dniu 07.11.2018 o 22:06, David Ahern pisze: On 11/3/18 6:24 PM, Paweł Staszewski wrote: Does your setup have any other device types besides physical ports with VLANs (e.g., any macvlans or bonds)?

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread Paweł Staszewski
W dniu 08.11.2018 o 17:25, Paweł Staszewski pisze: W dniu 08.11.2018 o 17:06, David Ahern pisze: On 11/8/18 6:33 AM, Paweł Staszewski wrote: W dniu 07.11.2018 o 22:06, David Ahern pisze: On 11/3/18 6:24 PM, Paweł Staszewski wrote: Does your setup have any other device types besides physi

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread David Ahern
On 11/8/18 9:27 AM, Paweł Staszewski wrote: >>> What hardware is this? >>> > mellanox connectx 4 > ethtool -i enp175s0f0 > driver: mlx5_core > version: 5.0-0 > firmware-version: 12.21.1000 (SM_200101033) > expansion-rom-version: > bus-info: :af:00.0 > supports-statistics: yes > supports-tes

[PATCH bpf-next 4/4] selftest/bpf: Use bpf_sk_lookup_{tcp,udp} in test_sock_addr

2018-11-08 Thread Andrey Ignatov
Use bpf_sk_lookup_tcp, bpf_sk_lookup_udp and bpf_sk_release helpers from test_sock_addr programs to make sure they're available and can lookup and release socket properly for IPv4/IPv4, TCP/UDP. Reading from a few fields of returned struct bpf_sock is also tested. Signed-off-by: Andrey Ignatov A

[PATCH bpf-next 2/4] bpf: Split bpf_sk_lookup

2018-11-08 Thread Andrey Ignatov
Split bpf_sk_lookup to separate core functionality, that can be reused to make socket lookup available to more program types, from functionality specific to program types that have access to skb. Core functionality is placed to __bpf_sk_lookup. And bpf_sk_lookup only gets caller netns and ifindex

[PATCH bpf-next 3/4] bpf: Support socket lookup in CGROUP_SOCK_ADDR progs

2018-11-08 Thread Andrey Ignatov
Make bpf_sk_lookup_tcp, bpf_sk_lookup_udp and bpf_sk_release helpers available in programs of type BPF_PROG_TYPE_CGROUP_SOCK_ADDR. Such programs operate on sockets and have access to socket and struct sockaddr passed by user to system calls such as sys_bind, sys_connect, sys_sendmsg. It's useful

[PATCH bpf-next 0/4] bpf: Support socket lookup in CGROUP_SOCK_ADDR progs

2018-11-08 Thread Andrey Ignatov
This patch set makes bpf_sk_lookup_tcp, bpf_sk_lookup_udp and bpf_sk_release helpers available in programs of type BPF_PROG_TYPE_CGROUP_SOCK_ADDR. Patch 1 is a fix for bpf_sk_lookup_udp that was already sent to netdev separately for bpf (stable) tree. Here it's prerequisite for patch 4. Patch 2 i

[PATCH bpf-next 1/4] bpf: Fix IPv6 dport byte order in bpf_sk_lookup_udp

2018-11-08 Thread Andrey Ignatov
Lookup functions in sk_lookup have different expectations about byte order of provided arguments. Specifically __inet_lookup, __udp4_lib_lookup and __udp6_lib_lookup expect dport to be in network byte order and do ntohs(dport) internally. At the same time __inet6_lookup expects dport to be in hos

Re: [PATCH net-next] SUNRPC: drop pointless static qualifier in xdr_get_next_encode_buffer()

2018-11-08 Thread bfie...@fieldses.org
On Thu, Nov 08, 2018 at 03:13:25AM +, Trond Myklebust wrote: > On Thu, 2018-11-08 at 02:04 +, YueHaibing wrote: > > There is no need to have the '__be32 *p' variable static since new > > value > > always be assigned before use it. Applying for 4.20 and stable, thanks! > > > > Signed-off-

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread Paweł Staszewski
W dniu 08.11.2018 o 17:32, David Ahern pisze: On 11/8/18 9:27 AM, Paweł Staszewski wrote: What hardware is this? mellanox connectx 4 ethtool -i enp175s0f0 driver: mlx5_core version: 5.0-0 firmware-version: 12.21.1000 (SM_200101033) expansion-rom-version: bus-info: :af:00.0 supports-

[PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT

2018-11-08 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 771eb6bd0785..4b3999d88c9e 100644 --- a/drivers/infiniband/h

[PATCH net-next 2/4] cnic: remove use of VLAN_TAG_PRESENT

2018-11-08 Thread Michał Mirosław
This just removes VLAN_TAG_PRESENT use. VLAN TCI=0 special meaning is deeply embedded in the driver code and so is left as is. Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadco

[PATCH net-next 4/4] OVS: remove use of VLAN_TAG_PRESENT

2018-11-08 Thread Michał Mirosław
This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- net/openvswitch/actions.c | 13 + net/openvswitch/flow.c | 4

[PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers

2018-11-08 Thread Michał Mirosław
This series removes VLAN_TAG_PRESENT use from network drivers in preparation to removing its special meaning. Michał Mirosław (4): i40iw: remove use of VLAN_TAG_PRESENT cnic: remove use of VLAN_TAG_PRESENT gianfar: remove use of VLAN_TAG_PRESENT OVS: remove use of VLAN_TAG_PRESENT driver

[PATCH net-next 3/4] gianfar: remove use of VLAN_TAG_PRESENT

2018-11-08 Thread Michał Mirosław
Reviewed-by: Claudiu Manoil Signed-off-by: Michał Mirosław --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 0

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-08 Thread Edward Cree
On 07/11/18 21:49, Alexei Starovoitov wrote: > On Wed, Nov 07, 2018 at 07:29:31PM +, Edward Cree wrote: >> Whereas I don't, and I don't feel like my core criticisms have >>  been addressed _at all_.  The only answer I get to "BTF should >>  store type and instance information in separate record

Re: [PATCH v3 bpf-next 4/4] bpftool: support loading flow dissector

2018-11-08 Thread Stanislav Fomichev
On 11/08, Quentin Monnet wrote: > Hi Stanislav, thanks for the changes! More comments below. Thank you for another round of review! > 2018-11-07 21:39 UTC-0800 ~ Stanislav Fomichev > > This commit adds support for loading/attaching/detaching flow > > dissector program. The structure of the flow d

Re: a propose of snmp counter document

2018-11-08 Thread Cong Wang
On Thu, Nov 8, 2018 at 12:10 AM peng yu wrote: > > I'm planing to write a document which explains the meaning of the > kernel snmp counters, and combine the explanations with some tests, > because I found lots of the 'TcpExt' and 'IpExt' counters are not > explained in any document. Here is a draf

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-08 Thread David Ahern
On 11/8/18 10:30 AM, Paweł Staszewski wrote: > Wondering about this: > swapper 0 [045] 68494.770287: fib:fib_table_lookup: table 254 oif 0 > iif 6 proto 1 192.168.22.237/0 -> 172.16.0.2/0 tos 0 scope 0 flags 0 ==> > dev vlan1740 gw 0.0.0.0 src 172.16.0.1 err 0 >     7fff818c13b5 fib_tab

Re: [RFC perf,bpf 1/5] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

2018-11-08 Thread Song Liu
Hi Peter, > On Nov 8, 2018, at 7:00 AM, Peter Zijlstra wrote: > > On Wed, Nov 07, 2018 at 06:25:04PM +, Song Liu wrote: >> >> >>> On Nov 7, 2018, at 12:40 AM, Peter Zijlstra wrote: >>> >>> On Tue, Nov 06, 2018 at 12:52:42PM -0800, Song Liu wrote: For better performance analysis of B

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-08 Thread Alexei Starovoitov
On Thu, Nov 08, 2018 at 05:58:56PM +, Edward Cree wrote: > > > Happy to jump on the call to explain it again. > > 10:30am pacific time works for me tomorrow. > That works for me (that's in ~30 minutes from now if I've converted >  correctly.)  Please email me offlist with the phone number to c

Re: [PATCH v3 bpf-next 4/4] bpftool: support loading flow dissector

2018-11-08 Thread Quentin Monnet
2018-11-08 10:01 UTC-0800 ~ Stanislav Fomichev > On 11/08, Quentin Monnet wrote: >> Hi Stanislav, thanks for the changes! More comments below. > Thank you for another round of review! > >> 2018-11-07 21:39 UTC-0800 ~ Stanislav Fomichev >>> This commit adds support for loading/attaching/detaching

Re: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate

2018-11-08 Thread Andrew Lunn
On Thu, Nov 08, 2018 at 01:17:47PM +, Ioana Ciornei wrote: > The fsl_mc_object_allocate function can fail because not all allocatable > objects are probed by the fsl_mc_allocator at the call time. Defer the > dpaa2-eth probe when this happens. > > Signed-off-by: Ioana Ciornei > --- > drivers

Re: Latest net-next kernel 4.19.0+

2018-11-08 Thread Cong Wang
On Thu, Nov 1, 2018 at 3:59 PM Paweł Staszewski wrote: > > > > W dniu 31.10.2018 o 22:17, Cong Wang pisze: > > On Wed, Oct 31, 2018 at 2:05 PM Saeed Mahameed wrote: > >> Cong, How often does this happen ? can you some how verify if the > >> problematic packet has extra end padding after the ip pa

[PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham This patchset is a continuation to earlier submitted three patch series to add a new driver for Marvell's OcteonTX2 SOC's Resource virtualization unit (RVU) admin function driver. 1. octeontx2-af: Add RVU Admin Function driver https://www.spinics.net/lists/netdev/msg528272

[PATCH 01/20] octeontx2-af: Support to modify min/max allowed packet lengths

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for RVU PF/VFs to modify min/max packet lengths allowed by HW. For VFs on PF0, settings will be automatically applied on LBK link. RX link's min/maxlen is configured to min/max of PF and it's all VFs. On the TX side if requested all SMQs attached to the

[PATCH 02/20] octeontx2-af: Support to get NIX HW constants from AF

2018-11-08 Thread sunil . kovvuri
From: Kiran Kumar This patch adds reading HW limits like number of Rx/Tx stats, number of queue IRQs supported per NIX LF from AF registers and sync them to PF/VF. Signed-off-by: Kiran Kumar Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h| 4 drivers

[PATCH 03/20] octeontx2-af: Relax resource lock into mutex

2018-11-08 Thread sunil . kovvuri
From: Stanislaw Kardach The resource locks does not need to be a spinlock as they are not used in any interrupt handling routines (only in bottom halves). Therefore relax them into a mutex so that later on we may use them in routines that might sleep. Signed-off-by: Stanislaw Kardach Signed-off

[PATCH 10/20] octeontx2-af: Support to enable/disable default MCAM entries

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham For a PF/VF with a NIXLF attached has default/reserved MCAM entries for receiving Ucast/Bcast/Promisc traffic. Ideally traffic should be forwarded to NIXLF only after it's contexts are initialized. This patch keeps these default entries disabled and adds mbox messages for a PF

[PATCH 04/20] octeontx2-af: NPC MCAM entry alloc/free support

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham This patch adds NPC MCAM entry management and support for allocating and freeing them via mailbox. Both contiguous and non-contiguous allocations are supported. Incase of contiguous, if request cannot be met then max contiguous number of available entries are allocated. High

[PATCH 07/20] octeontx2-af: Map or unmap NPC MCAM entry and counter

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham Alloc memory to save MCAM 'entry to counter' mapping and since multiple entries can map to same counter, added counter's reference count tracking. Do 'entry to counter' mapping when a entry is being installed and mbox msg sender requested to configure a counter as well. Mappi

[PATCH 05/20] octeontx2-af: MCAM entry installation support

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham Add support for a RVU PF/VF to enable, disable, configure and shuffle MCAM entries via mbox commands. This patch adds mailbox message formats and handling of these commands. As of now otherthan validating MCAM entry index, info like channel number e.t.c in MCAM config data se

[PATCH 08/20] octeontx2-af: Alloc and config NPC MCAM entry at a time

2018-11-08 Thread sunil . kovvuri
From: Sunil Goutham A new mailbox message is added to support allocating a MCAM entry along with a counter and configuring it in one go. This reduces the amount of mailbox communication involved in installing a new MCAM rule. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeon

  1   2   3   >