Re: [PATCH net-next 0/2] cls_flower: Various fixes

2018-06-04 Thread Roi Dayan
On 03/06/2018 22:39, Jiri Pirko wrote: Sun, Jun 03, 2018 at 08:33:25PM CEST, xiyou.wangc...@gmail.com wrote: On Wed, May 30, 2018 at 1:17 AM, Paul Blakey wrote: Two of the fixes are for my multiple mask patch Paul Blakey (2): cls_flower: Fix missing free of rhashtable cls_flower: Fix

Re: [PATCH net v2 0/2] ip[6] tunnels: fix mtu calculations

2018-06-04 Thread Nicolas Dichtel
Le 01/06/2018 à 19:57, David Miller a écrit : [snip] > I think the 0xfff8 value might come from the requirement that ipv6 > fragments need to be a multiple of 8 bytes long. > Oh, thanks for the explanation!

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-06-04 Thread Dmitry Vyukov
On Tue, May 29, 2018 at 7:45 PM, Xin Long wrote: > On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner > wrote: >> On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: >>> On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < >>> marcelo.leit...@gmail.com> wrote: >>> > - patch

Re: [PATCH net-next v2 1/3] bpf: implement bpf_get_current_cgroup_id() helper

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 12:59 AM, Yonghong Song wrote: > bpf has been used extensively for tracing. For example, bcc > contains an almost full set of bpf-based tools to trace kernel > and user functions/events. Most tracing tools are currently > either filtered based on pid or system-wide. > > Containers ha

Re: [RFC feedback] AF_XDP and non-Intel hardware

2018-06-04 Thread Mykyta Iziumtsev
Hi Björn and Magnus, Here is a short update on the proposed changes to AF_XDP. During implementation phase I figured out that 'end-of-page' in RX descriptor's flags won't work, unfortunately. This is because the kernel driver can't know if the frame will be last on the page when RX descriptor is

[PATCH] docs: networking: fix minor typos in various documentation files

2018-06-04 Thread Olivier Gayot
This patch fixes some typos/misspelling errors in the Documentation/networking files. Signed-off-by: Olivier Gayot --- Documentation/networking/6lowpan.txt | 4 ++-- Documentation/networking/gtp.txt | 4 ++-- Documentation/networking/ila.txt | 2 +-

pull request: bluetooth-next 2018-06-04

2018-06-04 Thread Johan Hedberg
Hi Dave, Here's one last bluetooth-next pull request for the 4.18 kernel: - New USB device IDs for Realtek 8822BE and 8723DE - reset/resume fix for Dell Inspiron 5565 - Fix HCI_UART_INIT_PENDING flag behavior - Fix patching behavior for some ATH3012 models - A few other minor cleanups & fixe

Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-04 Thread Phil Sutter
Hi! On Sun, Jun 03, 2018 at 07:08:55PM +0200, Jesper Dangaard Brouer wrote: [...] > Secondly I personally *hate* how the 'ip' does it's short options > parsing and especially order/precedence ambiguity. Phil Sutter > (Fedora/RHEL iproute2 maintainer) have a funny quiz illustrating the > ambiguity

[PATCH net] ipmr: fix error path when mr_table_alloc fails

2018-06-04 Thread Sabrina Dubroca
commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table") refactored ipmr_new_table, so that it now returns NULL when mr_table_alloc fails. Unfortunately, all callers of ipmr_new_table expect an ERR_PTR. commit 66fb33254f45 ("ipmr: properly check rhltable_init() return value") followed su

[PATCH bpf-next 1/5] xsk: proper fill queue descriptor validation

2018-06-04 Thread Björn Töpel
From: Björn Töpel Previously the fill queue descriptor was not copied to kernel space prior validating it, making it possible for userland to change the descriptor post-kernel-validation. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 11 +-- net/xdp/xsk_queue.h | 32 +---

[PATCH bpf-next 4/5] samples/bpf: adapted to new uapi

2018-06-04 Thread Björn Töpel
From: Björn Töpel Here, the xdpsock sample application is adjusted to the new descriptor format. Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 84 -- 1 file changed, 36 insertions(+), 48 deletions(-) diff --git a/samples/bpf/xdpsock_us

[PATCH bpf-next 2/5] xsk: proper Rx drop statistics update

2018-06-04 Thread Björn Töpel
From: Björn Töpel Previously, rx_dropped could be updated incorrectly, e.g. if the XDP program redirected the frame to a socket bound to a different queue than where the XDP program was executing. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH bpf-next 3/5] xsk: new descriptor addressing scheme

2018-06-04 Thread Björn Töpel
From: Björn Töpel Currently, AF_XDP only supports a fixed frame-size memory scheme where each frame is referenced via an index (idx). A user passes the frame index to the kernel, and the kernel acts upon the data. Some NICs, however, do not have a fixed frame-size model, instead they have a mode

[PATCH bpf-next 0/5] AF_XDP: bug fixes and descriptor changes

2018-06-04 Thread Björn Töpel
From: Björn Töpel An issue with the current AF_XDP uapi raised by Mykyta Iziumtsev (see https://www.spinics.net/lists/netdev/msg503664.html) is that it does not support NICs that have a "type-writer" model in an efficient way. In this model, a memory window is passed to the hardware and multiple

[PATCH bpf-next 5/5] samples/bpf: minor *_nb_free performance fix

2018-06-04 Thread Björn Töpel
From: Magnus Karlsson Signed-off-by: Magnus Karlsson --- samples/bpf/xdpsock_user.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index b71a342b9082..7494f60fbff8 100644 --- a/samples/bpf/xdpsock_user.c +++ b/

[PATCH bpf-next 02/11] xsk: introduce xdp_umem_page

2018-06-04 Thread Björn Töpel
From: Björn Töpel The xdp_umem_page holds the address for a page. Trade memory for faster lookup. Later, we'll add DMA address here as well. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 7 ++- net/xdp/xdp_umem.c | 15 ++- net/xdp/xdp_umem.h | 3 +-- 3 files

[PATCH bpf-next 03/11] net: xdp: added bpf_netdev_command XDP_{QUERY,SETUP}_XSK_UMEM

2018-06-04 Thread Björn Töpel
From: Björn Töpel Extend ndo_bpf with two new commands used for query zero-copy support and register an UMEM to a queue_id of a netdev. Signed-off-by: Björn Töpel --- include/linux/netdevice.h | 8 1 file changed, 8 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux

[PATCH bpf-next 01/11] xsk: moved struct xdp_umem definition

2018-06-04 Thread Björn Töpel
From: Björn Töpel Moved struct xdp_umem to xdp_sock.h, in order to prepare for zero-copy support. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 24 +++- net/xdp/xdp_umem.c | 1 + net/xdp/xdp_umem.h | 22 +- net/xdp/xsk_queue.h| 3

[PATCH bpf-next 00/11] AF_XDP: introducing zero-copy support

2018-06-04 Thread Björn Töpel
From: Björn Töpel This patch serie introduces zerocopy (ZC) support for AF_XDP. Programs using AF_XDP sockets will now receive RX packets without any copies and can also transmit packets without incurring any copies. No modifications to the application are needed, but the NIC driver needs to be m

[PATCH bpf-next 04/11] xdp: add MEM_TYPE_ZERO_COPY

2018-06-04 Thread Björn Töpel
From: Björn Töpel Here, a new type of allocator support is added to the XDP return API. A zero-copy allocated xdp_buff cannot be converted to an xdp_frame. Instead is the buff has to be copied. This is not supported at all in this commit. Also, an opaque "handle" is added to xdp_buff. This can b

[PATCH bpf-next 05/11] xsk: add zero-copy support for Rx

2018-06-04 Thread Björn Töpel
From: Björn Töpel Extend the xsk_rcv to support the new MEM_TYPE_ZERO_COPY memory, and wireup ndo_bpf call in bind. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 6 +++ include/uapi/linux/if_xdp.h | 4 +- net/xdp/xdp_umem.c | 77 n

[PATCH bpf-next 06/11] net: added netdevice operation for Tx

2018-06-04 Thread Björn Töpel
From: Magnus Karlsson Added ndo_xsk_async_xmit. This ndo "kicks" the netdev to start to pull userland AF_XDP Tx frames from a NAPI context. Signed-off-by: Magnus Karlsson --- include/linux/netdevice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/netdevice.h b/include/lin

[PATCH bpf-next 08/11] i40e: added queue pair disable/enable functions

2018-06-04 Thread Björn Töpel
From: Björn Töpel Queue pair enable/disable plumbing. Signed-off-by: Björn Töpel --- drivers/net/ethernet/intel/i40e/i40e_main.c | 251 1 file changed, 251 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i4

[PATCH bpf-next 10/11] i40e: implement AF_XDP zero-copy support for Tx

2018-06-04 Thread Björn Töpel
From: Magnus Karlsson Here, ndo_xsk_async_xmit is implemented. As a shortcut, the existing XDP Tx rings are used for zero-copy. This will result in other devices doing XDP_REDIRECT to an AF_XDP enabled queue will have its packets dropped. Signed-off-by: Magnus Karlsson --- drivers/net/ethernet

[PATCH bpf-next 09/11] i40e: implement AF_XDP zero-copy support for Rx

2018-06-04 Thread Björn Töpel
From: Björn Töpel This commit adds initial AF_XDP zero-copy support for i40e-based NICs. First we add support for the new XDP_QUERY_XSK_UMEM and XDP_SETUP_XSK_UMEM commands in ndo_bpf. This allows the AF_XDP socket to pass a UMEM to the driver. The driver will then DMA map all the frames in the U

[PATCH bpf-next 07/11] xsk: wire upp Tx zero-copy functions

2018-06-04 Thread Björn Töpel
From: Magnus Karlsson Here we add the functionality required to support zero-copy Tx, and also exposes various zero-copy related functions for the netdevs. Signed-off-by: Magnus Karlsson --- include/net/xdp_sock.h | 9 +++ net/xdp/xdp_umem.c | 29 +++-- net/xdp/xdp_ume

[PATCH bpf-next 11/11] samples/bpf: xdpsock: use skb Tx path for XDP_SKB

2018-06-04 Thread Björn Töpel
From: Björn Töpel Make sure that XDP_SKB also uses the skb Tx path. Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 5 + 1 file changed, 5 insertions(+) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index 7494f60fbff8..d69c8d78d3fd 100644 --- a/samples/b

[PATCH iproute2 0/2] display netns name instead of nsid

2018-06-04 Thread Nicolas Dichtel
[PATCH iproute2 0/2] display netns name instead of nsid After these patches, the iproute2 name of netns is displayed instead of the nsid. It's easier to read/understand. ip/ip_common.h | 3 +++ ip/ipaddress.c | 23 ++- ip/iplink.c| 18 -- ip/ipnetns.c

[PATCH iproute2 2/2] iplink: enable to specify a name for the link-netns

2018-06-04 Thread Nicolas Dichtel
The 'link-netnsid' argument needs a number. Add 'link-netns' when the user wants to use the iproute2 netns name instead of the nsid. Example: ip link add ipip1 link-netns foo type ipip remote 10.16.0.121 local 10.16.0.249 Signed-off-by: Nicolas Dichtel --- ip/ip_common.h | 2 ++ ip/iplink.c

[PATCH iproute2 1/2] ip: display netns name instead of nsid

2018-06-04 Thread Nicolas Dichtel
When iproute2 has a name for the nsid, let's display it. It's more user friendly than a number. Signed-off-by: Nicolas Dichtel --- ip/ip_common.h | 1 + ip/ipaddress.c | 23 ++- ip/ipnetns.c | 10 ++ 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/i

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-06-04 Thread Xin Long
On Mon, Jun 4, 2018 at 4:34 PM, Dmitry Vyukov wrote: > On Tue, May 29, 2018 at 7:45 PM, Xin Long wrote: >> On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner >> wrote: >>> On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo L

Re: [PATCH] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Daniel Borkmann
On 06/02/2018 06:22 AM, Daniel Borkmann wrote: > On 05/31/2018 11:44 AM, Toke Høiland-Jørgensen wrote: >> Song Liu writes: >> >>> On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen >>> wrote: This adds an example program showing how to sample packets from XDP using the perf event

Re: [PATCH RFC ipsec-next 0/3] Virtual xfrm interfaces

2018-06-04 Thread David Miller
From: Steffen Klassert Date: Mon, 4 Jun 2018 08:09:07 +0200 > This patchset introduces new virtual xfrm interfaces. > The design of virtual xfrm interfaces interfaces was > discussed at the Linux IPsec workshop 2018. This patchset > implements these interfaces as the IPsec userspace and > kernel

Re: 答复: ANNOUNCE: Enhanced IP v1.4

2018-06-04 Thread Eric Dumazet
On 06/03/2018 10:58 PM, PKU.孙斌 wrote: > On Sun, Jun 03, 2018 at 03:41:08PM -0700, Eric Dumazet wrote: >> >> >> On 06/03/2018 01:37 PM, Tom Herbert wrote: >> >>> This is not an inconsequential mechanism that is being proposed. It's >>> a modification to IP protocol that is intended to work on the

Re: [PATCH] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 06/02/2018 06:22 AM, Daniel Borkmann wrote: >> On 05/31/2018 11:44 AM, Toke Høiland-Jørgensen wrote: >>> Song Liu writes: >>> On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen wrote: > This adds an example program showing how to sample packets f

Re: [bpf-next V2 PATCH 2/8] i40e: implement flush flag for ndo_xdp_xmit

2018-06-04 Thread Daniel Borkmann
On 05/31/2018 10:59 AM, Jesper Dangaard Brouer wrote: > When passed the XDP_XMIT_FLUSH flag i40e_xdp_xmit now performs the > same kind of ring tail update as in i40e_xdp_flush. The advantage is > that all the necessary checks have been performed and xdp_ring can be > updated, instead of having to

Re: [PATCH] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 03:02 PM, Toke Høiland-Jørgensen wrote: > Daniel Borkmann writes: >> On 06/02/2018 06:22 AM, Daniel Borkmann wrote: >>> On 05/31/2018 11:44 AM, Toke Høiland-Jørgensen wrote: Song Liu writes: > On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen > wrote: >> Thi

Re: [bpf-next V2 PATCH 3/8] ixgbe: implement flush flag for ndo_xdp_xmit

2018-06-04 Thread Daniel Borkmann
On 05/31/2018 10:59 AM, Jesper Dangaard Brouer wrote: > When passed the XDP_XMIT_FLUSH flag ixgbe_xdp_xmit now performs the > same kind of ring tail update as in ixgbe_xdp_flush. The update tail > code in ixgbe_xdp_flush is generalized and shared with ixgbe_xdp_xmit. > > Signed-off-by: Jesper Dan

Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-06-04 Thread David Miller
From: Dan Carpenter Date: Thu, 31 May 2018 15:01:25 +0300 > @@ -380,7 +380,8 @@ static rx_handler_result_t > net_failover_handle_frame(struct sk_buff **pskb) > > static void net_failover_compute_features(struct net_device *dev) > { > - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F

Re: [PATCH] net: virtio: simplify the virtnet_find_vqs

2018-06-04 Thread David Miller
From: Tonghao Zhang Date: Thu, 31 May 2018 07:16:32 -0700 > Use the common free functions while return successfully. > > Signed-off-by: Tonghao Zhang This looks fine, applied, thanks.

Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread Daniel Borkmann
Hey guys, On 06/02/2018 11:39 PM, John Fastabend wrote: > On 06/01/2018 12:58 PM, Eric Dumazet wrote: >> On 06/01/2018 03:46 PM, John Fastabend wrote: >>> This fixes a crash where we assign tcp_prot to IPv6 sockets instead >>> of tcpv6_prot. >> >> ... >> >>> + /* ULPs are currently supported onl

[PATCH net-next] MAINTAINERS: TCP gets its first maintainer

2018-06-04 Thread Eric Dumazet
Signed-off-by: Eric Dumazet --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0ae0dbf0e15e74febca1b3469098a08704b59594..70d61c2b1be46c0927ae6648c644b8c7828cce48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9862,6 +9862,19 @@ F:

Re: [PATCH net-next 0/3] selftests/net: various

2018-06-04 Thread David Miller
From: Willem de Bruijn Date: Thu, 31 May 2018 12:14:37 -0400 > From: Willem de Bruijn > > A few odds and ends to network tests: > > - msg_zerocopy: run as part of kselftest > - udp gso: add missing bounds test for minimal sizes > - psocket_snd: initial basic conformance test Always grea

Re: [bpf-next V2 PATCH 3/8] ixgbe: implement flush flag for ndo_xdp_xmit

2018-06-04 Thread Jesper Dangaard Brouer
On Mon, 4 Jun 2018 15:19:05 +0200 Daniel Borkmann wrote: > > +static void ixgbe_xdp_ring_update_tail(struct ixgbe_ring *ring) > > +{ > > + /* Force memory writes to complete before letting h/w know there > > +* are new descriptors to fetch. > > +*/ > > + wmb(); > > + writel(ring->ne

Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread John Fastabend
On 06/04/2018 06:39 AM, Daniel Borkmann wrote: > Hey guys, > > On 06/02/2018 11:39 PM, John Fastabend wrote: >> On 06/01/2018 12:58 PM, Eric Dumazet wrote: >>> On 06/01/2018 03:46 PM, John Fastabend wrote: This fixes a crash where we assign tcp_prot to IPv6 sockets instead of tcpv6_prot.

Re: [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets

2018-06-04 Thread David Miller
From: Petr Machata Date: Fri, 01 Jun 2018 00:37:29 +0200 > This patchset includes two small fixes for the tests that were > introduced in commit 1bb58d2d3cbe ("Merge branch > 'Mirroring-tests-involving-VLAN'"). > > In patch #1, a "tc action trap" is uninstalled after the suite runs, > instead of

Re: [PATCH v3 net-next] net: stmmac: Add Flexible PPS support

2018-06-04 Thread David Miller
From: Jose Abreu Date: Thu, 31 May 2018 18:01:27 +0100 > This adds support for Flexible PPS output (which is equivalent > to per_out output of PTP subsystem). > > Tested using an oscilloscope and the following commands: > > 1) Start PTP4L: > # ptp4l -A -4 -H -m -i eth0 & > 2) Set Flexible

Re: [PATCH net-next v2 0/2] qed: Fix issues in UFP feature commit 'cac6f691'.

2018-06-04 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 31 May 2018 18:47:35 -0700 > From: Sudarsana Reddy Kalluru > > This patch series fixes couple of issues in the UFP feature commit, >cac6f691: Add support for Unified Fabric Port. > > Changes from previous version: > -- >

Re: [PATCH net-next] MAINTAINERS: TCP gets its first maintainer

2018-06-04 Thread Jiri Pirko
Mon, Jun 04, 2018 at 03:50:29PM CEST, eduma...@google.com wrote: >Signed-off-by: Eric Dumazet >--- > MAINTAINERS | 13 + > 1 file changed, 13 insertions(+) > >diff --git a/MAINTAINERS b/MAINTAINERS >index >0ae0dbf0e15e74febca1b3469098a08704b59594..70d61c2b1be46c0927ae6648c644b8c7828cce

Re: [PATCH net-next] MAINTAINERS: TCP gets its first maintainer

2018-06-04 Thread David Miller
From: Eric Dumazet Date: Mon, 4 Jun 2018 06:50:29 -0700 > Signed-off-by: Eric Dumazet Thanks a lot Eric, applied to net-next. :-)

[PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32

2018-06-04 Thread Dan Carpenter
The features mask needs to be a netdev_features_t (u64) because a u32 is not big enough. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan Carpenter --- v2: In the original patch, I thought that the & should be | and I introduced a bug. diff --git a/drivers/net/ne

[PATCH 2/2 net] team: use netdev_features_t instead of u32

2018-06-04 Thread Dan Carpenter
This code was introduced in 2011 around the same time that we made netdev_features_t a u64 type. These days a u32 is not big enough to hold all the potential features. Signed-off-by: Dan Carpenter diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 267dcc929f6c..8863fa023500 10

Re: [PATCH 2/2 net] team: use netdev_features_t instead of u32

2018-06-04 Thread Jiri Pirko
Mon, Jun 04, 2018 at 04:46:01PM CEST, dan.carpen...@oracle.com wrote: >This code was introduced in 2011 around the same time that we made >netdev_features_t a u64 type. These days a u32 is not big enough to >hold all the potential features. > >Signed-off-by: Dan Carpenter Acked-by: Jiri Pirko

Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

2018-06-04 Thread Jason Gunthorpe
On Sat, Jun 02, 2018 at 08:04:19AM +0300, Leon Romanovsky wrote: > On Fri, Jun 01, 2018 at 03:11:49PM -0600, Jason Gunthorpe wrote: > > On Thu, May 31, 2018 at 04:43:27PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Changelog: > > > v2->v3: > > > * Change function mlx5_fc

Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 03:57 PM, John Fastabend wrote: > On 06/04/2018 06:39 AM, Daniel Borkmann wrote: >> On 06/02/2018 11:39 PM, John Fastabend wrote: >>> On 06/01/2018 12:58 PM, Eric Dumazet wrote: On 06/01/2018 03:46 PM, John Fastabend wrote: > This fixes a crash where we assign tcp_prot to IPv

Re: 答复: ANNOUNCE: Enhanced IP v1.4

2018-06-04 Thread Tom Herbert
On Mon, Jun 4, 2018 at 6:02 AM, Eric Dumazet wrote: > > > On 06/03/2018 10:58 PM, PKU.孙斌 wrote: >> On Sun, Jun 03, 2018 at 03:41:08PM -0700, Eric Dumazet wrote: >>> >>> >>> On 06/03/2018 01:37 PM, Tom Herbert wrote: >>> This is not an inconsequential mechanism that is being proposed. It's >>>

Re: [PATCH net-next v2 1/3] bpf: implement bpf_get_current_cgroup_id() helper

2018-06-04 Thread Alexei Starovoitov
On Mon, Jun 04, 2018 at 11:08:35AM +0200, Daniel Borkmann wrote: > On 06/04/2018 12:59 AM, Yonghong Song wrote: > > bpf has been used extensively for tracing. For example, bcc > > contains an almost full set of bpf-based tools to trace kernel > > and user functions/events. Most tracing tools are cu

Re: [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU

2018-06-04 Thread David Miller
From: Li RongQing Date: Fri, 1 Jun 2018 19:03:59 +0800 > RFC4821 say: The value for this timer MUST NOT be less than > 5 minutes and is recommended to be 10 minutes, per RFC 1981. > > Signed-off-by: Li RongQing As Eric stated, admins should be allowed to set this however they wish (f.e. for s

Re: [PATCH net] ipv4: igmp: hold wakelock to prevent delayed reports

2018-06-04 Thread Tejaswi Tanikella
On Fri, Jun 01, 2018 at 07:45:16AM -0700, Florian Fainelli wrote: Thank you Florian for reviewing my patch. I had a few questions. > > > On 06/01/2018 07:05 AM, Tejaswi Tanikella wrote: > > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > > timer is started to send out a

Re: [PATCH net] ipv4: igmp: hold wakelock to prevent delayed reports

2018-06-04 Thread David Miller
From: Tejaswi Tanikella Date: Fri, 1 Jun 2018 19:35:41 +0530 > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > timer is started to send out a response after a random time within > max_delay. If the system then moves into suspend state, Report is > delayed until system wak

Re: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-06-04 Thread Nicolas Ferre
Jennifer, On 25/05/2018 at 23:44, Jennifer Dahm wrote: During testing, I discovered that the Zynq GEM hardware overwrites all outgoing UDP packet checksums, which is illegal in packet forwarding cases. This happens both with and without the checksum-zeroing behavior introduced in 007e4ba3ee13

Re: [RFC PATCH 2/2] net: macb: Disable TX checksum offloading on all Zynq

2018-06-04 Thread Nicolas Ferre
On 25/05/2018 at 23:44, Jennifer Dahm wrote: The Zynq ethernet hardware has checksum offloading bugs that cause small UDP packets (<= 2 bytes) to be sent with an incorrect checksum (0x) and forwarded UDP packets to be re-checksummed, which is illegal behavior. The best solution we have right

Re: [PATCH net-next v2 1/3] bpf: implement bpf_get_current_cgroup_id() helper

2018-06-04 Thread Yonghong Song
On 6/4/18 7:58 AM, Alexei Starovoitov wrote: On Mon, Jun 04, 2018 at 11:08:35AM +0200, Daniel Borkmann wrote: On 06/04/2018 12:59 AM, Yonghong Song wrote: bpf has been used extensively for tracing. For example, bcc contains an almost full set of bpf-based tools to trace kernel and user funct

Re: [RFC PATCH 1/2] net: macb: Add CAP to disable hardware TX checksum offloading

2018-06-04 Thread Nicolas Ferre
On 25/05/2018 at 23:44, Jennifer Dahm wrote: Certain PHYs have significant bugs in their TX checksum offloading that cannot be solved in software. In order to accommodate these PHYS, add a CAP to disable this hardware. Signed-off-by: Jennifer Dahm --- drivers/net/ethernet/cadence/macb.h

[bug] cxgb4: vrf stopped working with cxgb4 card

2018-06-04 Thread AMG Zollner Robert
I have noticed that vrf is not working with kernel v4.15.0 but was working with v4.13.0 when using cxgb4 Chelsio driver (T520-cr) Setup: Two metal servers with a T520-cr card each, directly connected without a switch in between.    SVR1  only ipfwd SVR2     with vrf .-

[bpf-next PATCH] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread John Fastabend
This fixes a crash where we assign tcp_prot to IPv6 sockets instead of tcpv6_prot. Previously we overwrote the sk->prot field with tcp_prot even in the AF_INET6 case. This patch ensures the correct tcp_prot and tcpv6_prot are used. Further, only allow ESTABLISHED connections to join the map per no

[RFC PATCH 1/4] net-sysfs: Drop support for XPS and traffic_class on single queue device

2018-06-04 Thread Alexander Duyck
This patch makes it so that we do not report the traffic class or allow XPS configuration on single queue devices. This is mostly to avoid unnecessary complexity with changes I have planned that will allow us to reuse the unused tc_to_txq and XPS configuration on a single queue device to allow it t

[RFC PATCH 2/4] net: Add support for subordinate device traffic classes

2018-06-04 Thread Alexander Duyck
This patch is meant to provide the basic tools needed to allow us to create subordinate device traffic classes. The general idea here is to allow subdividing the queues of a device into queue groups accessible through an upper device such as a macvlan. The idea here is to enforce the idea that an

[RFC PATCH 0/4] Add support for DCB and XPS with MACVLAN offload

2018-06-04 Thread Alexander Duyck
This patch set is meant to address a number of shortcomings in the current implementation of MACVLAN offload. The main issue being the fact that the current Tx queue implementation for ixgbe required the use of ndo_select_queue which doesn't necessarily play well with DCB or XPS. I started this pa

[RFC PATCH 3/4] ixgbe: Add code to populate and use macvlan tc to Tx queue map

2018-06-04 Thread Alexander Duyck
This patch makes it so that we use the tc_to_txq mapping in the macvlan device in order to select the Tx queue for outgoing packets. The idea here is to try and move away from using ixgbe_select_queue and to come up with a generic way to make this work for devices going forward. By encoding this i

[RFC PATCH 4/4] net: Add support for subordinate traffic classes to netdev_pick_tx

2018-06-04 Thread Alexander Duyck
This change makes it so that we can support the concept of subordinate device traffic classes to the core networking code. In doing this we can start pulling out the driver specific bits needed to support selecting a queue based on an upper device. The solution at is currently stands is only parti

Re: [PATCH net-next v5 00/11] Modify action API for implementing lockless actions

2018-06-04 Thread David Miller
From: Vlad Buslov Date: Fri, 1 Jun 2018 18:15:07 +0300 > Currently, all netlink protocol handlers for updating rules, actions and > qdiscs are protected with single global rtnl lock which removes any > possibility for parallelism. This patch set is a first step to remove > rtnl lock dependency f

Re: [PATCH net] net/packet: refine check for priv area size

2018-06-04 Thread David Miller
From: Eric Dumazet Date: Fri, 1 Jun 2018 09:23:02 -0700 > syzbot was able to trick af_packet again [1] :-( > Various commits tried to address the problem in the past, > but failed to take into account V3 header size. > > [1] ... > Fixes: 2b6867c2ce76 ("net/packet: fix overflow in check for p

[PATCH net-next] net: sched: return error code when tcf proto is not found

2018-06-04 Thread Vlad Buslov
If requested tcf proto is not found, get and del filter netlink protocol handlers output error message to extack, but do not return actual error code. Add check to return ENOENT when result of tp find function is NULL pointer. Fixes: c431f89b18a2 ("net: sched: split tc_ctl_tfilter into three handl

Re: [RFC feedback] AF_XDP and non-Intel hardware

2018-06-04 Thread Björn Töpel
Den mån 4 juni 2018 kl 11:44 skrev Mykyta Iziumtsev : > > Hi Björn and Magnus, > > Here is a short update on the proposed changes to AF_XDP. > > During implementation phase I figured out that 'end-of-page' in RX > descriptor's flags won't work, unfortunately. This is because the > kernel driver can

[PATCH bpf-next] bpf: guard bpf_get_current_cgroup_id() with CONFIG_CGROUPS

2018-06-04 Thread Yonghong Song
Commit bf6fa2c893c5 ("bpf: implement bpf_get_current_cgroup_id() helper") introduced a new helper bpf_get_current_cgroup_id(). The helper has a dependency on CONFIG_CGROUPS. When CONFIG_CGROUPS is not defined, using the helper will result the following verifier error: kernel subsystem misconfigu

Re: [PATCH net] VSOCK: check sk state before receive

2018-06-04 Thread Jorgen S. Hansen
> On May 30, 2018, at 11:17 AM, Stefan Hajnoczi wrote: > > On Sun, May 27, 2018 at 11:29:45PM +0800, Hangbin Liu wrote: >> Hmm...Although I won't reproduce this bug with my reproducer after >> apply my patch. I could still get a similiar issue with syzkaller sock vnet >> test. >> >> It looks t

Re: [PATCH bpf-next 0/5] AF_XDP: bug fixes and descriptor changes

2018-06-04 Thread Alexei Starovoitov
On Mon, Jun 04, 2018 at 01:57:10PM +0200, Björn Töpel wrote: > From: Björn Töpel > > An issue with the current AF_XDP uapi raised by Mykyta Iziumtsev (see > https://www.spinics.net/lists/netdev/msg503664.html) is that it does > not support NICs that have a "type-writer" model in an efficient > wa

[PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-04 Thread Toke Høiland-Jørgensen
This adds two new helper functions to trace_helpers that supports polling multiple perf file descriptors for events. These are used to the XDP perf_event_output example, which needs to work with one perf fd per CPU. Signed-off-by: Toke Høiland-Jørgensen --- tools/testing/selftests/bpf/trace_help

[PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Toke Høiland-Jørgensen
This adds an example program showing how to sample packets from XDP using the perf event buffer. The example userspace program just prints the ethernet header for every packet sampled. The example sets up a perf file descriptor per CPU, allowing the XDP program to pass BPF_F_CURRENT_CPU and work n

Re: [PATCH net-next 0/2] cls_flower: Various fixes

2018-06-04 Thread Cong Wang
On Mon, Jun 4, 2018 at 12:35 AM, Roi Dayan wrote: > > > On 03/06/2018 22:39, Jiri Pirko wrote: >> >> Sun, Jun 03, 2018 at 08:33:25PM CEST, xiyou.wangc...@gmail.com wrote: >>> >>> On Wed, May 30, 2018 at 1:17 AM, Paul Blakey wrote: Two of the fixes are for my multiple mask patch >>>

Re: [PATCH bpf-next 00/11] AF_XDP: introducing zero-copy support

2018-06-04 Thread Alexei Starovoitov
On Mon, Jun 04, 2018 at 02:05:50PM +0200, Björn Töpel wrote: > From: Björn Töpel > > This patch serie introduces zerocopy (ZC) support for > AF_XDP. Programs using AF_XDP sockets will now receive RX packets > without any copies and can also transmit packets without incurring any > copies. No modi

[PATCH net] l2tp: fix refcount leakage on PPPoL2TP sockets

2018-06-04 Thread Guillaume Nault
Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session object destroy") tried to fix a race condition where a PPPoL2TP socket would disappear while the L2TP session was still using it. However, it missed the root issue which is that an L2TP session may accept to be reconnected if its

Re: [PATCH] net-tcp: extend tcp_tw_reuse sysctl to enable loopback only optimization

2018-06-04 Thread Eric Dumazet
On 06/03/2018 10:41 AM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This changes the /proc/sys/net/ipv4/tcp_tw_reuse from a boolean > to an integer. > > It now takes the values 0, 1 and 2, where 0 and 1 behave as before, > while 2 enables timewait socket reuse only for sockets

Re: [PATCH] net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets

2018-06-04 Thread Eric Dumazet
On 06/03/2018 10:47 AM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > It is not safe to do so because such sockets are already in the > hash tables and changing these options can result in invalidating > the tb->fastreuse(port) caching. > Reviewed-by: Eric Dumazet

Re: [PATCH net-next V2 1/2] cls_flower: Fix missing free of rhashtable

2018-06-04 Thread Simon Horman
On Sun, Jun 03, 2018 at 10:06:13AM +0300, Paul Blakey wrote: > When destroying the instance, destroy the head rhashtable. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Pa

Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter

2018-06-04 Thread Simon Horman
On Sun, Jun 03, 2018 at 10:06:14AM +0300, Paul Blakey wrote: > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Bu

[net-next 03/12] Documentation: e1000: Update kernel documentation

2018-06-04 Thread Jeff Kirsher
Updated the e1000.txt kernel documentation with the latest information. Also convert the text file to reStructuredText (RST) format, since the Linux kernel documentation now uses this format for documentation. Signed-off-by: Jeff Kirsher Tested-by: Aaron Brown --- .../networking/{e1000.txt =>

[net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Jeff Kirsher
This series contains a smorgasbord of updates to documentation, e1000e, igb, ixgbe, ixgbevf and i40e. Benjamin Poirier fixes a potential kernel crash due to NULL pointer dereference in e1000e. Jeff updates the kernel documentation for e100 and e1000 to correct default values and URLs which were i

[net-next 10/12] ixgbe: fix possible race in reset subtask

2018-06-04 Thread Jeff Kirsher
From: Tony Nguyen Similar to ixgbevf, the same possibility for race exists. Extend the RTNL lock in ixgbe_reset_subtask() to protect the state bits; this is to make sure that we get the most up-to-date values for the bits and avoid a possible race when going down. Signed-off-by: Tony Nguyen Tes

[net-next 05/12] igb: Wait 10ms just once after TX queues reset

2018-06-04 Thread Jeff Kirsher
From: Sergey Nemov Move 10ms sleep out of function resetting TX queue. Reset all the TX queues in one turn and wait for all of them just once. Use usleep_range() instead of mdelay() in order not to affect transmission on other interfaces. Signed-off-by: Sergey Nemov Tested-by: Aaron Brown Sig

[net-next 09/12] bpf, i40e: add meta data support

2018-06-04 Thread Jeff Kirsher
From: Daniel Borkmann Add support for XDP meta data when using build skb variant of the i40e driver. Implementation is analogous to the existing ixgbe and ixgbevf support for meta data from 366a88fe2f40 ("bpf, ixgbe: add meta data support") and be822eff ("ixgbevf: Add support for meta data").

[net-next 04/12] igb: Clear TSICR interrupts together with ICR

2018-06-04 Thread Jeff Kirsher
From: Joanna Yurdal Issuing "ip link set up/down" can block TSICR interrupts, what results in missing PTP Tx timestamp and no PPS pulse generation. Problem happens when the link is set up with the TSICR interrupts pending. ICR is cleared before enabling interrupts, while TSICR is not. When all T

[net-next 12/12] ixgbe: fix broken ipsec Rx with proper cast on spi

2018-06-04 Thread Jeff Kirsher
From: Shannon Nelson Fix up a cast problem introduced by a sparse cleanup patch. This fixes a problem where the encrypted packets were not recognized on Rx and subsequently dropped. Fixes: 9cfbfa701b55 ("ixgbe: cleanup sparse warnings") Signed-off-by: Shannon Nelson Signed-off-by: Jeff Kirsher

[net-next 11/12] ixgbe: check ipsec ip addr against mgmt filters

2018-06-04 Thread Jeff Kirsher
From: Shannon Nelson Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Si

[net-next 06/12] ixgbevf: Fix coexistence of malicious driver detection with XDP

2018-06-04 Thread Jeff Kirsher
From: Alexander Duyck In the case of the VF driver it is supposed to provide a context descriptor that allows us to provide information about the header offsets inside of the frame. However in the case of XDP we don't really have any of that information since the data is minimally processed. As a

[net-next 07/12] ixgbevf: fix possible race in the reset subtask

2018-06-04 Thread Jeff Kirsher
From: Emil Tantilov Extend the RTNL lock in ixgbevf_reset_subtask() to protect the state bits check in addition to the call to ixgbevf_reinit_locked(). This is to make sure that we get the most up-to-date values for the bits and avoid a possible race when going down. Suggested-by: Zhiping du S

[net-next 08/12] ixgbe: introduce a helper to simplify code

2018-06-04 Thread Jeff Kirsher
From: YueHaibing ixgbe_dbg_reg_ops_read and ixgbe_dbg_netdev_ops_read copy-pasting the same code except for ixgbe_dbg_netdev_ops_buf/ixgbe_dbg_reg_ops_buf, so introduce a helper ixgbe_dbg_common_ops_read to remove redundant code. Signed-off-by: YueHaibing Tested-by: Andrew Bowers Signed-off-by

[net-next 01/12] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-06-04 Thread Jeff Kirsher
From: Benjamin Poirier There have been multiple reports of crashes that look like kernel: RIP: 0010:[] timecounter_read+0xf/0x50 [...] kernel: Call Trace: kernel: [] e1000e_phc_gettime+0x2f/0x60 [e1000e] kernel: [] e1000e_systim_overflow_work+0x1d/0x80 [e1000e] kernel: [] process_one_work+0x15

[net-next 02/12] Documentation: e100: Update the Intel 10/100 driver doc

2018-06-04 Thread Jeff Kirsher
Over the years, several of the links have changed or are no longer valid so update them. In addition, the default values were incorrect for a couple of parameters. Converted the text file to the reStructuredText (RST) format, since the Linux kernel documentation now uses this format for documenta

  1   2   >