Hello Florian,
Thanks for your feedback, I will send a v2 with those changes.
Regards
On Wed, 2018-05-30 at 10:46 -0700, Florian Fainelli wrote:
>
> On 05/30/2018 08:33 AM, Damien Thébault wrote:
> > This patch adds support for the BCM5389 switch connected through
> > MDIO.
>
> This looks good
This patch adds support for the BCM5389 switch connected through MDIO.
Signed-off-by: Damien Thébault
---
Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
drivers/net/dsa/b53/b53_common.c | 13 +
drivers/net/dsa/b53/b53_mdio.c| 5 -
On Wed, 30 May 2018 15:18:02 -0700
Song Liu wrote:
> Overall, this set looks good to me. The only suggestion I have is to add more
> documentation on the expected behavior of XDP_XMIT_FLUSH in netdevice.h
> (as part of 01/08).
I do see your point, as the behavior of XDP_XMIT_FLUSH is actually mo
On Wed, 30 May 2018 15:06:27 -0700
Song Liu wrote:
> > diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> > index 04fbd75a5274..9c846a7a8cff 100644
> > --- a/kernel/bpf/devmap.c
> > +++ b/kernel/bpf/devmap.c
> > @@ -217,7 +217,7 @@ void __dev_map_insert_ctx(struct bpf_map *map, u32 bit)
> >
Implement helper delete function that uses new action ops 'delete', instead
of destroying action directly. This is required so act API could delete
actions by index, without holding any references to action that is being
deleted.
Implement function __tcf_action_put() that releases reference to act
Extend action ops with 'delete' function. Each action type to implements
its own delete function that doesn't depend on rtnl lock.
Implement delete function that is required to delete actions without
holding rtnl lock. Use action API function that atomically deletes action
only if it is still in a
Act API used linked list to pass set of actions to functions. It is
intrusive data structure that stores list nodes inside action structure
itself, which means it is not safe to modify such list concurrently.
However, action API doesn't use any linked list specific operations on this
set of actions
Implement new action API function that atomically finds and deletes action
from idr by index. Intended to be used by lockless actions that do not rely
on rtnl lock.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
Changes from V1 to V2:
- Rename tcf_
Change action API to assume that action init function always takes
reference to action, even when overwriting existing action. This is
necessary because action API continues to use action pointer after init
function is done. At this point action becomes accessible for concurrent
modifications, so u
Implement functions to atomically update and free action cookie
using rcu mechanism.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
include/net/act_api.h | 2 +-
include/net/pkt_cls.h | 1 +
net/sched/act_api.c | 44 +++
Without rtnl lock protection it is no longer safe to use pointer to tc
action without holding reference to it. (it can be destroyed concurrently)
Remove unsafe action idr lookup function. Instead of it, implement safe tcf
idr check function that atomically looks up action in idr and increments
its
Add additional 'rtnl_held' argument to act API init functions. It is
required to implement actions that need to release rtnl lock before loading
kernel module and reacquire if afterwards.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
Changes from
Change type of action reference counter to refcount_t.
Change type of action bind counter to atomic_t.
This type is used to allow decrementing bind counter without testing
for 0 result.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
include/net/a
Currently, all netlink protocol handlers for updating rules, actions and
qdiscs are protected with single global rtnl lock which removes any
possibility for parallelism. This patch set is a first step to remove
rtnl lock dependency from TC rules update path.
Recently, new rtnl registration flag RT
Implement function that atomically checks if action exists and either takes
reference to it, or allocates idr slot for action index to prevent
concurrent allocations of actions with same index. Use EBUSY error pointer
to indicate that idr slot is reserved.
Implement cleanup helper function that re
Return from action init function with reference to action taken,
even when overwriting existing action.
Action init API initializes its fourth argument (pointer to pointer to tc
action) to either existing action with same index or newly created action.
In case of existing index(and bind argument i
On Wed, 30 May 2018 14:58:16 -0700
Song Liu wrote:
> On Wed, May 30, 2018 at 11:00 AM, Jesper Dangaard Brouer
> wrote:
> > Signed-off-by: Jesper Dangaard Brouer
>
> I guess we still need to say something in the commit message?
Okay, I'll go through all of the driver changes and add some tex
Hi Tkhai/David,
We are facing mutex dead lock condition that we think might be related to a fix
that you have provided in:
Merge branch
'Close-race-between-un-register_netdevice_notifier-and-pernet_operations'
commit b9a12601541eb55d07e00261a5112a4bc36fe7be
We tried to backport the patch serie
On Wed, 30 May 2018 14:58:16 -0700 Song Liu wrote:
> > @@ -3699,6 +3699,9 @@ int i40e_xdp_xmit(struct net_device *dev, int n,
> > struct xdp_frame **frames,
> > }
> > }
> >
> > + if (unlikely(flags & XDP_XMIT_FLUSH))
> > + i40e_xdp_ring_update_tail(vsi
Le 30/05/2018 à 22:29, Ido Schimmel a écrit :
[snip]
> There is another instance of this magic number in the file, but it's
> written in lower case so you might have missed it - see
> ip_tunnel_newlink(). Can you please take care of it in v2?
Good catch, thank you.
Will send a v2.
As I mentioned in merge commit 10f678683e4 ("Merge branch 'xdp_xmit-bulking'")
I plan to change the API for ndo_xdp_xmit once more, by adding a flags
argument, which is done in this patchset.
I know it is late in the cycle (currently at rc7), but it would be
nice to avoid changing NDOs over severa
When passed the XDP_XMIT_FLUSH flag virtnet_xdp_xmit now performs the
same virtqueue_kick as virtnet_xdp_flush.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/virtio_net.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/vi
The first patch restores the possibility to bind an ip4 tunnel to an
interface whith a large mtu.
The second patch was spotted after the first fix. I also target it to net
because it fixes the max mtu value that can be used for ipv6 tunnels.
v2: remove the 0xfff8 in ip_tunnel_newlink()
net/ipv
This patch only change the API and reject any use of flags. This is an
intermediate step that allows us to implement the flush flag operation
later, for each individual driver in a separate patch.
The plan is to implement flush operation via XDP_XMIT_FLUSH flag
and then remove XDP_XMIT_FLAGS_NONE
After commit f6cc9c054e77, the following conf is broken (note that the
default loopback mtu is 65536, ie IP_MAX_MTU + 1):
$ ip tunnel add gre1 mode gre local 10.125.0.1 remote 10.125.0.2 dev lo
add tunnel "gre0" failed: Invalid argument
$ ip l a type dummy
$ ip l s dummy1 up
$ ip l s dummy1 mtu 65
The XDP_REDIRECT map devmap can avoid using ndo_xdp_flush, by instead
instructing ndo_xdp_xmit to flush via XDP_XMIT_FLUSH flag in
appropriate places.
Notice after this patch it is possible to remove ndo_xdp_flush
completely, as this is the last user of ndo_xdp_flush. This is left
for later patche
I don't know where this value comes from (probably a copy and paste and
paste and paste ...).
Let's use standard values which are a bit greater.
Link:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a
Signed-off-by: Nicolas Dichtel
---
net/ipv6/i
This is the first real user of the XDP_XMIT_FLUSH flag.
As pointed out many times, XDP_REDIRECT without using BPF maps is
significant slower than the map variant. This is primary due to the
lack of bulking, as the ndo_xdp_flush operation is required after each
frame (to avoid frames hanging on th
When passed the XDP_XMIT_FLUSH flag ixgbe_xdp_xmit now performs the
same kind of ring tail update as in ixgbe_xdp_flush. The update tail
code in ixgbe_xdp_flush is generalized and shared with ixgbe_xdp_xmit.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
Removing XDP_XMIT_FLAGS_NONE as all driver now implement
a flush operation in their ndo_xdp_xmit call. The compiler
will catch if any users of XDP_XMIT_FLAGS_NONE remains.
Signed-off-by: Jesper Dangaard Brouer
---
include/net/xdp.h |1 -
1 file changed, 1 deletion(-)
diff --git a/include/n
When passed the XDP_XMIT_FLUSH flag tun_xdp_xmit now performs the same
kind of socket wake up as in tun_xdp_flush(). The wake up code from
tun_xdp_flush is generalized and shared with tun_xdp_xmit.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/tun.c | 19 +--
1 file cha
When passed the XDP_XMIT_FLUSH flag i40e_xdp_xmit now performs the
same kind of ring tail update as in i40e_xdp_flush. The advantage is
that all the necessary checks have been performed and xdp_ring can be
updated, instead of having to perform the exact same steps/checks in
i40e_xdp_flush
Signed-
Hi, Illyas,
On 31.05.2018 11:43, Mansoor, Illyas wrote:
> We are facing mutex dead lock condition that we think might be related to a
> fix that you have provided in:
> Merge branch
> 'Close-race-between-un-register_netdevice_notifier-and-pernet_operations'
> commit b9a12601541eb55d07e00261a511
On Thu, May 31, 2018 at 12:21:31PM +0300, Kirill Tkhai wrote:
> Hi, Illyas,
>
> On 31.05.2018 11:43, Mansoor, Illyas wrote:
> > We are facing mutex dead lock condition that we think might be related to a
> > fix that you have provided in:
> > Merge branch
> > 'Close-race-between-un-register_netd
Song Liu writes:
> On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen wrote:
>> This adds an example program showing how to sample packets from XDP using
>> the perf event buffer. The example userspace program just prints the
>> ethernet header for every packet sampled.
>>
>> Most of the us
Hi Vlad,
Can you try one simple test below with these patches?
#create an action
sudo $TC actions add action skbedit mark 1 pipe
#
sudo $TC qdisc del dev lo parent :
sudo $TC qdisc add dev lo ingress
# bind action to filter
sudo $TC filter add dev lo parent : protocol ip prio 1 \
u32
Use the % instead of while, and it may simple code and improve
the calculating. The real_num_tx_queues has been checked when
allocating and setting it.
Signed-off-by: Tonghao Zhang
---
net/core/dev.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/core/dev.c b/net
On Wed, May 30, 2018 at 9:29 PM, Jiri Pirko wrote:
> Wed, May 30, 2018 at 11:26:23AM CEST, john.hur...@netronome.com wrote:
>>On Tue, May 29, 2018 at 11:09 PM, Jiri Pirko wrote:
>>> Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote:
On Sat, May 26, 2018 at 3:47 AM, Jakub K
We may derference an invalid pointer in the error path of
xfrm_bundle_create(). Fix this by returning this error
pointer directly instead of assigning it to xdst0.
Fixes: 45b018beddb6 ("ipsec: Create and use new helpers for dst child access.")
Signed-off-by: Steffen Klassert
---
net/xfrm/xfrm_po
From: Eric Dumazet
syzbot found a way to trigger an infinitie loop by overflowing
@offset variable that has been forced to use u16 for some very
obscure reason in the past.
We probably want to look at NEXTHDR_FRAGMENT handling which looks
wrong, in a separate patch.
In net-next, we shall try to
1) Avoid possible overflow of the offset variable
in _decode_session6(), this fixes an infinite
lookp there. From Eric Dumazet.
2) We may use an error pointer in the error path of
xfrm_bundle_create(). Fix this by returning this
pointer directly to the caller.
Please pull or let me k
This has an '&' vs '|' typo so it starts with vlan_features set to none.
Also a u32 type isn't large enough to hold all the feature bits, it
should be netdev_features_t.
Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/net_failover.
We forgot to set the error code on this path. This function is supposed
to return error pointers, so with this bug it accidentally returns NULL
and the caller doesn't check for that.
Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/net
On 5/30/2018 10:20 AM, Tariq Toukan wrote:
On 28/05/2018 7:09 PM, Eric Dumazet wrote:
On 05/28/2018 07:52 AM, Alexander Aring wrote:
as somebody who had similar issues with this patch series I can tell you
about what happened for the 6LoWPAN fragmentation.
The issue sounds similar, but
Signed-off-by: Thadeu Lima de Souza Cascardo
---
include/net/caif/caif_layer.h | 2 +-
net/caif/cfrfml.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/caif/caif_layer.h b/include/net/caif/caif_layer.h
index 94e5ed64dc6d..8a114e57bcb6 100644
--- a/i
Signed-off-by: Thadeu Lima de Souza Cascardo
---
include/linux/if_vlan.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 78a5a90b4267..83ea4df6ab81 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@
On Thu 31 May 2018 at 10:01, Jamal Hadi Salim wrote:
> Hi Vlad,
>
> Can you try one simple test below with these patches?
>
> #create an action
> sudo $TC actions add action skbedit mark 1 pipe
> #
> sudo $TC qdisc del dev lo parent :
> sudo $TC qdisc add dev lo ingress
> # bind action to fi
Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks")
brought two regressions caught in our regression suite.
The big one is an additional cost of 256 bytes of overhead per 4096 bytes,
or 6.25 % which is unacceptable since ICM can be pretty large.
This comes from having to al
From: Leon Romanovsky
Changelog:
v2->v3:
* Change function mlx5_fc_query signature to hide the details of
internal core driver struct mlx5_fc
* Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h)
* Use array of struct mlx5_ib_flow_counters_desc to clarify the output
From: Raed Salem
User space application which uses counters functionality,
is expected to allocate/release the counters resources by
calling create/destroy verbs and in turn get a unique handle
that can be used to attach the counters to its counted type.
Reviewed-by: Yishai Hadas
Signed-off-by:
From: Raed Salem
A verbs application may need to get statistics and info on various
aspects of a verb object (e.g. Flow, QP, ...), in general case the
application will state which object's counters its interested in
(we refer to this action as attach), bind this new counters object
to the appropr
From: Matan Barak
This is required when user-space drivers need to pass extra information
regarding how to handle this flow steering specification.
Reviewed-by: Yishai Hadas
Signed-off-by: Matan Barak
Signed-off-by: Boris Pismenny
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/core/u
From: Raed Salem
The user supplies counters instance and a reference to an output
array of uint64_t.
The driver reads the hardware counters values and writes them to
the output index location in the user supplied array.
All counters values are represented as uint64_t types.
To be able to success
From: Matan Barak
Previously, the user had to dig inside the attribute to get the uobject.
Add a helper function that correctly extract it (and do the required
checks) for him/her.
Signed-off-by: Matan Barak
Reviewed-by: Michael J. Ruhl
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/c
From: Raed Salem
The struct ib_uverbs_flow_spec_action_count associates
a counters object with the flow.
Post this association the flow counters can be read via
the counters object.
Reviewed-by: Yishai Hadas
Signed-off-by: Raed Salem
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/cor
From: Raed Salem
Implements the flow counters read wrapper.
Reviewed-by: Yishai Hadas
Signed-off-by: Raed Salem
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/hw/mlx5/main.c| 15 +++
drivers/infiniband/hw/mlx5/mlx5_ib.h | 13 -
2 files changed, 27 insertion
From: Raed Salem
This patch implements the device counters create and destroy APIs
and introducing some internal management structures.
Downstream patches in this series will add the functionality to
support flow counters binding and reading.
Reviewed-by: Yishai Hadas
Signed-off-by: Raed Salem
From: Raed Salem
This patch implements the uverbs counters read API, it will use the
specific read counters function to the given type to accomplish its
task.
Reviewed-by: Yishai Hadas
Signed-off-by: Raed Salem
Signed-off-by: Leon Romanovsky
---
drivers/infiniband/hw/mlx5/main.c | 43 +++
From: Raed Salem
Exports counters API to be used in both IB and EN.
Reviewed-by: Yishai Hadas
Signed-off-by: Raed Salem
Signed-off-by: Leon Romanovsky
---
drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 2 --
drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c | 3 +++
include/linu
From: Raed Salem
A counters object could be attached to flow on creation
by providing the counter specification action.
General counters description which count packets and bytes are
introduced, downstream patches from this series will use them
as part of flow counters binding.
In addition, inc
From: Raed Salem
Associates a counters with a flow when IB_FLOW_SPEC_ACTION_COUNT
is part of the flow specifications.
The counters user space placements of location and description
(index, description) pairs are passed as private data of the
counters flow specification.
Reviewed-by: Yishai Hada
From: Raed Salem
This patch exposes the read counters verb to user space
applications.
By that verb the user can read the hardware counters which
are associated with the counters object.
The application needs to provide a sufficient memory to
hold the statistics.
Reviewed-by: Yishai Hadas
Sign
From: Or Gerlitz
This allows to un-expose the details of struct mlx5_fc and keep
it internal to the core driver as it used to be.
Signed-off-by: Or Gerlitz
Signed-off-by: Leon Romanovsky
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 15 ++-
drivers/net/ethernet/mella
Andrew Lunn writes:
> Make it explicit that either device tree is used or platform data. If
> neither is available, abort the probe.
>
> Reported-by: Dan Carpenter
> Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support")
> Signed-off-by: Andrew Lunn
Reviewed-by: Vivien
On Thu, May 31, 2018 at 8:18 AM Moshe Shemesh wrote:
>
>
>
> I do see big improvement after changing the 3 parameters as Eric suggested:
> /proc/sys/net/ipv6/ip6frag_time set to 2
> /proc/sys/net/ipv6/ip6frag_low_thresh set to 104857600
> /proc/sys/net/ipv6/ip6frag_high_thresh set to 78643200
>
>
On 05/30/2018 03:15 PM, Andrew Lunn wrote:
> Make it explicit that either device tree is used or platform data. If
> neither is available, abort the probe.
>
> Reported-by: Dan Carpenter
> Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support")
> Signed-off-by: Andrew L
On 05/31/2018 12:04 AM, Damien Thébault wrote:
> This patch adds support for the BCM5389 switch connected through MDIO.
>
> Signed-off-by: Damien Thébault
Looks great, thanks Damien.
Reviewed-by: Florian Fainelli
--
Florian
Use the common free functions while return successfully.
Signed-off-by: Tonghao Zhang
---
drivers/net/virtio_net.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 8f08a3e..0eee6d6 100644
--- a/drivers/net/virtio_n
Parse and display those attributes.
Example:
ip l a type dummy
ip netns add foo
ip monitor link&
ip l s dummy1 netns foo
Deleted 6: dummy1: mtu 1500 qdisc noop state DOWN group
default
link/ether 66:af:3a:3f:a0:89 brd ff:ff:ff:ff:ff:ff new-nsid 0 new-ifindex 6
Signed-off-by: Nicolas Dichtel
Oops, I use an old email for Stephen, sorry.
Regards,
Nicolas
Le 31/05/2018 à 16:28, Nicolas Dichtel a écrit :
> Parse and display those attributes.
> Example:
> ip l a type dummy
> ip netns add foo
> ip monitor link&
> ip l s dummy1 netns foo
> Deleted 6: dummy1: mtu 1500 qdisc noop state DOWN
>-Original Message-
>From: Leon Romanovsky [mailto:l...@kernel.org]
>Sent: Thursday, May 31, 2018 9:44 AM
>To: Doug Ledford ; Jason Gunthorpe
>
>Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ; Matan
>Barak ; Ruhl, Michael J ;
>Or Gerlitz ; Raed Salem ;
>Yisha
>-Original Message-
>From: Leon Romanovsky [mailto:l...@kernel.org]
>Sent: Thursday, May 31, 2018 9:44 AM
>To: Doug Ledford ; Jason Gunthorpe
>
>Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ; Matan
>Barak ; Ruhl, Michael J ;
>Or Gerlitz ; Raed Salem ;
>Yisha
The structure shared between driver and management firmware (MFW)
differ in sizes. The additional field defined by the MFW is not
relevant to the current driver. Add a dummy field to the structure.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Elior
---
drivers/net/ethernet/qlogic
Incorrect shared memory address is used while deriving the values
for tc and pri_type. Use shmem address corresponding to 'oem_cfg_func'
where the management firmare saves tc/pri_type values.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Elior
---
drivers/net/ethernet/qlogic/qed/q
From: Sudarsana Reddy Kalluru
This patch series fixes couple of issues in the UFP feature commit,
cac6f691: Add support for Unified Fabric Port.
Please consider applying it to "net-next".
Sudarsana Reddy Kalluru (2):
qed: Fix shared memory inconsistency between driver and the MFW.
qed: F
On 5/31/2018 5:42 PM, Ruhl, Michael J wrote:
-Original Message-
From: Leon Romanovsky [mailto:l...@kernel.org]
Sent: Thursday, May 31, 2018 9:44 AM
To: Doug Ledford ; Jason Gunthorpe
Cc: Leon Romanovsky ; RDMA mailing list ; Boris Pismenny ; Matan
Barak ; Ruhl, Michael J ;
Or Gerlitz ; R
Sorry for the late response i had some time to take another look and do some
extra testing
> switchdev is about offloading what Linux can do to hardware to
> accelerate it. The switch is a block of accelerator hardware, like a
> GPU is for accelerating graphics. Linux can render OpenGL, but it is
On Thu, 31 May 2018 16:28:48 +0200
Nicolas Dichtel wrote:
> Parse and display those attributes.
> Example:
> ip l a type dummy
> ip netns add foo
> ip monitor link&
> ip l s dummy1 netns foo
> Deleted 6: dummy1: mtu 1500 qdisc noop state DOWN group
> default
> link/ether 66:af:3a:3f:a0:89 b
Le 31/05/2018 à 17:46, Stephen Hemminger a écrit :
> On Thu, 31 May 2018 16:28:48 +0200
[snip]
> This makes sense. All of linkinfo that is present should be displayed.
>
> Both netns and ifindex are really unsigned values. Use __u32 and print_uint.
Ok.
> Also why not convert numeric values to nam
On 30.05.2018 22:35, Andrew Lunn wrote:
>> I think we need a better solution than spending the effort needed
>> to make the MDIO ops runtime-pm-aware. In general there seems to be
>> just one network driver using both phylib and runtime pm, so most
>> drivers aren't affected (yet).
>>
>> I will spe
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
wrote:
> The XDP_REDIRECT map devmap can avoid using ndo_xdp_flush, by instead
> instructing ndo_xdp_xmit to flush via XDP_XMIT_FLUSH flag in
> appropriate places.
>
> Notice after this patch it is possible to remove ndo_xdp_flush
> completel
On Thu, May 31, 2018 at 1:59 AM, Jesper Dangaard Brouer
wrote:
> When passed the XDP_XMIT_FLUSH flag ixgbe_xdp_xmit now performs the
> same kind of ring tail update as in ixgbe_xdp_flush. The update tail
> code in ixgbe_xdp_flush is generalized and shared with ixgbe_xdp_xmit.
>
> Signed-off-by: J
From: Willem de Bruijn
The existing msg_zerocopy test takes additional protocol arguments.
Add a variant that takes no arguments and runs all supported variants.
Call this from kselftest.
Signed-off-by: Willem de Bruijn
---
tools/testing/selftests/net/Makefile| 2 +-
tools/testing/self
From: Willem de Bruijn
A few odds and ends to network tests:
- msg_zerocopy: run as part of kselftest
- udp gso: add missing bounds test for minimal sizes
- psocket_snd: initial basic conformance test
Willem de Bruijn (3):
selftests/net: enable msg_zerocopy test
selftests/net: udpgso:
From: Willem de Bruijn
Verify that udpgso can generate segments smaller than device mtu, down
to the extreme case of 1B gso_size.
Verify that irrespective of gso_size, udpgso restricts the number of
segments it will generate per call (UDP_MAX_SEGMENTS).
Signed-off-by: Willem de Bruijn
---
too
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
wrote:
> When passed the XDP_XMIT_FLUSH flag tun_xdp_xmit now performs the same
> kind of socket wake up as in tun_xdp_flush(). The wake up code from
> tun_xdp_flush is generalized and shared with tun_xdp_xmit.
>
> Signed-off-by: Jesper Danga
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
wrote:
> When passed the XDP_XMIT_FLUSH flag virtnet_xdp_xmit now performs the
> same virtqueue_kick as virtnet_xdp_flush.
>
> Signed-off-by: Jesper Dangaard Brouer
Acked-by: Song Liu
> ---
> drivers/net/virtio_net.c |6 +-
> 1 f
From: Willem de Bruijn
Add regression tests for PF_PACKET transmission using packet_snd.
The TPACKET ring interface has tests for transmission and reception.
This is an initial stab at the same for the send call based interface.
Packets are sent over loopback, then read twice. The entire packet
On 5/31/2018 4:43 PM, Leon Romanovsky wrote:
From: Leon Romanovsky
Changelog:
v2->v3:
* Change function mlx5_fc_query signature to hide the details of
internal core driver struct mlx5_fc
* Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h)
* Use array of stru
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
wrote:
> Removing XDP_XMIT_FLAGS_NONE as all driver now implement
> a flush operation in their ndo_xdp_xmit call. The compiler
> will catch if any users of XDP_XMIT_FLAGS_NONE remains.
>
> Signed-off-by: Jesper Dangaard Brouer
Acked-by: So
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
wrote:
> This is the first real user of the XDP_XMIT_FLUSH flag.
>
> As pointed out many times, XDP_REDIRECT without using BPF maps is
> significant slower than the map variant. This is primary due to the
> lack of bulking, as the ndo_xdp_fl
This adds support for Flexible PPS output (which is equivalent
to per_out output of PTP subsystem).
Tested using an oscilloscope and the following commands:
1) Start PTP4L:
# ptp4l -A -4 -H -m -i eth0 &
2) Set Flexible PPS frequency:
# echo > /sys/class/ptp/ptpX/period
Where
On Thu, May 31, 2018 at 02:49:44PM +, Ruhl, Michael J wrote:
> >-Original Message-
> >From: Leon Romanovsky [mailto:l...@kernel.org]
> >Sent: Thursday, May 31, 2018 9:44 AM
> >To: Doug Ledford ; Jason Gunthorpe
> >
> >Cc: Leon Romanovsky ; RDMA mailing list >r...@vger.kernel.org>; Bori
On 5/31/2018 5:04 AM, Dan Carpenter wrote:
We forgot to set the error code on this path. This function is supposed
to return error pointers, so with this bug it accidentally returns NULL
and the caller doesn't check for that.
Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-
From: Song Liu
Date: Tue, 29 May 2018 10:03:21 -0700
> Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit()
> is being bypassed. This is because "ret" from sch_direct_xmit() will be
> either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0
> will reach the cond
On 5/31/2018 5:01 AM, Dan Carpenter wrote:
This has an '&' vs '|' typo so it starts with vlan_features set to none.
Also a u32 type isn't large enough to hold all the feature bits, it
should be netdev_features_t.
Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: Dan Car
On Wed, May 30, 2018 at 04:11:37PM +0300, Yuval Bason wrote:
> This patch adds support for configuring SRQ and provides the necessary
> APIs for rdma upper layer driver (qedr) to enable the SRQ feature.
>
> Signed-off-by: Michal Kalderon
> Signed-off-by: Ariel Elior
> Signed-off-by: Yuval Bason
Move the function do_test_span_vlan_dir_ips() from mirror_vlan.sh test
to a library file mirror_lib.sh to allow reuse. Fill in other entry
points similar to other testing functions in mirror_lib.sh, they will be
useful in following patches.
Signed-off-by: Petr Machata
---
.../testing/selftests/n
Move vlan_capture_install() and vlan_capture_uninstall() from
mirror_vlan.sh test to lib.sh so that it can be reused in other tests.
Signed-off-by: Petr Machata
---
tools/testing/selftests/net/forwarding/lib.sh | 23 ++
.../selftests/net/forwarding/mirror_vlan.sh
When the VLAN capture is installed on a front panel device and not a
soft device, the packets are counted twice: once in fast path, and once
after they are trapped to the kernel. Resolve the problem by passing
skip_hw flag to vlan_capture_install().
Signed-off-by: Petr Machata
---
tools/testing/
1 - 100 of 148 matches
Mail list logo
