Re: [PATCH RESEND rdma-next] net/mlx5: Use flow counter pointer as input to the query function

2018-05-30 Thread Leon Romanovsky
On Wed, May 30, 2018 at 09:44:34AM +0300, Or Gerlitz wrote: > This allows to un-expose the details of struct mlx5_fc and keep > it internal to the core driver as it used to be. > > Signed-off-by: Or Gerlitz > --- > > Jason, > > As you asked, I am sending a fixup in case you intend to apply > V2 of

Re: [PATCH RESEND rdma-next] net/mlx5: Use flow counter pointer as input to the query function

2018-05-30 Thread Or Gerlitz
On Wed, May 30, 2018 at 9:59 AM, Leon Romanovsky wrote: > > Care to pass it through our usual submission channel? sure, Jason asked for a fixup, I will push it internally Or.

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Michael Chan
On Tue, May 29, 2018 at 11:33 PM, Jakub Kicinski wrote: > > At some points you (Broadcom) were working whole bunch of devlink > configuration options for the PCIe side of the ASIC. The number of > queues relates to things like number of allocated MSI-X vectors, which > if memory serves me was in

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Tariq Toukan
On 28/05/2018 7:09 PM, Eric Dumazet wrote: On 05/28/2018 07:52 AM, Alexander Aring wrote: as somebody who had similar issues with this patch series I can tell you about what happened for the 6LoWPAN fragmentation. The issue sounds similar, but there is too much missing information here to

Re: [PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-30 Thread Quentin Monnet
On 29 May 2018 at 20:44, Daniel Borkmann wrote: > On 05/29/2018 08:27 PM, Song Liu wrote: >> On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet >> wrote: >>> These are minor edits for the eBPF helpers documentation in >>> include/uapi/linux/bpf.h. >>> >>> The main fix consists in removing "BPF_FIB_L

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 3:20 AM Tariq Toukan wrote: > Not sure, the transmit BW you get is higher than what we saw. > Anyway, we'll check this. That is on a 40Gbit test bed (mlx4 cx/3), maybe you were using a 10Gbit NIC ?

[PATCH net-next 1/2] cls_flower: Fix missing free of rhashtable

2018-05-30 Thread Paul Blakey
When destroying the instance, destroy the head rhashtable. Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Jiri Pirko Signed-off-by: Paul Blakey --- net/sched/cls_flower.c | 2 ++ 1 file changed, 2 insertions

[PATCH net-next 0/2] cls_flower: Various fixes

2018-05-30 Thread Paul Blakey
Two of the fixes are for my multiple mask patch Paul Blakey (2): cls_flower: Fix missing free of rhashtable cls_flower: Fix comparing of old filter mask with new filter net/sched/cls_flower.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.7.4

[PATCH net-next 2/2] cls_flower: Fix comparing of old filter mask with new filter

2018-05-30 Thread Paul Blakey
We incorrectly compare the mask and the result is that we can't modify an already existing rule. Fix that by comparing correctly. Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Jiri Pirko Signed-off-by: Paul

[PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule

2018-05-30 Thread Paul Blakey
When we fail to modify a rule, we incorrectly release the idr handle of the unmodified old rule. Fix that by checking if we need to release it. Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Acked-by: Jiri Pirko Signed-off-by

[PATCH net 1/2] ip_tunnel: restore binding to ifaces with a large mtu

2018-05-30 Thread Nicolas Dichtel
After commit f6cc9c054e77, the following conf is broken (note that the default loopback mtu is 65536, ie IP_MAX_MTU + 1): $ ip tunnel add gre1 mode gre local 10.125.0.1 remote 10.125.0.2 dev lo add tunnel "gre0" failed: Invalid argument $ ip l a type dummy $ ip l s dummy1 up $ ip l s dummy1 mtu 65

[PATCH net 2/2] ip6_tunnel: remove magic mtu value 0xFFF8

2018-05-30 Thread Nicolas Dichtel
I don't know where this value comes from (probably a copy and paste and paste and paste ...). Let's use standard values which are a bit greater. Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a Signed-off-by: Nicolas Dichtel --- net/ipv6/i

[PATCH net 0/2] ip[6] tunnels: fix mtu calculations

2018-05-30 Thread Nicolas Dichtel
The first patch restores the possibility to bind an ip4 tunnel to an interface whith a large mtu. The second patch was spotted after the first fix. I also target it to net because it fixes the max mtu value that can be used for ipv6 tunnels. net/ipv4/ip_tunnel.c | 6 +++--- net/ipv6/ip6_tunne

Re: [PATCH net] VSOCK: check sk state before receive

2018-05-30 Thread Stefan Hajnoczi
On Sun, May 27, 2018 at 11:29:45PM +0800, Hangbin Liu wrote: > Hmm...Although I won't reproduce this bug with my reproducer after > apply my patch. I could still get a similiar issue with syzkaller sock vnet > test. > > It looks this patch is not complete. Here is the KASAN call trace with my >

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Jesper Dangaard Brouer
On Mon, 28 May 2018 09:09:17 -0700 Eric Dumazet wrote: > Tariq, here are my test results : No drops for me. > > # ./netperf -H 2607:f8b0:8099:e18:: -t UDP_STREAM > MIGRATED UDP STREAM TEST from ::0 (::) port 0 AF_INET6 to > 2607:f8b0:8099:e18:: () port 0 AF_INET6 > Socket Message Elapsed

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-30 Thread John Hurley
On Tue, May 29, 2018 at 11:09 PM, Jiri Pirko wrote: > Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: >>On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski >> wrote: >>> On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin.

Feature Request : iface may be allowed as datatype in all ipset

2018-05-30 Thread Akshat Kakkar
Is there a reason why iface is allowed to be paired only with net to create an ipset? I think with feature of skbinfo in every ipset, it should be allowed to add iface in all ipset. As skbinfo can store tc classes, it might make more sense if I can pin point on which outgoing interface this class

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 5:20 AM Jesper Dangaard Brouer wrote: > On Mon, 28 May 2018 09:09:17 -0700 > Eric Dumazet wrote: > > Tariq, here are my test results : No drops for me. > > > > # ./netperf -H 2607:f8b0:8099:e18:: -t UDP_STREAM > > MIGRATED UDP STREAM TEST from ::0 (::) port 0 AF_INET6 to

Re: [PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-30 Thread Daniel Borkmann
On 05/30/2018 02:12 AM, Song Liu wrote: > On Tue, May 29, 2018 at 2:20 PM, Jakub Kicinski wrote: >> On Tue, 29 May 2018 13:29:31 -0700, Andrey Ignatov wrote: >>> Add support for recently added BPF_CGROUP_UDP4_SENDMSG and >>> BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation >>>

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 6:36 AM Eric Dumazet wrote: > Here are the good ones, using latest David Miller net tree. ( plus > https://patchwork.ozlabs.org/patch/922528/ but that should not matter here) > llpaa23:/export/hda3/google/edumazet# ./netperf -H 2607:f8b0:8099:e18:: -t > UDP_STREAM > MIG

Re: [PATCH bpf-next v7 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-30 Thread Daniel Borkmann
On 05/24/2018 12:18 PM, Daniel Borkmann wrote: > On 05/20/2018 03:58 PM, Mathieu Xhonneux wrote: >> The BPF seg6local hook should be powerful enough to enable users to >> implement most of the use-cases one could think of. After some thinking, >> we figured out that the following actions should be

[PATCH net-next] cxgb4: Add FORCE_PAUSE bit to 32 bit port caps

2018-05-30 Thread Ganesh Goudar
Add FORCE_PAUSE bit to force local pause settings instead of using auto negotiated values. Signed-off-by: Santosh Rastapur Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c| 10 +- drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h |

[PATCH] rtnetlink: Add more well known protocol values

2018-05-30 Thread Donald Sharp
FRRouting installs routes into the kernel associated with the originating protocol. Add these values to the well known values in rtnetlink.h. Signed-off-by: Donald Sharp --- v2: Fixed whitespace issues include/uapi/linux/rtnetlink.h | 5 + 1 file changed, 5 insertions(+) diff --git a/inclu

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Yishai Hadas
On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h index 508ea8c82da7..ef3f430a7050 100644 +++ b/include/uapi/rdma/mlx5-abi.h @@ -443,4 +443,18 @@ enum { enum {

Re: [PATCH] rtnetlink: Add more well known protocol values

2018-05-30 Thread Donald Sharp
This patch is intended for net-next. thanks! donald On Wed, May 30, 2018 at 8:27 AM, Donald Sharp wrote: > FRRouting installs routes into the kernel associated with > the originating protocol. Add these values to the well > known values in rtnetlink.h. > > Signed-off-by: Donald Sharp > --- >

[PATCH net-next] qed: Add srq core support for RoCE and iWARP

2018-05-30 Thread Yuval Bason
This patch adds support for configuring SRQ and provides the necessary APIs for rdma upper layer driver (qedr) to enable the SRQ feature. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior Signed-off-by: Yuval Bason --- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 5 +- drivers/net/e

Re: [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure

2018-05-30 Thread John Fastabend
On 05/29/2018 10:56 PM, Prashant Bhole wrote: > Test failures are not identified because exit code of RX/TX threads > is not checked. Also threads are not returning correct exit code. > > - Return exit code from threads depending on test execution status > - In main thread, check the exit code of

Re: [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout

2018-05-30 Thread John Fastabend
On 05/29/2018 10:56 PM, Prashant Bhole wrote: > In order to reduce runtime of tests, recently timout for select() call > was reduced from 1sec to 10usec. This was causing many tests failures. > It was caught with failure handling commits in this series. > > Restoring the timeout from 10usec to 1se

Re: [PATCH bpf v3 0/5] fix test_sockmap

2018-05-30 Thread John Fastabend
On 05/29/2018 10:56 PM, Prashant Bhole wrote: > This series fixes error handling, timeout and data verification in > test_sockmap. Previously it was not able to detect failure/timeout in > RX/TX thread because error was not notified to the main thread. > > Also slightly improved test output by pri

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Tariq Toukan
On 30/05/2018 7:11 AM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. Note that mlx4_alloc_icm() is already able to try high order allocations and fallback to low-order alloca

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-30 Thread Tariq Toukan
On 30/05/2018 10:36 AM, Eric Dumazet wrote: On Wed, May 30, 2018 at 3:20 AM Tariq Toukan wrote: Not sure, the transmit BW you get is higher than what we saw. Anyway, we'll check this. That is on a 40Gbit test bed (mlx4 cx/3), maybe you were using a 10Gbit NIC ? It is a ConnectX-4 50G (

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: > On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: > >On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > >>diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h > >>index 508ea8c82da7..ef3f430a7050 100644

Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-30 Thread Saeed Mahameed
On Wed, 2018-05-30 at 03:04 +0200, Andrew Lunn wrote: > On Tue, May 29, 2018 at 05:19:53PM -0700, Saeed Mahameed wrote: > > From: Ilan Tayari > > > > Temperature warning event is sent by FW to indicate high > > temperature > > as detected by one of the sensors on the board. > > Add handling of th

Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-30 Thread Saeed Mahameed
On Wed, 2018-05-30 at 03:07 +0200, Andrew Lunn wrote: > On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote: > > From: Ilan Tayari > > > > The FPGA QP event fires whenever a QP on the FPGA trasitions > > to the error state. > > FPGA i know, field programmable gate array. Could you off

Re: [PATCH iproute2-next] ipaddress: Add support for address metric

2018-05-30 Thread David Ahern
On 5/27/18 9:10 AM, dsah...@kernel.org wrote: > From: David Ahern > > Add support for IFA_RT_PRIORITY using the same keywords as iproute for > RTA_PRIORITY. > > Signed-off-by: David Ahern > --- > include/uapi/linux/if_addr.h | 1 + > ip/ipaddress.c | 15 ++- > man/ma

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Yishai Hadas
On 5/30/2018 6:06 PM, Jason Gunthorpe wrote: On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h ind

[PATCH v2 iproute2-next] ip route: print RTA_CACHEINFO if it exists

2018-05-30 Thread dsahern
From: David Ahern RTA_CACHEINFO can be sent for non-cloned routes. If the attribute is present print it. Allows route dumps to print expires times for example which can exist on FIB entries. Signed-off-by: David Ahern --- v2 - leave print_cache_flags under r->rtm_flags & RTM_F_CLONED check ip

[PATCH] b53: Add brcm5389 support

2018-05-30 Thread Damien Thébault
This patch adds support for the BCM5389 switch connected through MDIO. Signed-off-by: Damien Thébault --- drivers/net/dsa/b53/b53_common.c | 13 + drivers/net/dsa/b53/b53_mdio.c | 5 - drivers/net/dsa/b53/b53_priv.h | 1 + 3 files changed, 18 insertions(+), 1 deletion(-) d

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 06:24:00PM +0300, Yishai Hadas wrote: > On 5/30/2018 6:06 PM, Jason Gunthorpe wrote: > >On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: > >>On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: > >>>On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > >>>

Re: [RFC net-next 0/4] net: sched: support replay of filter offload when binding to block

2018-05-30 Thread Or Gerlitz
On Mon, May 28, 2018 at 11:02 PM, Jakub Kicinski wrote: > On Mon, 28 May 2018 13:48:28 +0300, Or Gerlitz wrote: >> On Fri, May 25, 2018 at 5:25 AM, Jakub Kicinski wrote: >> > This series from John adds the ability to replay filter offload requests >> > when new offload callback is being registered

Re: [PATCH bpf-next 10/11] bpf: sync bpf uapi header with tools

2018-05-30 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Pull in recent changes from include/uapi/linux/bpf.h. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by: Song Liu > --- > tools/include/uapi/linux/bpf.h | 20 ++-- > 1 file changed, 18 insertio

Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

2018-05-30 Thread Song Liu
On Tue, May 29, 2018 at 12:55 PM, Daniel Borkmann wrote: > On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote: >> On Mon, 28 May 2018 02:43:37 +0200 >> Daniel Borkmann wrote: >> >>> Its trivial and straight forward to expose it for scripts that can >>> then use it along with bpftool in order to

Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-30 Thread Andrew Lunn
> Hi Andrew, yes the temperature is available by other means, this patch > is needed for alert information reasons in order to know which internal > sensors triggered the alarm. > We are working in parallel to expose temperature sensor to hwmon, but > this is still WIP. > > > Is it ok to have bot

Re: [PATCH RESEND rdma-next] net/mlx5: Use flow counter pointer as input to the query function

2018-05-30 Thread Saeed Mahameed
On Wed, 2018-05-30 at 09:44 +0300, Or Gerlitz wrote: > This allows to un-expose the details of struct mlx5_fc and keep > it internal to the core driver as it used to be. > > Signed-off-by: Or Gerlitz > --- > > Jason, > > As you asked, I am sending a fixup in case you intend to apply > V2 of the

Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-30 Thread Andrew Lunn
On Wed, May 30, 2018 at 03:14:20PM +, Saeed Mahameed wrote: > On Wed, 2018-05-30 at 03:07 +0200, Andrew Lunn wrote: > > On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote: > > > From: Ilan Tayari > > > > > > The FPGA QP event fires whenever a QP on the FPGA trasitions > > > to the

[PATCH] samples/bpf: Add xdp_sample_pkts example

2018-05-30 Thread Toke Høiland-Jørgensen
This adds an example program showing how to sample packets from XDP using the perf event buffer. The example userspace program just prints the ethernet header for every packet sampled. Most of the userspace code is borrowed from other examples, most notably trace_output. Note that the example onl

Re: [PATCH bpf-next 09/11] bpf: fix context access in tracing progs on 32 bit archs

2018-05-30 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Wang reported that all the testcases for BPF_PROG_TYPE_PERF_EVENT > program type in test_verifier report the following errors on x86_32: > > 172/p unpriv: spill/fill of different pointers ldx FAIL > Unexpected error message! > 0: (bf)

Re: [PATCH bpf-next 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-05-30 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > While some of the BPF map lookup helpers provide a ->map_gen_lookup() > callback for inlining the map lookup altogether it is not available > for every map, so the remaining ones have to call bpf_map_lookup_elem() > helper which does a disp

[PATCH iproute2 net-next] iproute: ip route get support for sport, dport and ipproto match

2018-05-30 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- ip/iproute.c | 26 +- man/man8/ip-route.8.in | 20 +++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 56dd9f2..ef04d27 100644 --- a/ip/iproute

Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

2018-05-30 Thread Jesper Dangaard Brouer
On Wed, 30 May 2018 09:15:25 -0700 Song Liu wrote: > On Tue, May 29, 2018 at 12:55 PM, Daniel Borkmann > wrote: > > On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote: > >> On Mon, 28 May 2018 02:43:37 +0200 > >> Daniel Borkmann wrote: > >> > >>> Its trivial and straight forward to expos

Re: [PATCH bpf-next 07/11] bpf: make sure to clear unused fields in tunnel/xfrm state fetch

2018-05-30 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Since the remaining bits are not filled in struct bpf_tunnel_key > resp. struct bpf_xfrm_state and originate from uninitialized stack > space, we should make sure to clear them before handing control > back to the program. > > Also add a pa

Re: [PATCH bpf-next 08/11] bpf: fix cbpf parser bug for octal numbers

2018-05-30 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Range is 0-7, not 0-9, otherwise parser silently excludes it from the > strtol() rather than throwing an error. > > Reported-by: Marc Boschma > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by: Song Liu > --- >

Re: [PATCH] drivers/net: Fix various unnecessary characters after logging newlines

2018-05-30 Thread David Miller
From: Joe Perches Date: Mon, 28 May 2018 19:51:57 -0700 > Remove and coalesce formats when there is an unnecessary > character after a logging newline. These extra characters > cause logging defects. > > Miscellanea: > > o Coalesce formats > > Signed-off-by: Joe Perches Applied to net-next,

Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-30 Thread Saeed Mahameed
On Wed, 2018-05-30 at 18:21 +0200, Andrew Lunn wrote: > On Wed, May 30, 2018 at 03:14:20PM +, Saeed Mahameed wrote: > > On Wed, 2018-05-30 at 03:07 +0200, Andrew Lunn wrote: > > > On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote: > > > > From: Ilan Tayari > > > > > > > > The FPG

Re: [v2] MAINTAINERS: add myself as maintainer for QorIQ PTP clock driver

2018-05-30 Thread David Miller
From: Yangbo Lu Date: Tue, 29 May 2018 11:47:44 +0800 > Added myself as maintainer for QorIQ PTP clock driver. > Since gianfar_ptp.c was renamed to ptp_qoriq.c, let's > maintain it under QorIQ PTP clock driver. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - Dropped dpaa2/rtc par

Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-30 Thread Saeed Mahameed
On Wed, 2018-05-30 at 18:17 +0200, Andrew Lunn wrote: > > Hi Andrew, yes the temperature is available by other means, this > > patch > > is needed for alert information reasons in order to know which > > internal > > sensors triggered the alarm. > > We are working in parallel to expose temperature

Re: [PATCH] b53: Add brcm5389 support

2018-05-30 Thread Florian Fainelli
On 05/30/2018 08:33 AM, Damien Thébault wrote: > This patch adds support for the BCM5389 switch connected through MDIO. This looks good, please do address the following couple of things: - subject should be: net: dsa: b53: Add BCM5389 support - you also need to update Documentation/devicetree/b

[net] ixgbe: fix parsing of TC actions for HW offload

2018-05-30 Thread Jeff Kirsher
From: Ondřej Hlavatý The previous code was optimistic, accepting the offload of whole action chain when there was a single known action (drop/redirect). This results in offloading a rule which should not be offloaded, because its behavior cannot be reproduced in the hardware. For example: $ tc

[bpf-next V1 PATCH 1/8] xdp: add flags argument to ndo_xdp_xmit API

2018-05-30 Thread Jesper Dangaard Brouer
This patch only change the API and reject any use of flags. This is an intermediate step that allows us to implement the flush flag operation later, for each individual driver in a separate patch. The plan is to implement flush operation via XDP_XMIT_FLUSH flag and then remove XDP_XMIT_FLAGS_NONE

[bpf-next V1 PATCH 0/8] bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation

2018-05-30 Thread Jesper Dangaard Brouer
As I mentioned in merge commit 10f678683e4 ("Merge branch 'xdp_xmit-bulking'") I plan to change the API for ndo_xdp_xmit once more, by adding a flags argument, which is done in this patchset. I know it is late in the cycle (currently at rc7), but it would be nice to avoid changing NDOs over severa

[bpf-next V1 PATCH 3/8] ixgbe: implement flush flag for ndo_xdp_xmit

2018-05-30 Thread Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 87f088f4af52..4f

[bpf-next V1 PATCH 4/8] tun: implement flush flag for ndo_xdp_xmit

2018-05-30 Thread Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer --- drivers/net/tun.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index b182b8cdd219..d82a05fb0594 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1285,6 +1285,14

[bpf-next V1 PATCH 2/8] i40e: implement flush flag for ndo_xdp_xmit

2018-05-30 Thread Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/intel/i40e/i40e_txrx.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index c0451d6e0790..03c1446f0465 100644 --- a

[bpf-next V1 PATCH 8/8] bpf/xdp: devmap can avoid calling ndo_xdp_flush

2018-05-30 Thread Jesper Dangaard Brouer
The XDP_REDIRECT map devmap can avoid using ndo_xdp_flush, by instead instructing ndo_xdp_xmit to flush via XDP_XMIT_FLUSH flag in appropriate places. Notice after this patch it is possible to remove ndo_xdp_flush completely, as this is the last user of ndo_xdp_flush. This is left for later patche

[bpf-next V1 PATCH 6/8] xdp: done implementing ndo_xdp_xmit flush flag for all drivers

2018-05-30 Thread Jesper Dangaard Brouer
Removing XDP_XMIT_FLAGS_NONE as all driver now implement a flush operation in their ndo_xdp_xmit call. The compiler will catch if any users of XDP_XMIT_FLAGS_NONE remains. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h |1 - 1 file changed, 1 deletion(-) diff --git a/include/n

[bpf-next V1 PATCH 7/8] bpf/xdp: non-map redirect can avoid calling ndo_xdp_flush

2018-05-30 Thread Jesper Dangaard Brouer
This is the first real user of the XDP_XMIT_FLUSH flag. As pointed out many times, XDP_REDIRECT without using BPF maps is significant slower than the map variant. This is primary due to the lack of bulking, as the ndo_xdp_flush operation is required after each frame (to avoid frames hanging on th

[bpf-next V1 PATCH 5/8] virtio_net: implement flush flag for ndo_xdp_xmit

2018-05-30 Thread Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer --- drivers/net/virtio_net.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 4ed823625953..62ba8aadd8e6 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c

[PATCH v2] ixgbe: check ipsec ip addr against mgmt filters

2018-05-30 Thread Shannon Nelson
Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Signed-off-by: Shannon Ne

[PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-30 Thread Saeed Mahameed
Hi, The following series is for mlx5-next tree [1], it adds the support of two new device events, from Ilan Tayari: 1. High temperature warnings. 2. FPGA QP error event. In case of no objection this series will be applied to mlx5-next tree and will be sent later as a pull request to both rdma a

[PATCH V2 mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-30 Thread Saeed Mahameed
From: Ilan Tayari Temperature warning event is sent by FW to indicate high temperature as detected by one of the sensors on the board. Add handling of this event by writing the numbers of the alert sensors to the kernel log. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: S

[PATCH V2 mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-30 Thread Saeed Mahameed
From: Ilan Tayari The FPGA queue pair (QP) event fires whenever a QP on the FPGA transitions to the error state. At this stage, this event is unrecoverable, it may become recoverable in the future. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- driver

[PATCH] iproute2: fix 'ip xfrm monitor all' command

2018-05-30 Thread Nathan Harold
Currently, calling 'ip xfrm monitor all' will actually invoke the 'all-nsid' command because the soft-match for 'all-nsid' occurs before the precise match for 'all'. This patch rearranges the checks so that the 'all' command, itself an alias for invoking 'ip xfrm monitor' with no argument, can be c

[PATCH bpf-next] bpf: Change bpf_fib_lookup to return -EAFNOSUPPORT for unsupported address families

2018-05-30 Thread dsahern
From: David Ahern Update bpf_fib_lookup to return -EAFNOSUPPORT for unsupported address families. Allows userspace to probe for support as more are added (e.g., AF_MPLS). Signed-off-by: David Ahern --- net/core/filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ne

Re: [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout

2018-05-30 Thread Alexei Starovoitov
On Wed, May 30, 2018 at 02:56:09PM +0900, Prashant Bhole wrote: > In order to reduce runtime of tests, recently timout for select() call > was reduced from 1sec to 10usec. This was causing many tests failures. > It was caught with failure handling commits in this series. > > Restoring the timeout

Re: [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout

2018-05-30 Thread John Fastabend
On 05/30/2018 12:29 PM, Alexei Starovoitov wrote: > On Wed, May 30, 2018 at 02:56:09PM +0900, Prashant Bhole wrote: >> In order to reduce runtime of tests, recently timout for select() call >> was reduced from 1sec to 10usec. This was causing many tests failures. >> It was caught with failure handl

[PATCH net-next] net: phy: consider PHY_IGNORE_INTERRUPT in state machine PHY_NOLINK handling

2018-05-30 Thread Heiner Kallweit
We can bail out immediately also in case of PHY_IGNORE_INTERRUPT because phy_mac_interupt() informs us once the link is up. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c i

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-30 Thread Heiner Kallweit
Am 24.05.2018 um 00:04 schrieb Andrew Lunn: > On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: >> I have the issue that suspending the MAC-integrated PHY gives an >> error during system suspend. The sequence is: >> >> 1. unconnected PHY/MAC are runtime-suspended already >> 2. system

Re: [PATCH net 1/2] ip_tunnel: restore binding to ifaces with a large mtu

2018-05-30 Thread Ido Schimmel
On Wed, May 30, 2018 at 10:28:42AM +0200, Nicolas Dichtel wrote: > After commit f6cc9c054e77, the following conf is broken (note that the > default loopback mtu is 65536, ie IP_MAX_MTU + 1): > > $ ip tunnel add gre1 mode gre local 10.125.0.1 remote 10.125.0.2 dev lo > add tunnel "gre0" failed: Inv

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-30 Thread Paolo Abeni
Hi, On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > Yes, that code is not correct, we should fix that code Did you have any chance to address the issue and/or to give a more in- deepth look to the change proposed in my initial email? Thanks, Paolo

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-30 Thread Jiri Pirko
Wed, May 30, 2018 at 11:26:23AM CEST, john.hur...@netronome.com wrote: >On Tue, May 29, 2018 at 11:09 PM, Jiri Pirko wrote: >> Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: >>>On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski >>> wrote: On Fri, 25 May 2018 08:48:09 +020

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. If KASAN reported issue was really caused by smaller chunk sizes, changing allocation order dynamically

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-30 Thread Andrew Lunn
> I think we need a better solution than spending the effort needed > to make the MDIO ops runtime-pm-aware. In general there seems to be > just one network driver using both phylib and runtime pm, so most > drivers aren't affected (yet). > > I will spend few more thoughts on a solution .. Hi Hei

Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-30 Thread Jiri Pirko
Sun, May 27, 2018 at 11:17:29PM CEST, vla...@mellanox.com wrote: >Act API used linked list to pass set of actions to functions. It is >intrusive data structure that stores list nodes inside action structure >itself, which means it is not safe to modify such list concurrently. >However, action API d

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: > > > > On 5/29/2018 9:11 PM, Eric Dumazet wrote: > > Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") > > brought a regression caught in our regression suite, thanks to KASAN. > > If KASAN reported issue was really caused

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/30/2018 1:50 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. If KASAN

Re: [PATCH bpf-next] bpf: Change bpf_fib_lookup to return -EAFNOSUPPORT for unsupported address families

2018-05-30 Thread Alexei Starovoitov
On Wed, May 30, 2018 at 12:24:17PM -0700, dsah...@kernel.org wrote: > From: David Ahern > > Update bpf_fib_lookup to return -EAFNOSUPPORT for unsupported address > families. Allows userspace to probe for support as more are added > (e.g., AF_MPLS). > > Signed-off-by: David Ahern Applied, Thank

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Samudrala, Sridhar
On 5/29/2018 11:33 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: Isn't ndo_set_vf_xxx(

[PATCH bpf] bpf: prevent non-ipv4 socket to be added into sock map

2018-05-30 Thread Wei Wang
From: Wei Wang Sock map only supports IPv4 socket proto right now. If a non-IPv4 socket gets stored in the BPF map, sk->sk_prot gets overwritten with the v4 tcp prot. It could potentially cause issues when invoking functions from sk->sk_prot later in the stack. Fixes: 174a79ff9515 ("bpf: sockmap

[PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into sock hash

2018-05-30 Thread Wei Wang
From: Wei Wang Sock hash only supports IPv4 socket proto right now. If a non-IPv4 socket gets stored in the BPF map, sk->sk_prot gets overwritten with the v4 tcp prot. Syskaller reported the following related issue on an IPv6 socket: BUG: KASAN: slab-out-of-bounds in ip6_dst_idev include/net/ip6

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Eric Dumazet
On Wed, May 30, 2018 at 5:08 PM Qing Huang wrote: > > > > On 5/30/2018 1:50 PM, Eric Dumazet wrote: > > On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: > >> > >> > >> On 5/29/2018 9:11 PM, Eric Dumazet wrote: > >>> Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") > >>>

Re: [bpf-next V1 PATCH 1/8] xdp: add flags argument to ndo_xdp_xmit API

2018-05-30 Thread Song Liu
On Wed, May 30, 2018 at 11:00 AM, Jesper Dangaard Brouer wrote: > This patch only change the API and reject any use of flags. This is an > intermediate step that allows us to implement the flush flag operation > later, for each individual driver in a separate patch. > > The plan is to implement fl

Re: [bpf-next V1 PATCH 2/8] i40e: implement flush flag for ndo_xdp_xmit

2018-05-30 Thread Song Liu
On Wed, May 30, 2018 at 11:00 AM, Jesper Dangaard Brouer wrote: > Signed-off-by: Jesper Dangaard Brouer I guess we still need to say something in the commit message? > --- > drivers/net/ethernet/intel/i40e/i40e_txrx.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --gi

Re: [bpf-next V1 PATCH 8/8] bpf/xdp: devmap can avoid calling ndo_xdp_flush

2018-05-30 Thread Song Liu
On Wed, May 30, 2018 at 11:01 AM, Jesper Dangaard Brouer wrote: > The XDP_REDIRECT map devmap can avoid using ndo_xdp_flush, by instead > instructing ndo_xdp_xmit to flush via XDP_XMIT_FLUSH flag in > appropriate places. > > Notice after this patch it is possible to remove ndo_xdp_flush > complete

[PATCH net-next] net: dsa: mv88e6xxx: Be explicit about DT or pdata

2018-05-30 Thread Andrew Lunn
Make it explicit that either device tree is used or platform data. If neither is available, abort the probe. Reported-by: Dan Carpenter Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support") Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 3 +++ 1 file

Re: [bpf-next V1 PATCH 0/8] bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation

2018-05-30 Thread Song Liu
Overall, this set looks good to me. The only suggestion I have is to add more documentation on the expected behavior of XDP_XMIT_FLUSH in netdevice.h (as part of 01/08). Thanks, Song On Wed, May 30, 2018 at 11:00 AM, Jesper Dangaard Brouer wrote: > As I mentioned in merge commit 10f678683e4 ("M

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Jakub Kicinski
On Wed, 30 May 2018 00:18:39 -0700, Michael Chan wrote: > On Tue, May 29, 2018 at 11:33 PM, Jakub Kicinski wrote: > > At some points you (Broadcom) were working whole bunch of devlink > > configuration options for the PCIe side of the ASIC. The number of > > queues relates to things like number of

greetings

2018-05-30 Thread Miss Zeliha ömer Faruk
-- Hello I have been trying to contact you. Did you get my business proposal? Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turke

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Jakub Kicinski
On Wed, 30 May 2018 14:23:06 -0700, Samudrala, Sridhar wrote: > On 5/29/2018 11:33 PM, Jakub Kicinski wrote: > > On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: > >> On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: > >>> On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: >

Re: [PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-30 Thread Qing Huang
On 5/30/2018 2:30 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 5:08 PM Qing Huang wrote: On 5/30/2018 1:50 PM, Eric Dumazet wrote: On Wed, May 30, 2018 at 4:30 PM Qing Huang wrote: On 5/29/2018 9:11 PM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page

[PATCH bpf-next] xsk: temporarily disable AF_XDP

2018-05-30 Thread Björn Töpel
From: Björn Töpel Temporarily disable AF_XDP sockets, and hide uapi. Signed-off-by: Björn Töpel --- include/{uapi => }/linux/if_xdp.h | 0 net/xdp/Kconfig | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename include/{uapi => }/linux/if_xdp.h (100%) diff --git a/inc

  1   2   >