[PATCH V0:net-next 3/4] net: stmmac: add dwmac-4.20a compatible

2018-05-25 Thread Christophe Roullier
Manage dwmac-4.20a version from synopsys Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac

[PATCH V0:net-next 1/4] net: ethernet: stmmac: add adaptation for stm32mp157c.

2018-05-25 Thread Christophe Roullier
Glue codes to support stm32mp157c device and stay compatible with stm32 mcu familly Signed-off-by: Christophe Roullier Acked-by: Alexandre TORGUE --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 267 -- 1 file changed, 252 insertions(+), 15 deletions(-) diff --git a/

[PATCH V0:net-next 4/4] dt-bindings: stm32: add compatible for syscon

2018-05-25 Thread Christophe Roullier
This patch describes syscon DT bindings. Signed-off-by: Christophe Roullier Reviewed-by: Rob Herring --- .../devicetree/bindings/arm/stm32/stm32-syscon.txt | 14 ++ .../devicetree/bindings/arm/{ => stm32}/stm32.txt | 0 2 files changed, 14 insertions(+) create mod

[PATCH V0:net-next 2/4] dt-bindings: stm32-dwmac: add support of MPU families

2018-05-25 Thread Christophe Roullier
Add description for Ethernet MPU families fields Signed-off-by: Christophe Roullier Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/st

[PATCH V0:net-next 0/4] net: ethernet: stmmac: add support for stm32mp1

2018-05-25 Thread Christophe Roullier
Patches to have Ethernet support on stm32mp1 Christophe Roullier (4): net: ethernet: stmmac: add adaptation for stm32mp157c. dt-bindings: stm32-dwmac: add support of MPU families net: stmmac: add dwmac-4.20a compatible dt-bindings: stm32: add compatible for syscon .../devicetree/bindings

Re: [PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-25 Thread Daniel Mack
On Thursday, May 24, 2018 09:07 AM, Robert Jarzmik wrote: Now the dma_slave_map is available for PXA architecture, switch the SSP device to it. This specifically means that : - for platform data based machines, the DMA requestor channels are extracted from the slave map, where pxa-ssp-dai. is

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

2018-05-25 Thread Geert Uytterhoeven
Hi Vladimir, On Thu, May 24, 2018 at 1:11 PM, Vladimir Zapolskiy wrote: > For ages trivial changes to RAVB and SuperH ethernet links by means of > standard 'ethtool' trigger a 'sleeping function called from invalid > context' bug, to visualize it on r8a7795 ULCB: > > % ethtool -r eth0 > BUG:

Re: [PATCH bpf-next 0/5] fix test_sockmap

2018-05-25 Thread Prashant Bhole
On 5/24/2018 1:58 PM, John Fastabend wrote: On 05/23/2018 09:47 PM, Prashant Bhole wrote: On 5/23/2018 6:44 PM, Prashant Bhole wrote: On 5/22/2018 2:08 AM, John Fastabend wrote: On 05/20/2018 10:13 PM, Prashant Bhole wrote: On 5/19/2018 1:42 AM, John Fastabend wrote: On 05/18/2018 12

Re: [PATCH bpf-next v7 6/6] selftests/bpf: test for seg6local End.BPF action

2018-05-25 Thread Daniel Borkmann
On 05/25/2018 04:30 AM, Y Song wrote: > When compiling latest bpf-next, I hit the following compilation error: > > clang -I. -I./include/uapi -I../../../include/uapi -idirafter > /usr/local/include -idirafter > /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include > -idirafter /usr/inclu

Re: [PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-25 Thread Daniel Mack
On Thursday, May 24, 2018 09:06 AM, Robert Jarzmik wrote: As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the

Re: Hangs in r8152 connected to power management in kernels at least up v4.17-rc4

2018-05-25 Thread Jiri Slaby
On 05/16/2018, 03:36 PM, Jiri Slaby wrote: > So I assume it must be a problem of making usb->disconnect without prior > ndo->close (or alike). So according to my debug messages, I think this should workaround the problem: --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -3962,7 +3962

Re: [PATCH net-next] selftests: net: Test headroom handling of ip6_gre devices

2018-05-25 Thread Petr Machata
William Tu writes: >> +cleanup() >> +{ >> + ip link del dev swp1 >> + ip link del dev swp3 >> + ip link del dev vh3 > I think we also need to do: > ip link del dev gt6 gt6 is removed in test_headroom, but for early-break sort of scenarios I guess we do want to have it in cleanu

[PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Mathieu Xhonneux
Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks some UAPI headers in tools/. clang -I. -I./include/uapi -I../../../include/uapi -idirafter /usr/local/include -idirafter /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include -idirafter /usr/include -Wno-compare-dist

Re: [PATCH net] tun: Fix NULL pointer dereference in XDP redirect

2018-05-25 Thread Jason Wang
On 2018年05月25日 12:32, Toshiaki Makita wrote: Calling XDP redirection requires preempt/bh disabled. Especially softirq can call another XDP function and redirection functions, then percpu value ri->map can be overwritten to NULL. This is a generic XDP case called from tun. [ 3535.736058] BUG:

Re: [net-next] ath10k: Remove useless test before clk_disable_unprepare

2018-05-25 Thread Kalle Valo
YueHaibing wrote: > clk_disable_unprepare() already checks that the clock pointer is valid. > No need to test it before calling it. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. cf3c0ae6a32b ath10k: remove useless test before c

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Petr Machata
Florian Fainelli writes: > You seem to have approached the bridge changes a little differently from > this series: > > https://lists.linux-foundation.org/pipermail/bridge/2016-November/010112.html It pretty much extends the patchset to also send the notifications for the CPU port. I missed this

[PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe

2018-05-25 Thread Yafang Shao
skb->len is meaningless to user. data length could be more helpful, with which we can easily filter out the packet without payload. Signed-off-by: Yafang Shao --- include/trace/events/tcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/tcp.h b/i

Re: [v3] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-25 Thread Kalle Valo
Ramon Fried wrote: > Introduce infrastructure for supporting Factory Test Mode (FTM) of the > wireless LAN subsystem. In order for the user space to access the > firmware in test mode the relevant netlink channel needs to be exposed > from the kernel driver. > > The above is achieved as follows:

[PATCH net-next] bpfilter: fix a build err

2018-05-25 Thread YueHaibing
gcc-7.3.0 report following err: HOSTCC net/bpfilter/main.o In file included from net/bpfilter/main.c:9:0: ./include/uapi/linux/bpf.h:12:10: fatal error: linux/bpf_common.h: No such file or directory #include remove it by adding a include path. Fixes: d2ba09c17a06 ("net: add skeleton of bpfi

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-25 Thread Ilias Apalodimas
On Fri, May 25, 2018 at 09:29:02AM +0300, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 06:33:10PM +0200, Andrew Lunn wrote: > > On Thu, May 24, 2018 at 07:02:54PM +0300, Ilias Apalodimas wrote: > > > On Thu, May 24, 2018 at 05:25:59PM +0200, Andrew Lunn wrote: > > > > O.K, back to the basic id

[PATCH net] ipv6: sr: fix memory OOB access in seg6_do_srh_encap/inline

2018-05-25 Thread Mathieu Xhonneux
seg6_do_srh_encap and seg6_do_srh_inline can possibly do an out-of-bounds access when adding the SRH to the packet. This no longer happen when expanding the skb not only by the size of the SRH (+ outer IPv6 header), but also by skb->mac_len. [ 53.793056] BUG: KASAN: use-after-free in seg6_do_srh

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-25 Thread Sergei Shtylyov
Hello! On 5/24/2018 3:02 PM, Simon Wunderlich wrote: From: Sven Eckelmann All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any non-default netns. Thus disabli

Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

2018-05-25 Thread Kalle Valo
Alexei Starovoitov writes: > On Wed, May 23, 2018 at 01:03:08PM +0200, Johannes Berg wrote: >> On Wed, 2018-03-28 at 12:05 -0700, Alexei Starovoitov wrote: >> > fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table >> > instead of all 17 arguments by value. >> > dvm/main.c and mvm/uti

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-25 Thread Sven Eckelmann
On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote: [...] > > --- a/net/batman-adv/Kconfig > > +++ b/net/batman-adv/Kconfig > > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > > bool "batman-adv debugfs entries" > > depends on BATMAN_ADV > > depends on DEBUG_FS > > - default y > > +

Re: [PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-25 Thread Vinod
On 24-05-18, 09:07, Robert Jarzmik wrote: > Add some documentation for the pxad_param structure, and describe the > contract behind the minimal required priority of a DMA channel. Acked-by: Vinod Koul -- ~Vinod

Re: [PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-25 Thread Vinod
On 24-05-18, 09:07, Robert Jarzmik wrote: > As the pxa architecture and all its related drivers do not rely anymore > on the filter function, thanks to the slave map conversion, make > pxad_filter_fn() static, and remove it from the global namespace. Acked-by: Vinod Koul -- ~Vinod

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-25 Thread Sergei Shtylyov
On 5/25/2018 1:50 PM, Sven Eckelmann wrote: [...] --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default y + default n N is the default defau

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-25 Thread Sven Eckelmann
On Freitag, 25. Mai 2018 14:13:40 CEST Sergei Shtylyov wrote: > > [...] > >>> --- a/net/batman-adv/Kconfig > >>> +++ b/net/batman-adv/Kconfig > >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > >>> bool "batman-adv debugfs entries" > >>> depends on BATMAN_ADV > >>> depends on DEBUG_FS > >>> -

Re: [PATCH] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Sergei Shtylyov
Hello! On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+)

Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

2018-05-25 Thread Edward Cree
On 24/05/18 10:14, Martin Habets wrote: > efx_enqueue_skb() can push new buffers for the xmit_more functionality. > We must stops the TX queue before this or else the TX queue does not get > restarted and we get a netdev watchdog. > > In the error handling we may now need to unwind more than 1 pack

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-25 Thread Andrew Lunn
> So it's only static FBDs left. Please describe the use case. Why would i want to put static FDB addresses on a CPU port? What in the linux network stack needs this? Andrew

Re: [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-25 Thread Nikolay Aleksandrov
On 24/05/18 18:10, Petr Machata wrote: > A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves > initializing a struct switchdev_obj_port_vlan, a piece of code that > repeats on each call site almost verbatim. While in the current codebase > there is just one duplicated add call,

Re: [PATCH v2 1/1] qed: Add firmware 8.37.2.0

2018-05-25 Thread Josh Boyer
On Mon, May 21, 2018 at 10:25 AM Rahul Verma wrote: > This patch add a new qed firmware with fixes and added > support for new features. > -Fix aRFS for tunneled traffic without inner IP. > -Fix chip configuration which may fail under heavy traffic conditions. > -Fix iSCSI recovery flow. > -Suppo

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Nikolay Aleksandrov
On 24/05/18 18:10, Petr Machata wrote: > A driver might need to react to changes in settings of brentry VLANs. > Therefore send switchdev port notifications for these as well. Reuse > SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use > netif_is_bridge_master() on orig_dev to determi

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-25 Thread Andrew Lunn
> Understood, if we missed back anything on handling multicast for > the cpu port we'll go back and fix it (i am assuming snooping is the answer > here). It is part of the answer. You should also look at .ndo_set_rx_mode. When the switch ports are not in a bridge, this call i used to pass a list o

Re: [PATCH net-next] net: dsa: dsa_loop: Make dynamic debugging helpful

2018-05-25 Thread Andrew Lunn
On Thu, May 24, 2018 at 08:52:14PM -0700, Florian Fainelli wrote: > Remove redundant debug prints from phy_read/write since we can trace those > calls through trace events. Enhance dynamic debug prints to print arguments > which helps figuring how what is going on at the driver level with higher >

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Ilias Apalodimas
On Fri, May 25, 2018 at 01:09:46PM +0300, Petr Machata wrote: > Florian Fainelli writes: > > > You seem to have approached the bridge changes a little differently from > > this series: > > > > https://lists.linux-foundation.org/pipermail/bridge/2016-November/010112.html > > It pretty much extend

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-25 Thread Niklas Cassel
On Thu, May 24, 2018 at 11:50:34AM -0400, Bob Copeland wrote: > On Mon, May 21, 2018 at 10:37:01PM +0200, Niklas Cassel wrote: > > On Thu, May 17, 2018 at 03:26:25PM -0700, Adrian Chadd wrote: > > > On Thu, 17 May 2018 at 16:16, Niklas Cassel > > > wrote: > > > > > > > diff --git a/drivers/net/wi

[PATCH] drivers/net/phy/micrel: Fix for PHY KSZ8061 errrata: Potential link-up failure when Ethernet cable is connected slowly

2018-05-25 Thread Alexander Onnasch
Signed-off-by: Alexander Onnasch --- drivers/net/phy/micrel.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 6c45ff6..7d80a00 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.

Hello,

2018-05-25 Thread Mrs. Annabelle Edo.
Hello, Good day, How you are today and your family, i hope you are in good health, my name is Mrs. Annabelle, I saw your email on Web. Media, I have something to discuss with you my late unclaimed fund, please reply me for more information, Mrs. Annabelle Ed

[PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Ard Biesheuvel
The netsec network controller IP can drive 64 address bits for DMA, and the DMA mask is set accordingly in the driver. However, the SynQuacer SoC, which is the only silicon incorporating this IP at the moment, integrates this IP in a manner that leaves address bits [63:40] unconnected. Up until no

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-25 Thread Bob Copeland
On Fri, May 25, 2018 at 02:36:56PM +0200, Niklas Cassel wrote: > A spin lock does have the advantage of ordering: memory operations issued > before the spin_unlock_bh() will be completed before the spin_unlock_bh() > operation has completed. > > However, ath10k_htt_tx_dec_pending() was called earl

[PATCH net-next] qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID

2018-05-25 Thread Bjørn Mork
SIMCOM are reusing a single device ID for many (all of their?) different modems, based on different chipsets and firmwares. Newer Qualcomm chipset generations require setting DTR to wake the QMI function. The SIM7600E modem is using such a chipset, making it fail to work with this driver despite t

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Robin Murphy
On 25/05/18 13:50, Ard Biesheuvel wrote: The netsec network controller IP can drive 64 address bits for DMA, and the DMA mask is set accordingly in the driver. However, the SynQuacer SoC, which is the only silicon incorporating this IP at the moment, integrates this IP in a manner that leaves add

Re: [PATCH] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Kalle Valo
Sergei Shtylyov writes: > On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++-

Re: [PATCH net] tun: Fix NULL pointer dereference in XDP redirect

2018-05-25 Thread Toshiaki Makita
On 18/05/25 (金) 18:59, Jason Wang wrote: On 2018年05月25日 12:32, Toshiaki Makita wrote: Calling XDP redirection requires preempt/bh disabled. Especially softirq can call another XDP function and redirection functions, then percpu value ri->map can be overwritten to NULL. This is a generic XDP cas

Re: KASAN: use-after-free Read in ccid2_hc_tx_packet_recv

2018-05-25 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:b50694381cfc Merge branch 'stable/for-linus-4.17' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17151cb780 kernel config: https://syzkaller.appspot.com/x/.config?x=982e2d

Re: [PATCH bpf-next 0/5] fix test_sockmap

2018-05-25 Thread John Fastabend
On 05/25/2018 01:28 AM, Prashant Bhole wrote: > > > On 5/24/2018 1:58 PM, John Fastabend wrote: >> On 05/23/2018 09:47 PM, Prashant Bhole wrote: >>> >>> >>> On 5/23/2018 6:44 PM, Prashant Bhole wrote: On 5/22/2018 2:08 AM, John Fastabend wrote: > On 05/20/2018 10:13 PM, Prashan

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > Hi Bjorn! > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > > Some user space depends on enabling sriov_totalvfs number of VFs > > > to not fail, e.g

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: > Hi Jose, > > On 5/24/2018 3:01 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 24-05-2018 06:58, Bhadram Varka wrote: >>> >>> After some time if check Tx descriptor status - then I see only >>> below >>> >>> [..] >>> [85788.286730] 027 [0x82795

KASAN: use-after-free Write in tls_push_record

2018-05-25 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:13405468f49d bpfilter: don't pass O_CREAT when opening con.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=109ad82f80 kernel config: https://syzkaller.appspot.com/x/.config?x=8be0182d69f8d422 da

Re: [patch iproute2/net-next 2/2] devlink: introduce support for showing port number and split subport number

2018-05-25 Thread David Ahern
On 5/24/18 12:39 AM, Jiri Pirko wrote: > Wed, May 23, 2018 at 10:05:49PM CEST, dsah...@gmail.com wrote: >> On 5/20/18 2:15 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> devlink/devlink.c| 6 ++ >>> include/uapi/linux/devlink.h | 2 ++ >>>

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-25 Thread Niklas Cassel
On Fri, May 25, 2018 at 08:50:23AM -0400, Bob Copeland wrote: > On Fri, May 25, 2018 at 02:36:56PM +0200, Niklas Cassel wrote: > > A spin lock does have the advantage of ordering: memory operations issued > > before the spin_unlock_bh() will be completed before the spin_unlock_bh() > > operation ha

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-25 Thread David Miller
From: Qing Huang Date: Wed, 23 May 2018 16:22:46 -0700 > When a system is under memory presure (high usage with fragments), > the original 256KB ICM chunk allocations will likely trigger kernel > memory management to enter slow path doing memory compact/migration > ops in order to complete high o

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Bhadram Varka
Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.

[PATCH net-next] net: sched: shrink struct Qdisc

2018-05-25 Thread Paolo Abeni
The struct Qdisc has a lot of holes, especially after commit a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback"), which as a side effect, moved the fields just after 'busylock' on a new cacheline. Since both 'padded' and 'refcnt' are not updated frequently, and there is a hole before

hello

2018-05-25 Thread las...@ono.com
we came across your e-mail contact prior a private search while in need of help Get your bank atm card, I prepare card that worth huge amount of money loaded in the card is $3,000,000m us dollars, with this card you can make maximum withdrawals of $500 us dollars daily from any atm machine in yo

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
On 25-05-2018 15:25, Bhadram Varka wrote: > Hi Jose, > > On 5/25/2018 7:35 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 25-05-2018 05:41, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > >>>

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-25 Thread Marcelo Ricardo Leitner
On Fri, May 25, 2018 at 05:45:03AM +, Fu, Qiaobin wrote: > Hi Marcelo, > > Thanks for pointing out these style issues. Below is the updated version: Hi Qiaobin, Looks good to me. Now you have to submit it like you submitted the original patch, but add the version tag to the summary. Like '[P

refactor 32-bit dma limit quirks

2018-05-25 Thread Christoph Hellwig
Hi all, x86 currently has some quirks to force lower dma masks. They are mostly useful for certain VIA systems that otherwise corrupt data, but otherwise don't make much sense given that the modern DMA APIs do the right thing automatically. This series dumps a few of these old kernel command lin

[PATCH 7/7] x86: switch the VIA 32-bit DMA quirk to use the struct device flag

2018-05-25 Thread Christoph Hellwig
Instead of globally disabling > 32bit DMA using the arch_dma_supported hook walk the PCI bus under the actually affected bridge and mark every device with the dma_32bit_limit flag. This also gets rid of the arch_dma_supported hook entirely. Signed-off-by: Christoph Hellwig --- arch/x86/include/

[PATCH 5/7] x86: remove the experimental forcesac boot option

2018-05-25 Thread Christoph Hellwig
Limiting the dma mask to avoid PCI (pre-PCIe) DAC cycles while paying the huge overhead of an IOMMU is rather pointless, and this seriously gets in the way of dma mapping work. Signed-off-by: Christoph Hellwig --- .../admin-guide/kernel-parameters.txt | 1 - Documentation/x86/x86_64/boo

[PATCH 6/7] x86: remove the explicit nodac and allowdac option

2018-05-25 Thread Christoph Hellwig
This is something drivers should decide (modulo chipset quirks like for VIA), which as far as I can tell is how things have been handled for the last 15 years. Note that we keep the usedac option for now, as it is used in the wild to override the too generic VIA quirk. Signed-off-by: Christoph He

[PATCH 3/7] ia64: remove iommu_dma_supported

2018-05-25 Thread Christoph Hellwig
The generic dma_direct_supported helper already used by intel-iommu on x86 does a better job than the ia64 reimplementation. Signed-off-by: Christoph Hellwig --- arch/ia64/kernel/pci-dma.c | 13 - drivers/iommu/intel-iommu.c | 2 -- 2 files changed, 15 deletions(-) diff --git a/ar

[PATCH 2/7] ia64: remove the dead iommu_sac_force variable

2018-05-25 Thread Christoph Hellwig
Looks like copy and paste from x86 that never actually got used. Signed-off-by: Christoph Hellwig --- arch/ia64/kernel/pci-dma.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/arch/ia64/kernel/pci-dma.c b/arch/ia64/kernel/pci-dma.c index b5df084c0af4..50b6ad282a90 100644

Re: [PATCH] net: stmmac: Use mutex instead of spinlock

2018-05-25 Thread Bhadram Varka
Hi, On 5/24/2018 7:39 PM, Thierry Reding wrote: From: Thierry Reding Some drivers, such as DWC EQOS on Tegra, need to perform operations that can sleep under this lock (clk_set_rate() in tegra_eqos_fix_speed()) for proper operation. Since there is no need for this lock to be a spinlock, conver

[PATCH 4/7] x86: remove a stray reference to pci-nommu.c

2018-05-25 Thread Christoph Hellwig
This is just the minimal workaround. The file file is mostly either stale and/or duplicative of Documentation/admin-guide/kernel-parameters.txt, but that is much more work than I'm willing to do right now. Signed-off-by: Christoph Hellwig --- Documentation/x86/x86_64/boot-options.txt | 4 ++--

[PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

2018-05-25 Thread Christoph Hellwig
Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits even if the device itself supports more. Add a single bit flag to struct device (to be moved into the dma extension once we around it) to flag such devices and reject larger DMA to them. Signed-off-by: Christoph Hellwig --- in

Re: [PATCH net-next] net: sched: shrink struct Qdisc

2018-05-25 Thread Jiri Pirko
Fri, May 25, 2018 at 04:28:44PM CEST, pab...@redhat.com wrote: >The struct Qdisc has a lot of holes, especially after commit >a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback"), >which as a side effect, moved the fields just after 'busylock' >on a new cacheline. > >Since both 'padded

Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

2018-05-25 Thread Greg Kroah-Hartman
On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote: > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits > even if the device itself supports more. Add a single bit flag to > struct device (to be moved into the dma extension once we around it) "once we around it"?

Re: [PATCH] drivers/net/phy/micrel: Fix for PHY KSZ8061 errrata: Potential link-up failure when Ethernet cable is connected slowly

2018-05-25 Thread Florian Fainelli
On 05/25/2018 05:37 AM, Alexander Onnasch wrote: > Signed-off-by: Alexander Onnasch You would want to make the commit subject shorter (ideally capped somewhere around 72 characters) and provide a commit message which explains the issue and why the workaround is effective. Thank you! [snip] >

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-25 Thread Stephen Hemminger
On Fri, 18 May 2018 17:40:05 -0600 David Ahern wrote: > On 5/18/18 4:08 PM, Stephen Hemminger wrote: > > > > What about just pushing the lookup down to the leaf functions that need it? > > > > That should work as well. You want to re-send a formal patch? > I just pushed it up as a formal p

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-25 Thread Alban Crequy
On Wed, May 23, 2018 at 4:34 AM Y Song wrote: > I did a quick prototyping and the above interface seems working fine. Thanks! I gave your kernel patch & userspace program a try and it works for me on cgroup-v2. Also, I found out how to get my containers to use both cgroup-v1 and cgroup-v2 (by e

[PATCH v2 net-next] net: stmmac: Add PPS and Flexible PPS support

2018-05-25 Thread Jose Abreu
This adds support for PPS output and Flexible PPS (which is equivalent to per_out output of PTP subsystem). Tested using an oscilloscope and the following commands: 1) Start PTP4L: # ptp4l -A -4 -H -m -i eth0 & 2) Set Flexible PPS frequency: # echo > /sys/class/ptp/ptpX/perio

Fw: [Bug 199823] New: HTB not honoring Queue priority when being overdriven with large limits

2018-05-25 Thread Stephen Hemminger
Looks like a TSO issue? Begin forwarded message: Date: Thu, 24 May 2018 16:40:26 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199823] New: HTB not honoring Queue priority when being overdriven with large limits https://bugzilla.kernel.org/show_bu

[PATCH v4 bpf-next 1/6] bpf: Define cgroup_bpf_enabled for CONFIG_CGROUP_BPF=n

2018-05-25 Thread Andrey Ignatov
Static key is used to enable/disable cgroup-bpf related code paths at run time. Though it's not defined when cgroup-bpf is disabled at compile time, i.e. CONFIG_CGROUP_BPF=n, and if some code wants to use it, it has to do this: #ifdef CONFIG_CGROUP_BPF if (cgroup_bpf_enabl

[PATCH v4 bpf-next 4/6] libbpf: Support guessing sendmsg{4,6} progs

2018-05-25 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/sendmsg4" and "cgroup/sendmsg6" section names. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 2 ++ 1 file changed, 2 insertions(

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-25 Thread Sergei Shtylyov
On 05/25/2018 02:15 PM, Sven Eckelmann wrote: >>> [...] > --- a/net/batman-adv/Kconfig > +++ b/net/batman-adv/Kconfig > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > bool "batman-adv debugfs entries" > depends on BATMAN_ADV > depends on DEBUG_FS > - default y >>

[PATCH v4 bpf-next 6/6] selftests/bpf: Selftest for sys_sendmsg hooks

2018-05-25 Thread Andrey Ignatov
Add selftest for BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types. Try to sendmsg(2) to specific IP:port and test that: * source IP is overridden as expected. * remote IP:port pair is overridden as expected; Both UDPv4 and UDPv6 are tested. Output: # test_sock_addr.sh 2>/dev/nu

[PATCH v4 bpf-next 0/6] bpf: Hooks for sys_sendmsg

2018-05-25 Thread Andrey Ignatov
v3 -> v4: * handle static key correctly for CONFIG_CGROUP_BPF=n. v2 -> v3: * place BPF logic under static key in udp_sendmsg, udpv6_sendmsg; * rebase. v1 -> v2: * return ENOTSUPP if bpf_prog rewrote IPv6-only with IPv4-mapped IPv6; * add test for IPv4-mapped IPv6 use-case; * fix build for CONFIG_

[PATCH v4 bpf-next 3/6] bpf: Sync bpf.h to tools/

2018-05-25 Thread Andrey Ignatov
Sync new `BPF_CGROUP_UDP4_SENDMSG` and `BPF_CGROUP_UDP6_SENDMSG` attach types to tools/. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 8 1 file changed, 8 insertions(+) diff --git a/tools/include/uapi/linux

[PATCH v4 bpf-next 5/6] selftests/bpf: Prepare test_sock_addr for extension

2018-05-25 Thread Andrey Ignatov
test_sock_addr was not easy to extend since it was focused on sys_bind and sys_connect quite a bit. Reorganized it so that it'll be easier to cover new test-cases for `BPF_PROG_TYPE_CGROUP_SOCK_ADDR`: - decouple test-cases so that only one BPF prog is tested at a time; - check programmatically t

[PATCH v4 bpf-next 2/6] bpf: Hooks for sys_sendmsg

2018-05-25 Thread Andrey Ignatov
In addition to already existing BPF hooks for sys_bind and sys_connect, the patch provides new hooks for sys_sendmsg. It leverages existing BPF program type `BPF_PROG_TYPE_CGROUP_SOCK_ADDR` that provides access to socket itlself (properties like family, type, protocol) and user-passed `struct sock

Re: [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-25 Thread Vivien Didelot
Hi Petr, Petr Machata writes: > -static int __vlan_vid_add(struct net_device *dev, struct net_bridge *br, > - u16 vid, u16 flags) > +static int br_switchdev_port_obj_add(struct net_device *dev, u16 vid, u16 > flags) > { > struct switchdev_obj_port_vlan v = { >

Re: [PATCH net-next 4/7] dsa: port: Ignore bridge VLAN events

2018-05-25 Thread Vivien Didelot
Hi Petr, Petr Machata writes: > Ignore VLAN events where the orig_dev is the bridge device itself. > > Signed-off-by: Petr Machata Reviewed-by: Vivien Didelot Thanks, Vivien

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Y Song
On Fri, May 25, 2018 at 4:20 AM, Mathieu Xhonneux wrote: > Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks > some UAPI headers in tools/. > > clang -I. -I./include/uapi -I../../../include/uapi -idirafter > /usr/local/include -idirafter > /data/users/yhs/work/llvm/build/inst

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Vivien Didelot
Hi Petr, Petr Machata writes: > A driver might need to react to changes in settings of brentry VLANs. > Therefore send switchdev port notifications for these as well. Reuse > SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use > netif_is_bridge_master() on orig_dev to determine whe

Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

2018-05-25 Thread Christoph Hellwig
On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote: > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits > > even if the device itself supports more. Add a single bit flag to > > struct device

Re: [PATCH net-next] bpfilter: fix a build err

2018-05-25 Thread Alexei Starovoitov
On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote: > gcc-7.3.0 report following err: > > HOSTCC net/bpfilter/main.o > In file included from net/bpfilter/main.c:9:0: > ./include/uapi/linux/bpf.h:12:10: fatal error: linux/bpf_common.h: No such > file or directory > #include > > remov

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Song Liu
On Fri, May 25, 2018 at 4:20 AM, Mathieu Xhonneux wrote: > Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks > some UAPI headers in tools/. > > clang -I. -I./include/uapi -I../../../include/uapi -idirafter > /usr/local/include -idirafter > /data/users/yhs/work/llvm/build/inst

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Y Song
On Fri, May 25, 2018 at 9:16 AM, Y Song wrote: > On Fri, May 25, 2018 at 4:20 AM, Mathieu Xhonneux > wrote: >> Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks >> some UAPI headers in tools/. >> >> clang -I. -I./include/uapi -I../../../include/uapi -idirafter >> /usr/local

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Alexei Starovoitov
On Fri, May 25, 2018 at 12:20:36PM +0100, Mathieu Xhonneux wrote: > Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks > some UAPI headers in tools/. > > clang -I. -I./include/uapi -I../../../include/uapi -idirafter > /usr/local/include -idirafter > /data/users/yhs/work/llvm/b

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-25 Thread Y Song
On Fri, May 25, 2018 at 8:21 AM, Alban Crequy wrote: > On Wed, May 23, 2018 at 4:34 AM Y Song wrote: > >> I did a quick prototyping and the above interface seems working fine. > > Thanks! I gave your kernel patch & userspace program a try and it works for > me on cgroup-v2. > > Also, I found out

Re: [PATCH v4 bpf-next 1/6] bpf: Define cgroup_bpf_enabled for CONFIG_CGROUP_BPF=n

2018-05-25 Thread Alexei Starovoitov
On Fri, May 25, 2018 at 08:55:22AM -0700, Andrey Ignatov wrote: > Static key is used to enable/disable cgroup-bpf related code paths at > run time. > > Though it's not defined when cgroup-bpf is disabled at compile time, > i.e. CONFIG_CGROUP_BPF=n, and if some code wants to use it, it has to do >

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Andrew, Vivien, if the following hunks get applied are we possibly > breaking mv88e6xxx? This is the use case that is really missing IMHO at > the moment in DSA: we cannot control the VLAN membership and attributes > of the CPU port(s), so either we make it

Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

2018-05-25 Thread Greg Kroah-Hartman
On Fri, May 25, 2018 at 06:23:07PM +0200, Christoph Hellwig wrote: > On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote: > > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits > > > even if th

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-25 Thread Daniel Borkmann
On 05/25/2018 06:23 PM, Alexei Starovoitov wrote: > On Fri, May 25, 2018 at 12:20:36PM +0100, Mathieu Xhonneux wrote: >> Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks >> some UAPI headers in tools/. >> >> clang -I. -I./include/uapi -I../../../include/uapi -idirafter >> /us

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-25 Thread Eugene Syromiatnikov
On Thu, May 24, 2018 at 04:34:51PM -0700, Alexei Starovoitov wrote: > On Thu, May 24, 2018 at 09:41:08AM +0200, Jesper Dangaard Brouer wrote: > > On Wed, 23 May 2018 15:02:45 -0700 > > Alexei Starovoitov wrote: > > > > > On Wed, May 23, 2018 at 02:18:19PM +0200, Eugene Syromiatnikov wrote: > > >

Re: [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-25 Thread Petr Machata
Vivien Didelot writes: > Hi Petr, > > Petr Machata writes: > >> -static int __vlan_vid_add(struct net_device *dev, struct net_bridge *br, >> - u16 vid, u16 flags) >> +static int br_switchdev_port_obj_add(struct net_device *dev, u16 vid, u16 >> flags) >> { >> struct sw

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

2018-05-25 Thread Petr Machata
Vivien Didelot writes: >> +} else { >> +err = br_switchdev_port_obj_add(dev, v->vid, flags); >> +if (err && err != -EOPNOTSUPP) >> +goto out; >> } > > Except that br_switchdev_port_obj_add taking vid and flags arguments > seems confusing to me,

  1   2   3   >