Re: [PATCH bpf-next] bpf, doc: Update bpf_jit_enable limitation for CONFIG_BPF_JIT_ALWAYS_ON

2018-04-27 Thread Leo Yan
On Fri, Apr 27, 2018 at 11:44:44AM +0200, Daniel Borkmann wrote: > On 04/26/2018 04:26 AM, Leo Yan wrote: > > When CONFIG_BPF_JIT_ALWAYS_ON is enabled, kernel has limitation for > > bpf_jit_enable, so it has fixed value 1 and we cannot set it to 2 > > for JIT opcode dumping; this patch is to update

[PATCH v1 net-next] microchip_t1: Add driver for Microchip LAN87XX T1 PHYs

2018-04-27 Thread Nisar Sayed
Add driver for Microchip LAN87XX T1 PHYs This patch support driver for Microchp T1 PHYs. There will be followup patches to this driver to support T1 PHY features such as cable diagnostics, signal quality indicator(SQI), sleep and wakeup (TC10) support. Signed-off-by: Nisar Sayed --- v0 - v1:

Re: [PATCH 3/3] selftests/bpf: .gitignore: add test_btf

2018-04-27 Thread Daniel Borkmann
Hi Sirio, thanks for your patch! On 04/26/2018 10:31 AM, Sirio Balmelli wrote: > Signed-off-by: Sirio Balmelli > --- > tools/testing/selftests/bpf/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/.gitignore > b/tools/testing/selftests/bpf/.gitign

Re: [PATCH 2/3] selftests/bpf: test_xdp_noinline.c: fix 'noinline' macro expansion

2018-04-27 Thread Daniel Borkmann
On 04/26/2018 10:31 AM, Sirio Balmelli wrote: > Compiling with clang 7.0.0 yields: > test_xdp_noinline.c:470:24: warning: unknown attribute '__attribute__' > ignored [-Wunknown-attributes] > ../../../include/linux/compiler-gcc.h:24:19: note: expanded from macro > 'noinline' >

Re: [PATCH bpf-next] bpf, doc: Update bpf_jit_enable limitation for CONFIG_BPF_JIT_ALWAYS_ON

2018-04-27 Thread Daniel Borkmann
On 04/27/2018 11:49 AM, Leo Yan wrote: > On Fri, Apr 27, 2018 at 11:44:44AM +0200, Daniel Borkmann wrote: >> On 04/26/2018 04:26 AM, Leo Yan wrote: >>> When CONFIG_BPF_JIT_ALWAYS_ON is enabled, kernel has limitation for >>> bpf_jit_enable, so it has fixed value 1 and we cannot set it to 2 >>> for J

[PATCH bpf-next v2] bpf, doc: Update bpf_jit_enable limitation for CONFIG_BPF_JIT_ALWAYS_ON

2018-04-27 Thread Leo Yan
When CONFIG_BPF_JIT_ALWAYS_ON is enabled, kernel has limitation for bpf_jit_enable, so it has fixed value 1 and we cannot set it to 2 for JIT opcode dumping; this patch is to update the doc for it. Suggested-by: Daniel Borkmann Signed-off-by: Leo Yan --- Documentation/networking/filter.txt | 6

Re: [PATCH net-next 00/13] sctp: refactor MTU handling

2018-04-27 Thread Xin Long
On Fri, Apr 27, 2018 at 3:58 AM, Marcelo Ricardo Leitner wrote: > Currently MTU handling is spread over SCTP stack. There are multiple > places doing same/similar calculations and updating them is error prone > as one spot can easily be left out. > > This patchset converges it into a more concise

Re: [PATCH 1/3] selftests/bpf: Makefile: add includes to fix broken test build

2018-04-27 Thread Daniel Borkmann
On 04/26/2018 10:31 AM, Sirio Balmelli wrote: > several bpf tests fail to build with clang 7.0.0: > ... > In file included from ../../../include/uapi/linux/bpf.h:11: > In file included from ./include/uapi/linux/types.h:5: > /usr/include/asm-generic/int-ll64.h:11:10: fatal error: 'asm/bitsperlong.h'

Re: [PATCH bpf-next v2] bpf, doc: Update bpf_jit_enable limitation for CONFIG_BPF_JIT_ALWAYS_ON

2018-04-27 Thread Daniel Borkmann
On 04/27/2018 12:02 PM, Leo Yan wrote: > When CONFIG_BPF_JIT_ALWAYS_ON is enabled, kernel has limitation for > bpf_jit_enable, so it has fixed value 1 and we cannot set it to 2 > for JIT opcode dumping; this patch is to update the doc for it. > > Suggested-by: Daniel Borkmann > Signed-off-by: Leo

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-27 Thread Mikulas Patocka
On Fri, 27 Apr 2018, Michal Hocko wrote: > On Thu 26-04-18 18:52:05, Mikulas Patocka wrote: > > > > > > On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: > [...] > > >But assuming it's important to control this kind of > > >fault injection to be controlled from > > >a dedicated menuco

[PATCH net-next 0/2] netns: uevent filtering

2018-04-27 Thread Christian Brauner
Hey everyone, This is the new approach to uevent filtering as discussed (see the threads in [1], [2], and [3]). This series deals with with fixing up uevent filtering logic: - uevent filtering logic is simplified - locking time on uevent_sock_list is minimized - tagged and untagged kobjects are h

[PATCH net-next 2/2 v3] netns: restrict uevents

2018-04-27 Thread Christian Brauner
commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces") enabled sending hotplug events into all network namespaces back in 2010. Over time the set of uevents that get sent into all network namespaces has shrunk. We have now reached the point where hotplug events for all devi

[PATCH net-next 1/2 v3] uevent: add alloc_uevent_skb() helper

2018-04-27 Thread Christian Brauner
This patch adds alloc_uevent_skb() in preparation for follow up patches. Signed-off-by: Christian Brauner --- lib/kobject_uevent.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 15ea2

[net-next] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread Ahmed Abdelsalam
This patch adds a documentation for seg_flowlabel sysctl into Documentation/networking/ip-sysctl.txt Signed-off-by: Ahmed Abdelsalam --- Documentation/networking/ip-sysctl.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentati

Re: [PATCH net-next 03/13] sctp: remove an if() that is always true

2018-04-27 Thread Neil Horman
On Thu, Apr 26, 2018 at 04:58:52PM -0300, Marcelo Ricardo Leitner wrote: > As noticed by Xin Long, the if() here is always true as PMTU can never > be 0. > > Reported-by: Xin Long > Signed-off-by: Marcelo Ricardo Leitner > --- > net/sctp/associola.c | 6 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread kbuild test robot
Hi Toke, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20180427-175308 config: i386-allmodconfig (attached as .config

Re: ip6-in-ip{4,6} ipsec tunnel issues with 1280 MTU

2018-04-27 Thread Ashwanth Goli
On 2018-04-26 17:21, Paolo Abeni wrote: Hi, [fixed CC list] On Wed, 2018-04-25 at 21:43 +0530, Ashwanth Goli wrote: Hi Pablo, Actually I'm Paolo, but yours is a recurring mistake ;) I am noticing an issue similar to the one reported by Alexis Perez [Regression for ip6-in-ip4 IPsec tunnel i

RE: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-27 Thread Ramesh Shanmugasundaram
Hello Sergei, Thanks for your patch. > Subject: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings > > Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD > bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Ramesh Shanmugasundaram Thanks, Ramesh

Re: ath6kl: fix ath6kl_data_tx()'s return type

2018-04-27 Thread Kalle Valo
Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck >

Re: [next] ath10k: fix spelling mistake: "servive" -> "service"

2018-04-27 Thread Kalle Valo
Colin Ian King wrote: > Trivial fix to spelling mistake in ath10k_warn warning message text > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 785281342d0c ath10k: fix spelling mistake: "servive" -> "service" -- https://patchw

Re: ath10k: sdio: jump to correct label in error handling path

2018-04-27 Thread Kalle Valo
Niklas Cassel wrote: > Jump to the correct label in error handling path. > At this point of execution create_singlethread_workqueue() has succeeded, > so it should be properly destroyed. > > Jump label was renamed in commit ec2c64e20257 ("ath10k: sdio: fix memory > leak for probe allocations").

ID of (former "National") TI's PHY DP83848

2018-04-27 Thread Juergen Borleis
Hi, I have worked on a DP83848 variant without an interrupt line. While at it, I read through all datasheets of existing variants of the DP83848 phy. Here is what I've found so far: +--+--++-+ | Variant |Phy ID| Note | IRQ | +--+---

Re: [tip:x86/cleanups] x86/bpf: Clean up non-standard comments, to make the code more readable

2018-04-27 Thread Daniel Borkmann
Hi Ingo, On 04/27/2018 01:00 PM, tip-bot for Ingo Molnar wrote: > Commit-ID: 5f26c50143f58f256535bee8d93a105f36d4d2da > Gitweb: > https://git.kernel.org/tip/5f26c50143f58f256535bee8d93a105f36d4d2da > Author: Ingo Molnar > AuthorDate: Fri, 27 Apr 2018 11:54:40 +0200 > Committer: Ingo Mo

Re: WARNING in tcp_enter_loss (2)

2018-04-27 Thread syzbot
syzbot has found reproducer for the following crash on upstream commit 0644f186fc9d77bb5bd198369e59fb28927a3692 (Thu Apr 26 23:36:11 2018 +) Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=c5a30

[PATCH bpf-next v2 00/15] Introducing AF_XDP support

2018-04-27 Thread Björn Töpel
From: Björn Töpel This patch set introduces a new address family called AF_XDP that is optimized for high performance packet processing and, in upcoming patch sets, zero-copy semantics. In this v2 version, we have removed all zero-copy related code in order to make it smaller, simpler and hopeful

[PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

[PATCH bpf-next v2 02/15] xsk: add user memory registration support sockopt

2018-04-27 Thread Björn Töpel
From: Björn Töpel In this commit the base structure of the AF_XDP address family is set up. Further, we introduce the abilty register a window of user memory to the kernel via the XDP_UMEM_REG setsockopt syscall. The memory window is viewed by an AF_XDP socket as a set of equally large frames. Af

[PATCH iproute2-next v5] Add support for cake qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH bpf-next v2 05/15] xsk: add support for bind for Rx

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson Here, the bind syscall is added. Binding an AF_XDP socket, means associating the socket to an umem, a netdev and a queue index. This can be done in two ways. The first way, creating a "socket from scratch". Create the umem using the XDP_UMEM_REG setsockopt and an associated

[PATCH bpf-next v2 04/15] xsk: add Rx queue setup and mmap support

2018-04-27 Thread Björn Töpel
From: Björn Töpel Another setsockopt (XDP_RX_QUEUE) is added to let the process allocate a queue, where the kernel can pass completed Rx frames from the kernel to user process. The mmapping of the queue is done using the XDP_PGOFF_RX_QUEUE offset. Signed-off-by: Björn Töpel --- include/net/xd

[PATCH bpf-next v2 08/15] xsk: wire up XDP_DRV side of AF_XDP

2018-04-27 Thread Björn Töpel
From: Björn Töpel This commit wires up the xskmap to XDP_DRV layer. Signed-off-by: Björn Töpel --- net/core/filter.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index d3781daa26ab..1f2726318725 100644 --- a/

[PATCH bpf-next v2 12/15] dev: packet: make packet_direct_xmit a common function

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson The new dev_direct_xmit will be used by AF_XDP in later commits. Signed-off-by: Magnus Karlsson --- include/linux/netdevice.h | 1 + net/core/dev.c| 38 ++ net/packet/af_packet.c| 42 +---

[PATCH bpf-next v2 15/15] samples/bpf: sample application and documentation for AF_XDP sockets

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson This is a sample application for AF_XDP sockets. The application supports three different modes of operation: rxdrop, txonly and l2fwd. To show-case a simple round-robin load-balancing between a set of sockets in an xskmap, set the RR_LB compile time define option to 1 in "

[PATCH bpf-next v2 13/15] xsk: support for Tx

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson Here, Tx support is added. The user fills the Tx queue with frames to be sent by the kernel, and let's the kernel know using the sendmsg syscall. Signed-off-by: Magnus Karlsson --- net/xdp/xsk.c | 111 ++-- net/xdp/xsk

[PATCH bpf-next v2 14/15] xsk: statistics support

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson In this commit, a new getsockopt is added: XDP_STATISTICS. This is used to obtain stats from the sockets. v2: getsockopt now returns size of stats structure. Signed-off-by: Magnus Karlsson --- include/uapi/linux/if_xdp.h | 7 +++ net/xdp/xsk.c | 45 +++

[PATCH bpf-next v2 09/15] xsk: wire up XDP_SKB side of AF_XDP

2018-04-27 Thread Björn Töpel
From: Björn Töpel This commit wires up the xskmap to XDP_SKB layer. Signed-off-by: Björn Töpel --- include/linux/filter.h | 2 +- net/core/dev.c | 35 +++ net/core/filter.c | 17 ++--- 3 files changed, 34 insertions(+), 20 deletions(-)

[PATCH bpf-next v2 10/15] xsk: add umem completion queue support and mmap

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson Here, we add another setsockopt for registered user memory (umem) called XDP_UMEM_COMPLETION_QUEUE. Using this socket option, the process can ask the kernel to allocate a queue (ring buffer) and also mmap it (XDP_UMEM_PGOFF_COMPLETION_QUEUE) into the process. The queue is u

[PATCH bpf-next v2 11/15] xsk: add Tx queue setup and mmap support

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson Another setsockopt (XDP_TX_QUEUE) is added to let the process allocate a queue, where the user process can pass frames to be transmitted by the kernel. The mmapping of the queue is done using the XDP_PGOFF_TX_QUEUE offset. Signed-off-by: Magnus Karlsson --- include/net/x

[PATCH bpf-next v2 06/15] xsk: add Rx receive functions and poll support

2018-04-27 Thread Björn Töpel
From: Björn Töpel Here the actual receive functions of AF_XDP are implemented, that in a later commit, will be called from the XDP layers. There's one set of functions for the XDP_DRV side and another for XDP_SKB (generic). A new XDP API, xdp_return_buff, is also introduced. Adding xdp_return_

[PATCH bpf-next v2 07/15] bpf: introduce new bpf AF_XDP map type BPF_MAP_TYPE_XSKMAP

2018-04-27 Thread Björn Töpel
From: Björn Töpel The xskmap is yet another BPF map, very much inspired by dev/cpu/sockmap, and is a holder of AF_XDP sockets. A user application adds AF_XDP sockets into the map, and by using the bpf_redirect_map helper, an XDP program can redirect XDP frames to an AF_XDP socket. Note that a so

[PATCH bpf-next v2 03/15] xsk: add umem fill queue support and mmap

2018-04-27 Thread Björn Töpel
From: Magnus Karlsson Here, we add another setsockopt for registered user memory (umem) called XDP_UMEM_FILL_QUEUE. Using this socket option, the process can ask the kernel to allocate a queue (ring buffer) and also mmap it (XDP_UMEM_PGOFF_FILL_QUEUE) into the process. The queue is used to expli

[PATCH bpf-next v2 01/15] net: initial AF_XDP skeleton

2018-04-27 Thread Björn Töpel
From: Björn Töpel Buildable skeleton of AF_XDP without any functionality. Just what it takes to register a new address family. Signed-off-by: Björn Töpel --- MAINTAINERS | 8 include/linux/socket.h | 5 - net/Kconfig |

Re: [PATCH bpf-next v2 00/15] Introducing AF_XDP support

2018-04-27 Thread Björn Töpel
2018-04-27 14:17 GMT+02:00 Björn Töpel : > From: Björn Töpel > > This patch set introduces a new address family called AF_XDP that is > optimized for high performance packet processing and, in upcoming > patch sets, zero-copy semantics. In this v2 version, we have removed > all zero-copy related c

Re: [PATCH net] pppoe: check sockaddr length in pppoe_connect()

2018-04-27 Thread Kevin Easton
On Mon, Apr 23, 2018 at 04:38:27PM +0200, Guillaume Nault wrote: > We must validate sockaddr_len, otherwise userspace can pass fewer data > than we expect and we end up accessing invalid data. > > Fixes: 224cf5ad14c0 ("ppp: Move the PPP drivers") > Reported-by: syzbot+4f03bdf92fdf9ef5d...@syzkalle

Re: [PATCH net-next v8 2/4] net: Introduce generic failover module

2018-04-27 Thread kbuild test robot
Hi Sridhar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180427-183842 reproduce: # apt-get install

Hello from Lisa

2018-04-27 Thread Lisa Johnson
Hello dear, I am Miss Lisa. I have very important thing to discuss with you please, this information is very vital. Contact me with my private email so we can talk (lisajohnsonsalima...@hotmail.com ) Lisa.

[PATCHv2 net] bridge: check iface upper dev when setting master via ioctl

2018-04-27 Thread Hangbin Liu
When we set a bond slave's master to bridge via ioctl, we only check the IFF_BRIDGE_PORT flag. Although we will find the slave's real master at netdev_master_upper_dev_link() later, it already does some settings and allocates some resources. It would be better to return as early as possible. v1 ->

Re: [PATCH v2 net-next 1/2] tcp: add TCP_ZEROCOPY_RECEIVE support for zerocopy receive

2018-04-27 Thread Eric Dumazet
On Fri, Apr 27, 2018 at 1:45 AM kbuild test robot wrote: > Hi Eric, > Thank you for the patch! Yet something to improve: > [auto build test ERROR on net-next/master] > url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-add-TCP_ZEROCOPY_RECEIVE-support-for-zerocopy-rece

Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Eric Dumazet
On 04/27/2018 05:17 AM, Toke Høiland-Jørgensen wrote: ... > + > +static struct sk_buff *cake_ack_filter(struct cake_sched_data *q, > +struct cake_flow *flow) > +{ > + int seglen; > + struct sk_buff *skb = flow->tail, *skb_check, *skb_check_prev; > +

Re: [PATCH] ptp_pch: use helpers function for converting between ns and timespec

2018-04-27 Thread Richard Cochran
On Fri, Apr 27, 2018 at 03:36:18PM +0800, YueHaibing wrote: > use ns_to_timespec64() and timespec64_to_ns() instead of open coding Acked-by: Richard Cochran

Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 04/27/2018 05:17 AM, Toke Høiland-Jørgensen wrote: > > ... > >> + >> +static struct sk_buff *cake_ack_filter(struct cake_sched_data *q, >> + struct cake_flow *flow) >> +{ >> +int seglen; >> +struct sk_buff *skb = flow->tail, *skb

Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Eric Dumazet
On 04/27/2018 06:38 AM, Toke Høiland-Jørgensen wrote: > > Ah, right. Will fix. > > Is it safe to dereference the iph pointer before calling > pskb_may_pull()? No, please take a look at ip_rcv() for a typical use case.

Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support

2018-04-27 Thread Alexandre Belloni
On 26/04/2018 23:09:15+0200, Andrew Lunn wrote: > > +/* Checks if the net_device instance given to us originate from our > > driver. */ > > +static bool ocelot_netdevice_dev_check(const struct net_device *dev) > > +{ > > + return dev->netdev_ops == &ocelot_port_netdev_ops; > > +} > > This is pr

Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 04/27/2018 06:38 AM, Toke Høiland-Jørgensen wrote: >> >> Ah, right. Will fix. >> >> Is it safe to dereference the iph pointer before calling >> pskb_may_pull()? > > No, please take a look at ip_rcv() for a typical use case. Will do, thanks. -Toke

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-27 Thread Greg KH
On Fri, Apr 27, 2018 at 02:20:07PM +0200, Thomas Deutschmann wrote: > On 2018-04-22 23:50, Thomas Deutschmann wrote: > > Hi, > > > > please add > > > >> From f15ca723c1ebe6c1a06bc95fda6b62cd87b44559 Mon Sep 17 00:00:00 2001 > >> From: Nicolas Dichtel > >> Date: Thu, 25 Jan 2018 19:03:03 +0100 >

tc: Using u32 filter

2018-04-27 Thread Jose Abreu
Hi, I'm trying to use u32 filter to filter specific fields of packets by HW *only* but I'm having a hard time in trying to run tc to configure it. I implemented a dummy .ndo_setup_tc callback which always returns success and I set NETIF_F_HW_TC field in hw_features. Then I run tc, like this:

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-27 Thread David Miller
From: Greg KH Date: Fri, 27 Apr 2018 15:51:25 +0200 > On Fri, Apr 27, 2018 at 02:20:07PM +0200, Thomas Deutschmann wrote: >> On 2018-04-22 23:50, Thomas Deutschmann wrote: >> > Hi, >> > >> > please add >> > >> >> From f15ca723c1ebe6c1a06bc95fda6b62cd87b44559 Mon Sep 17 00:00:00 2001 >> >> From:

[PATCH net 2/2] sfc: fix ARFS expiry check on EF10

2018-04-27 Thread Edward Cree
Owing to a missing conditional, the result of rps_may_expire_flow() was being ignored and filters were being removed even if we'd decided not to expire them. Fixes: f8d6203780b7 ("sfc: ARFS filter IDs") Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 5 +++-- 1 file changed, 3

[PATCH net 1/2] sfc: Use filter index rather than ID for rps_flow_id table

2018-04-27 Thread Edward Cree
efx->type->filter_insert() returns an ID rather than the index that efx->type->filter_async_insert() used to, which causes it to exceed efx->type->max_rx_ip_filters on some EF10 configurations, leading to out- of-bounds array writes. So, in efx_filter_rfs_work(), convert this back into an index

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-27 Thread Greg KH
On Fri, Apr 27, 2018 at 03:51:25PM +0200, Greg KH wrote: > On Fri, Apr 27, 2018 at 02:20:07PM +0200, Thomas Deutschmann wrote: > > On 2018-04-22 23:50, Thomas Deutschmann wrote: > > > Hi, > > > > > > please add > > > > > >> From f15ca723c1ebe6c1a06bc95fda6b62cd87b44559 Mon Sep 17 00:00:00 2001 >

Re: ip6-in-ip{4,6} ipsec tunnel issues with 1280 MTU

2018-04-27 Thread David Ahern
On 4/27/18 5:02 AM, Ashwanth Goli wrote: > On 2018-04-26 17:21, Paolo Abeni wrote: >> Hi, >> >> [fixed CC list] >> >> On Wed, 2018-04-25 at 21:43 +0530, Ashwanth Goli wrote: >>> Hi Pablo, >> >> Actually I'm Paolo, but yours is a recurring mistake ;) >> >>> I am noticing an issue similar to the one

[PATCH net 0/2] sfc: more ARFS fixes

2018-04-27 Thread Edward Cree
A couple more bits of breakage in my recent ARFS and async filters work. Patch #1 in particular fixes a bug that leads to memory trampling and consequent crashes. Edward Cree (2): sfc: Use filter index rather than ID for rps_flow_id table sfc: fix ARFS expiry check on EF10 drivers/net/ether

Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space

2018-04-27 Thread David Miller
From: Bjorn Andersson Date: Mon, 23 Apr 2018 14:46:53 -0700 > + count = min_t(size_t, iov_iter_count(to), skb->len); > + if (copy_to_iter(skb->data, count, to) != count) > + count = -EFAULT; > + > + kfree_skb(skb); As noted by Chris, you should be using consume_skb() here

Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

2018-04-27 Thread David Miller
From: Mathieu Xhonneux Date: Tue, 24 Apr 2018 18:44:15 +0100 > This patch adds the End.BPF action to the LWT seg6local infrastructure. > This action works like any other seg6local End action, meaning that an IPv6 > header with SRH is needed, whose DA has to be equal to the SID of the > action. It

Re: [PATCH v1 net-next] lan78xx: Lan7801 Support for Fixed PHY

2018-04-27 Thread David Miller
From: Raghuram Chary J Date: Wed, 25 Apr 2018 12:13:06 +0530 > Adding Fixed PHY support to the lan78xx driver. > > Signed-off-by: Raghuram Chary J > --- > v0->v1: >* Remove driver version #define >* Modify netdev_info to netdev_dbg >* Move lan7801 specific to new routine and add swi

[PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
We know "err" is zero so we can remove these and pull the code in one indent level. Signed-off-by: Dan Carpenter --- This applies to the BPF tree (linux-next) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index e631b6fd60d3..7cb0905f37c2 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@

Re: [PATCH net-next] l2tp: centralise parsing of sockaddr_pppol2tp*

2018-04-27 Thread David Miller
From: Guillaume Nault Date: Wed, 25 Apr 2018 17:50:31 +0200 > @DaveM, I have some know bugs in pppol2tp_connect() that I'm going to > work on soon. That's probably going to create some conflicts between > net and net-next. They should be easy to resolve, but if you prefer, I > can resend this pat

Re: tc: Using u32 filter

2018-04-27 Thread Jiri Pirko
Fri, Apr 27, 2018 at 04:15:46PM CEST, jose.ab...@synopsys.com wrote: >Hi, > >I'm trying to use u32 filter to filter specific fields of packets >by HW *only* but I'm having a hard time in trying to run tc to >configure it. >I implemented a dummy .ndo_setup_tc callback which always returns >success a

Re: [net 1/1] tipc: fix bug in function tipc_nl_node_dump_monitor

2018-04-27 Thread David Miller
From: Jon Maloy Date: Wed, 25 Apr 2018 18:29:25 +0200 > Commit 36a50a989ee8 ("tipc: fix infinite loop when dumping link monitor > summary") intended to fix a problem with user tool looping when max > number of bearers are enabled. > > Unfortunately, the wrong version of the commit was posted, so

[PATCH 1/2] bpf: btf: silence uninitialize variable warnings

2018-04-27 Thread Dan Carpenter
Smatch complains that size can be uninitialized if btf_type_id_size() returns NULL. It seems reasonable enough to check for that. Signed-off-by: Dan Carpenter --- This goes to the BPF tree (linux-next). diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 22e1046a1a86..e631b6fd60d3 100644 ---

Re: [net-next 1/1] tipc: introduce ioctl for fetching node identity

2018-04-27 Thread David Miller
From: Jon Maloy Date: Wed, 25 Apr 2018 19:29:36 +0200 > After the introduction of a 128-bit node identity it may be difficult > for a user to correlate between this identity and the generated node > hash address. > > We now try to make this easier by introducing a new ioctl() call for > fetching

Re: [PATCH net-next] l2tp: consistent reference counting in procfs and debufs

2018-04-27 Thread David Miller
From: Guillaume Nault Date: Wed, 25 Apr 2018 19:54:14 +0200 > The 'pppol2tp' procfs and 'l2tp/tunnels' debugfs files handle reference > counting of sessions differently than for tunnels. > > For consistency, use the same mechanism for handling both sessions and > tunnels. That is, drop the refer

Re: [PATCH net-next 6/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread kbuild test robot
Hi Intiyaz, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Felix-Manlunas/liquidio-enhanced-ethtool-set-channels-feature/20180427-195934 reproduce: # apt-get install sparse

[RFC PATCH] liquidio: lio_23xx_reconfigure_queue_count() can be static

2018-04-27 Thread kbuild test robot
Fixes: a6b1f70737e0 ("liquidio: enhanced ethtool --set-channels feature") Signed-off-by: Fengguang Wu --- lio_ethtool.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c

[PATCH net-next v2 0/6] mlxsw: SPAN: Support routes pointing at bridges

2018-04-27 Thread Ido Schimmel
Petr says: When mirroring to a gretap or ip6gretap netdevice, the route that directs the encapsulated packets can reference a bridge. In that case, in the software model, the packet is switched. Thus when offloading mirroring like that, take into consideration FDB, STP, PVID configured at the bri

[PATCH net-next v2 4/6] mlxsw: spectrum: Register SPAN before switchdev

2018-04-27 Thread Ido Schimmel
From: Petr Machata Since switchdev events can trigger SPAN respin, it is necessary that the data structures are available. Register SPAN first, with a commentary on what the dependencies are. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spect

[PATCH net-next v2 2/6] mlxsw: spectrum: Extract mlxsw_sp_stp_spms_state()

2018-04-27 Thread Ido Schimmel
From: Petr Machata Instead of duplicating the decision regarding port forwarding state made by mlxsw_sp_port_vid_stp_set(), extract the decision-making into a new function and reuse. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2

[PATCH net-next] udp: remove stray export symbol

2018-04-27 Thread Willem de Bruijn
From: Willem de Bruijn UDP GSO needs to export __udp_gso_segment to call it from ipv6. I accidentally exported static ipv4 function __udp4_gso_segment. Remove that EXPORT_SYMBOL_GPL. Fixes: ee80d1ebe5ba ("udp: add udp gso") Signed-off-by: Willem de Bruijn --- net/ipv4/udp_offload.c | 1 - 1 f

[PATCH net-next v2 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

2018-04-27 Thread Ido Schimmel
From: Petr Machata When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the underlay address (i.e. the remote address of the tunnel) may be routed to a bridge. In that case, look up the resolved neighbor Ethernet address in that bridge's FDB. Then configure the offload to direct

[PATCH net-next v2 5/6] mlxsw: Respin SPAN on switchdev events

2018-04-27 Thread Ido Schimmel
From: Petr Machata Changes to switchdev artifact can make a SPAN entry offloadable or unoffloadable. To that end: - Listen to SWITCHDEV_FDB_*_TO_BRIDGE notifications in addition to the *_TO_DEVICE ones, to catch whatever activity is sent to the bridge (likely by mlxsw itself). On each FDB

[PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

2018-04-27 Thread Ido Schimmel
From: Petr Machata Add a couple new functions to allow querying FDB and vlan settings of a bridge. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- include/linux/if_bridge.h | 28 net/bridge/br_fdb.c | 22 ++ net/bridge/br_priv

[PATCH net-next v2 3/6] mlxsw: spectrum_switchdev: Publish two functions

2018-04-27 Thread Ido Schimmel
From: Petr Machata Publish the existing function mlxsw_sp_bridge_port_find(), and add another service accessor mlxsw_sp_bridge_port_stp_state(). Publish both in a new file spectrum_switchdev.h. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../ethernet/mellanox/mlxsw/spectrum_sw

Re: [PATCH net] nfp: don't depend on eth_tbl being available

2018-04-27 Thread David Miller
From: Jakub Kicinski Date: Wed, 25 Apr 2018 11:21:08 -0700 > For very very old generation of the management FW Ethernet port > information table may theoretically not be available. This in > turn will cause the nfp_port structures to not be allocated. > > Make sure we don't crash the kernel whe

[PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-04-27 Thread Tarick Bedeir
Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words, either mlx4_init_port_info() succeeds and returns zero, or it fails, returns non-zero, and requires

Re: [PATCH net v2 0/2] net: mvpp2: Fix hangs when starting some interfaces on 7k/8k

2018-04-27 Thread David Miller
From: Maxime Chevallier Date: Wed, 25 Apr 2018 20:21:15 +0200 > Armada 7K / 8K clock management has recently been reworked, see : > > commit c7e92def1ef4 ("clk: mvebu: cp110: Fix clock tree representation") > > I have been experiencing overall system hangs on MacchiatoBin when starting > the et

Re: [PATCH net-next 0/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread David Miller
From: Felix Manlunas Date: Wed, 25 Apr 2018 11:23:01 -0700 > From: Intiyaz Basha > > For the ethtool --set-channels feature, the liquidio driver currently > accepts max combined value as the queue count configured during driver > load time, where max combined count is the total count of input

Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

2018-04-27 Thread Nikolay Aleksandrov
On 27/04/18 18:11, Ido Schimmel wrote: > From: Petr Machata > > Add a couple new functions to allow querying FDB and vlan settings of a > bridge. > > Signed-off-by: Petr Machata > Signed-off-by: Ido Schimmel > --- > include/linux/if_bridge.h | 28 > net/bridge/br_

Re: [PATCH net] pppoe: check sockaddr length in pppoe_connect()

2018-04-27 Thread Guillaume Nault
On Fri, Apr 27, 2018 at 08:23:16AM -0400, Kevin Easton wrote: > On Mon, Apr 23, 2018 at 04:38:27PM +0200, Guillaume Nault wrote: > > We must validate sockaddr_len, otherwise userspace can pass fewer data > > than we expect and we end up accessing invalid data. > > > > Fixes: 224cf5ad14c0 ("ppp: Mo

Re: [PATCH net-next v2 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

2018-04-27 Thread Nikolay Aleksandrov
On 27/04/18 18:11, Ido Schimmel wrote: > From: Petr Machata > > When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the > underlay address (i.e. the remote address of the tunnel) may be routed > to a bridge. > > In that case, look up the resolved neighbor Ethernet address in tha

Re: [PATCH net-next] l2tp: consistent reference counting in procfs and debufs

2018-04-27 Thread Guillaume Nault
On Fri, Apr 27, 2018 at 11:06:55AM -0400, David Miller wrote: > From: Guillaume Nault > Date: Wed, 25 Apr 2018 19:54:14 +0200 > > > The 'pppol2tp' procfs and 'l2tp/tunnels' debugfs files handle reference > > counting of sessions differently than for tunnels. > > > > For consistency, use the same

Re: ip6-in-ip{4,6} ipsec tunnel issues with 1280 MTU

2018-04-27 Thread Ashwanth Goli
On 2018-04-27 20:18, David Ahern wrote: On 4/27/18 5:02 AM, Ashwanth Goli wrote: On 2018-04-26 17:21, Paolo Abeni wrote: Hi, [fixed CC list] On Wed, 2018-04-25 at 21:43 +0530, Ashwanth Goli wrote: Hi Pablo, Actually I'm Paolo, but yours is a recurring mistake ;) I am noticing an issue si

[PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Kevin Easton
The struct vhost_msg within struct vhost_msg_node is copied to userspace, so it should be allocated with kzalloc() to ensure all structure padding is zeroed. Signed-off-by: Kevin Easton Reported-by: syzbot+87cfa083e727a2247...@syzkaller.appspotmail.com --- drivers/vhost/vhost.c | 2 +- 1 file ch

Re: [net-next] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread Randy Dunlap
On 04/27/2018 03:35 AM, Ahmed Abdelsalam wrote: > This patch adds a documentation for seg_flowlabel sysctl into > Documentation/networking/ip-sysctl.txt > > Signed-off-by: Ahmed Abdelsalam > --- > Documentation/networking/ip-sysctl.txt | 13 + > 1 file changed, 13 insertions(+) > >

Re: [PATCH net] tcp: ignore Fast Open on repair mode

2018-04-27 Thread David Miller
From: Yuchung Cheng Date: Wed, 25 Apr 2018 11:33:08 -0700 > The TCP repair sequence of operation is to first set the socket in > repair mode, then inject the TCP stats into the socket with repair > socket options, then call connect() to re-activate the socket. The > connect syscall simply returns

Re: [PATCH net] pppoe: check sockaddr length in pppoe_connect()

2018-04-27 Thread Kevin Easton
On Fri, Apr 27, 2018 at 05:39:06PM +0200, Guillaume Nault wrote: > On Fri, Apr 27, 2018 at 08:23:16AM -0400, Kevin Easton wrote: ... > > There's another bug here - pppoe_connect() should also be validating > > sp->sa_family. My suggested patch was going to be: > > > > diff --git a/drivers/net/ppp

[net-next v2] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread Ahmed Abdelsalam
This patch adds a documentation for seg_flowlabel sysctl into Documentation/networking/ip-sysctl.txt Signed-off-by: Ahmed Abdelsalam --- Documentation/networking/ip-sysctl.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentati

Re: [net-next] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread Ahmed Abdelsalam
On Fri, 27 Apr 2018 08:47:14 -0700 Randy Dunlap wrote: > On 04/27/2018 03:35 AM, Ahmed Abdelsalam wrote: > > This patch adds a documentation for seg_flowlabel sysctl into > > Documentation/networking/ip-sysctl.txt > > > > Signed-off-by: Ahmed Abdelsalam > > --- > > Documentation/networking/ip-

Re: [PATCH v1 net-next] microchip_t1: Add driver for Microchip LAN87XX T1 PHYs

2018-04-27 Thread Florian Fainelli
On 04/27/2018 08:10 AM, Nisar Sayed wrote: > Add driver for Microchip LAN87XX T1 PHYs > > This patch support driver for Microchp T1 PHYs. > There will be followup patches to this driver to support T1 PHY > features such as cable diagnostics, signal quality indicator(SQI), > sleep and wakeup (TC1

Re: tc: Using u32 filter

2018-04-27 Thread Jose Abreu
On 27-04-2018 16:04, Jiri Pirko wrote: > Fri, Apr 27, 2018 at 04:15:46PM CEST, jose.ab...@synopsys.com wrote: >> Hi, >> >> I'm trying to use u32 filter to filter specific fields of packets >> by HW *only* but I'm having a hard time in trying to run tc to >> configure it. >> I implemented a dummy .n

[PATCH v4 net-next 1/2] tcp: add TCP_ZEROCOPY_RECEIVE support for zerocopy receive

2018-04-27 Thread Eric Dumazet
When adding tcp mmap() implementation, I forgot that socket lock had to be taken before current->mm->mmap_sem. syzbot eventually caught the bug. Since we can not lock the socket in tcp mmap() handler we have to split the operation in two phases. 1) mmap() on a tcp socket simply reserves VMA space

  1   2   3   4   >