[PATCH bpf v2] bpf/tracing: fix a deadlock in perf_event_detach_bpf_prog

2018-04-10 Thread Yonghong Song
syzbot reported a possible deadlock in perf_event_detach_bpf_prog. The error details: == WARNING: possible circular locking dependency detected 4.16.0-rc7+ #3 Not tainted -- syz-executo

[PATCH bpf v3] bpf/tracing: fix a deadlock in perf_event_detach_bpf_prog

2018-04-10 Thread Yonghong Song
syzbot reported a possible deadlock in perf_event_detach_bpf_prog. The error details: == WARNING: possible circular locking dependency detected 4.16.0-rc7+ #3 Not tainted -- syz-executo

Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-10 Thread Jason Wang
On 2018年04月10日 12:57, Tiwei Bie wrote: On Tue, Apr 10, 2018 at 10:52:52AM +0800, Jason Wang wrote: On 2018年04月02日 23:23, Tiwei Bie wrote: This patch introduces a mdev (mediated device) based hardware vhost backend. This backend is an abstraction of the various hardware vhost accelerators (pot

Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-10 Thread Paolo Bonzini
On 10/04/2018 06:57, Tiwei Bie wrote: >> So you just move the abstraction layer from qemu to kernel, and you still >> need different drivers in kernel for different device interfaces of >> accelerators. This looks even more complex than leaving it in qemu. As you >> said, another idea is to impleme

Re: [PATCH bpf v3] bpf/tracing: fix a deadlock in perf_event_detach_bpf_prog

2018-04-10 Thread Daniel Borkmann
On 04/10/2018 09:21 AM, Yonghong Song wrote: > syzbot reported a possible deadlock in perf_event_detach_bpf_prog. > The error details: > == > WARNING: possible circular locking dependency detected > 4.16.0-rc7+ #3 Not tainted > ---

Patch "x86/asm: Don't use RBP as a temporary register in csum_partial_copy_generic()" has been added to the 4.4-stable tree

2018-04-10 Thread gregkh
This is a note to let you know that I've just added the patch titled x86/asm: Don't use RBP as a temporary register in csum_partial_copy_generic() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

[PATCH linux] net: fix deadlock while clearing neighbor proxy table

2018-04-10 Thread Wolfgang Bumiller
When coming from ndisc_netdev_event() in net/ipv6/ndisc.c, neigh_ifdown() is called with &nd_tbl, locking this while clearing the proxy neighbor entries when eg. deleting an interface. Calling the table's pndisc_destructor() with the lock still held, however, can cause a deadlock: When a multicast

RE: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-10 Thread Liang, Cunming
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, April 10, 2018 3:52 PM > To: Bie, Tiwei ; Jason Wang > Cc: m...@redhat.com; alex.william...@redhat.com; ddut...@redhat.com; > Duyck, Alexander H ; virtio-dev@lists.oasis- > open.org; linux-ker...@vge

Re: [PATCH] slip: Check if rstate is initialized before uncompressing

2018-04-10 Thread Guillaume Nault
On Tue, Apr 10, 2018 at 11:28:10AM +0530, tejas...@codeaurora.org wrote: > On 2018-04-09 20:34, David Miller wrote: > > From: Tejaswi Tanikella > > Date: Mon, 9 Apr 2018 14:23:49 +0530 > > > > > @@ -673,6 +677,7 @@ struct slcompress * > > > if (cs->cs_tcp.doff > 5) > > > memcpy(cs->cs_tcpop

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Xue Liu
Hallo, Thanks for the fix. It looks good. ACK-by: Xue Liu On 5 April 2018 at 18:20, Gustavo A. R. Silva wrote: > Free allocated memory for pdata before return. > > Addresses-Coverity-ID: 1466096 ("Resource leak") > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver > d

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

2018-04-10 Thread Daniel Borkmann
On 04/09/2018 01:26 PM, Jesper Dangaard Brouer wrote: > On Fri, 6 Apr 2018 12:36:18 +0200 > Daniel Borkmann wrote: [...] >> [...] >> The underlying problem is effectively the decoupling of program >> verification that doesn't have/know the context of where it is being >> attached to in this case.

Re: XDP_TX for virtio_net not working in recent kernel?

2018-04-10 Thread Daniel Borkmann
[ +jason +netdev ] On 04/10/2018 12:49 AM, Kimitoshi Takahashi wrote: > Hello, > > I'm totally newbie. > > I want to try some examples under the samples/bpf of the kernel tree using > the virtio_net driver in kvm, in order to get familiar with the XDP. However, > it seems to me that for kernel

Re: [RFC bpf-next] bpf: document eBPF helpers and add a script to generate man page

2018-04-10 Thread Quentin Monnet
2018-04-09 18:47 UTC-0700 ~ Alexei Starovoitov > On Mon, Apr 09, 2018 at 02:25:26PM +0100, Quentin Monnet wrote: >> >> Anyway, I am fine with keeping just signatures, descriptions and return >> values for now. I will submit a new version with only those items. > > Thank you. > > Could you also s

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Stefan Schmidt
Hello. On 04/10/2018 11:54 AM, Xue Liu wrote: > Hallo, > > Thanks for the fix. It looks good. > > ACK-by: Xue Liu Thanks for the ACK Xue. The correct format would be Acked-by: Xue Liu That way patchwork also picks the ACK up and adds it to the patch before I apply it from there. No worries

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Jiri Pirko
Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: >On 4/9/2018 1:07 AM, Jiri Pirko wrote: >> Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/6/2018 5:48 AM, Jiri Pirko wrote: >> > > Thu, Apr 05, 2018 at 11:08:22PM CEST, sridhar.samudr...@int

[PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread Sabrina Dubroca
Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via netlink") added the ability to change o_flags, but missed that the GSO/LLTX features are disabled by default, and only enabled some gre features are unused. Thus we also need to disable the GSO/LLTX features on the device when t

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Stefan Schmidt
Hello. On 04/05/2018 06:20 PM, Gustavo A. R. Silva wrote: > Free allocated memory for pdata before return. > > Addresses-Coverity-ID: 1466096 ("Resource leak") > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver > driver") > Signed-off-by: Gustavo A. R. Silva > --- > d

Re: [PATCH v2 2/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent

2018-04-10 Thread Kevin Easton
On Mon, Apr 09, 2018 at 12:34:42PM +0200, Steffen Klassert wrote: > On Sat, Apr 07, 2018 at 11:40:47AM -0400, Kevin Easton wrote: > > Several places use (x + 7) / 8 to convert from a number of bits to a number > > of bytes. Replace those with DIV_ROUND_UP(x, 8) instead, for consistency > > with ot

[PATCH] selftests: bpf: update .gitignore with missing generated files

2018-04-10 Thread Anders Roxell
Signed-off-by: Anders Roxell --- tools/testing/selftests/bpf/.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index 9cf83f895d98..5e1ab2f0eb79 100644 --- a/tools/testing/selftests/bpf/.gitignore +++

[PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Phil Elwell
Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY initialisation into lan78xx_probe, but lan78xx_open subsequently calls lan78xx_reset. As well as forcing a second round of link negotiation, this reset frequently prevents the phy interrupt from being generated (even though the link i

Re: [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc

2018-04-10 Thread Thomas Gleixner
Jesus, On Mon, 9 Apr 2018, Jesus Sanchez-Palencia wrote: > On 03/28/2018 12:48 AM, Thomas Gleixner wrote: > > Yes, you have the root qdisc, which is in charge of the overall scheduling > > plan, how complex or not it is defined does not matter. It exposes traffic > > classes which have properties

aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot

2018-04-10 Thread Yanko Kaneti
Hello, Since 90869ddfefeb net: aquantia: Implement pci shutdown callback I get the below oops on reboot. Without the callback everything works as expected. 05:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz Ethernet Controller [AQtion] [1d6a:d107] (rev 02) Fedora ra

Re: aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot

2018-04-10 Thread Igor Russkikh
On 10.04.2018 15:42, Yanko Kaneti wrote: > Hello, > > Since 90869ddfefeb net: aquantia: Implement pci shutdown callback > I get the below oops on reboot. Without the callback everything works > as expected. > Thanks, we also recently found out that. Could you please try the below patch? di

Re: [RFC PATCH v3 bpf-next 0/5] bpf/verifier: subprog/func_call simplifications

2018-04-10 Thread Jiong Wang
On 06/04/2018 18:11, Edward Cree wrote: By storing subprog boundaries as a subprogno mark on each insn, rather than a start (and implicit end) for each subprog, the code handling subprogs can in various places be made simpler, more explicit, and more efficient (i.e. better asymptotic complexit

Re: [RFC PATCH v3 bpf-next 4/5] bpf/verifier: use call graph to efficiently check max stack depth

2018-04-10 Thread Jiong Wang
On 06/04/2018 18:14, Edward Cree wrote: Since that algorithm selects + * nodes in the order of the sorted output, we can do our processing in the loop + * that does the tsort, rather than storing the sorted list and then having a + * second loop to iterate over it and compute the total_stack_de

Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread Xin Long
On Tue, Apr 10, 2018 at 6:57 PM, Sabrina Dubroca wrote: > Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via > netlink") added the ability to change o_flags, but missed that the > GSO/LLTX features are disabled by default, and only enabled some gre > features are unused. Thus w

Re: [PATCH v2 1/2] vhost: fix vhost_vq_access_ok() log check

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 01:26:29PM +0800, Stefan Hajnoczi wrote: > Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log > when IOTLB is enabled") introduced a regression. The logic was > originally: > > if (vq->iotlb) > return 1; > return A && B; > > After the patch th

Re: [PATCH v2 1/2] vhost: fix vhost_vq_access_ok() log check

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 04:22:35PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 10, 2018 at 01:26:29PM +0800, Stefan Hajnoczi wrote: > > Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log > > when IOTLB is enabled") introduced a regression. The logic was > > originally: > > >

Re: [PATCH v2 2/2] vhost: return bool from *_access_ok() functions

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 01:26:30PM +0800, Stefan Hajnoczi wrote: > Currently vhost *_access_ok() functions return int. This is error-prone > because there are two popular conventions: > > 1. 0 means failure, 1 means success > 2. -errno means failure, 0 means success > > Although vhost mostly use

[PATCH 2/2] net: wireless: zydas: Replace GFP_ATOMIC with GFP_KERNEL in zd1201_fw_upload

2018-04-10 Thread Jia-Ju Bai
zd1201_probe() is never called in atomic context. zd1201_fw_upload() is only called by zd1201_probe(), which is only set as ".probe" in struct usb_driver. Despite never getting called from atomic context, zd1201_fw_upload() calls kmalloc() with GFP_ATOMIC, which does not sleep for allocation. GF

[PATCH 1/2] net: wireless: zydas: Replace mdelay with msleep in zd1201_probe

2018-04-10 Thread Jia-Ju Bai
zd1201_probe() is never called in atomic context. zd1201_probe() is only set as ".probe" in struct usb_driver. Despite never getting called from atomic context, zd1201_probe() calls mdelay() to busily wait. This is not necessary and can be replaced with msleep() to avoid busy waiting. This is fo

Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 09:23:53AM +, Liang, Cunming wrote: > > > > -Original Message- > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > Sent: Tuesday, April 10, 2018 3:52 PM > > To: Bie, Tiwei ; Jason Wang > > Cc: m...@redhat.com; alex.william...@redhat.com; ddut...@redhat.co

Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread William Tu
On Tue, Apr 10, 2018 at 6:10 AM, Xin Long wrote: > On Tue, Apr 10, 2018 at 6:57 PM, Sabrina Dubroca wrote: >> Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via >> netlink") added the ability to change o_flags, but missed that the >> GSO/LLTX features are disabled by default,

[PATCH] net: wireless: cisco: airo: Replace mdelay with usleep_range in flashgchar

2018-04-10 Thread Jia-Ju Bai
flashgchar() is never called in atomic context. flashgchar() is only called by flashcard(). flashcard() calls copy_from_user() and kmalloc(GFP_KERNEL), which indicates this function is not called in atomic context. Despite never getting called from atomic context, flashgchar() calls mdelay() to

Re: [PATCH v2] net: phy: marvell: Enable interrupt function on LED2 pin

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 7.6606) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16: Bu

Re: [PATCH net 3/3] lan78xx: Lan7801 Support for Fixed PHY

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 55d7de9de6c3 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver. The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.

Re: [PATCH] dp83640: Ensure against premature access to PHY registers after reset

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 6.8160) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16: Bu

Re: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 7.2454) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16: Bu

Re: [PATCH] ARM: dts: ls1021a: Specify TBIPA register address

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 22.1404) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16: B

Re: [PATCH net 0/3] lan78xx: Fixes and enhancements

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 55d7de9de6c3 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver. The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.

Re: [PATCH net 1/3] lan78xx: PHY DSP registers initialization to address EEE link drop issues with long cables

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 55d7de9de6c3 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver. The bot has also determined it's probably a bug fixing patch. (score: 3.9486) The bot has te

Re: [PATCH net 2/3] lan78xx: Add support to dump lan78xx registers

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 55d7de9de6c3 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver. The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.

Re: [PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 5.8567) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16: Bu

[PATCH] net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

2018-04-10 Thread Jia-Ju Bai
dma_tx_fragment() is never called in atomic context. dma_tx_fragment() is only called by b43legacy_dma_tx(), which is only called by b43legacy_tx_work(). b43legacy_tx_work() is only set a parameter of INIT_WORK() in b43legacy_wireless_init(). Despite never getting called from atomic context, dm

Re: [PATCH 1/4] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 0ef58b0a05c1 hv_netvsc: change GPAD teardown order on older versions. The bot has also determined it's probably a bug fixing patch. (score: 19.6070) The bot has tested the followi

Re: [PATCH 2/4] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 0ef58b0a05c1 hv_netvsc: change GPAD teardown order on older versions. The bot has also determined it's probably a bug fixing patch. (score: 3.6623) The bot has tested the followin

Re: [PATCH 3/4] hv_netvsc: Ensure correct teardown message sequence order

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 0ef58b0a05c1 hv_netvsc: change GPAD teardown order on older versions. The bot has also determined it's probably a bug fixing patch. (score: 60.7987) The bot has tested the followi

Re: [patch net] devlink: convert occ_get op to separate registration

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: d9f9b9a4d05f devlink: Add support for resource abstraction. The bot has tested the following trees: v4.16.1. v4.16.1: Failed to apply! Possible dependencies: 37923ed6b8ce ("net

Re: [PATCH] slip: Check if rstate is initialized before uncompressing

2018-04-10 Thread David Miller
From: tejas...@codeaurora.org Date: Tue, 10 Apr 2018 11:28:10 +0530 > On 2018-04-09 20:34, David Miller wrote: >> From: Tejaswi Tanikella >> Date: Mon, 9 Apr 2018 14:23:49 +0530 >> >>> @@ -673,6 +677,7 @@ struct slcompress * >>> if (cs->cs_tcp.doff > 5) >>> memcpy(cs->cs_tcpopt, icp +

Re: aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot

2018-04-10 Thread Yanko Kaneti
On Tue, 2018-04-10 at 15:53 +0300, Igor Russkikh wrote: > On 10.04.2018 15:42, Yanko Kaneti wrote: > > Hello, > > > > Since 90869ddfefeb net: aquantia: Implement pci shutdown callback > > I get the below oops on reboot. Without the callback everything works > > as expected. > > > > Thanks, we

Re: [patch net] devlink: convert occ_get op to separate registration

2018-04-10 Thread Jiri Pirko
Tue, Apr 10, 2018 at 03:49:40PM CEST, alexander.le...@microsoft.com wrote: >Hi, > >[This is an automated email] > >This commit has been processed because it contains a "Fixes:" tag, >fixing commit: d9f9b9a4d05f devlink: Add support for resource abstraction. I don't think we need this fix in stable

[PATCH] net: wimax: i2400m: Replace GFP_ATOMIC with GFP_KERNEL in i2400m_tx_setup

2018-04-10 Thread Jia-Ju Bai
i2400m_tx_setup() is never called in atomic context. The call chains ending up at i2400m_tx_setup() are: [1] i2400m_tx_setup() <- __i2400m_dev_start() <- __i2400m_dev_reset_handle() [2] i2400m_tx_setup() <- __i2400m_dev_start() <- i2400m_dev_start() <- i2400m_setup() <- i2400mu_p

Re: [RFC PATCH v2 00/14] Introducing AF_XDP support

2018-04-10 Thread William Tu
On Mon, Apr 9, 2018 at 11:47 PM, Björn Töpel wrote: > 2018-04-09 23:51 GMT+02:00 William Tu : >> On Tue, Mar 27, 2018 at 9:59 AM, Björn Töpel wrote: >>> From: Björn Töpel >>> >>> This RFC introduces a new address family called AF_XDP that is >>> optimized for high performance packet processing a

RE: [PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Nisar.Sayed
Thanks Phil, for identifying the issues. > - ret = lan78xx_reset(dev); > - if (ret < 0) > - goto done; > - > phy_start(net->phydev); > > netif_dbg(dev, ifup, dev->net, "phy initialised successfully"); > -- You may need to start the interrupts before "phy_start" in

Re: marvell switch

2018-04-10 Thread Ran Shalit
On Thu, Apr 5, 2018 at 11:46 PM, Andrew Lunn wrote: >> > Hi Ran >> > >> > The Marvell driver makes each port act like a normal Linux network >> > interface. So if you want to enable a port, do >> > >> > ip link set lan0 up >> > >> > Want to add an ip address to a port >> > >> > ip addr add 10.42.4

[PATCH] net: sbni: Replace mdelay with msleep in sbni_probe1

2018-04-10 Thread Jia-Ju Bai
sbni_probe1() is never called in atomic context. The call chains ending up at sbni_probe1() are: [1] sbni_probe1() <- sbni_init() <- sbni_probe() <- net_olddevs_init() [2] sbni_probe1() <- sbni_isa_probe() <- sbni_init() <- sbni_probe() <- net_olddevs_init() [3] sbni_probe1() <- sbni_pci_

RE: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-10 Thread Liang, Cunming
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, April 10, 2018 9:36 PM > To: Liang, Cunming > Cc: Paolo Bonzini ; Bie, Tiwei ; > Jason Wang ; alex.william...@redhat.com; > ddut...@redhat.com; Duyck, Alexander H ; > virtio-...@lists.oasis-open.org

[PATCH net 1/2] tun: set the flags before registering the netdevice

2018-04-10 Thread Sabrina Dubroca
Otherwise, register_netdevice advertises the creation of the device with the default flags, instead of what the user requested. Reported-by: Thomas Haller Fixes: 1ec010e70593 ("tun: export flags, uid, gid, queue information over netlink") Signed-off-by: Sabrina Dubroca --- drivers/net/tun.c |

Re: ath10k: avoid possible string overflow

2018-04-10 Thread Kalle Valo
Arnd Bergmann wrote: > The way that 'strncat' is used here raised a warning in gcc-8: > > drivers/net/wireless/ath/ath10k/wmi.c: In function > 'ath10k_wmi_tpc_stats_final_disp_tables': > drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output > truncated before terminating nul co

[PATCH net 2/2] tun: send netlink notification when the device is modified

2018-04-10 Thread Sabrina Dubroca
I added dumping of link information about tun devices over netlink in commit 1ec010e70593 ("tun: export flags, uid, gid, queue information over netlink"), but didn't add the missing netlink notifications when the device's exported properties change. This patch adds notifications when owner/group o

Re: [next] wil6210: fix potential null dereference of ndev before null check

2018-04-10 Thread Kalle Valo
Colin Ian King wrote: > The pointer ndev is being dereferenced before it is being null checked, > hence there is a potential null pointer deference. Fix this by only > dereferencing ndev after it has been null checked > > Detected by CoverityScan, CID#1467010 ("Dereference before null check") >

Re: ath10k: fix spelling mistake: "tiggers" -> "triggers"

2018-04-10 Thread Kalle Valo
Colin Ian King wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6ce36faeac35 ath10k: fix spelling mistake: "tiggers" -> "triggers" -- https://patchwork.kernel.org/patc

Re: ath9k: dfs: remove accidental use of stack VLA

2018-04-10 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wvla, remove accidental use of stack VLA. > > This avoids an accidental stack VLA (since the compiler thinks > the value of FFT_NUM_SAMPLES can change, even when marked > "const"). This just replaces it with a #define. > > Also, fixed a

Re: [PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Phil Elwell
Hi Nisar, On 10/04/2018 15:16, nisar.sa...@microchip.com wrote: > Thanks Phil, for identifying the issues. > >> -ret = lan78xx_reset(dev); >> -if (ret < 0) >> -goto done; >> - >> phy_start(net->phydev); >> >> netif_dbg(dev, ifup, dev->net, "phy initialised successful

Re: [patch net] devlink: convert occ_get op to separate registration

2018-04-10 Thread David Miller
From: Sasha Levin Date: Tue, 10 Apr 2018 13:49:40 + > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: d9f9b9a4d05f devlink: Add support for resource abstraction. > > The bot has tested the following trees: v4.16.1. This is nice, but it's becomming noise.

Re: [PATCH net-next] netns: filter uevents correctly

2018-04-10 Thread Christian Brauner
On Mon, Apr 09, 2018 at 06:21:31PM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Thu, Apr 05, 2018 at 10:59:49PM -0500, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill Tkhai wrote: > >> >> On 05.04.2018

[PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device

2018-04-10 Thread Jia-Ju Bai
hso_create_device() is never called in atomic context. The call chains ending up at hso_create_device() are: [1] hso_create_device() <- hso_create_bulk_serial_device() <- hso_probe() [2] hso_create_device() <- hso_create_mux_serial_device() <- hso_probe() [3] hso_create_device() <- hso_create_net_

Re: [patch net] devlink: convert occ_get op to separate registration

2018-04-10 Thread David Miller
From: Jiri Pirko Date: Tue, 10 Apr 2018 16:13:09 +0200 > Tue, Apr 10, 2018 at 03:49:40PM CEST, alexander.le...@microsoft.com wrote: >>Hi, >> >>[This is an automated email] >> >>This commit has been processed because it contains a "Fixes:" tag, >>fixing commit: d9f9b9a4d05f devlink: Add support fo

[RFC bpf-next v2 0/8] bpf: document eBPF helpers and add a script to generate man page

2018-04-10 Thread Quentin Monnet
eBPF helper functions can be called from within eBPF programs to perform a variety of tasks that would be otherwise hard or impossible to do with eBPF itself. There is a growing number of such helper functions in the kernel, but documentation is scarce. The main user space header file does contain

[RFC bpf-next v2 1/8] bpf: add script and prepare bpf.h for new helpers documentation

2018-04-10 Thread Quentin Monnet
Remove previous "overview" of eBPF helpers from user bpf.h header. Replace it by a comment explaining how to process the new documentation (to come in following patches) with a Python script to produce RST, then man page documentation. Also add the aforementioned Python script under scripts/. It i

[RFC bpf-next v2 5/8] bpf: add documentation for eBPF helpers (33-41)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 6/8] bpf: add documentation for eBPF helpers (42-50)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 7/8] bpf: add documentation for eBPF helpers (51-57)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 2/8] bpf: add documentation for eBPF helpers (01-11)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 4/8] bpf: add documentation for eBPF helpers (23-32)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

[RFC bpf-next v2 3/8] bpf: add documentation for eBPF helpers (12-22)

2018-04-10 Thread Quentin Monnet
Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page. The objective is to make the documentation

Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check

2018-04-10 Thread David Miller
From: Jason Wang Date: Tue, 10 Apr 2018 14:40:10 +0800 > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: >> v2: >> * Rewrote the conditional to make the vq access check clearer [Linus] >> * Added Patch 2 to make the return type consistent and harder to misuse >> * [Linus] >> >> The first patch

Re: [PATCH net-next 0/3] ave: fix the activation issues for some UniPhier SoCs

2018-04-10 Thread David Miller
From: Kunihiko Hayashi Date: Mon, 9 Apr 2018 15:38:42 +0900 > This add the following stuffs to fix the activation issues and satisfy > requirements for AVE ethernet driver implemented on some UniPhier SoCs. > > - Add support for additional necessary clocks and resets, because the kernel > is

Re: mISDN: Remove VLAs

2018-04-10 Thread David Miller
This patch puts more than 1400 bytes onto the kernel stack in l1oip_socket_send(), which is a cure worse than the disease. I'm not applying this, sorry.

Re: [PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device

2018-04-10 Thread Johan Hovold
On Tue, Apr 10, 2018 at 10:35:24PM +0800, Jia-Ju Bai wrote: > hso_create_device() is never called in atomic context. > > The call chains ending up at hso_create_device() are: > [1] hso_create_device() <- hso_create_bulk_serial_device() <- hso_probe() > [2] hso_create_device() <- hso_create_mux_ser

Re: [PATCH linux] net: fix deadlock while clearing neighbor proxy table

2018-04-10 Thread David Miller
From: Wolfgang Bumiller Date: Tue, 10 Apr 2018 11:15:14 +0200 > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index 7b7a14abba28..601df647588c 100644 > --- a/net/core/neighbour.c > +++ b/net/core/neighbour.c > @@ -292,7 +292,6 @@ int neigh_ifdown(struct neigh_table *tbl, struct > ne

Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread David Miller
From: Sabrina Dubroca Date: Tue, 10 Apr 2018 12:57:18 +0200 > Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via > netlink") added the ability to change o_flags, but missed that the > GSO/LLTX features are disabled by default, and only enabled some gre > features are unused. T

Re: [PATCH net-next] netns: filter uevents correctly

2018-04-10 Thread Eric W. Biederman
Christian Brauner writes: > On Mon, Apr 09, 2018 at 06:21:31PM -0500, Eric W. Biederman wrote: >> Christian Brauner writes: >> >> > On Thu, Apr 05, 2018 at 10:59:49PM -0500, Eric W. Biederman wrote: >> >> Christian Brauner writes: >> >> >> >> > On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Samudrala, Sridhar
On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:22

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Jiri Pirko
Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: >On 4/10/2018 3:55 AM, Jiri Pirko wrote: >> Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/9/2018 1:07 AM, Jiri Pirko wrote: >> > > Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@in

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Samudrala, Sridhar
On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:1

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Jiri Pirko
Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: >On 4/10/2018 8:22 AM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/10/2018 3:55 AM, Jiri Pirko wrote: >> > > Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@i

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Siwei Liu
On Tue, Apr 10, 2018 at 8:43 AM, Jiri Pirko wrote: > Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: >>On 4/10/2018 8:22 AM, Jiri Pirko wrote: >>> Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: >>> > On 4/10/2018 3:55 AM, Jiri Pirko wrote: >>> > >

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-10 Thread Samudrala, Sridhar
On 4/10/2018 8:43 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:

Re: [PATCH net] sctp: sctp_sockaddr_af must check minimal addr length for AF_INET6

2018-04-10 Thread Marcelo Ricardo Leitner
On Sun, Apr 08, 2018 at 07:52:08AM -0700, Eric Dumazet wrote: > Check must happen before call to ipv6_addr_v4mapped() Please don't forget to also Cc linux-s...@vger.kernel.org on sctp patches. Thanks!

Re: [RFC] connector: add group_exit_code and signal_flags fields to exit_proc_event

2018-04-10 Thread Stefan Strogin
Hi Evgeniy, On 09/04/18 02:49, Evgeniy Polyakov wrote: > Hi everyone > > Sorry for that late reply > > 01.03.2018, 21:58, "Stefan Strogin" : >> So I was thinking to add these two fields to union event_data: >> task->signal->group_exit_code >> task->signal->flags >> This won't increase size of st

Re: [PATCH bpf v3] bpf/tracing: fix a deadlock in perf_event_detach_bpf_prog

2018-04-10 Thread Yonghong Song
On 4/10/18 1:54 AM, Daniel Borkmann wrote: On 04/10/2018 09:21 AM, Yonghong Song wrote: syzbot reported a possible deadlock in perf_event_detach_bpf_prog. The error details: == WARNING: possible circular locking dependency detected 4

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-10 Thread Marcelo Ricardo Leitner
On Sun, Apr 08, 2018 at 08:41:21PM +0200, Wenhua Shi wrote: > 2018-04-08 18:51 GMT+02:00 David Miller : > > > > From: Wenhua Shi > > Date: Fri, 6 Apr 2018 03:43:39 +0200 > > > > > Signed-off-by: Wenhua Shi > > > > This precondition should be made impossible instead of having to do > > an extra c

[PATCH bpf v4] bpf/tracing: fix a deadlock in perf_event_detach_bpf_prog

2018-04-10 Thread Yonghong Song
syzbot reported a possible deadlock in perf_event_detach_bpf_prog. The error details: == WARNING: possible circular locking dependency detected 4.16.0-rc7+ #3 Not tainted -- syz-executo

Re: [RFC bpf-next v2 7/8] bpf: add documentation for eBPF helpers (51-57)

2018-04-10 Thread Yonghong Song
On 4/10/18 7:41 AM, Quentin Monnet wrote: Add documentation for eBPF helper functions to bpf.h user header file. This documentation can be parsed with the Python script provided in another commit of the patch series, in order to provide a RST document that can later be converted into a man page

[RFC net-next 2/2] net: net-sysfs: Reduce netstat_show read_lock critical section

2018-04-10 Thread Saeed Mahameed
Instead of holding the device chain read_lock also while calling dev_get_stats just hold it only to check dev_isalive, if the dev is alive, hold that dev via dev_hold then release the read_lock. When done handling the device, dev_put it. Signed-off-by: Saeed Mahameed --- net/core/net-sysfs.c |

[RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section

2018-04-10 Thread Saeed Mahameed
The current net proc fs sequence file implementation to show current namespace netdevs list statistics and mc lists holds the rcu lock throughout the whole process, from dev seq start up to dev seq stop. This is really greedy and demanding from device drivers since ndo_get_stats64 called from dev_

Re: [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section

2018-04-10 Thread David Miller
From: Saeed Mahameed Date: Tue, 10 Apr 2018 10:08:11 -0700 > The current net proc fs sequence file implementation to show current > namespace netdevs list statistics and mc lists holds the rcu lock > throughout the whole process, from dev seq start up to dev seq stop. > > This is really greedy a

Re: [RFC net-next 2/2] net: net-sysfs: Reduce netstat_show read_lock critical section

2018-04-10 Thread David Miller
From: Saeed Mahameed Date: Tue, 10 Apr 2018 10:08:12 -0700 > Instead of holding the device chain read_lock also while calling > dev_get_stats just hold it only to check dev_isalive, if the dev is alive, > hold that dev via dev_hold then release the read_lock. > > When done handling the device, d

  1   2   >