On Wed, Apr 4, 2018 at 2:45 PM, Icenowy Zheng wrote:
> 在 2018-04-03二的 11:50 +0200，Maxime Ripard写道：
>> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote:
>> > On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote:
>> > > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard
>> > > wrot
Hi
Today's head and linux-next doesn't compile due commit 9217e566bdee
("of_net: Implement of_get_nvmem_mac_address helper"):
drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
.../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cell_get'
.../drivers/of/of_net.c:104: undefi
On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote:
> On 4/3/18 9:42 AM, Jiri Pirko wrote:
>>>
>>> There are other use cases that want to hide a device from userspace. I
>>
>> What usecases do you have in mind?
>
> As mentioned in a previous response some kernel drivers create control
> netdevs. Ju
On Tue, Apr 3, 2018 at 11:19 PM, Jiri Pirko wrote:
> Wed, Apr 04, 2018 at 03:04:26AM CEST, dsah...@gmail.com wrote:
>>On 4/3/18 9:42 AM, Jiri Pirko wrote:
There are other use cases that want to hide a device from userspace. I
>>>
>>> What usecases do you have in mind?
>>
>>As mentioned i
On Tue, Apr 3, 2018 at 5:25 AM, Michael S. Tsirkin wrote:
> On Sun, Apr 01, 2018 at 05:13:08AM -0400, Si-Wei Liu wrote:
>> @@ -896,6 +898,68 @@ void qmp_device_del(const char *id, Error **errp)
>> }
>> }
>>
>> +int pci_get_busdevfn_by_id(const char *id, uint16_t *busnr,
>> +
On Tue, Apr 3, 2018 at 5:20 AM, Michael S. Tsirkin wrote:
> On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote:
>> diff --git a/include/uapi/linux/virtio_net.h
>> b/include/uapi/linux/virtio_net.h
>> index aa40664..0827b7e 100644
>> --- a/include/uapi/linux/virtio_net.h
>> +++ b/include/u
On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote:
> On 4/3/18 9:42 AM, Jiri Pirko wrote:
>>>
>>> There are other use cases that want to hide a device from userspace. I
>>
>> What usecases do you have in mind?
>
> As mentioned in a previous response some kernel drivers create control
> netdevs. Ju
On 04/03/2018 07:03 PM, Saeed Mahameed wrote:
> On Tue, Apr 3, 2018 at 9:23 AM, David Miller wrote:
>> From: Jesper Dangaard Brouer
>> Date: Tue, 3 Apr 2018 18:07:16 +0200
>>> On Tue, 03 Apr 2018 10:54:27 -0400 (EDT)
>>> David Miller wrote:
>>>
Don't worry, just resubmit when net-next opens
Hello,
I’ve encountered an issue when using BPF_PROG_TEST_RUN and capturing the output.
The kernel copies data into user space without checking the length of
the destination buffer.
In bpf_test_finish(), size is the amount of data in the XDP buffer /
skb after the program is run. This can be larg
On 04/02/2018 09:58 PM, John Fastabend wrote:
> On 04/02/2018 12:50 PM, John Fastabend wrote:
>> If a socket with pending cork data is closed we do not return the
>> memory to the socket until the garbage collector free's the psock
>> structure. The garbage collector though can run after the sock h
On 04-04-18 09:22, Jarkko Nikula wrote:
Hi
Today's head and linux-next doesn't compile due commit 9217e566bdee ("of_net:
Implement of_get_nvmem_mac_address helper"):
drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
.../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cel
On 04/03/2018 02:09 PM, Anders Roxell wrote:
> There will be a build warning -Wunused-function if CONFIG_CGROUP_BPF
> isn't defined, since the only user is inside #ifdef CONFIG_CGROUP_BPF:
> kernel/bpf/syscall.c:1229:12: warning: ‘bpf_prog_attach_check_attach_type’
> defined but not used [-Wunu
When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE
is 65536(64K). But the type of length is u16, it will overflow. So change it
to u32.
Signed-off-by: Tan Xiaojun
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Given the merge window is open right now, please only submit bug
fixes to bpf tree at this time, thank you!
2018-04-03 16:25 GMT+02:00 David Lebrun :
> Actually I'm wrong here. dst_input() will call either ip6_input() or
> ip6_forward(), not ipv6_rcv(). Both functions expect IP6CB() to be set,
> so using skb->cb here will interfere with them.
>
> What about saving and restoring the IPv6 CB, similarly to
On 04/04/2018 11:04 AM, Lorenz Bauer wrote:
> Hello,
>
> I’ve encountered an issue when using BPF_PROG_TEST_RUN and capturing the
> output.
> The kernel copies data into user space without checking the length of
> the destination buffer.
>
> In bpf_test_finish(), size is the amount of data in th
On Wed, 28 Mar 2018, Yuchung Cheng wrote:
> On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen
> wrote:
> > When a cumulative ACK lands to high_seq at the end of loss
> > recovery and SACK is not enabled, the sender needs to avoid
> > false fast retransmits (RFC6582). The avoidance mechanisms is
> >
On Wed, 28 Mar 2018, Yuchung Cheng wrote:
> On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen
> wrote:
> >
> > If SACK is not enabled and the first cumulative ACK after the RTO
> > retransmission covers more than the retransmitted skb, a spurious
> > FRTO undo will trigger (assuming FRTO is enabled
The new of_get_nvmem_mac_address() helper function causes a link error
with CONFIG_NVMEM=m:
drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
of_net.c:(.text+0x168): undefined reference to `of_nvmem_cell_get'
of_net.c:(.text+0x19c): undefined reference to `nvmem_cell_read'
of_net.c:(.te
On Wed, 28 Mar 2018, Yuchung Cheng wrote:
> On Wed, Mar 28, 2018 at 7:14 AM, Yuchung Cheng wrote:
> >
> > On Wed, Mar 28, 2018 at 5:45 AM, Ilpo Järvinen
> > wrote:
> > > On Tue, 27 Mar 2018, Yuchung Cheng wrote:
> > >
> > >> On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen
> > >> wrote:
> > >> >
On 3/31/2018 8:21 PM, David Ahern wrote:
On 3/31/18 9:53 AM, Andrew Lunn wrote:
I want to be able to login to a customer and accessing this snapshot
without any previous configuration from the user and not asking for
enabling the feature and then waiting for a repro...this will help
debugging
After 03fe2debbb2771fb90881e merged during 4.17 marge window,
I start to see following warning during "make xmldocs"
./include/net/mac80211.h:2083: warning: bad line: >
Replace ">" with "*" fix the issue.
Signed-off-by: Masanari Iida
---
include/net/mac80211.h | 2 +-
1 file changed, 1 insert
The __net_initdata section cannot currently be used for structures that
get cleaned up in an exitcall using unregister_pernet_operations:
WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the
function nsim_devlink_exit() to the (unknown reference) .init.data:(unknown)
The fun
Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON
support for tc-actions at the expense of breaking other use cases that
reach tc_print_action(), as the latter don't expect the 'actions' array
to be a new object.
Consider the following taken duringrun of tc_chain.sh selftest,
a
After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates
done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6:
factorize sk_wmem_alloc updates done by __ip6_append_data()"),
when transmitting sub MTU datagram, an addtional, unneeded atomic
operation is performed in ip*_append_data()
On Sun, 2018-04-01 at 20:31 +0200, Anton Gary Ceph wrote:
> After a few profiling and analysis, turned out that the ethertype field
> of the packets has the following distribution:
[...]
> 0.6% don't know/no opinion
Am I the only one finding the submission date and the above info
suspicious ?
> I hear you. It is more complicated this way...having all these individual
> objects vs just a single "bundle" of them that represents a NIC. But, that's
> the way the DPAA2 hardware is, and we're implementing kernel support for
> the hardware as it is.
Hi Stuart
I see we are not making any pr
To fetch UID info for socket diagnostics, we determine the
namespace of user context using tipc socket instance. This
may cause namespace violation, as the kernel will remap based
on UID.
We fix this by fetching namespace info using the calling userspace
netlink socket.
Fixes: c30b70deb5f4 (tipc:
On 03/04/2018 2:08 PM, Jesper Dangaard Brouer wrote:
This patch shows how it is possible to have both the driver local page
cache, which uses elevated refcnt for "catching"/avoiding SKB
put_page returns the page through the page allocator. And at the
same time, have pages getting returned to t
On Tue, Apr 3, 2018 at 2:43 PM, Alexey Kodanev
wrote:
> With TCP Fastopen we can have the following cases, which could also
> use MSG_ZEROCOPY flag with send() and sendto():
>
> * sendto() + MSG_FASTOPEN flag, sk state can be in TCP_CLOSE at
> the start of tcp_sendmsg()
>
> * set socket option T
On 04/04/2018 05:30 AM, Paolo Abeni wrote:
> After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates
> done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6:
> factorize sk_wmem_alloc updates done by __ip6_append_data()"),
> when transmitting sub MTU datagram, an addtional, unneed
Like tos inherit, ttl inherit should also means inherit the inner protocol's
ttl values, which actually not implemented in vxlan yet.
But we could not treat ttl == 0 as "use the inner TTL", because that would be
used also when the "ttl" option is not specified and that would be a behavior
change,
For making things build again:
Acked-by: Mike Looijmans
I'd be interested in use-cases for having nvmem as a module, I cannot think of
any.
I am working on splitting of_get_nvmem_mac_address(), by moving most of its
burden to the nvmem interface. Intend to create this "just give me my bytes
On Wed, 4 Apr 2018 16:12:14 +0300
Tariq Toukan wrote:
> > @@ -432,9 +434,12 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,
> >
> > rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE;
> > rq->buff.headroom = mlx5e_get_rq_headroom(mdev, params);
> > + pool_siz
On Wed, Apr 4, 2018 at 3:32 PM, Mike Looijmans wrote:
>
> Which may still be very confusing, since it means that CONFIG_MACB=y with
> CONFIG_NVMEM=m will fail, but setting both to "y" or both to "m" will work.
> So that would introduce more build failures again, right?
Right, it would require ha
On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote:
> Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
> casues the ring to get corrupted by allowing multiple kernel threads
> to claim ownership of the same ring entry, Mark the ring entry as
> already being used within the spin_lo
> > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> > index e0f3f4a..264d7b2 100644
> > --- a/net/packet/af_packet.c
> > +++ b/net/packet/af_packet.c
> > @@ -2287,6 +2287,15 @@ static int tpacket_rcv(struct sk_buff *skb, struct
> > net_device *dev,
> > if (po->stats.st
On Tue, Apr 3, 2018 at 6:51 PM, João Paulo Rechi Vita wrote:
>
> This are the results (testing with speedtest.net) I got at some key points:
>
> VersionCommitPingDownUp
>
> v4.11a351e9b1225.445.99
> v4.11a351e9b
On Wednesday, April 04, 2018 9:49 AM, Willem de Bruijn
wrote:
>
> On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote:
> > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
> > casues the ring to get corrupted by allowing multiple kernel threads
> > to claim ownership of the same
From: David Howells
Date: Mon, 02 Apr 2018 23:51:39 +0100
> By analogy with other Rx implementations, RxRPC packet types 9, 10 and 11
> should just be discarded rather than being aborted like other undefined
> packet types.
>
> Reported-by: Jeffrey Altman
> Signed-off-by: David Howells
Applie
From: Florian Fainelli
Date: Mon, 2 Apr 2018 15:58:54 -0700
> This patch series fixes the same warning reported by sparse in bcmsysport and
> bcmgenet in the code that deals with inserting the TX checksum pointers:
>
> drivers/net/ethernet/broadcom/bcmsysport.c:1155:26: warning: cast from
> re
From: Cong Wang
Date: Mon, 2 Apr 2018 11:01:27 -0700
> After commit 581319c58600 ("net/socket: use per af lockdep classes for sk
> queues")
> sock queue locks now have per-af lockdep classes, including unix socket.
> It is no longer necessary to workaround it.
>
> I noticed this while looking
From: Florian Fainelli
Date: Mon, 2 Apr 2018 16:24:14 -0700
> We would be passing 0 instead of NULL as the rsp argument to
> mt7530_fdb_cmd(), fix that.
>
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530
> switch")
> Signed-off-by: Florian Fainelli
Applied.
From: Florian Fainelli
Date: Mon, 2 Apr 2018 16:17:01 -0700
> sparse complains about the following warnings:
>
> drivers/net/dsa/b53/b53_mmap.c:33:31: warning: incorrect type in
> initializer (different address spaces)
> drivers/net/dsa/b53/b53_mmap.c:33:31:expected unsigned char
> [noderef
From: Eric Dumazet
Date: Mon, 2 Apr 2018 18:48:37 -0700
> Once dst has been cached in socket via sk_setup_caps(),
> it is illegal to call ip_rt_put() (or dst_release()),
> since sk_setup_caps() did not change dst refcount.
>
> We can still dereference it since we hold socket lock.
>
> Caugth b
From: Russell King
Date: Tue, 03 Apr 2018 10:31:45 +0100
> Add a thermal monitoring device for the Marvell 88x3310, which updates
> once a second. We also need to hook into the suspend/resume mechanism
> to ensure that the thermal monitoring is reconfigured when we resume.
>
> Suggested-by: And
On Mon, 2018-04-02 at 09:40 -0400, Vladislav Yasevich wrote:
> Since we now have support for software CRC32c offload, turn it on
> for macvlan and macvtap devices so that guests can take advantage
> of offload SCTP checksums to the host or host hardware.
>
> Signed-off-by: Vladislav Yasevich
> --
From: Alexey Kodanev
Date: Tue, 3 Apr 2018 15:00:06 +0300
> A new RTF_CACHE route can be created with the socket's dst cache
> update between the below calls in udpv6_sendmsg(), when datagram
> sending results to ICMPV6_PKT_TOOBIG error:
>
>dst = ip6_sk_dst_lookup_flow(...)
>...
> relea
From: Jon Maloy
Date: Tue, 3 Apr 2018 19:11:19 +0200
> When an item of struct tipc_subscription is created, we fail to
> initialize the two lists aggregated into the struct. This has so far
> never been a problem, since the items are just added to a root
> object by list_add(), which does not req
On 4/4/18 6:12 AM, Arnd Bergmann wrote:
> The __net_initdata section cannot currently be used for structures that
> get cleaned up in an exitcall using unregister_pernet_operations:
>
> WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the
> function nsim_devlink_exit() to th
Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches,
since linker might place next to it a non zero value preventing a change
to ip6frag_low_thresh.
ip6frag_low_thresh is not used anymore in the kernel, but we do not
want to prematuraly break user scripts wanting to change i
From: Jakub Kicinski
Date: Mon, 2 Apr 2018 13:31:20 -0700
> We are currently counting packets with CHECKSUM_COMPLETE as
> "hw_rx_csum_ok". This is confusing. Add a new counter.
> To make sure it fits in the same cacheline move the less used
> error counter to a different location.
>
> Signed-
On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso wrote:
> One module per supported filter chain family type takes too much memory
> for very little code - too much modularization - place all chain filter
> definitions in one single file.
>
> Signed-off-by: Pablo Neira Ayuso
Hi Pablo,
I've bis
On 04/04/2018 08:35 AM, Eric Dumazet wrote:
> Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches,
> since linker might place next to it a non zero value preventing a change
> to ip6frag_low_thresh.
>
> ip6frag_low_thresh is not used anymore in the kernel, but we do not
>
The ctpio_dmabuf_start entry is not actually a stat and shouldn't
be exposed to ethtool.
Fixes: 2c0b6ee837db ("sfc: expose CTPIO stats on NICs that support
them")
Signed-off-by: Bert Kenward
---
drivers/net/ethernet/sfc/ef10.c | 2 --
drivers/net/ethernet/sfc/nic.h | 1 -
2 files changed, 3 del
On Wed, Apr 4, 2018 at 5:33 PM, David Ahern wrote:
> On 4/4/18 6:12 AM, Arnd Bergmann wrote:
>> The __net_initdata section cannot currently be used for structures that
>> get cleaned up in an exitcall using unregister_pernet_operations:
>>
>
> I am confused ... I do the same thing in the VRF driv
From: Alexander Graf
Date: Wed, 4 Apr 2018 00:19:35 +0200
> When using wicked with a lan78xx device attached to the system, we
> end up with ethtool commands issued on the device before an ifup
> got issued. That lead to the following crash:
>
...
> The culprit is quite simple: The driver trie
From: Jakub Kicinski
Date: Tue, 3 Apr 2018 17:24:23 -0700
> From: Dirk van der Merwe
>
> The NSP default buffer is a piece of NFP memory where additional
> command data can be placed. Its format has been copied from
> host buffer, but the PCIe selection bits do not make sense in
> this case.
- Original Message -
> Here's a second version of the patch (now a patch set) to eliminate
> rhashtable_walk_peek in gfs2.
>
> The first patch introduces lockref_put_not_zero, the inverse of
> lockref_get_not_zero.
>
> The second patch eliminates rhashtable_walk_peek in gfs2. In
> gfs2_g
From: Tan Xiaojun
Date: Wed, 4 Apr 2018 17:40:48 +0800
> When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE
> is 65536(64K). But the type of length is u16, it will overflow. So change it
> to u32.
>
> Signed-off-by: Tan Xiaojun
Applied, thanks.
On Wed, Apr 04, 2018 at 05:38:31PM +0200, Arnd Bergmann wrote:
> On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso
> wrote:
> > One module per supported filter chain family type takes too much memory
> > for very little code - too much modularization - place all chain filter
> > definitions in o
From: Arnd Bergmann
Date: Wed, 4 Apr 2018 12:38:40 +0200
> The new of_get_nvmem_mac_address() helper function causes a link error
> with CONFIG_NVMEM=m:
>
> drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
> of_net.c:(.text+0x168): undefined reference to `of_nvmem_cell_get'
> of_net
From: Masanari Iida
Date: Wed, 4 Apr 2018 20:53:33 +0900
> After 03fe2debbb2771fb90881e merged during 4.17 marge window,
> I start to see following warning during "make xmldocs"
>
> ./include/net/mac80211.h:2083: warning: bad line: >
>
> Replace ">" with "*" fix the issue.
>
> Signed-off-by:
On Wed, Apr 04, 2018 at 11:46:28AM -0400, Bob Peterson wrote:
>
> The patches look good. The big question is whether to add them to this
> merge window while it's still open. Opinions?
We're still hashing out the rhashtable interface so I don't think
now is the time to rush things.
Thanks,
--
Em
On Wed, Apr 4, 2018 at 5:46 PM, Pablo Neira Ayuso wrote:
> On Wed, Apr 04, 2018 at 05:38:31PM +0200, Arnd Bergmann wrote:
>> On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso
>> wrote:
>> > One module per supported filter chain family type takes too much memory
>> > for very little code - too m
From: Arnd Bergmann
Date: Wed, 4 Apr 2018 14:12:39 +0200
> The __net_initdata section cannot currently be used for structures that
> get cleaned up in an exitcall using unregister_pernet_operations:
>
> WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the
> function nsim_
From: Paolo Abeni
Date: Wed, 4 Apr 2018 14:30:01 +0200
> After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates
> done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6:
> factorize sk_wmem_alloc updates done by __ip6_append_data()"),
> when transmitting sub MTU datagram, an addt
From: GhantaKrishnamurthy MohanKrishna
Date: Wed, 4 Apr 2018 14:49:47 +0200
> To fetch UID info for socket diagnostics, we determine the
> namespace of user context using tipc socket instance. This
> may cause namespace violation, as the kernel will remap based
> on UID.
>
> We fix this by fetc
Al Viro writes:
> On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote:
>
>> FWIW, I'm going through the ->kill_sb() instances, fixing that sort
>> of bugs (most of them preexisting, but I should've checked instead
>> of assuming that everything's fine). Will push out later tonight.
>
> OK, s
From: Hangbin Liu
Date: Wed, 4 Apr 2018 21:26:21 +0800
> Like tos inherit, ttl inherit should also means inherit the inner protocol's
> ttl values, which actually not implemented in vxlan yet.
>
> But we could not treat ttl == 0 as "use the inner TTL", because that would be
> used also when the
From: Eric Dumazet
Date: Wed, 4 Apr 2018 08:35:10 -0700
> Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches,
> since linker might place next to it a non zero value preventing a change
> to ip6frag_low_thresh.
>
> ip6frag_low_thresh is not used anymore in the kernel, but
On Wed, Apr 4, 2018 at 5:52 PM, David Miller wrote:
> From: Arnd Bergmann
> Date: Wed, 4 Apr 2018 14:12:39 +0200
>
>> The __net_initdata section cannot currently be used for structures that
>> get cleaned up in an exitcall using unregister_pernet_operations:
>>
>> WARNING: vmlinux.o(.text+0x868c
Therefore, please submit bug fixes relative to 'net', thank you.
From: Bert Kenward
Date: Wed, 4 Apr 2018 16:40:30 +0100
> The ctpio_dmabuf_start entry is not actually a stat and shouldn't
> be exposed to ethtool.
>
> Fixes: 2c0b6ee837db ("sfc: expose CTPIO stats on NICs that support
> them")
Please don't break up a long Fixes tag line into multiple lines.
On Wed, Apr 4, 2018 at 6:35 AM Ilpo Järvinen
wrote:
> On Wed, 28 Mar 2018, Yuchung Cheng wrote:
> > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen
> > wrote:
> > >
> > > If SACK is not enabled and the first cumulative ACK after the RTO
> > > retransmission covers more than the retransmitted skb
On 4/3/2018 2:16 PM, Alexander Duyck wrote:
This change makes it so that we use a software path for packets that are
going to be locally switched between two macvlan interfaces on the same
device. In addition we resort to software replication of broadcast and
multicast packets instead of offloadi
On 4/3/2018 2:16 PM, Alexander Duyck wrote:
[...]
+static inline void *macvlan_accel_priv(struct net_device *dev)
+{
+ struct macvlan_dev *macvlan = netdev_priv(dev);
+
+ return macvlan->accel_priv;
Perhaps a check for (macvlan == NULL) before using it?
sln
+}
#endif /* _LIN
From: Arnd Bergmann
Date: Wed, 4 Apr 2018 18:03:41 +0200
> On Wed, Apr 4, 2018 at 5:52 PM, David Miller wrote:
>> From: Arnd Bergmann
>> Date: Wed, 4 Apr 2018 14:12:39 +0200
>>
>>> The __net_initdata section cannot currently be used for structures that
>>> get cleaned up in an exitcall using u
On Wed, Apr 4, 2018 at 9:53 AM, Shannon Nelson
wrote:
> On 4/3/2018 2:16 PM, Alexander Duyck wrote:
>>
>> This change makes it so that we use a software path for packets that are
>> going to be locally switched between two macvlan interfaces on the same
>> device. In addition we resort to software
On 4/4/18 4:13 AM, Miguel Fadon Perlines wrote:
> arp_filter performs an ip_route_output search for arp source address and
>
> checks if output device is the same where the arp request was received,
>
> if it is not, the arp request is not answered.
>
>
>
> This route lookup is always done on
On Wed, Apr 4, 2018 at 9:33 AM, Neal Cardwell wrote:
>
> On Wed, Apr 4, 2018 at 6:35 AM Ilpo Järvinen
> wrote:
>
> > On Wed, 28 Mar 2018, Yuchung Cheng wrote:
>
> > > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen
> > > wrote:
> > > >
> > > > If SACK is not enabled and the first cumulative ACK a
On 4/4/18 6:24 AM, Yuval Mintz wrote:
> Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON
> support for tc-actions at the expense of breaking other use cases that
> reach tc_print_action(), as the latter don't expect the 'actions' array
> to be a new object.
>
> Consider the fo
On Wed, Apr 4, 2018 at 6:42 AM Ilpo Järvinen
wrote:
> On Wed, 28 Mar 2018, Yuchung Cheng wrote:
...
> > Your patch looks good. Some questions / comments:
The patch looks good to me as well (I read the Mar 28 version). Thanks for
this fix, Ilpo.
> Just to be sure that we understand each other th
Signed-off-by: Roman Mashak
---
tc/m_tunnel_key.c | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/tc/m_tunnel_key.c b/tc/m_tunnel_key.c
index bac3c07fa90b..0fa461549ad9 100644
--- a/tc/m_tunnel_key.c
+++ b/tc/m_tunnel_key.c
@@ -221,7 +221
On 4/4/18 1:36 AM, Siwei Liu wrote:
> On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote:
>> On 4/3/18 9:42 AM, Jiri Pirko wrote:
There are other use cases that want to hide a device from userspace. I
>>>
>>> What usecases do you have in mind?
>>
>> As mentioned in a previous response som
n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote:
> Agreed. That's a good point. And I would much preferred to rename that
> to FLAG_ORIG_PROGRESS (w/ updated comment).
> so I think we're in agreement to use existing patch w/ the new name
> FLAG_ORIG_PROGRESS
Yes, SGTM.
I guess this "prevent b
On Wed, Apr 4, 2018 at 9:53 AM, Shannon Nelson
wrote:
> On 4/3/2018 2:16 PM, Alexander Duyck wrote:
>
> [...]
>>
>> +static inline void *macvlan_accel_priv(struct net_device *dev)
>> +{
>> + struct macvlan_dev *macvlan = netdev_priv(dev);
>> +
>> + return macvlan->accel_priv;
>
>
> P
From: David Ahern
Date: Wed, 4 Apr 2018 11:21:54 -0600
> It is a netdev so there is no reason to have a separate ip command to
> inspect it. 'ip link' is the right place.
I agree on this.
What I really don't understand still is the use case... really.
So there are control netdevs, what exactly
[ dropping virtio-...@lists.oasis-open.org since it is a closed list and
I am tired of deleting bounces ]
On 4/4/18 2:28 AM, Siwei Liu wrote:
> On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote:
>> On 4/3/18 9:42 AM, Jiri Pirko wrote:
There are other use cases that want to hide a device
On Wed, Apr 4, 2018 at 10:22 AM, Neal Cardwell wrote:
> n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote:
>> Agreed. That's a good point. And I would much preferred to rename that
>> to FLAG_ORIG_PROGRESS (w/ updated comment).
>
>> so I think we're in agreement to use existing patch w/ the new n
From: David Ahern
Date: Wed, 4 Apr 2018 11:37:52 -0600
> Networking vendors have out of tree kernel modules. Those modules use a
> netdev (call it a master netdev, a control netdev, cpu port, whatever)
> to pull packets from the ASIC and deliver to virtual netdevices
> representing physical ports
On Wed, 4 Apr 2018 11:37:52 -0600
David Ahern wrote:
> Networking vendors have out of tree kernel modules. Those modules use a
> netdev (call it a master netdev, a control netdev, cpu port, whatever)
> to pull packets from the ASIC and deliver to virtual netdevices
> representing physical ports.
On Wed, Apr 4, 2018 at 1:41 PM Yuchung Cheng wrote:
> On Wed, Apr 4, 2018 at 10:22 AM, Neal Cardwell
wrote:
> > n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote:
> >> Agreed. That's a good point. And I would much preferred to rename that
> >> to FLAG_ORIG_PROGRESS (w/ updated comment).
> >
> >
This fixes some fallout from the net-next merge the other day, plus
some non-merge-window-related bug fixes:
1) Fix sparse warnings in bcmgenet,systemport, b53, and mt7530, from
Florian Fainelli.
2) pptp does a bogus dst_release() on a route we have a single refcount
on, and attached to a
On Wed, Apr 4, 2018 at 10:21 AM, David Ahern wrote:
> On 4/4/18 1:36 AM, Siwei Liu wrote:
>> On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote:
>>> On 4/3/18 9:42 AM, Jiri Pirko wrote:
>
> There are other use cases that want to hide a device from userspace. I
What usecases do yo
Wed, Apr 04, 2018 at 07:37:49PM CEST, da...@davemloft.net wrote:
>From: David Ahern
>Date: Wed, 4 Apr 2018 11:21:54 -0600
>
>> It is a netdev so there is no reason to have a separate ip command to
>> inspect it. 'ip link' is the right place.
>
>I agree on this.
>
>What I really don't understand st
On Wed, Apr 4, 2018 at 7:08 AM, Cong Wang wrote:
> On Tue, Apr 3, 2018 at 4:42 AM, Kirill Tkhai wrote:
>> On 03.04.2018 14:25, Dmitry Vyukov wrote:
>>> On Tue, Apr 3, 2018 at 11:50 AM, Kirill Tkhai wrote:
sk_diag_dump_icons() dumps only sockets in TCP_LISTEN state.
TCP_LISTEN state may
commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces")
enabled sending hotplug events into all network namespaces back in 2010.
Over time the set of uevents that get sent into all network namespaces has
shrunk. We have now reached the point where hotplug events for all devi
Ulf Hansson writes:
> On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>> Hi,
>>
>> This serie is aimed at removing the dmaengine slave compat use, and transfer
>> knowledge of the DMA requestors into architecture code.
>> As this looks like a patch bomb, each maintainer expressing for his tree
On Wed, 04 Apr 2018 21:49:26 +0200
Robert Jarzmik wrote:
> Ulf Hansson writes:
>
> > On 2 April 2018 at 16:26, Robert Jarzmik wrote:
> >> Hi,
> >>
> >> This serie is aimed at removing the dmaengine slave compat use, and
> >> transfer
> >> knowledge of the DMA requestors into architecture co
1 - 100 of 143 matches
Mail list logo
